rubocop 0.71.0 → 0.72.0

data/lib/rubocop.rb

@@ -27,6 +27,7 @@ require_relative 'rubocop/ast/node/mixin/conditional_node'
 require_relative 'rubocop/ast/node/mixin/hash_element_node'
 require_relative 'rubocop/ast/node/mixin/method_dispatch_node'
 require_relative 'rubocop/ast/node/mixin/modifier_node'
+require_relative 'rubocop/ast/node/mixin/numeric_node'
 require_relative 'rubocop/ast/node/mixin/parameterized_node'
 require_relative 'rubocop/ast/node/mixin/predicate_operator_node'
 require_relative 'rubocop/ast/node/mixin/basic_literal_node'
@@ -42,8 +43,10 @@ require_relative 'rubocop/ast/node/def_node'
 require_relative 'rubocop/ast/node/defined_node'
 require_relative 'rubocop/ast/node/ensure_node'
 require_relative 'rubocop/ast/node/for_node'
+require_relative 'rubocop/ast/node/float_node'
 require_relative 'rubocop/ast/node/hash_node'
 require_relative 'rubocop/ast/node/if_node'
+require_relative 'rubocop/ast/node/int_node'
 require_relative 'rubocop/ast/node/keyword_splat_node'
 require_relative 'rubocop/ast/node/module_node'
 require_relative 'rubocop/ast/node/or_node'
@@ -148,7 +151,6 @@ require_relative 'rubocop/cop/mixin/statement_modifier'
 require_relative 'rubocop/cop/mixin/string_help'
 require_relative 'rubocop/cop/mixin/string_literals_help'
 require_relative 'rubocop/cop/mixin/target_ruby_version'
-require_relative 'rubocop/cop/mixin/target_rails_version'
 require_relative 'rubocop/cop/mixin/too_many_lines'
 require_relative 'rubocop/cop/mixin/trailing_body'
 require_relative 'rubocop/cop/mixin/trailing_comma'
@@ -179,6 +181,7 @@ require_relative 'rubocop/cop/bundler/ordered_gems'
 require_relative 'rubocop/cop/gemspec/duplicated_assignment'
 require_relative 'rubocop/cop/gemspec/ordered_dependencies'
 require_relative 'rubocop/cop/gemspec/required_ruby_version'
+require_relative 'rubocop/cop/gemspec/ruby_version_globals_usage'
 
 require_relative 'rubocop/cop/layout/access_modifier_indentation'
 require_relative 'rubocop/cop/layout/align_arguments'
@@ -425,6 +428,7 @@ require_relative 'rubocop/cop/style/end_block'
 require_relative 'rubocop/cop/style/eval_with_location'
 require_relative 'rubocop/cop/style/even_odd'
 require_relative 'rubocop/cop/style/expand_path_arguments'
+require_relative 'rubocop/cop/style/float_division'
 require_relative 'rubocop/cop/style/for'
 require_relative 'rubocop/cop/style/format_string'
 require_relative 'rubocop/cop/style/format_string_token'
@@ -547,58 +551,6 @@ require_relative 'rubocop/cop/style/word_array'
 require_relative 'rubocop/cop/style/yoda_condition'
 require_relative 'rubocop/cop/style/zero_length_predicate'
 
-require_relative 'rubocop/cop/rails/action_filter'
-require_relative 'rubocop/cop/rails/active_record_aliases'
-require_relative 'rubocop/cop/rails/active_record_override'
-require_relative 'rubocop/cop/rails/active_support_aliases'
-require_relative 'rubocop/cop/rails/application_job'
-require_relative 'rubocop/cop/rails/application_record'
-require_relative 'rubocop/cop/rails/assert_not'
-require_relative 'rubocop/cop/rails/belongs_to'
-require_relative 'rubocop/cop/rails/blank'
-require_relative 'rubocop/cop/rails/bulk_change_table'
-require_relative 'rubocop/cop/rails/create_table_with_timestamps'
-require_relative 'rubocop/cop/rails/date'
-require_relative 'rubocop/cop/rails/delegate'
-require_relative 'rubocop/cop/rails/delegate_allow_blank'
-require_relative 'rubocop/cop/rails/dynamic_find_by'
-require_relative 'rubocop/cop/rails/enum_uniqueness'
-require_relative 'rubocop/cop/rails/environment_comparison'
-require_relative 'rubocop/cop/rails/exit'
-require_relative 'rubocop/cop/rails/file_path'
-require_relative 'rubocop/cop/rails/find_by'
-require_relative 'rubocop/cop/rails/find_each'
-require_relative 'rubocop/cop/rails/has_and_belongs_to_many'
-require_relative 'rubocop/cop/rails/has_many_or_has_one_dependent'
-require_relative 'rubocop/cop/rails/http_positional_arguments'
-require_relative 'rubocop/cop/rails/http_status'
-require_relative 'rubocop/cop/rails/ignored_skip_action_filter_option'
-require_relative 'rubocop/cop/rails/inverse_of'
-require_relative 'rubocop/cop/rails/lexically_scoped_action_filter'
-require_relative 'rubocop/cop/rails/link_to_blank'
-require_relative 'rubocop/cop/rails/not_null_column'
-require_relative 'rubocop/cop/rails/output'
-require_relative 'rubocop/cop/rails/output_safety'
-require_relative 'rubocop/cop/rails/pluralization_grammar'
-require_relative 'rubocop/cop/rails/presence'
-require_relative 'rubocop/cop/rails/present'
-require_relative 'rubocop/cop/rails/read_write_attribute'
-require_relative 'rubocop/cop/rails/redundant_allow_nil'
-require_relative 'rubocop/cop/rails/redundant_receiver_in_with_options'
-require_relative 'rubocop/cop/rails/reflection_class_name'
-require_relative 'rubocop/cop/rails/refute_methods'
-require_relative 'rubocop/cop/rails/relative_date_constant'
-require_relative 'rubocop/cop/rails/request_referer'
-require_relative 'rubocop/cop/rails/reversible_migration'
-require_relative 'rubocop/cop/rails/safe_navigation'
-require_relative 'rubocop/cop/rails/save_bang'
-require_relative 'rubocop/cop/rails/scope_args'
-require_relative 'rubocop/cop/rails/skips_model_validations'
-require_relative 'rubocop/cop/rails/time_zone'
-require_relative 'rubocop/cop/rails/uniq_before_pluck'
-require_relative 'rubocop/cop/rails/unknown_env'
-require_relative 'rubocop/cop/rails/validation'
-
 require_relative 'rubocop/cop/security/eval'
 require_relative 'rubocop/cop/security/json_load'
 require_relative 'rubocop/cop/security/marshal_load'

data/lib/rubocop/ast/builder.rb

@@ -28,8 +28,10 @@ module RuboCop
         defs:       DefNode,
         ensure:     EnsureNode,
         for:        ForNode,
+        float:      FloatNode,
         hash:       HashNode,
         if:         IfNode,
+        int:        IntNode,
         irange:     RangeNode,
         erange:     RangeNode,
         kwsplat:    KeywordSplatNode,

data/lib/rubocop/ast/node.rb

@@ -405,7 +405,7 @@ module RuboCop
               receiver.send(recursive_kind) &&
               arguments.all?(&recursive_kind)
           when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
-            children.all?(&recursive_kind)
+            children.compact.all?(&recursive_kind)
           else
             send(kind_filter)
           end

data/lib/rubocop/ast/node/float_node.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `float` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available to
+    # all `float` nodes within RuboCop.
+    class FloatNode < Node
+      include NumericNode
+    end
+  end
+end

data/lib/rubocop/ast/node/int_node.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `int` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available to
+    # all `int` nodes within RuboCop.
+    class IntNode < Node
+      include NumericNode
+    end
+  end
+end

data/lib/rubocop/ast/node/mixin/numeric_node.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # Common functionality for primitive numeric nodes: `int`, `float`, ...
+    module NumericNode
+      SIGN_REGEX = /\A[+-]/.freeze
+
+      # Checks whether this is literal has a sign.
+      #
+      # @example
+      #
+      #   +42
+      #
+      # @return [Boolean] whether this literal has a sign.
+      def sign?
+        source.match(SIGN_REGEX)
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/resbody_node.rb

@@ -17,12 +17,7 @@ module RuboCop
       #
       # @return [Node, nil] The exception variable of the `resbody`.
       def exception_variable
-        variable = node_parts[1]
-        return variable if variable
-
-        # When resbody is an implicit rescue (i.e. `rescue e` style),
-        # the exception variable is descendants[1].
-        descendants[1]
+        node_parts[1]
       end
     end
   end

data/lib/rubocop/cached_data.rb

@@ -38,7 +38,7 @@ module RuboCop
     def message(offense)
       # JSON.dump will fail if the offense message contains text which is not
       # valid UTF-8
-      offense.message.scrub
+      offense.message.dup.force_encoding(::Encoding::UTF_8).scrub
     end
 
     # Restore an offense object loaded from a JSON file.

data/lib/rubocop/config.rb

@@ -229,6 +229,16 @@ module RuboCop
       }
     ].freeze
 
+    OBSOLETE_ENFORCED_STYLES = [
+      {
+        cop: 'Layout/IndentationConsistency',
+        parameter: 'EnforcedStyle',
+        enforced_style: 'rails',
+        alternative: '`EnforcedStyle: rails` has been renamed to ' \
+                     '`EnforcedStyle: indented_internal_methods`'
+      }
+    ].freeze
+
     attr_reader :loaded_path
 
     def initialize(hash = {}, loaded_path = nil)
@@ -565,7 +575,8 @@ module RuboCop
     def reject_obsolete_cops_and_parameters
       messages = [
         obsolete_cops,
-        obsolete_parameters
+        obsolete_parameters,
+        obsolete_enforced_style
       ].flatten.compact
       return if messages.empty?
 
@@ -596,17 +607,35 @@ module RuboCop
       end
     end
 
+    def obsolete_enforced_style
+      OBSOLETE_ENFORCED_STYLES.map do |params|
+        obsolete_enforced_style_message(params[:cop], params[:parameter],
+                                        params[:enforced_style],
+                                        params[:alternative])
+      end
+    end
+
+    def obsolete_enforced_style_message(cop, param, enforced_style, alternative)
+      style = self[cop]&.detect { |key, _| key.start_with?(param) }
+
+      return unless style && style[1] == enforced_style
+
+      "obsolete `#{param}: #{enforced_style}` (for #{cop}) " \
+        "found in #{smart_loaded_path}" \
+        "\n#{alternative}"
+    end
+
     def check_target_ruby
       return if KNOWN_RUBIES.include?(target_ruby_version)
 
       msg = if OBSOLETE_RUBIES.include?(target_ruby_version)
-              "Unsupported Ruby version #{target_ruby_version} found in " \
-              "#{target_ruby_source}. #{target_ruby_version}-compatible " \
+              "RuboCop found unsupported Ruby version #{target_ruby_version} " \
+              "in #{target_ruby_source}. #{target_ruby_version}-compatible " \
               'analysis was dropped after version ' \
               "#{OBSOLETE_RUBIES[target_ruby_version]}."
             else
-              "Unknown Ruby version #{target_ruby_version.inspect} found in " \
-              "#{target_ruby_source}."
+              'RuboCop found unknown Ruby version ' \
+              "#{target_ruby_version.inspect} in #{target_ruby_source}."
             end
 
       msg += "\nSupported versions: #{KNOWN_RUBIES.join(', ')}"

data/lib/rubocop/config_loader.rb

@@ -144,10 +144,6 @@ module RuboCop
         puts "Added inheritance from `#{AUTO_GENERATED_FILE}` in `#{DOTFILE}`."
       end
 
-      def required_features
-        resolver.required_features
-      end
-
       private
 
       def find_project_dotfile(target_dir)
@@ -177,8 +173,8 @@ module RuboCop
 
       def existing_configuration(config_file)
         IO.read(config_file, encoding: Encoding::UTF_8)
-          .sub(%r{^inherit_from: *[.\/\w]+}, '')
-          .sub(%r{^inherit_from: *(\n *- *[.\/\w]+)+}, '')
+          .sub(/^inherit_from: *[^\n]+/, '')
+          .sub(/^inherit_from: *(\n *- *[^\n]+)+/, '')
       end
 
       def write_config_file(file_name, file_string, rubocop_yml_contents)

data/lib/rubocop/config_loader_resolver.rb

@@ -6,17 +6,9 @@ require 'pathname'
 module RuboCop
   # A help class for ConfigLoader that handles configuration resolution.
   class ConfigLoaderResolver
-    attr_reader :required_features
-
-    def initialize
-      @required_features = []
-    end
-
     def resolve_requires(path, hash)
       config_dir = File.dirname(path)
       Array(hash.delete('require')).each do |r|
-        @required_features << r
-
         if r.start_with?('.')
           require(File.join(config_dir, r))
         else
@@ -172,12 +164,6 @@ module RuboCop
     def handle_disabled_by_default(config, new_default_configuration)
       department_config = config.to_hash.reject { |cop| cop.include?('/') }
       department_config.each do |dept, dept_params|
-        # Rails is always disabled by default and the department's Enabled flag
-        # works like the --rails command line option, which is that when
-        # AllCops:DisabledByDefault is true, each Rails cop must still be
-        # explicitly mentioned in user configuration in order to be enabled.
-        next if dept == 'Rails'
-
         next unless dept_params['Enabled']
 
         new_default_configuration.each do |cop, params|

data/lib/rubocop/cop/cop.rb

@@ -48,10 +48,6 @@ module RuboCop
         registry.qualified_cop_name(name, origin)
       end
 
-      def self.non_rails
-        registry.without_department(:Rails)
-      end
-
       def self.inherited(subclass)
         registry.enlist(subclass)
       end

data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Gemspec
+      # Checks that `RUBY_VERSION` constant is not used in gemspec.
+      # Using `RUBY_VERSION` is dangerous because value of the
+      # constant is determined by `rake release`.
+      # It's possible to have dependency based on ruby version used
+      # to execute `rake release` and not user's ruby version.
+      #
+      # @example
+      #
+      #   # bad
+      #   Gem::Specification.new do |spec|
+      #     if RUBY_VERSION >= '2.5'
+      #       spec.add_runtime_dependency 'gem_a'
+      #     else
+      #       spec.add_runtime_dependency 'gem_b'
+      #     end
+      #   end
+      #
+      #   # good
+      #   Gem::Specification.new do |spec|
+      #     spec.add_runtime_dependency 'gem_a'
+      #   end
+      #
+      class RubyVersionGlobalsUsage < Cop
+        MSG = 'Do not use `RUBY_VERSION` in gemspec file.'
+
+        def_node_matcher :ruby_version?, '(const nil? :RUBY_VERSION)'
+
+        def_node_search :gem_specification?, <<-PATTERN
+          (block
+            (send
+              (const
+                (const {cbase nil?} :Gem) :Specification) :new)
+            ...)
+        PATTERN
+
+        def on_const(node)
+          return unless gem_spec_with_ruby_version?(node)
+
+          add_offense(node)
+        end
+
+        private
+
+        def gem_spec_with_ruby_version?(node)
+          gem_specification?(processed_source.ast) && ruby_version?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/layout/class_structure.rb

@@ -129,7 +129,7 @@ module RuboCop
       #     end
       #   end
       #
-      # @see https://github.com/rubocop-hq/ruby-style-guide#consistent-classes
+      # @see https://rubystyle.guide#consistent-classes
       class ClassStructure < Cop
         HUMANIZED_NODE_TYPE = {
           casgn: :constants,

data/lib/rubocop/cop/layout/indent_first_argument.rb

@@ -4,8 +4,12 @@ module RuboCop
   module Cop
     # rubocop:disable Metrics/LineLength
     module Layout
-      # This cop checks the indentation of the first argument in a method call
-      # or definition.
+      # This cop checks the indentation of the first argument in a method call.
+      # Arguments after the first one are checked by Layout/AlignArguments,
+      # not by this cop.
+      #
+      # For indenting the first parameter of method *definitions*, check out
+      # Layout/IndentFirstParameter.
       #
       # @example
       #

data/lib/rubocop/cop/layout/indent_first_parameter.rb

@@ -3,9 +3,13 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the first parameter in a method call.
-      # Parameters after the first one are checked by Layout/AlignParameters,
-      # not by this cop.
+      # This cop checks the indentation of the first parameter in a method
+      # definition. Parameters after the first one are checked by
+      # Layout/AlignParameters, not by this cop.
+      #
+      # For indenting the first argument of method *calls*, check out
+      # Layout/IndentFirstArgument, which supports options related to
+      # nesting that are irrelevant for method *definitions*.
       #
       # @example
       #

data/lib/rubocop/cop/layout/indent_heredoc.rb

@@ -52,7 +52,6 @@ module RuboCop
       class IndentHeredoc < Cop
         include Heredoc
         include ConfigurableEnforcedStyle
-        include SafeMode
 
         RUBY23_TYPE_MSG = 'Use %<indentation_width>d spaces for indentation ' \
                           'in a heredoc by using `<<~` instead of ' \

data/lib/rubocop/cop/layout/indentation_consistency.rb

@@ -5,12 +5,13 @@ module RuboCop
     module Layout
       # This cop checks for inconsistent indentation.
       #
-      # The difference between `rails` and `normal` is that the `rails` style
-      # prescribes that in classes and modules the `protected` and `private`
-      # modifier keywords shall be indented the same as public methods and that
-      # protected and private members shall be indented one step more than the
-      # modifiers. Other than that, both styles mean that entities on the same
-      # logical depth shall have the same indentation.
+      # The difference between `indented_internal_methods` and `normal` is
+      # that the `indented_internal_methods` style prescribes that in
+      # classes and modules the `protected` and `private` modifier keywords
+      # shall be indented the same as public methods and that protected and
+      # private members shall be indented one step more than the modifiers.
+      # Other than that, both styles mean that entities on the same logical
+      # depth shall have the same indentation.
       #
       # @example EnforcedStyle: normal (default)
       #   # bad
@@ -65,7 +66,7 @@ module RuboCop
       #     end
       #   end
       #
-      # @example EnforcedStyle: rails
+      # @example EnforcedStyle: indented_internal_methods
       #   # bad
       #   class A
       #     def test
@@ -166,8 +167,8 @@ module RuboCop
         end
 
         def check(node)
-          if style == :rails
-            check_rails_style(node)
+          if style == :indented_internal_methods
+            check_indented_internal_methods_style(node)
           else
             check_normal_style(node)
           end
@@ -180,13 +181,13 @@ module RuboCop
           )
         end
 
-        def check_rails_style(node)
+        def check_indented_internal_methods_style(node)
           children_to_check = [[]]
           node.children.each do |child|
             # Modifier nodes have special indentation and will be checked by
             # the AccessModifierIndentation cop. This cop uses them as dividers
-            # in rails mode. Then consistency is checked only within each
-            # section delimited by a modifier node.
+            # in indented_internal_methods mode. Then consistency is checked
+            # only within each section delimited by a modifier node.
             if bare_access_modifier?(child)
               children_to_check << []
             else