rubocop 0.71.0 → 0.72.0

data/lib/rubocop/cop/rails/time_zone.rb

@@ -1,238 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks for the use of Time methods without zone.
-      #
-      # Built on top of Ruby on Rails style guide (https://github.com/rubocop-hq/rails-style-guide#time)
-      # and the article http://danilenko.org/2012/7/6/rails_timezones/
-      #
-      # Two styles are supported for this cop. When EnforcedStyle is 'strict'
-      # then only use of Time.zone is allowed.
-      #
-      # When EnforcedStyle is 'flexible' then it's also allowed
-      # to use Time.in_time_zone.
-      #
-      # @example EnforcedStyle: strict
-      #   # `strict` means that `Time` should be used with `zone`.
-      #
-      #   # bad
-      #   Time.now
-      #   Time.parse('2015-03-02 19:05:37')
-      #
-      #   # bad
-      #   Time.current
-      #   Time.at(timestamp).in_time_zone
-      #
-      #   # good
-      #   Time.zone.now
-      #   Time.zone.parse('2015-03-02 19:05:37')
-      #
-      # @example EnforcedStyle: flexible (default)
-      #   # `flexible` allows usage of `in_time_zone` instead of `zone`.
-      #
-      #   # bad
-      #   Time.now
-      #   Time.parse('2015-03-02 19:05:37')
-      #
-      #   # good
-      #   Time.zone.now
-      #   Time.zone.parse('2015-03-02 19:05:37')
-      #
-      #   # good
-      #   Time.current
-      #   Time.at(timestamp).in_time_zone
-      class TimeZone < Cop
-        include ConfigurableEnforcedStyle
-
-        MSG = 'Do not use `%<current>s` without zone. Use `%<prefer>s` ' \
-              'instead.'
-
-        MSG_ACCEPTABLE = 'Do not use `%<current>s` without zone. ' \
-                         'Use one of %<prefer>s instead.'
-
-        MSG_LOCALTIME = 'Do not use `Time.localtime` without ' \
-                        'offset or zone.'
-
-        TIMECLASSES = %i[Time DateTime].freeze
-
-        GOOD_METHODS = %i[zone zone_default find_zone find_zone!].freeze
-
-        DANGEROUS_METHODS = %i[now local new parse at current].freeze
-
-        ACCEPTED_METHODS = %i[in_time_zone utc getlocal xmlschema iso8601
-                              jisx0301 rfc3339 httpdate to_i to_f].freeze
-
-        def on_const(node)
-          mod, klass = *node
-          # we should only check core classes
-          # (`DateTime`, `Time`, `::DateTime` or `::Time`)
-          return unless (mod.nil? || mod.cbase_type?) && method_send?(node)
-
-          check_time_node(klass, node.parent) if TIMECLASSES.include?(klass)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            # add `.zone`: `Time.at` => `Time.zone.at`
-            corrector.insert_after(node.children[0].source_range, '.zone')
-            # replace `Time.zone.current` => `Time.zone.now`
-            if node.method_name == :current
-              corrector.replace(node.loc.selector, 'now')
-            end
-            # prefer `Time` over `DateTime` class
-            if strict?
-              corrector.replace(node.children.first.source_range, 'Time')
-            end
-            remove_redundant_in_time_zone(corrector, node)
-          end
-        end
-
-        private
-
-        # remove redundant `.in_time_zone` from `Time.zone.now.in_time_zone`
-        def remove_redundant_in_time_zone(corrector, node)
-          time_methods_called = extract_method_chain(node)
-          return unless time_methods_called.include?(:in_time_zone) ||
-                        time_methods_called.include?(:zone)
-
-          while node&.send_type?
-            if node.children.last == :in_time_zone
-              in_time_zone_with_dot =
-                node.loc.selector.adjust(begin_pos: -1)
-              corrector.remove(in_time_zone_with_dot)
-            end
-            node = node.parent
-          end
-        end
-
-        def check_time_node(klass, node)
-          chain = extract_method_chain(node)
-          return if not_danger_chain?(chain)
-
-          return check_localtime(node) if need_check_localtime?(chain)
-
-          method_name = (chain & DANGEROUS_METHODS).join('.')
-
-          return if offset_provided?(node)
-
-          message = build_message(klass, method_name, node)
-
-          add_offense(node, location: :selector, message: message)
-        end
-
-        def build_message(klass, method_name, node)
-          if flexible?
-            format(
-              MSG_ACCEPTABLE,
-              current: "#{klass}.#{method_name}",
-              prefer: acceptable_methods(klass, method_name, node).join(', ')
-            )
-          else
-            safe_method_name = safe_method(method_name, node)
-            format(MSG,
-                   current: "#{klass}.#{method_name}",
-                   prefer: "Time.zone.#{safe_method_name}")
-          end
-        end
-
-        def extract_method_chain(node)
-          chain = []
-          while !node.nil? && node.send_type?
-            chain << node.method_name if method_from_time_class?(node)
-            node = node.parent
-          end
-          chain
-        end
-
-        # Only add the method to the chain if the method being
-        # called is part of the time class.
-        def method_from_time_class?(node)
-          receiver, method_name, *_args = *node
-          if (receiver.is_a? RuboCop::AST::Node) && !receiver.cbase_type?
-            method_from_time_class?(receiver)
-          else
-            TIMECLASSES.include?(method_name)
-          end
-        end
-
-        # checks that parent node of send_type
-        # and receiver is the given node
-        def method_send?(node)
-          return false unless node.parent&.send_type?
-
-          node.parent.receiver == node
-        end
-
-        def safe_method(method_name, node)
-          if %w[new current].include?(method_name)
-            node.arguments? ? 'local' : 'now'
-          else
-            method_name
-          end
-        end
-
-        def check_localtime(node)
-          selector_node = node
-
-          while node&.send_type?
-            break if node.method_name == :localtime
-
-            node = node.parent
-          end
-
-          return if node.arguments?
-
-          add_offense(selector_node,
-                      location: :selector, message: MSG_LOCALTIME)
-        end
-
-        def not_danger_chain?(chain)
-          (chain & DANGEROUS_METHODS).empty? || !(chain & good_methods).empty?
-        end
-
-        def need_check_localtime?(chain)
-          flexible? && chain.include?(:localtime)
-        end
-
-        def flexible?
-          style == :flexible
-        end
-
-        def strict?
-          style == :strict
-        end
-
-        def good_methods
-          if strict?
-            GOOD_METHODS
-          else
-            GOOD_METHODS + [:current] + ACCEPTED_METHODS
-          end
-        end
-
-        def acceptable_methods(klass, method_name, node)
-          acceptable = [
-            "`Time.zone.#{safe_method(method_name, node)}`",
-            "`#{klass}.current`"
-          ]
-
-          ACCEPTED_METHODS.each do |am|
-            acceptable << "`#{klass}.#{method_name}.#{am}`"
-          end
-
-          acceptable
-        end
-
-        # Time.new can be called with a time zone offset
-        # When it is, that should be considered safe
-        # Example:
-        # Time.new(1988, 3, 15, 3, 0, 0, "-05:00")
-        def offset_provided?(node)
-          node.arguments.size >= 7
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/uniq_before_pluck.rb

@@ -1,105 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # Prefer the use of uniq (or distinct), before pluck instead of after.
-      #
-      # The use of uniq before pluck is preferred because it executes within
-      # the database.
-      #
-      # This cop has two different enforcement modes. When the EnforcedStyle
-      # is conservative (the default) then only calls to pluck on a constant
-      # (i.e. a model class) before uniq are added as offenses.
-      #
-      # When the EnforcedStyle is aggressive then all calls to pluck before
-      # uniq are added as offenses. This may lead to false positives as the cop
-      # cannot distinguish between calls to pluck on an ActiveRecord::Relation
-      # vs a call to pluck on an ActiveRecord::Associations::CollectionProxy.
-      #
-      # Autocorrect is disabled by default for this cop since it may generate
-      # false positives.
-      #
-      # @example EnforcedStyle: conservative (default)
-      #   # bad
-      #   Model.pluck(:id).uniq
-      #
-      #   # good
-      #   Model.uniq.pluck(:id)
-      #
-      # @example EnforcedStyle: aggressive
-      #   # bad
-      #   # this will return a Relation that pluck is called on
-      #   Model.where(cond: true).pluck(:id).uniq
-      #
-      #   # bad
-      #   # an association on an instance will return a CollectionProxy
-      #   instance.assoc.pluck(:id).uniq
-      #
-      #   # bad
-      #   Model.pluck(:id).uniq
-      #
-      #   # good
-      #   Model.uniq.pluck(:id)
-      #
-      class UniqBeforePluck < RuboCop::Cop::Cop
-        include ConfigurableEnforcedStyle
-        include RangeHelp
-
-        MSG = 'Use `%<method>s` before `pluck`.'
-        NEWLINE = "\n"
-        PATTERN = '[!^block (send (send %<type>s :pluck ...) ' \
-                  '${:uniq :distinct} ...)]'
-
-        def_node_matcher :conservative_node_match,
-                         format(PATTERN, type: 'const')
-
-        def_node_matcher :aggressive_node_match,
-                         format(PATTERN, type: '_')
-
-        def on_send(node)
-          method = if style == :conservative
-                     conservative_node_match(node)
-                   else
-                     aggressive_node_match(node)
-                   end
-
-          return unless method
-
-          add_offense(node, location: :selector,
-                            message: format(MSG, method: method))
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            method = node.method_name
-
-            corrector.remove(dot_method_with_whitespace(method, node))
-            corrector.insert_before(node.receiver.loc.dot.begin, ".#{method}")
-          end
-        end
-
-        private
-
-        def style_parameter_name
-          'EnforcedStyle'
-        end
-
-        def dot_method_with_whitespace(method, node)
-          range_between(dot_method_begin_pos(method, node),
-                        node.loc.selector.end_pos)
-        end
-
-        def dot_method_begin_pos(method, node)
-          lines = node.source.split(NEWLINE)
-
-          if lines.last.strip == ".#{method}"
-            node.source.rindex(NEWLINE)
-          else
-            node.loc.dot.begin_pos
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/unknown_env.rb

@@ -1,63 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks that environments called with `Rails.env` predicates
-      # exist.
-      #
-      # @example
-      #   # bad
-      #   Rails.env.proudction?
-      #
-      #   # good
-      #   Rails.env.production?
-      class UnknownEnv < Cop
-        include NameSimilarity
-
-        MSG = 'Unknown environment `%<name>s`.'
-        MSG_SIMILAR = 'Unknown environment `%<name>s`. ' \
-                      'Did you mean `%<similar>s`?'
-
-        def_node_matcher :unknown_environment?, <<-PATTERN
-          (send
-            (send
-              {(const nil? :Rails) (const (cbase) :Rails)}
-              :env)
-            $#unknown_env_name?)
-        PATTERN
-
-        def on_send(node)
-          unknown_environment?(node) do |name|
-            add_offense(node, location: :selector, message: message(name))
-          end
-        end
-
-        private
-
-        def collect_variable_like_names(_scope)
-          environments.map { |env| env + '?' }
-        end
-
-        def message(name)
-          similar = find_similar_name(name.to_s, [])
-          if similar
-            format(MSG_SIMILAR, name: name, similar: similar)
-          else
-            format(MSG, name: name)
-          end
-        end
-
-        def unknown_env_name?(name)
-          name = name.to_s
-          name.end_with?('?') &&
-            !environments.include?(name[0..-2])
-        end
-
-        def environments
-          cop_config['Environments']
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/validation.rb

@@ -1,109 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks for the use of old-style attribute validation macros.
-      #
-      # @example
-      #   # bad
-      #   validates_acceptance_of :foo
-      #   validates_confirmation_of :foo
-      #   validates_exclusion_of :foo
-      #   validates_format_of :foo
-      #   validates_inclusion_of :foo
-      #   validates_length_of :foo
-      #   validates_numericality_of :foo
-      #   validates_presence_of :foo
-      #   validates_absence_of :foo
-      #   validates_size_of :foo
-      #   validates_uniqueness_of :foo
-      #
-      #   # good
-      #   validates :foo, acceptance: true
-      #   validates :foo, confirmation: true
-      #   validates :foo, exclusion: true
-      #   validates :foo, format: true
-      #   validates :foo, inclusion: true
-      #   validates :foo, length: true
-      #   validates :foo, numericality: true
-      #   validates :foo, presence: true
-      #   validates :foo, absence: true
-      #   validates :foo, size: true
-      #   validates :foo, uniqueness: true
-      #
-      class Validation < Cop
-        MSG = 'Prefer the new style validations `%<prefer>s` over ' \
-              '`%<current>s`.'
-
-        TYPES = %w[
-          acceptance
-          confirmation
-          exclusion
-          format
-          inclusion
-          length
-          numericality
-          presence
-          absence
-          size
-          uniqueness
-        ].freeze
-
-        DENYLIST = TYPES.map { |p| "validates_#{p}_of".to_sym }.freeze
-        ALLOWLIST = TYPES.map { |p| "validates :column, #{p}: value" }.freeze
-
-        def on_send(node)
-          return unless !node.receiver && DENYLIST.include?(node.method_name)
-
-          add_offense(node, location: :selector)
-        end
-
-        def autocorrect(node)
-          last_argument = node.arguments.last
-          return if !last_argument.literal? && !last_argument.splat_type?
-
-          lambda do |corrector|
-            corrector.replace(node.loc.selector, 'validates')
-            correct_validate_type(corrector, node)
-          end
-        end
-
-        private
-
-        def message(node)
-          format(MSG, prefer: preferred_method(node.method_name),
-                      current: node.method_name)
-        end
-
-        def preferred_method(method)
-          ALLOWLIST[DENYLIST.index(method.to_sym)]
-        end
-
-        def correct_validate_type(corrector, node)
-          last_argument = node.arguments.last
-          validate_type = node.method_name.to_s.split('_')[1]
-
-          if last_argument.hash_type?
-            corrector.replace(
-              last_argument.loc.expression,
-              "#{validate_type}: #{braced_options(last_argument)}"
-            )
-          else
-            range = last_argument.source_range
-
-            corrector.insert_after(range, ", #{validate_type}: true")
-          end
-        end
-
-        def braced_options(options)
-          if options.braces?
-            options.source
-          else
-            "{ #{options.source} }"
-          end
-        end
-      end
-    end
-  end
-end