rubocop 0.51.0 → 0.52.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +1 -2
  3. data/config/default.yml +86 -10
  4. data/config/disabled.yml +9 -4
  5. data/config/enabled.yml +1105 -1006
  6. data/lib/rubocop.rb +30 -3
  7. data/lib/rubocop/ast/builder.rb +2 -0
  8. data/lib/rubocop/ast/node.rb +24 -2
  9. data/lib/rubocop/ast/node/args_node.rb +17 -0
  10. data/lib/rubocop/ast/node/array_node.rb +1 -1
  11. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +16 -0
  12. data/lib/rubocop/ast/node/send_node.rb +20 -0
  13. data/lib/rubocop/ast/node/str_node.rb +14 -0
  14. data/lib/rubocop/ast/node/symbol_node.rb +20 -0
  15. data/lib/rubocop/ast/traversal.rb +4 -4
  16. data/lib/rubocop/cli.rb +45 -4
  17. data/lib/rubocop/comment_config.rb +2 -5
  18. data/lib/rubocop/config.rb +42 -8
  19. data/lib/rubocop/config_loader.rb +39 -100
  20. data/lib/rubocop/config_loader_resolver.rb +99 -2
  21. data/lib/rubocop/cop/autocorrect_logic.rb +1 -1
  22. data/lib/rubocop/cop/bundler/duplicated_gem.rb +7 -7
  23. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +4 -3
  24. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  25. data/lib/rubocop/cop/cop.rb +16 -46
  26. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +102 -0
  27. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -2
  28. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +87 -0
  29. data/lib/rubocop/cop/generator.rb +23 -4
  30. data/lib/rubocop/cop/internal_affairs.rb +1 -1
  31. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +46 -0
  32. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +2 -2
  33. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +9 -8
  34. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  35. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  36. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +4 -7
  37. data/lib/rubocop/cop/layout/align_hash.rb +16 -16
  38. data/lib/rubocop/cop/layout/align_parameters.rb +6 -12
  39. data/lib/rubocop/cop/layout/block_end_newline.rb +19 -5
  40. data/lib/rubocop/cop/layout/case_indentation.rb +14 -17
  41. data/lib/rubocop/cop/layout/class_structure.rb +306 -0
  42. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -0
  43. data/lib/rubocop/cop/layout/comment_indentation.rb +39 -2
  44. data/lib/rubocop/cop/layout/dot_position.rb +22 -13
  45. data/lib/rubocop/cop/layout/else_alignment.rb +6 -6
  46. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +17 -17
  47. data/lib/rubocop/cop/layout/empty_lines.rb +15 -1
  48. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +3 -2
  49. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +89 -0
  50. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -2
  51. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -8
  52. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +30 -5
  53. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +7 -3
  54. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -2
  55. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +22 -7
  56. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  57. data/lib/rubocop/cop/layout/extra_spacing.rb +21 -24
  58. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +4 -1
  59. data/lib/rubocop/cop/layout/indent_array.rb +67 -20
  60. data/lib/rubocop/cop/layout/indent_hash.rb +70 -25
  61. data/lib/rubocop/cop/layout/indent_heredoc.rb +51 -11
  62. data/lib/rubocop/cop/layout/indentation_width.rb +24 -17
  63. data/lib/rubocop/cop/layout/initial_indentation.rb +7 -5
  64. data/lib/rubocop/cop/layout/leading_comment_space.rb +2 -2
  65. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +47 -14
  66. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +10 -9
  67. data/lib/rubocop/cop/layout/multiline_block_layout.rb +19 -16
  68. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +46 -13
  69. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +9 -10
  70. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +4 -0
  71. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +9 -3
  72. data/lib/rubocop/cop/layout/space_after_colon.rb +4 -4
  73. data/lib/rubocop/cop/layout/space_after_comma.rb +3 -3
  74. data/lib/rubocop/cop/layout/space_after_method_name.rb +4 -4
  75. data/lib/rubocop/cop/layout/space_after_semicolon.rb +8 -1
  76. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +16 -19
  77. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +27 -16
  78. data/lib/rubocop/cop/layout/space_around_keyword.rb +13 -11
  79. data/lib/rubocop/cop/layout/space_around_operators.rb +26 -13
  80. data/lib/rubocop/cop/layout/space_before_block_braces.rb +10 -10
  81. data/lib/rubocop/cop/layout/space_before_comma.rb +12 -1
  82. data/lib/rubocop/cop/layout/space_before_comment.rb +2 -4
  83. data/lib/rubocop/cop/layout/space_before_first_arg.rb +4 -3
  84. data/lib/rubocop/cop/layout/space_before_semicolon.rb +1 -1
  85. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +6 -12
  86. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +235 -0
  87. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -3
  88. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +87 -16
  89. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +57 -34
  90. data/lib/rubocop/cop/layout/space_inside_parens.rb +31 -3
  91. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +15 -15
  92. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +81 -0
  93. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -13
  94. data/lib/rubocop/cop/layout/tab.rb +2 -2
  95. data/lib/rubocop/cop/layout/trailing_blank_lines.rb +7 -7
  96. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +11 -20
  97. data/lib/rubocop/cop/lint/block_alignment.rb +26 -23
  98. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  99. data/lib/rubocop/cop/lint/def_end_alignment.rb +5 -10
  100. data/lib/rubocop/cop/lint/else_layout.rb +2 -2
  101. data/lib/rubocop/cop/lint/end_alignment.rb +13 -14
  102. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +3 -4
  103. data/lib/rubocop/cop/lint/inherit_exception.rb +10 -14
  104. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +81 -0
  105. data/lib/rubocop/cop/lint/nested_percent_literal.rb +58 -0
  106. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
  107. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -1
  108. data/lib/rubocop/cop/lint/percent_string_array.rb +14 -14
  109. data/lib/rubocop/cop/lint/percent_symbol_array.rb +11 -11
  110. data/lib/rubocop/cop/lint/redundant_with_index.rb +6 -3
  111. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
  112. data/lib/rubocop/cop/lint/require_parentheses.rb +3 -1
  113. data/lib/rubocop/cop/lint/rescue_type.rb +3 -3
  114. data/lib/rubocop/cop/lint/script_permission.rb +1 -0
  115. data/lib/rubocop/cop/lint/shadowed_argument.rb +146 -0
  116. data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +6 -6
  117. data/lib/rubocop/cop/lint/unneeded_disable.rb +29 -11
  118. data/lib/rubocop/cop/lint/unneeded_require_statement.rb +2 -1
  119. data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +43 -17
  120. data/lib/rubocop/cop/message_annotator.rb +4 -2
  121. data/lib/rubocop/cop/metrics/abc_size.rb +2 -2
  122. data/lib/rubocop/cop/metrics/class_length.rb +3 -1
  123. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -1
  124. data/lib/rubocop/cop/metrics/line_length.rb +2 -2
  125. data/lib/rubocop/cop/metrics/module_length.rb +3 -1
  126. data/lib/rubocop/cop/metrics/parameter_lists.rb +9 -2
  127. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -1
  128. data/lib/rubocop/cop/mixin/documentation_comment.rb +1 -1
  129. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +7 -5
  130. data/lib/rubocop/cop/mixin/empty_parameter.rb +23 -0
  131. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +7 -3
  132. data/lib/rubocop/cop/mixin/heredoc.rb +19 -19
  133. data/lib/rubocop/cop/mixin/method_complexity.rb +32 -8
  134. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +7 -3
  135. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +6 -4
  136. data/lib/rubocop/cop/mixin/negative_conditional.rb +3 -0
  137. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -12
  138. data/lib/rubocop/cop/mixin/parentheses.rb +12 -0
  139. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +8 -8
  140. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +10 -10
  141. data/lib/rubocop/cop/mixin/statement_modifier.rb +7 -17
  142. data/lib/rubocop/cop/mixin/surrounding_space.rb +95 -8
  143. data/lib/rubocop/cop/mixin/too_many_lines.rb +2 -2
  144. data/lib/rubocop/cop/mixin/trailing_comma.rb +22 -14
  145. data/lib/rubocop/cop/mixin/unused_argument.rb +3 -40
  146. data/lib/rubocop/cop/naming/accessor_method_name.rb +20 -10
  147. data/lib/rubocop/cop/naming/ascii_identifiers.rb +33 -0
  148. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +5 -4
  149. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -12
  150. data/lib/rubocop/cop/naming/constant_name.rb +32 -3
  151. data/lib/rubocop/cop/naming/file_name.rb +19 -8
  152. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +10 -16
  153. data/lib/rubocop/cop/naming/method_name.rb +20 -14
  154. data/lib/rubocop/cop/naming/predicate_name.rb +7 -3
  155. data/lib/rubocop/cop/naming/variable_name.rb +17 -2
  156. data/lib/rubocop/cop/naming/variable_number.rb +10 -27
  157. data/lib/rubocop/cop/offense.rb +6 -1
  158. data/lib/rubocop/cop/performance/case_when_splat.rb +2 -6
  159. data/lib/rubocop/cop/performance/casecmp.rb +5 -4
  160. data/lib/rubocop/cop/performance/compare_with_block.rb +13 -7
  161. data/lib/rubocop/cop/performance/count.rb +5 -4
  162. data/lib/rubocop/cop/performance/detect.rb +7 -4
  163. data/lib/rubocop/cop/performance/double_start_end_with.rb +2 -7
  164. data/lib/rubocop/cop/performance/end_with.rb +2 -2
  165. data/lib/rubocop/cop/performance/flat_map.rb +3 -2
  166. data/lib/rubocop/cop/performance/hash_each_methods.rb +41 -40
  167. data/lib/rubocop/cop/performance/lstrip_rstrip.rb +5 -4
  168. data/lib/rubocop/cop/performance/redundant_block_call.rb +22 -22
  169. data/lib/rubocop/cop/performance/redundant_match.rb +2 -2
  170. data/lib/rubocop/cop/performance/redundant_merge.rb +6 -4
  171. data/lib/rubocop/cop/performance/redundant_sort_by.rb +4 -4
  172. data/lib/rubocop/cop/performance/regexp_match.rb +3 -2
  173. data/lib/rubocop/cop/performance/size.rb +2 -2
  174. data/lib/rubocop/cop/performance/start_with.rb +2 -2
  175. data/lib/rubocop/cop/performance/string_replacement.rb +4 -4
  176. data/lib/rubocop/cop/performance/times_map.rb +14 -15
  177. data/lib/rubocop/cop/performance/uri_default_parser.rb +3 -3
  178. data/lib/rubocop/cop/rails/action_filter.rb +22 -0
  179. data/lib/rubocop/cop/rails/active_support_aliases.rb +2 -2
  180. data/lib/rubocop/cop/rails/application_job.rb +4 -2
  181. data/lib/rubocop/cop/rails/application_record.rb +4 -2
  182. data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +82 -0
  183. data/lib/rubocop/cop/rails/delegate.rb +20 -25
  184. data/lib/rubocop/cop/rails/delegate_allow_blank.rb +2 -2
  185. data/lib/rubocop/cop/rails/environment_comparison.rb +66 -0
  186. data/lib/rubocop/cop/rails/exit.rb +7 -0
  187. data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +7 -0
  188. data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +6 -2
  189. data/lib/rubocop/cop/rails/http_positional_arguments.rb +36 -41
  190. data/lib/rubocop/cop/rails/inverse_of.rb +96 -0
  191. data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +112 -0
  192. data/lib/rubocop/cop/rails/output.rb +9 -0
  193. data/lib/rubocop/cop/rails/output_safety.rb +14 -20
  194. data/lib/rubocop/cop/rails/pluralization_grammar.rb +8 -8
  195. data/lib/rubocop/cop/rails/presence.rb +105 -0
  196. data/lib/rubocop/cop/rails/read_write_attribute.rb +10 -10
  197. data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +91 -0
  198. data/lib/rubocop/cop/rails/relative_date_constant.rb +9 -9
  199. data/lib/rubocop/cop/rails/reversible_migration.rb +3 -4
  200. data/lib/rubocop/cop/rails/safe_navigation.rb +5 -6
  201. data/lib/rubocop/cop/rails/save_bang.rb +2 -2
  202. data/lib/rubocop/cop/rails/uniq_before_pluck.rb +1 -1
  203. data/lib/rubocop/cop/rails/validation.rb +7 -7
  204. data/lib/rubocop/cop/security/json_load.rb +4 -2
  205. data/lib/rubocop/cop/security/marshal_load.rb +4 -2
  206. data/lib/rubocop/cop/style/alias.rb +24 -26
  207. data/lib/rubocop/cop/style/and_or.rb +34 -28
  208. data/lib/rubocop/cop/style/array_join.rb +9 -0
  209. data/lib/rubocop/cop/style/ascii_comments.rb +24 -4
  210. data/lib/rubocop/cop/style/attr.rb +14 -4
  211. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +5 -3
  212. data/lib/rubocop/cop/style/bare_percent_literals.rb +31 -10
  213. data/lib/rubocop/cop/style/block_comments.rb +14 -2
  214. data/lib/rubocop/cop/style/block_delimiters.rb +80 -15
  215. data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +81 -48
  216. data/lib/rubocop/cop/style/case_equality.rb +12 -0
  217. data/lib/rubocop/cop/style/character_literal.rb +10 -0
  218. data/lib/rubocop/cop/style/class_and_module_children.rb +6 -2
  219. data/lib/rubocop/cop/style/class_check.rb +28 -9
  220. data/lib/rubocop/cop/style/class_methods.rb +8 -8
  221. data/lib/rubocop/cop/style/class_vars.rb +4 -3
  222. data/lib/rubocop/cop/style/collection_methods.rb +4 -2
  223. data/lib/rubocop/cop/style/colon_method_call.rb +16 -0
  224. data/lib/rubocop/cop/style/colon_method_definition.rb +36 -0
  225. data/lib/rubocop/cop/style/command_literal.rb +70 -21
  226. data/lib/rubocop/cop/style/comment_annotation.rb +35 -10
  227. data/lib/rubocop/cop/style/commented_keyword.rb +12 -9
  228. data/lib/rubocop/cop/style/conditional_assignment.rb +10 -12
  229. data/lib/rubocop/cop/style/copyright.rb +19 -20
  230. data/lib/rubocop/cop/style/date_time.rb +2 -2
  231. data/lib/rubocop/cop/style/def_with_parentheses.rb +27 -2
  232. data/lib/rubocop/cop/style/dir.rb +2 -2
  233. data/lib/rubocop/cop/style/documentation.rb +17 -2
  234. data/lib/rubocop/cop/style/each_for_simple_loop.rb +7 -7
  235. data/lib/rubocop/cop/style/each_with_object.rb +5 -5
  236. data/lib/rubocop/cop/style/empty_block_parameter.rb +47 -0
  237. data/lib/rubocop/cop/style/empty_case_condition.rb +2 -2
  238. data/lib/rubocop/cop/style/empty_else.rb +52 -22
  239. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +43 -0
  240. data/lib/rubocop/cop/style/empty_literal.rb +17 -5
  241. data/lib/rubocop/cop/style/empty_method.rb +4 -10
  242. data/lib/rubocop/cop/style/encoding.rb +2 -1
  243. data/lib/rubocop/cop/style/eval_with_location.rb +146 -0
  244. data/lib/rubocop/cop/style/even_odd.rb +4 -2
  245. data/lib/rubocop/cop/style/extend_self.rb +92 -0
  246. data/lib/rubocop/cop/style/flip_flop.rb +11 -0
  247. data/lib/rubocop/cop/style/format_string.rb +29 -2
  248. data/lib/rubocop/cop/style/format_string_token.rb +15 -14
  249. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +4 -3
  250. data/lib/rubocop/cop/style/global_vars.rb +11 -1
  251. data/lib/rubocop/cop/style/hash_syntax.rb +44 -43
  252. data/lib/rubocop/cop/style/identical_conditional_branches.rb +8 -8
  253. data/lib/rubocop/cop/style/if_inside_else.rb +10 -10
  254. data/lib/rubocop/cop/style/if_unless_modifier.rb +7 -7
  255. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +2 -2
  256. data/lib/rubocop/cop/style/if_with_semicolon.rb +9 -0
  257. data/lib/rubocop/cop/style/implicit_runtime_error.rb +5 -5
  258. data/lib/rubocop/cop/style/infinite_loop.rb +2 -2
  259. data/lib/rubocop/cop/style/lambda.rb +23 -31
  260. data/lib/rubocop/cop/style/lambda_call.rb +15 -9
  261. data/lib/rubocop/cop/style/line_end_concatenation.rb +4 -4
  262. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -2
  263. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +2 -2
  264. data/lib/rubocop/cop/style/method_def_parentheses.rb +4 -3
  265. data/lib/rubocop/cop/style/method_missing.rb +8 -8
  266. data/lib/rubocop/cop/style/min_max.rb +12 -12
  267. data/lib/rubocop/cop/style/missing_else.rb +5 -4
  268. data/lib/rubocop/cop/style/mixin_grouping.rb +29 -19
  269. data/lib/rubocop/cop/style/mixin_usage.rb +8 -10
  270. data/lib/rubocop/cop/style/module_function.rb +17 -5
  271. data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -4
  272. data/lib/rubocop/cop/style/multiline_if_then.rb +14 -13
  273. data/lib/rubocop/cop/style/multiline_memoization.rb +8 -14
  274. data/lib/rubocop/cop/style/mutable_constant.rb +12 -12
  275. data/lib/rubocop/cop/style/negated_if.rb +22 -30
  276. data/lib/rubocop/cop/style/negated_while.rb +1 -5
  277. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +18 -17
  278. data/lib/rubocop/cop/style/next.rb +39 -11
  279. data/lib/rubocop/cop/style/nil_comparison.rb +6 -6
  280. data/lib/rubocop/cop/style/non_nil_check.rb +25 -22
  281. data/lib/rubocop/cop/style/not.rb +14 -4
  282. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -6
  283. data/lib/rubocop/cop/style/numeric_literals.rb +7 -7
  284. data/lib/rubocop/cop/style/numeric_predicate.rb +14 -18
  285. data/lib/rubocop/cop/style/one_line_conditional.rb +4 -4
  286. data/lib/rubocop/cop/style/option_hash.rb +11 -14
  287. data/lib/rubocop/cop/style/or_assignment.rb +2 -2
  288. data/lib/rubocop/cop/style/parallel_assignment.rb +13 -13
  289. data/lib/rubocop/cop/style/parentheses_around_condition.rb +19 -3
  290. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +24 -3
  291. data/lib/rubocop/cop/style/percent_q_literals.rb +27 -6
  292. data/lib/rubocop/cop/style/perl_backrefs.rb +7 -0
  293. data/lib/rubocop/cop/style/preferred_hash_methods.rb +6 -10
  294. data/lib/rubocop/cop/style/proc.rb +8 -0
  295. data/lib/rubocop/cop/style/raise_args.rb +8 -14
  296. data/lib/rubocop/cop/style/random_with_offset.rb +160 -0
  297. data/lib/rubocop/cop/style/redundant_begin.rb +14 -4
  298. data/lib/rubocop/cop/style/redundant_conditional.rb +9 -8
  299. data/lib/rubocop/cop/style/redundant_return.rb +5 -4
  300. data/lib/rubocop/cop/style/redundant_self.rb +25 -26
  301. data/lib/rubocop/cop/style/regexp_literal.rb +74 -21
  302. data/lib/rubocop/cop/style/rescue_modifier.rb +11 -0
  303. data/lib/rubocop/cop/style/rescue_standard_error.rb +122 -0
  304. data/lib/rubocop/cop/style/return_nil.rb +4 -8
  305. data/lib/rubocop/cop/style/safe_navigation.rb +20 -2
  306. data/lib/rubocop/cop/style/self_assignment.rb +13 -13
  307. data/lib/rubocop/cop/style/semicolon.rb +18 -8
  308. data/lib/rubocop/cop/style/send.rb +9 -0
  309. data/lib/rubocop/cop/style/signal_exception.rb +100 -0
  310. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  311. data/lib/rubocop/cop/style/single_line_methods.rb +20 -8
  312. data/lib/rubocop/cop/style/special_global_vars.rb +16 -11
  313. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +7 -12
  314. data/lib/rubocop/cop/style/stderr_puts.rb +5 -3
  315. data/lib/rubocop/cop/style/string_hash_keys.rb +36 -0
  316. data/lib/rubocop/cop/style/string_literals.rb +22 -0
  317. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +2 -8
  318. data/lib/rubocop/cop/style/string_methods.rb +18 -7
  319. data/lib/rubocop/cop/style/symbol_array.rb +5 -9
  320. data/lib/rubocop/cop/style/symbol_proc.rb +5 -4
  321. data/lib/rubocop/cop/style/ternary_parentheses.rb +31 -40
  322. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +101 -0
  323. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +20 -6
  324. data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +22 -7
  325. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +95 -0
  326. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -4
  327. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -10
  328. data/lib/rubocop/cop/style/unless_else.rb +15 -0
  329. data/lib/rubocop/cop/style/unneeded_capital_w.rb +17 -7
  330. data/lib/rubocop/cop/style/unneeded_interpolation.rb +14 -18
  331. data/lib/rubocop/cop/style/unneeded_percent_q.rb +13 -12
  332. data/lib/rubocop/cop/style/variable_interpolation.rb +20 -9
  333. data/lib/rubocop/cop/style/when_then.rb +13 -0
  334. data/lib/rubocop/cop/style/while_until_do.rb +26 -4
  335. data/lib/rubocop/cop/style/while_until_modifier.rb +25 -6
  336. data/lib/rubocop/cop/style/word_array.rb +4 -8
  337. data/lib/rubocop/cop/style/yoda_condition.rb +10 -16
  338. data/lib/rubocop/cop/style/zero_length_predicate.rb +23 -15
  339. data/lib/rubocop/cop/util.rb +42 -33
  340. data/lib/rubocop/cop/variable_force.rb +1 -1
  341. data/lib/rubocop/cop/variable_force/assignment.rb +4 -2
  342. data/lib/rubocop/cop/variable_force/scope.rb +1 -5
  343. data/lib/rubocop/cop/variable_force/variable.rb +1 -1
  344. data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -3
  345. data/lib/rubocop/formatter/formatter_set.rb +2 -1
  346. data/lib/rubocop/formatter/json_formatter.rb +9 -3
  347. data/lib/rubocop/formatter/quiet_formatter.rb +13 -0
  348. data/lib/rubocop/node_pattern.rb +2 -3
  349. data/lib/rubocop/options.rb +8 -8
  350. data/lib/rubocop/path_util.rb +15 -3
  351. data/lib/rubocop/processed_source.rb +5 -2
  352. data/lib/rubocop/rspec/shared_contexts.rb +4 -0
  353. data/lib/rubocop/runner.rb +1 -1
  354. data/lib/rubocop/token.rb +74 -0
  355. data/lib/rubocop/version.rb +1 -1
  356. metadata +37 -10
  357. data/lib/rubocop/cop/internal_affairs/deprecated_positional_arguments.rb +0 -81
  358. data/lib/rubocop/cop/layout/space_inside_brackets.rb +0 -20
  359. data/lib/rubocop/cop/lint/rescue_without_error_class.rb +0 -41
  360. data/lib/rubocop/cop/mixin/space_inside.rb +0 -76
@@ -0,0 +1,95 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for trailing code after the method definition.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # def some_method
11
+ # do_stuff; end
12
+ #
13
+ # def do_this(x)
14
+ # baz.map { |b| b.this(x) } end
15
+ #
16
+ # def foo
17
+ # block do
18
+ # bar
19
+ # end end
20
+ #
21
+ # # good
22
+ # def some_method
23
+ # do_stuff
24
+ # end
25
+ #
26
+ # def do_this(x)
27
+ # baz.map { |b| b.this(x) }
28
+ # end
29
+ #
30
+ # def foo
31
+ # block do
32
+ # bar
33
+ # end
34
+ # end
35
+ #
36
+ class TrailingMethodEndStatement < Cop
37
+ include AutocorrectAlignment
38
+
39
+ MSG = 'Place the end statement of a multi-line method on ' \
40
+ 'its own line.'.freeze
41
+
42
+ def on_def(node)
43
+ return unless trailing_end?(node)
44
+
45
+ add_offense(node.to_a.last, location: end_token.pos)
46
+ end
47
+
48
+ def autocorrect(_node)
49
+ lambda do |corrector|
50
+ break_line_before_end(corrector)
51
+ remove_semicolon(corrector)
52
+ end
53
+ end
54
+
55
+ private
56
+
57
+ def trailing_end?(node)
58
+ node.body &&
59
+ node.multiline? &&
60
+ end_token &&
61
+ body_and_end_on_same_line?
62
+ end
63
+
64
+ def end_token
65
+ @end_token ||= processed_source.tokens.reverse.find do |token|
66
+ token.type == :kEND
67
+ end
68
+ end
69
+
70
+ def body_and_end_on_same_line?
71
+ end_token.line == token_before_end.line
72
+ end
73
+
74
+ def token_before_end
75
+ @token_before_end ||= begin
76
+ i = processed_source.tokens.index(end_token)
77
+ processed_source.tokens[i - 1]
78
+ end
79
+ end
80
+
81
+ def break_line_before_end(corrector)
82
+ corrector.insert_before(
83
+ end_token.pos,
84
+ "\n" + ' ' * configured_indentation_width
85
+ )
86
+ end
87
+
88
+ def remove_semicolon(corrector)
89
+ return unless token_before_end.semicolon?
90
+ corrector.remove(token_before_end.pos)
91
+ end
92
+ end
93
+ end
94
+ end
95
+ end
@@ -15,8 +15,10 @@ module RuboCop
15
15
  # # good
16
16
  # a, b, = foo()
17
17
  # a, = foo()
18
- # *a, b, _ = foo() => We need to know to not include 2 variables in a
19
- # a, *b, _ = foo() => The correction `a, *b, = foo()` is a syntax error
18
+ # *a, b, _ = foo()
19
+ # # => We need to know to not include 2 variables in a
20
+ # a, *b, _ = foo()
21
+ # # => The correction `a, *b, = foo()` is a syntax error
20
22
  #
21
23
  # # good if AllowNamedUnderscoreVariables is true
22
24
  # a, b, _something = foo()
@@ -24,7 +26,7 @@ module RuboCop
24
26
  include SurroundingSpace
25
27
 
26
28
  MSG = 'Do not use trailing `_`s in parallel assignment. ' \
27
- 'Prefer `%s`.'.freeze
29
+ 'Prefer `%<code>s`.'.freeze
28
30
  UNDERSCORE = '_'.freeze
29
31
 
30
32
  def on_masgn(node)
@@ -35,7 +37,9 @@ module RuboCop
35
37
  offset = range.begin_pos - node.source_range.begin_pos
36
38
  good_code[offset, range.size] = ''
37
39
 
38
- add_offense(node, location: range, message: format(MSG, good_code))
40
+ add_offense(node,
41
+ location: range,
42
+ message: format(MSG, code: good_code))
39
43
  end
40
44
  end
41
45
 
@@ -5,8 +5,30 @@ module RuboCop
5
5
  module Style
6
6
  # This cop looks for trivial reader/writer methods, that could
7
7
  # have been created with the attr_* family of functions automatically.
8
+ #
9
+ # @example
10
+ # # bad
11
+ # def foo
12
+ # @foo
13
+ # end
14
+ #
15
+ # def bar=(val)
16
+ # @bar = val
17
+ # end
18
+ #
19
+ # def self.baz
20
+ # @baz
21
+ # end
22
+ #
23
+ # # good
24
+ # attr_reader :foo
25
+ # attr_writer :bar
26
+ #
27
+ # class << self
28
+ # attr_reader :baz
29
+ # end
8
30
  class TrivialAccessors < Cop
9
- MSG = 'Use `attr_%s` to define trivial %s methods.'.freeze
31
+ MSG = 'Use `attr_%<kind>s` to define trivial %<kind>s methods.'.freeze
10
32
 
11
33
  def on_def(node)
12
34
  return if in_module_or_instance_eval?(node)
@@ -16,6 +38,14 @@ module RuboCop
16
38
  end
17
39
  alias on_defs on_def
18
40
 
41
+ def autocorrect(node)
42
+ if node.def_type?
43
+ autocorrect_instance(node)
44
+ elsif node.defs_type? && node.children.first.self_type?
45
+ autocorrect_class(node)
46
+ end
47
+ end
48
+
19
49
  private
20
50
 
21
51
  def in_module_or_instance_eval?(node)
@@ -42,7 +72,7 @@ module RuboCop
42
72
 
43
73
  add_offense(node,
44
74
  location: :keyword,
45
- message: format(MSG, kind, kind))
75
+ message: format(MSG, kind: kind))
46
76
  end
47
77
 
48
78
  def exact_name_match?
@@ -121,14 +151,6 @@ module RuboCop
121
151
  "attr_#{kind} :#{method_name.to_s.chomp('=')}"
122
152
  end
123
153
 
124
- def autocorrect(node)
125
- if node.def_type?
126
- autocorrect_instance(node)
127
- elsif node.defs_type? && node.children.first.self_type?
128
- autocorrect_class(node)
129
- end
130
- end
131
-
132
154
  def autocorrect_instance(node)
133
155
  kind = trivial_accessor_kind(node)
134
156
 
@@ -4,6 +4,21 @@ module RuboCop
4
4
  module Cop
5
5
  module Style
6
6
  # This cop looks for *unless* expressions with *else* clauses.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # unless foo_bar.nil?
11
+ # # do something...
12
+ # else
13
+ # # do a different thing...
14
+ # end
15
+ #
16
+ # # good
17
+ # if foo_bar.present?
18
+ # # do something...
19
+ # else
20
+ # # do a different thing...
21
+ # end
7
22
  class UnlessElse < Cop
8
23
  MSG = 'Do not use `unless` with `else`. Rewrite these with the ' \
9
24
  'positive case first.'.freeze
@@ -4,6 +4,16 @@ module RuboCop
4
4
  module Cop
5
5
  module Style
6
6
  # This cop checks for usage of the %W() syntax when %w() would do.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # %W(cat dog pig)
11
+ # %W[door wall floor]
12
+ #
13
+ # # good
14
+ # %w/swim run bike/
15
+ # %w[shirt pants shoes]
16
+ # %W(apple #{fruit} grape)
7
17
  class UnneededCapitalW < Cop
8
18
  include PercentLiteral
9
19
 
@@ -14,6 +24,13 @@ module RuboCop
14
24
  process(node, '%W')
15
25
  end
16
26
 
27
+ def autocorrect(node)
28
+ lambda do |corrector|
29
+ src = node.loc.begin.source
30
+ corrector.replace(node.loc.begin, src.tr('W', 'w'))
31
+ end
32
+ end
33
+
17
34
  private
18
35
 
19
36
  def on_percent_literal(node)
@@ -28,13 +45,6 @@ module RuboCop
28
45
  double_quotes_required?(string.source)
29
46
  end
30
47
  end
31
-
32
- def autocorrect(node)
33
- lambda do |corrector|
34
- src = node.loc.begin.source
35
- corrector.replace(node.loc.begin, src.tr('W', 'w'))
36
- end
37
- end
38
48
  end
39
49
  end
40
50
  end
@@ -28,21 +28,29 @@ module RuboCop
28
28
  add_offense(node) if single_interpolation?(node)
29
29
  end
30
30
 
31
+ def autocorrect(node)
32
+ embedded_node = node.children.first
33
+
34
+ if variable_interpolation?(embedded_node)
35
+ autocorrect_variable_interpolation(embedded_node, node)
36
+ elsif single_variable_interpolation?(embedded_node)
37
+ autocorrect_single_variable_interpolation(embedded_node, node)
38
+ else
39
+ autocorrect_other(embedded_node, node)
40
+ end
41
+ end
42
+
31
43
  private
32
44
 
33
45
  def single_interpolation?(node)
34
- single_child?(node) &&
46
+ node.children.one? &&
35
47
  interpolation?(node.children.first) &&
36
48
  !implicit_concatenation?(node) &&
37
49
  !embedded_in_percent_array?(node)
38
50
  end
39
51
 
40
52
  def single_variable_interpolation?(node)
41
- single_child?(node) && variable_interpolation?(node.children.first)
42
- end
43
-
44
- def single_child?(node)
45
- node.children.one?
53
+ node.children.one? && variable_interpolation?(node.children.first)
46
54
  end
47
55
 
48
56
  def interpolation?(node)
@@ -62,18 +70,6 @@ module RuboCop
62
70
  percent_literal?(node.parent)
63
71
  end
64
72
 
65
- def autocorrect(node)
66
- embedded_node = node.children.first
67
-
68
- if variable_interpolation?(embedded_node)
69
- autocorrect_variable_interpolation(embedded_node, node)
70
- elsif single_variable_interpolation?(embedded_node)
71
- autocorrect_single_variable_interpolation(embedded_node, node)
72
- else
73
- autocorrect_other(embedded_node, node)
74
- end
75
- end
76
-
77
73
  def autocorrect_variable_interpolation(embedded_node, node)
78
74
  replacement = "#{embedded_node.loc.expression.source}.to_s"
79
75
  ->(corrector) { corrector.replace(node.loc.expression, replacement) }
@@ -5,8 +5,8 @@ module RuboCop
5
5
  module Style
6
6
  # This cop checks for usage of the %q/%Q syntax when '' or "" would do.
7
7
  class UnneededPercentQ < Cop
8
- MSG = 'Use `%s` only for strings that contain both single quotes and ' \
9
- 'double quotes%s.'.freeze
8
+ MSG = 'Use `%<q_type>s` only for strings that contain both ' \
9
+ 'single quotes and double quotes%<extra>s.'.freeze
10
10
  DYNAMIC_MSG = ', or for dynamic strings that contain ' \
11
11
  'double quotes'.freeze
12
12
  SINGLE_QUOTE = "'".freeze
@@ -18,6 +18,7 @@ module RuboCop
18
18
  ESCAPED_NON_BACKSLASH = /\\[^\\]/
19
19
 
20
20
  def on_dstr(node)
21
+ return unless string_literal?(node)
21
22
  check(node)
22
23
  end
23
24
 
@@ -29,6 +30,15 @@ module RuboCop
29
30
  check(node)
30
31
  end
31
32
 
33
+ def autocorrect(node)
34
+ delimiter =
35
+ node.source =~ /^%Q[^"]+$|'/ ? QUOTE : SINGLE_QUOTE
36
+ lambda do |corrector|
37
+ corrector.replace(node.loc.begin, delimiter)
38
+ corrector.replace(node.loc.end, delimiter)
39
+ end
40
+ end
41
+
32
42
  private
33
43
 
34
44
  def check(node)
@@ -55,16 +65,7 @@ module RuboCop
55
65
  else
56
66
  EMPTY
57
67
  end
58
- format(MSG, src[0, 2], extra)
59
- end
60
-
61
- def autocorrect(node)
62
- delimiter =
63
- node.source =~ /^%Q[^"]+$|'/ ? QUOTE : SINGLE_QUOTE
64
- lambda do |corrector|
65
- corrector.replace(node.loc.begin, delimiter)
66
- corrector.replace(node.loc.end, delimiter)
67
- end
68
+ format(MSG, q_type: src[0, 2], extra: extra)
68
69
  end
69
70
 
70
71
  def string_literal?(node)
@@ -4,9 +4,20 @@ module RuboCop
4
4
  module Cop
5
5
  module Style
6
6
  # This cop checks for variable interpolation (like "#@ivar").
7
+ #
8
+ # @example
9
+ # # bad
10
+ # "His name is #$name"
11
+ # /check #$pattern/
12
+ # "Let's go to the #@store"
13
+ #
14
+ # # good
15
+ # "His name is #{$name}"
16
+ # /check #{$pattern}/
17
+ # "Let's go to the #{@store}"
7
18
  class VariableInterpolation < Cop
8
- MSG = 'Replace interpolated variable `%s` ' \
9
- 'with expression `#{%s}`.'.freeze
19
+ MSG = 'Replace interpolated variable `%<variable>s` ' \
20
+ 'with expression `#{%<variable>s}`.'.freeze
10
21
 
11
22
  def on_dstr(node)
12
23
  check_for_interpolation(node)
@@ -20,6 +31,12 @@ module RuboCop
20
31
  check_for_interpolation(node)
21
32
  end
22
33
 
34
+ def autocorrect(node)
35
+ lambda do |corrector|
36
+ corrector.replace(node.source_range, "{#{node.source}}")
37
+ end
38
+ end
39
+
23
40
  private
24
41
 
25
42
  def check_for_interpolation(node)
@@ -29,13 +46,7 @@ module RuboCop
29
46
  end
30
47
 
31
48
  def message(node)
32
- format(MSG, node.source, node.source)
33
- end
34
-
35
- def autocorrect(node)
36
- lambda do |corrector|
37
- corrector.replace(node.source_range, "{#{node.source}}")
38
- end
49
+ format(MSG, variable: node.source)
39
50
  end
40
51
 
41
52
  def var_nodes(nodes)
@@ -4,6 +4,19 @@ module RuboCop
4
4
  module Cop
5
5
  module Style
6
6
  # This cop checks for *when;* uses in *case* expressions.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # case foo
11
+ # when 1; 'baz'
12
+ # when 2; 'bar'
13
+ # end
14
+ #
15
+ # # good
16
+ # case foo
17
+ # when 1 then 'baz'
18
+ # when 2 then 'bar'
19
+ # end
7
20
  class WhenThen < Cop
8
21
  MSG = 'Do not use `when x;`. Use `when x then` instead.'.freeze
9
22
 
@@ -4,8 +4,32 @@ module RuboCop
4
4
  module Cop
5
5
  module Style
6
6
  # Checks for uses of `do` in multi-line `while/until` statements.
7
+ #
8
+ # @example
9
+ #
10
+ # # bad
11
+ # while x.any? do
12
+ # do_something(x.pop)
13
+ # end
14
+ #
15
+ # # good
16
+ # while x.any?
17
+ # do_something(x.pop)
18
+ # end
19
+ #
20
+ # @example
21
+ #
22
+ # # bad
23
+ # until x.empty? do
24
+ # do_something(x.pop)
25
+ # end
26
+ #
27
+ # # good
28
+ # until x.empty?
29
+ # do_something(x.pop)
30
+ # end
7
31
  class WhileUntilDo < Cop
8
- MSG = 'Do not use `do` with multi-line `%s`.'.freeze
32
+ MSG = 'Do not use `do` with multi-line `%<keyword>s`.'.freeze
9
33
 
10
34
  def on_while(node)
11
35
  handle(node)
@@ -19,11 +43,9 @@ module RuboCop
19
43
  return unless node.multiline? && node.do?
20
44
 
21
45
  add_offense(node, location: :begin,
22
- message: format(MSG, node.keyword))
46
+ message: format(MSG, keyword: node.keyword))
23
47
  end
24
48
 
25
- private
26
-
27
49
  def autocorrect(node)
28
50
  do_range = node.condition.source_range.end.join(node.loc.begin)
29
51