rubocop 0.51.0 → 0.52.0

data/lib/rubocop.rb

@@ -32,6 +32,7 @@ require_relative 'rubocop/ast/node/mixin/method_dispatch_node'
 require_relative 'rubocop/ast/node/mixin/modifier_node'
 require_relative 'rubocop/ast/node/mixin/parameterized_node'
 require_relative 'rubocop/ast/node/mixin/predicate_operator_node'
+require_relative 'rubocop/ast/node/mixin/basic_literal_node'
 require_relative 'rubocop/ast/node/and_node'
 require_relative 'rubocop/ast/node/args_node'
 require_relative 'rubocop/ast/node/array_node'
@@ -48,7 +49,9 @@ require_relative 'rubocop/ast/node/pair_node'
 require_relative 'rubocop/ast/node/regexp_node'
 require_relative 'rubocop/ast/node/resbody_node'
 require_relative 'rubocop/ast/node/send_node'
+require_relative 'rubocop/ast/node/str_node'
 require_relative 'rubocop/ast/node/super_node'
+require_relative 'rubocop/ast/node/symbol_node'
 require_relative 'rubocop/ast/node/until_node'
 require_relative 'rubocop/ast/node/when_node'
 require_relative 'rubocop/ast/node/while_node'
@@ -98,6 +101,7 @@ require_relative 'rubocop/cop/mixin/def_node'
 require_relative 'rubocop/cop/mixin/documentation_comment'
 require_relative 'rubocop/cop/mixin/duplication'
 require_relative 'rubocop/cop/mixin/empty_lines_around_body'
+require_relative 'rubocop/cop/mixin/empty_parameter'
 require_relative 'rubocop/cop/mixin/end_keyword_alignment'
 require_relative 'rubocop/cop/mixin/enforce_superclass'
 require_relative 'rubocop/cop/mixin/first_element_line_break'
@@ -126,7 +130,6 @@ require_relative 'rubocop/cop/mixin/safe_mode'
 require_relative 'rubocop/cop/mixin/space_after_punctuation'
 require_relative 'rubocop/cop/mixin/space_before_punctuation'
 require_relative 'rubocop/cop/mixin/surrounding_space'
-require_relative 'rubocop/cop/mixin/space_inside' # relies on surrounding_space
 require_relative 'rubocop/cop/mixin/statement_modifier'
 require_relative 'rubocop/cop/mixin/string_help'
 require_relative 'rubocop/cop/mixin/string_literals_help'
@@ -140,7 +143,9 @@ require_relative 'rubocop/cop/bundler/duplicated_gem'
 require_relative 'rubocop/cop/bundler/insecure_protocol_source'
 require_relative 'rubocop/cop/bundler/ordered_gems'
 
+require_relative 'rubocop/cop/gemspec/duplicated_assignment'
 require_relative 'rubocop/cop/gemspec/ordered_dependencies'
+require_relative 'rubocop/cop/gemspec/required_ruby_version'
 
 require_relative 'rubocop/cop/layout/access_modifier_indentation'
 require_relative 'rubocop/cop/layout/align_array'
@@ -148,6 +153,7 @@ require_relative 'rubocop/cop/layout/align_hash'
 require_relative 'rubocop/cop/layout/align_parameters'
 require_relative 'rubocop/cop/layout/block_end_newline'
 require_relative 'rubocop/cop/layout/case_indentation'
+require_relative 'rubocop/cop/layout/class_structure'
 require_relative 'rubocop/cop/layout/closing_parenthesis_indentation'
 require_relative 'rubocop/cop/layout/comment_indentation'
 require_relative 'rubocop/cop/layout/dot_position'
@@ -155,6 +161,7 @@ require_relative 'rubocop/cop/layout/else_alignment'
 require_relative 'rubocop/cop/layout/empty_line_after_magic_comment'
 require_relative 'rubocop/cop/layout/empty_line_between_defs'
 require_relative 'rubocop/cop/layout/empty_lines_around_access_modifier'
+require_relative 'rubocop/cop/layout/empty_lines_around_arguments'
 require_relative 'rubocop/cop/layout/empty_lines_around_begin_body'
 require_relative 'rubocop/cop/layout/empty_lines_around_block_body'
 require_relative 'rubocop/cop/layout/empty_lines_around_class_body'
@@ -202,12 +209,13 @@ require_relative 'rubocop/cop/layout/space_before_first_arg'
 require_relative 'rubocop/cop/layout/space_before_semicolon'
 require_relative 'rubocop/cop/layout/space_in_lambda_literal'
 require_relative 'rubocop/cop/layout/space_inside_array_percent_literal'
+require_relative 'rubocop/cop/layout/space_inside_array_literal_brackets'
 require_relative 'rubocop/cop/layout/space_inside_block_braces'
-require_relative 'rubocop/cop/layout/space_inside_brackets'
 require_relative 'rubocop/cop/layout/space_inside_hash_literal_braces'
 require_relative 'rubocop/cop/layout/space_inside_parens'
 require_relative 'rubocop/cop/layout/space_inside_percent_literal_delimiters'
 require_relative 'rubocop/cop/layout/space_inside_range_literal'
+require_relative 'rubocop/cop/layout/space_inside_reference_brackets'
 require_relative 'rubocop/cop/layout/space_inside_string_interpolation'
 require_relative 'rubocop/cop/layout/tab'
 require_relative 'rubocop/cop/layout/trailing_blank_lines'
@@ -246,8 +254,10 @@ require_relative 'rubocop/cop/lint/interpolation_check'
 require_relative 'rubocop/cop/lint/literal_as_condition'
 require_relative 'rubocop/cop/lint/literal_in_interpolation'
 require_relative 'rubocop/cop/lint/loop'
+require_relative 'rubocop/cop/lint/missing_cop_enable_directive'
 require_relative 'rubocop/cop/lint/multiple_compare'
 require_relative 'rubocop/cop/lint/nested_method_definition'
+require_relative 'rubocop/cop/lint/nested_percent_literal'
 require_relative 'rubocop/cop/lint/next_without_accumulator'
 require_relative 'rubocop/cop/lint/non_local_exit_from_iterator'
 require_relative 'rubocop/cop/lint/parentheses_as_grouped_expression'
@@ -260,10 +270,10 @@ require_relative 'rubocop/cop/lint/regexp_as_condition'
 require_relative 'rubocop/cop/lint/require_parentheses'
 require_relative 'rubocop/cop/lint/rescue_exception'
 require_relative 'rubocop/cop/lint/rescue_type'
-require_relative 'rubocop/cop/lint/rescue_without_error_class'
 require_relative 'rubocop/cop/lint/return_in_void_context'
 require_relative 'rubocop/cop/lint/safe_navigation_chain'
 require_relative 'rubocop/cop/lint/script_permission'
+require_relative 'rubocop/cop/lint/shadowed_argument'
 require_relative 'rubocop/cop/lint/shadowed_exception'
 require_relative 'rubocop/cop/lint/shadowing_outer_local_variable'
 require_relative 'rubocop/cop/lint/string_conversion_in_interpolation'
@@ -356,6 +366,7 @@ require_relative 'rubocop/cop/style/class_methods'
 require_relative 'rubocop/cop/style/class_vars'
 require_relative 'rubocop/cop/style/collection_methods'
 require_relative 'rubocop/cop/style/colon_method_call'
+require_relative 'rubocop/cop/style/colon_method_definition'
 require_relative 'rubocop/cop/style/command_literal'
 require_relative 'rubocop/cop/style/comment_annotation'
 require_relative 'rubocop/cop/style/commented_keyword'
@@ -369,13 +380,17 @@ require_relative 'rubocop/cop/style/documentation'
 require_relative 'rubocop/cop/style/double_negation'
 require_relative 'rubocop/cop/style/each_for_simple_loop'
 require_relative 'rubocop/cop/style/each_with_object'
+require_relative 'rubocop/cop/style/empty_block_parameter'
 require_relative 'rubocop/cop/style/empty_case_condition'
 require_relative 'rubocop/cop/style/empty_else'
+require_relative 'rubocop/cop/style/empty_lambda_parameter'
 require_relative 'rubocop/cop/style/empty_literal'
 require_relative 'rubocop/cop/style/empty_method'
 require_relative 'rubocop/cop/style/encoding'
 require_relative 'rubocop/cop/style/end_block'
+require_relative 'rubocop/cop/style/eval_with_location'
 require_relative 'rubocop/cop/style/even_odd'
+require_relative 'rubocop/cop/style/extend_self'
 require_relative 'rubocop/cop/style/flip_flop'
 require_relative 'rubocop/cop/style/for'
 require_relative 'rubocop/cop/style/format_string'
@@ -437,6 +452,7 @@ require_relative 'rubocop/cop/style/perl_backrefs'
 require_relative 'rubocop/cop/style/preferred_hash_methods'
 require_relative 'rubocop/cop/style/proc'
 require_relative 'rubocop/cop/style/raise_args'
+require_relative 'rubocop/cop/style/random_with_offset'
 require_relative 'rubocop/cop/style/redundant_begin'
 require_relative 'rubocop/cop/style/redundant_exception'
 require_relative 'rubocop/cop/style/redundant_freeze'
@@ -446,6 +462,7 @@ require_relative 'rubocop/cop/style/redundant_self'
 require_relative 'rubocop/cop/style/redundant_conditional'
 require_relative 'rubocop/cop/style/regexp_literal'
 require_relative 'rubocop/cop/style/rescue_modifier'
+require_relative 'rubocop/cop/style/rescue_standard_error'
 require_relative 'rubocop/cop/style/return_nil'
 require_relative 'rubocop/cop/style/safe_navigation'
 require_relative 'rubocop/cop/style/self_assignment'
@@ -457,6 +474,7 @@ require_relative 'rubocop/cop/style/single_line_methods'
 require_relative 'rubocop/cop/style/special_global_vars'
 require_relative 'rubocop/cop/style/stabby_lambda_parentheses'
 require_relative 'rubocop/cop/style/stderr_puts'
+require_relative 'rubocop/cop/style/string_hash_keys'
 require_relative 'rubocop/cop/style/string_literals'
 require_relative 'rubocop/cop/style/string_literals_in_interpolation'
 require_relative 'rubocop/cop/style/string_methods'
@@ -465,8 +483,10 @@ require_relative 'rubocop/cop/style/symbol_array'
 require_relative 'rubocop/cop/style/symbol_literal'
 require_relative 'rubocop/cop/style/symbol_proc'
 require_relative 'rubocop/cop/style/ternary_parentheses'
+require_relative 'rubocop/cop/style/trailing_body_on_method_definition'
 require_relative 'rubocop/cop/style/trailing_comma_in_arguments'
 require_relative 'rubocop/cop/style/trailing_comma_in_literal'
+require_relative 'rubocop/cop/style/trailing_method_end_statement'
 require_relative 'rubocop/cop/style/trailing_underscore_variable'
 require_relative 'rubocop/cop/style/trivial_accessors'
 require_relative 'rubocop/cop/style/unless_else'
@@ -486,11 +506,13 @@ require_relative 'rubocop/cop/rails/active_support_aliases'
 require_relative 'rubocop/cop/rails/application_job'
 require_relative 'rubocop/cop/rails/application_record'
 require_relative 'rubocop/cop/rails/blank'
+require_relative 'rubocop/cop/rails/create_table_with_timestamps'
 require_relative 'rubocop/cop/rails/date'
 require_relative 'rubocop/cop/rails/dynamic_find_by'
 require_relative 'rubocop/cop/rails/delegate'
 require_relative 'rubocop/cop/rails/delegate_allow_blank'
 require_relative 'rubocop/cop/rails/enum_uniqueness'
+require_relative 'rubocop/cop/rails/environment_comparison'
 require_relative 'rubocop/cop/rails/exit'
 require_relative 'rubocop/cop/rails/file_path'
 require_relative 'rubocop/cop/rails/find_by'
@@ -498,12 +520,16 @@ require_relative 'rubocop/cop/rails/find_each'
 require_relative 'rubocop/cop/rails/has_and_belongs_to_many'
 require_relative 'rubocop/cop/rails/has_many_or_has_one_dependent'
 require_relative 'rubocop/cop/rails/http_positional_arguments'
+require_relative 'rubocop/cop/rails/inverse_of'
+require_relative 'rubocop/cop/rails/lexically_scoped_action_filter'
 require_relative 'rubocop/cop/rails/not_null_column'
 require_relative 'rubocop/cop/rails/output_safety'
 require_relative 'rubocop/cop/rails/output'
 require_relative 'rubocop/cop/rails/pluralization_grammar'
+require_relative 'rubocop/cop/rails/presence'
 require_relative 'rubocop/cop/rails/present'
 require_relative 'rubocop/cop/rails/read_write_attribute'
+require_relative 'rubocop/cop/rails/redundant_receiver_in_with_options'
 require_relative 'rubocop/cop/rails/request_referer'
 require_relative 'rubocop/cop/rails/reversible_migration'
 require_relative 'rubocop/cop/rails/relative_date_constant'
@@ -536,6 +562,7 @@ require_relative 'rubocop/formatter/html_formatter'
 require_relative 'rubocop/formatter/json_formatter'
 require_relative 'rubocop/formatter/offense_count_formatter'
 require_relative 'rubocop/formatter/progress_formatter'
+require_relative 'rubocop/formatter/quiet_formatter'
 require_relative 'rubocop/formatter/tap_formatter'
 require_relative 'rubocop/formatter/worst_offenders_formatter'
 

data/lib/rubocop/ast/builder.rb

@@ -30,7 +30,9 @@ module RuboCop
         RegexpNode       => [:regexp],
         ResbodyNode      => [:resbody],
         SendNode         => %i[csend send],
+        StrNode          => %i[str dstr xstr],
         SuperNode        => %i[super zsuper],
+        SymbolNode       => [:sym],
         UntilNode        => %i[until until_post],
         WhenNode         => [:when],
         WhileNode        => %i[while while_post],

data/lib/rubocop/ast/node.rb

@@ -24,6 +24,7 @@ module RuboCop
 
       # <=> isn't included here, because it doesn't return a boolean.
       COMPARISON_OPERATORS = %i[== === != <= >= > <].freeze
+      ARITHMETIC_OPERATORS = %i[+ - * / % **].freeze
 
       TRUTHY_LITERALS = %i[str dstr xstr int float sym dsym array
                            hash regexp true irange erange complex
@@ -314,11 +315,28 @@ module RuboCop
       ## Predicates
 
       def multiline?
-        source_range && (source_range.first_line != source_range.last_line)
+        line_count > 1
       end
 
       def single_line?
-        !multiline?
+        line_count == 1
+      end
+
+      def line_count
+        return 0 unless source_range
+        source_range.last_line - source_range.first_line + 1
+      end
+
+      def nonempty_line_count
+        source.lines.grep(/\S/).size
+      end
+
+      def empty?
+        length.zero?
+      end
+
+      def length
+        source_range ? source_range.size : 0
       end
 
       def asgn_method_call?
@@ -326,6 +344,10 @@ module RuboCop
           method_name.to_s.end_with?('='.freeze)
       end
 
+      def arithmetic_operation?
+        ARITHMETIC_OPERATORS.include?(method_name)
+      end
+
       def_node_matcher :equals_asgn?, <<-PATTERN
         {lvasgn ivasgn cvasgn gvasgn casgn masgn}
       PATTERN

data/lib/rubocop/ast/node/args_node.rb

@@ -7,6 +7,23 @@ module RuboCop
     # to all `args` nodes within RuboCop.
     class ArgsNode < Node
       include CollectionNode
+
+      # It returns true if arguments are empty, and delimiters do not exist.
+      # @example:
+      #   # true
+      #   def x; end
+      #   x { }
+      #   -> {}
+      #
+      #   # false
+      #   def x(); end
+      #   def x a; end
+      #   x { || }
+      #   -> () {}
+      #   -> a {}
+      def empty_and_without_delimiters?
+        loc.expression.nil?
+      end
     end
   end
 end

data/lib/rubocop/ast/node/array_node.rb

@@ -31,7 +31,7 @@ module RuboCop
       #   Check for any percent literal.
       #
       # @overload percent_literal?(type)
-      #   Check for percent literaly of type `type`.
+      #   Check for percent literal of type `type`.
       #
       #   @param type [Symbol] an optional percent literal type
       #

data/lib/rubocop/ast/node/mixin/basic_literal_node.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # Common functionality for primitive literal nodes: `sym`, `str`,
+    # `int`, `float`, ...
+    module BasicLiteralNode
+      # Returns the value of the literal.
+      #
+      # @return [mixed] the value of the literal
+      def value
+        node_parts[0]
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/send_node.rb

@@ -8,6 +8,7 @@ module RuboCop
     class SendNode < Node
       include ParameterizedNode
       include MethodDispatchNode
+      ARROW = '->'.freeze
 
       # Custom destructuring method. This can be used to normalize
       # destructuring for different variations of the node.
@@ -17,9 +18,28 @@ module RuboCop
         to_a
       end
 
+      # Checks whether this is a negation method, i.e. `!` or keyword `not`.
+      #
+      # @return [Boolean] whether this method is a negation method
       def negation_method?
         keyword_bang? || keyword_not?
       end
+
+      # Checks whether this is a lambda. Some versions of parser parses
+      # non-literal lambdas as a method send.
+      #
+      # @return [Boolean] whether this method is a lambda
+      def lambda?
+        parent && parent.block_type? && method?(:lambda)
+      end
+
+      # Checks whether this is a stabby lambda. e.g. `-> () {}`
+      #
+      # @return [Boolean] whether this method is a staby lambda
+      def stabby_lambda?
+        selector = loc.selector
+        selector && selector.source == ARROW
+      end
     end
   end
 end

data/lib/rubocop/ast/node/str_node.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `str`, `dstr` and `xstr` nodes. This will be used
+    # in place of a plain node when the builder constructs the AST, making
+    # its methods available to all `str` nodes within RuboCop.
+    class StrNode < Node
+      def heredoc?
+        loc.is_a?(Parser::Source::Map::Heredoc)
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/symbol_node.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `sym` nodes. This will be used in  place of a
+    # plain node when the builder constructs the AST, making its methods
+    # available to all `sym` nodes within RuboCop.
+    class SymbolNode < Node
+      include BasicLiteralNode
+
+      # Custom destructuring method. This can be used to normalize
+      # destructuring for different variations of the node.
+      #
+      # @return [Array] the different parts of the `sym` node
+      def node_parts
+        to_a
+      end
+    end
+  end
+end

data/lib/rubocop/ast/traversal.rb

@@ -30,11 +30,11 @@ module RuboCop
                              kwoptarg].freeze
 
       NO_CHILD_NODES.each do |type|
-        module_eval("def on_#{type}(node); end")
+        module_eval("def on_#{type}(node); end", __FILE__, __LINE__)
       end
 
       ONE_CHILD_NODE.each do |type|
-        module_eval(<<-RUBY)
+        module_eval(<<-RUBY, __FILE__, __LINE__ + 1)
           def on_#{type}(node)
             if (child = node.children[0])
               send(:"on_\#{child.type}", child)
@@ -44,7 +44,7 @@ module RuboCop
       end
 
       MANY_CHILD_NODES.each do |type|
-        module_eval(<<-RUBY)
+        module_eval(<<-RUBY, __FILE__, __LINE__ + 1)
           def on_#{type}(node)
             node.children.each { |child| send(:"on_\#{child.type}", child) }
             nil
@@ -54,7 +54,7 @@ module RuboCop
 
       SECOND_CHILD_ONLY.each do |type|
         # Guard clause is for nodes nested within mlhs
-        module_eval(<<-RUBY)
+        module_eval(<<-RUBY, __FILE__, __LINE__ + 1)
           def on_#{type}(node)
             if (child = node.children[1])
               send(:"on_\#{child.type}", child)

data/lib/rubocop/cli.rb

@@ -28,8 +28,7 @@ module RuboCop
       validate_options_vs_config
       act_on_options
       apply_default_formatter
-
-      execute_runner(paths)
+      execute_runners(paths)
     rescue RuboCop::Error => e
       warn Rainbow("Error: #{e.message}").red
       return 2
@@ -52,6 +51,48 @@ module RuboCop
 
     private
 
+    def execute_runners(paths)
+      if @options[:auto_gen_config]
+        reset_config_and_auto_gen_file
+        line_length_contents = run_line_length_cop_auto_gen_config(paths)
+        run_all_cops_auto_gen_config(line_length_contents, paths)
+      else
+        execute_runner(paths)
+      end
+    end
+
+    # Do an initial run with only Metrics/LineLength so that cops that depend
+    # on Metrics/LineLength:Max get the correct value for that parameter.
+    def run_line_length_cop_auto_gen_config(paths)
+      puts Rainbow('Phase 1 of 2: run Metrics/LineLength cop').yellow
+      @options[:only] = ['Metrics/LineLength']
+      execute_runner(paths)
+      @options.delete(:only)
+      @config_store = ConfigStore.new
+      # Save the todo configuration of the LineLength cop.
+      IO.read(ConfigLoader::AUTO_GENERATED_FILE)
+        .lines
+        .drop_while { |line| line.start_with?('#') }
+        .join
+    end
+
+    def run_all_cops_auto_gen_config(line_length_contents, paths)
+      puts Rainbow('Phase 2 of 2: run all cops').yellow
+      result = execute_runner(paths)
+      # This run was made with the current maximum length allowed, so append
+      # the saved setting for LineLength.
+      File.open(ConfigLoader::AUTO_GENERATED_FILE, 'a') do |f|
+        f.write(line_length_contents)
+      end
+      result
+    end
+
+    def reset_config_and_auto_gen_file
+      @config_store = ConfigStore.new
+      File.open(ConfigLoader::AUTO_GENERATED_FILE, 'w'){}
+      ConfigLoader.add_inheritance_from_auto_generated_file
+    end
+
     def validate_options_vs_config
       if @options[:parallel] &&
          !@config_store.for(Dir.pwd).for_all_cops['UseCache']
@@ -62,8 +103,6 @@ module RuboCop
     end
 
     def act_on_options
-      handle_exiting_options
-
       ConfigLoader.debug = @options[:debug]
       ConfigLoader.auto_gen_config = @options[:auto_gen_config]
       ConfigLoader.ignore_parent_exclusion = @options[:ignore_parent_exclusion]
@@ -71,6 +110,8 @@ module RuboCop
       @config_store.options_config = @options[:config] if @options[:config]
       @config_store.force_default_config! if @options[:force_default_config]
 
+      handle_exiting_options
+
       if @options[:color]
         # color output explicitly forced on
         Rainbow.enabled = true