rubocop 0.51.0 → 0.52.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +1 -2
  3. data/config/default.yml +86 -10
  4. data/config/disabled.yml +9 -4
  5. data/config/enabled.yml +1105 -1006
  6. data/lib/rubocop.rb +30 -3
  7. data/lib/rubocop/ast/builder.rb +2 -0
  8. data/lib/rubocop/ast/node.rb +24 -2
  9. data/lib/rubocop/ast/node/args_node.rb +17 -0
  10. data/lib/rubocop/ast/node/array_node.rb +1 -1
  11. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +16 -0
  12. data/lib/rubocop/ast/node/send_node.rb +20 -0
  13. data/lib/rubocop/ast/node/str_node.rb +14 -0
  14. data/lib/rubocop/ast/node/symbol_node.rb +20 -0
  15. data/lib/rubocop/ast/traversal.rb +4 -4
  16. data/lib/rubocop/cli.rb +45 -4
  17. data/lib/rubocop/comment_config.rb +2 -5
  18. data/lib/rubocop/config.rb +42 -8
  19. data/lib/rubocop/config_loader.rb +39 -100
  20. data/lib/rubocop/config_loader_resolver.rb +99 -2
  21. data/lib/rubocop/cop/autocorrect_logic.rb +1 -1
  22. data/lib/rubocop/cop/bundler/duplicated_gem.rb +7 -7
  23. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +4 -3
  24. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  25. data/lib/rubocop/cop/cop.rb +16 -46
  26. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +102 -0
  27. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -2
  28. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +87 -0
  29. data/lib/rubocop/cop/generator.rb +23 -4
  30. data/lib/rubocop/cop/internal_affairs.rb +1 -1
  31. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +46 -0
  32. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +2 -2
  33. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +9 -8
  34. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  35. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  36. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +4 -7
  37. data/lib/rubocop/cop/layout/align_hash.rb +16 -16
  38. data/lib/rubocop/cop/layout/align_parameters.rb +6 -12
  39. data/lib/rubocop/cop/layout/block_end_newline.rb +19 -5
  40. data/lib/rubocop/cop/layout/case_indentation.rb +14 -17
  41. data/lib/rubocop/cop/layout/class_structure.rb +306 -0
  42. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -0
  43. data/lib/rubocop/cop/layout/comment_indentation.rb +39 -2
  44. data/lib/rubocop/cop/layout/dot_position.rb +22 -13
  45. data/lib/rubocop/cop/layout/else_alignment.rb +6 -6
  46. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +17 -17
  47. data/lib/rubocop/cop/layout/empty_lines.rb +15 -1
  48. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +3 -2
  49. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +89 -0
  50. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -2
  51. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -8
  52. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +30 -5
  53. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +7 -3
  54. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -2
  55. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +22 -7
  56. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  57. data/lib/rubocop/cop/layout/extra_spacing.rb +21 -24
  58. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +4 -1
  59. data/lib/rubocop/cop/layout/indent_array.rb +67 -20
  60. data/lib/rubocop/cop/layout/indent_hash.rb +70 -25
  61. data/lib/rubocop/cop/layout/indent_heredoc.rb +51 -11
  62. data/lib/rubocop/cop/layout/indentation_width.rb +24 -17
  63. data/lib/rubocop/cop/layout/initial_indentation.rb +7 -5
  64. data/lib/rubocop/cop/layout/leading_comment_space.rb +2 -2
  65. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +47 -14
  66. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +10 -9
  67. data/lib/rubocop/cop/layout/multiline_block_layout.rb +19 -16
  68. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +46 -13
  69. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +9 -10
  70. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +4 -0
  71. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +9 -3
  72. data/lib/rubocop/cop/layout/space_after_colon.rb +4 -4
  73. data/lib/rubocop/cop/layout/space_after_comma.rb +3 -3
  74. data/lib/rubocop/cop/layout/space_after_method_name.rb +4 -4
  75. data/lib/rubocop/cop/layout/space_after_semicolon.rb +8 -1
  76. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +16 -19
  77. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +27 -16
  78. data/lib/rubocop/cop/layout/space_around_keyword.rb +13 -11
  79. data/lib/rubocop/cop/layout/space_around_operators.rb +26 -13
  80. data/lib/rubocop/cop/layout/space_before_block_braces.rb +10 -10
  81. data/lib/rubocop/cop/layout/space_before_comma.rb +12 -1
  82. data/lib/rubocop/cop/layout/space_before_comment.rb +2 -4
  83. data/lib/rubocop/cop/layout/space_before_first_arg.rb +4 -3
  84. data/lib/rubocop/cop/layout/space_before_semicolon.rb +1 -1
  85. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +6 -12
  86. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +235 -0
  87. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -3
  88. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +87 -16
  89. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +57 -34
  90. data/lib/rubocop/cop/layout/space_inside_parens.rb +31 -3
  91. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +15 -15
  92. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +81 -0
  93. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -13
  94. data/lib/rubocop/cop/layout/tab.rb +2 -2
  95. data/lib/rubocop/cop/layout/trailing_blank_lines.rb +7 -7
  96. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +11 -20
  97. data/lib/rubocop/cop/lint/block_alignment.rb +26 -23
  98. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  99. data/lib/rubocop/cop/lint/def_end_alignment.rb +5 -10
  100. data/lib/rubocop/cop/lint/else_layout.rb +2 -2
  101. data/lib/rubocop/cop/lint/end_alignment.rb +13 -14
  102. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +3 -4
  103. data/lib/rubocop/cop/lint/inherit_exception.rb +10 -14
  104. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +81 -0
  105. data/lib/rubocop/cop/lint/nested_percent_literal.rb +58 -0
  106. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
  107. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -1
  108. data/lib/rubocop/cop/lint/percent_string_array.rb +14 -14
  109. data/lib/rubocop/cop/lint/percent_symbol_array.rb +11 -11
  110. data/lib/rubocop/cop/lint/redundant_with_index.rb +6 -3
  111. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
  112. data/lib/rubocop/cop/lint/require_parentheses.rb +3 -1
  113. data/lib/rubocop/cop/lint/rescue_type.rb +3 -3
  114. data/lib/rubocop/cop/lint/script_permission.rb +1 -0
  115. data/lib/rubocop/cop/lint/shadowed_argument.rb +146 -0
  116. data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +6 -6
  117. data/lib/rubocop/cop/lint/unneeded_disable.rb +29 -11
  118. data/lib/rubocop/cop/lint/unneeded_require_statement.rb +2 -1
  119. data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +43 -17
  120. data/lib/rubocop/cop/message_annotator.rb +4 -2
  121. data/lib/rubocop/cop/metrics/abc_size.rb +2 -2
  122. data/lib/rubocop/cop/metrics/class_length.rb +3 -1
  123. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -1
  124. data/lib/rubocop/cop/metrics/line_length.rb +2 -2
  125. data/lib/rubocop/cop/metrics/module_length.rb +3 -1
  126. data/lib/rubocop/cop/metrics/parameter_lists.rb +9 -2
  127. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -1
  128. data/lib/rubocop/cop/mixin/documentation_comment.rb +1 -1
  129. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +7 -5
  130. data/lib/rubocop/cop/mixin/empty_parameter.rb +23 -0
  131. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +7 -3
  132. data/lib/rubocop/cop/mixin/heredoc.rb +19 -19
  133. data/lib/rubocop/cop/mixin/method_complexity.rb +32 -8
  134. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +7 -3
  135. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +6 -4
  136. data/lib/rubocop/cop/mixin/negative_conditional.rb +3 -0
  137. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -12
  138. data/lib/rubocop/cop/mixin/parentheses.rb +12 -0
  139. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +8 -8
  140. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +10 -10
  141. data/lib/rubocop/cop/mixin/statement_modifier.rb +7 -17
  142. data/lib/rubocop/cop/mixin/surrounding_space.rb +95 -8
  143. data/lib/rubocop/cop/mixin/too_many_lines.rb +2 -2
  144. data/lib/rubocop/cop/mixin/trailing_comma.rb +22 -14
  145. data/lib/rubocop/cop/mixin/unused_argument.rb +3 -40
  146. data/lib/rubocop/cop/naming/accessor_method_name.rb +20 -10
  147. data/lib/rubocop/cop/naming/ascii_identifiers.rb +33 -0
  148. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +5 -4
  149. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -12
  150. data/lib/rubocop/cop/naming/constant_name.rb +32 -3
  151. data/lib/rubocop/cop/naming/file_name.rb +19 -8
  152. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +10 -16
  153. data/lib/rubocop/cop/naming/method_name.rb +20 -14
  154. data/lib/rubocop/cop/naming/predicate_name.rb +7 -3
  155. data/lib/rubocop/cop/naming/variable_name.rb +17 -2
  156. data/lib/rubocop/cop/naming/variable_number.rb +10 -27
  157. data/lib/rubocop/cop/offense.rb +6 -1
  158. data/lib/rubocop/cop/performance/case_when_splat.rb +2 -6
  159. data/lib/rubocop/cop/performance/casecmp.rb +5 -4
  160. data/lib/rubocop/cop/performance/compare_with_block.rb +13 -7
  161. data/lib/rubocop/cop/performance/count.rb +5 -4
  162. data/lib/rubocop/cop/performance/detect.rb +7 -4
  163. data/lib/rubocop/cop/performance/double_start_end_with.rb +2 -7
  164. data/lib/rubocop/cop/performance/end_with.rb +2 -2
  165. data/lib/rubocop/cop/performance/flat_map.rb +3 -2
  166. data/lib/rubocop/cop/performance/hash_each_methods.rb +41 -40
  167. data/lib/rubocop/cop/performance/lstrip_rstrip.rb +5 -4
  168. data/lib/rubocop/cop/performance/redundant_block_call.rb +22 -22
  169. data/lib/rubocop/cop/performance/redundant_match.rb +2 -2
  170. data/lib/rubocop/cop/performance/redundant_merge.rb +6 -4
  171. data/lib/rubocop/cop/performance/redundant_sort_by.rb +4 -4
  172. data/lib/rubocop/cop/performance/regexp_match.rb +3 -2
  173. data/lib/rubocop/cop/performance/size.rb +2 -2
  174. data/lib/rubocop/cop/performance/start_with.rb +2 -2
  175. data/lib/rubocop/cop/performance/string_replacement.rb +4 -4
  176. data/lib/rubocop/cop/performance/times_map.rb +14 -15
  177. data/lib/rubocop/cop/performance/uri_default_parser.rb +3 -3
  178. data/lib/rubocop/cop/rails/action_filter.rb +22 -0
  179. data/lib/rubocop/cop/rails/active_support_aliases.rb +2 -2
  180. data/lib/rubocop/cop/rails/application_job.rb +4 -2
  181. data/lib/rubocop/cop/rails/application_record.rb +4 -2
  182. data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +82 -0
  183. data/lib/rubocop/cop/rails/delegate.rb +20 -25
  184. data/lib/rubocop/cop/rails/delegate_allow_blank.rb +2 -2
  185. data/lib/rubocop/cop/rails/environment_comparison.rb +66 -0
  186. data/lib/rubocop/cop/rails/exit.rb +7 -0
  187. data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +7 -0
  188. data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +6 -2
  189. data/lib/rubocop/cop/rails/http_positional_arguments.rb +36 -41
  190. data/lib/rubocop/cop/rails/inverse_of.rb +96 -0
  191. data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +112 -0
  192. data/lib/rubocop/cop/rails/output.rb +9 -0
  193. data/lib/rubocop/cop/rails/output_safety.rb +14 -20
  194. data/lib/rubocop/cop/rails/pluralization_grammar.rb +8 -8
  195. data/lib/rubocop/cop/rails/presence.rb +105 -0
  196. data/lib/rubocop/cop/rails/read_write_attribute.rb +10 -10
  197. data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +91 -0
  198. data/lib/rubocop/cop/rails/relative_date_constant.rb +9 -9
  199. data/lib/rubocop/cop/rails/reversible_migration.rb +3 -4
  200. data/lib/rubocop/cop/rails/safe_navigation.rb +5 -6
  201. data/lib/rubocop/cop/rails/save_bang.rb +2 -2
  202. data/lib/rubocop/cop/rails/uniq_before_pluck.rb +1 -1
  203. data/lib/rubocop/cop/rails/validation.rb +7 -7
  204. data/lib/rubocop/cop/security/json_load.rb +4 -2
  205. data/lib/rubocop/cop/security/marshal_load.rb +4 -2
  206. data/lib/rubocop/cop/style/alias.rb +24 -26
  207. data/lib/rubocop/cop/style/and_or.rb +34 -28
  208. data/lib/rubocop/cop/style/array_join.rb +9 -0
  209. data/lib/rubocop/cop/style/ascii_comments.rb +24 -4
  210. data/lib/rubocop/cop/style/attr.rb +14 -4
  211. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +5 -3
  212. data/lib/rubocop/cop/style/bare_percent_literals.rb +31 -10
  213. data/lib/rubocop/cop/style/block_comments.rb +14 -2
  214. data/lib/rubocop/cop/style/block_delimiters.rb +80 -15
  215. data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +81 -48
  216. data/lib/rubocop/cop/style/case_equality.rb +12 -0
  217. data/lib/rubocop/cop/style/character_literal.rb +10 -0
  218. data/lib/rubocop/cop/style/class_and_module_children.rb +6 -2
  219. data/lib/rubocop/cop/style/class_check.rb +28 -9
  220. data/lib/rubocop/cop/style/class_methods.rb +8 -8
  221. data/lib/rubocop/cop/style/class_vars.rb +4 -3
  222. data/lib/rubocop/cop/style/collection_methods.rb +4 -2
  223. data/lib/rubocop/cop/style/colon_method_call.rb +16 -0
  224. data/lib/rubocop/cop/style/colon_method_definition.rb +36 -0
  225. data/lib/rubocop/cop/style/command_literal.rb +70 -21
  226. data/lib/rubocop/cop/style/comment_annotation.rb +35 -10
  227. data/lib/rubocop/cop/style/commented_keyword.rb +12 -9
  228. data/lib/rubocop/cop/style/conditional_assignment.rb +10 -12
  229. data/lib/rubocop/cop/style/copyright.rb +19 -20
  230. data/lib/rubocop/cop/style/date_time.rb +2 -2
  231. data/lib/rubocop/cop/style/def_with_parentheses.rb +27 -2
  232. data/lib/rubocop/cop/style/dir.rb +2 -2
  233. data/lib/rubocop/cop/style/documentation.rb +17 -2
  234. data/lib/rubocop/cop/style/each_for_simple_loop.rb +7 -7
  235. data/lib/rubocop/cop/style/each_with_object.rb +5 -5
  236. data/lib/rubocop/cop/style/empty_block_parameter.rb +47 -0
  237. data/lib/rubocop/cop/style/empty_case_condition.rb +2 -2
  238. data/lib/rubocop/cop/style/empty_else.rb +52 -22
  239. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +43 -0
  240. data/lib/rubocop/cop/style/empty_literal.rb +17 -5
  241. data/lib/rubocop/cop/style/empty_method.rb +4 -10
  242. data/lib/rubocop/cop/style/encoding.rb +2 -1
  243. data/lib/rubocop/cop/style/eval_with_location.rb +146 -0
  244. data/lib/rubocop/cop/style/even_odd.rb +4 -2
  245. data/lib/rubocop/cop/style/extend_self.rb +92 -0
  246. data/lib/rubocop/cop/style/flip_flop.rb +11 -0
  247. data/lib/rubocop/cop/style/format_string.rb +29 -2
  248. data/lib/rubocop/cop/style/format_string_token.rb +15 -14
  249. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +4 -3
  250. data/lib/rubocop/cop/style/global_vars.rb +11 -1
  251. data/lib/rubocop/cop/style/hash_syntax.rb +44 -43
  252. data/lib/rubocop/cop/style/identical_conditional_branches.rb +8 -8
  253. data/lib/rubocop/cop/style/if_inside_else.rb +10 -10
  254. data/lib/rubocop/cop/style/if_unless_modifier.rb +7 -7
  255. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +2 -2
  256. data/lib/rubocop/cop/style/if_with_semicolon.rb +9 -0
  257. data/lib/rubocop/cop/style/implicit_runtime_error.rb +5 -5
  258. data/lib/rubocop/cop/style/infinite_loop.rb +2 -2
  259. data/lib/rubocop/cop/style/lambda.rb +23 -31
  260. data/lib/rubocop/cop/style/lambda_call.rb +15 -9
  261. data/lib/rubocop/cop/style/line_end_concatenation.rb +4 -4
  262. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -2
  263. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +2 -2
  264. data/lib/rubocop/cop/style/method_def_parentheses.rb +4 -3
  265. data/lib/rubocop/cop/style/method_missing.rb +8 -8
  266. data/lib/rubocop/cop/style/min_max.rb +12 -12
  267. data/lib/rubocop/cop/style/missing_else.rb +5 -4
  268. data/lib/rubocop/cop/style/mixin_grouping.rb +29 -19
  269. data/lib/rubocop/cop/style/mixin_usage.rb +8 -10
  270. data/lib/rubocop/cop/style/module_function.rb +17 -5
  271. data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -4
  272. data/lib/rubocop/cop/style/multiline_if_then.rb +14 -13
  273. data/lib/rubocop/cop/style/multiline_memoization.rb +8 -14
  274. data/lib/rubocop/cop/style/mutable_constant.rb +12 -12
  275. data/lib/rubocop/cop/style/negated_if.rb +22 -30
  276. data/lib/rubocop/cop/style/negated_while.rb +1 -5
  277. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +18 -17
  278. data/lib/rubocop/cop/style/next.rb +39 -11
  279. data/lib/rubocop/cop/style/nil_comparison.rb +6 -6
  280. data/lib/rubocop/cop/style/non_nil_check.rb +25 -22
  281. data/lib/rubocop/cop/style/not.rb +14 -4
  282. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -6
  283. data/lib/rubocop/cop/style/numeric_literals.rb +7 -7
  284. data/lib/rubocop/cop/style/numeric_predicate.rb +14 -18
  285. data/lib/rubocop/cop/style/one_line_conditional.rb +4 -4
  286. data/lib/rubocop/cop/style/option_hash.rb +11 -14
  287. data/lib/rubocop/cop/style/or_assignment.rb +2 -2
  288. data/lib/rubocop/cop/style/parallel_assignment.rb +13 -13
  289. data/lib/rubocop/cop/style/parentheses_around_condition.rb +19 -3
  290. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +24 -3
  291. data/lib/rubocop/cop/style/percent_q_literals.rb +27 -6
  292. data/lib/rubocop/cop/style/perl_backrefs.rb +7 -0
  293. data/lib/rubocop/cop/style/preferred_hash_methods.rb +6 -10
  294. data/lib/rubocop/cop/style/proc.rb +8 -0
  295. data/lib/rubocop/cop/style/raise_args.rb +8 -14
  296. data/lib/rubocop/cop/style/random_with_offset.rb +160 -0
  297. data/lib/rubocop/cop/style/redundant_begin.rb +14 -4
  298. data/lib/rubocop/cop/style/redundant_conditional.rb +9 -8
  299. data/lib/rubocop/cop/style/redundant_return.rb +5 -4
  300. data/lib/rubocop/cop/style/redundant_self.rb +25 -26
  301. data/lib/rubocop/cop/style/regexp_literal.rb +74 -21
  302. data/lib/rubocop/cop/style/rescue_modifier.rb +11 -0
  303. data/lib/rubocop/cop/style/rescue_standard_error.rb +122 -0
  304. data/lib/rubocop/cop/style/return_nil.rb +4 -8
  305. data/lib/rubocop/cop/style/safe_navigation.rb +20 -2
  306. data/lib/rubocop/cop/style/self_assignment.rb +13 -13
  307. data/lib/rubocop/cop/style/semicolon.rb +18 -8
  308. data/lib/rubocop/cop/style/send.rb +9 -0
  309. data/lib/rubocop/cop/style/signal_exception.rb +100 -0
  310. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  311. data/lib/rubocop/cop/style/single_line_methods.rb +20 -8
  312. data/lib/rubocop/cop/style/special_global_vars.rb +16 -11
  313. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +7 -12
  314. data/lib/rubocop/cop/style/stderr_puts.rb +5 -3
  315. data/lib/rubocop/cop/style/string_hash_keys.rb +36 -0
  316. data/lib/rubocop/cop/style/string_literals.rb +22 -0
  317. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +2 -8
  318. data/lib/rubocop/cop/style/string_methods.rb +18 -7
  319. data/lib/rubocop/cop/style/symbol_array.rb +5 -9
  320. data/lib/rubocop/cop/style/symbol_proc.rb +5 -4
  321. data/lib/rubocop/cop/style/ternary_parentheses.rb +31 -40
  322. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +101 -0
  323. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +20 -6
  324. data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +22 -7
  325. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +95 -0
  326. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -4
  327. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -10
  328. data/lib/rubocop/cop/style/unless_else.rb +15 -0
  329. data/lib/rubocop/cop/style/unneeded_capital_w.rb +17 -7
  330. data/lib/rubocop/cop/style/unneeded_interpolation.rb +14 -18
  331. data/lib/rubocop/cop/style/unneeded_percent_q.rb +13 -12
  332. data/lib/rubocop/cop/style/variable_interpolation.rb +20 -9
  333. data/lib/rubocop/cop/style/when_then.rb +13 -0
  334. data/lib/rubocop/cop/style/while_until_do.rb +26 -4
  335. data/lib/rubocop/cop/style/while_until_modifier.rb +25 -6
  336. data/lib/rubocop/cop/style/word_array.rb +4 -8
  337. data/lib/rubocop/cop/style/yoda_condition.rb +10 -16
  338. data/lib/rubocop/cop/style/zero_length_predicate.rb +23 -15
  339. data/lib/rubocop/cop/util.rb +42 -33
  340. data/lib/rubocop/cop/variable_force.rb +1 -1
  341. data/lib/rubocop/cop/variable_force/assignment.rb +4 -2
  342. data/lib/rubocop/cop/variable_force/scope.rb +1 -5
  343. data/lib/rubocop/cop/variable_force/variable.rb +1 -1
  344. data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -3
  345. data/lib/rubocop/formatter/formatter_set.rb +2 -1
  346. data/lib/rubocop/formatter/json_formatter.rb +9 -3
  347. data/lib/rubocop/formatter/quiet_formatter.rb +13 -0
  348. data/lib/rubocop/node_pattern.rb +2 -3
  349. data/lib/rubocop/options.rb +8 -8
  350. data/lib/rubocop/path_util.rb +15 -3
  351. data/lib/rubocop/processed_source.rb +5 -2
  352. data/lib/rubocop/rspec/shared_contexts.rb +4 -0
  353. data/lib/rubocop/runner.rb +1 -1
  354. data/lib/rubocop/token.rb +74 -0
  355. data/lib/rubocop/version.rb +1 -1
  356. metadata +37 -10
  357. data/lib/rubocop/cop/internal_affairs/deprecated_positional_arguments.rb +0 -81
  358. data/lib/rubocop/cop/layout/space_inside_brackets.rb +0 -20
  359. data/lib/rubocop/cop/lint/rescue_without_error_class.rb +0 -41
  360. data/lib/rubocop/cop/mixin/space_inside.rb +0 -76
@@ -14,60 +14,54 @@ module RuboCop
14
14
  #
15
15
  # # bad
16
16
  # "<p>#{user_content}</p>".html_safe
17
- # => ActiveSupport::SafeBuffer
18
- # "<p><b>hi</b></p>"
17
+ # # => ActiveSupport::SafeBuffer "<p><b>hi</b></p>"
19
18
  #
20
19
  # # good
21
20
  # content_tag(:p, user_content)
22
- # => ActiveSupport::SafeBuffer
23
- # "<p>&lt;b&gt;hi&lt;/b&gt;</p>"
21
+ # # => ActiveSupport::SafeBuffer "<p>&lt;b&gt;hi&lt;/b&gt;</p>"
24
22
  #
25
23
  # # bad
26
24
  # out = ""
27
25
  # out << "<li>#{user_content}</li>"
28
26
  # out << "<li>#{user_content}</li>"
29
27
  # out.html_safe
30
- # => ActiveSupport::SafeBuffer
31
- # "<li><b>hi</b></li><li><b>hi</b></li>"
28
+ # # => ActiveSupport::SafeBuffer "<li><b>hi</b></li><li><b>hi</b></li>"
32
29
  #
33
30
  # # good
34
31
  # out = []
35
32
  # out << content_tag(:li, user_content)
36
33
  # out << content_tag(:li, user_content)
37
34
  # safe_join(out)
38
- # => ActiveSupport::SafeBuffer
39
- # "<li>&lt;b&gt;hi&lt;/b&gt;</li><li>&lt;b&gt;hi&lt;/b&gt;</li>"
35
+ # # => ActiveSupport::SafeBuffer
36
+ # # "<li>&lt;b&gt;hi&lt;/b&gt;</li><li>&lt;b&gt;hi&lt;/b&gt;</li>"
40
37
  #
41
38
  # # bad
42
39
  # out = "<h1>trusted content</h1>".html_safe
43
40
  # out.safe_concat(user_content)
44
- # => ActiveSupport::SafeBuffer
45
- # "<h1>trusted_content</h1><b>hi</b>"
41
+ # # => ActiveSupport::SafeBuffer "<h1>trusted_content</h1><b>hi</b>"
46
42
  #
47
43
  # # good
48
44
  # out = "<h1>trusted content</h1>".html_safe
49
45
  # out.concat(user_content)
50
- # => ActiveSupport::SafeBuffer
51
- # "<h1>trusted_content</h1>&lt;b&gt;hi&lt;/b&gt;"
46
+ # # => ActiveSupport::SafeBuffer
47
+ # # "<h1>trusted_content</h1>&lt;b&gt;hi&lt;/b&gt;"
52
48
  #
53
49
  # # safe, though maybe not good style
54
50
  # out = "trusted content"
55
51
  # result = out.concat(user_content)
56
- # => String "trusted content<b>hi</b>"
52
+ # # => String "trusted content<b>hi</b>"
57
53
  # # because when rendered in ERB the String will be escaped:
58
- # <%= result %>
59
- # => trusted content&lt;b&gt;hi&lt;/b&gt;
54
+ # # <%= result %>
55
+ # # => trusted content&lt;b&gt;hi&lt;/b&gt;
60
56
  #
61
57
  # # bad
62
58
  # (user_content + " " + content_tag(:span, user_content)).html_safe
63
- # => ActiveSupport::SafeBuffer
64
- # "<b>hi</b> <span><b>hi</b></span>"
59
+ # # => ActiveSupport::SafeBuffer "<b>hi</b> <span><b>hi</b></span>"
65
60
  #
66
61
  # # good
67
62
  # safe_join([user_content, " ", content_tag(:span, user_content)])
68
- # => ActiveSupport::SafeBuffer
69
- # "&lt;b&gt;hi&lt;/b&gt; <span>&lt;b&gt;hi&lt;/b&gt;</span>"
70
- #
63
+ # # => ActiveSupport::SafeBuffer
64
+ # # "&lt;b&gt;hi&lt;/b&gt; <span>&lt;b&gt;hi&lt;/b&gt;</span>"
71
65
  class OutputSafety < Cop
72
66
  MSG = 'Tagging a string as html safe may be a security risk.'.freeze
73
67
 
@@ -37,14 +37,6 @@ module RuboCop
37
37
  add_offense(node)
38
38
  end
39
39
 
40
- private
41
-
42
- def message(node)
43
- number, = *node.receiver
44
-
45
- format(MSG, number, correct_method(node.method_name.to_s))
46
- end
47
-
48
40
  def autocorrect(node)
49
41
  lambda do |corrector|
50
42
  method_name = node.loc.selector.source
@@ -53,6 +45,14 @@ module RuboCop
53
45
  end
54
46
  end
55
47
 
48
+ private
49
+
50
+ def message(node)
51
+ number, = *node.receiver
52
+
53
+ format(MSG, number, correct_method(node.method_name.to_s))
54
+ end
55
+
56
56
  def correct_method(method_name)
57
57
  if plural_method?(method_name)
58
58
  singularize(method_name)
@@ -0,0 +1,105 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Rails
6
+ # This cop checks code that can be written more easily using
7
+ # `Object#presence` defined by Active Support.
8
+ #
9
+ # @example
10
+ # # bad
11
+ # a.present? ? a : nil
12
+ #
13
+ # # bad
14
+ # !a.present? ? nil : a
15
+ #
16
+ # # bad
17
+ # a.blank? ? nil : a
18
+ #
19
+ # # bad
20
+ # !a.blank? ? a : nil
21
+ #
22
+ # # good
23
+ # a.presence
24
+ #
25
+ # @example
26
+ # # bad
27
+ # a.present? ? a : b
28
+ #
29
+ # # bad
30
+ # !a.present? ? b : a
31
+ #
32
+ # # bad
33
+ # a.blank? ? b : a
34
+ #
35
+ # # bad
36
+ # !a.blank? ? a : b
37
+ #
38
+ # # good
39
+ # a.presence || b
40
+ class Presence < Cop
41
+ MSG = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze
42
+
43
+ def_node_matcher :redundant_receiver_and_other, <<-PATTERN
44
+ {
45
+ (if
46
+ (send $_recv :present?)
47
+ _recv
48
+ $_false
49
+ )
50
+ (if
51
+ (send $_recv :blank?)
52
+ $_true
53
+ _recv
54
+ )
55
+ }
56
+ PATTERN
57
+
58
+ def_node_matcher :redundant_negative_receiver_and_other, <<-PATTERN
59
+ {
60
+ (if
61
+ (send (send $_recv :present?) :!)
62
+ $_true
63
+ _recv
64
+ )
65
+ (if
66
+ (send (send $_recv :blank?) :!)
67
+ _recv
68
+ $_false
69
+ )
70
+ }
71
+ PATTERN
72
+
73
+ def on_if(node)
74
+ receiver, other = redundant_receiver_and_other(node)
75
+ unless receiver
76
+ receiver, other = redundant_negative_receiver_and_other(node)
77
+ end
78
+ return unless receiver
79
+ message = format(MSG,
80
+ prefer: replacement(receiver, other),
81
+ current: node.source)
82
+ add_offense(node, message: message)
83
+ end
84
+
85
+ def autocorrect(node)
86
+ lambda do |corrector|
87
+ receiver, other = redundant_receiver_and_other(node)
88
+ unless receiver
89
+ receiver, other = redundant_negative_receiver_and_other(node)
90
+ end
91
+ return unless receiver
92
+ corrector.replace(node.source_range, replacement(receiver, other))
93
+ end
94
+ end
95
+
96
+ private
97
+
98
+ def replacement(receiver, other)
99
+ or_source = other.nil_type? ? '' : " || #{other.source}"
100
+ "#{receiver.source}.presence" + or_source
101
+ end
102
+ end
103
+ end
104
+ end
105
+ end
@@ -31,16 +31,6 @@ module RuboCop
31
31
  add_offense(node, location: :selector)
32
32
  end
33
33
 
34
- private
35
-
36
- def message(node)
37
- if node.method?(:read_attribute)
38
- format(MSG, 'self[:attr]', 'read_attribute(:attr)')
39
- else
40
- format(MSG, 'self[:attr] = val', 'write_attribute(:attr, val)')
41
- end
42
- end
43
-
44
34
  def autocorrect(node)
45
35
  case node.method_name
46
36
  when :read_attribute
@@ -52,6 +42,16 @@ module RuboCop
52
42
  ->(corrector) { corrector.replace(node.source_range, replacement) }
53
43
  end
54
44
 
45
+ private
46
+
47
+ def message(node)
48
+ if node.method?(:read_attribute)
49
+ format(MSG, 'self[:attr]', 'read_attribute(:attr)')
50
+ else
51
+ format(MSG, 'self[:attr] = val', 'write_attribute(:attr, val)')
52
+ end
53
+ end
54
+
55
55
  def read_attribute_replacement(node)
56
56
  "self[#{node.first_argument.source}]"
57
57
  end
@@ -0,0 +1,91 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Rails
6
+ # This cop checks for redundant receiver in `with_options`.
7
+ # Receiver is implicit from Rails 4.2 or higher.
8
+ #
9
+ # @example
10
+ # # bad
11
+ # class Account < ApplicationRecord
12
+ # with_options dependent: :destroy do |assoc|
13
+ # assoc.has_many :customers
14
+ # assoc.has_many :products
15
+ # assoc.has_many :invoices
16
+ # assoc.has_many :expenses
17
+ # end
18
+ # end
19
+ #
20
+ # # good
21
+ # class Account < ApplicationRecord
22
+ # with_options dependent: :destroy do
23
+ # has_many :customers
24
+ # has_many :products
25
+ # has_many :invoices
26
+ # has_many :expenses
27
+ # end
28
+ # end
29
+ class RedundantReceiverInWithOptions < Cop
30
+ extend TargetRailsVersion
31
+
32
+ minimum_target_rails_version 4.2
33
+
34
+ MSG = 'Redundant receiver in `with_options`.'.freeze
35
+
36
+ def_node_matcher :with_options?, <<-PATTERN
37
+ (block
38
+ (send nil? :with_options
39
+ (...))
40
+ (args
41
+ (...))
42
+ ...)
43
+ PATTERN
44
+
45
+ def_node_search :assoc_has_redundant_receiver, <<-PATTERN
46
+ (send
47
+ (lvar _) ...)
48
+ PATTERN
49
+
50
+ def on_block(node)
51
+ with_options?(node) do
52
+ assoc_has_redundant_receiver(node).each do |assoc|
53
+ add_offense(assoc, location: assoc.receiver.loc.expression)
54
+ end
55
+ end
56
+ end
57
+
58
+ def autocorrect(node)
59
+ lambda do |corrector|
60
+ corrector.remove(node.receiver.loc.expression)
61
+ corrector.remove(node.loc.dot)
62
+ corrector.remove(block_argument_range(node))
63
+ end
64
+ end
65
+
66
+ private
67
+
68
+ def block_argument_range(node)
69
+ block_argument = node.parent.parent.children[1].loc.expression
70
+
71
+ range_between(
72
+ search_begin_pos_of_space_before_block_argument(
73
+ block_argument.begin_pos
74
+ ),
75
+ block_argument.end_pos
76
+ )
77
+ end
78
+
79
+ def search_begin_pos_of_space_before_block_argument(begin_pos)
80
+ position = begin_pos - 1
81
+
82
+ if processed_source.raw_source[position] == ' '
83
+ search_begin_pos_of_space_before_block_argument(position)
84
+ else
85
+ begin_pos
86
+ end
87
+ end
88
+ end
89
+ end
90
+ end
91
+ end
@@ -51,6 +51,15 @@ module RuboCop
51
51
  check_node(rhs)
52
52
  end
53
53
 
54
+ def autocorrect(node)
55
+ _scope, const_name, value = *node
56
+ indent = ' ' * node.loc.column
57
+ new_code = ["def self.#{const_name.downcase}",
58
+ "#{indent}#{value.source}",
59
+ 'end'].join("\n#{indent}")
60
+ ->(corrector) { corrector.replace(node.source_range, new_code) }
61
+ end
62
+
54
63
  private
55
64
 
56
65
  def check_node(node)
@@ -73,15 +82,6 @@ module RuboCop
73
82
  RELATIVE_DATE_METHODS.include?(node.method_name) &&
74
83
  !node.arguments?
75
84
  end
76
-
77
- def autocorrect(node)
78
- _scope, const_name, value = *node
79
- indent = ' ' * node.loc.column
80
- new_code = ["def self.#{const_name.downcase}",
81
- "#{indent}#{value.source}",
82
- 'end'].join("\n#{indent}")
83
- ->(corrector) { corrector.replace(node.source_range, new_code) }
84
- end
85
85
  end
86
86
  end
87
87
  end
@@ -256,8 +256,7 @@ module RuboCop
256
256
 
257
257
  def within_change_method?(node)
258
258
  node.each_ancestor(:def).any? do |ancestor|
259
- method_name, = *ancestor
260
- method_name == :change
259
+ ancestor.method?(:change)
261
260
  end
262
261
  end
263
262
 
@@ -270,8 +269,8 @@ module RuboCop
270
269
  def all_hash_key?(args, *keys)
271
270
  return false unless args && args.hash_type?
272
271
 
273
- hash_keys = args.to_a.map do |arg|
274
- arg.to_a.first.children.first.to_sym
272
+ hash_keys = args.keys.map do |key|
273
+ key.children.first.to_sym
275
274
  end
276
275
 
277
276
  hash_keys & keys == keys
@@ -51,17 +51,14 @@ module RuboCop
51
51
  minimum_target_ruby_version 2.3
52
52
 
53
53
  def on_send(node)
54
- try_call(node) do |try_method, method_to_try|
54
+ try_call(node) do |try_method, dispatch|
55
55
  return if try_method == :try && !cop_config['ConvertTry']
56
- return unless method_to_try.sym_type?
57
- method, = *method_to_try
58
- return unless method =~ /\w+[=!?]?/
56
+ return unless dispatch.sym_type? && dispatch.value =~ /\w+[=!?]?/
57
+
59
58
  add_offense(node, message: format(MSG, try_method))
60
59
  end
61
60
  end
62
61
 
63
- private
64
-
65
62
  def autocorrect(node)
66
63
  method_node, *params = *node.arguments
67
64
  method = method_node.source[1..-1]
@@ -74,6 +71,8 @@ module RuboCop
74
71
  end
75
72
  end
76
73
 
74
+ private
75
+
77
76
  def replacement(method, params)
78
77
  new_params = params.map(&:source).join(', ')
79
78
 
@@ -24,7 +24,7 @@ module RuboCop
24
24
  #
25
25
  # # good
26
26
  # unless user.save
27
- # . . .
27
+ # # ...
28
28
  # end
29
29
  # user.save!
30
30
  # user.update!(name: 'Joe')
@@ -33,7 +33,7 @@ module RuboCop
33
33
  #
34
34
  # user = User.find_or_create_by(name: 'Joe')
35
35
  # unless user.persisted?
36
- # . . .
36
+ # # ...
37
37
  # end
38
38
  class SaveBang < Cop
39
39
  MSG = 'Use `%s` instead of `%s` if the return value is not checked.'
@@ -26,7 +26,7 @@ module RuboCop
26
26
  #
27
27
  # @example
28
28
  # # this will return a Relation that pluck is called on
29
- # Model.where(...).pluck(:id).uniq
29
+ # Model.where(cond: true).pluck(:id).uniq
30
30
  #
31
31
  # # an association on an instance will return a CollectionProxy
32
32
  # instance.assoc.pluck(:id).uniq