rubocop 0.43.0 → 0.44.0
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of rubocop might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/README.md +1 -1
- data/bin/rubocop +0 -1
- data/config/default.yml +31 -0
- data/config/disabled.yml +6 -6
- data/config/enabled.yml +182 -140
- data/lib/rubocop.rb +7 -2
- data/lib/rubocop/ast_node.rb +0 -1
- data/lib/rubocop/ast_node/builder.rb +0 -1
- data/lib/rubocop/ast_node/sexp.rb +0 -1
- data/lib/rubocop/ast_node/traversal.rb +0 -1
- data/lib/rubocop/cached_data.rb +3 -20
- data/lib/rubocop/cli.rb +0 -1
- data/lib/rubocop/comment_config.rb +0 -1
- data/lib/rubocop/config.rb +0 -1
- data/lib/rubocop/config_loader.rb +1 -2
- data/lib/rubocop/config_loader_resolver.rb +0 -1
- data/lib/rubocop/config_store.rb +0 -1
- data/lib/rubocop/cop/autocorrect_logic.rb +0 -1
- data/lib/rubocop/cop/commissioner.rb +0 -1
- data/lib/rubocop/cop/cop.rb +15 -5
- data/lib/rubocop/cop/corrector.rb +0 -1
- data/lib/rubocop/cop/force.rb +0 -1
- data/lib/rubocop/cop/ignored_node.rb +0 -1
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +0 -1
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +0 -1
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
- data/lib/rubocop/cop/lint/block_alignment.rb +0 -1
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +0 -1
- data/lib/rubocop/cop/lint/condition_position.rb +0 -1
- data/lib/rubocop/cop/lint/debugger.rb +0 -1
- data/lib/rubocop/cop/lint/def_end_alignment.rb +0 -1
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +0 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +0 -1
- data/lib/rubocop/cop/lint/duplicated_key.rb +0 -1
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +0 -1
- data/lib/rubocop/cop/lint/else_layout.rb +0 -1
- data/lib/rubocop/cop/lint/empty_ensure.rb +0 -1
- data/lib/rubocop/cop/lint/empty_interpolation.rb +0 -1
- data/lib/rubocop/cop/lint/end_alignment.rb +0 -1
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -1
- data/lib/rubocop/cop/lint/ensure_return.rb +0 -1
- data/lib/rubocop/cop/lint/eval.rb +0 -1
- data/lib/rubocop/cop/lint/float_out_of_range.rb +0 -1
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +0 -1
- data/lib/rubocop/cop/lint/handle_exceptions.rb +0 -1
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +0 -1
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +0 -1
- data/lib/rubocop/cop/lint/inherit_exception.rb +0 -1
- data/lib/rubocop/cop/lint/invalid_character_literal.rb +0 -1
- data/lib/rubocop/cop/lint/literal_in_condition.rb +0 -1
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +0 -1
- data/lib/rubocop/cop/lint/loop.rb +0 -1
- data/lib/rubocop/cop/lint/nested_method_definition.rb +0 -1
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +0 -1
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +0 -1
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +0 -1
- data/lib/rubocop/cop/lint/percent_string_array.rb +0 -1
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +0 -1
- data/lib/rubocop/cop/lint/rand_one.rb +0 -1
- data/lib/rubocop/cop/lint/require_parentheses.rb +0 -1
- data/lib/rubocop/cop/lint/rescue_exception.rb +0 -1
- data/lib/rubocop/cop/lint/shadowed_exception.rb +1 -2
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +0 -1
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +0 -1
- data/lib/rubocop/cop/lint/syntax.rb +0 -1
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +0 -1
- data/lib/rubocop/cop/lint/unified_integer.rb +0 -1
- data/lib/rubocop/cop/lint/unneeded_disable.rb +0 -1
- data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +15 -2
- data/lib/rubocop/cop/lint/unreachable_code.rb +0 -1
- data/lib/rubocop/cop/lint/unused_block_argument.rb +81 -27
- data/lib/rubocop/cop/lint/unused_method_argument.rb +0 -1
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +0 -1
- data/lib/rubocop/cop/lint/useless_assignment.rb +0 -1
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -1
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +0 -1
- data/lib/rubocop/cop/lint/useless_setter_call.rb +0 -1
- data/lib/rubocop/cop/lint/void.rb +0 -1
- data/lib/rubocop/cop/metrics/abc_size.rb +1 -2
- data/lib/rubocop/cop/metrics/block_length.rb +26 -0
- data/lib/rubocop/cop/metrics/block_nesting.rb +0 -1
- data/lib/rubocop/cop/metrics/class_length.rb +0 -1
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +0 -1
- data/lib/rubocop/cop/metrics/line_length.rb +45 -8
- data/lib/rubocop/cop/metrics/method_length.rb +5 -10
- data/lib/rubocop/cop/metrics/module_length.rb +0 -1
- data/lib/rubocop/cop/metrics/parameter_lists.rb +0 -1
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +0 -1
- data/lib/rubocop/cop/mixin/access_modifier_node.rb +0 -1
- data/lib/rubocop/cop/mixin/annotation_comment.rb +0 -1
- data/lib/rubocop/cop/mixin/array_hash_indentation.rb +0 -1
- data/lib/rubocop/cop/mixin/array_syntax.rb +0 -1
- data/lib/rubocop/cop/mixin/autocorrect_alignment.rb +0 -1
- data/lib/rubocop/cop/mixin/check_assignment.rb +0 -1
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -1
- data/lib/rubocop/cop/mixin/code_length.rb +1 -2
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +0 -1
- data/lib/rubocop/cop/mixin/configurable_max.rb +0 -1
- data/lib/rubocop/cop/mixin/configurable_naming.rb +0 -1
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +2 -2
- data/lib/rubocop/cop/mixin/def_node.rb +0 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +0 -1
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +41 -16
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +0 -1
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +0 -1
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +0 -1
- data/lib/rubocop/cop/mixin/hash_node.rb +0 -1
- data/lib/rubocop/cop/mixin/if_node.rb +0 -1
- data/lib/rubocop/cop/mixin/integer_node.rb +0 -1
- data/lib/rubocop/cop/mixin/match_range.rb +0 -1
- data/lib/rubocop/cop/mixin/method_complexity.rb +0 -1
- data/lib/rubocop/cop/mixin/method_preference.rb +0 -1
- data/lib/rubocop/cop/mixin/min_body_length.rb +0 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +0 -1
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +0 -1
- data/lib/rubocop/cop/mixin/negative_conditional.rb +0 -1
- data/lib/rubocop/cop/mixin/on_method_def.rb +0 -1
- data/lib/rubocop/cop/mixin/on_normal_if_unless.rb +0 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +0 -1
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -1
- data/lib/rubocop/cop/mixin/percent_literal.rb +0 -1
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +0 -1
- data/lib/rubocop/cop/mixin/safe_assignment.rb +0 -1
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +0 -1
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +0 -1
- data/lib/rubocop/cop/mixin/space_inside.rb +0 -1
- data/lib/rubocop/cop/mixin/statement_modifier.rb +0 -1
- data/lib/rubocop/cop/mixin/string_help.rb +0 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +0 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +0 -1
- data/lib/rubocop/cop/mixin/too_many_lines.rb +25 -0
- data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -2
- data/lib/rubocop/cop/mixin/unused_argument.rb +0 -1
- data/lib/rubocop/cop/offense.rb +0 -1
- data/lib/rubocop/cop/performance/case_when_splat.rb +17 -8
- data/lib/rubocop/cop/performance/casecmp.rb +0 -1
- data/lib/rubocop/cop/performance/count.rb +0 -1
- data/lib/rubocop/cop/performance/detect.rb +0 -1
- data/lib/rubocop/cop/performance/double_start_end_with.rb +0 -1
- data/lib/rubocop/cop/performance/end_with.rb +0 -1
- data/lib/rubocop/cop/performance/fixed_size.rb +0 -1
- data/lib/rubocop/cop/performance/flat_map.rb +0 -1
- data/lib/rubocop/cop/performance/{hash_each.rb → hash_each_methods.rb} +0 -1
- data/lib/rubocop/cop/performance/lstrip_rstrip.rb +0 -1
- data/lib/rubocop/cop/performance/range_include.rb +0 -1
- data/lib/rubocop/cop/performance/redundant_block_call.rb +0 -1
- data/lib/rubocop/cop/performance/redundant_match.rb +0 -1
- data/lib/rubocop/cop/performance/redundant_merge.rb +1 -1
- data/lib/rubocop/cop/performance/redundant_sort_by.rb +0 -1
- data/lib/rubocop/cop/performance/reverse_each.rb +0 -1
- data/lib/rubocop/cop/performance/sample.rb +1 -2
- data/lib/rubocop/cop/performance/size.rb +0 -1
- data/lib/rubocop/cop/performance/sort_with_block.rb +0 -1
- data/lib/rubocop/cop/performance/start_with.rb +0 -1
- data/lib/rubocop/cop/performance/string_replacement.rb +0 -1
- data/lib/rubocop/cop/performance/times_map.rb +0 -1
- data/lib/rubocop/cop/rails/action_filter.rb +2 -3
- data/lib/rubocop/cop/rails/date.rb +0 -1
- data/lib/rubocop/cop/rails/delegate.rb +0 -1
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +62 -0
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +77 -0
- data/lib/rubocop/cop/rails/exit.rb +0 -1
- data/lib/rubocop/cop/rails/find_by.rb +0 -1
- data/lib/rubocop/cop/rails/find_each.rb +0 -1
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -1
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +89 -0
- data/lib/rubocop/cop/rails/not_null_column.rb +1 -2
- data/lib/rubocop/cop/rails/output.rb +0 -1
- data/lib/rubocop/cop/rails/output_safety.rb +1 -2
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -1
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -1
- data/lib/rubocop/cop/rails/request_referer.rb +0 -1
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -1
- data/lib/rubocop/cop/rails/save_bang.rb +12 -3
- data/lib/rubocop/cop/rails/scope_args.rb +0 -1
- data/lib/rubocop/cop/rails/time_zone.rb +0 -1
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +1 -2
- data/lib/rubocop/cop/rails/validation.rb +0 -1
- data/lib/rubocop/cop/security/json_load.rb +11 -3
- data/lib/rubocop/cop/severity.rb +0 -1
- data/lib/rubocop/cop/style/access_modifier_indentation.rb +0 -1
- data/lib/rubocop/cop/style/accessor_method_name.rb +0 -1
- data/lib/rubocop/cop/style/alias.rb +0 -1
- data/lib/rubocop/cop/style/align_array.rb +0 -1
- data/lib/rubocop/cop/style/align_hash.rb +0 -1
- data/lib/rubocop/cop/style/align_parameters.rb +0 -1
- data/lib/rubocop/cop/style/and_or.rb +0 -1
- data/lib/rubocop/cop/style/array_join.rb +0 -1
- data/lib/rubocop/cop/style/ascii_comments.rb +0 -1
- data/lib/rubocop/cop/style/ascii_identifiers.rb +0 -1
- data/lib/rubocop/cop/style/attr.rb +0 -1
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +0 -1
- data/lib/rubocop/cop/style/bare_percent_literals.rb +0 -1
- data/lib/rubocop/cop/style/begin_block.rb +0 -1
- data/lib/rubocop/cop/style/block_comments.rb +0 -1
- data/lib/rubocop/cop/style/block_delimiters.rb +0 -1
- data/lib/rubocop/cop/style/block_end_newline.rb +0 -1
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -1
- data/lib/rubocop/cop/style/case_equality.rb +0 -1
- data/lib/rubocop/cop/style/case_indentation.rb +0 -1
- data/lib/rubocop/cop/style/character_literal.rb +0 -1
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +0 -1
- data/lib/rubocop/cop/style/class_and_module_children.rb +0 -1
- data/lib/rubocop/cop/style/class_check.rb +0 -1
- data/lib/rubocop/cop/style/class_methods.rb +0 -1
- data/lib/rubocop/cop/style/class_vars.rb +0 -1
- data/lib/rubocop/cop/style/closing_parenthesis_indentation.rb +0 -1
- data/lib/rubocop/cop/style/collection_methods.rb +0 -1
- data/lib/rubocop/cop/style/colon_method_call.rb +0 -1
- data/lib/rubocop/cop/style/command_literal.rb +0 -1
- data/lib/rubocop/cop/style/comment_annotation.rb +0 -1
- data/lib/rubocop/cop/style/comment_indentation.rb +0 -1
- data/lib/rubocop/cop/style/conditional_assignment.rb +0 -1
- data/lib/rubocop/cop/style/constant_name.rb +0 -1
- data/lib/rubocop/cop/style/copyright.rb +0 -1
- data/lib/rubocop/cop/style/def_with_parentheses.rb +0 -1
- data/lib/rubocop/cop/style/documentation.rb +0 -1
- data/lib/rubocop/cop/style/documentation_method.rb +0 -1
- data/lib/rubocop/cop/style/dot_position.rb +0 -1
- data/lib/rubocop/cop/style/double_negation.rb +0 -1
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +0 -1
- data/lib/rubocop/cop/style/each_with_object.rb +0 -1
- data/lib/rubocop/cop/style/else_alignment.rb +0 -1
- data/lib/rubocop/cop/style/empty_case_condition.rb +0 -1
- data/lib/rubocop/cop/style/empty_else.rb +7 -6
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +0 -1
- data/lib/rubocop/cop/style/empty_lines.rb +0 -1
- data/lib/rubocop/cop/style/empty_lines_around_access_modifier.rb +15 -8
- data/lib/rubocop/cop/style/empty_lines_around_block_body.rb +0 -1
- data/lib/rubocop/cop/style/empty_lines_around_class_body.rb +0 -1
- data/lib/rubocop/cop/style/empty_lines_around_method_body.rb +0 -1
- data/lib/rubocop/cop/style/empty_lines_around_module_body.rb +0 -1
- data/lib/rubocop/cop/style/empty_literal.rb +0 -1
- data/lib/rubocop/cop/style/encoding.rb +0 -1
- data/lib/rubocop/cop/style/end_block.rb +0 -1
- data/lib/rubocop/cop/style/end_of_line.rb +0 -1
- data/lib/rubocop/cop/style/even_odd.rb +0 -1
- data/lib/rubocop/cop/style/extra_spacing.rb +5 -4
- data/lib/rubocop/cop/style/file_name.rb +0 -1
- data/lib/rubocop/cop/style/first_array_element_line_break.rb +0 -1
- data/lib/rubocop/cop/style/first_hash_element_line_break.rb +0 -1
- data/lib/rubocop/cop/style/first_method_argument_line_break.rb +0 -1
- data/lib/rubocop/cop/style/first_method_parameter_line_break.rb +0 -1
- data/lib/rubocop/cop/style/first_parameter_indentation.rb +0 -1
- data/lib/rubocop/cop/style/flip_flop.rb +0 -1
- data/lib/rubocop/cop/style/for.rb +0 -1
- data/lib/rubocop/cop/style/format_string.rb +0 -1
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +0 -1
- data/lib/rubocop/cop/style/global_vars.rb +0 -1
- data/lib/rubocop/cop/style/guard_clause.rb +2 -4
- data/lib/rubocop/cop/style/hash_syntax.rb +0 -1
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +0 -1
- data/lib/rubocop/cop/style/if_inside_else.rb +0 -1
- data/lib/rubocop/cop/style/if_unless_modifier.rb +0 -1
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +0 -1
- data/lib/rubocop/cop/style/if_with_semicolon.rb +0 -1
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +0 -1
- data/lib/rubocop/cop/style/indent_array.rb +0 -1
- data/lib/rubocop/cop/style/indent_assignment.rb +0 -1
- data/lib/rubocop/cop/style/indent_hash.rb +0 -1
- data/lib/rubocop/cop/style/indentation_consistency.rb +0 -1
- data/lib/rubocop/cop/style/indentation_width.rb +0 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +0 -1
- data/lib/rubocop/cop/style/initial_indentation.rb +0 -1
- data/lib/rubocop/cop/style/inline_comment.rb +0 -1
- data/lib/rubocop/cop/style/lambda.rb +0 -1
- data/lib/rubocop/cop/style/lambda_call.rb +0 -1
- data/lib/rubocop/cop/style/leading_comment_space.rb +0 -1
- data/lib/rubocop/cop/style/line_end_concatenation.rb +1 -2
- data/lib/rubocop/cop/style/method_call_parentheses.rb +0 -1
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +0 -1
- data/lib/rubocop/cop/style/method_def_parentheses.rb +0 -1
- data/lib/rubocop/cop/style/method_missing.rb +0 -1
- data/lib/rubocop/cop/style/method_name.rb +0 -1
- data/lib/rubocop/cop/style/missing_else.rb +0 -1
- data/lib/rubocop/cop/style/module_function.rb +0 -1
- data/lib/rubocop/cop/style/multiline_array_brace_layout.rb +0 -1
- data/lib/rubocop/cop/style/multiline_assignment_layout.rb +0 -1
- data/lib/rubocop/cop/style/multiline_block_chain.rb +0 -1
- data/lib/rubocop/cop/style/multiline_block_layout.rb +0 -1
- data/lib/rubocop/cop/style/multiline_hash_brace_layout.rb +0 -1
- data/lib/rubocop/cop/style/multiline_if_then.rb +0 -1
- data/lib/rubocop/cop/style/multiline_memoization.rb +44 -0
- data/lib/rubocop/cop/style/multiline_method_call_brace_layout.rb +0 -1
- data/lib/rubocop/cop/style/multiline_method_call_indentation.rb +0 -1
- data/lib/rubocop/cop/style/multiline_method_definition_brace_layout.rb +0 -1
- data/lib/rubocop/cop/style/multiline_operation_indentation.rb +0 -1
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +0 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +0 -1
- data/lib/rubocop/cop/style/negated_if.rb +0 -1
- data/lib/rubocop/cop/style/negated_while.rb +0 -1
- data/lib/rubocop/cop/style/nested_modifier.rb +0 -1
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +0 -1
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +0 -1
- data/lib/rubocop/cop/style/next.rb +0 -1
- data/lib/rubocop/cop/style/nil_comparison.rb +0 -1
- data/lib/rubocop/cop/style/non_nil_check.rb +18 -2
- data/lib/rubocop/cop/style/not.rb +0 -1
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +2 -5
- data/lib/rubocop/cop/style/numeric_literals.rb +0 -1
- data/lib/rubocop/cop/style/numeric_predicate.rb +0 -1
- data/lib/rubocop/cop/style/one_line_conditional.rb +0 -1
- data/lib/rubocop/cop/style/op_method.rb +0 -1
- data/lib/rubocop/cop/style/option_hash.rb +0 -1
- data/lib/rubocop/cop/style/optional_arguments.rb +0 -1
- data/lib/rubocop/cop/style/parallel_assignment.rb +13 -2
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +0 -1
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +0 -1
- data/lib/rubocop/cop/style/percent_q_literals.rb +0 -1
- data/lib/rubocop/cop/style/perl_backrefs.rb +0 -1
- data/lib/rubocop/cop/style/predicate_name.rb +0 -1
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +44 -6
- data/lib/rubocop/cop/style/proc.rb +0 -1
- data/lib/rubocop/cop/style/raise_args.rb +13 -14
- data/lib/rubocop/cop/style/redundant_begin.rb +0 -1
- data/lib/rubocop/cop/style/redundant_exception.rb +0 -1
- data/lib/rubocop/cop/style/redundant_freeze.rb +0 -1
- data/lib/rubocop/cop/style/redundant_parentheses.rb +2 -2
- data/lib/rubocop/cop/style/redundant_return.rb +37 -9
- data/lib/rubocop/cop/style/redundant_self.rb +0 -1
- data/lib/rubocop/cop/style/regexp_literal.rb +0 -1
- data/lib/rubocop/cop/style/rescue_ensure_alignment.rb +0 -1
- data/lib/rubocop/cop/style/rescue_modifier.rb +0 -1
- data/lib/rubocop/cop/style/safe_navigation.rb +51 -39
- data/lib/rubocop/cop/style/self_assignment.rb +0 -1
- data/lib/rubocop/cop/style/semicolon.rb +0 -1
- data/lib/rubocop/cop/style/send.rb +0 -1
- data/lib/rubocop/cop/style/signal_exception.rb +0 -1
- data/lib/rubocop/cop/style/single_line_block_params.rb +0 -1
- data/lib/rubocop/cop/style/single_line_methods.rb +0 -1
- data/lib/rubocop/cop/style/space_after_colon.rb +0 -1
- data/lib/rubocop/cop/style/space_after_comma.rb +0 -1
- data/lib/rubocop/cop/style/space_after_method_name.rb +0 -1
- data/lib/rubocop/cop/style/space_after_not.rb +0 -1
- data/lib/rubocop/cop/style/space_after_semicolon.rb +0 -1
- data/lib/rubocop/cop/style/space_around_block_parameters.rb +0 -1
- data/lib/rubocop/cop/style/space_around_equals_in_parameter_default.rb +0 -1
- data/lib/rubocop/cop/style/space_around_keyword.rb +0 -1
- data/lib/rubocop/cop/style/space_around_operators.rb +0 -1
- data/lib/rubocop/cop/style/space_before_block_braces.rb +0 -1
- data/lib/rubocop/cop/style/space_before_comma.rb +0 -1
- data/lib/rubocop/cop/style/space_before_comment.rb +0 -1
- data/lib/rubocop/cop/style/space_before_first_arg.rb +0 -1
- data/lib/rubocop/cop/style/space_before_semicolon.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_array_percent_literal.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_block_braces.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_brackets.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_hash_literal_braces.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_parens.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_percent_literal_delimiters.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_range_literal.rb +0 -1
- data/lib/rubocop/cop/style/space_inside_string_interpolation.rb +0 -1
- data/lib/rubocop/cop/style/special_global_vars.rb +0 -1
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +0 -1
- data/lib/rubocop/cop/style/string_literals.rb +0 -1
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +0 -1
- data/lib/rubocop/cop/style/string_methods.rb +0 -1
- data/lib/rubocop/cop/style/struct_inheritance.rb +0 -1
- data/lib/rubocop/cop/style/symbol_array.rb +0 -1
- data/lib/rubocop/cop/style/symbol_literal.rb +0 -1
- data/lib/rubocop/cop/style/symbol_proc.rb +0 -1
- data/lib/rubocop/cop/style/tab.rb +0 -1
- data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -2
- data/lib/rubocop/cop/style/trailing_blank_lines.rb +0 -1
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +0 -1
- data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +0 -1
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +0 -1
- data/lib/rubocop/cop/style/trailing_whitespace.rb +0 -1
- data/lib/rubocop/cop/style/trivial_accessors.rb +0 -1
- data/lib/rubocop/cop/style/unless_else.rb +0 -1
- data/lib/rubocop/cop/style/unneeded_capital_w.rb +3 -2
- data/lib/rubocop/cop/style/unneeded_interpolation.rb +0 -1
- data/lib/rubocop/cop/style/unneeded_percent_q.rb +0 -1
- data/lib/rubocop/cop/style/variable_interpolation.rb +0 -1
- data/lib/rubocop/cop/style/variable_name.rb +0 -1
- data/lib/rubocop/cop/style/variable_number.rb +0 -1
- data/lib/rubocop/cop/style/when_then.rb +0 -1
- data/lib/rubocop/cop/style/while_until_do.rb +0 -1
- data/lib/rubocop/cop/style/while_until_modifier.rb +0 -1
- data/lib/rubocop/cop/style/word_array.rb +0 -1
- data/lib/rubocop/cop/style/zero_length_predicate.rb +0 -1
- data/lib/rubocop/cop/team.rb +1 -2
- data/lib/rubocop/cop/util.rb +11 -6
- data/lib/rubocop/cop/variable_force.rb +0 -1
- data/lib/rubocop/cop/variable_force/assignment.rb +0 -1
- data/lib/rubocop/cop/variable_force/locatable.rb +0 -1
- data/lib/rubocop/cop/variable_force/reference.rb +0 -1
- data/lib/rubocop/cop/variable_force/scope.rb +0 -1
- data/lib/rubocop/cop/variable_force/variable.rb +0 -1
- data/lib/rubocop/cop/variable_force/variable_table.rb +0 -1
- data/lib/rubocop/error.rb +0 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -1
- data/lib/rubocop/formatter/clang_style_formatter.rb +0 -1
- data/lib/rubocop/formatter/colorizable.rb +0 -1
- data/lib/rubocop/formatter/disabled_config_formatter.rb +0 -1
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -1
- data/lib/rubocop/formatter/emacs_style_formatter.rb +0 -1
- data/lib/rubocop/formatter/file_list_formatter.rb +0 -1
- data/lib/rubocop/formatter/formatter_set.rb +0 -1
- data/lib/rubocop/formatter/fuubar_style_formatter.rb +0 -1
- data/lib/rubocop/formatter/html_formatter.rb +2 -3
- data/lib/rubocop/formatter/json_formatter.rb +0 -1
- data/lib/rubocop/formatter/offense_count_formatter.rb +0 -1
- data/lib/rubocop/formatter/progress_formatter.rb +0 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +0 -1
- data/lib/rubocop/formatter/text_util.rb +0 -1
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +0 -1
- data/lib/rubocop/name_similarity.rb +0 -1
- data/lib/rubocop/node_pattern.rb +0 -1
- data/lib/rubocop/options.rb +0 -1
- data/lib/rubocop/path_util.rb +0 -1
- data/lib/rubocop/processed_source.rb +3 -4
- data/lib/rubocop/rake_task.rb +0 -1
- data/lib/rubocop/remote_config.rb +0 -1
- data/lib/rubocop/result_cache.rb +3 -4
- data/lib/rubocop/rspec/cop_helper.rb +0 -1
- data/lib/rubocop/rspec/host_environment_simulation_helper.rb +0 -1
- data/lib/rubocop/rspec/shared_contexts.rb +0 -1
- data/lib/rubocop/rspec/shared_examples.rb +0 -1
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +0 -1
- data/lib/rubocop/string_interpreter.rb +0 -1
- data/lib/rubocop/string_util.rb +0 -1
- data/lib/rubocop/target_finder.rb +0 -1
- data/lib/rubocop/token.rb +0 -1
- data/lib/rubocop/version.rb +1 -2
- data/lib/rubocop/warning.rb +0 -1
- metadata +9 -3
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -8,6 +7,14 @@ module RuboCop
|
|
8
7
|
# check for the variable whose method is being called to
|
9
8
|
# safe navigation (`&.`).
|
10
9
|
#
|
10
|
+
# Configuration option: ConvertCodeThatCanStartToReturnNil
|
11
|
+
# The default for this is `false`. When configured to `true`, this will
|
12
|
+
# check for code in the format `!foo.nil? && foo.bar`. As it is written,
|
13
|
+
# the return of this code is limited to `false` and whatever the return
|
14
|
+
# of the method is. If this is converted to safe navigation,
|
15
|
+
# `foo&.bar` can start returning `nil` as well as what the method
|
16
|
+
# returns.
|
17
|
+
#
|
11
18
|
# @example
|
12
19
|
# # bad
|
13
20
|
# foo.bar if foo
|
@@ -24,19 +31,21 @@ module RuboCop
|
|
24
31
|
# foo && foo.bar { |e| e.something }
|
25
32
|
# foo && foo.bar(param) { |e| e.something }
|
26
33
|
#
|
27
|
-
# foo.nil? || foo.bar
|
28
|
-
# !foo || foo.bar
|
29
|
-
#
|
30
34
|
# # good
|
31
35
|
# foo&.bar
|
32
36
|
# foo&.bar(param1, param2)
|
33
37
|
# foo&.bar { |e| e.something }
|
34
38
|
# foo&.bar(param) { |e| e.something }
|
35
39
|
#
|
40
|
+
# foo.nil? || foo.bar
|
41
|
+
# !foo || foo.bar
|
42
|
+
#
|
36
43
|
# # Methods that `nil` will `respond_to?` should not be converted to
|
37
44
|
# # use safe navigation
|
38
45
|
# foo.to_i if foo
|
39
46
|
class SafeNavigation < Cop
|
47
|
+
include IfNode
|
48
|
+
|
40
49
|
MSG = 'Use safe navigation (`&.`) instead of checking if an object ' \
|
41
50
|
'exists before calling the method.'.freeze
|
42
51
|
NIL_METHODS = nil.methods.freeze
|
@@ -51,18 +60,18 @@ module RuboCop
|
|
51
60
|
(send $_ {:nil? :!}) nil
|
52
61
|
{(send $_ $_ ...) (block (send $_ $_ ...) ...)}
|
53
62
|
...)
|
54
|
-
(and
|
55
|
-
{(send (send $_ :nil?) :!) $_}
|
56
|
-
{(send $_ $_ ...) (block (send $_ $_ ...) ...)}
|
57
|
-
...)
|
58
|
-
(or
|
59
|
-
(send $_ {:nil? :!})
|
60
|
-
{(send $_ $_ ...) (block (send $_ $_ ...) ...)}
|
61
|
-
...)
|
62
63
|
}
|
63
64
|
PATTERN
|
64
65
|
|
66
|
+
def_node_matcher :candidate_that_may_introduce_nil, <<-PATTERN
|
67
|
+
(and
|
68
|
+
{(send (send $_ :nil?) :!) $_}
|
69
|
+
{(send $_ $_ ...) (block (send $_ $_ ...) ...)}
|
70
|
+
...)
|
71
|
+
PATTERN
|
72
|
+
|
65
73
|
def on_if(node)
|
74
|
+
return if ternary?(node)
|
66
75
|
check_node(node)
|
67
76
|
end
|
68
77
|
|
@@ -76,48 +85,51 @@ module RuboCop
|
|
76
85
|
|
77
86
|
def check_node(node)
|
78
87
|
return if target_ruby_version < 2.3
|
79
|
-
|
88
|
+
return if node.loc.respond_to?(:else) && !node.loc.else.nil?
|
89
|
+
checked_variable, receiver, method = extract_parts(node)
|
80
90
|
return unless receiver == checked_variable
|
81
91
|
return if NIL_METHODS.include?(method)
|
82
92
|
return unless method =~ /\w+[=!?]?/
|
83
93
|
add_offense(node, :expression)
|
84
94
|
end
|
85
95
|
|
96
|
+
def extract_parts(node)
|
97
|
+
if cop_config['ConvertCodeThatCanStartToReturnNil']
|
98
|
+
safe_navigation_candidate(node) ||
|
99
|
+
candidate_that_may_introduce_nil(node)
|
100
|
+
else
|
101
|
+
safe_navigation_candidate(node)
|
102
|
+
end
|
103
|
+
end
|
104
|
+
|
86
105
|
def autocorrect(node)
|
87
|
-
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
end
|
106
|
+
if node.loc.respond_to?(:keyword) && node.loc.keyword.is?('unless')
|
107
|
+
_check, _else, body = *node
|
108
|
+
else
|
109
|
+
_check, body = *node
|
110
|
+
end
|
93
111
|
|
94
|
-
|
95
|
-
method, = *method_call
|
96
|
-
corrector.insert_before(method.loc.dot, '&')
|
97
|
-
else
|
98
|
-
corrector.insert_before(method_call.loc.dot, '&')
|
99
|
-
end
|
112
|
+
method_call, = *body if body.block_type?
|
100
113
|
|
101
|
-
|
114
|
+
lambda do |corrector|
|
115
|
+
corrector.remove(begin_range(node, body))
|
116
|
+
corrector.remove(end_range(node, body))
|
117
|
+
corrector.insert_before((method_call || body).loc.dot, '&')
|
102
118
|
end
|
103
119
|
end
|
104
120
|
|
105
121
|
private
|
106
122
|
|
107
|
-
def
|
108
|
-
|
109
|
-
|
110
|
-
|
123
|
+
def begin_range(node, method_call)
|
124
|
+
Parser::Source::Range.new(node.loc.expression.source_buffer,
|
125
|
+
node.loc.expression.begin_pos,
|
126
|
+
method_call.loc.expression.begin_pos)
|
127
|
+
end
|
111
128
|
|
112
|
-
|
113
|
-
|
114
|
-
|
115
|
-
|
116
|
-
else
|
117
|
-
Parser::Source::Range.new(source_buffer,
|
118
|
-
method_expression.end_pos,
|
119
|
-
node_expression.end_pos)
|
120
|
-
end
|
129
|
+
def end_range(node, method_call)
|
130
|
+
Parser::Source::Range.new(node.loc.expression,
|
131
|
+
method_call.loc.expression.end_pos,
|
132
|
+
node.loc.expression.end_pos)
|
121
133
|
end
|
122
134
|
end
|
123
135
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -91,7 +90,7 @@ module RuboCop
|
|
91
90
|
end
|
92
91
|
|
93
92
|
def parenthesized?(node)
|
94
|
-
node.
|
93
|
+
node.begin_type?
|
95
94
|
end
|
96
95
|
|
97
96
|
# When this cop is configured to enforce parentheses and the
|