rubocop 0.43.0 → 0.44.0

data/lib/rubocop.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'parser'
@@ -88,6 +87,7 @@ require 'rubocop/cop/mixin/space_inside' # relies on surrounding_space
 require 'rubocop/cop/mixin/statement_modifier'
 require 'rubocop/cop/mixin/string_help'
 require 'rubocop/cop/mixin/string_literals_help'
+require 'rubocop/cop/mixin/too_many_lines'
 require 'rubocop/cop/mixin/trailing_comma'
 require 'rubocop/cop/mixin/unused_argument'
 
@@ -149,6 +149,7 @@ require 'rubocop/cop/lint/void'
 
 require 'rubocop/cop/metrics/cyclomatic_complexity'
 require 'rubocop/cop/metrics/abc_size' # relies on cyclomatic_complexity
+require 'rubocop/cop/metrics/block_length'
 require 'rubocop/cop/metrics/block_nesting'
 require 'rubocop/cop/metrics/class_length'
 require 'rubocop/cop/metrics/line_length'
@@ -165,7 +166,7 @@ require 'rubocop/cop/performance/double_start_end_with'
 require 'rubocop/cop/performance/end_with'
 require 'rubocop/cop/performance/fixed_size'
 require 'rubocop/cop/performance/flat_map'
-require 'rubocop/cop/performance/hash_each'
+require 'rubocop/cop/performance/hash_each_methods'
 require 'rubocop/cop/performance/lstrip_rstrip'
 require 'rubocop/cop/performance/range_include'
 require 'rubocop/cop/performance/redundant_block_call'
@@ -283,6 +284,7 @@ require 'rubocop/cop/style/multiline_block_chain'
 require 'rubocop/cop/style/multiline_block_layout'
 require 'rubocop/cop/style/multiline_hash_brace_layout'
 require 'rubocop/cop/style/multiline_if_then'
+require 'rubocop/cop/style/multiline_memoization'
 require 'rubocop/cop/style/multiline_method_call_brace_layout'
 require 'rubocop/cop/style/multiline_method_call_indentation'
 require 'rubocop/cop/style/multiline_method_definition_brace_layout'
@@ -383,11 +385,14 @@ require 'rubocop/cop/style/zero_length_predicate'
 
 require 'rubocop/cop/rails/action_filter'
 require 'rubocop/cop/rails/date'
+require 'rubocop/cop/rails/dynamic_find_by'
 require 'rubocop/cop/rails/delegate'
+require 'rubocop/cop/rails/delegate_allow_blank'
 require 'rubocop/cop/rails/exit'
 require 'rubocop/cop/rails/find_by'
 require 'rubocop/cop/rails/find_each'
 require 'rubocop/cop/rails/has_and_belongs_to_many'
+require 'rubocop/cop/rails/http_positional_arguments'
 require 'rubocop/cop/rails/not_null_column'
 require 'rubocop/cop/rails/output_safety'
 require 'rubocop/cop/rails/output'

data/lib/rubocop/ast_node.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/ast_node/builder.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/ast_node/sexp.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/ast_node/traversal.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cached_data.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'json'
@@ -49,32 +48,16 @@ module RuboCop
 
     # Restore an offense object loaded from a JSON file.
     def deserialize_offenses(offenses)
-      source_buffer = utf8_source_buffer
+      source_buffer = Parser::Source::Buffer.new(@filename)
+      source_buffer.source = File.read(@filename, encoding: Encoding::UTF_8)
       offenses.map! do |o|
         location = Parser::Source::Range.new(source_buffer,
                                              o['location']['begin_pos'],
                                              o['location']['end_pos'])
         Cop::Offense.new(o['severity'], location,
-                         # We know that we wrote a UTF-8 encoded string to the
-                         # cache file, so it's safe to force-encode it back to
-                         # UTF-8 if it happens to be ASCII-8BIT.
-                         o['message'].force_encoding('UTF-8'),
+                         o['message'],
                          o['cop_name'], o['status'].to_sym)
       end
     end
-
-    # Return a source buffer that has a UTF-8 encoded source.
-    def utf8_source_buffer
-      # We are given a source with an encoding of ASCII-8BIT
-      ascii_source = Parser::Source::Buffer.new(@filename).read.source
-
-      # Correct the encoding of the source as we expect UTF-8
-      source = ascii_source.dup.force_encoding('UTF-8')
-
-      # The existing source is immutable so we need a new object
-      source_buffer = Parser::Source::Buffer.new(@filename)
-      source_buffer.source = source
-      source_buffer
-    end
   end
 end

data/lib/rubocop/cli.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/comment_config.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/config.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'pathname'

data/lib/rubocop/config_loader.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'yaml'
@@ -140,7 +139,7 @@ module RuboCop
       end
 
       def load_yaml_configuration(absolute_path)
-        yaml_code = IO.read(absolute_path, encoding: 'UTF-8')
+        yaml_code = IO.read(absolute_path, encoding: Encoding::UTF_8)
         hash = yaml_safe_load(yaml_code, absolute_path) || {}
 
         puts "configuration from #{absolute_path}" if debug?

data/lib/rubocop/config_loader_resolver.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'yaml'

data/lib/rubocop/config_store.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/autocorrect_logic.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/commissioner.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/cop.rb

@@ -1,5 +1,5 @@
-# encoding: utf-8
 # frozen_string_literal: true
+require 'uri'
 
 module RuboCop
   module Cop
@@ -23,12 +23,11 @@ module RuboCop
       end
 
       def qualified_cop_name(name, origin)
-        @cop_names ||= Set.new(map(&:cop_name))
-        return name if @cop_names.include?(name)
+        return name if cop_names.include?(name)
 
         basename = File.basename(name)
         found_ns = types.map(&:capitalize).select do |ns|
-          @cop_names.include?("#{ns}/#{basename}")
+          cop_names.include?("#{ns}/#{basename}")
         end
 
         case found_ns.size
@@ -48,6 +47,12 @@ module RuboCop
         end
         "#{found_ns}/#{basename}"
       end
+
+      private
+
+      def cop_names
+        @cop_names ||= Set.new(map(&:cop_name))
+      end
     end
 
     # A scaffold for concrete cops.
@@ -228,7 +233,12 @@ module RuboCop
 
       def style_guide_url
         url = cop_config['StyleGuide']
-        url.nil? || url.empty? ? nil : url
+        return nil if url.nil? || url.empty?
+
+        base_url = config.for_all_cops['StyleGuideBaseURL']
+        return url if base_url.nil? || base_url.empty?
+
+        URI.join(base_url, url).to_s
       end
 
       def reference_url

data/lib/rubocop/cop/corrector.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/force.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/ignored_node.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/ambiguous_operator.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/assignment_in_condition.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
@@ -48,7 +47,8 @@ module RuboCop
         end
 
         def skip_children?(asgn_node)
-          safe_assignment_allowed? && safe_assignment?(asgn_node)
+          (asgn_node.send_type? && asgn_node.method_name !~ /=\z/) ||
+            (safe_assignment_allowed? && safe_assignment?(asgn_node))
         end
 
         # each_node/visit_descendants_with_types with :skip_children

data/lib/rubocop/cop/lint/block_alignment.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/circular_argument_reference.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/condition_position.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/debugger.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/def_end_alignment.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/deprecated_class_methods.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/duplicate_methods.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/duplicated_key.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/each_with_object_argument.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/else_layout.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/empty_ensure.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/empty_interpolation.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/end_alignment.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/end_in_method.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/ensure_return.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/eval.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/float_out_of_range.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/format_parameter_mismatch.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/handle_exceptions.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/implicit_string_concatenation.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/ineffective_access_modifier.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/inherit_exception.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/invalid_character_literal.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/literal_in_condition.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/literal_in_interpolation.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/loop.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/nested_method_definition.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/next_without_accumulator.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/lint/percent_string_array.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop