rubocop 0.43.0 → 0.44.0

data/lib/rubocop/cop/style/unless_else.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/unneeded_capital_w.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
@@ -25,7 +24,9 @@ module RuboCop
 
         def requires_interpolation?(node)
           node.child_nodes.any? do |string|
-            string.dstr_type? || double_quotes_acceptable?(string.str_content)
+            string.dstr_type? ||
+              double_quotes_acceptable?(string.str_content) ||
+              string.source == '\s'
           end
         end
 

data/lib/rubocop/cop/style/unneeded_interpolation.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/unneeded_percent_q.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/variable_interpolation.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/variable_name.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/variable_number.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/when_then.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/while_until_do.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/while_until_modifier.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/word_array.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/style/zero_length_predicate.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/team.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
@@ -83,7 +82,7 @@ module RuboCop
           @options[:stdin] = new_source
         else
           filename = buffer.name
-          File.open(filename, 'wb') { |f| f.write(new_source) }
+          File.open(filename, 'w') { |f| f.write(new_source) }
         end
         @updated_source_file = true
       end

data/lib/rubocop/cop/util.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 # rubocop:disable Metrics/ModuleLength
 
@@ -219,10 +218,11 @@ module RuboCop
       # If double quoted string literals are found in Ruby code, and they are
       # not the preferred style, should they be flagged?
       def double_quotes_acceptable?(string)
-        # If a string literal contains hard-to-type characters which would
-        # not appear on a "normal" keyboard, then double-quotes are acceptable
-        needs_escaping?(string) ||
-          string.codepoints.any? { |cp| cp < 32 || cp > 126 }
+        needs_escaping?(string) || hard_to_type?(string)
+      end
+
+      def hard_to_type?(string)
+        string.codepoints.any? { |cp| cp < 32 || cp > 126 }
       end
 
       def needs_escaping?(string)
@@ -234,7 +234,7 @@ module RuboCop
       end
 
       def to_string_literal(string)
-        if needs_escaping?(string)
+        if needs_escaping?(string) && compatible_external_encoding_for?(string)
           string.inspect
         else
           "'#{string.gsub('\\') { '\\\\' }}'"
@@ -266,6 +266,11 @@ module RuboCop
       def stripped_source_upto(line)
         processed_source[0..line].map(&:strip)
       end
+
+      def compatible_external_encoding_for?(src)
+        src = src.dup if RUBY_VERSION < '2.3'
+        src.force_encoding(Encoding.default_external).valid_encoding?
+      end
     end
   end
 end

data/lib/rubocop/cop/variable_force.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/variable_force/assignment.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/variable_force/locatable.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/variable_force/reference.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/variable_force/scope.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/variable_force/variable.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/cop/variable_force/variable_table.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/error.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/base_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 # rubocop:disable Metrics/LineLength

data/lib/rubocop/formatter/clang_style_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/colorizable.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/disabled_config_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/disabled_lines_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/emacs_style_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/file_list_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/formatter_set.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'fileutils'

data/lib/rubocop/formatter/fuubar_style_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'ruby-progressbar'

data/lib/rubocop/formatter/html_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'cgi'
@@ -12,8 +11,8 @@ module RuboCop
     # This formatter saves the output as an html file.
     class HTMLFormatter < BaseFormatter
       ELLIPSES = '<span class="extra-code">...</span>'.freeze
-      TEMPLATE_PATH = File.expand_path('../../../../assets/output.html.erb',
-                                       __FILE__).encode('utf-8')
+      TEMPLATE_PATH =
+        File.expand_path('../../../../assets/output.html.erb', __FILE__)
 
       Color = Struct.new(:red, :green, :blue, :alpha) do
         def to_s

data/lib/rubocop/formatter/json_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'json'

data/lib/rubocop/formatter/offense_count_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/progress_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/simple_text_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'rubocop/formatter/colorizable'

data/lib/rubocop/formatter/text_util.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/formatter/worst_offenders_formatter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'pathname'

data/lib/rubocop/name_similarity.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/node_pattern.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 # rubocop:disable Metrics/ClassLength

data/lib/rubocop/options.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'optparse'

data/lib/rubocop/path_util.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/processed_source.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'digest/md5'
@@ -21,9 +20,9 @@ module RuboCop
     end
 
     def initialize(source, ruby_version, path = nil)
-      # In Ruby 2, source code encoding defaults to UTF-8. We follow the same
-      # principle regardless of which Ruby version we're running under.
-      # Encoding comments will override this setting.
+      # Defaults source encoding to UTF-8, regardless of the encoding it has
+      # been read with, which could be non-utf8 depending on the default
+      # external encoding.
       unless source.encoding == Encoding::UTF_8
         source.force_encoding(Encoding::UTF_8)
       end

data/lib/rubocop/rake_task.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'rake'

data/lib/rubocop/remote_config.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'net/http'

data/lib/rubocop/result_cache.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'digest/md5'
@@ -91,7 +90,7 @@ module RuboCop
     end
 
     def load
-      @cached_data.from_json(IO.binread(@path))
+      @cached_data.from_json(IO.read(@path, encoding: Encoding::UTF_8))
     end
 
     def save(offenses)
@@ -103,7 +102,7 @@ module RuboCop
       # indication that a symlink attack is being waged.
       return if symlink_protection_triggered?(dir)
 
-      File.open(preliminary_path, 'wb') do |f|
+      File.open(preliminary_path, 'w', encoding: Encoding::UTF_8) do |f|
         f.write(@cached_data.to_json(offenses))
       end
       # The preliminary path is used so that if there are multiple RuboCop
@@ -158,7 +157,7 @@ module RuboCop
           sources = source_files
                     .select { |path| File.file?(path) }
                     .sort
-                    .map { |path| IO.read(path) }
+                    .map { |path| IO.read(path, encoding: Encoding::UTF_8) }
           Digest::MD5.hexdigest(sources.join)
         end
     end

data/lib/rubocop/rspec/cop_helper.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'tempfile'

data/lib/rubocop/rspec/host_environment_simulation_helper.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 # RuboCop can be run in contexts where unexpected other libraries are included,

data/lib/rubocop/rspec/shared_contexts.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'tmpdir'

data/lib/rubocop/rspec/shared_examples.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 # `cop` and `source` must be declared with #let.

data/lib/rubocop/rspec/support.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 # Require this file to load code that supports testing using RSpec.

data/lib/rubocop/runner.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/string_interpreter.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/string_util.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/target_finder.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'set'

data/lib/rubocop/token.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop

data/lib/rubocop/version.rb

@@ -1,10 +1,9 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.43.0'.freeze
+    STRING = '0.44.0'.freeze
 
     MSG = '%s (using Parser %s, running on %s %s %s)'.freeze