rubocop-sketchup 0.5.0 → 0.6.0

data/lib/rubocop/sketchup/config.rb

@@ -1,63 +1,63 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module Config
-
-      DEFAULT_CONFIGURATION =
-          SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
-
-      private
-
-      def all_cops_config
-        config.for_all_cops
-      end
-
-      def sketchup_cops_config
-        config.for_all_cops.fetch('SketchUp', DEFAULT_CONFIGURATION)
-      end
-
-
-      def sketchup_config_key?(key)
-        return unless all_cops_config.key?('SketchUp')
-
-        all_cops_config.fetch('SketchUp').key?(key)
-      end
-
-
-      def sketchup_target_version?
-        sketchup_config_key?('TargetSketchUpVersion')
-      end
-
-      def sketchup_target_version
-        version = sketchup_cops_config.fetch('TargetSketchUpVersion')
-        version ? SketchUpVersion.new(version) : nil
-      end
-
-
-      def extension_source_path_config?
-        sketchup_config_key?('SourcePath')
-      end
-
-      def extension_source_path_config
-        sketchup_cops_config.fetch('SourcePath')
-      end
-
-
-      def encrypted_extension?
-        sketchup_config_key?('EncryptedExtension') &&
-          sketchup_cops_config.fetch('EncryptedExtension')
-      end
-
-
-      def extension_binaries?
-        sketchup_config_key?('ExtensionBinaries')
-      end
-
-      def extension_binaries
-        sketchup_cops_config.fetch('ExtensionBinaries')
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module Config
+
+      DEFAULT_CONFIGURATION =
+          SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
+
+      private
+
+      def all_cops_config
+        config.for_all_cops
+      end
+
+      def sketchup_cops_config
+        config.for_all_cops.fetch('SketchUp', DEFAULT_CONFIGURATION)
+      end
+
+
+      def sketchup_config_key?(key)
+        return unless all_cops_config.key?('SketchUp')
+
+        all_cops_config.fetch('SketchUp').key?(key)
+      end
+
+
+      def sketchup_target_version?
+        sketchup_config_key?('TargetSketchUpVersion')
+      end
+
+      def sketchup_target_version
+        version = sketchup_cops_config.fetch('TargetSketchUpVersion')
+        version ? SketchUpVersion.new(version) : nil
+      end
+
+
+      def extension_source_path_config?
+        sketchup_config_key?('SourcePath')
+      end
+
+      def extension_source_path_config
+        sketchup_cops_config.fetch('SourcePath')
+      end
+
+
+      def encrypted_extension?
+        sketchup_config_key?('EncryptedExtension') &&
+          sketchup_cops_config.fetch('EncryptedExtension')
+      end
+
+
+      def extension_binaries?
+        sketchup_config_key?('ExtensionBinaries')
+      end
+
+      def extension_binaries
+        sketchup_cops_config.fetch('ExtensionBinaries')
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/deprecations/add_separator_to_menu.rb

@@ -1,25 +1,25 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupDeprecations
-      # Avoid adding separators to top level menus. If you require grouping use
-      # a sub-menu instead.
-      class AddSeparatorToMenu < SketchUp::Cop
-
-        MSG = 'Method is deprecated.'.freeze
-
-        def_node_matcher :add_separator_to_menu?, <<-PATTERN
-          (send nil? :add_separator_to_menu _)
-        PATTERN
-
-        def on_send(node)
-          return unless add_separator_to_menu?(node)
-
-          add_offense(node, location: :selector)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      # Avoid adding separators to top level menus. If you require grouping use
+      # a sub-menu instead.
+      class AddSeparatorToMenu < SketchUp::Cop
+
+        MSG = 'Method is deprecated.'.freeze
+
+        def_node_matcher :add_separator_to_menu?, <<-PATTERN
+          (send nil? :add_separator_to_menu _)
+        PATTERN
+
+        def on_send(node)
+          return unless add_separator_to_menu?(node)
+
+          add_offense(node, location: :selector)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/deprecations/operation_next_transparent.rb

@@ -1,30 +1,30 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupDeprecations
-      # If set to true, then whatever operation comes after this one will be
-      # appended into one combined operation, allowing the user the undo both
-      # actions with a single undo command.
-      #
-      # This flag is a highly difficult one, since there are so many ways that a
-      # SketchUp user can interrupt a given operation with one of their own.
-      #
-      # Only use this flag if you have no other option, for instance to work
-      # around bug in how `Sketchup::Model#place_component` starts operations.
-      class OperationNextTransparent < SketchUp::Cop
-        MSG = 'Third argument is deprecated.'.freeze
-
-        def on_send(node)
-          _, method_name, *args = *node
-          return unless method_name == :start_operation
-          return if args.size < 3
-
-          argument = args[2]
-          next_transparent = (argument.type == :true)
-          add_offense(argument, location: :expression) if next_transparent
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      # If set to true, then whatever operation comes after this one will be
+      # appended into one combined operation, allowing the user the undo both
+      # actions with a single undo command.
+      #
+      # This flag is a highly difficult one, since there are so many ways that a
+      # SketchUp user can interrupt a given operation with one of their own.
+      #
+      # Only use this flag if you have no other option, for instance to work
+      # around bug in how `Sketchup::Model#place_component` starts operations.
+      class OperationNextTransparent < SketchUp::Cop
+        MSG = 'Third argument is deprecated.'.freeze
+
+        def on_send(node)
+          _, method_name, *args = *node
+          return unless method_name == :start_operation
+          return if args.size < 3
+
+          argument = args[2]
+          next_transparent = (argument.type == :true)
+          add_offense(argument, location: :expression) if next_transparent
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/deprecations/require_all.rb

@@ -1,27 +1,27 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupDeprecations
-      # Method is deprecated because it adds the given path to `$LOAD_PATH`.
-      # Modifying `$LOAD_PATH` is bad practice because it can cause extensions
-      # to inadvertently load the wrong file.
-      class RequireAll < SketchUp::Cop
-
-        MSG = 'Method is deprecated because it adds the given path '\
-              'to $LOAD_PATH.'.freeze
-
-        def_node_matcher :require_all?, <<-PATTERN
-          (send nil? :require_all _)
-        PATTERN
-
-        def on_send(node)
-          return unless require_all?(node)
-
-          add_offense(node, location: :selector)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      # Method is deprecated because it adds the given path to `$LOAD_PATH`.
+      # Modifying `$LOAD_PATH` is bad practice because it can cause extensions
+      # to inadvertently load the wrong file.
+      class RequireAll < SketchUp::Cop
+
+        MSG = 'Method is deprecated because it adds the given path '\
+              'to $LOAD_PATH.'.freeze
+
+        def_node_matcher :require_all?, <<-PATTERN
+          (send nil? :require_all _)
+        PATTERN
+
+        def on_send(node)
+          return unless require_all?(node)
+
+          add_offense(node, location: :selector)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/deprecations/set_texture_projection.rb

@@ -1,26 +1,26 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupDeprecations
-      # Method is deprecated because it creates invalid UV mapping. Saving the
-      # model will display a dialog indicating that the model needs to be
-      # repaired. Once repaired the UV mapping will visually change.
-      class SetTextureProjection < SketchUp::Cop
-
-        MSG = 'Method is deprecated. It can create invalid UV mapping.'.freeze
-
-        def_node_matcher :set_texture_projection?, <<-PATTERN
-          (send _ :set_texture_projection ...)
-        PATTERN
-
-        def on_send(node)
-          return unless set_texture_projection?(node)
-
-          add_offense(node, location: :selector)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      # Method is deprecated because it creates invalid UV mapping. Saving the
+      # model will display a dialog indicating that the model needs to be
+      # repaired. Once repaired the UV mapping will visually change.
+      class SetTextureProjection < SketchUp::Cop
+
+        MSG = 'Method is deprecated. It can create invalid UV mapping.'.freeze
+
+        def_node_matcher :set_texture_projection?, <<-PATTERN
+          (send _ :set_texture_projection ...)
+        PATTERN
+
+        def on_send(node)
+          return unless set_texture_projection?(node)
+
+          add_offense(node, location: :selector)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/deprecations/show_ruby_panel.rb

@@ -1,25 +1,25 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupDeprecations
-      # Method is deprecated. Use `SKETCHUP_CONSOLE.show` instead.
-      class ShowRubyPanel < SketchUp::Cop
-
-        MSG = 'Method is deprecated. Use `SKETCHUP_CONSOLE.show` '\
-               'instead.'.freeze
-
-        def_node_matcher :show_ruby_panel?, <<-PATTERN
-          (send nil? :show_ruby_panel)
-        PATTERN
-
-        def on_send(node)
-          return unless show_ruby_panel?(node)
-
-          add_offense(node, location: :expression)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      # Method is deprecated. Use `SKETCHUP_CONSOLE.show` instead.
+      class ShowRubyPanel < SketchUp::Cop
+
+        MSG = 'Method is deprecated. Use `SKETCHUP_CONSOLE.show` '\
+               'instead.'.freeze
+
+        def_node_matcher :show_ruby_panel?, <<-PATTERN
+          (send nil? :show_ruby_panel)
+        PATTERN
+
+        def on_send(node)
+          return unless show_ruby_panel?(node)
+
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/deprecations/sketchup_set.rb

@@ -1,30 +1,30 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupDeprecations
-      # From SketchUp 6 until SketchUp 2013 the SketchUp API shipped with a
-      # `Set` class. When SketchUp started shipping with the Ruby StdLib in
-      # SketchUp 2014 the class was changed from `Set` to `Sketchup::Set` in
-      # order to avoid conflict with the Ruby Standard Library.
-      #
-      # The `Sketchup::Set` class is much slower than Ruby's own `Set` class
-      # and less versatile.
-      class SketchupSet < SketchUp::Cop
-
-        MSG = 'Class is deprecated.'.freeze
-
-        def_node_matcher :sketchup_set?, <<-PATTERN
-          (const (const nil? :Sketchup) :Set)
-        PATTERN
-
-        def on_const(node)
-          return unless sketchup_set?(node)
-
-          add_offense(node, location: :expression)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      # From SketchUp 6 until SketchUp 2013 the SketchUp API shipped with a
+      # `Set` class. When SketchUp started shipping with the Ruby StdLib in
+      # SketchUp 2014 the class was changed from `Set` to `Sketchup::Set` in
+      # order to avoid conflict with the Ruby Standard Library.
+      #
+      # The `Sketchup::Set` class is much slower than Ruby's own `Set` class
+      # and less versatile.
+      class SketchupSet < SketchUp::Cop
+
+        MSG = 'Class is deprecated.'.freeze
+
+        def_node_matcher :sketchup_set?, <<-PATTERN
+          (const (const nil? :Sketchup) :Set)
+        PATTERN
+
+        def on_const(node)
+          return unless sketchup_set?(node)
+
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/performance/openssl.rb

@@ -1,41 +1,41 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupPerformance
-      # There are performance issue with the OpenSSL library that Ruby ship. In
-      # a clean SU session, default model there is a small delay observed in the
-      # Windows version of SU.
-      #
-      # But with a larger model loaded, or session that have had larger files
-      # loaded the lag will be minutes.
-      #
-      # `SecureRandom` is  also affected by this, as it uses OpenSSL to seed.
-      #
-      # It also affects `Net::HTTP` if making HTTPS connections.
-      class OpenSSL < SketchUp::Cop
-
-        MSG = 'Avoid use of OpenSSL within SketchUp due to severe performance '\
-              'issues.'.freeze
-
-        # http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
-        # https://rubocop.readthedocs.io/en/latest/node_pattern/
-        def_node_matcher :require, <<-PATTERN
-          (send nil? :require
-            (str $_)
-          )
-        PATTERN
-
-        OPEN_SSL_USAGE = %w[openssl securerandom net/https net/http].freeze
-
-        def on_send(node)
-          filename = require(node)
-          return if filename.nil?
-          return unless OPEN_SSL_USAGE.include?(filename.downcase)
-
-          add_offense(node, location: :expression)
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupPerformance
+      # There are performance issue with the OpenSSL library that Ruby ship. In
+      # a clean SU session, default model there is a small delay observed in the
+      # Windows version of SU.
+      #
+      # But with a larger model loaded, or session that have had larger files
+      # loaded the lag will be minutes.
+      #
+      # `SecureRandom` is  also affected by this, as it uses OpenSSL to seed.
+      #
+      # It also affects `Net::HTTP` if making HTTPS connections.
+      class OpenSSL < SketchUp::Cop
+
+        MSG = 'Avoid use of OpenSSL within SketchUp due to severe performance '\
+              'issues.'.freeze
+
+        # http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
+        # https://rubocop.readthedocs.io/en/latest/node_pattern/
+        def_node_matcher :require, <<-PATTERN
+          (send nil? :require
+            (str $_)
+          )
+        PATTERN
+
+        OPEN_SSL_USAGE = %w[openssl securerandom net/https net/http].freeze
+
+        def on_send(node)
+          filename = require(node)
+          return if filename.nil?
+          return unless OPEN_SSL_USAGE.include?(filename.downcase)
+
+          add_offense(node, location: :expression)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/performance/operation_disable_ui.rb

@@ -1,33 +1,33 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupPerformance
-      # Operations should disable the UI for performance gain.
-      #
-      # @example
-      #   model = Sketchup.active_model
-      #   model.start_operation('Operation Name', true)
-      #   # <model changes>
-      #   model.commit_operation
-      class OperationDisableUI < SketchUp::Cop
-        MSG = 'Operations should disable the UI for performance gain.'.freeze
-
-        def on_send(node)
-          _, method_name, *args = *node
-          return unless method_name == :start_operation
-
-          if args.size < 2
-            add_offense(node, location: :selector)
-            return
-          end
-          argument = args[1]
-          disable_ui = argument.truthy_literal?
-          return if disable_ui
-
-          add_offense(argument, location: :expression)
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupPerformance
+      # Operations should disable the UI for performance gain.
+      #
+      # @example
+      #   model = Sketchup.active_model
+      #   model.start_operation('Operation Name', true)
+      #   # <model changes>
+      #   model.commit_operation
+      class OperationDisableUI < SketchUp::Cop
+        MSG = 'Operations should disable the UI for performance gain.'.freeze
+
+        def on_send(node)
+          _, method_name, *args = *node
+          return unless method_name == :start_operation
+
+          if args.size < 2
+            add_offense(node, location: :selector)
+            return
+          end
+          argument = args[1]
+          disable_ui = argument.truthy_literal?
+          return if disable_ui
+
+          add_offense(argument, location: :expression)
+        end
+      end
+    end
+  end
+end