rubocop-sketchup 0.5.0 → 0.6.0

data/lib/rubocop/sketchup/cop.rb

@@ -1,111 +1,111 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-
-    WorkaroundCop = RuboCop::Cop::Cop.dup
-
-    # Clone of the the normal RuboCop::Cop::Cop class so we can rewrite
-    # the inherited method without breaking functionality
-    class WorkaroundCop
-      # Remove the Cop.inherited method to be a noop. Our SketchUp::Cop
-      # class will invoke the inherited hook instead
-      class << self
-        undef inherited
-        def inherited(*) end
-      end
-
-      # Special case `Module#<` so that the rspec support rubocop exports
-      # is compatible with our subclass
-      def self.<(other)
-        other.equal?(RuboCop::Cop::Cop) || super
-      end
-    end
-    private_constant(:WorkaroundCop)
-
-    # @abstract parent class to SketchUp cops
-    #
-    # The criteria for whether rubocop-sketchup analyzes a certain ruby file
-    # is configured via `AllCops/SketchUp`. For example, if you want to
-    # customize your project to scan all files within a `test/` directory
-    # then you could add this to your configuration:
-    #
-    # @example configuring analyzed paths
-    #
-    #   AllCops:
-    #     SketchUp:
-    #       SketchupDeprecations:
-    #         Exclude:
-    #         - '_test.rb$'
-    #         - '(?:^|/)test/'
-    class Cop < WorkaroundCop
-
-      include SketchUp::Config
-
-      # Invoke the original inherited hook so our cops are recognized
-      def self.inherited(subclass)
-        RuboCop::Cop::Cop.inherited(subclass)
-      end
-
-      def relevant_file?(file)
-        relevant_rubocop_sketchup_file?(file) && super
-      end
-
-      private
-
-      def default_severity
-        sketchup_severity || super
-      end
-
-      def sketchup_severity
-        case self.class.department
-        when :SketchupRequirements
-          :error
-        when :SketchupDeprecations
-          :warning
-        when :SketchupPerformance
-          :warning
-        when :SketchupSuggestions
-          :convention
-        end
-      end
-
-      def department_name
-        self.class.department.to_s
-      end
-
-      def relevant_rubocop_sketchup_file?(file)
-        !sketchup_excluded?(file)
-      end
-
-      def sketchup_excluded?(file)
-        matches_file?(file, sketchup_exclude_pattern) ||
-          matches_file?(file, sketchup_department_exclude_pattern)
-      end
-
-      def matches_file?(file, patterns)
-        path = nil
-        patterns.any? do |pattern|
-          # Try to match the absolute path, as Exclude properties are absolute.
-          next true if match_path?(pattern, file)
-
-          # Try with relative path.
-          path ||= config.path_relative_to_config(file)
-          match_path?(pattern, path)
-        end
-      end
-
-      def sketchup_department_exclude_pattern
-        sketchup_cops_config
-          .fetch(department_name, {})
-          .fetch('Exclude', [])
-      end
-
-      def sketchup_exclude_pattern
-        sketchup_cops_config
-          .fetch('Exclude', [])
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+
+    WorkaroundCop = RuboCop::Cop::Cop.dup
+
+    # Clone of the the normal RuboCop::Cop::Cop class so we can rewrite
+    # the inherited method without breaking functionality
+    class WorkaroundCop
+      # Remove the Cop.inherited method to be a noop. Our SketchUp::Cop
+      # class will invoke the inherited hook instead
+      class << self
+        undef inherited
+        def inherited(*) end
+      end
+
+      # Special case `Module#<` so that the rspec support rubocop exports
+      # is compatible with our subclass
+      def self.<(other)
+        other.equal?(RuboCop::Cop::Cop) || super
+      end
+    end
+    private_constant(:WorkaroundCop)
+
+    # @abstract parent class to SketchUp cops
+    #
+    # The criteria for whether rubocop-sketchup analyzes a certain ruby file
+    # is configured via `AllCops/SketchUp`. For example, if you want to
+    # customize your project to scan all files within a `test/` directory
+    # then you could add this to your configuration:
+    #
+    # @example configuring analyzed paths
+    #
+    #   AllCops:
+    #     SketchUp:
+    #       SketchupDeprecations:
+    #         Exclude:
+    #         - '_test.rb$'
+    #         - '(?:^|/)test/'
+    class Cop < WorkaroundCop
+
+      include SketchUp::Config
+
+      # Invoke the original inherited hook so our cops are recognized
+      def self.inherited(subclass)
+        RuboCop::Cop::Cop.inherited(subclass)
+      end
+
+      def relevant_file?(file)
+        relevant_rubocop_sketchup_file?(file) && super
+      end
+
+      private
+
+      def default_severity
+        sketchup_severity || super
+      end
+
+      def sketchup_severity
+        case self.class.department
+        when :SketchupRequirements
+          :error
+        when :SketchupDeprecations
+          :warning
+        when :SketchupPerformance
+          :warning
+        when :SketchupSuggestions
+          :convention
+        end
+      end
+
+      def department_name
+        self.class.department.to_s
+      end
+
+      def relevant_rubocop_sketchup_file?(file)
+        !sketchup_excluded?(file)
+      end
+
+      def sketchup_excluded?(file)
+        matches_file?(file, sketchup_exclude_pattern) ||
+          matches_file?(file, sketchup_department_exclude_pattern)
+      end
+
+      def matches_file?(file, patterns)
+        path = nil
+        patterns.any? do |pattern|
+          # Try to match the absolute path, as Exclude properties are absolute.
+          next true if match_path?(pattern, file)
+
+          # Try with relative path.
+          path ||= config.path_relative_to_config(file)
+          match_path?(pattern, path)
+        end
+      end
+
+      def sketchup_department_exclude_pattern
+        sketchup_cops_config
+          .fetch(department_name, {})
+          .fetch('Exclude', [])
+      end
+
+      def sketchup_exclude_pattern
+        sketchup_cops_config
+          .fetch('Exclude', [])
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/dc_globals.rb

@@ -1,24 +1,24 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module DynamicComponentGlobals
-
-      DC_GLOBALS = %i[
-        $dc_strings
-        $dc_extension
-        $dc_CONFIGURATOR_NAME
-        $dc_REPORTER_NAME
-        $dc_MANAGER_NAME
-        $dc_observers
-      ].freeze
-
-      private
-
-      def dc_global_var?(global_var)
-        DC_GLOBALS.include?(global_var)
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module DynamicComponentGlobals
+
+      DC_GLOBALS = %i[
+        $dc_strings
+        $dc_extension
+        $dc_CONFIGURATOR_NAME
+        $dc_REPORTER_NAME
+        $dc_MANAGER_NAME
+        $dc_observers
+      ].freeze
+
+      private
+
+      def dc_global_var?(global_var)
+        DC_GLOBALS.include?(global_var)
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/dc_methods.rb

@@ -1,130 +1,130 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module DynamicComponentMethods
-
-      DC_METHODS = [
-        {
-          name: :rotx,
-          path: 'Geom::Transformation',
-        },
-        {
-          name: :roty,
-          path: 'Geom::Transformation',
-        },
-        {
-          name: :rotz,
-          path: 'Geom::Transformation',
-        },
-        {
-          name: :xscale,
-          path: 'Geom::Transformation',
-        },
-        {
-          name: :yscale,
-          path: 'Geom::Transformation',
-        },
-        {
-          name: :zscale,
-          path: 'Geom::Transformation',
-        },
-
-        {
-          name: :copy,
-          path: 'Sketchup::Camera',
-          variables: [:camera, :cam],
-        },
-        {
-          name: :update,
-          path: 'Sketchup::Camera',
-          variables: [:camera, :cam],
-        },
-        {
-          name: :same_camera_params?,
-          path: 'Sketchup::Camera',
-        },
-
-        {
-          name: :copy,
-          path: 'Sketchup::ComponentInstance',
-          variables: [:instance, :inst],
-        },
-        {
-          name: :description,
-          path: 'Sketchup::ComponentInstance',
-          variables: [:instance, :inst],
-        },
-
-        {
-          name: :local_transformation,
-          path: 'Sketchup::Drawingelement',
-        },
-        {
-          name: :scaled_size,
-          path: 'Sketchup::Drawingelement',
-        },
-        {
-          name: :unscaled_size,
-          path: 'Sketchup::Drawingelement',
-        },
-        {
-          name: :set_last_size,
-          path: 'Sketchup::Drawingelement',
-        },
-        {
-          name: :last_scaling_factors,
-          path: 'Sketchup::Drawingelement',
-        },
-
-        {
-          name: :get_attributes,
-          path: 'Sketchup::Entity',
-        },
-        {
-          name: :has_attributes?,
-          path: 'Sketchup::Entity',
-        },
-
-        {
-          name: :typename,
-          path: 'Sketchup::Model',
-          variables: [:model, :mod],
-        },
-        {
-          name: :entityID,
-          path: 'Sketchup::Model',
-          variables: [:model, :mod],
-        },
-        {
-          name: :delete_attribute,
-          path: 'Sketchup::Model',
-          variables: [:model, :mod],
-        },
-        {
-          name: :layer,
-          path: 'Sketchup::Model',
-          variables: [:model, :mod],
-        },
-
-        {
-          name: :last_width=,
-          path: 'UI::WebDialog',
-        },
-        {
-          name: :last_height=,
-          path: 'UI::WebDialog',
-        },
-        {
-          name: :last_width,
-          path: 'UI::WebDialog',
-        },
-        {
-          name: :last_height,
-          path: 'UI::WebDialog',
-        },
-      ].freeze
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module DynamicComponentMethods
+
+      DC_METHODS = [
+        {
+          name: :rotx,
+          path: 'Geom::Transformation',
+        },
+        {
+          name: :roty,
+          path: 'Geom::Transformation',
+        },
+        {
+          name: :rotz,
+          path: 'Geom::Transformation',
+        },
+        {
+          name: :xscale,
+          path: 'Geom::Transformation',
+        },
+        {
+          name: :yscale,
+          path: 'Geom::Transformation',
+        },
+        {
+          name: :zscale,
+          path: 'Geom::Transformation',
+        },
+
+        {
+          name: :copy,
+          path: 'Sketchup::Camera',
+          variables: [:camera, :cam],
+        },
+        {
+          name: :update,
+          path: 'Sketchup::Camera',
+          variables: [:camera, :cam],
+        },
+        {
+          name: :same_camera_params?,
+          path: 'Sketchup::Camera',
+        },
+
+        {
+          name: :copy,
+          path: 'Sketchup::ComponentInstance',
+          variables: [:instance, :inst],
+        },
+        {
+          name: :description,
+          path: 'Sketchup::ComponentInstance',
+          variables: [:instance, :inst],
+        },
+
+        {
+          name: :local_transformation,
+          path: 'Sketchup::Drawingelement',
+        },
+        {
+          name: :scaled_size,
+          path: 'Sketchup::Drawingelement',
+        },
+        {
+          name: :unscaled_size,
+          path: 'Sketchup::Drawingelement',
+        },
+        {
+          name: :set_last_size,
+          path: 'Sketchup::Drawingelement',
+        },
+        {
+          name: :last_scaling_factors,
+          path: 'Sketchup::Drawingelement',
+        },
+
+        {
+          name: :get_attributes,
+          path: 'Sketchup::Entity',
+        },
+        {
+          name: :has_attributes?,
+          path: 'Sketchup::Entity',
+        },
+
+        {
+          name: :typename,
+          path: 'Sketchup::Model',
+          variables: [:model, :mod],
+        },
+        {
+          name: :entityID,
+          path: 'Sketchup::Model',
+          variables: [:model, :mod],
+        },
+        {
+          name: :delete_attribute,
+          path: 'Sketchup::Model',
+          variables: [:model, :mod],
+        },
+        {
+          name: :layer,
+          path: 'Sketchup::Model',
+          variables: [:model, :mod],
+        },
+
+        {
+          name: :last_width=,
+          path: 'UI::WebDialog',
+        },
+        {
+          name: :last_height=,
+          path: 'UI::WebDialog',
+        },
+        {
+          name: :last_width,
+          path: 'UI::WebDialog',
+        },
+        {
+          name: :last_height,
+          path: 'UI::WebDialog',
+        },
+      ].freeze
+
+    end
+  end
+end

data/lib/rubocop/sketchup/extension_project.rb

@@ -1,65 +1,65 @@
-# frozen_string_literal: true
-
-require 'pathname'
-
-module RuboCop
-  module SketchUp
-    module ExtensionProject
-
-      include SketchUp::Config
-
-      # @return [Pathname]
-      def config_path
-        path = config.instance_variable_get(:@loaded_path)
-        if path
-          Pathname.new(path).expand_path.dirname
-        else
-          Pathname.new(Dir.pwd).expand_path
-        end
-      end
-
-      # @return [Pathname]
-      def relative_source_path
-        Pathname.new(extension_source_path_config)
-      end
-
-      # @return [Pathname]
-      def source_path
-        config_path.join(relative_source_path)
-      end
-
-      # @param [RuboCop::ProcessedSource] processed_source
-      def path_relative_to_source(processed_source)
-        source_filename = processed_source.buffer.name
-        rel_path = config.path_relative_to_config(source_filename)
-        path = Pathname.new(rel_path).expand_path
-        path.relative_path_from(source_path)
-      end
-
-      # @param [RuboCop::ProcessedSource] processed_source
-      def root_file?(processed_source)
-        filename = path_relative_to_source(processed_source)
-        filename.extname.casecmp('.rb').zero? &&
-          filename.parent.to_s == '.'
-      end
-
-      def extension_root_files
-        Dir.glob("#{source_path}/*.rb").map { |path| Pathname.new(path) }
-      end
-
-      def extension_root_file
-        unless extension_root_files.size == 1
-          num_files = extension_root_files.size
-          raise "More than one root extension file (#{num_files})"
-        end
-
-        extension_root_files.first
-      end
-
-      def extension_directory
-        extension_root_file.dirname
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'pathname'
+
+module RuboCop
+  module SketchUp
+    module ExtensionProject
+
+      include SketchUp::Config
+
+      # @return [Pathname]
+      def config_path
+        path = config.instance_variable_get(:@loaded_path)
+        if path
+          Pathname.new(path).expand_path.dirname
+        else
+          Pathname.new(Dir.pwd).expand_path
+        end
+      end
+
+      # @return [Pathname]
+      def relative_source_path
+        Pathname.new(extension_source_path_config)
+      end
+
+      # @return [Pathname]
+      def source_path
+        config_path.join(relative_source_path)
+      end
+
+      # @param [RuboCop::ProcessedSource] processed_source
+      def path_relative_to_source(processed_source)
+        source_filename = processed_source.buffer.name
+        rel_path = config.path_relative_to_config(source_filename)
+        path = Pathname.new(rel_path).expand_path
+        path.relative_path_from(source_path)
+      end
+
+      # @param [RuboCop::ProcessedSource] processed_source
+      def root_file?(processed_source)
+        filename = path_relative_to_source(processed_source)
+        filename.extname.casecmp('.rb').zero? &&
+          filename.parent.to_s == '.'
+      end
+
+      def extension_root_files
+        Dir.glob("#{source_path}/*.rb").map { |path| Pathname.new(path) }
+      end
+
+      def extension_root_file
+        unless extension_root_files.size == 1
+          num_files = extension_root_files.size
+          raise "More than one root extension file (#{num_files})"
+        end
+
+        extension_root_files.first
+      end
+
+      def extension_directory
+        extension_root_file.dirname
+      end
+
+    end
+  end
+end