rubocop-sketchup 0.5.0 → 0.6.0

data/lib/rubocop/sketchup/namespace_checker.rb

@@ -1,46 +1,46 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module NamespaceChecker
-
-      def on_class(node)
-        check_namespace(node)
-      end
-
-      def on_module(node)
-        check_namespace(node)
-      end
-
-      def on_def(node)
-        check_namespace(node)
-      end
-      alias on_defs on_def
-
-      # Constant assignment.
-      def on_casgn(node)
-        check_namespace(node)
-      end
-
-      def check_namespace(node)
-        return unless in_namespace?(node)
-
-        add_offense(node, location: :name, severity: :error)
-      end
-
-      def in_namespace?(node)
-        # parent_module_name might return nil if for instance a method is
-        # defined within a block. (Apparently that is possible...)
-        return false if node.parent_module_name.nil?
-
-        namespace = SketchUp::Namespace.new(node.parent_module_name)
-        namespaces.include?(namespace.first)
-      end
-
-      def namespaces
-        raise NotImplementedError
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module NamespaceChecker
+
+      def on_class(node)
+        check_namespace(node)
+      end
+
+      def on_module(node)
+        check_namespace(node)
+      end
+
+      def on_def(node)
+        check_namespace(node)
+      end
+      alias on_defs on_def
+
+      # Constant assignment.
+      def on_casgn(node)
+        check_namespace(node)
+      end
+
+      def check_namespace(node)
+        return unless in_namespace?(node)
+
+        add_offense(node, location: :name, severity: :error)
+      end
+
+      def in_namespace?(node)
+        # parent_module_name might return nil if for instance a method is
+        # defined within a block. (Apparently that is possible...)
+        return false if node.parent_module_name.nil?
+
+        namespace = SketchUp::Namespace.new(node.parent_module_name)
+        namespaces.include?(namespace.first)
+      end
+
+      def namespaces
+        raise NotImplementedError
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/no_comment_disable.rb

@@ -1,17 +1,17 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module NoCommentDisable
-
-      private
-
-      # This forces the cop to be run even if there is a source code comment
-      # that tries to disable it.
-      def enabled_line?(_line_number)
-        true
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module NoCommentDisable
+
+      private
+
+      # This forces the cop to be run even if there is a source code comment
+      # that tries to disable it.
+      def enabled_line?(_line_number)
+        true
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/range_help.rb

@@ -1,52 +1,52 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Methods that calculate and return Parser::Source::Ranges
-    module RangeHelp
-
-      private
-
-      def range_with_receiver(node)
-        receiver = node.receiver
-        loc_begin = if receiver.send_type?
-                      receiver.loc.selector.begin_pos
-                    else
-                      receiver.loc.expression.begin_pos
-                    end
-        loc_end = node.loc.selector.end_pos
-        range_between(loc_begin, loc_end)
-      end
-
-      def string_contents_range(node)
-        begin_pos = node.loc.begin.end_pos
-        end_pos = node.loc.end.begin_pos
-        range_between(begin_pos, end_pos)
-      end
-
-      def arguments_range(node)
-        begin_pos = node.arguments.first.loc.expression.begin_pos
-        end_pos = node.arguments.last.loc.expression.end_pos
-        range_between(begin_pos, end_pos)
-      end
-
-      def conditional_range(node)
-        if node.modifier_form?
-          range_between(node.loc.keyword.begin_pos,
-              node.loc.expression.end_pos)
-        else
-          :expression
-        end
-      end
-
-      def file_ext_range(argument_node)
-        filename = argument_node.str_content
-        ext_size = File.extname(filename).size
-        end_pos = argument_node.loc.end.begin_pos
-        begin_pos = end_pos - ext_size
-        range_between(begin_pos, end_pos)
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Methods that calculate and return Parser::Source::Ranges
+    module RangeHelp
+
+      private
+
+      def range_with_receiver(node)
+        receiver = node.receiver
+        loc_begin = if receiver.send_type?
+                      receiver.loc.selector.begin_pos
+                    else
+                      receiver.loc.expression.begin_pos
+                    end
+        loc_end = node.loc.selector.end_pos
+        range_between(loc_begin, loc_end)
+      end
+
+      def string_contents_range(node)
+        begin_pos = node.loc.begin.end_pos
+        end_pos = node.loc.end.begin_pos
+        range_between(begin_pos, end_pos)
+      end
+
+      def arguments_range(node)
+        begin_pos = node.arguments.first.loc.expression.begin_pos
+        end_pos = node.arguments.last.loc.expression.end_pos
+        range_between(begin_pos, end_pos)
+      end
+
+      def conditional_range(node)
+        if node.modifier_form?
+          range_between(node.loc.keyword.begin_pos,
+              node.loc.expression.end_pos)
+        else
+          :expression
+        end
+      end
+
+      def file_ext_range(argument_node)
+        filename = argument_node.str_content
+        ext_size = File.extname(filename).size
+        end_pos = argument_node.loc.end.begin_pos
+        begin_pos = end_pos - ext_size
+        range_between(begin_pos, end_pos)
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/sketchup_version.rb

@@ -1,87 +1,87 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    class SketchUpVersion
-
-      include Comparable
-
-      attr_reader :version, :maintenance
-
-      class InvalidVersion < StandardError; end
-
-      def initialize(version)
-        @version, @maintenance = parse_version(version)
-      end
-
-      def <=>(other)
-        if version == other.version
-          maintenance <=> other.maintenance
-        else
-          version <=> other.version
-        end
-      end
-
-      def to_s
-        string_version = version < 2013 ? version.to_f : version.to_i
-        if maintenance > 0
-          "SketchUp #{string_version} M#{maintenance}"
-        else
-          "SketchUp #{string_version}"
-        end
-      end
-
-      private
-
-      VERSION_NUMBER_REGEX = /^(?:SketchUp )?([0-9.]+)(?: M(\d+))?$/
-
-      # This list is compiled from the list of versions reported by YARD when
-      # running the `versions` template;
-      #
-      #   yardoc -t versions -f text
-      #
-      # TODO(thomthom): Push the version template to the API stubs repository.
-      VALID_VERSIONS = [
-        [2018, 0],
-        [2017, 0],
-        [2016, 1],
-        [2016, 0],
-        [2015, 0],
-        [2014, 0],
-        [2013, 0],
-        [8.0, 2],
-        [8.0, 1],
-        [8.0, 0],
-        [7.1, 1],
-        [7.1, 0],
-        [7.0, 1],
-        [7.0, 0],
-        [6.0, 0],
-      ].freeze
-
-      def parse_version(version)
-        v = 0
-        m = 0
-        if version.is_a?(String)
-          # Treat all LayOut versions as SketchUp versions for now.
-          normalised_version = version.gsub('LayOut', 'SketchUp')
-          result = normalised_version.match(VERSION_NUMBER_REGEX)
-          if result
-            v = result.captures[0].to_f
-            m = (result.captures[1] || '0').to_i
-          end
-        elsif version.is_a?(Numeric)
-          v = version
-          m = 0
-        end
-        version_parts = [v, m]
-        unless VALID_VERSIONS.include?(version_parts)
-          raise InvalidVersion, "#{version} is not a valid SketchUp version"
-        end
-
-        version_parts
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    class SketchUpVersion
+
+      include Comparable
+
+      attr_reader :version, :maintenance
+
+      class InvalidVersion < StandardError; end
+
+      def initialize(version)
+        @version, @maintenance = parse_version(version)
+      end
+
+      def <=>(other)
+        if version == other.version
+          maintenance <=> other.maintenance
+        else
+          version <=> other.version
+        end
+      end
+
+      def to_s
+        string_version = version < 2013 ? version.to_f : version.to_i
+        if maintenance > 0
+          "SketchUp #{string_version} M#{maintenance}"
+        else
+          "SketchUp #{string_version}"
+        end
+      end
+
+      private
+
+      VERSION_NUMBER_REGEX = /^(?:SketchUp )?([0-9.]+)(?: M(\d+))?$/.freeze
+
+      # This list is compiled from the list of versions reported by YARD when
+      # running the `versions` template;
+      #
+      #   yardoc -t versions -f text
+      #
+      # TODO(thomthom): Push the version template to the API stubs repository.
+      VALID_VERSIONS = [
+        [2018, 0],
+        [2017, 0],
+        [2016, 1],
+        [2016, 0],
+        [2015, 0],
+        [2014, 0],
+        [2013, 0],
+        [8.0, 2],
+        [8.0, 1],
+        [8.0, 0],
+        [7.1, 1],
+        [7.1, 0],
+        [7.0, 1],
+        [7.0, 0],
+        [6.0, 0],
+      ].freeze
+
+      def parse_version(version)
+        v = 0
+        m = 0
+        if version.is_a?(String)
+          # Treat all LayOut versions as SketchUp versions for now.
+          normalised_version = version.gsub('LayOut', 'SketchUp')
+          result = normalised_version.match(VERSION_NUMBER_REGEX)
+          if result
+            v = result.captures[0].to_f
+            m = (result.captures[1] || '0').to_i
+          end
+        elsif version.is_a?(Numeric)
+          v = version
+          m = 0
+        end
+        version_parts = [v, m]
+        unless VALID_VERSIONS.include?(version_parts)
+          raise InvalidVersion, "#{version} is not a valid SketchUp version"
+        end
+
+        version_parts
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/tool_checker.rb

@@ -1,43 +1,43 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module ToolChecker
-
-      def on_class(node)
-        name, _base_class, body = *node
-        return unless name.const_name.end_with?('Tool')
-
-        check_body(body, node)
-      end
-
-      private
-
-      # rubocop:disable Lint/UnusedMethodArgument
-      def on_tool_class(class_node, body, body_methods)
-        raise NotImplementedError, 'Implement this method'
-      end
-      # rubocop:enable Lint/UnusedMethodArgument
-
-      def body_methods(body)
-        return [body] if body.def_type?
-        return unless body.begin_type?
-
-        body.each_child_node(:def)
-      end
-
-      def check_body(body, class_node)
-        return if body.nil? # Empty class etc.
-
-        body_methods = body_methods(body)
-
-        on_tool_class(class_node, body_methods)
-      end
-
-      def find_method(defs, method_name)
-        defs.find { |def_node| def_node.method?(method_name) }
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module ToolChecker
+
+      def on_class(node)
+        name, _base_class, body = *node
+        return unless name.const_name.end_with?('Tool')
+
+        check_body(body, node)
+      end
+
+      private
+
+      # rubocop:disable Lint/UnusedMethodArgument
+      def on_tool_class(class_node, body, body_methods)
+        raise NotImplementedError, 'Implement this method'
+      end
+      # rubocop:enable Lint/UnusedMethodArgument
+
+      def body_methods(body)
+        return [body] if body.def_type?
+        return unless body.begin_type?
+
+        body.each_child_node(:def)
+      end
+
+      def check_body(body, class_node)
+        return if body.nil? # Empty class etc.
+
+        body_methods = body_methods(body)
+
+        on_tool_class(class_node, body_methods)
+      end
+
+      def find_method(defs, method_name)
+        defs.find { |def_node| def_node.method?(method_name) }
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/version.rb

@@ -1,5 +1,5 @@
-module RuboCop
-  module SketchUp
-    VERSION = '0.5.0'.freeze
-  end
-end
+module RuboCop
+  module SketchUp
+    VERSION = '0.6.0'.freeze
+  end
+end

data/lib/rubocop/sketchup.rb

@@ -1,12 +1,12 @@
-require 'pathname'
-
-module RuboCop
-  # RuboCop SketchUp project namespace
-  module SketchUp
-    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
-    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
-    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
-
-    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
-  end
-end
+require 'pathname'
+
+module RuboCop
+  # RuboCop SketchUp project namespace
+  module SketchUp
+    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
+    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
+
+    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
+  end
+end

data/lib/rubocop-sketchup.rb

@@ -1,48 +1,48 @@
-require 'rubocop'
-require 'rubocop/sketchup'
-require 'rubocop/sketchup/version'
-require 'rubocop/sketchup/inject'
-
-require 'rubocop/sketchup/formatter/extension_review'
-require 'rubocop/sketchup/config'
-require 'rubocop/sketchup/cop'
-require 'rubocop/sketchup/dc_globals'
-require 'rubocop/sketchup/dc_methods'
-require 'rubocop/sketchup/extension_project'
-require 'rubocop/sketchup/features'
-require 'rubocop/sketchup/namespace'
-require 'rubocop/sketchup/namespace_checker'
-require 'rubocop/sketchup/no_comment_disable'
-require 'rubocop/sketchup/range_help'
-require 'rubocop/sketchup/sketchup_version'
-require 'rubocop/sketchup/tool_checker'
-
-RuboCop::SketchUp::Inject.defaults!
-
-# Monkey patching the built in formatter list to add a short alias for custom
-# formatters. Naughty! Naughty!
-class RuboCop::Formatter::FormatterSet
-  formatters = BUILTIN_FORMATTERS_FOR_KEYS.dup
-  formatters['extension_review'] =
-      RuboCop::Formatter::ExtensionReviewFormatter
-  verbose = $VERBOSE
-  begin
-    $VERBOSE = nil
-    BUILTIN_FORMATTERS_FOR_KEYS = formatters.freeze
-  ensure
-    $VERBOSE = verbose
-  end
-end
-
-# Make it easier to explore available methods on a method.
-class Object
-  def methods!
-    methods.sort - Object.class.instance_methods
-  end
-end
-
-# Load all custom cops.
-pattern = File.join(__dir__, 'rubocop', 'sketchup', 'cop', '**/*rb')
-Dir.glob(pattern) { |file|
-  require file
-}
+require 'rubocop'
+require 'rubocop/sketchup'
+require 'rubocop/sketchup/version'
+require 'rubocop/sketchup/inject'
+
+require 'rubocop/sketchup/formatter/extension_review'
+require 'rubocop/sketchup/config'
+require 'rubocop/sketchup/cop'
+require 'rubocop/sketchup/dc_globals'
+require 'rubocop/sketchup/dc_methods'
+require 'rubocop/sketchup/extension_project'
+require 'rubocop/sketchup/features'
+require 'rubocop/sketchup/namespace'
+require 'rubocop/sketchup/namespace_checker'
+require 'rubocop/sketchup/no_comment_disable'
+require 'rubocop/sketchup/range_help'
+require 'rubocop/sketchup/sketchup_version'
+require 'rubocop/sketchup/tool_checker'
+
+RuboCop::SketchUp::Inject.defaults!
+
+# Monkey patching the built in formatter list to add a short alias for custom
+# formatters. Naughty! Naughty!
+class RuboCop::Formatter::FormatterSet
+  formatters = BUILTIN_FORMATTERS_FOR_KEYS.dup
+  formatters['extension_review'] =
+      RuboCop::Formatter::ExtensionReviewFormatter
+  verbose = $VERBOSE
+  begin
+    $VERBOSE = nil
+    BUILTIN_FORMATTERS_FOR_KEYS = formatters.freeze
+  ensure
+    $VERBOSE = verbose
+  end
+end
+
+# Make it easier to explore available methods on a method.
+class Object
+  def methods!
+    methods.sort - Object.class.instance_methods
+  end
+end
+
+# Load all custom cops.
+pattern = File.join(__dir__, 'rubocop', 'sketchup', 'cop', '**/*rb')
+Dir.glob(pattern) { |file|
+  require file
+}