RubyGems - reform - Versions diffs - 2.1.0 → 2.2.0.rc1 - Mend

reform 2.1.0 → 2.2.0.rc1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (89) hide show

checksums.yaml +4 -4
data/.gitignore +0 -1
data/.travis.yml +4 -12
data/CHANGES.md +8 -0
data/README.md +36 -743
data/Rakefile +1 -31
data/gemfiles/{Gemfile.rails-3.1 → Gemfile.disposable-0.3} +1 -2
data/lib/reform.rb +0 -9
data/lib/reform/contract.rb +5 -1
data/lib/reform/form.rb +1 -4
data/lib/reform/form/composition.rb +1 -2
data/lib/reform/form/dry.rb +29 -16
data/lib/reform/form/module.rb +15 -3
data/lib/reform/form/validate.rb +1 -1
data/lib/reform/validation.rb +3 -3
data/lib/reform/version.rb +1 -1
data/reform.gemspec +3 -10
data/test/coercion_test.rb +7 -7
data/test/composition_test.rb +5 -1
data/test/contract_test.rb +10 -4
data/test/deserialize_test.rb +3 -3
data/test/errors_test.rb +48 -28
data/test/form_option_test.rb +3 -1
data/test/form_test.rb +19 -14
data/test/module_test.rb +51 -11
data/test/populate_test.rb +21 -7
data/test/reform_test.rb +24 -20
data/test/save_test.rb +10 -4
data/test/skip_if_test.rb +5 -3
data/test/test_helper.rb +3 -43
data/test/validate_test.rb +34 -14
data/test/validation/dry_test.rb +60 -0
data/test/validation/dry_validation_test.rb +65 -43
data/test/validation/errors.yml +4 -0
metadata +16 -192
data/database.sqlite3 +0 -0
data/gemfiles/Gemfile.rails-3.2 +0 -7
data/gemfiles/Gemfile.rails-4.0 +0 -8
data/gemfiles/Gemfile.rails-4.1 +0 -8
data/gemfiles/Gemfile.rails-4.2 +0 -8
data/lib/reform/active_record.rb +0 -4
data/lib/reform/form/active_model.rb +0 -87
data/lib/reform/form/active_model/form_builder_methods.rb +0 -48
data/lib/reform/form/active_model/model_reflections.rb +0 -46
data/lib/reform/form/active_model/model_validations.rb +0 -110
data/lib/reform/form/active_model/validations.rb +0 -107
data/lib/reform/form/active_record.rb +0 -30
data/lib/reform/form/lotus.rb +0 -59
data/lib/reform/form/multi_parameter_attributes.rb +0 -48
data/lib/reform/form/validation/unique_validator.rb +0 -54
data/lib/reform/rails.rb +0 -13
data/test/active_model_custom_validation_translations_test.rb +0 -75
data/test/active_model_test.rb +0 -207
data/test/active_model_validation_for_property_named_format_test.rb +0 -18
data/test/active_record_test.rb +0 -273
data/test/builder_test.rb +0 -32
data/test/custom_validation_test.rb +0 -47
data/test/dummy/Rakefile +0 -7
data/test/dummy/app/controllers/albums_controller.rb +0 -18
data/test/dummy/app/controllers/application_controller.rb +0 -4
data/test/dummy/app/controllers/musician_controller.rb +0 -5
data/test/dummy/app/forms/album_form.rb +0 -18
data/test/dummy/app/helpers/application_helper.rb +0 -2
data/test/dummy/app/models/album.rb +0 -4
data/test/dummy/app/models/song.rb +0 -3
data/test/dummy/app/views/albums/new.html.erb +0 -28
data/test/dummy/app/views/layouts/application.html.erb +0 -14
data/test/dummy/config.ru +0 -4
data/test/dummy/config/application.rb +0 -20
data/test/dummy/config/boot.rb +0 -10
data/test/dummy/config/database.yml +0 -22
data/test/dummy/config/environment.rb +0 -5
data/test/dummy/config/environments/development.rb +0 -16
data/test/dummy/config/environments/production.rb +0 -46
data/test/dummy/config/environments/test.rb +0 -33
data/test/dummy/config/locales/en.yml +0 -14
data/test/dummy/config/routes.rb +0 -4
data/test/dummy/db/test.sqlite3 +0 -0
data/test/form_builder_test.rb +0 -138
data/test/lotus/Gemfile +0 -5
data/test/lotus/lotus_test.rb +0 -31
data/test/lotus_test.rb +0 -150
data/test/model_reflections_test.rb +0 -138
data/test/model_validations_test.rb +0 -82
data/test/mongoid_test.rb +0 -313
data/test/multi_parameter_attributes_test.rb +0 -50
data/test/rails/integration_test.rb +0 -54
data/test/unique_test.rb +0 -135
data/test/validation/activemodel_validation_test.rb +0 -252

data/test/dummy/app/views/albums/new.html.erb DELETED

@@ -1,28 +0,0 @@
-New Album
-<%= form_for @form do |f| %>
-  <% if @form.errors.any? %>
-    <div>
-      <h3><%= pluralize(@form.errors.count, "error") %> prohibited this form from being saved:</h3>
-      <ul>
-        <% @form.errors.full_messages.each do |msg| %>
-          <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
-  <%= f.label :title, "Album Title" %>
-  <%= f.text_field :title %>
-  <%= f.fields_for :songs do |song| %>
-    <div>
-      <%= song.label :title %>
-      <%= song.text_field :title %>
-    </div>
-  <% end %>
-  <%= f.submit %>
-<% end %>

data/test/dummy/app/views/layouts/application.html.erb DELETED

@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <title>Dummy</title>
-  <%= stylesheet_link_tag :all %>
-  <%= javascript_include_tag :defaults %>
-  <%= csrf_meta_tag %>
-</head>
-<body>
-<%= yield %>
-</body>
-</html>

data/test/dummy/config.ru DELETED

@@ -1,4 +0,0 @@
-# This file is used by Rack-based servers to start the application.
-require ::File.expand_path('../config/environment',  __FILE__)
-run Dummy::Application

data/test/dummy/config/application.rb DELETED

@@ -1,20 +0,0 @@
-require File.expand_path('../boot', __FILE__)
-require "active_model/railtie"
-require "action_controller/railtie"
-require "action_view/railtie"
-Bundler.require
-module Dummy
-  class Application < Rails::Application
-    config.encoding = "utf-8"
-    # Configure sensitive parameters which will be filtered from the log file.
-    config.filter_parameters += [:password]
-    config.cache_store = :memory_store
-  end
-end
-#require "reform/rails" # FIXME: this has to happen automatically in the rake test_rails run.

data/test/dummy/config/boot.rb DELETED

@@ -1,10 +0,0 @@
-require 'rubygems'
-gemfile = File.expand_path('../../../../Gemfile', __FILE__)
-if File.exist?(gemfile)
-  ENV['BUNDLE_GEMFILE'] = gemfile
-  require 'bundler'
-  Bundler.setup
-end
-$:.unshift File.expand_path('../../../../lib', __FILE__)

data/test/dummy/config/database.yml DELETED

@@ -1,22 +0,0 @@
-# SQLite version 3.x
-#   gem install sqlite3-ruby (not necessary on OS X Leopard)
-development:
-  adapter: sqlite3
-  database: db/development.sqlite3
-  pool: 5
-  timeout: 5000
-# Warning: The database defined as "test" will be erased and
-# re-generated from your development database when you run "rake".
-# Do not set this db to the same as development or production.
-test:
-  adapter: sqlite3
-  database: db/test.sqlite3
-  pool: 5
-  timeout: 5000
-production:
-  adapter: sqlite3
-  database: db/production.sqlite3
-  pool: 5
-  timeout: 5000

data/test/dummy/config/environment.rb DELETED

@@ -1,5 +0,0 @@
-# Load the rails application
-require File.expand_path('../application', __FILE__)
-# Initialize the rails application
-Dummy::Application.initialize!

data/test/dummy/config/environments/development.rb DELETED

@@ -1,16 +0,0 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/environment.rb
-  # In the development environment your application's code is reloaded on
-  # every request.  This slows down response time but is perfect for development
-  # since you don't have to restart the webserver when you make code changes.
-  config.cache_classes = false
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-  # Show full error reports and disable caching
-  config.consider_all_requests_local       = true
-  config.action_controller.perform_caching = false
-  config.secret_key_base = 123
-end

data/test/dummy/config/environments/production.rb DELETED

@@ -1,46 +0,0 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/environment.rb
-  # The production environment is meant for finished, "live" apps.
-  # Code is not reloaded between requests
-  config.cache_classes = true
-  # Full error reports are disabled and caching is turned on
-  config.consider_all_requests_local       = false
-  config.action_controller.perform_caching = true
-  # Specifies the header that your server uses for sending files
-  config.action_dispatch.x_sendfile_header = "X-Sendfile"
-  # For nginx:
-  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect'
-  # If you have no front-end server that supports something like X-Sendfile,
-  # just comment this out and Rails will serve the files
-  # See everything in the log (default is :info)
-  # config.log_level = :debug
-  # Use a different logger for distributed setups
-  # config.logger = SyslogLogger.new
-  # Use a different cache store in production
-  # config.cache_store = :mem_cache_store
-  # Disable Rails's static asset server
-  # In production, Apache or nginx will already do this
-  config.serve_static_assets = false
-  # Enable serving of images, stylesheets, and javascripts from an asset server
-  # config.action_controller.asset_host = "http://assets.example.com"
-  # Disable delivery errors, bad email addresses will be ignored
-  # config.action_mailer.raise_delivery_errors = false
-  # Enable threaded mode
-  # config.threadsafe!
-  # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
-  # the I18n.default_locale when a translation can not be found)
-  config.i18n.fallbacks = true
-end

data/test/dummy/config/environments/test.rb DELETED

@@ -1,33 +0,0 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/environment.rb
-  # The test environment is used exclusively to run your application's
-  # test suite.  You never need to work with it otherwise.  Remember that
-  # your test database is "scratch space" for the test suite and is wiped
-  # and recreated between test runs.  Don't rely on the data there!
-  config.cache_classes = true
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-  # Show full error reports and disable caching
-  config.consider_all_requests_local       = true
-  config.action_controller.perform_caching = false
-  # Raise exceptions instead of rendering exception templates
-  config.action_dispatch.show_exceptions = false
-  # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
-  config.secret_key_base = "yo"
-  # Tell Action Mailer not to deliver emails to the real world.
-  # The :test delivery method accumulates sent emails in the
-  # ActionMailer::Base.deliveries array.
-  #config.action_mailer.delivery_method = :test
-  # Use SQL instead of Active Record's schema dumper when creating the test database.
-  # This is necessary if your schema can't be completely dumped by the schema dumper,
-  # like if you have constraints or database-specific column types
-  # config.active_record.schema_format = :sql
-end

data/test/dummy/config/locales/en.yml DELETED

@@ -1,14 +0,0 @@
----
-en:
-  # custom validation error messages
-  errors:
-    messages:
-      taken: has already been taken
-  activemodel:
-    errors:
-      models:
-        song:
-          attributes:
-            title:
-              custom_error_message: Custom Error Message
-              taken: has already been taken

data/test/dummy/config/routes.rb DELETED

@@ -1,4 +0,0 @@
-Dummy::Application.routes.draw do
-  get ':controller(/:action(/:id(.:format)))'
-  resources :albums
-end

data/test/dummy/db/test.sqlite3 DELETED

File without changes

data/test/form_builder_test.rb DELETED

@@ -1,138 +0,0 @@
-require 'test_helper'
-class FormBuilderCompatTest < BaseTest
-  class AlbumForm < Reform::Form
-    feature Reform::Form::ActiveModel::FormBuilderMethods
-    feature Reform::Form::MultiParameterAttributes
-    property :artist do
-      property :name
-      validates :name, :presence => true
-    end
-    collection :songs do
-      # feature Reform::Form::ActiveModel::FormBuilderMethods
-      property :title
-      property :release_date, :multi_params => true
-      validates :title, :presence => true
-    end
-    class LabelForm < Reform::Form
-      property :name
-    end
-    property :label, form: LabelForm
-    property :band do
-      property :label do
-        property :name
-        property :location do
-          property :postcode
-        end
-      end
-    end
-  end
-  let (:song) { OpenStruct.new }
-  let (:form) {
-    AlbumForm.new(OpenStruct.new(
-      :artist => Artist.new(:name => "Propagandhi"),
-      :songs  => [song],
-      :label  => Label.new,
-      :band => Band.new(OpenStruct.new(location: OpenStruct.new))
-    ))
-  }
-  it "respects _attributes params hash" do
-    form.validate(
-      "artist_attributes" => {"name" => "Blink 182"},
-      "songs_attributes"  => {"0" => {"title" => "Damnit"}},
-      "band_attributes"   => {"label_attributes" => {"name" => "Epitaph", "location_attributes" => {"postcode" => 2481}}})
-    form.artist.name.must_equal "Blink 182"
-    form.songs.first.title.must_equal "Damnit"
-    form.band.label.name.must_equal "Epitaph"
-    form.band.label.location.postcode.must_equal 2481
-  end
-  it "allows nested collection and property to be missing" do
-    form.validate({})
-    form.artist.name.must_equal "Propagandhi"
-    form.songs.size.must_equal 1
-    form.songs[0].model.must_equal song # this is a weird test.
-  end
-  it "defines _attributes= setter so Rails' FB works properly" do
-    form.must_respond_to("artist_attributes=")
-    form.must_respond_to("songs_attributes=")
-    form.must_respond_to("label_attributes=")
-  end
-  describe "deconstructed datetime parameters" do
-    let(:form_attributes) do
-      {
-        "artist_attributes" => {"name" => "Blink 182"},
-        "songs_attributes" => {"0" => {"title" => "Damnit", "release_date(1i)" => release_year,
-          "release_date(2i)" => release_month, "release_date(3i)" => release_day,
-          "release_date(4i)" => release_hour, "release_date(5i)" => release_minute}}
-      }
-    end
-    let(:release_year) { "1997" }
-    let(:release_month) { "9" }
-    let(:release_day) { "27" }
-    let(:release_hour) { nil }
-    let(:release_minute) { nil }
-    describe "with valid date parameters" do
-      it "creates a date" do
-        form.validate(form_attributes)
-        form.songs.first.release_date.must_equal Date.new(1997, 9, 27)
-      end
-    end
-    describe "with valid datetime parameters" do
-      let(:release_hour) { "10" }
-      let(:release_minute) { "11" }
-      it "creates a datetime" do
-        form.validate(form_attributes)
-        form.songs.first.release_date.must_equal Time.new(1997, 9, 27, 10, 11)
-      end
-    end
-    %w(year month day).each do |date_attr|
-      describe "when the #{date_attr} is missing" do
-        let(:"release_#{date_attr}") { "" }
-        it "rejects the date" do
-          form.validate(form_attributes)
-          form.songs.first.release_date.must_be_nil
-        end
-      end
-    end
-    # doesn't modify original params.
-    it do
-      original = form_attributes.inspect
-      form.validate(form_attributes)
-      form_attributes.inspect.must_equal original
-    end
-  end
-  it "returns flat errors hash" do
-    form.validate("artist_attributes" => {"name" => ""},
-      "songs_attributes" => {"0" => {"title" => ""}})
-    form.errors.messages.must_equal(:"artist.name" => ["can't be blank"], :"songs.title" => ["can't be blank"])
-  end
-end

data/test/lotus/Gemfile DELETED

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-gem "reform", path: "../../"
-gem "lotus-validations"
-gem "minitest"

data/test/lotus/lotus_test.rb DELETED

@@ -1,31 +0,0 @@
-require "reform"
-require "reform/form/lotus"
-require "minitest/autorun"
-Reform::Contract.class_eval do
-  include Reform::Contract::Validate
-  include Reform::Form::Lotus
-end
-class LotusTest < Minitest::Spec
-  Album = Struct.new(:title, :songs, :artist)
-  class AlbumForm < Reform::Form
-    property :title
-    validates :title, presence: true
-    property :songs do
-      property :name
-    end
-  end
-  it do
-    form = AlbumForm.new(Album.new("Show Completo"))
-    form.validate(title: "").must_equal false
-    form.errors.to_s.must_equal ""
-  end
-end

data/test/lotus_test.rb DELETED

@@ -1,150 +0,0 @@
-require "test_helper"
-require "reform/form/lotus"
-class LotusValidationsTest < MiniTest::Spec
-  class AlbumForm < Reform::Form
-    feature Lotus
-    property :title
-    property :hit do
-      property :title
-      validates :title, :presence => true
-    end
-    collection :songs do
-      property :title
-      validates :title, :presence => true
-    end
-    property :band do # yepp, people do crazy stuff like that.
-      property :name
-      property :label do
-        property :name
-        validates :name, :presence => true
-      end
-      # TODO: make band a required object.
-      validate :validate_musical_taste
-      def validate_musical_taste
-        errors.add(:base, "You are a bad person") if name == 'Nickelback'
-      end
-    end
-    validates :title, :presence => true
-  end
-  let (:album) do
-    OpenStruct.new(
-      :title  => "Blackhawks Over Los Angeles",
-      :hit    => song,
-      :songs  => songs, # TODO: document this requirement,
-      :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
-    )
-  end
-  let (:song)  { OpenStruct.new(:title => "Downtown") }
-  let (:songs) { [song=OpenStruct.new(:title => "Calling"), song] }
-  let (:form)  { AlbumForm.new(album) }
-  # correct #validate.
-  it do
-    result = form.validate(
-      "name"   => "Best Of",
-      "songs"  => [{"title" => "Fallout"}, {"title" => "Roxanne", "composer" => {"name" => "Sting"}}],
-      "artist" => {"name" => "The Police"},
-      "band"   => {"label" => {"name" => "Epitaph"}},
-    )
-    result.must_equal true
-    form.errors.inspect.must_equal "{}"
-  end
-  describe "incorrect #validate" do
-    it("xxx") do
-      result = form.validate(
-      "hit"   =>{"title" => ""},
-      "title" => "",
-      "songs" => [{"title" => ""}, {"title" => ""}])
-      result.must_equal false
-      form.errors.messages.inspect.must_match "title"
-      form.errors.messages.inspect.must_match "hit.title"
-      form.errors.messages.inspect.must_match "songs.title"
-      form.errors.messages.inspect.must_match "band.label.name"
-      form.hit.errors.messages.inspect.must_match "title"
-      form.songs[0].errors.messages.inspect.must_match "title"
-      # FIXME
-      # form.errors.messages.must_equal({
-      #   :title  => ["can't be blank"],
-      #   :"hit.title"=>["can't be blank"],
-      #   :"songs.title"=>["can't be blank"],
-      #   :"band.label.name"=>["can't be blank"]
-      # })
-      # # nested forms keep their own Errors:
-      # form.hit.errors.messages.must_equal({:title=>["can't be blank"]})
-      # form.songs[0].errors.messages.must_equal({:title=>["can't be blank"]})
-      # form.errors.messages.must_equal({
-      #   :title        => ["can't be blank"],
-      #   :"hit.title"  => ["can't be blank"],
-      #   :"songs.title"=> ["can't be blank"],
-      #   :"band.label.name"=>["can't be blank"]
-      # })
-    end
-  end
-  describe "#validate with collection form invalid" do
-    it do
-      result = form.validate("songs"=>[{"title" => ""}], "band"=>{"label"=>{:name => "Fat Wreck"}})
-      result.must_equal false
-      # FIXME
-      # form.errors.messages.must_equal({:"songs.title"=>["can't be blank"]})
-      form.errors.messages.inspect.must_match "songs.title"
-    end
-  end
-  describe "#validate with collection and 2-level-nested invalid" do
-    it do
-      result = form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}})
-      result.must_equal false
-      # FIXME
-      # form.errors.messages.must_equal({:"songs.title"=>["can't be blank"], :"band.label.name"=>["can't be blank"]})
-      form.errors.messages.inspect.must_match "songs.title"
-      form.errors.messages.inspect.must_match "band.label.name"
-    end
-  end
-  # TODO: implement.
-  # describe "#validate with nested form using :base invalid" do
-  #   before { @result = form.validate("songs"=>[{"title" => "Someday"}], "band" => {"name" => "Nickelback", "label" => {"name" => "Roadrunner Records"}}) }
-  #   it { @result.must_equal false }
-  #   it { form.errors.messages.must_equal({:base=>["You are a bad person"]}) }
-  # end
-  describe "correct #validate" do
-    before { @result = form.validate(
-      "hit"   => {"title" => "Sacrifice"},
-      "title" => "Second Heat",
-      "songs" => [{"title"=>"Heart Of A Lion"}],
-      "band"  => {"label"=>{:name => "Fat Wreck"}}
-      ) }
-    it { @result.must_equal true }
-    it { form.hit.title.must_equal "Sacrifice" }
-    it { form.title.must_equal "Second Heat" }
-    it { form.songs.first.title.must_equal "Heart Of A Lion" }
-  end
-end