reform 2.1.0 → 2.2.0.rc1

data/test/multi_parameter_attributes_test.rb

@@ -1,50 +0,0 @@
-require 'test_helper'
-
-class ReformTest < ReformSpec
-  describe "Date" do
-    Person = Struct.new(:date_of_birth)
-    let (:form) { DateOfBirthForm.new(Person.new) }
-
-    class DateOfBirthForm < Reform::Form
-      feature Reform::Form::ActiveModel::FormBuilderMethods
-      feature Reform::Form::MultiParameterAttributes
-      property :date_of_birth, type: Date, :multi_params => true
-    end
-
-    it "munges multi-param date fields into a valid Date attribute" do
-      date_of_birth_params = { "date_of_birth(1i)"=>"1950", "date_of_birth(2i)"=>"1", "date_of_birth(3i)"=>"1" }
-      form.validate(date_of_birth_params)
-      form.date_of_birth.must_equal Date.civil(1950, 1, 1)
-    end
-
-    it "handles invalid Time input" do
-      date_of_birth_params = { "date_of_birth(1i)"=>"1950", "date_of_birth(2i)"=>"99", "date_of_birth(3i)"=>"1" }
-      form.validate(date_of_birth_params)
-      form.date_of_birth.must_equal nil
-    end
-  end
-
-  describe "DateTime" do
-    Party = Struct.new(:start_time)
-    let (:form) { PartyForm.new(Party.new) }
-
-    class PartyForm < Reform::Form
-      feature Reform::Form::ActiveModel::FormBuilderMethods
-      feature Reform::Form::MultiParameterAttributes
-      property :start_time, type: DateTime, :multi_params => true
-    end
-
-    it "munges multi-param date and time fields into a valid Time attribute" do
-      start_time_params = { "start_time(1i)"=>"2000", "start_time(2i)"=>"1", "start_time(3i)"=>"1", "start_time(4i)"=>"12", "start_time(5i)"=>"00" }
-      time_format = "%Y-%m-%d %H:%M"
-      form.validate(start_time_params)
-      form.start_time.strftime(time_format).must_equal DateTime.strptime("2000-01-01 12:00", time_format)
-    end
-
-    it "handles invalid Time input" do
-      start_time_params = { "start_time(1i)"=>"2000", "start_time(2i)"=>"99", "start_time(3i)"=>"1", "start_time(4i)"=>"12", "start_time(5i)"=>"00" }
-      form.validate(start_time_params)
-      form.start_time.must_equal nil
-    end
-  end
-end

data/test/rails/integration_test.rb

@@ -1,54 +0,0 @@
-require_relative "../test_helper"
-
-require "dummy/config/environment"
-require "rails/test_help" # adds stuff like @routes, etc.
-
-# require "haml"
-# require "haml/template" # Thanks, Nathan!
-
-#ActiveRecord::Schema.define do
-  # create_table :artists do |table|
-  #   table.column :name, :string
-  #   table.timestamps
-  # end
-
-#   create_table :songs do |table|
-#     table.column :title, :string
-#     table.column :album_id, :integer
-#   end
-
-#   create_table :albums do |table|
-#     table.column :title, :string
-#   end
-# end
-
-class HasOneAndHasManyTest < ActionController::TestCase
-  tests AlbumsController
-
-  test "rendering 1-1 and 1-n" do
-    get :new
-    #puts @response.body
-
-    assert_select "form"
-
-    assert_select "form input" do |els|
-      assert_select "[name=?]", "album[title]"
-      assert_select "[name=?]", "album[songs_attributes][1][title]"
-      assert_select "[name=?]", "album[songs_attributes][0][title]"
-    end
-  end
-
-  test "submitting invalid form" do
-    params = {
-      "album"=>{"title"=>"Rio",
-        "songs_attributes"=>{
-          "0"=>{"name"=>""},
-          "1"=>{"name"=>""}
-      }}, "commit"=>"Create Album"}
-
-    post :create, params
-
-    assert_select "form"
-    assert_select "li", "Songs title can&#39;t be blank"
-  end
-end

data/test/unique_test.rb

@@ -1,135 +0,0 @@
-require "test_helper"
-
-require "reform/form/validation/unique_validator.rb"
-require "reform/form/active_record"
-
-class UniquenessValidatorOnCreateTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    include ActiveRecord
-    property :title
-    validates :title, unique: true
-  end
-
-  it do
-    Song.delete_all
-
-    form = SongForm.new(Song.new)
-    form.validate("title" => "How Many Tears").must_equal true
-    form.save
-
-    form = SongForm.new(Song.new)
-    form.validate("title" => "How Many Tears").must_equal false
-    form.errors.to_s.must_equal "{:title=>[\"has already been taken\"]}"
-  end
-end
-
-
-class UniquenessValidatorOnUpdateTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    include ActiveRecord
-    property :title
-    validates :title, unique: true
-  end
-
-  it do
-    Song.delete_all
-    @song = Song.create(title: "How Many Tears")
-
-    form = SongForm.new(@song)
-    form.validate("title" => "How Many Tears").must_equal true
-    form.save
-
-    form = SongForm.new(@song)
-    form.validate("title" => "How Many Tears").must_equal true
-  end
-end
-
-
-class UniqueWithCompositionTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    include ActiveRecord
-    include Composition
-
-    property :title, on: :song
-    validates :title, unique: true
-  end
-
-  it do
-    Song.delete_all
-
-    form = SongForm.new(song: Song.new)
-    form.validate("title" => "How Many Tears").must_equal true
-    form.save
-  end
-end
-
-
-class UniqueValidatorWithScopeTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    include ActiveRecord
-    property :album_id
-    property :title
-    validates :title, unique: { scope: :album_id }
-  end
-
-  it do
-    Song.delete_all
-
-    album = Album.new
-    album.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album.id, title: 'How Many Tears').must_equal true
-    form.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album.id, title: 'How Many Tears').must_equal false
-    form.errors.to_s.must_equal "{:title=>[\"has already been taken\"]}"
-
-    album = Album.new
-    album.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album.id, title: 'How Many Tears').must_equal true
-  end
-end
-
-class UniqueValidatorWithScopeArrayTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    include ActiveRecord
-    property :album_id
-    property :artist_id
-    property :title
-    validates :title, unique: { scope: [:album_id, :artist_id] }
-  end
-
-  it do
-    Song.delete_all
-
-    album1 = Album.new
-    album1.save
-
-    artist1 = Artist.new
-    artist1.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album1.id, artist_id: artist1.id, title: 'How Many Tears').must_equal true
-    form.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album1.id, artist_id: artist1.id, title: 'How Many Tears').must_equal false
-    form.errors.to_s.must_equal "{:title=>[\"has already been taken\"]}"
-
-    album2 = Album.new
-    album2.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album2.id, artist_id: artist1.id, title: 'How Many Tears').must_equal true
-
-    artist2 = Artist.new
-    artist2.save
-
-    form = SongForm.new(Song.new)
-    form.validate(album_id: album1.id, artist_id: artist2.id, title: 'How Many Tears').must_equal true
-  end
-end

data/test/validation/activemodel_validation_test.rb

@@ -1,252 +0,0 @@
-require "test_helper"
-require "reform/form/lotus"
-
-class ActiveModelValidationTest < MiniTest::Spec
-  Session = Struct.new(:username, :email, :password, :confirm_password)
-  Album = Struct.new(:name, :songs, :artist)
-  Artist = Struct.new(:name)
-
-  class SessionForm < Reform::Form
-    include Reform::Form::ActiveModel::Validations
-
-
-    property :username
-    property :email
-    property :password
-    property :confirm_password
-
-    validation :default do
-      validates :username, presence: true
-      validates :email, presence: true
-    end
-
-    validation :email, if: :default do
-      # validate :email_ok? # FIXME: implement that.
-      validates :email, length: {is: 3}
-    end
-
-    validation :nested, if: :default do
-      validates :password, presence: true, length: {is: 1}
-    end
-
-    validation :confirm, if: :default, after: :email do
-      validates :confirm_password, length: {is: 2}
-    end
-  end
-
-  let (:form) { SessionForm.new(Session.new) }
-
-  # valid.
-  it do
-    form.validate({username: "Helloween", email: "yep", password: "9", confirm_password:"dd"}).must_equal true
-    form.errors.messages.inspect.must_equal "{}"
-  end
-
-  # invalid.
-  it do
-    form.validate({}).must_equal false
-    form.errors.messages.inspect.must_equal "{:username=>[\"can't be blank\"], :email=>[\"can't be blank\"]}"
-  end
-
-  # partially invalid.
-  # 2nd group fails.
-  let (:character) { self.class.rails4_2? ? :character : :characters}
-  it do
-    form.validate(username: "Helloween", email: "yo").must_equal false
-    form.errors.messages.inspect.must_equal "{:email=>[\"is the wrong length (should be 3 characters)\"], :confirm_password=>[\"is the wrong length (should be 2 characters)\"], :password=>[\"can't be blank\", \"is the wrong length (should be 1 #{character})\"]}"
-  end
-  # 3rd group fails.
-  it do
-    form.validate(username: "Helloween", email: "yo!").must_equal false
-    form.errors.messages.inspect.must_equal"{:confirm_password=>[\"is the wrong length (should be 2 characters)\"], :password=>[\"can't be blank\", \"is the wrong length (should be 1 #{character})\"]}"
-  end
-  # 4th group with after: fails.
-  it do
-    form.validate(username: "Helloween", email: "yo!", password: "1", confirm_password: "9").must_equal false
-    form.errors.messages.inspect.must_equal "{:confirm_password=>[\"is the wrong length (should be 2 characters)\"]}"
-  end
-
-
-  describe "implicit :default group" do
-    # implicit :default group.
-    class LoginForm < Reform::Form
-      include Reform::Form::ActiveModel::Validations
-
-
-      property :username
-      property :email
-      property :password
-      property :confirm_password
-
-      validates :username, presence: true
-      validates :email, presence: true
-      validates :password, presence: true
-
-      validation :after_default, if: :default do
-        validates :confirm_password, presence: true
-      end
-    end
-
-    let (:form) { LoginForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Helloween", email: "yep", password: "9", confirm_password: 9}).must_equal true
-      form.errors.messages.inspect.must_equal "{}"
-    end
-
-    # invalid.
-    it do
-      form.validate({password: 9}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"can't be blank\"], :email=>[\"can't be blank\"]}"
-    end
-
-    # partially invalid.
-    # 2nd group fails.
-    it do
-      form.validate(password: 9).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"can't be blank\"], :email=>[\"can't be blank\"]}"
-    end
-  end
-
-
-  # describe "overwriting a group" do
-  #   class OverwritingForm < Reform::Form
-  #     include Reform::Form::ActiveModel::Validations
-
-  #     property :username
-  #     property :email
-
-  #     validation :email do
-  #       validates :email, presence: true # is not considered, but overwritten.
-  #     end
-
-  #     validation :email do # overwrites the above.
-  #       validates :username, presence: true
-  #     end
-  #   end
-
-  #   let (:form) { OverwritingForm.new(Session.new) }
-
-  #   # valid.
-  #   it do
-  #     form.validate({username: "Helloween"}).must_equal true
-  #   end
-
-  #   # invalid.
-  #   it do
-  #     form.validate({}).must_equal false
-  #     form.errors.messages.inspect.must_equal "{:username=>[\"username can't be blank\"]}"
-  #   end
-  # end
-
-
-  describe "inherit: true in same group" do
-    class InheritSameGroupForm < Reform::Form
-      include Reform::Form::ActiveModel::Validations
-
-      property :username
-      property :email
-
-      validation :email do
-        validates :email, presence: true
-      end
-
-      validation :email, inherit: true do # extends the above.
-        validates :username, presence: true
-      end
-    end
-
-    let (:form) { InheritSameGroupForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Helloween", email: 9}).must_equal true
-    end
-
-    # invalid.
-    it do
-      form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"can't be blank\"], :username=>[\"can't be blank\"]}"
-    end
-  end
-
-
-  describe "if: with lambda" do
-    class IfWithLambdaForm < Reform::Form
-      include Reform::Form::ActiveModel::Validations
-
-      property :username
-      property :email
-      property :password
-
-      validation :email do
-        validates :email, presence: true
-      end
-
-      # run this is :email group is true.
-      validation :after_email, if: lambda { |results| results[:email]==true } do # extends the above.
-        validates :username, presence: true
-      end
-
-      # block gets evaled in form instance context.
-      validation :password, if: lambda { |results| email == "john@trb.org" } do
-        validates :password, presence: true
-      end
-    end
-
-    let (:form) { IfWithLambdaForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Strung Out", email: 9}).must_equal true
-    end
-
-    # invalid.
-    it do
-      form.validate({email: 9}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"can't be blank\"]}"
-    end
-  end
-
-
-# TODO: describe "multiple errors for property" do
-
-  describe "::validate" do
-    class ValidateForm < Reform::Form
-      include Reform::Form::ActiveModel::Validations
-
-      property :username
-      validates :username, presence: true
-      validate :username_ok?#, context: :entity
-
-      def username_ok?#(value)
-        errors.add(:username, "not ok") if username == "yo"
-      end
-    end
-
-    let (:form) { ValidateForm.new(Session.new) }
-
-    # invalid.
-    it do
-      form.validate({username: "yo"}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"not ok\"]}"
-    end
-
-    # valid.
-    it do
-      form.validate({username: "not yo"}).must_equal true
-      form.errors.empty?.must_equal true
-    end
-  end
-
-
-  describe "validates: :acceptance" do
-    class AcceptanceForm < Reform::Form
-      property :accept, virtual: true, validates: { acceptance: true }
-    end
-
-    it { AcceptanceForm.new(nil).validate(accept: "0").must_equal false }
-    it { AcceptanceForm.new(nil).validate(accept: "1").must_equal true }
-  end
-end