reform 2.1.0 → 2.2.0.rc1

data/test/active_model_validation_for_property_named_format_test.rb

@@ -1,18 +0,0 @@
-require "test_helper"
-
-class AMValidationWithFormatTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    property :format
-    validates :format, presence: true
-  end
-
-  class Song
-    def format
-      1
-    end
-  end
-
-  it do
-    SongForm.new(Song.new).validate({}).must_equal true
-  end
-end

data/test/active_record_test.rb

@@ -1,273 +0,0 @@
-require 'test_helper'
-require 'reform/active_record'
-
-# ActiveRecord::Schema.define do
-#   create_table :artists do |table|
-#     table.column :name, :string
-#     table.timestamps
-#   end
-#   create_table :songs do |table|
-#     table.column :title, :string
-#     table.column :artist_id, :integer
-#     table.column :album_id, :integer
-#     table.timestamps
-#   end
-#   create_table :albums do |table|
-#     table.column :title, :string
-#     table.timestamps
-#   end
-# end
-# Artist.new(:name => "Racer X").save
-
-class ActiveRecordTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    feature Reform::Form::ActiveModel::Validations
-
-    include Reform::Form::ActiveRecord
-    model :song
-
-    property :title
-    property :created_at
-
-    validates_uniqueness_of :title, scope: [:album_id, :artist_id]
-    validates :created_at, :presence => true # have another property to test if we mix up.
-
-    property :artist do
-      property :name
-      validates_uniqueness_of :name # this currently also tests if Form::AR is included as a feature.
-    end
-  end
-
-  let(:album)   { Album.create(:title => "Damnation") }
-  let(:artist)  { Artist.create(:name => "Opeth") }
-  let(:form)    { SongForm.new(Song.new(:artist => Artist.new)) }
-
-  it { form.class.i18n_scope.must_equal :activerecord }
-
-  # uniqueness
-  it "has no errors on title when title is unique for the same artist and album" do
-    form.validate("title" => "The Gargoyle", "artist_id" => artist.id, "album" => album.id, "created_at" => "November 6, 1966")
-    assert_empty form.errors[:title]
-  end
-
-  it "has errors on title when title is taken for the same artist and album" do
-    skip "replace ActiveModel::Validations with our own, working and reusable gem."
-    Song.create(title: "Windowpane", artist_id: artist.id, album_id: album.id)
-    form.validate("title" => "Windowpane", "artist_id" => artist.id, "album" => album)
-    refute_empty form.errors[:title]
-  end
-
-  # nested object taken.
-  it "is valid when artist name is unique" do
-    form.validate("artist" => {"name" => "Paul Gilbert"}, "title" => "The Gargoyle", "created_at" => "November 6, 1966").must_equal true
-  end
-
-  it "is invalid and shows error when taken" do
-    Song.delete_all
-    Artist.create(:name => "Racer X")
-
-    form.validate("artist" => {"name" => "Racer X"}, "title" => "Ghost Inside My Skin").must_equal false
-    form.errors.messages.must_equal({:"artist.name"=>["has already been taken"], :created_at => ["can't be blank"]})
-  end
-
-  it "works with Composition" do
-    form = Class.new(Reform::Form) do
-      include Reform::Form::ActiveRecord
-      include Reform::Form::Composition
-
-      property :name, :on => :artist
-      validates_uniqueness_of :name
-    end.new(:artist => Artist.new)
-
-    Artist.create(:name => "Bad Religion")
-    form.validate("name" => "Bad Religion").must_equal false
-  end
-
-  describe "#save" do
-    # TODO: test 1-n?
-    it "calls model.save" do
-      Artist.delete_all
-      form.validate("artist" => {"name" => "Bad Religion"}, "title" => "Ghost Inside My Skin")
-      form.save
-      Artist.where(:name => "Bad Religion").size.must_equal 1
-    end
-
-    it "doesn't call model.save when block is given" do
-      Artist.delete_all
-      form.validate("name" => "Bad Religion")
-      form.save {}
-      Artist.where(:name => "Bad Religion").size.must_equal 0
-    end
-
-    it "can access block params using string or hash key" do
-      Artist.delete_all
-      form.validate("artist" => {"name" => "Paul Gilbert"}, "title" => "The Gargoyle", "created_at" => "November 6, 1966")
-      form.save do |params|
-        params[:title].must_equal 'The Gargoyle'
-        params['title'].must_equal 'The Gargoyle'
-      end
-    end
-  end
-end
-
-
-class PopulateWithActiveRecordTest < MiniTest::Spec
-  class AlbumForm < Reform::Form
-
-    property :title
-
-    collection :songs, :populate_if_empty => Song do
-      property :title
-    end
-  end
-
-  let (:album) { Album.new(:songs => []) }
-  it do
-    form = AlbumForm.new(album)
-
-    form.validate("songs" => [{"title" => "Straight From The Jacket"}])
-
-    # form populated.
-    form.songs.size.must_equal 1
-    form.songs[0].model.must_be_kind_of Song
-
-    # model NOT populated.
-    album.songs.must_equal []
-
-
-    form.sync
-
-    # form populated.
-    form.songs.size.must_equal 1
-    form.songs[0].model.must_be_kind_of Song
-
-    # model also populated.
-    song = album.songs[0]
-    album.songs.must_equal [song]
-    song.title.must_equal "Straight From The Jacket"
-
-
-    if ActiveRecord::VERSION::STRING !~ /^3.0/
-      # saving saves association.
-      form.save
-
-      album.reload
-      song = album.songs[0]
-      album.songs.must_equal [song]
-      song.title.must_equal "Straight From The Jacket"
-    end
-  end
-
-
-  describe "modifying 1., adding 2." do
-    let (:song) { Song.new(:title => "Part 2") }
-    let (:album) { Album.create.tap { |a| a.songs << song } }
-
-    it do
-      form = AlbumForm.new(album)
-
-      id = album.songs[0].id
-      assert id > 0
-
-      form.validate("songs" => [{"title" => "Part Two"}, {"title" => "Check For A Pulse"}])
-
-      # form populated.
-      form.songs.size.must_equal 2
-      form.songs[0].model.must_be_kind_of Song
-      form.songs[1].model.must_be_kind_of Song
-
-      # model NOT populated.
-      album.songs.must_equal [song]
-
-
-      form.sync
-
-      # form populated.
-      form.songs.size.must_equal 2
-
-      # model also populated.
-      album.songs.size.must_equal 2
-
-      # corrected title
-      album.songs[0].title.must_equal "Part Two"
-      # ..but same song.
-      album.songs[0].id.must_equal id
-
-      # and a new song.
-      album.songs[1].title.must_equal "Check For A Pulse"
-      album.songs[1].persisted?.must_equal true # TODO: with << strategy, this shouldn't be saved.
-    end
-
-    describe 'using nested_models_attributes to modify nested collection' do
-      class ActiveModelAlbumForm < Reform::Form
-        include Reform::Form::ActiveModel
-        include Reform::Form::ActiveModel::FormBuilderMethods
-
-        property :title
-
-        collection :songs, :populate_if_empty => Song do
-          property :title
-        end
-      end
-
-      let (:album) { Album.create(:title => 'Greatest Hits') }
-      let (:form) { ActiveModelAlbumForm.new(album) }
-
-      it "xxx"do
-        form.validate('songs_attributes' => {'0' => {'title' => 'Tango'}})
-
-        # form populated.
-        form.songs.size.must_equal 1
-        form.songs[0].model.must_be_kind_of Song
-        form.songs[0].title.must_equal 'Tango'
-
-        # model NOT populated.
-        album.songs.must_equal []
-
-        form.save
-
-        # nested model persisted.
-        first_song = album.songs[0]
-        assert first_song.id > 0
-
-        # form populated.
-        form.songs.size.must_equal 1
-
-        # model also populated.
-        album.songs.size.must_equal 1
-        album.songs[0].title.must_equal 'Tango'
-
-        # DISCUSS: IfEmpty uses twin.original[index] for syncing. in our case, this is empty, so it will add Tango again.
-        form = ActiveModelAlbumForm.new(album)
-        form.validate('songs_attributes' => {'0' => {'id' => first_song.id, 'title' => 'Tango nuevo'}, '1' => {'title' => 'Waltz'}})
-
-        # form populated.
-        form.songs.size.must_equal 2
-        form.songs[0].model.must_be_kind_of Song
-        form.songs[1].model.must_be_kind_of Song
-        form.songs[0].title.must_equal 'Tango nuevo'
-        form.songs[1].title.must_equal 'Waltz'
-
-        # model NOT populated.
-        album.songs.size.must_equal 1
-        album.songs[0].title.must_equal 'Tango'
-
-        form.save
-
-        # form populated.
-        form.songs.size.must_equal 2
-
-        # model also populated.
-        album.songs.size.must_equal 2
-        album.songs[0].id.must_equal first_song.id
-        album.songs[0].persisted?.must_equal true
-        album.songs[1].persisted?.must_equal true
-        album.songs[0].title.must_equal 'Tango nuevo'
-        album.songs[1].title.must_equal 'Waltz'
-      end
-    end
-  end
-end
-
-
-

data/test/builder_test.rb

@@ -1,32 +0,0 @@
-# require 'test_helper'
-
-# class BuilderTest < MiniTest::Spec
-#   it do
-#     Builder.new.checkboxes(:settings, :hash => {"play" => true, "released" => false}).must_equal %{<input name="yo" type="hidden" value="unchecked_value" /><input id="object_name_method" name="yo" type="checkbox" value="checked_value" />
-# <input name="yo" type="hidden" value="unchecked_value" /><input id="object_name_method" name="yo" type="checkbox" value="checked_value" />}
-#   end
-# end
-
-
-# require 'action_view/helpers/capture_helper'
-# require 'action_view/helpers/tag_helper'
-# require 'action_view/helpers/url_helper'
-# require 'action_view/helpers/sanitize_helper'
-# require 'action_view/helpers/text_helper'
-# require 'action_view/helpers/form_tag_helper'
-# require 'action_view/helpers/form_helper'
-
-# class Builder
-#   include ActionView::Helpers::CaptureHelper
-#   include ActionView::Helpers::FormHelper
-
-#   # {name: value}
-#   def checkboxes(name, options)
-#     # get property form.to_a ? to_builder_hash or something like that
-#     options[:hash].collect do |id, value|
-#       ActionView::Helpers::InstanceTag.new(:object_name, :method, self).to_check_box_tag({:name => "yo"}, :checked_value, :unchecked_value)
-
-#       # check_box_tag(id, value, checked = false, {})
-#     end.join("\n")
-#   end
-# end

data/test/custom_validation_test.rb

@@ -1,47 +0,0 @@
-require 'test_helper'
-
-unless ActiveModel::VERSION::MAJOR == 3 and ActiveModel::VERSION::MINOR == 0
-
-  class UnexistantTitleValidator < ActiveModel::Validator
-    def validate record
-      if record.title == 'unexistant_song'
-        record.errors.add(:title, 'this title does not exist!')
-      end
-    end
-  end
-
-  class CustomValidationTest < MiniTest::Spec
-
-    class Album
-      include ActiveModel::Validations
-      attr_accessor :title, :artist
-
-      validates_with UnexistantTitleValidator
-    end
-
-    class AlbumForm < Reform::Form
-      extend ActiveModel::ModelValidations
-
-      property :title
-      property :artist_name, from: :artist
-      copy_validations_from Album
-    end
-
-    let(:album) { Album.new }
-
-    describe 'non-composite form' do
-
-      let(:album_form) { AlbumForm.new(album) }
-
-      it 'is not valid when title is unexistant_song' do
-        album_form.validate(artist_name: 'test', title: 'unexistant_song').must_equal false
-      end
-
-      it 'is valid when title is something existant' do
-        album_form.validate(artist_name: 'test', title: 'test').must_equal true
-      end
-
-    end
-
-  end
-end

data/test/dummy/Rakefile

@@ -1,7 +0,0 @@
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
-
-require File.expand_path('../config/application', __FILE__)
-require 'rake'
-
-Rails::Application.load_tasks

data/test/dummy/app/controllers/albums_controller.rb

@@ -1,18 +0,0 @@
-class AlbumsController < ActionController::Base
-  def new
-    album = Album.new(:songs => [Song.new, Song.new])
-    @form = AlbumForm.new(album)
-  end
-
-  def create
-    album = Album.new(songs: [Song.new, Song.new])
-    @form = AlbumForm.new(album)
-
-    if @form.validate(params["album"])
-      @form.save
-      redirect_to album_path(album)
-    else
-      render :new
-    end
-  end
-end

data/test/dummy/app/controllers/application_controller.rb

@@ -1,4 +0,0 @@
-class ApplicationController < ActionController::Base
-  protect_from_forgery
-  layout 'application'
-end

data/test/dummy/app/controllers/musician_controller.rb

@@ -1,5 +0,0 @@
-class MusicianController < ActionController::Base
-  def index
-    render :text => Artist.find(:all)
-  end
-end

data/test/dummy/app/forms/album_form.rb

@@ -1,18 +0,0 @@
-class AlbumForm < Reform::Form # FIXME: sub forms don't inherit FBM.
-
-  model :album
-
-  property :title
-
-  collection :songs do
-    property :title
-    validates :title, presence: true
-  end
-
-  validates :title, presence: true
-
-  def save
-    super
-    model.save
-  end
-end

data/test/dummy/app/helpers/application_helper.rb

@@ -1,2 +0,0 @@
-module ApplicationHelper
-end

data/test/dummy/app/models/album.rb

@@ -1,4 +0,0 @@
-class Album < ActiveRecord::Base
-  has_many :songs
-  has_and_belongs_to_many :artists
-end

data/test/dummy/app/models/song.rb

@@ -1,3 +0,0 @@
-class Song < ActiveRecord::Base
-  belongs_to :album
-end