reek 6.0.3 → 6.0.4

data/spec/reek/smell_detectors/nil_check_spec.rb

@@ -1,100 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/nil_check'
-
-RSpec.describe Reek::SmellDetectors::NilCheck do
-  it 'reports the right values' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo.nil?
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck,
-                           lines:   [2],
-                           context: 'alfa',
-                           message: 'performs a nil-check',
-                           source:  'string')
-  end
-
-  it 'does count all occurences' do
-    src = <<-RUBY
-      def alfa(bravo, charlie)
-        bravo.nil?
-        charlie.nil?
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck,
-                           lines:   [2, 3],
-                           context: 'alfa')
-  end
-
-  it 'reports nothing when scope includes no nil checks' do
-    src = 'def alfa; end'
-    expect(src).not_to reek_of(:NilCheck)
-  end
-
-  it 'reports when scope uses == nil' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo == nil
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck)
-  end
-
-  it 'reports when scope uses === nil' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo === nil
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck)
-  end
-
-  it 'reports when scope uses nil ==' do
-    src = <<-RUBY
-      def alfa(bravo)
-        nil == bravo
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck)
-  end
-
-  it 'reports when scope uses a case-clause checking nil' do
-    src = <<-RUBY
-      def alfa(bravo)
-        case bravo
-        when nil then puts "Nil"
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck)
-  end
-
-  it 'does not report when scope uses &.' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo&.charlie
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NilCheck)
-  end
-
-  it 'reports all lines when scope uses multiple nilchecks' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo.nil?
-        @charlie === nil
-        delta&.echo
-      end
-    RUBY
-
-    expect(src).to reek_of(:NilCheck, lines: [2, 3])
-  end
-end

data/spec/reek/smell_detectors/repeated_conditional_spec.rb

@@ -1,100 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/repeated_conditional'
-
-RSpec.describe Reek::SmellDetectors::RepeatedConditional do
-  it 'reports the right values' do
-    src = <<-RUBY
-      class Alfa
-        attr_accessor :bravo
-
-        def charlie
-          puts "Repeat 1!" if bravo
-        end
-
-        def delta
-          puts "Repeat 2!" if bravo
-        end
-
-        def echo
-          puts "Repeat 3!" if bravo
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:RepeatedConditional,
-                           lines:   [5, 9, 13],
-                           context: 'Alfa',
-                           message: "tests 'bravo' at least 3 times",
-                           source:  'string',
-                           name:    'bravo',
-                           count:   3)
-  end
-
-  it 'does count all occurences' do
-    src = <<-RUBY
-      class Alfa
-        attr_accessor :bravo
-
-        def charlie
-          puts "Repeat 1!" if bravo
-          puts "And again!" if bravo
-        end
-
-        def delta
-          puts "Repeat 2!" if bravo
-        end
-
-        def echo
-          puts "Repeat 3!" if bravo
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:RepeatedConditional,
-                           lines: [5, 6, 10, 14],
-                           count: 4)
-  end
-
-  it 'does not report two repeated conditionals' do
-    src = <<-RUBY
-      class Alfa
-        attr_accessor :bravo
-
-        def charlie
-          puts "Repeat 1!" if bravo
-        end
-
-        def delta
-          puts "Repeat 2!" if bravo
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:RepeatedConditional)
-  end
-
-  it 'reports repeated conditionals regardless of `if` or `case` statements' do
-    src = <<-RUBY
-      class Alfa
-        attr_accessor :bravo
-
-        def charlie
-          puts "Repeat 1!" if bravo
-        end
-
-        def delta
-          case bravo
-          when 1 then puts "Repeat 2!"
-          else 'nothing'
-          end
-        end
-
-        def echo
-          puts "Repeat 3!" if bravo
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:RepeatedConditional)
-  end
-end

data/spec/reek/smell_detectors/subclassed_from_core_class_spec.rb

@@ -1,77 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/subclassed_from_core_class'
-
-RSpec.describe Reek::SmellDetectors::SubclassedFromCoreClass do
-  it 'reports the right values' do
-    src = <<-RUBY
-      class Alfa < Hash
-      end
-    RUBY
-
-    expect(src).to reek_of(:SubclassedFromCoreClass,
-                           lines:    [1],
-                           context:  'Alfa',
-                           message:  "inherits from core class 'Hash'",
-                           source:   'string',
-                           ancestor: 'Hash')
-  end
-
-  it 'reports when inheriting from a core class inside a module' do
-    src = <<-RUBY
-      module Alfa
-        class Bravo < Hash
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:SubclassedFromCoreClass, context: 'Alfa::Bravo')
-  end
-
-  it 'does not report when not inheriting from a core class' do
-    src = <<-RUBY
-      class Alfa
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:SubclassedFromCoreClass)
-  end
-
-  it 'does not report on coincidental core class names in other namespaces' do
-    src = <<-RUBY
-      class Alfa < Bravo::Array
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:SubclassedFromCoreClass)
-  end
-
-  it 'reports if inner class inherit from a core class' do
-    src = <<-RUBY
-      class Alfa
-        Bravo = Class.new(Array)
-      end
-    RUBY
-
-    expect(src).to reek_of(:SubclassedFromCoreClass, context: 'Alfa::Bravo')
-  end
-
-  it 'reports class which inherits from core class via Class.new' do
-    src = 'Alfa = Class.new(Array)'
-    expect(src).to reek_of(:SubclassedFromCoreClass)
-  end
-
-  it 'does not report class which inherits from allowed class via Class.new' do
-    src = 'Alfa = Class.new(StandardError)'
-    expect(src).not_to reek_of(:SubclassedFromCoreClass)
-  end
-
-  it 'does not report classes created with Struct.new' do
-    src = "Alfa = Struct.new('Array')"
-    expect(src).not_to reek_of(:SubclassedFromCoreClass)
-  end
-
-  it 'does not report class created by another class constructor taking a core class as argument' do
-    src = 'Charlie = Delta.new(Array)'
-    expect(src).not_to reek_of(:SubclassedFromCoreClass)
-  end
-end

data/spec/reek/smell_detectors/too_many_constants_spec.rb

@@ -1,144 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/too_many_constants'
-
-RSpec.describe Reek::SmellDetectors::TooManyConstants do
-  let(:config) do
-    { Reek::SmellDetectors::TooManyConstants::MAX_ALLOWED_CONSTANTS_KEY => 2 }
-  end
-
-  it 'reports the right values' do
-    src = <<-RUBY
-      class Alfa
-        Bravo = Charlie = Delta = 1
-      end
-    RUBY
-
-    expect(src).to reek_of(:TooManyConstants,
-                           lines:   [1],
-                           context: 'Alfa',
-                           message: 'has 3 constants',
-                           source:  'string',
-                           count:   3).with_config(config)
-  end
-
-  it 'does not report for non-excessive constants' do
-    src = <<-RUBY
-      class Alfa
-        Bravo = Charlie = 1
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'does not report when increasing default' do
-    src = <<-RUBY
-      # :reek:TooManyConstants { max_constants: 3 }
-      class Alfa
-        Bravo = Charlie = Delta = 1
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'does not report when disabled' do
-    src = <<-RUBY
-      # :reek:TooManyConstants { enabled: false }
-      class Alfa
-        Bravo = Charlie = Delta = 1
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'does not account class definition' do
-    src = <<-RUBY
-      class Alfa
-        Bravo = Charlie = 1
-        Delta = Class.new(StandardError)
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'does not account struct definition' do
-    src = <<-RUBY
-      class Alfa
-        Bravo = Charlie = 1
-        Delta = Struct.new
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'counts each constant only once' do
-    src = <<-RUBY
-      class Alfa
-        Bravo = Charlie = 1
-      end
-
-      class Delta
-        Echo = Foxtrot = 1
-      end
-
-      class Golf
-        Hotel = India = 1
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'does not report outer module when inner module suppressed' do
-    src = <<-RUBY
-      module Alfa
-        # ignore :reek:TooManyConstants
-        module Bravo
-          Charlie = Delta = Echo = 1
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'counts each constant only once for each namespace' do
-    src = <<-RUBY
-      module Alfa
-        Bravo = Charlie = 1
-
-        class Delta
-          Echo = 1
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyConstants).with_config(config)
-  end
-
-  it 'reports for excessive constants inside a module' do
-    src = <<-RUBY
-      module Alfa
-        Bravo = Charlie = Delta = 1
-      end
-    RUBY
-
-    expect(src).to reek_of(:TooManyConstants, context: 'Alfa').with_config(config)
-  end
-
-  it 'reports the full class name' do
-    src = <<-RUBY
-      module Alfa
-        class Bravo
-          Charlie = Delta = Echo = 1
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:TooManyConstants, context: 'Alfa::Bravo').with_config(config)
-  end
-end

data/spec/reek/smell_detectors/too_many_instance_variables_spec.rb

@@ -1,132 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/too_many_instance_variables'
-
-RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
-  let(:config) do
-    { Reek::SmellDetectors::TooManyInstanceVariables::MAX_ALLOWED_IVARS_KEY => 2 }
-  end
-
-  it 'reports the right values' do
-    src = <<-RUBY
-      class Alfa
-        def bravo
-          @charlie = @delta = @echo = 1
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:TooManyInstanceVariables,
-                           lines:   [1],
-                           context: 'Alfa',
-                           message: 'has at least 3 instance variables',
-                           source:  'string',
-                           count:   3).with_config(config)
-  end
-
-  it 'does not report for non-excessive ivars' do
-    src = <<-RUBY
-      class Alfa
-        def bravo
-          @charlie = @delta = 1
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-
-  it 'has a configurable maximum' do
-    src = <<-RUBY
-      # :reek:TooManyInstanceVariables { max_instance_variables: 3 }
-      class Alfa
-        def bravo
-          @charlie = @delta = @echo = 1
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-
-  it 'counts each ivar only once' do
-    src = <<-RUBY
-      class Alfa
-        def bravo
-          @charlie = @delta = 1
-          @charlie = @delta = 1
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-
-  it 'does not report memoized bravo' do
-    src = <<-RUBY
-      class Alfa
-        def bravo
-          @charlie = @delta = 1
-          @echo ||= 1
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-
-  it 'does not count ivars across inner classes' do
-    src = <<-RUBY
-      class Alfa
-        class Bravo
-          def charlie
-            @delta = @echo = 1
-          end
-        end
-
-        class Hotel
-          def india
-            @juliett = 1
-          end
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-
-  it 'does not count ivars across inner modules and classes' do
-    src = <<-RUBY
-      class Alfa
-        class Bravo
-          def charlie
-            @delta = @echo = 1
-          end
-        end
-
-        module Foxtrot
-          def golf
-            @hotel = 1
-          end
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-
-  it 'reports excessive ivars across different methods' do
-    src = <<-RUBY
-      class Alfa
-        def bravo
-          @charlie = @delta = 1
-        end
-
-        def golf
-          @hotel = 1
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:TooManyInstanceVariables).with_config(config)
-  end
-end