reek 6.0.3 → 6.0.4

data/spec/reek/context/method_context_spec.rb

@@ -1,72 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/context/method_context'
-
-RSpec.describe Reek::Context::MethodContext do
-  let(:method_context) { described_class.new(exp, nil) }
-
-  describe '#matches?' do
-    let(:exp) { instance_double('Reek::AST::SexpExtensions::ModuleNode').as_null_object }
-
-    before do
-      allow(exp).to receive(:full_name).at_least(:once).and_return('mod')
-    end
-
-    it 'recognises itself in a collection of names' do
-      expect(method_context.matches?(['banana', 'mod'])).to eq(true)
-    end
-
-    it 'does not recognise itself in a collection of names that does not include it' do
-      expect(method_context.matches?(['banana'])).to eq(false)
-    end
-
-    it 'recognises itself in a collection of regular expressions' do
-      expect(method_context.matches?([/banana/, /mod/])).to eq(true)
-    end
-
-    it 'does not recognise itself in a collection of regular expressions that do not match it' do
-      expect(method_context.matches?([/banana/])).to eq(false)
-    end
-  end
-
-  describe '#default_assignments' do
-    def assignments_from(src)
-      exp = Reek::Source::SourceCode.from(src).syntax_tree
-      ctx = Reek::Context::MethodContext.new(exp, nil)
-      ctx.default_assignments
-    end
-
-    context 'with no defaults' do
-      it 'returns an empty hash' do
-        src = 'def meth(arga, argb, &blk) end'
-        expect(assignments_from(src)).to be_empty
-      end
-    end
-
-    context 'with 1 default' do
-      let(:defaults) { assignments_from('def meth(arga, argb=456, &blk) end') }
-
-      it 'returns the param-value pair' do
-        expect(defaults[0]).to eq [:argb, sexp(:int, 456)]
-      end
-
-      it 'returns the nothing else' do
-        expect(defaults.length).to eq(1)
-      end
-    end
-
-    context 'with 2 defaults' do
-      let(:defaults) do
-        assignments_from('def meth(arga=123, argb=456, &blk) end')
-      end
-
-      it 'returns both param-value pairs' do
-        expect(defaults).to eq [[:arga, sexp(:int, 123)],
-                                [:argb, sexp(:int, 456)]]
-      end
-
-      it 'returns nothing else' do
-        expect(defaults.length).to eq(2)
-      end
-    end
-  end
-end

data/spec/reek/context/module_context_spec.rb

@@ -1,55 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/context/module_context'
-require_lib 'reek/context/root_context'
-
-RSpec.describe Reek::Context::ModuleContext do
-  it 'reports module name for smell in method' do
-    expect('
-      module Fred
-        def simple(x) x + 1; end
-      end
-    ').to reek_of(:UncommunicativeParameterName, name: 'x', context: 'Fred#simple')
-  end
-
-  it 'does not report module with empty class' do
-    expect('
-      # module for test
-      module Fred
-        # module for test
-        class Jim; end; end').not_to reek
-  end
-
-  it 'recognises global constant' do
-    expect('
-      # module for test
-      module ::Global
-        # module for test
-        class Inside; end; end').not_to reek
-  end
-
-  describe '#track_visibility' do
-    let(:main_exp) { instance_double('Reek::AST::Node') }
-    let(:first_def) { instance_double('Reek::AST::SexpExtensions::DefNode', name: :foo) }
-    let(:second_def) { instance_double('Reek::AST::SexpExtensions::DefNode') }
-
-    let(:context) { described_class.new(main_exp) }
-    let(:first_child) { Reek::Context::MethodContext.new(first_def, main_exp) }
-    let(:second_child) { Reek::Context::MethodContext.new(second_def, main_exp) }
-
-    it 'sets visibility on subsequent child contexts' do
-      context.append_child_context first_child
-      context.track_visibility :private, []
-      context.append_child_context second_child
-      expect(first_child.visibility).to eq :public
-      expect(second_child.visibility).to eq :private
-    end
-
-    it 'sets visibility on specifically mentioned child contexts' do
-      context.append_child_context first_child
-      context.track_visibility :private, [first_child.name]
-      context.append_child_context second_child
-      expect(first_child.visibility).to eq :private
-      expect(second_child.visibility).to eq :public
-    end
-  end
-end

data/spec/reek/context/root_context_spec.rb

@@ -1,12 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/context/root_context'
-
-RSpec.describe Reek::Context::RootContext do
-  describe '#full_name' do
-    it 'reports full context' do
-      ast = Reek::Source::SourceCode.from('foo = 1').syntax_tree
-      root = described_class.new(ast)
-      expect(root.full_name).to eq('')
-    end
-  end
-end

data/spec/reek/context/statement_counter_spec.rb

@@ -1,24 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/context/statement_counter'
-
-RSpec.describe Reek::Context::StatementCounter do
-  let(:counter) { described_class.new }
-
-  describe '#increase_by' do
-    it 'does not increase if passed a falsy value' do
-      counter.increase_by(nil)
-      expect(counter.value).to eq 0
-    end
-
-    it 'increase by the lengh of the passed in argument' do
-      counter.increase_by([1, 2, 3])
-      expect(counter.value).to eq 3
-    end
-
-    it 'accumulates increases' do
-      counter.increase_by([1, 2, 3])
-      counter.increase_by([1, 2, 3])
-      expect(counter.value).to eq 6
-    end
-  end
-end

data/spec/reek/context_builder_spec.rb

@@ -1,457 +0,0 @@
-require_relative '../spec_helper'
-require_lib 'reek/context_builder'
-
-RSpec.describe Reek::ContextBuilder do
-  describe '#context_tree' do
-    context 'with some simple example code' do
-      let(:walker) do
-        code = 'class Car; def drive; end; end'
-        described_class.new(syntax_tree(code))
-      end
-      let(:context_tree) { walker.context_tree }
-      let(:module_context) { context_tree.children.first }
-      let(:method_context) { module_context.children.first }
-
-      describe 'the starting node' do
-        it 'is a root node' do
-          expect(context_tree.type).to eq(:root)
-          expect(context_tree).to be_a(Reek::Context::RootContext)
-        end
-
-        it 'has one module_context child' do
-          aggregate_failures do
-            expect(context_tree.children.count).to eq 1
-            expect(module_context).to be_a(Reek::Context::ModuleContext)
-          end
-        end
-      end
-
-      describe 'the module node' do
-        it 'has one method_context child' do
-          aggregate_failures do
-            expect(method_context).to be_a(Reek::Context::MethodContext)
-            expect(module_context.children.size).to eq(1)
-          end
-        end
-
-        it 'holds a reference to the parent context' do
-          expect(method_context.parent).to eq(module_context)
-        end
-      end
-    end
-
-    it 'creates the proper context for all kinds of singleton methods' do
-      src = <<-RUBY
-        class Car
-          def self.start; end
-
-          class << self
-            def drive; end
-          end
-        end
-      RUBY
-
-      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
-      context_tree = described_class.new(syntax_tree).context_tree
-
-      class_node = context_tree.children.first
-      start_method = class_node.children.first
-      drive_method = class_node.children.last
-
-      expect(start_method).to be_instance_of Reek::Context::SingletonMethodContext
-      expect(drive_method).to be_instance_of Reek::Context::SingletonMethodContext
-    end
-
-    it 'returns something sensible for nested metaclasses' do
-      src = <<-RUBY
-        class Foo
-          class << self
-            class << self
-              def bar; end
-            end
-          end
-        end
-      RUBY
-
-      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
-      context_tree = described_class.new(syntax_tree).context_tree
-
-      class_context = context_tree.children.first
-      method_context = class_context.children.first
-
-      expect(method_context).to be_instance_of Reek::Context::SingletonMethodContext
-      expect(method_context.parent).to eq class_context
-    end
-
-    it 'returns something sensible for nested method definitions' do
-      src = <<-RUBY
-        class Foo
-          def foo
-            def bar
-            end
-          end
-        end
-      RUBY
-
-      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
-      context_tree = described_class.new(syntax_tree).context_tree
-
-      class_context = context_tree.children.first
-      foo_context = class_context.children.first
-
-      bar_context = foo_context.children.first
-      expect(bar_context).to be_instance_of Reek::Context::MethodContext
-      expect(bar_context.parent).to eq foo_context
-    end
-
-    it 'returns something sensible for method definitions nested in singleton methods' do
-      src = <<-RUBY
-        class Foo
-          def self.foo
-            def bar
-            end
-          end
-        end
-      RUBY
-
-      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
-      context_tree = described_class.new(syntax_tree).context_tree
-
-      class_context = context_tree.children.first
-      foo_context = class_context.children.first
-
-      bar_context = foo_context.children.first
-      expect(bar_context).to be_instance_of Reek::Context::SingletonMethodContext
-      expect(bar_context.parent).to eq foo_context
-    end
-  end
-
-  describe 'statement counting' do
-    def tree(code)
-      described_class.new(syntax_tree(code)).context_tree
-    end
-
-    def number_of_statements_for(code)
-      tree(code).children.first.number_of_statements
-    end
-
-    it 'counts 1 assignment' do
-      code = 'def one() val = 4; end'
-      expect(number_of_statements_for(code)).to eq(1)
-    end
-
-    it 'counts 3 assignments' do
-      code = 'def one() val = 4; val = 4; val = 4; end'
-      expect(number_of_statements_for(code)).to eq(3)
-    end
-
-    it 'counts 1 attr assignment' do
-      code = 'def one() val[0] = 4; end'
-      expect(number_of_statements_for(code)).to eq(1)
-    end
-
-    it 'counts 1 increment assignment' do
-      code = 'def one() val += 4; end'
-      expect(number_of_statements_for(code)).to eq(1)
-    end
-
-    it 'counts 1 increment attr assignment' do
-      code = 'def one() val[0] += 4; end'
-      expect(number_of_statements_for(code)).to eq(1)
-    end
-
-    it 'counts 1 nested assignment' do
-      code = 'def one() val = fred = 4; end'
-      expect(number_of_statements_for(code)).to eq(1)
-    end
-
-    it 'counts returns' do
-      code = 'def one() val = 4; true; end'
-      expect(number_of_statements_for(code)).to eq(2)
-    end
-
-    it 'counts nil returns' do
-      code = 'def one() val = 4; nil; end'
-      expect(number_of_statements_for(code)).to eq(2)
-    end
-
-    context 'with control statements' do
-      it 'counts 3 statements in a conditional expression' do
-        code = 'def one() if val == 4; callee(); callee(); callee(); end; end'
-        expect(number_of_statements_for(code)).to eq(3)
-      end
-
-      it 'counts 3 statements in an else' do
-        code = <<-RUBY
-          def one()
-            if val == 4
-              callee(); callee(); callee()
-            else
-              callee(); callee(); callee()
-            end
-          end
-        RUBY
-
-        expect(number_of_statements_for(code)).to eq(6)
-      end
-
-      it 'does not count constant assignment with or equals' do
-        code = 'class Hi; CONST ||= 1; end'
-        expect(number_of_statements_for(code)).to eq(0)
-      end
-
-      it 'does not count multi constant assignment' do
-        code = 'class Hi; CONST, OTHER_CONST = 1, 2; end'
-        expect(number_of_statements_for(code)).to eq(0)
-      end
-
-      it 'does not count empty conditional expression' do
-        code = 'def one() if val == 4; ; end; end'
-        expect(number_of_statements_for(code)).to eq(0)
-      end
-
-      it 'does not count empty else' do
-        code = 'def one() if val == 4; ; else; ; end; end'
-        expect(number_of_statements_for(code)).to eq(0)
-      end
-
-      it 'counts extra statements in an if condition' do
-        code = 'def one() if begin val = callee(); val < 4 end; end; end'
-        expect(number_of_statements_for(code)).to eq(1)
-      end
-
-      it 'counts 3 statements in a while loop' do
-        code = 'def one() while val < 4; callee(); callee(); callee(); end; end'
-        expect(number_of_statements_for(code)).to eq(3)
-      end
-
-      it 'counts extra statements in a while condition' do
-        code = 'def one() while begin val = callee(); val < 4 end; end; end'
-        expect(number_of_statements_for(code)).to eq(1)
-      end
-
-      it 'counts 3 statements in a until loop' do
-        code = 'def one() until val < 4; callee(); callee(); callee(); end; end'
-        expect(number_of_statements_for(code)).to eq(3)
-      end
-
-      it 'counts 3 statements in a for loop' do
-        code = 'def one() for i in 0..4; callee(); callee(); callee(); end; end'
-        expect(number_of_statements_for(code)).to eq(3)
-      end
-
-      it 'counts 3 statements in a rescue' do
-        code = <<-RUBY
-          def one()
-            begin
-              callee(); callee(); callee()
-            rescue
-              callee(); callee(); callee()
-            end
-          end
-        RUBY
-        expect(number_of_statements_for(code)).to eq(6)
-      end
-
-      it 'counts 3 statements in a when' do
-        code = <<-RUBY
-          def one()
-            case fred
-            when "hi" then callee(); callee()
-            when "lo" then callee()
-            end
-          end
-        RUBY
-        expect(number_of_statements_for(code)).to eq(3)
-      end
-
-      it 'counts 3 statements in a case else' do
-        code = <<-RUBY
-          def one()
-            case fred
-            when "hi" then callee(); callee(); callee()
-            else           callee(); callee(); callee()
-            end
-          end
-        RUBY
-        expect(number_of_statements_for(code)).to eq(6)
-      end
-
-      it 'does not count empty case' do
-        code = 'def one() case fred; when "hi"; ; when "lo"; ; end; end'
-        expect(number_of_statements_for(code)).to eq(0)
-      end
-
-      it 'does not count empty case else' do
-        code = 'def one() case fred; when "hi"; ; else; ; end; end'
-        expect(number_of_statements_for(code)).to eq(0)
-      end
-
-      it 'counts 4 statements in an iterator' do
-        code = 'def one() fred.each do; callee(); callee(); callee(); end; end'
-        expect(number_of_statements_for(code)).to eq(4)
-      end
-
-      it 'counts 1 statement in a singleton method' do
-        code = 'def self.foo; callee(); end'
-        expect(number_of_statements_for(code)).to eq(1)
-      end
-    end
-  end
-
-  describe 'visibility tracking' do
-    def context_tree_for(code)
-      described_class.new(syntax_tree(code)).context_tree
-    end
-
-    it 'marks instance methods when using a def modifier' do
-      code = <<-RUBY
-        class Foo
-          private def bar
-          end
-
-          def baz
-          end
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      module_context = root.children.first
-      method_contexts = module_context.children
-      aggregate_failures do
-        expect(method_contexts[0].visibility).to eq :private
-        expect(method_contexts[1].visibility).to eq :public
-      end
-    end
-
-    it 'does not mark class methods with instance visibility' do
-      code = <<-RUBY
-        class Foo
-          private
-          def bar
-          end
-          def self.baz
-          end
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      module_context = root.children.first
-      method_contexts = module_context.children
-      expect(method_contexts[0].visibility).to eq :private
-      expect(method_contexts[1].visibility).to eq :public
-    end
-
-    it 'only marks existing instance methods using later instance method modifiers' do
-      code = <<-RUBY
-        class Foo
-          def bar
-          end
-
-          def baz
-          end
-
-          def self.bar
-          end
-
-          class << self
-            def bar
-            end
-          end
-
-          private :bar, :baz
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      module_context = root.children.first
-      method_contexts = module_context.children
-      expect(method_contexts[0].visibility).to eq :private
-      expect(method_contexts[1].visibility).to eq :private
-      expect(method_contexts[2].visibility).to eq :public
-      expect(method_contexts[3].visibility).to eq :public
-    end
-
-    it 'only marks existing instance attributes using later instance method modifiers' do
-      code = <<-RUBY
-        class Foo
-          attr_writer :bar
-
-          class << self
-            attr_writer :bar
-          end
-
-          private :bar
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      module_context = root.children.first
-      method_contexts = module_context.children
-      expect(method_contexts[0].visibility).to eq :private
-      expect(method_contexts[1].visibility).to eq :public
-    end
-
-    it 'marks class method visibility using private_class_method' do
-      code = <<-RUBY
-        class Foo
-          def self.baz
-          end
-
-          private_class_method :baz
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      module_context = root.children.first
-      method_contexts = module_context.children
-      expect(method_contexts[0].visibility).to eq :private
-    end
-
-    it 'marks class method visibility using public_class_method' do
-      code = <<-RUBY
-        class Foo
-          class << self
-            private
-
-            def baz
-            end
-          end
-
-          public_class_method :baz
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      module_context = root.children.first
-      method_contexts = module_context.children
-      expect(method_contexts[0].visibility).to eq :public
-    end
-
-    it 'correctly skips nested modules' do
-      code = <<-RUBY
-        class Foo
-          class Bar
-            def baz
-            end
-          end
-
-          def baz
-          end
-
-          def self.bar
-          end
-
-          private :baz
-          private_class_method :bar
-        end
-      RUBY
-
-      root = context_tree_for(code)
-      foo_context = root.children.first
-      bar_context = foo_context.children.first
-      nested_baz_context = bar_context.children.first
-      expect(nested_baz_context.visibility).to eq :public
-    end
-  end
-end