reek 6.0.3 → 6.0.4

data/spec/reek/smell_detectors/missing_safe_method_spec.rb

@@ -1,68 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/missing_safe_method'
-
-RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
-  it 'reports the right values' do
-    src = <<-RUBY
-      class Alfa
-        def bravo!
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:MissingSafeMethod,
-                           lines:   [2],
-                           context: 'Alfa',
-                           message: "has missing safe method 'bravo!'",
-                           source:  'string',
-                           name:    'bravo!')
-  end
-
-  it 'does count all occurences' do
-    src = <<-RUBY
-      class Alfa
-        def bravo!
-        end
-
-        def charlie!
-        end
-      end
-    RUBY
-
-    expect(src).
-      to reek_of(:MissingSafeMethod, lines: [2], name: 'bravo!').
-      and reek_of(:MissingSafeMethod, lines: [5], name: 'charlie!')
-  end
-
-  it 'reports nothing when method and bang counterpart exist' do
-    src = <<-RUBY
-      class Alfa
-        def bravo
-        end
-
-        def bravo!
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:MissingSafeMethod)
-  end
-
-  it 'does not report methods we excluded via comment' do
-    source = <<-RUBY
-      # :reek:MissingSafeMethod { exclude: [ bravo! ] }
-      class Alfa
-        def bravo!
-        end
-
-        def charlie!
-        end
-      end
-    RUBY
-
-    aggregate_failures do
-      expect(source).not_to reek_of(:MissingSafeMethod, name: 'bravo!')
-      expect(source).to reek_of(:MissingSafeMethod, name: 'charlie!')
-    end
-  end
-end

data/spec/reek/smell_detectors/module_initialize_spec.rb

@@ -1,77 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/module_initialize'
-
-RSpec.describe Reek::SmellDetectors::ModuleInitialize do
-  it 'reports the right values' do
-    src = <<-RUBY
-      module Alfa
-        def initialize; end
-      end
-    RUBY
-
-    expect(src).to reek_of(:ModuleInitialize,
-                           lines:   [1],
-                           context: 'Alfa',
-                           message: 'has initialize method',
-                           source:  'string')
-  end
-
-  it 'reports nothing for a method with a different name' do
-    src = <<-RUBY
-      module Alfa
-        def bravo; end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:ModuleInitialize)
-  end
-
-  it 'reports nothing for a method named initialize in a nested class' do
-    src = <<-RUBY
-      module Alfa
-        class Bravo
-          def initialize; end
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:ModuleInitialize)
-  end
-
-  it 'reports nothing for a method named initialize in a nested struct' do
-    src = <<-RUBY
-      module Alfa
-        Bravo = Struct.new(:charlie) do
-          def initialize; end
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:ModuleInitialize)
-  end
-
-  it 'reports nothing for a method named initialize in a nested dynamic class' do
-    src = <<-RUBY
-      module Alfa
-        def self.bravo
-          Class.new do
-            def initialize; end
-          end
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:ModuleInitialize)
-  end
-
-  it 'can be disabled via comment' do
-    src = <<-RUBY
-      # :reek:ModuleInitialize
-      module Alfa
-        def initialize; end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:ModuleInitialize)
-  end
-end

data/spec/reek/smell_detectors/nested_iterators_spec.rb

@@ -1,333 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/nested_iterators'
-
-RSpec.describe Reek::SmellDetectors::NestedIterators do
-  it 'reports the right values' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo.each do |charlie|
-          charlie.each { |delta| delta }
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:NestedIterators,
-                           lines:   [3],
-                           context: 'alfa',
-                           message: 'contains iterators nested 2 deep',
-                           source:  'string',
-                           depth:   2)
-  end
-
-  it 'does count all occurences' do
-    src = <<-RUBY
-      def alfa
-        bravo.each do |charlie|
-          charlie.each { |delta| delta }
-        end
-
-        echo.each do |foxtrot|
-          foxtrot.each do |golf|
-            golf.each { |hotel| hotel }
-          end
-        end
-      end
-    RUBY
-
-    expect(src).
-      to reek_of(:NestedIterators, lines: [3], depth: 2).
-      and reek_of(:NestedIterators, lines: [8], depth: 3)
-  end
-
-  it 'reports no smells with no iterators' do
-    src = 'def alfa; end'
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  it 'reports no smells with one iterator' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo.each { |charlie| charlie }
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  it 'does not report nested iterators for Object#tap' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo.tap do |charlie|
-          charlie.each { |delta| delta }
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  it 'does not report method with successive iterators' do
-    src = <<-RUBY
-      def alfa
-        @bravo.each   { |charlie| charlie }
-        @charlie.each { |delta| delta }
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  it 'does not report method with chained iterators' do
-    src = <<-RUBY
-      def alfa
-        bravo.sort_by { |charlie| charlie }.each { |delta| delta }
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  it 'detects an iterator with an empty block' do
-    src = <<-RUBY
-      def alfa
-        bravo do |charlie|
-          charlie { |delta| }
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:NestedIterators)
-  end
-
-  it 'reports nesting inside iterator arguments' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo(
-          charlie.each do |delta|
-            delta.each { |echo| echo }
-          end
-        )
-      end
-    RUBY
-
-    expect(src).to reek_of(:NestedIterators, depth: 2)
-  end
-
-  it 'reports the deepest level of nesting only' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo.each do |charlie|
-          charlie.each do |delta|
-            delta.each { |echo| echo }
-          end
-        end
-      end
-    RUBY
-
-    expect(src).
-      to not_reek_of(:NestedIterators, depth: 2).
-      and reek_of(:NestedIterators, depth: 3, lines: [4])
-  end
-
-  it 'reports all lines on which nested iterators occur' do
-    source = <<-RUBY
-      def alfa
-        @bravo.each { |charlie| charlie.each { |delta| @echo.send } }
-        @foxtrot.each { |golf| golf.each { |hotel| @india.send } }
-      end
-    RUBY
-
-    expect(source).to reek_of(:NestedIterators, lines: [2, 3])
-  end
-
-  it 'handles the case where super receives a block' do
-    src = <<-RUBY
-      def alfa
-        super do |bravo|
-          bravo.each { |charlie| charlie }
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:NestedIterators)
-  end
-
-  it 'handles the case where super receives a block and arguments' do
-    src = <<-RUBY
-      def alfa
-        super(delta) do |bravo|
-          bravo.each { |charlie| charlie }
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:NestedIterators)
-  end
-
-  it 'does not count iterators without block arguments' do
-    src = <<-RUBY
-      def alfa
-        bravo do
-          charlie.each { |delta| delta }
-        end
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  context 'when blocks are specified as lambdas' do
-    it 'does not report blocks that are not nested' do
-      src = <<-RUBY
-        def alfa
-          bravo ->(charlie) { delta }
-        end
-      RUBY
-
-      expect(src).not_to reek_of(:NestedIterators)
-    end
-
-    it 'reports blocks that are nested' do
-      src = <<-RUBY
-        def alfa
-          bravo ->(charlie) do
-            delta ->(echo) { echo }
-          end
-        end
-      RUBY
-
-      expect(src).to reek_of(:NestedIterators)
-    end
-  end
-
-  it 'reports nested iterators called via safe navigation' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo&.each do |charlie|
-          charlie&.each { |delta| delta }
-        end
-      end
-    RUBY
-
-    expect(src).to reek_of(:NestedIterators)
-  end
-
-  it 'does not report unnested iterators called via safe navigation' do
-    src = <<-RUBY
-      def alfa(bravo)
-        bravo&.each { |charlie| charlie }
-        delta&.each { |echo| echo }
-      end
-    RUBY
-
-    expect(src).not_to reek_of(:NestedIterators)
-  end
-
-  context 'when setting the allowed nesting depth to 3' do
-    let(:config) do
-      { Reek::SmellDetectors::NestedIterators::MAX_ALLOWED_NESTING_KEY => 3 }
-    end
-
-    it 'does not report nested iterators 3 levels deep' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.each do |charlie|
-            charlie.each do |delta|
-              delta.each { |echo| echo }
-            end
-          end
-        end
-      RUBY
-
-      expect(src).not_to reek_of(:NestedIterators).with_config(config)
-    end
-
-    it 'reports nested iterators 4 levels deep' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.each do |charlie|
-            charlie.each do |delta|
-              delta.each do |echo|
-                echo.each { |foxtrot| foxtrot }
-              end
-            end
-          end
-        end
-      RUBY
-
-      expect(src).to reek_of(:NestedIterators).with_config(config)
-    end
-  end
-
-  context 'when ignoring iterators' do
-    let(:config) do
-      { Reek::SmellDetectors::NestedIterators::IGNORE_ITERATORS_KEY => ['ignore_me'] }
-    end
-
-    it 'does not report when nesting the ignored iterator inside another' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.each do |charlie|
-            charlie.ignore_me { |delta| delta }
-          end
-        end
-      RUBY
-
-      expect(src).not_to reek_of(:NestedIterators).with_config(config)
-    end
-
-    it 'does not report a nested iterator inside the ignored iterator' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.ignore_me do |charlie|
-            charlie.each { |delta| delta }
-          end
-        end
-      RUBY
-
-      expect(src).not_to reek_of(:NestedIterators).with_config(config)
-    end
-
-    it 'reports nested iterators inside the ignored iterator' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.ignore_me do |charlie|
-            charlie.each do |delta|
-              delta.each { |echo| echo }
-            end
-          end
-        end
-      RUBY
-
-      expect(src).to reek_of(:NestedIterators, depth: 2).with_config(config)
-    end
-
-    it 'reports nested iterators outside the ignored iterator' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.each do |charlie|
-            charlie.each do |delta|
-              delta.ignore_me { |echo| echo }
-            end
-          end
-        end
-      RUBY
-
-      expect(src).to reek_of(:NestedIterators, depth: 2).with_config(config)
-    end
-
-    it 'reports nested iterators with the ignored iterator between them' do
-      src = <<-RUBY
-        def alfa(bravo)
-          bravo.each do |charlie|
-            charlie.ignore_me do |delta|
-              delta.each { |echo| echo }
-            end
-          end
-        end
-      RUBY
-
-      expect(src).to reek_of(:NestedIterators, depth: 2).with_config(config)
-    end
-  end
-end