reek 2.0.4 → 3.0.0

data/lib/reek/report/location_formatter.rb

@@ -0,0 +1,35 @@
+module Reek
+  module Report
+    #
+    # Formats the location of a warning as an empty string.
+    #
+    # @api private
+    module BlankLocationFormatter
+      def self.format(_warning)
+        ''
+      end
+    end
+
+    #
+    # Formats the location of a warning as an array of line numbers.
+    #
+    # @api private
+    module DefaultLocationFormatter
+      def self.format(warning)
+        "#{warning.lines.inspect}:"
+      end
+    end
+
+    #
+    # Formats the location of a warning as a combination of source file name
+    # and line number. In this format, it is not possible to show more than
+    # one line number, so the first number is displayed.
+    #
+    # @api private
+    module SingleLineLocationFormatter
+      def self.format(warning)
+        "#{warning.source}:#{warning.lines.first}: "
+      end
+    end
+  end
+end

data/lib/reek/report/report.rb

@@ -0,0 +1,198 @@
+require 'rainbow'
+require 'json'
+require_relative 'formatter'
+require_relative 'heading_formatter'
+
+module Reek
+  module Report
+    #
+    # A report that contains the smells and smell counts following source code analysis.
+    #
+    # @abstract Subclass and override {#show} to create a concrete report class.
+    class Base
+      # @api private
+      NO_WARNINGS_COLOR = :green
+      # @api private
+      WARNINGS_COLOR = :red
+
+      def initialize(options = {})
+        @examiners           = []
+        @total_smell_count   = 0
+        @options             = options
+        @warning_formatter   = options.fetch :warning_formatter, SimpleWarningFormatter.new
+        @report_formatter    = options.fetch :report_formatter, Formatter
+        @sort_by_issue_count = options.fetch :sort_by_issue_count, false
+      end
+
+      # Add Examiner to report on. The report will output results for all
+      # added examiners.
+      #
+      # @param [Reek::Examiner] examiner object to report on
+      def add_examiner(examiner)
+        @total_smell_count += examiner.smells_count
+        @examiners << examiner
+        self
+      end
+
+      # Render the report results on STDOUT
+      def show
+        raise NotImplementedError
+      end
+
+      # @api private
+      def smells?
+        @total_smell_count > 0
+      end
+
+      # @api private
+      def smells
+        @examiners.map(&:smells).flatten
+      end
+    end
+
+    #
+    # Generates a sorted, text summary of smells in examiners
+    #
+    class TextReport < Base
+      def show
+        sort_examiners if smells?
+        display_summary
+        display_total_smell_count
+      end
+
+      private
+
+      def smell_summaries
+        @examiners.map { |ex| summarize_single_examiner(ex) }.reject(&:empty?)
+      end
+
+      def display_summary
+        smell_summaries.each { |smell| puts smell }
+      end
+
+      def display_total_smell_count
+        return unless @examiners.size > 1
+        print total_smell_count_message
+      end
+
+      def summarize_single_examiner(examiner)
+        result = heading_formatter.header(examiner)
+        if examiner.smelly?
+          formatted_list = @report_formatter.format_list(examiner.smells,
+                                                         @warning_formatter)
+          result += ":\n#{formatted_list}"
+        end
+        result
+      end
+
+      def sort_examiners
+        @examiners.sort_by!(&:smells_count).reverse! if @sort_by_issue_count
+      end
+
+      def total_smell_count_message
+        colour = smells? ? WARNINGS_COLOR : NO_WARNINGS_COLOR
+        s = @total_smell_count == 1 ? '' : 's'
+        Rainbow("#{@total_smell_count} total warning#{s}\n").color(colour)
+      end
+
+      def heading_formatter
+        @heading_formatter ||=
+          @options.fetch(:heading_formatter, HeadingFormatter::Quiet).new(@report_formatter)
+      end
+    end
+
+    #
+    # Displays a list of smells in YAML format
+    # YAML with empty array for 0 smells
+    class YAMLReport < Base
+      def show
+        print smells.map(&:yaml_hash).to_yaml
+      end
+    end
+
+    #
+    # Displays a list of smells in JSON format
+    # JSON with empty array for 0 smells
+    class JSONReport < Base
+      def show
+        print ::JSON.generate(
+          smells.map do |smell|
+            smell.yaml_hash(@warning_formatter)
+          end
+        )
+      end
+    end
+
+    #
+    # Saves the report as a HTML file
+    #
+    class HTMLReport < Base
+      require 'erb'
+
+      def show
+        path = File.expand_path('../../../../assets/html_output.html.erb',
+                                __FILE__)
+        File.open('reek.html', 'w+') do |file|
+          file.puts ERB.new(File.read(path)).result(binding)
+        end
+        print("Html file saved\n")
+      end
+    end
+
+    #
+    # Generates a list of smells in XML format
+    #
+    class XMLReport < Base
+      require 'rexml/document'
+
+      def show
+        checkstyle = REXML::Element.new('checkstyle', document)
+
+        smells.group_by(&:source).each do |file, file_smells|
+          file_to_xml(file, file_smells, checkstyle)
+        end
+
+        print_xml(checkstyle.parent)
+      end
+
+      private
+
+      def document
+        REXML::Document.new.tap do |doc|
+          doc << REXML::XMLDecl.new
+        end
+      end
+
+      def file_to_xml(file, file_smells, parent)
+        REXML::Element.new('file', parent).tap do |element|
+          element.attributes['name'] = File.realpath(file)
+          smells_to_xml(file_smells, element)
+        end
+      end
+
+      def smells_to_xml(smells, parent)
+        smells.each do |smell|
+          smell_to_xml(smell, parent)
+        end
+      end
+
+      def smell_to_xml(smell, parent)
+        REXML::Element.new('error', parent).tap do |element|
+          attributes = [
+            ['line', smell.lines.first],
+            ['column', 0],
+            ['severity', 'warning'],
+            ['message', smell.message],
+            ['source', smell.smell_type]
+          ]
+          element.add_attributes(attributes)
+        end
+      end
+
+      def print_xml(document)
+        formatter = REXML::Formatters::Default.new
+        puts formatter.write(document, '')
+      end
+    end
+  end
+end

data/lib/reek/smells/attribute.rb

@@ -1,6 +1,6 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
-require 'reek/core/smell_configuration'
+require_relative 'smell_configuration'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -13,16 +13,27 @@ module Reek
     # +attr_reader+, +attr_writer+ and +attr_accessor+ -- including those
     # that are private.
     #
-    # TODO: Eliminate private attributes
-    # TODO: Catch attributes declared "by hand"
+    # See {file:docs/Attribute.md} for details.
+    # @api private
     #
+    # TODO: Catch attributes declared "by hand"
     class Attribute < SmellDetector
+      ATTR_DEFN_METHODS = [:attr, :attr_reader, :attr_writer, :attr_accessor]
+      VISIBILITY_MODIFIERS = [:private, :public, :protected]
+
+      def initialize(*args)
+        @visiblity_tracker = {}
+        @visiblity_mode = :public
+        @result = Set.new
+        super
+      end
+
       def self.contexts # :nodoc:
         [:class, :module]
       end
 
       def self.default_config
-        super.merge(Core::SmellConfiguration::ENABLED_KEY => false)
+        super.merge(SmellConfiguration::ENABLED_KEY => false)
       end
 
       #
@@ -43,14 +54,33 @@ module Reek
       private
 
       def attributes_in(module_ctx)
-        result = Set.new
-        attr_defn_methods = [:attr, :attr_reader, :attr_writer, :attr_accessor]
         module_ctx.local_nodes(:send) do |call_node|
-          if attr_defn_methods.include?(call_node.method_name)
-            call_node.arg_names.each { |arg| result << [arg, call_node.line] }
+          if visibility_modifier?(call_node)
+            track_visibility(call_node)
+          elsif ATTR_DEFN_METHODS.include?(call_node.method_name)
+            call_node.arg_names.each do |arg|
+              @visiblity_tracker[arg] = @visiblity_mode
+              @result << [arg, call_node.line]
+            end
           end
         end
-        result
+        @result.select { |args| recorded_public_methods.include?(args[0]) }
+      end
+
+      def visibility_modifier?(call_node)
+        VISIBILITY_MODIFIERS.include?(call_node.method_name)
+      end
+
+      def track_visibility(call_node)
+        if call_node.arg_names.any?
+          call_node.arg_names.each { |arg| @visiblity_tracker[arg] = call_node.method_name }
+        else
+          @visiblity_mode = call_node.method_name
+        end
+      end
+
+      def recorded_public_methods
+        @visiblity_tracker.select { |_, visbility| visbility == :public }
       end
     end
   end

data/lib/reek/smells/boolean_parameter.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -11,6 +11,8 @@ module Reek
     # Currently Reek can only detect a Boolean parameter when it has a
     # default initializer.
     #
+    # See {file:docs/Boolean-Parameter.md} for details.
+    # @api private
     class BooleanParameter < SmellDetector
       def self.smell_category
         'ControlCouple'

data/lib/reek/smells/class_variable.rb

@@ -1,6 +1,6 @@
 require 'set'
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -12,6 +12,8 @@ module Reek
     # In particular, class variables can make it hard to set up tests (because
     # the context of the test includes all global state).
     #
+    # See {file:docs/Class-Variable.md} for details.
+    # @api private
     class ClassVariable < SmellDetector
       def self.contexts # :nodoc:
         [:class, :module]

data/lib/reek/smells/control_parameter.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -40,6 +40,8 @@ module Reek
     # that remains next to where the caller invokes it in
     # the source code.
     #
+    # See {file:docs/Control-Parameter.md} for details.
+    # @api private
     class ControlParameter < SmellDetector
       def self.smell_category
         'ControlCouple'

data/lib/reek/smells/data_clump.rb

@@ -1,6 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
-require 'reek/source'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -16,6 +15,8 @@ module Reek
     # Currently Reek looks for a group of two or more parameters with
     # the same names that are expected by three or more methods of a class.
     #
+    # See {file:docs/Data-Clump.md} for details.
+    # @api private
     class DataClump < SmellDetector
       #
       # The name of the config field that sets the maximum allowed

data/lib/reek/smells/duplicate_method_call.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -16,6 +16,8 @@ module Reek
     #     @other.thing + @other.thing
     #   end
     #
+    # See {file:docs/Duplicate-Method-Call.md} for details.
+    # @api private
     class DuplicateMethodCall < SmellDetector
       # The name of the config field that sets the maximum number of
       # identical calls to be permitted within any single method.
@@ -70,7 +72,7 @@ module Reek
         end
 
         def call
-          @call ||= @call_node.format_ruby
+          @call ||= @call_node.format_to_ruby
         end
 
         def occurs
@@ -106,8 +108,8 @@ module Reek
 
         def collect_calls(result)
           context.each_node(:send, [:mlhs]) do |call_node|
-            next if call_node.method_name == :new
-            next if !call_node.receiver && call_node.args.empty?
+            next if initializer_call? call_node
+            next if simple_method_call? call_node
             result[call_node].record(call_node)
           end
           context.local_nodes(:block) do |call_node|
@@ -119,6 +121,14 @@ module Reek
           found_call.occurs > @max_allowed_calls && !allow_calls?(found_call.call)
         end
 
+        def simple_method_call?(call_node)
+          !call_node.receiver && call_node.args.empty?
+        end
+
+        def initializer_call?(call_node)
+          call_node.method_name == :new
+        end
+
         def allow_calls?(method)
           @allow_calls.any? { |allow| /#{allow}/ =~ method }
         end

data/lib/reek/smells/feature_envy.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -30,6 +30,11 @@ module Reek
     # Currently +FeatureEnvy+ reports any method that refers to self less
     # often than it refers to (ie. send messages to) some other object.
     #
+    # If the method doesn't reference self at all, +UtilityFunction+ is
+    # reported instead.
+    #
+    # See {file:docs/Feature-Envy.md} for details.
+    # @api private
     class FeatureEnvy < SmellDetector
       def self.smell_category
         'LowCohesion'
@@ -42,6 +47,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       def examine_context(method_ctx)
+        return [] unless method_ctx.references_self?
         method_ctx.envious_receivers.map do |ref, occurs|
           target = ref.to_s
           SmellWarning.new self,

data/lib/reek/smells/irresponsible_module.rb

@@ -1,6 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
-require 'reek/source/code_comment'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -8,12 +7,14 @@ module Reek
     # It is considered good practice to annotate every class and module
     # with a brief comment outlining its responsibilities.
     #
+    # See {file:docs/Irresponsible-Module.md} for details.
+    # @api private
     class IrresponsibleModule < SmellDetector
       def self.contexts # :nodoc:
         [:class]
       end
 
-      def self.descriptive   # :nodoc:
+      def descriptive   # :nodoc:
         @descriptive ||= {}
       end
 
@@ -23,13 +24,17 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       def examine_context(ctx)
-        comment = Source::CodeComment.new(ctx.exp.comments)
-        return [] if self.class.descriptive[ctx.full_name] ||= comment.descriptive?
+        return [] if descriptive?(ctx)
+        expression = ctx.exp
         [SmellWarning.new(self,
                           context: ctx.full_name,
-                          lines: [ctx.exp.line],
+                          lines: [expression.line],
                           message: 'has no descriptive comment',
-                          parameters: {  name: ctx.exp.text_name })]
+                          parameters: {  name: expression.text_name })]
+      end
+
+      def descriptive?(ctx)
+        descriptive[ctx.full_name] ||= ctx.descriptively_commented?
       end
     end
   end

data/lib/reek/smells/long_parameter_list.rb

@@ -1,6 +1,6 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
-require 'reek/core/smell_configuration'
+require_relative 'smell_configuration'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -12,6 +12,8 @@ module Reek
     # Currently +LongParameterList+ reports any method or block with too
     # many parameters.
     #
+    # See {file:docs/Long-Parameter-List.md} for details.
+    # @api private
     class LongParameterList < SmellDetector
       # The name of the config field that sets the maximum number of
       # parameters permitted in any method or block.
@@ -21,7 +23,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_ALLOWED_PARAMS_KEY => DEFAULT_MAX_ALLOWED_PARAMS,
-          Core::SmellConfiguration::OVERRIDES_KEY => {
+          SmellConfiguration::OVERRIDES_KEY => {
             'initialize' => { MAX_ALLOWED_PARAMS_KEY => 5 }
           }
         )

data/lib/reek/smells/long_yield_list.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -7,6 +7,8 @@ module Reek
     # A variant on LongParameterList that checks the number of items
     # passed to a block by a +yield+ call.
     #
+    # See {file:docs/Long-Yield-List.md} for details.
+    # @api private
     class LongYieldList < SmellDetector
       # The name of the config field that sets the maximum number of
       # parameters permitted in any method or block.

data/lib/reek/smells/module_initialize.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -8,6 +8,8 @@ module Reek
     # hard to tell initialization order and parameters so having 'initialize'
     # in a module is usually a bad idea
     #
+    # See {file:docs/Module-Initialize.md} for details.
+    # @api private
     class ModuleInitialize < SmellDetector
       def self.contexts # :nodoc:
         [:module]

data/lib/reek/smells/nested_iterators.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -8,6 +8,8 @@ module Reek
     #
     # +NestedIterators+ reports failing methods only once.
     #
+    # See {file:docs/Nested-Iterators.md} for details.
+    # @api private
     class NestedIterators < SmellDetector
       # The name of the config field that sets the maximum depth
       # of nested iterators to be permitted within any single method.

data/lib/reek/smells/nil_check.rb

@@ -1,10 +1,13 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
     # Checking for nil is a special kind of type check, and therefore a case of
     # SimulatedPolymorphism.
+    #
+    # See {file:docs/Nil-Check.md} for details.
+    # @api private
     class NilCheck < SmellDetector
       def self.smell_category
         'SimulatedPolymorphism'
@@ -19,7 +22,7 @@ module Reek
           SmellWarning.new self,
                            context: ctx.full_name,
                            lines: [node.line],
-                           message: 'performs a nil-check.'
+                           message: 'performs a nil-check'
         end
       end
 

data/lib/reek/smells/prima_donna_method.rb

@@ -1,5 +1,5 @@
-require 'reek/smells/smell_detector'
-require 'reek/smell_warning'
+require_relative 'smell_detector'
+require_relative 'smell_warning'
 
 module Reek
   module Smells
@@ -22,6 +22,8 @@ module Reek
     #
     # Such a method is called PrimaDonnaMethod and is reported as a smell.
     #
+    # See {file:docs/Prima-Donna-Method.md} for details.
+    # @api private
     class PrimaDonnaMethod < SmellDetector
       def self.contexts # :nodoc:
         [:class]
@@ -29,18 +31,25 @@ module Reek
 
       def examine_context(ctx)
         ctx.node_instance_methods.map do |method_sexp|
-          next unless method_sexp.ends_with_bang?
+          check_for_smells(method_sexp, ctx)
+        end.compact
+      end
 
-          version_without_bang = ctx.node_instance_methods.find do |sexp_item|
-            sexp_item.name.to_s == method_sexp.name_without_bang
-          end
-          next if version_without_bang
+      private
 
-          SmellWarning.new self,
-                           context: ctx.full_name,
-                           lines: [ctx.exp.line],
-                           message: "has prima donna method `#{method_sexp.name}`"
-        end.compact
+      def check_for_smells(method_sexp, ctx)
+        return unless method_sexp.ends_with_bang?
+
+        version_without_bang = ctx.node_instance_methods.find do |sexp_item|
+          sexp_item.name.to_s == method_sexp.name_without_bang
+        end
+
+        return if version_without_bang
+
+        SmellWarning.new self,
+                         context: ctx.full_name,
+                         lines: [ctx.exp.line],
+                         message: "has prima donna method `#{method_sexp.name}`"
       end
     end
   end