reek 2.0.4 → 3.0.0

data/spec/reek/smells/too_many_statements_spec.rb

@@ -1,16 +1,17 @@
-require 'spec_helper'
-require 'reek/smells/too_many_statements'
-require 'reek/smells/smell_detector_shared'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/too_many_statements'
+require_relative 'smell_detector_shared'
+require_relative '../../../lib/reek/source/source_code'
 
 def process_method(source)
-  Reek::Core::TreeWalker.new.process_def(source.to_reek_source.syntax_tree)
+  Reek::TreeWalker.new.process_def(Reek::Source::SourceCode.from(source).syntax_tree)
 end
 
 def process_singleton_method(source)
-  Reek::Core::TreeWalker.new.process_defs(source.to_reek_source.syntax_tree)
+  Reek::TreeWalker.new.process_defs(Reek::Source::SourceCode.from(source).syntax_tree)
 end
 
-describe Reek::Smells::TooManyStatements do
+RSpec.describe Reek::Smells::TooManyStatements do
   it 'should not report short methods' do
     src = 'def short(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;end'
     expect(src).not_to reek_of(:TooManyStatements)
@@ -48,7 +49,7 @@ describe Reek::Smells::TooManyStatements do
   end
 end
 
-describe Reek::Smells::TooManyStatements do
+RSpec.describe Reek::Smells::TooManyStatements do
   it 'counts 1 assignment' do
     method = process_method('def one() val = 4; end')
     expect(method.num_statements).to eq(1)
@@ -90,7 +91,7 @@ describe Reek::Smells::TooManyStatements do
   end
 end
 
-describe Reek::Smells::TooManyStatements, 'does not count control statements' do
+RSpec.describe Reek::Smells::TooManyStatements, 'does not count control statements' do
   it 'counts 1 statement in a conditional expression' do
     method = process_method('def one() if val == 4; callee(); end; end')
     expect(method.num_statements).to eq(1)
@@ -247,7 +248,7 @@ describe Reek::Smells::TooManyStatements, 'does not count control statements' do
   end
 end
 
-describe Reek::Smells::TooManyStatements do
+RSpec.describe Reek::Smells::TooManyStatements do
   before(:each) do
     @detector = build(:smell_detector, smell_type: :TooManyStatements, source: 'source_name')
   end

data/spec/reek/smells/uncommunicative_method_name_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
-require 'reek/smells/uncommunicative_method_name'
-require 'reek/smells/smell_detector_shared'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/uncommunicative_method_name'
+require_relative 'smell_detector_shared'
 
-describe Reek::Smells::UncommunicativeMethodName do
+RSpec.describe Reek::Smells::UncommunicativeMethodName do
   before do
     @source_name = 'dummy_source'
     @detector = build(:smell_detector, smell_type: :UncommunicativeMethodName, source: @source_name)
@@ -21,7 +21,7 @@ describe Reek::Smells::UncommunicativeMethodName do
     context 'with a bad name' do
       before do
         src = "def #{method_name}; end"
-        ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
+        ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
         smells = @detector.examine_context(ctx)
         @warning = smells[0]
       end

data/spec/reek/smells/uncommunicative_module_name_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
-require 'reek/smells/uncommunicative_module_name'
-require 'reek/smells/smell_detector_shared'
-require 'reek/core/code_context'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/uncommunicative_module_name'
+require_relative 'smell_detector_shared'
+require_relative '../../../lib/reek/context/code_context'
 
-describe Reek::Smells::UncommunicativeModuleName do
+RSpec.describe Reek::Smells::UncommunicativeModuleName do
   before do
     @source_name = 'dummy_source'
     @detector = build(:smell_detector, smell_type: :UncommunicativeModuleName, source: @source_name)
@@ -30,7 +30,7 @@ describe Reek::Smells::UncommunicativeModuleName do
 
     it 'reports a bad scoped name' do
       src = "#{type} Foo::X; end"
-      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
       smells = @detector.examine_context(ctx)
       expect(smells.length).to eq(1)
       expect(smells[0].smell_category).to eq(Reek::Smells::UncommunicativeModuleName.smell_category)
@@ -43,7 +43,7 @@ describe Reek::Smells::UncommunicativeModuleName do
   context 'accepting names' do
     it 'accepts Inline::C' do
       src = 'module Inline::C; end'
-      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
       expect(@detector.examine_context(ctx)).to be_empty
     end
   end
@@ -51,7 +51,7 @@ describe Reek::Smells::UncommunicativeModuleName do
   context 'looking at the YAML' do
     before :each do
       src = 'module Printer2; end'
-      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
       smells = @detector.examine_context(ctx)
       @warning = smells[0]
     end

data/spec/reek/smells/uncommunicative_parameter_name_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
-require 'reek/smells/uncommunicative_parameter_name'
-require 'reek/smells/smell_detector_shared'
-require 'reek/core/method_context'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/uncommunicative_parameter_name'
+require_relative 'smell_detector_shared'
+require_relative '../../../lib/reek/context/method_context'
 
-describe Reek::Smells::UncommunicativeParameterName do
+RSpec.describe Reek::Smells::UncommunicativeParameterName do
   before :each do
     @source_name = 'dummy_source'
     @detector = build(:smell_detector,
@@ -63,13 +63,25 @@ describe Reek::Smells::UncommunicativeParameterName do
         expect("def #{host}help(_unused) basics(_unused) end").
           to reek_of(:UncommunicativeParameterName)
       end
+
+      it 'reports names inside array decomposition' do
+        src = "def #{host}help((b, nice)) basics(b, nice) end"
+        expect(src).to reek_of(:UncommunicativeParameterName,
+                               name: 'b')
+      end
+
+      it 'reports names inside nested array decomposition' do
+        src = "def #{host}help((foo, (bar, c))) basics(foo, c) end"
+        expect(src).to reek_of(:UncommunicativeParameterName,
+                               name: 'c')
+      end
     end
   end
 
   context 'looking at the smell result fields' do
     before :each do
       src = 'def bad(good, bad2, good_again); basics(good, bad2, good_again); end'
-      ctx = Reek::Core::MethodContext.new(nil, src.to_reek_source.syntax_tree)
+      ctx = Reek::Context::MethodContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
       @smells = @detector.examine_context(ctx)
       @warning = @smells[0]
     end

data/spec/reek/smells/uncommunicative_variable_name_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
-require 'reek/smells/uncommunicative_variable_name'
-require 'reek/smells/smell_detector_shared'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/uncommunicative_variable_name'
+require_relative 'smell_detector_shared'
 
-describe Reek::Smells::UncommunicativeVariableName do
+RSpec.describe Reek::Smells::UncommunicativeVariableName do
   before :each do
     @source_name = 'dummy_source'
     @detector = build(:smell_detector,
@@ -52,7 +52,8 @@ describe Reek::Smells::UncommunicativeVariableName do
 
     it 'reports variable name only once' do
       src = 'def simple(fred) x = jim(45); x = y end'
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
+      ctx = Reek::Context::CodeContext.new(nil, syntax_tree)
       smells = @detector.examine_context(ctx)
       expect(smells.length).to eq(1)
       expect(smells[0].smell_type).to eq(described_class.smell_type)
@@ -163,7 +164,8 @@ describe Reek::Smells::UncommunicativeVariableName do
           end
         end
       EOS
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
+      ctx = Reek::Context::CodeContext.new(nil, syntax_tree)
       @smells = @detector.examine_context(ctx)
       @warning = @smells[0]
     end
@@ -179,7 +181,8 @@ describe Reek::Smells::UncommunicativeVariableName do
   context 'when a smell is reported in a singleton method' do
     before :each do
       src = 'def self.bad() x2 = 4; end'
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
+      ctx = Reek::Context::CodeContext.new(nil, syntax_tree)
       @smells = @detector.examine_context(ctx)
       @warning = @smells[0]
     end

data/spec/reek/smells/unused_parameters_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
-require 'reek/smells/unused_parameters'
-require 'reek/smells/smell_detector_shared'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/unused_parameters'
+require_relative 'smell_detector_shared'
 
-describe Reek::Smells::UnusedParameters do
+RSpec.describe Reek::Smells::UnusedParameters do
   context 'for methods' do
     it 'reports nothing for no parameters' do
       expect('def simple; true end').not_to reek_of(:UnusedParameters)

data/spec/reek/smells/utility_function_spec.rb

@@ -1,30 +1,72 @@
-require 'spec_helper'
-require 'reek/smells/utility_function'
-require 'reek/smells/smell_detector_shared'
-
-describe Reek::Smells::UtilityFunction do
-  before(:each) do
-    @source_name = 'dummy_source'
-    @detector = build(:smell_detector, smell_type: :UtilityFunction, source: @source_name)
-  end
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/smells/utility_function'
+require_relative 'smell_detector_shared'
+
+RSpec.describe Reek::Smells::UtilityFunction do
+  describe 'a detector' do
+    before(:each) do
+      @source_name = 'dummy_source'
+      @detector = build(:smell_detector,
+                        smell_type: :UtilityFunction,
+                        source: @source_name)
+    end
+
+    it_should_behave_like 'SmellDetector'
+
+    context 'when a smells is reported' do
+      before :each do
+        src = <<-EOS
+        def simple(arga)
+          arga.b.c
+        end
+        EOS
+        source = Reek::Source::SourceCode.from(src)
+        mctx = Reek::TreeWalker.new.process_def(source.syntax_tree)
+        @warning = @detector.examine_context(mctx)[0]   # SMELL: too cumbersome!
+      end
 
-  it_should_behave_like 'SmellDetector'
+      it_should_behave_like 'common fields set correctly'
+
+      it 'reports the line number of the method' do
+        expect(@warning.lines).to eq([1])
+      end
+    end
+  end
 
   context 'with a singleton method' do
     ['self', 'local_call', '$global'].each do |receiver|
       it 'ignores the receiver' do
         src = "def #{receiver}.simple(arga) arga.to_s + arga.to_i end"
-        ctx = Reek::Core::MethodContext.new(nil, src.to_reek_source.syntax_tree)
-        expect(@detector.examine_context(ctx)).to be_empty
+        expect(src).not_to reek_of(:UtilityFunction)
       end
     end
   end
 
+  context 'Singleton methods' do
+    it 'for classes with `class << self` notation should not report UtilityFunction' do
+      src = 'class C; class << self; def m(a) a.to_s; end; end; end'
+      expect(src).not_to reek_of(:UtilityFunction)
+    end
+
+    it 'for classes with `self.` notation should not report UtilityFunction' do
+      src = 'class C; def self.m(a) a.to_s; end; end'
+      expect(src).not_to reek_of(:UtilityFunction)
+    end
+
+    it 'for modules with `class << self` notation should not report UtilityFunction' do
+      src = 'module M; class << self; def self.m(a) a.to_s; end; end; end'
+      expect(src).not_to reek_of(:UtilityFunction)
+    end
+
+    it 'for modules with `self.` notation should not report UtilityFunction' do
+      src = 'module M; def self.simple(a) a.to_s; end; end'
+      expect(src).not_to reek_of(:UtilityFunction)
+    end
+  end
+
   context 'with no calls' do
     it 'does not report empty method' do
-      src = 'def simple(arga) end'
-      ctx = Reek::Core::MethodContext.new(nil, src.to_reek_source.syntax_tree)
-      expect(@detector.examine_context(ctx)).to be_empty
+      expect('def simple(arga) end').not_to reek_of(:UtilityFunction)
     end
 
     it 'does not report literal' do
@@ -53,12 +95,12 @@ describe Reek::Smells::UtilityFunction do
   end
 
   context 'with only one call' do
-    it 'does not report a call to a parameter' do
-      expect('def simple(arga) arga.to_s end').not_to reek_of(:UtilityFunction,  name: 'simple')
+    it 'reports a call to a parameter' do
+      expect('def simple(arga) arga.to_s end').to reek_of(:UtilityFunction,  name: 'simple')
     end
 
-    it 'does not report a call to a constant' do
-      expect('def simple(arga) FIELDS[arga] end').not_to reek_of(:UtilityFunction)
+    it 'reports a call to a constant' do
+      expect('def simple(arga) FIELDS[arga] end').to reek_of(:UtilityFunction)
     end
   end
 
@@ -66,6 +108,7 @@ describe Reek::Smells::UtilityFunction do
     it 'reports two calls' do
       src = 'def simple(arga) arga.to_s + arga.to_i end'
       expect(src).to reek_of(:UtilityFunction,  name: 'simple')
+      expect(src).not_to reek_of(:FeatureEnvy)
     end
 
     it 'counts a local call in a param initializer' do
@@ -88,7 +131,9 @@ describe Reek::Smells::UtilityFunction do
     end
 
     it 'should report message chain' do
-      expect('def simple(arga) arga.b.c end').to reek_of(:UtilityFunction,  name: 'simple')
+      src = 'def simple(arga) arga.b.c end'
+      expect(src).to reek_of(:UtilityFunction,  name: 'simple')
+      expect(src).not_to reek_of(:FeatureEnvy)
     end
 
     it 'does not report a method that calls super' do
@@ -110,23 +155,4 @@ describe Reek::Smells::UtilityFunction do
       expect(src).not_to reek_of(:UtilityFunction)
     end
   end
-
-  context 'when a smells is reported' do
-    before :each do
-      src = <<-EOS
-        def simple(arga)
-          arga.b.c
-        end
-      EOS
-      source = src.to_reek_source
-      mctx = Reek::Core::TreeWalker.new.process_def(source.syntax_tree)
-      @warning = @detector.examine_context(mctx)[0]   # SMELL: too cumbersome!
-    end
-
-    it_should_behave_like 'common fields set correctly'
-
-    it 'reports the line number of the method' do
-      expect(@warning.lines).to eq([1])
-    end
-  end
 end

data/spec/reek/source/source_code_spec.rb

@@ -1,25 +1,25 @@
-require 'spec_helper'
+require_relative '../../spec_helper'
 require 'stringio'
-require 'reek/source/source_code'
+require_relative '../../../lib/reek/source/source_code'
 
-include Reek::Source
-
-describe SourceCode do
+RSpec.describe Reek::Source::SourceCode do
   describe '#syntax_tree' do
     it 'associates comments with the AST' do
-      source_code = SourceCode.new("# this is\n# a comment\ndef foo; end", '(string)')
+      source = "# this is\n# a comment\ndef foo; end"
+      source_code = Reek::Source::SourceCode.new(source, '(string)')
       result = source_code.syntax_tree
-      expect(result.comments).to eq "# this is\n# a comment"
+      expect(result.leading_comment).to eq "# this is\n# a comment"
     end
 
     it 'cleanly processes empty source' do
-      source_code = SourceCode.new('', '(string)')
+      source_code = Reek::Source::SourceCode.new('', '(string)')
       result = source_code.syntax_tree
       expect(result).to be_nil
     end
 
     it 'cleanly processes empty source with comments' do
-      source_code = SourceCode.new("# this is\n# a comment\n", '(string)')
+      source = "# this is\n# a comment\n"
+      source_code = Reek::Source::SourceCode.new(source, '(string)')
       result = source_code.syntax_tree
       expect(result).to be_nil
     end
@@ -29,7 +29,7 @@ describe SourceCode do
     let(:source_name) { 'Test source' }
     let(:error_message) { 'Error message' }
     let(:parser) { double('parser') }
-    let(:src) { SourceCode.new('', source_name, parser) }
+    let(:src) { Reek::Source::SourceCode.new('', source_name, parser) }
 
     before :each do
       @catcher = StringIO.new

data/spec/reek/source/source_locator_spec.rb

@@ -0,0 +1,30 @@
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/source/source_locator'
+
+RSpec.describe Reek::Source::SourceLocator do
+  describe '#sources' do
+    context 'exclude paths' do
+      let(:config) { 'spec/samples/configuration/with_excluded_paths.reek' }
+      let(:path) { 'spec/samples/source_with_exclude_paths' }
+      let(:files_that_are_expected_to_be_ignored) do
+        [
+          'spec/samples/source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb',
+          'spec/samples/source_with_exclude_paths/nested/ignore_me_as_well/irresponsible_module.rb'
+        ]
+      end
+
+      it 'does not use excluded paths' do
+        with_test_config(config) do
+          sources = described_class.new([path]).sources
+
+          expect(sources.map(&:path).sort).
+            not_to include(files_that_are_expected_to_be_ignored)
+
+          expect(sources.map(&:path).sort).to eq [
+            'spec/samples/source_with_exclude_paths/nested/uncommunicative_parameter_name.rb'
+          ]
+        end
+      end
+    end
+  end
+end

data/spec/reek/spec/should_reek_of_spec.rb

@@ -1,10 +1,7 @@
-require 'spec_helper'
-require 'reek/spec'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/spec'
 
-include Reek
-include Reek::Spec
-
-describe ShouldReekOf do
+RSpec.describe Reek::Spec::ShouldReekOf do
   context 'rdoc demo example' do
     before :each do
       @ruby = 'def double_thing() @other.thing.foo + @other.thing.foo end'
@@ -27,7 +24,8 @@ describe ShouldReekOf do
     before :each do
       @clean_code = 'def good() true; end'
       @smelly_code = 'def x() y = 4; end'
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName,  name: 'y')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              name: 'y')
     end
 
     it 'matches a smelly String' do
@@ -47,7 +45,8 @@ describe ShouldReekOf do
   context 'passing in smell_details with unknown parameter name' do
     before :each do
       @smelly_code = 'def x() y = 4; end'
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName,  foo: 'y')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              foo: 'y')
     end
 
     it 'raises ArgumentError' do
@@ -55,27 +54,12 @@ describe ShouldReekOf do
     end
   end
 
-  context 'checking code in a Dir' do
-    before :each do
-      @clean_dir = Dir['spec/samples/three_clean_files/*.rb']
-      @smelly_dir = Dir['spec/samples/two_smelly_files/*.rb']
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName, name: '@s')
-    end
-
-    it 'matches a smelly String' do
-      expect(@matcher.matches?(@smelly_dir)).to be_truthy
-    end
-
-    it 'doesnt match a fragrant String' do
-      expect(@matcher.matches?(@clean_dir)).to be_falsey
-    end
-  end
-
   context 'checking code in a File' do
     before :each do
       @clean_file = File.new(Dir['spec/samples/three_clean_files/*.rb'][0])
       @smelly_file = File.new(Dir['spec/samples/two_smelly_files/*.rb'][0])
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName, name: '@s')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              name: '@s')
     end
 
     it 'matches a smelly String' do

data/spec/reek/spec/should_reek_only_of_spec.rb

@@ -1,14 +1,11 @@
-require 'spec_helper'
-require 'reek/spec'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/spec'
 
-include Reek
-include Reek::Spec
-
-describe ShouldReekOnlyOf do
+RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   before :each do
     @expected_smell_type = :NestedIterators
     @expected_context_name = 'SmellyClass#big_method'
-    @matcher = ShouldReekOnlyOf.new(@expected_smell_type)
+    @matcher = Reek::Spec::ShouldReekOnlyOf.new(@expected_smell_type)
     @examiner = double('examiner').as_null_object
     expect(@examiner).to receive(:smells) { smells }
     @match = @matcher.matches_examiner?(@examiner)

data/spec/reek/spec/should_reek_spec.rb

@@ -1,11 +1,8 @@
-require 'spec_helper'
-require 'reek/spec'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/spec'
 
-include Reek
-include Reek::Spec
-
-describe ShouldReek do
-  let(:matcher) { ShouldReek.new }
+RSpec.describe Reek::Spec::ShouldReek do
+  let(:matcher) { Reek::Spec::ShouldReek.new }
 
   describe 'checking code in a string' do
     let(:clean_code) { 'def good() true; end' }
@@ -25,31 +22,6 @@ describe ShouldReek do
     end
   end
 
-  describe 'checking code in a Dir' do
-    let(:clean_dir) { Dir['spec/samples/three_clean_files/*.rb'] }
-    let(:smelly_dir) { Dir['spec/samples/two_smelly_files/*.rb'] }
-    let(:masked_dir) { Dir['spec/samples/clean_due_to_masking/*.rb'] }
-
-    it 'matches a smelly Dir' do
-      expect(matcher.matches?(smelly_dir)).to be_truthy
-    end
-
-    it 'doesnt match a fragrant Dir' do
-      expect(matcher.matches?(clean_dir)).to be_falsey
-    end
-
-    it 'masks smells using the relevant configuration' do
-      with_test_config('spec/samples/clean_due_to_masking/masked.reek') do
-        expect(matcher.matches?(masked_dir)).to be_falsey
-      end
-    end
-
-    it 'reports the smells when should_not fails' do
-      matcher.matches?(smelly_dir)
-      expect(matcher.failure_message_when_negated).to match('UncommunicativeVariableName')
-    end
-  end
-
   describe 'checking code in a File' do
     let(:clean_file) { File.new('spec/samples/three_clean_files/clean_one.rb') }
     let(:smelly_file) { File.new('spec/samples/two_smelly_files/dirty_one.rb') }

data/spec/reek/tree_dresser_spec.rb

@@ -0,0 +1,16 @@
+require_relative '../spec_helper'
+require_relative '../../lib/reek/tree_dresser'
+
+RSpec.describe Reek::TreeDresser do
+  let(:ifnode) { ::Parser::AST::Node.new(:if) }
+  let(:sendnode) { ::Parser::AST::Node.new(:send) }
+  let(:dresser) { described_class.new }
+
+  it 'dresses :if sexp with IfNode' do
+    expect(dresser.dress(ifnode, {})).to be_a Reek::AST::SexpExtensions::IfNode
+  end
+
+  it 'dresses :send sexp with SendNode' do
+    expect(dresser.dress(sendnode, {})).to be_a Reek::AST::SexpExtensions::SendNode
+  end
+end

data/spec/reek/{core/tree_walker_spec.rb → tree_walker_spec.rb}

@@ -1,9 +1,7 @@
-require 'spec_helper'
-require 'reek/core/tree_walker'
+require_relative '../spec_helper'
+require_relative '../../lib/reek/tree_walker'
 
-include Reek::Core
-
-describe TreeWalker, 'with no method definitions' do
+RSpec.describe Reek::TreeWalker, 'with no method definitions' do
   it 'reports no problems for empty source code' do
     expect('').not_to reek
   end
@@ -13,14 +11,14 @@ class Fred; end').not_to reek
   end
 end
 
-describe TreeWalker, 'with a global method definition' do
+RSpec.describe Reek::TreeWalker, 'with a global method definition' do
   it 'reports no problems for simple method' do
     src = 'def Outermost::fred() true; end'
     expect(src).not_to reek
   end
 end
 
-describe TreeWalker, 'when a yield is the receiver' do
+RSpec.describe Reek::TreeWalker, 'when a yield is the receiver' do
   it 'reports no problems' do
     src = <<EOS
 def values(*args)

data/spec/samples/checkstyle.xml

@@ -0,0 +1,2 @@
+<?xml version='1.0'?>
+<checkstyle><file name='/some/path'><error column='0' line='1' message='doesn&apos;t depend on instance state' severity='warning' source='UtilityFunction'/><error column='0' line='1' message='has the parameter name &apos;a&apos;' severity='warning' source='UncommunicativeParameterName'/></file></checkstyle>

data/spec/samples/configuration/with_excluded_paths.reek

@@ -0,0 +1,4 @@
+---
+exclude_paths:
+  - spec/samples/source_with_exclude_paths/ignore_me/
+  - spec/samples/source_with_exclude_paths/nested/ignore_me_as_well

data/spec/samples/{overrides/masked/lower.reek → masked_by_dotfile/.reek}

@@ -1,7 +1,9 @@
 ---
 DuplicateMethodCall:
-  enabled: true
+  enabled: false
 UncommunicativeVariableName:
   enabled: false
 UncommunicativeMethodName:
   enabled: false
+UncommunicativeParameterName:
+  enabled: false

data/spec/samples/source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb

@@ -0,0 +1,5 @@
+# Klass comment.
+class Klass
+  def m
+  end
+end

data/spec/samples/source_with_exclude_paths/nested/ignore_me_as_well/irresponsible_module.rb

@@ -0,0 +1,2 @@
+class Klass
+end

data/spec/samples/source_with_exclude_paths/nested/uncommunicative_parameter_name.rb

@@ -0,0 +1,6 @@
+# Klass comment
+class Klass
+  def method(a)
+    a + @x
+  end
+end