reek 2.0.4 → 3.0.0

data/features/reports/reports.feature

@@ -4,50 +4,40 @@ Feature: Correctly formatted reports
   I want to be able to parse reek's output simply and consistently
 
   Scenario Outline: two reports run together with indented smells
+    Given a directory called 'smelly' containing two smelly files
     When I run reek <args>
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings:
-        [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-        [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
-      spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings:
-        [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-        [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
-      12 total warnings
+      smelly/dirty_one.rb -- 2 warnings:
+        [1]:Dirty has no descriptive comment (IrresponsibleModule)
+        [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
+      smelly/dirty_two.rb -- 3 warnings:
+        [1]:Dirty has no descriptive comment (IrresponsibleModule)
+        [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
+        [3]:Dirty#b has the name 'b' (UncommunicativeMethodName)
+      5 total warnings
       """
 
     Examples:
-      | args                               |
-      | spec/samples/two_smelly_files/*.rb |
-      | spec/samples/two_smelly_files      |
+      | args                                    |
+      | smelly/dirty_one.rb smelly/dirty_two.rb |
+      | smelly                                  |
 
   Scenario Outline: No sorting (which means report each file as it is read in)
-    When I run reek <option> spec/samples/three_smelly_files/*.rb
+    Given a directory called 'smelly' containing two smelly files
+    When I run reek <option> smelly
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/three_smelly_files/dirty_one.rb -- 2 warnings:
+      smelly/dirty_one.rb -- 2 warnings:
         [1]:Dirty has no descriptive comment (IrresponsibleModule)
         [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-      spec/samples/three_smelly_files/dirty_three.rb -- 4 warnings:
+      smelly/dirty_two.rb -- 3 warnings:
         [1]:Dirty has no descriptive comment (IrresponsibleModule)
         [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [3]:Dirty#b has the name 'b' (UncommunicativeMethodName)
-        [4]:Dirty#c has the name 'c' (UncommunicativeMethodName)
-      spec/samples/three_smelly_files/dirty_two.rb -- 3 warnings:
-        [1]:Dirty has no descriptive comment (IrresponsibleModule)
-        [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [3]:Dirty#b has the name 'b' (UncommunicativeMethodName)
-      9 total warnings
+      5 total warnings
       """
 
     Examples:
@@ -57,23 +47,19 @@ Feature: Correctly formatted reports
       | --sort-by n    |
 
   Scenario Outline: Sort by issue count
-    When I run reek <option> spec/samples/three_smelly_files/*.rb
+    Given a directory called 'smelly' containing two smelly files
+    When I run reek <option> smelly
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/three_smelly_files/dirty_three.rb -- 4 warnings:
-        [1]:Dirty has no descriptive comment (IrresponsibleModule)
-        [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [3]:Dirty#b has the name 'b' (UncommunicativeMethodName)
-        [4]:Dirty#c has the name 'c' (UncommunicativeMethodName)
-      spec/samples/three_smelly_files/dirty_two.rb -- 3 warnings:
+      smelly/dirty_two.rb -- 3 warnings:
         [1]:Dirty has no descriptive comment (IrresponsibleModule)
         [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [3]:Dirty#b has the name 'b' (UncommunicativeMethodName)
-      spec/samples/three_smelly_files/dirty_one.rb -- 2 warnings:
+      smelly/dirty_one.rb -- 2 warnings:
         [1]:Dirty has no descriptive comment (IrresponsibleModule)
         [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-      9 total warnings
+      5 total warnings
       """
 
     Examples:
@@ -81,27 +67,24 @@ Feature: Correctly formatted reports
       | --sort-by smelliness |
       | --sort-by s          |
 
-  Scenario Outline: good files show no headings by default
-    When I run reek <args>
+  Scenario: good files show no headings by default
+    Given a directory called 'clean_files' containing some clean files
+    When I run reek clean_files
     Then it succeeds
     And it reports:
       """
       0 total warnings
       """
 
-    Examples:
-      | args |
-      | spec/samples/three_clean_files/*.rb |
-      | spec/samples/three_clean_files      |
-
   Scenario Outline: --empty-headings turns on headings for fragrant files
-    When I run reek <option> spec/samples/three_clean_files/*.rb
+    Given a directory called 'clean_files' containing some clean files
+    When I run reek <option> clean_files
     Then it succeeds
     And it reports:
       """
-      spec/samples/three_clean_files/clean_one.rb -- 0 warnings
-      spec/samples/three_clean_files/clean_three.rb -- 0 warnings
-      spec/samples/three_clean_files/clean_two.rb -- 0 warnings
+      clean_files/clean_one.rb -- 0 warnings
+      clean_files/clean_three.rb -- 0 warnings
+      clean_files/clean_two.rb -- 0 warnings
       0 total warnings
       """
 
@@ -111,12 +94,13 @@ Feature: Correctly formatted reports
       | -V                |
 
   Scenario Outline: --no-empty-headings turns off headings for fragrant files
-    When I run reek <option> spec/samples/three_clean_files/*.rb
+    Given a directory called 'clean_files' containing some clean files
+    When I run reek <option> clean_files
     Then it succeeds
     And it reports:
-    """
-    0 total warnings
-    """
+      """
+      0 total warnings
+      """
 
     Examples:
       | option                 |
@@ -124,17 +108,15 @@ Feature: Correctly formatted reports
       | -V --no-empty-headings |
 
   Scenario Outline: --no-line-numbers turns off line numbers
-    When I run reek <option> spec/samples/standard_smelly/dirty.rb
+    Given a smelly file called 'smelly.rb'
+    When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/standard_smelly/dirty.rb -- 6 warnings:
-        Dirty has the variable name '@s' (UncommunicativeVariableName)
-        Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        Dirty#a contains iterators nested 2 deep (NestedIterators)
-        Dirty#a has the name 'a' (UncommunicativeMethodName)
-        Dirty#a has the variable name 'x' (UncommunicativeVariableName)
+      smelly.rb -- 3 warnings:
+        Smelly#m calls @foo.bar 2 times (DuplicateMethodCall)
+        Smelly#m calls puts(@foo.bar) 2 times (DuplicateMethodCall)
+        Smelly#m has the name 'm' (UncommunicativeMethodName)
       """
 
     Examples:
@@ -144,17 +126,15 @@ Feature: Correctly formatted reports
       | -V --no-line-numbers |
 
   Scenario Outline: --line-numbers turns on line numbers
-    When I run reek <option> spec/samples/standard_smelly/dirty.rb
+    Given a smelly file called 'smelly.rb'
+    When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/standard_smelly/dirty.rb -- 6 warnings:
-        [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-        [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
+      smelly.rb -- 3 warnings:
+        [4, 5]:Smelly#m calls @foo.bar 2 times (DuplicateMethodCall)
+        [4, 5]:Smelly#m calls puts(@foo.bar) 2 times (DuplicateMethodCall)
+        [3]:Smelly#m has the name 'm' (UncommunicativeMethodName)
       """
 
     Examples:
@@ -164,17 +144,15 @@ Feature: Correctly formatted reports
       | --no-line-numbers -n             |
 
   Scenario Outline: --single-line shows filename and one line number
-    When I run reek <option> spec/samples/standard_smelly/dirty.rb
+    Given a smelly file called 'smelly.rb'
+    When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/standard_smelly/dirty.rb -- 6 warnings:
-        spec/samples/standard_smelly/dirty.rb:5: Dirty has the variable name '@s' (UncommunicativeVariableName)
-        spec/samples/standard_smelly/dirty.rb:4: Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        spec/samples/standard_smelly/dirty.rb:4: Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        spec/samples/standard_smelly/dirty.rb:5: Dirty#a contains iterators nested 2 deep (NestedIterators)
-        spec/samples/standard_smelly/dirty.rb:3: Dirty#a has the name 'a' (UncommunicativeMethodName)
-        spec/samples/standard_smelly/dirty.rb:5: Dirty#a has the variable name 'x' (UncommunicativeVariableName)
+      smelly.rb -- 3 warnings:
+        smelly.rb:4: Smelly#m calls @foo.bar 2 times (DuplicateMethodCall)
+        smelly.rb:4: Smelly#m calls puts(@foo.bar) 2 times (DuplicateMethodCall)
+        smelly.rb:3: Smelly#m has the name 'm' (UncommunicativeMethodName)
       """
 
     Examples:
@@ -185,41 +163,36 @@ Feature: Correctly formatted reports
       | -V -s         |
 
   Scenario Outline: Extra slashes aren't added to directory names
+    Given a directory called 'smelly' containing two smelly files
     When I run reek <args>
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings:
-        [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-        [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
-      spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings:
-        [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-        [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
-        [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
-      12 total warnings
+      smelly/dirty_one.rb -- 2 warnings:
+        [1]:Dirty has no descriptive comment (IrresponsibleModule)
+        [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
+      smelly/dirty_two.rb -- 3 warnings:
+        [1]:Dirty has no descriptive comment (IrresponsibleModule)
+        [2]:Dirty#a has the name 'a' (UncommunicativeMethodName)
+        [3]:Dirty#b has the name 'b' (UncommunicativeMethodName)
+      5 total warnings
       """
 
     Examples:
-      | args |
-      | spec/samples/two_smelly_files/ |
-      | spec/samples/two_smelly_files  |
+      | args    |
+      | smelly/ |
+      | smelly  |
 
   Scenario Outline: -U or --wiki-links adds helpful links to smell warnings
-    When I run reek <option> spec/samples/one_smelly_file/dirty.rb
+    Given a smelly file called 'smelly.rb'
+    When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/one_smelly_file/dirty.rb -- 3 warnings:
-        [1]:D has no descriptive comment (IrresponsibleModule) [https://github.com/troessner/reek/wiki/Irresponsible-Module]
-        [1]:D has the name 'D' (UncommunicativeModuleName) [https://github.com/troessner/reek/wiki/Uncommunicative-Module-Name]
-        [2]:D#a has the name 'a' (UncommunicativeMethodName) [https://github.com/troessner/reek/wiki/Uncommunicative-Method-Name]
+      smelly.rb -- 3 warnings:
+        [4, 5]:Smelly#m calls @foo.bar 2 times (DuplicateMethodCall) [https://github.com/troessner/reek/wiki/Duplicate-Method-Call]
+        [4, 5]:Smelly#m calls puts(@foo.bar) 2 times (DuplicateMethodCall) [https://github.com/troessner/reek/wiki/Duplicate-Method-Call]
+        [3]:Smelly#m has the name 'm' (UncommunicativeMethodName) [https://github.com/troessner/reek/wiki/Uncommunicative-Method-Name]
       """
 
     Examples:
@@ -228,14 +201,15 @@ Feature: Correctly formatted reports
       | --wiki-links  |
 
   Scenario Outline: --wiki-links is independent of --line-numbers
-    When I run reek <option> spec/samples/one_smelly_file/dirty.rb
+    Given a smelly file called 'smelly.rb'
+    When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/one_smelly_file/dirty.rb -- 3 warnings:
-        D has no descriptive comment (IrresponsibleModule) [https://github.com/troessner/reek/wiki/Irresponsible-Module]
-        D has the name 'D' (UncommunicativeModuleName) [https://github.com/troessner/reek/wiki/Uncommunicative-Module-Name]
-        D#a has the name 'a' (UncommunicativeMethodName) [https://github.com/troessner/reek/wiki/Uncommunicative-Method-Name]
+      smelly.rb -- 3 warnings:
+        Smelly#m calls @foo.bar 2 times (DuplicateMethodCall) [https://github.com/troessner/reek/wiki/Duplicate-Method-Call]
+        Smelly#m calls puts(@foo.bar) 2 times (DuplicateMethodCall) [https://github.com/troessner/reek/wiki/Duplicate-Method-Call]
+        Smelly#m has the name 'm' (UncommunicativeMethodName) [https://github.com/troessner/reek/wiki/Uncommunicative-Method-Name]
       """
 
     Examples:

data/features/reports/yaml.feature

@@ -3,7 +3,8 @@ Feature: Report smells using simple YAML layout
   output a list of smells in Yaml.
 
   Scenario: output is empty when there are no smells
-    When I run reek --format yaml spec/samples/three_clean_files
+    Given a directory called 'clean_files' containing some clean files
+    When I run reek --format yaml clean_files
     Then it succeeds
     And it reports this yaml:
     """
@@ -11,33 +12,38 @@ Feature: Report smells using simple YAML layout
     """
 
   Scenario: Indicate smells and print them as yaml when using files
-    When I run reek --format yaml spec/samples/standard_smelly/minimal_dirty.rb
+    Given a smelly file called 'smelly.rb'
+    When I run reek --format yaml smelly.rb
     Then the exit status indicates smells
     And it reports this yaml:
       """
       ---
-      - smell_category: IrresponsibleModule
-        smell_type: IrresponsibleModule
-        source: spec/samples/standard_smelly/minimal_dirty.rb
-        context: C
+      - smell_category: Duplication
+        smell_type: DuplicateMethodCall
+        source: smelly.rb
+        context: Smelly#m
         lines:
-        - 1
-        message: has no descriptive comment
-        name: C
-      - smell_category: UncommunicativeName
-        smell_type: UncommunicativeModuleName
-        source: spec/samples/standard_smelly/minimal_dirty.rb
-        context: C
+        - 4
+        - 5
+        message: calls @foo.bar 2 times
+        name: "@foo.bar"
+        count: 2
+      - smell_category: Duplication
+        smell_type: DuplicateMethodCall
+        source: smelly.rb
+        context: Smelly#m
         lines:
-        - 1
-        message: has the name 'C'
-        name: C
+        - 4
+        - 5
+        message: calls puts(@foo.bar) 2 times
+        name: puts(@foo.bar)
+        count: 2
       - smell_category: UncommunicativeName
         smell_type: UncommunicativeMethodName
-        source: spec/samples/standard_smelly/minimal_dirty.rb
-        context: C#m
+        source: smelly.rb
+        context: Smelly#m
         lines:
-        - 2
+        - 3
         message: has the name 'm'
         name: m
       """
@@ -50,7 +56,7 @@ Feature: Report smells using simple YAML layout
       ---
       - smell_category: IrresponsibleModule
         smell_type: IrresponsibleModule
-        source: "$stdin"
+        source: "STDIN"
         context: Turn
         lines:
         - 1

data/features/samples.feature

@@ -4,19 +4,21 @@ Feature: Basic smell detection
   I want to detect the smells in my Ruby code
 
   Scenario: Correct smells from inline.rb
-    When I run reek --no-line-numbers spec/samples/inline.rb
+    Given the "inline.rb" sample file exists
+    When I run reek --no-line-numbers inline.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/inline.rb -- 44 warnings:
+    inline.rb -- 45 warnings:
       CompilationError has no descriptive comment (IrresponsibleModule)
+      Dir has no descriptive comment (IrresponsibleModule)
       File has no descriptive comment (IrresponsibleModule)
       File#self.write_with_backup has approx 6 statements (TooManyStatements)
       Inline declares the class variable @@directory (ClassVariable)
       Inline declares the class variable @@rootdir (ClassVariable)
       Inline#self.rootdir calls env.nil? 2 times (DuplicateMethodCall)
       Inline#self.rootdir has approx 8 statements (TooManyStatements)
-      Inline#self.rootdir performs a nil-check. (NilCheck)
+      Inline#self.rootdir performs a nil-check (NilCheck)
       Inline::C declares the class variable @@type_map (ClassVariable)
       Inline::C has at least 13 instance variables (TooManyInstanceVariables)
       Inline::C takes parameters [options, src] to 5 methods (DataClump)
@@ -49,18 +51,19 @@ Feature: Basic smell detection
       Inline::C#parse_signature has the variable name 'x' (UncommunicativeVariableName)
       Inline::C#parse_signature is controlled by argument raw (ControlParameter)
       Inline::C#strip_comments doesn't depend on instance state (UtilityFunction)
-      Inline::C#strip_comments refers to src more than self (FeatureEnvy)
+      Module has no descriptive comment (IrresponsibleModule)
       Module#inline calls Inline.const_get(lang) 2 times (DuplicateMethodCall)
       Module#inline calls options[:testing] 2 times (DuplicateMethodCall)
       Module#inline has approx 12 statements (TooManyStatements)
     """
 
   Scenario: Correct smells from optparse.rb
-    When I run reek --no-line-numbers spec/samples/optparse.rb
+    Given the "optparse.rb" sample file exists
+    When I run reek --no-line-numbers optparse.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/optparse.rb -- 111 warnings:
+    optparse.rb -- 111 warnings:
       OptionParser has at least 42 methods (TooManyMethods)
       OptionParser has the variable name 'f' (UncommunicativeVariableName)
       OptionParser has the variable name 'k' (UncommunicativeVariableName)
@@ -100,7 +103,7 @@ Feature: Basic smell detection
       OptionParser#make_switch has the variable name 'q' (UncommunicativeVariableName)
       OptionParser#make_switch has the variable name 's' (UncommunicativeVariableName)
       OptionParser#make_switch has the variable name 'v' (UncommunicativeVariableName)
-      OptionParser#make_switch performs a nil-check. (NilCheck)
+      OptionParser#make_switch performs a nil-check (NilCheck)
       OptionParser#order calls argv[0] 2 times (DuplicateMethodCall)
       OptionParser#order refers to argv more than self (FeatureEnvy)
       OptionParser#parse calls argv[0] 2 times (DuplicateMethodCall)
@@ -118,7 +121,7 @@ Feature: Basic smell detection
       OptionParser#permute refers to argv more than self (FeatureEnvy)
       OptionParser#permute! has approx 6 statements (TooManyStatements)
       OptionParser#search has the variable name 'k' (UncommunicativeVariableName)
-      OptionParser#self.inc performs a nil-check. (NilCheck)
+      OptionParser#self.inc performs a nil-check (NilCheck)
       OptionParser#summarize has 4 parameters (LongParameterList)
       OptionParser#summarize has the variable name 'l' (UncommunicativeVariableName)
       OptionParser#summarize is controlled by argument blk (ControlParameter)
@@ -175,11 +178,12 @@ Feature: Basic smell detection
     """
 
   Scenario: Correct smells from redcloth.rb
-    When I run reek --no-line-numbers spec/samples/redcloth.rb
+    Given the "redcloth.rb" sample file exists
+    When I run reek --no-line-numbers redcloth.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/redcloth.rb -- 98 warnings:
+    redcloth.rb -- 95 warnings:
       RedCloth has at least 44 methods (TooManyMethods)
       RedCloth has the variable name 'a' (UncommunicativeVariableName)
       RedCloth has the variable name 'b' (UncommunicativeVariableName)
@@ -191,7 +195,7 @@ Feature: Basic smell detection
       RedCloth#block_markdown_atx refers to text more than self (FeatureEnvy)
       RedCloth#block_markdown_bq has approx 6 statements (TooManyStatements)
       RedCloth#block_markdown_lists has unused parameter 'text' (UnusedParameters)
-      RedCloth#block_markdown_rule refers to text more than self (FeatureEnvy)
+      RedCloth#block_markdown_rule doesn't depend on instance state (UtilityFunction)
       RedCloth#block_markdown_setext refers to text more than self (FeatureEnvy)
       RedCloth#block_textile_lists calls depth.last 5 times (DuplicateMethodCall)
       RedCloth#block_textile_lists calls depth.last.length 2 times (DuplicateMethodCall)
@@ -218,18 +222,15 @@ Feature: Basic smell detection
       RedCloth#clean_html has approx 15 statements (TooManyStatements)
       RedCloth#clean_html has the variable name 'q' (UncommunicativeVariableName)
       RedCloth#clean_html has the variable name 'q2' (UncommunicativeVariableName)
-      RedCloth#clean_html refers to raw more than self (FeatureEnvy)
-      RedCloth#clean_html refers to tags more than self (FeatureEnvy)
       RedCloth#clean_white_space has approx 7 statements (TooManyStatements)
       RedCloth#clean_white_space refers to text more than self (FeatureEnvy)
       RedCloth#flush_left doesn't depend on instance state (UtilityFunction)
-      RedCloth#flush_left refers to text more than self (FeatureEnvy)
-      RedCloth#footnote_ref refers to text more than self (FeatureEnvy)
+      RedCloth#footnote_ref doesn't depend on instance state (UtilityFunction)
       RedCloth#glyphs_textile has approx 10 statements (TooManyStatements)
+      RedCloth#h_align doesn't depend on instance state (UtilityFunction)
       RedCloth#htmlesc doesn't depend on instance state (UtilityFunction)
       RedCloth#htmlesc is controlled by argument mode (ControlParameter)
-      RedCloth#htmlesc refers to str more than self (FeatureEnvy)
-      RedCloth#incoming_entities refers to text more than self (FeatureEnvy)
+      RedCloth#incoming_entities doesn't depend on instance state (UtilityFunction)
       RedCloth#initialize has the variable name 'r' (UncommunicativeVariableName)
       RedCloth#inline contains iterators nested 2 deep (NestedIterators)
       RedCloth#inline_markdown_link has approx 6 statements (TooManyStatements)
@@ -246,11 +247,10 @@ Feature: Basic smell detection
       RedCloth#inline_textile_span contains iterators nested 2 deep (NestedIterators)
       RedCloth#inline_textile_span has approx 9 statements (TooManyStatements)
       RedCloth#inline_textile_span has the variable name 'm' (UncommunicativeVariableName)
+      RedCloth#lT doesn't depend on instance state (UtilityFunction)
       RedCloth#lT has the name 'lT' (UncommunicativeMethodName)
       RedCloth#lT is controlled by argument text (ControlParameter)
-      RedCloth#lT refers to text more than self (FeatureEnvy)
       RedCloth#no_textile doesn't depend on instance state (UtilityFunction)
-      RedCloth#no_textile refers to text more than self (FeatureEnvy)
       RedCloth#pba calls $1.length 2 times (DuplicateMethodCall)
       RedCloth#pba has approx 21 statements (TooManyStatements)
       RedCloth#pba is controlled by argument element (ControlParameter)
@@ -278,22 +278,17 @@ Feature: Basic smell detection
       RedCloth#textile_popup_help has the parameter name 'windowH' (UncommunicativeParameterName)
       RedCloth#textile_popup_help has the parameter name 'windowW' (UncommunicativeParameterName)
       RedCloth#to_html has approx 26 statements (TooManyStatements)
+      RedCloth#v_align doesn't depend on instance state (UtilityFunction)
     """
 
-  Scenario: Correct smells from a source file with Ruby 2.0 specific syntax
-    When I run reek spec/samples/ruby20_syntax.rb
+  Scenario: Correct smells from a source file with unusual syntax samples
+    Given the "unusual_syntax.rb" sample file exists
+    When I run reek unusual_syntax.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/ruby20_syntax.rb -- 1 warning:
-      [1]:SomeClass has no descriptive comment (IrresponsibleModule)
-    """
-
-  Scenario: Correct smells from a source file with Ruby 2.1 specific syntax
-    When I run reek spec/samples/ruby21_syntax.rb
-    Then the exit status indicates smells
-    And it reports:
-    """
-    spec/samples/ruby21_syntax.rb -- 1 warning:
+    unusual_syntax.rb -- 3 warnings:
       [1]:SomeClass has no descriptive comment (IrresponsibleModule)
+      [18]:SomeClass#method_with_array_decomposition has the parameter name 'a' (UncommunicativeParameterName)
+      [18]:SomeClass#method_with_array_decomposition has the parameter name 'b' (UncommunicativeParameterName)
     """

data/features/step_definitions/.rubocop.yml

@@ -0,0 +1,5 @@
+inherit_from: ../../.rubocop.yml
+
+# Allow common When <regexp> syntax
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false

data/features/step_definitions/reek_steps.rb

@@ -11,81 +11,69 @@ When /^I run rake (\w*) with:$/ do |name, task_def|
 end
 
 Then /^it reports nothing$/ do
-  expect(@last_stdout).to eq ''
+  assert_exact_output '', all_stdout
 end
 
 Then /^there is no output on stdout$/ do
-  expect(@last_stdout).to eq ''
+  assert_exact_output '', all_stdout
 end
 
 Then /^stdout includes "(.*)"$/ do |text|
-  expect(@last_stdout).to include text
+  assert_partial_output(text, all_stdout)
 end
 
 Then /^it succeeds$/ do
-  expect(@last_exit_status).to eq Reek::Cli::Application::STATUS_SUCCESS
+  assert_exit_status Reek::CLI::Application::STATUS_SUCCESS
 end
 
 Then /^the exit status indicates an error$/ do
-  expect(@last_exit_status).to eq Reek::Cli::Application::STATUS_ERROR
+  assert_exit_status Reek::CLI::Application::STATUS_ERROR
 end
 
 Then /^the exit status indicates smells$/ do
-  expect(@last_exit_status).to eq Reek::Cli::Application::STATUS_SMELLS
+  assert_exit_status Reek::CLI::Application::STATUS_SMELLS
 end
 
 Then /^it reports:$/ do |report|
-  expect(@last_stdout).to eq "#{report}\n"
+  assert_exact_output "#{report}\n", all_stdout
 end
 
 Then /^it reports this yaml:$/ do |expected_yaml|
   expected_warnings = YAML.load(expected_yaml.chomp)
-  actual_warnings = YAML.load(@last_stdout)
+  actual_warnings = YAML.load(all_stdout)
   expect(actual_warnings).to eq expected_warnings
 end
 
 Then /^it reports this JSON:$/ do |expected_json|
   expected_warnings = JSON.parse(expected_json.chomp)
-  actual_warnings = JSON.parse(@last_stdout)
+  actual_warnings = JSON.parse(all_stdout)
   expect(actual_warnings).to eq expected_warnings
 end
 
 Then /^stderr reports:$/ do |report|
-  expect(@last_stderr).to eq report
+  assert_exact_output report, all_stderr
 end
 
 Then /^it reports no errors$/ do
-  expect(@last_stderr.chomp).to eq ''
+  assert_exact_output '', all_stderr
 end
 
 Then /^it reports an error$/ do
-  expect(@last_stderr.chomp).to_not be_empty
+  expect(all_stderr).to_not be_empty
 end
 
 Then /^it reports the error ['"](.*)['"]$/ do |string|
-  expect(@last_stderr.chomp).to eq string
+  assert_partial_output string, all_stderr
 end
 
 Then /^it reports a parsing error$/ do
-  expect(@last_stderr.chomp).to match(/Parser::SyntaxError/)
+  assert_partial_output 'Parser::SyntaxError', all_stderr
 end
 
 Then /^it should indicate the line numbers of those smells$/ do
-  expect(@last_stdout.chomp).to match(/\[.*\]:/)
+  assert_matching_output /\[.*\]:/, all_stdout
 end
 
 Then /^it reports the current version$/ do
-  expect(@last_stdout).to eq "reek #{Reek::Version::STRING}\n"
-end
-
-Given(/^"(.*?)" exists in the working directory$/) do |path|
-  FileUtils.cp path, Pathname.pwd
-end
-
-Given(/^"(.*?)" exists in the parent directory of the working directory$/) do |path|
-  FileUtils.cp path, Pathname.pwd.parent
-end
-
-Given(/^"(.*?)" exists in the HOME directory$/) do |path|
-  FileUtils.cp path, Pathname.new(Dir.home)
+  assert_exact_output "reek #{Reek::Version::STRING}\n", all_stdout
 end