rbeapi 1.0 → 1.1

data/spec/unit/rbeapi/api/alias/fixture_alias.text

@@ -0,0 +1,3 @@
+alias Alias1 my command
+alias Alias2 my command 2
+alias Alias3 1 conf\n2 int %1\n3 description %2\n4 end\nend

data/spec/unit/rbeapi/api/bgp/bgp_neighbors_spec.rb

@@ -67,8 +67,7 @@ describe Rbeapi::Api::BgpNeighbors do
           shutdown: true, description: nil, next_hop_self: true,
           route_map_in: nil, route_map_out: nil
         }
-      }
-    }
+      } }
   end
   let(:bgp_as) { test[:bgp_as] }
 

data/spec/unit/rbeapi/api/bgp/bgp_spec.rb

@@ -67,8 +67,7 @@ describe Rbeapi::Api::Bgp do
           shutdown: true, description: nil, next_hop_self: true,
           route_map_in: nil, route_map_out: nil
         }
-      }
-    }
+      } }
   end
   let(:bgp_as) { test[:bgp_as] }
 

data/spec/unit/rbeapi/api/interfaces/base_spec.rb

@@ -23,7 +23,7 @@ describe Rbeapi::Api::BaseInterface do
     let(:resource) { subject.get('Loopback0') }
 
     let(:keys) do
-      [:type, :shutdown, :load_interval, :description, :name]
+      [:type, :shutdown, :load_interval, :description, :encapsulation, :name]
     end
 
     it 'returns an ethernet resource as a hash' do

data/spec/unit/rbeapi/api/interfaces/ethernet_spec.rb

@@ -24,7 +24,8 @@ describe Rbeapi::Api::EthernetInterface do
 
     let(:keys) do
       [:type, :speed, :sflow, :flowcontrol_send, :flowcontrol_receive,
-       :shutdown, :description, :name, :load_interval, :lacp_priority]
+       :shutdown, :description, :encapsulation, :name, :load_interval,
+       :lacp_priority]
     end
 
     it 'returns an ethernet resource as a hash' do
@@ -86,4 +87,37 @@ describe Rbeapi::Api::EthernetInterface do
                                                   default: true)).to be_truthy
     end
   end
+
+  describe '#set_encapsulation' do
+    it 'sets the interface encapsulation' do
+      expect(node).to receive(:config).with(['interface Ethernet1.1',
+                                             'encapsulation dot1q vlan 10'])
+      expect(subject.set_encapsulation('Ethernet1.1', value: '10'))
+        .to be_truthy
+    end
+
+    it 'negates the interface encapsulation' do
+      expect(node).to receive(:config).with(['interface Ethernet1.1',
+                                             'no encapsulation dot1q vlan'])
+      expect(subject.set_encapsulation('Ethernet1.1',
+                                       enable: false)).to be_truthy
+    end
+
+    it 'defaults the interface encapsulation' do
+      expect(node).to receive(:config)
+        .with(['interface Ethernet1.1',
+               'default encapsulation dot1q vlan'])
+      expect(subject.set_encapsulation('Ethernet1.1',
+                                       default: true)).to be_truthy
+    end
+
+    it 'default is preferred over enable' do
+      expect(node).to receive(:config)
+        .with(['interface Ethernet1.1',
+               'default encapsulation dot1q vlan'])
+      expect(subject.set_encapsulation('Ethernet1.1',
+                                       enable: false,
+                                       default: true)).to be_truthy
+    end
+  end
 end

data/spec/unit/rbeapi/api/interfaces/fixture_interfaces.text

@@ -217,3 +217,71 @@ interface Port-Channel1
    mlag 1
    spanning-tree portfast
 !
+interface Vlan1
+   no description
+   no shutdown
+   default load-interval
+   mtu 1500
+   logging event link-status use-global
+   autostate
+   snmp trap link-status
+   no ip proxy-arp
+   no ip local-proxy-arp
+   no ip address
+   no ip verify unicast
+   default arp timeout 14400
+   default ipv6 nd cache expire 14400
+   bfd interval 300 min_rx 300 multiplier 3
+   no bfd echo
+   default ip dhcp smart-relay
+   no ip helper-address
+   no ipv6 dhcp relay destination
+   ip dhcp relay information option circuit-id Vlan1
+   no ip igmp
+   ip igmp version 3
+   ip igmp last-member-query-count 2
+   ip igmp last-member-query-interval 10
+   ip igmp query-max-response-time 100
+   ip igmp query-interval 125
+   ip igmp startup-query-count 2
+   ip igmp startup-query-interval 310
+   ip igmp router-alert optional connected
+   no ip igmp host-proxy
+   no ipv6 enable
+   no ipv6 address
+   no ipv6 verify unicast
+   no ipv6 nd ra suppress
+   ipv6 nd ra interval msec 200000
+   ipv6 nd ra lifetime 1800
+   no ipv6 nd ra mtu suppress
+   no ipv6 nd managed-config-flag
+   no ipv6 nd other-config-flag
+   ipv6 nd reachable-time 0
+   ipv6 nd router-preference medium
+   ipv6 nd ra dns-servers lifetime 300
+   ipv6 nd ra dns-suffixes lifetime 300
+   ipv6 nd ra hop-limit 64
+   no ip multicast static
+   ip mfib fastdrop
+   default ntp serve
+   default ip ospf bfd
+   ip ospf cost 10
+   ip ospf dead-interval 40
+   ip ospf hello-interval 10
+   ip ospf priority 1
+   ip ospf retransmit-interval 5
+   no ip ospf shutdown
+   ip ospf transmit-delay 1
+   no ip ospf authentication
+   no ip ospf mtu-ignore
+   no ip pim sparse-mode
+   no ip pim bidirectional
+   no ip pim border-router
+   ip pim query-interval 30
+   ip pim query-count 3.5
+   ip pim join-prune-interval 60
+   ip pim dr-priority 1
+   no ip pim neighbor-filter
+   default ip pim bfd-instance
+   no ip pim bsr-border
+!

data/spec/unit/rbeapi/api/interfaces/portchannel_spec.rb

@@ -31,8 +31,8 @@ describe Rbeapi::Api::PortchannelInterface do
     let(:resource) { subject.get('Port-Channel1') }
 
     let(:keys) do
-      [:type, :shutdown, :load_interval, :description, :name, :members,
-       :lacp_mode, :minimum_links, :lacp_timeout, :lacp_fallback]
+      [:type, :shutdown, :load_interval, :description, :encapsulation, :name,
+       :members, :lacp_mode, :minimum_links, :lacp_timeout, :lacp_fallback]
     end
 
     it 'returns an ethernet resource as a hash' do
@@ -111,6 +111,40 @@ describe Rbeapi::Api::PortchannelInterface do
     end
   end
 
+  describe '#set_encapsulation' do
+    it 'sets the interface encapsulation' do
+      expect(node).to receive(:config)
+        .with(['interface Port-Channel1.1', 'encapsulation dot1q vlan 10'])
+
+      expect(subject.set_encapsulation('Port-Channel1.1', value: '10'))
+        .to be_truthy
+    end
+
+    it 'negates the interface encapsulation' do
+      expect(node).to receive(:config)
+        .with(['interface Port-Channel1.1', 'no encapsulation dot1q vlan'])
+
+      expect(subject.set_encapsulation('Port-Channel1.1',
+                                       enable: false)).to be_truthy
+    end
+
+    it 'defaults the interface encapsulation' do
+      expect(node).to receive(:config)
+        .with(['interface Port-Channel1.1', 'default encapsulation dot1q vlan'])
+
+      expect(subject.set_encapsulation('Port-Channel1.1', default: true))
+        .to be_truthy
+    end
+
+    it 'default is preferred over enable' do
+      expect(node).to receive(:config)
+        .with(['interface Port-Channel1.1', 'default encapsulation dot1q vlan'])
+
+      opts = { enable: false, default: true }
+      expect(subject.set_encapsulation('Port-Channel1.1', opts)).to be_truthy
+    end
+  end
+
   describe '#set_shutdown' do
     it 'enables the interface' do
       expect(node).to receive(:config)
@@ -144,8 +178,11 @@ describe Rbeapi::Api::PortchannelInterface do
 
   describe '#set_members' do
     it 'raises an ArgumentError if members is not an array' do
-      expect { subject.set_members('Port-Channel1', 'Ethernet3') }.to \
-        raise_error(ArgumentError)
+      expect do
+        subject.set_members('Port-Channel1',
+                            'Ethernet3')
+      end
+        .to raise_error(ArgumentError)
     end
   end
 end

data/spec/unit/rbeapi/api/interfaces/vlan_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+
+require 'rbeapi/api/interfaces'
+
+include FixtureHelpers
+
+describe Rbeapi::Api::VlanInterface do
+  subject { described_class.new(node) }
+
+  let(:node) { double('node') }
+
+  def interfaces
+    interfaces = Fixtures[:interfaces]
+    return interfaces if interfaces
+    fixture('interfaces', format: :text, dir: File.dirname(__FILE__))
+  end
+
+  before :each do
+    allow(subject.node).to receive(:running_config).and_return(interfaces)
+  end
+
+  describe '#get' do
+    let(:resource) { subject.get('Vlan1') }
+
+    let(:keys) do
+      [:type, :shutdown, :load_interval, :description, :name, :autostate,
+       :encapsulation]
+    end
+
+    it 'returns the resource as a hash' do
+      expect(resource).to be_a_kind_of(Hash)
+    end
+
+    it 'returns an interface type of vlan' do
+      expect(resource[:type]).to eq('vlan')
+    end
+
+    it 'has all keys' do
+      expect(resource.keys).to match_array(keys)
+    end
+  end
+
+  describe '#create' do
+    it 'creates the interface in the config' do
+      expect(node).to receive(:config).with('interface Vlan1')
+      expect(subject.create('Vlan1')).to be_truthy
+    end
+  end
+
+  describe '#delete' do
+    it 'deletes the interface in the config' do
+      expect(node).to receive(:config).with('no interface Vlan1')
+      expect(subject.delete('Vlan1')).to be_truthy
+    end
+  end
+
+  describe '#default' do
+    it 'defaults the interface config' do
+      expect(node).to receive(:config).with('default interface Vlan1')
+      expect(subject.default('Vlan1')).to be_truthy
+    end
+  end
+
+  describe '#set_autostate' do
+    it 'sets the autostate' do
+      commands = ['interface Vlan1', 'autostate']
+      opts = { value: :true }
+      expect(node).to receive(:config).with(commands)
+      expect(subject.set_autostate('Vlan1', opts)).to be_truthy
+    end
+  end
+end

data/spec/unit/rbeapi/api/interfaces/vxlan_spec.rb

@@ -23,8 +23,8 @@ describe Rbeapi::Api::VxlanInterface do
     let(:resource) { subject.get('Vxlan1') }
 
     let(:keys) do
-      [:type, :shutdown, :load_interval, :description, :name, :source_interface,
-       :multicast_group, :udp_port, :flood_list, :vlans]
+      [:type, :shutdown, :load_interval, :description, :encapsulation, :name,
+       :source_interface, :multicast_group, :udp_port, :flood_list, :vlans]
     end
 
     it 'returns the resource as a hash' do

data/spec/unit/rbeapi/api/managementdefaults/default_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+require 'rbeapi/api/managementdefaults'
+
+include FixtureHelpers
+
+describe Rbeapi::Api::Managementdefaults do
+  subject { described_class.new(node) }
+
+  let(:node) { double('node') }
+
+  def managementdefaults
+    managementdefaults = Fixtures[:managementdefaults]
+    return managementdefaults if managementdefaults
+    fixture('managementdefaults', format: :text, dir: File.dirname(__FILE__))
+  end
+
+  before :each do
+    allow(subject.node).to receive(:running_config)
+      .and_return(managementdefaults)
+  end
+
+  describe '#get' do
+    let(:keys) { [:secret_hash] }
+
+    it 'returns the management defaults resource hash with all keys' do
+      expect(subject.get.keys).to match_array(keys)
+    end
+  end
+
+  describe '#set_secret_hash' do
+    it 'sets the secret_hash to sha512' do
+      expect(node).to receive(:config).with(['management defaults',
+                                             'secret hash sha512'])
+      expect(subject.set_secret_hash(value: 'sha512')).to be_truthy
+    end
+
+    it 'sets the secret_hash to md5' do
+      expect(node).to receive(:config).with(['management defaults',
+                                             'secret hash md5'])
+      expect(subject.set_secret_hash(value: 'md5')).to be_truthy
+    end
+
+    it 'defaults the secret_hash' do
+      expect(node).to receive(:config).with(['management defaults',
+                                             'secret hash '])
+      expect(subject.set_secret_hash(default: true)).to be_truthy
+    end
+  end
+end

data/spec/unit/rbeapi/api/managementdefaults/fixture_managementdefaults.yaml

@@ -0,0 +1 @@
+sha512

data/spec/unit/rbeapi/api/prefixlists/default_spec.rb

@@ -51,43 +51,49 @@ describe Rbeapi::Api::Prefixlists do
   end
 
   describe '#get' do
-    let(:resource) { subject.get('test1') }
-
-    let(:prefixlist) do
-        [{
-          'seq' => '10',
-          'action' => 'permit',
-          'prefix' => '1.2.3.0/24'
-        },
-        {
-          'seq' => '20',
-          'action' => 'permit',
-          'prefix' => '2.3.4.0/24 le 30'
-        },
-        {
-          'seq' => '30',
-          'action' => 'permit',
-          'prefix' => '3.4.5.0/24 ge 26 le 30'
-        }]
-    end
-
-    let(:keys) { ['seq', 'action', 'prefix'] }
-
-    it 'returns the prefix list for an existing name' do
-      expect(resource).to eq(prefixlist)
-    end
-
-    it 'returns an array of prefixes' do
-      expect(resource).to be_a_kind_of(Array)
-    end
-
-    it 'has three prefixes' do
-      expect(resource.size).to eq(3)
-    end
-
-    it 'has all keys' do
-      resource.each do |prefix|
-        expect(prefix.keys).to match_array(keys)
+    let(:keys) { %w(seq action prefix) }
+
+    [
+      { title: 'single-line',
+        prefix_list: 'test5',
+        rules: [{ 'seq' => '10',
+                  'action' => 'permit',
+                  'prefix' => '10.50.1.0/24' },
+                { 'seq' => '20',
+                  'action' => 'permit',
+                  'prefix' => '10.50.2.0/24' }] },
+      { title: 'multi-line',
+        prefix_list: 'test1',
+        rules: [{ 'seq' => '10',
+                  'action' => 'permit',
+                  'prefix' => '10.10.1.0/24' },
+                { 'seq' => '20',
+                  'action' => 'permit',
+                  'prefix' => '10.20.1.0/24 le 30' },
+                { 'seq' => '30',
+                  'action' => 'permit',
+                  'prefix' => '10.30.1.0/24 ge 26 le 30' }] }
+    ].each do |context|
+      context "when prefix list is #{context[:title]}" do
+        let(:resource) { subject.get(context[:prefix_list]) }
+
+        it 'returns the correct rules' do
+          expect(resource).to eq(context[:rules])
+        end
+
+        it 'returns an array of rules' do
+          expect(resource).to be_a_kind_of(Array)
+        end
+
+        it "has #{context[:rules].size} rules" do
+          expect(resource.size).to eq(context[:rules].size)
+        end
+
+        it 'has all keys' do
+          resource.each do |rule|
+            expect(rule.keys).to match_array(keys)
+          end
+        end
       end
     end
 
@@ -101,37 +107,40 @@ describe Rbeapi::Api::Prefixlists do
     let(:resource) { subject.getall }
 
     let(:plists) do
-      { 
-        "test1" => [
-          {
-            "seq" => "10",
-            "action" => "permit",
-            "prefix" => "1.2.3.0/24"
-          },
-          {
-            "seq" => "20",
-            "action" => "permit",
-            "prefix" => "2.3.4.0/24 le 30"
-          },
-          {
-            "seq" => "30",
-            "action" => "permit",
-            "prefix" => "3.4.5.0/24 ge 26 le 30"
-          }
+      {
+        'test1' => [
+          { 'seq' => '10',
+            'action' => 'permit',
+            'prefix' => '10.10.1.0/24' },
+          { 'seq' => '20',
+            'action' => 'permit',
+            'prefix' => '10.20.1.0/24 le 30' },
+          { 'seq' => '30',
+            'action' => 'permit',
+            'prefix' => '10.30.1.0/24 ge 26 le 30' }
         ],
-        "test2" => [
-          {
-            "seq" => "10",
-            "action" => "permit",
-            "prefix" => "10.11.0.0/16"
-          },
-          {
-            "seq" => "20",
-            "action" => "permit",
-            "prefix" => "10.12.0.0/16 le 24"
-          }
+        'test2' => [
+          { 'seq' => '10',
+            'action' => 'permit',
+            'prefix' => '10.11.0.0/16' },
+          { 'seq' => '20',
+            'action' => 'permit',
+            'prefix' => '10.12.0.0/16 le 24' }
         ],
-        "test3" => []
+        'test3' => [],
+        'test4' => [
+          { 'seq' => '10',
+            'action' => 'permit',
+            'prefix' => '10.14.0.0/16 le 20' }
+        ],
+        'test5' => [
+          { 'seq' => '10',
+            'action' => 'permit',
+            'prefix' => '10.50.1.0/24' },
+          { 'seq' => '20',
+            'action' => 'permit',
+            'prefix' => '10.50.2.0/24' }
+        ]
       }
     end
 
@@ -143,8 +152,8 @@ describe Rbeapi::Api::Prefixlists do
       expect(resource).to be_a_kind_of(Hash)
     end
 
-    it 'has three prefix lists' do
-      expect(resource.size).to eq(3)
+    it 'has five prefix lists' do
+      expect(resource.size).to eq(5)
     end
   end
 
@@ -162,28 +171,38 @@ describe Rbeapi::Api::Prefixlists do
 
   describe '#add_rule' do
     it 'adds rule to existing prefix list' do
-      expect(node).to receive(:config).with('ip prefix-list test1 seq 25 permit 9.8.7.0/24')
-      expect(subject.add_rule('test1', 'permit','9.8.7.0/24', '25')).to be_truthy
+      expect(node).to receive(:config)
+        .with('ip prefix-list test1 seq 25 permit 10.25.1.0/24')
+      expect(subject.add_rule('test1', 'permit', '10.25.1.0/24', '25'))
+        .to be_truthy
     end
 
     it 'adds rule to existing prefix list w/o seq' do
-      expect(node).to receive(:config).with('ip prefix-list test1 permit 8.7.6.0/24')
-      expect(subject.add_rule('test1', 'permit', '8.7.6.0/24')).to be_truthy
+      expect(node).to receive(:config)
+        .with('ip prefix-list test1 permit 10.25.2.0/24')
+      expect(subject.add_rule('test1', 'permit', '10.25.2.0/24'))
+        .to be_truthy
     end
 
     it 'adds rule to non-existing prefix list' do
-      expect(node).to receive(:config).with('ip prefix-list plist2 seq 10 permit 6.5.4.128/25')
-      expect(subject.add_rule('plist2', 'permit', '6.5.4.128/25', '10')).to be_truthy
+      expect(node).to receive(:config)
+        .with('ip prefix-list plist2 seq 10 permit 10.25.3.128/25')
+      expect(subject.add_rule('plist2', 'permit', '10.25.3.128/25', '10'))
+        .to be_truthy
     end
 
     it 'adds rule to non-existing prefix list w/o seq' do
-      expect(node).to receive(:config).with('ip prefix-list plist2 deny 5.4.3.0/25')
-      expect(subject.add_rule('plist2', 'deny', '5.4.3.0/25')).to be_truthy
+      expect(node).to receive(:config)
+        .with('ip prefix-list plist2 deny 10.25.10.0/25')
+      expect(subject.add_rule('plist2', 'deny', '10.25.10.0/25'))
+        .to be_truthy
     end
 
     it 'overwrites existing rule' do
-      expect(node).to receive(:config).with('ip prefix-list test1 seq 20 permit 2.3.5.0/24 le 28')
-      expect(subject.add_rule('test1', 'permit', '2.3.5.0/24 le 28', '20')).to be_truthy
+      expect(node).to receive(:config)
+        .with('ip prefix-list test1 seq 20 permit 10.25.20.0/24 le 28')
+      expect(subject.add_rule('test1', 'permit', '10.25.20.0/24 le 28', '20'))
+        .to be_truthy
     end
   end
 
@@ -198,5 +217,4 @@ describe Rbeapi::Api::Prefixlists do
       expect(subject.delete('test2', '10'))
     end
   end
-
-end
+end