rbeapi 1.0 → 1.1

data/spec/system/rbeapi/api/interfaces_ethernet_spec.rb

@@ -14,8 +14,8 @@ describe Rbeapi::Api::Interfaces do
 
   describe '#get' do
     let(:entity) do
-      { name: 'Ethernet1', type: 'ethernet', description: '', shutdown: false,
-        load_interval: '', speed: 'default', sflow: true,
+      { name: 'Ethernet1', type: 'ethernet', description: '', encapsulation: '',
+        shutdown: false, load_interval: '', speed: 'default', sflow: true,
         flowcontrol_send: 'off', flowcontrol_receive: 'off',
         lacp_priority: '32768' }
     end
@@ -45,12 +45,33 @@ describe Rbeapi::Api::Interfaces do
     end
   end
 
+  describe '#create' do
+    before { node.config('no interface Ethernet1.1') }
+
+    it 'creates a new ethernet subinterface' do
+      expect(subject.get('Ethernet1.1')).to be_nil
+      expect(subject.create('Ethernet1.1')).to be_truthy
+      expect(subject.get('Ethernet1.1')).not_to be_nil
+      node.config(['no interface Ethernet1.1'])
+    end
+  end
+
   describe '#delete' do
     it 'raises an error on create' do
       expect { subject.create('Ethernet1') }.to raise_error(NotImplementedError)
     end
   end
 
+  describe '#delete' do
+    before { node.config(['interface Ethernet1.1']) }
+
+    it 'deletes an ethernet subinterface resource' do
+      expect(subject.get('Ethernet1.1')).not_to be_nil
+      expect(subject.delete('Ethernet1.1')).to be_truthy
+      expect(subject.get('Ethernet1.1')).to be_nil
+    end
+  end
+
   describe '#default' do
     before { node.config(['interface Ethernet1', :shutdown]) }
 
@@ -71,6 +92,17 @@ describe Rbeapi::Api::Interfaces do
     end
   end
 
+  describe '#set_encapsulation' do
+    it 'sets the encapsulation value on the interface' do
+      node.config(['interface Ethernet1.1', 'no encapsulation dot1q vlan'])
+      expect(subject.get('Ethernet1.1')[:encapsulation]).to be_empty
+      expect(subject.set_encapsulation('Ethernet1.1', value: '10'))
+        .to be_truthy
+      expect(subject.get('Ethernet1.1')[:encapsulation]).to eq('10')
+      node.config(['no interface Ethernet1.1'])
+    end
+  end
+
   describe '#set_shutdown' do
     it 'shutdown the interface' do
       node.config(['interface Ethernet1', 'no shutdown'])
@@ -91,7 +123,8 @@ describe Rbeapi::Api::Interfaces do
     before { node.config(['default interface Ethernet1']) }
 
     it 'sets enable true' do
-      expect(subject.set_speed('Ethernet1', enable: true)).to be_falsy
+      expect(subject.set_speed('Ethernet1', default: false,
+                                            enable: true)).to be_falsy
     end
   end
 

data/spec/system/rbeapi/api/interfaces_portchannel_spec.rb

@@ -14,9 +14,9 @@ describe Rbeapi::Api::Interfaces do
   describe '#get' do
     let(:entity) do
       { name: 'Port-Channel1', type: 'portchannel', description: '',
-        shutdown: false, load_interval: '', members: [], lacp_mode: 'on',
-        minimum_links: '0',
-        lacp_timeout: '90', lacp_fallback: 'disabled' }
+        encapsulation: '', shutdown: false, load_interval: '', members: [],
+        lacp_mode: 'on', minimum_links: '0', lacp_timeout: '90',
+        lacp_fallback: 'disabled' }
     end
 
     before do
@@ -52,6 +52,17 @@ describe Rbeapi::Api::Interfaces do
     end
   end
 
+  describe '#create' do
+    before { node.config('no interface Port-Channel1.1') }
+
+    it 'creates a new subinterface resource' do
+      expect(subject.get('Port-Channel1.1')).to be_nil
+      expect(subject.create('Port-Channel1.1')).to be_truthy
+      expect(subject.get('Port-Channel1.1')).not_to be_nil
+      node.config(['no interface Port-Channel1.1'])
+    end
+  end
+
   describe '#delete' do
     before { node.config(['interface Port-Channel1']) }
 
@@ -62,6 +73,16 @@ describe Rbeapi::Api::Interfaces do
     end
   end
 
+  describe '#delete' do
+    before { node.config(['interface Port-Channel1.1']) }
+
+    it 'deletes a switchport subinterface resource' do
+      ##      expect(subject.get('Port-Channel1.1')).not_to be_nil
+      expect(subject.delete('Port-Channel1.1')).to be_truthy
+      expect(subject.get('Port-Channel1.1')).to be_nil
+    end
+  end
+
   describe '#default' do
     before { node.config(['interface Port-Channel1', :shutdown]) }
 
@@ -82,6 +103,17 @@ describe Rbeapi::Api::Interfaces do
     end
   end
 
+  describe '#set_encapsulation' do
+    it 'sets the encapsulation value on the interface' do
+      node.config(['interface Port-Channel1.1', 'no encapsulation dot1q vlan'])
+      expect(subject.get('Port-Channel1.1')[:encapsulation]).to be_empty
+      expect(subject.set_encapsulation('Port-Channel1.1', value: '31'))
+        .to be_truthy
+      expect(subject.get('Port-Channel1.1')[:encapsulation]).to eq('31')
+      node.config(['no interface Port-Channel1.1'])
+    end
+  end
+
   describe '#set_shutdown' do
     it 'shutdown the interface' do
       node.config(['interface Port-Channel1', 'no shutdown'])

data/spec/system/rbeapi/api/interfaces_vlan_spec.rb

@@ -0,0 +1,90 @@
+require 'spec_helper'
+
+require 'rbeapi/client'
+require 'rbeapi/api/interfaces'
+
+describe Rbeapi::Api::Interfaces do
+  subject { described_class.new(node) }
+
+  let(:node) do
+    Rbeapi::Client.config.read(fixture_file('dut.conf'))
+    Rbeapi::Client.connect_to('dut')
+  end
+
+  describe '#get' do
+    let(:entity) do
+      { name: 'Vlan1', type: 'vlan', description: '', shutdown: false,
+        autostate: :true, load_interval: '', encapsulation: '' }
+    end
+
+    before { node.config(['no interface Vlan1', 'interface Vlan1']) }
+
+    it 'returns the interface resource' do
+      expect(subject.get('Vlan1')).to eq(entity)
+    end
+  end
+
+  describe '#getall' do
+    before { node.config(['no interface Vlan1', 'interface Vlan1']) }
+
+    it 'returns the interface collection' do
+      expect(subject.getall).to include('Vlan1')
+    end
+
+    it 'returns a hash collection' do
+      expect(subject.getall).to be_a_kind_of(Hash)
+    end
+  end
+
+  describe '#create' do
+    before { node.config('no interface Vlan1') }
+
+    it 'creates a new interface resource' do
+      expect(subject.create('Vlan1')).to be_truthy
+      expect(subject.get('Vlan1')).not_to be_nil
+    end
+  end
+
+  describe '#delete' do
+    before { node.config(['interface Vlan1']) }
+
+    it 'deletes a vlan interface resource' do
+      expect(subject.get('Vlan1')).not_to be_nil
+      expect(subject.delete('Vlan1')).to be_truthy
+      expect(subject.get('Vlan1')).to be_nil
+    end
+  end
+
+  describe '#default' do
+    before { node.config(['interface Vlan1', 'shutdown']) }
+
+    it 'sets Vlan1 to default' do
+      expect(subject.get('Vlan1')[:shutdown]).to be_truthy
+      expect(subject.default('Vlan1')).to be_truthy
+      expect(subject.get('Vlan1')[:shutdown]).to be_falsy
+    end
+  end
+
+  describe '#set_autostate' do
+    it 'sets the autostate value to true' do
+      node.config(['interface Vlan1', 'no autostate'])
+      expect(subject.get('Vlan1')[:autostate]).to eq(:false)
+      expect(subject.set_autostate('Vlan1', value: :true)).to be_truthy
+      expect(subject.get('Vlan1')[:autostate]).to eq(:true)
+    end
+
+    it 'sets the autostate value to false' do
+      node.config(['interface Vlan1', 'autostate'])
+      expect(subject.get('Vlan1')[:autostate]).to be_truthy
+      expect(subject.set_autostate('Vlan1', value: :false)).to be_truthy
+      expect(subject.get('Vlan1')[:autostate]).to eq(:false)
+    end
+
+    it 'manages autostate default' do
+      node.config(['interface Vlan1', 'no autostate'])
+      expect(subject.get('Vlan1')[:autostate]).to eq(:false)
+      expect(subject.set_autostate('Vlan1', default: :true)).to be_truthy
+      expect(subject.get('Vlan1')[:autostate]).to eq(:true)
+    end
+  end
+end

data/spec/system/rbeapi/api/interfaces_vxlan_spec.rb

@@ -13,10 +13,9 @@ describe Rbeapi::Api::Interfaces do
 
   describe '#get' do
     let(:entity) do
-      { name: 'Vxlan1', type: 'vxlan', description: '', shutdown: false,
-        load_interval: '',
-        source_interface: '', multicast_group: '', udp_port: 4789,
-        flood_list: [], vlans: {} }
+      { name: 'Vxlan1', type: 'vxlan', description: '', encapsulation: '',
+        shutdown: false, load_interval: '', source_interface: '',
+        multicast_group: '', udp_port: 4789, flood_list: [], vlans: {} }
     end
 
     before { node.config(['no interface Vxlan1', 'interface Vxlan1']) }

data/spec/system/rbeapi/api/managementdefaults_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+require 'rbeapi/client'
+require 'rbeapi/api/managementdefaults'
+
+describe Rbeapi::Api::Managementdefaults do
+  subject { described_class.new(node) }
+
+  let(:node) do
+    Rbeapi::Client.config.read(fixture_file('dut.conf'))
+    Rbeapi::Client.connect_to('dut')
+  end
+
+  describe '#get' do
+    before { node.config(['management defaults', 'default secret hash']) }
+
+    it 'contains all required settings' do
+      expect(subject.get).to include(:secret_hash)
+    end
+  end
+
+  describe '#set_secret_hash' do
+    before { node.config(['management defaults', 'default secret hash']) }
+
+    it 'configures the management defaults secret hash value' do
+      expect(subject.get[:secret_hash]).to eq('md5')
+      expect(subject.set_secret_hash(value: 'sha512')).to be_truthy
+      expect(subject.get[:secret_hash]).to eq('sha512')
+    end
+  end
+end

data/spec/system/rbeapi/api/ospf_interfaces_spec.rb

@@ -14,11 +14,15 @@ describe Rbeapi::Api::OspfInterfaces do
       node.config(['default interface Ethernet1', 'interface Ethernet1',
                    'no switchport', 'ip address 88.99.99.99/24',
                    'ip ospf network point-to-point',
-                   'exit', 'default interface Ethernet2'])
+                   'exit', 'default interface Ethernet2',
+                   'no interface Vlan99', 'interface Vlan99',
+                   'ip address 99.9.9.9/24', 'ip ospf network point-to-point',
+                   'exit'])
     end
 
     it 'returns an ospf interface resource instance' do
       expect(subject.get('Ethernet1')).not_to be_nil
+      expect(subject.get('Vlan99')).not_to be_nil
     end
 
     it 'returns nil for a switchport interface' do
@@ -29,16 +33,21 @@ describe Rbeapi::Api::OspfInterfaces do
   describe '#getall' do
     before do
       node.config(['default interface Ethernet1', 'interface Ethernet1',
-                   'no switchport', 'ip address 88.99.99.99/24', 'exit',
-                   'default interface Ethernet2'])
+                   'no switchport', 'ip address 88.99.99.99/24',
+                   'ip ospf network point-to-point',
+                   'exit', 'default interface Ethernet2',
+                   'no interface Vlan99', 'interface Vlan99',
+                   'ip address 99.9.9.9/24', 'ip ospf network point-to-point',
+                   'exit'])
     end
 
     it 'returns the ospf resource collection' do
       expect(subject.getall).to be_a_kind_of(Hash)
     end
 
-    it 'includes an instance of Ethernet1' do
+    it 'includes an instance of Ethernet1 and Vlan99' do
       expect(subject.getall).to include('Ethernet1')
+      expect(subject.getall).to include('Vlan99')
     end
 
     it 'does not include an instance of Ethernet2' do
@@ -49,30 +58,46 @@ describe Rbeapi::Api::OspfInterfaces do
   describe '#set_network_type' do
     before do
       node.config(['default interface Ethernet1', 'interface Ethernet1',
-                   'no switchport', 'ip address 88.99.99.99/24', 'exit'])
+                   'no switchport', 'ip address 88.99.99.99/24', 'exit',
+                   'no interface Vlan99', 'interface Vlan99',
+                   'ip address 99.9.9.9/24', 'exit'])
     end
 
     it 'configures the ospf interface type to point-to-point' do
-      expect(subject.get('Ethernet1')['network_type']).to eq('broadcast')
+      expect(subject.get('Ethernet1')[:network_type]).to eq('broadcast')
       expect(subject.set_network_type('Ethernet1', value: 'point-to-point'))
         .to be_truthy
-      expect(subject.get('Ethernet1')['network_type']).to eq('point-to-point')
+      expect(subject.get('Ethernet1')[:network_type]).to eq('point-to-point')
+      expect(subject.get('Vlan99')[:network_type]).to eq('broadcast')
+      expect(subject.set_network_type('Vlan99', value: 'point-to-point'))
+        .to be_truthy
+      expect(subject.get('Vlan99')[:network_type]).to eq('point-to-point')
     end
 
     it 'negates the ospf interface type' do
       expect(subject.set_network_type('Ethernet1', value: 'point-to-point'))
         .to be_truthy
-      expect(subject.get('Ethernet1')['network_type']).to eq('point-to-point')
+      expect(subject.get('Ethernet1')[:network_type]).to eq('point-to-point')
       expect(subject.set_network_type('Ethernet1', enable: false)).to be_truthy
-      expect(subject.get('Ethernet1')['network_type']).to eq('broadcast')
+      expect(subject.get('Ethernet1')[:network_type]).to eq('broadcast')
+      expect(subject.set_network_type('Vlan99', value: 'point-to-point'))
+        .to be_truthy
+      expect(subject.get('Vlan99')[:network_type]).to eq('point-to-point')
+      expect(subject.set_network_type('Vlan99', enable: false)).to be_truthy
+      expect(subject.get('Vlan99')[:network_type]).to eq('broadcast')
     end
 
     it 'defaults the ospf interface type' do
       expect(subject.set_network_type('Ethernet1', value: 'point-to-point'))
         .to be_truthy
-      expect(subject.get('Ethernet1')['network_type']).to eq('point-to-point')
+      expect(subject.get('Ethernet1')[:network_type]).to eq('point-to-point')
       expect(subject.set_network_type('Ethernet1', default: true)).to be_truthy
-      expect(subject.get('Ethernet1')['network_type']).to eq('broadcast')
+      expect(subject.get('Ethernet1')[:network_type]).to eq('broadcast')
+      expect(subject.set_network_type('Vlan99', value: 'point-to-point'))
+        .to be_truthy
+      expect(subject.get('Vlan99')[:network_type]).to eq('point-to-point')
+      expect(subject.set_network_type('Vlan99', default: true)).to be_truthy
+      expect(subject.get('Vlan99')[:network_type]).to eq('broadcast')
     end
   end
 end

data/spec/system/rbeapi/api/ospf_spec.rb

@@ -14,15 +14,25 @@ describe Rbeapi::Api::Ospf do
       node.config(['no router ospf 1',
                    'router ospf 1',
                    'router-id 1.1.1.1',
+                   'max-lsa 12000',
+                   'maximum-paths 16',
+                   'passive-interface default',
+                   'no passive-interface Ethernet1',
+                   'no passive-interface Ethernet2',
                    'redistribute static route-map word',
                    'network 192.168.10.10/24 area 0.0.0.0',
                    'network 192.168.11.10/24 area 0.0.0.0'])
     end
 
     let(:entity) do
-      { 'router_id' => '1.1.1.1',
-        'areas' => { '0.0.0.0' => ['192.168.10.0/24', '192.168.11.0/24'] },
-        'redistribute' => { 'static' => { 'route_map' => 'word' } } }
+      { router_id: '1.1.1.1',
+        max_lsa: 12_000,
+        maximum_paths: 16,
+        passive_interface_default: true,
+        active_interfaces: %w(Ethernet1 Ethernet2),
+        passive_interfaces: [],
+        areas: { '0.0.0.0' => ['192.168.10.0/24', '192.168.11.0/24'] },
+        redistribute: { 'static' => { route_map: 'word' } } }
     end
 
     it 'returns an ospf resource instance' do
@@ -39,8 +49,8 @@ describe Rbeapi::Api::Ospf do
       expect(collection).to include('1')
     end
 
-    it ' includes interfaces' do
-      expect(collection).to include('interfaces')
+    it 'includes interfaces' do
+      expect(collection).to include(:interfaces)
     end
 
     it 'is a kind of hash' do
@@ -58,23 +68,203 @@ describe Rbeapi::Api::Ospf do
     before { node.config(['no router ospf 1', 'router ospf 1']) }
 
     it 'configures the ospf router id to 1.1.1.1' do
-      expect(subject.get('1')['router_id']).to be_empty
+      expect(subject.get('1')[:router_id]).to be_empty
       expect(subject.set_router_id('1', value: '1.1.1.1')).to be_truthy
-      expect(subject.get('1')['router_id']).to eq('1.1.1.1')
+      expect(subject.get('1')[:router_id]).to eq('1.1.1.1')
     end
 
     it 'negates the router id' do
       expect(subject.set_router_id('1', value: '1.1.1.1')).to be_truthy
-      expect(subject.get('1')['router_id']).to eq('1.1.1.1')
+      expect(subject.get('1')[:router_id]).to eq('1.1.1.1')
       expect(subject.set_router_id('1', enable: false)).to be_truthy
-      expect(subject.get('1')['router_id']).to be_empty
+      expect(subject.get('1')[:router_id]).to be_empty
     end
 
     it 'defaults the router id' do
       expect(subject.set_router_id('1', value: '1.1.1.1')).to be_truthy
-      expect(subject.get('1')['router_id']).to eq('1.1.1.1')
+      expect(subject.get('1')[:router_id]).to eq('1.1.1.1')
       expect(subject.set_router_id('1', default: true)).to be_truthy
-      expect(subject.get('1')['router_id']).to be_empty
+      expect(subject.get('1')[:router_id]).to be_empty
+    end
+  end
+
+  describe '#set_max_lsa' do
+    before { node.config(['no router ospf 1', 'router ospf 1']) }
+
+    it 'configures the ospf max-lsa to 24000' do
+      expect(subject.get('1')[:max_lsa]).to eq(12_000)
+      expect(subject.set_max_lsa('1', value: 24_000)).to be_truthy
+      expect(subject.get('1')[:max_lsa]).to eq(24_000)
+    end
+
+    it 'negates the max-lsa' do
+      expect(subject.set_max_lsa('1', value: 24_000)).to be_truthy
+      expect(subject.get('1')[:max_lsa]).to eq(24_000)
+      expect(subject.set_max_lsa('1', enable: false)).to be_truthy
+      expect(subject.get('1')[:max_lsa]).to eq(12_000)
+    end
+
+    it 'defaults the max-lsa' do
+      expect(subject.set_max_lsa('1', value: 24_000)).to be_truthy
+      expect(subject.get('1')[:max_lsa]).to eq(24_000)
+      expect(subject.set_max_lsa('1', default: true)).to be_truthy
+      expect(subject.get('1')[:max_lsa]).to eq(12_000)
+    end
+  end
+
+  describe '#set_maximum_paths' do
+    before { node.config(['no router ospf 1', 'router ospf 1']) }
+
+    it 'configures the ospf maximum-paths to 16' do
+      expect(subject.get('1')[:maximum_paths]).to eq(128)
+      expect(subject.set_maximum_paths('1', value: 16)).to be_truthy
+      expect(subject.get('1')[:maximum_paths]).to eq(16)
+    end
+
+    it 'negates the maximum-paths' do
+      expect(subject.set_maximum_paths('1', value: 16)).to be_truthy
+      expect(subject.get('1')[:maximum_paths]).to eq(16)
+      expect(subject.set_maximum_paths('1', enable: false)).to be_truthy
+      expect(subject.get('1')[:maximum_paths]).to eq(128)
+    end
+
+    it 'defaults the maximum-paths' do
+      expect(subject.set_maximum_paths('1', value: 16)).to be_truthy
+      expect(subject.get('1')[:maximum_paths]).to eq(16)
+      expect(subject.set_maximum_paths('1', default: true)).to be_truthy
+      expect(subject.get('1')[:maximum_paths]).to eq(128)
+    end
+  end
+
+  describe '#passive_interface_default' do
+    before { node.config(['no router ospf 1', 'router ospf 1']) }
+
+    it 'configures the passive-interface default' do
+      expect(subject.get('1')[:passive_interface_default]).to eq(false)
+      expect(subject.set_passive_interface_default('1', value: true))
+        .to be_truthy
+      expect(subject.get('1')[:passive_interface_default]).to eq(true)
+    end
+
+    it 'negates the passive-interface default' do
+      expect(subject.set_passive_interface_default('1', value: true))
+        .to be_truthy
+      expect(subject.get('1')[:passive_interface_default]).to eq(true)
+      expect(subject.set_passive_interface_default('1', enable: false))
+        .to be_truthy
+      expect(subject.get('1')[:passive_interface_default]).to eq(false)
+    end
+
+    it 'defaults the passive-interface default' do
+      expect(subject.set_passive_interface_default('1', value: true))
+        .to be_truthy
+      expect(subject.get('1')[:passive_interface_default]).to eq(true)
+      expect(subject.set_passive_interface_default('1', default: true))
+        .to be_truthy
+      expect(subject.get('1')[:passive_interface_default]).to eq(false)
+    end
+  end
+
+  describe '#set_active_interfaces' do
+    before do
+      node.config(['no router ospf 1', 'router ospf 1',
+                   'passive-interface default'])
+    end
+
+    it 'configures the ospf no passive-interface Ethernet1, 2, 3' do
+      expect(subject.get('1')[:active_interfaces]).to be_empty
+      expect(subject.set_active_interfaces('1',
+                                           value: %w(Ethernet1
+                                                     Ethernet2
+                                                     Ethernet3))).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to eq(%w(Ethernet1
+                                                            Ethernet2
+                                                            Ethernet3))
+    end
+
+    it 'configures the ospf no passive-interface Ethernet1, 2' do
+      expect(subject.set_active_interfaces('1',
+                                           value: %w(Ethernet1
+                                                     Ethernet2
+                                                     Ethernet3))).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to eq(%w(Ethernet1
+                                                            Ethernet2
+                                                            Ethernet3))
+      expect(subject.set_active_interfaces('1',
+                                           value: %w(Ethernet1
+                                                     Ethernet2))).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to eq(%w(Ethernet1
+                                                            Ethernet2))
+    end
+
+    it 'negates the no passive-interface' do
+      expect(subject.set_active_interfaces('1',
+                                           value: %w(Ethernet1
+                                                     Ethernet2))).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to eq(%w(Ethernet1
+                                                            Ethernet2))
+      expect(subject.set_active_interfaces('1', enable: false)).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to be_empty
+    end
+
+    it 'defaults the no passive-interface' do
+      expect(subject.set_active_interfaces('1',
+                                           value: %w(Ethernet1
+                                                     Ethernet2))).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to eq(%w(Ethernet1
+                                                            Ethernet2))
+      expect(subject.set_active_interfaces('1', default: true)).to be_truthy
+      expect(subject.get('1')[:active_interfaces]).to be_empty
+    end
+  end
+
+  describe '#set_passive_interfaces' do
+    before { node.config(['no router ospf 1', 'router ospf 1']) }
+
+    it 'configures the ospf passive-interface Ethernet1, 2, 3' do
+      expect(subject.get('1')[:passive_interfaces]).to be_empty
+      expect(subject.set_passive_interfaces('1',
+                                            value: %w(Ethernet1
+                                                      Ethernet2
+                                                      Ethernet3))).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to eq(%w(Ethernet1
+                                                             Ethernet2
+                                                             Ethernet3))
+    end
+
+    it 'configures the ospf passive-interface Ethernet1, 2' do
+      expect(subject.set_passive_interfaces('1',
+                                            value: %w(Ethernet1
+                                                      Ethernet2
+                                                      Ethernet3))).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to eq(%w(Ethernet1
+                                                             Ethernet2
+                                                             Ethernet3))
+      expect(subject.set_passive_interfaces('1',
+                                            value: %w(Ethernet1
+                                                      Ethernet2))).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to eq(%w(Ethernet1
+                                                             Ethernet2))
+    end
+
+    it 'negates the passive-interface' do
+      expect(subject.set_passive_interfaces('1',
+                                            value: %w(Ethernet1
+                                                      Ethernet2))).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to eq(%w(Ethernet1
+                                                             Ethernet2))
+      expect(subject.set_passive_interfaces('1', enable: false)).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to be_empty
+    end
+
+    it 'defaults the passive-interface' do
+      expect(subject.set_passive_interfaces('1',
+                                            value: %w(Ethernet1
+                                                      Ethernet2))).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to eq(%w(Ethernet1
+                                                             Ethernet2))
+      expect(subject.set_passive_interfaces('1', default: true)).to be_truthy
+      expect(subject.get('1')[:passive_interfaces]).to be_empty
     end
   end
 
@@ -102,10 +292,10 @@ describe Rbeapi::Api::Ospf do
     before { node.config('router ospf 1') }
 
     it 'adds the network with area to the ospf process' do
-      expect(subject.get('1')['areas']).to be_empty
+      expect(subject.get('1')[:areas]).to be_empty
       expect(subject.add_network('1', '192.168.10.0/24', '0.0.0.0'))
         .to be_truthy
-      expect(subject.get('1')['areas']['0.0.0.0']).to include('192.168.10.0/24')
+      expect(subject.get('1')[:areas]['0.0.0.0']).to include('192.168.10.0/24')
     end
   end
 
@@ -115,10 +305,10 @@ describe Rbeapi::Api::Ospf do
     end
 
     it 'removes the network with area to the ospf process' do
-      expect(subject.get('1')['areas']['0.0.0.0']).to include('192.168.10.0/24')
+      expect(subject.get('1')[:areas]['0.0.0.0']).to include('192.168.10.0/24')
       expect(subject.remove_network('1', '192.168.10.0/24', '0.0.0.0'))
         .to be_truthy
-      expect(subject.get('1')['areas']).to be_empty
+      expect(subject.get('1')[:areas]).to be_empty
     end
   end
 
@@ -126,9 +316,42 @@ describe Rbeapi::Api::Ospf do
     before { node.config(['no router ospf 1', 'router ospf 1']) }
 
     it 'configures redistribution of static routes' do
-      expect(subject.get('1')['redistribute']).not_to include('static')
+      expect(subject.get('1')[:redistribute]).to be_empty
+      expect(subject.set_redistribute('1', 'static')).to be_truthy
+      expect(subject.get('1')[:redistribute])
+        .to eq('static' => { route_map: nil })
+    end
+
+    it 'configures redistribution of static routes with routemap' do
       expect(subject.set_redistribute('1', 'static')).to be_truthy
-      expect(subject.get('1')['redistribute']).to include('static')
+      expect(subject.get('1')[:redistribute])
+        .to eq('static' => { route_map: nil })
+      expect(subject.set_redistribute('1', 'static', route_map: 'test'))
+        .to be_truthy
+      expect(subject.get('1')[:redistribute])
+        .to eq('static' => { route_map: 'test' })
+    end
+
+    it 'negates the redistribution' do
+      expect(subject.set_redistribute('1', 'static', route_map: 'test'))
+        .to be_truthy
+      expect(subject.get('1')[:redistribute])
+        .to eq('static' => { route_map: 'test' })
+      expect(subject.set_redistribute('1',
+                                      'static',
+                                      enable: false)).to be_truthy
+      expect(subject.get('1')[:redistribute]).to be_empty
+    end
+
+    it 'defaults the redistribution' do
+      expect(subject.set_redistribute('1', 'connected', route_map: 'foo'))
+        .to be_truthy
+      expect(subject.get('1')[:redistribute])
+        .to eq('connected' => { route_map: 'foo' })
+      expect(subject.set_redistribute('1',
+                                      'connected',
+                                      default: true)).to be_truthy
+      expect(subject.get('1')[:redistribute]).to be_empty
     end
   end
 end