rbeapi 1.0 → 1.1

data/spec/system/rbeapi/api/prefixlists_spec.rb

@@ -42,94 +42,111 @@ describe Rbeapi::Api::Prefixlists do
     Rbeapi::Client.connect_to('dut')
   end
 
-  describe '#get' do
-    before do
-      node.config(['no ip prefix-list test1',
-                   'ip prefix-list test1',
-                   'seq 10 permit 1.2.3.0/24',
-                   'seq 20 permit 2.3.4.0/24 le 30',
-                   'seq 30 deny 3.4.5.0/24 ge 26 le 30',
-                   'permit 5.6.7.16/28 eq 29'])
+  let(:delete_prefix_lists) do
+    config = subject.node.running_config
+    config.scan(/(?<=^ip\sprefix-list\s)[^\s]+(?=\sseq.+)?/).uniq.map do |name|
+      "no ip prefix-list #{name}"
     end
+  end
 
+  describe '#get' do
     let(:prefixlist) { subject.get('test1') }
 
-    it 'returns the prefix list for an existing name' do
-      expect(prefixlist).to be_a_kind_of(Array)
-    end
-
-    it 'returns all rules as hash' do
-      expect(prefixlist).to all ( be_an(Hash) )
-    end
-
-    it 'has all keys for each rule' do
-      prefixlist.each do |rule|
-        expect(rule).to have_key('seq')
-        expect(rule).to have_key('prefix')
-        expect(rule).to have_key('action')
-      end
-    end
-
-    let(:values) do
+    let(:expected) do
       [
-        {
-          'seq' => '10',
+        { 'seq' => '10',
           'action' => 'permit',
-          'prefix' => '1.2.3.0/24'
-        },
-        {
-          'seq' => '20',
+          'prefix' => '10.10.1.0/24' },
+        { 'seq' => '20',
           'action' => 'permit',
-          'prefix' => '2.3.4.0/24 le 30'
-        },
-        {
-          'seq' => '30',
+          'prefix' => '10.20.1.0/24 le 30' },
+        { 'seq' => '30',
           'action' => 'deny',
-          'prefix' => '3.4.5.0/24 ge 26 le 30'
-        },
-        {
-          'seq' => '40',
+          'prefix' => '10.30.1.0/24 ge 26 le 30' },
+        { 'seq' => '40',
           'action' => 'permit',
-          'prefix' => '5.6.7.16/28 eq 29'
-        }
+          'prefix' => '10.40.1.16/28 eq 29' }
       ]
     end
 
-    it 'returns the correct values for all the keys' do
-      expect(prefixlist).to eq(values)
+    let(:keys) { %w(seq action prefix) }
+
+    [
+      { title: 'single-line',
+        cmds: ['ip prefix-list test1 seq 10 permit 10.10.1.0/24',
+               'ip prefix-list test1 seq 20 permit 10.20.1.0/24 le 30',
+               'ip prefix-list test1 seq 30 deny 10.30.1.0/24 ge 26 le 30',
+               'ip prefix-list test1 permit 10.40.1.16/28 eq 29'] },
+      { title: 'multi-line',
+        cmds: ['ip prefix-list test1',
+               'seq 10 permit 10.10.1.0/24',
+               'seq 20 permit 10.20.1.0/24 le 30',
+               'seq 30 deny 10.30.1.0/24 ge 26 le 30',
+               'permit 10.40.1.16/28 eq 29'] }
+    ].each do |context|
+      context "when prefix list is #{context[:title]}" do
+        before { node.config(delete_prefix_lists + context[:cmds]) }
+
+        it 'returns all rules in an array' do
+          expect(prefixlist).to be_a_kind_of(Array)
+        end
+
+        it 'returns each rule as hash' do
+          expect(prefixlist).to all be_an(Hash)
+        end
+
+        it 'has all keys for each rule' do
+          prefixlist.each do |rule|
+            expect(rule.keys).to match_array(keys)
+          end
+        end
+
+        it 'returns the correct values for all rules' do
+          expect(prefixlist).to eq(expected)
+        end
+      end
     end
   end
 
   describe '#getall' do
-    let(:del_pref_lists) {
-      subject.getall.keys.map { |k| "no ip prefix-list #{k}" } 
-    }
-
-    before do
-      node.config(del_pref_lists + 
-                  ['ip prefix-list test1',
-                  'seq 10 permit 1.2.3.0/24',
-                  'seq 20 permit 2.3.4.0/24 le 30',
-                  'seq 30 deny 3.4.5.0/24 ge 26 le 30',
-                  'permit 5.6.7.8/28',
-                  'ip prefix-list test2',
-                  'seq 10 permit 10.11.0.0/16',
-                  'seq 20 permit 10.12.0.0/16 le 24',
-                  'ip prefix-list test3'])
-    end
-
     let(:prefixlists) { subject.getall }
 
-    it 'returns the collection as hash' do
-      expect(prefixlists).to be_a_kind_of(Hash)
-    end
-
-    it 'returns all prefix lists as array' do
-      expect(prefixlists).to all ( be_an(Array) )
-    end
-
-    it 'has three prefix lists' do
-       expect(prefixlists.size).to eq(3)
+    [
+      { title: 'single-line',
+        cmds: ['ip prefix-list test1 seq 10 permit 10.10.1.0/24',
+               'ip prefix-list test1 seq 20 permit 10.20.1.0/24 le 30',
+               'ip prefix-list test1 seq 30 deny 10.30.1.0/24 ge 26 le 30',
+               'ip prefix-list test1 permit 10.40.1.8/28',
+               'ip prefix-list test2 seq 10 permit 10.11.0.0/16',
+               'ip prefix-list test2 seq 20 permit 10.12.0.0/16 le 24',
+               'ip prefix-list test3 permit 10.13.0.0/16'] },
+      { title: 'multi-line',
+        cmds: ['ip prefix-list test1',
+               'seq 10 permit 10.10.1.0/24',
+               'seq 20 permit 10.20.1.0/24 le 30',
+               'seq 30 deny 10.30.1.0/24 ge 26 le 30',
+               'permit 10.40.1.8/28',
+               'ip prefix-list test2',
+               'seq 10 permit 10.11.0.0/16',
+               'seq 20 permit 10.12.0.0/16 le 24',
+               'ip prefix-list test3',
+               'permit 10.13.0.0/16'] }
+    ].each do |context|
+      context "when prefix lists are #{context[:title]}" do
+        before { node.config(delete_prefix_lists + context[:cmds]) }
+
+        it 'returns the collection as hash' do
+          expect(prefixlists).to be_a_kind_of(Hash)
+        end
+
+        it 'returns each prefix lists as an array' do
+          expect(prefixlists).to all be_an(Array)
+        end
+
+        it 'has three prefix lists' do
+          expect(prefixlists.size).to eq(3)
+        end
+      end
     end
   end
 
@@ -149,40 +166,39 @@ describe Rbeapi::Api::Prefixlists do
   describe '#add_rule' do
     before do
       node.config(['no ip prefix-list test5',
-                    'ip prefix-list test5'])
+                   'no ip prefix-list test6',
+                   'ip prefix-list test5'])
     end
 
     it 'adds rule to an existing prefix list' do
       expect(subject.get('test5')).to eq([])
-      expect(subject.add_rule('test5', 'permit', '1.1.1.0/24')).to be_truthy
-      expect(subject.get('test5')).to eq([{
-                                        "seq" => "10",
-                                        "action" => "permit",
-                                        "prefix" => "1.1.1.0/24"}])
+      expect(subject.add_rule('test5', 'permit', '10.50.1.0/24')).to be_truthy
+      expect(subject.get('test5')).to eq([{ 'seq' => '10',
+                                            'action' => 'permit',
+                                            'prefix' => '10.50.1.0/24' }])
     end
 
     it 'adds rule to a non-existent prefix list' do
       expect(subject.get('test6')).to eq(nil)
-      expect(subject.add_rule('test6', 'deny', '2.2.2.0/24')).to be_truthy
-      expect(subject.get('test6')).to eq([{
-                                      "seq" => "10",
-                                      "action" => "deny",
-                                      "prefix" => "2.2.2.0/24"}])
+      expect(subject.add_rule('test6', 'deny', '10.60.1.0/24')).to be_truthy
+      expect(subject.get('test6')).to eq([{ 'seq' => '10',
+                                            'action' => 'deny',
+                                            'prefix' => '10.60.1.0/24' }])
     end
   end
 
   describe '#delete' do
     before do
       node.config(['no ip prefix-list test7',
-                  'no ip prefix-list test8',
-                  'ip prefix-list test7',
-                  'seq 10 permit 7.7.0.0/16',
-                  'ip prefix-list test8',
-                  'seq 10 permit 8.8.0.0/16',
-                  'deny 9.9.0.0/16 le 24'])
+                   'no ip prefix-list test8',
+                   'ip prefix-list test7',
+                   'seq 10 permit 10.70.0.0/16',
+                   'ip prefix-list test8',
+                   'seq 10 permit 10.80.0.0/16',
+                   'deny 10.82.0.0/16 le 24'])
     end
 
-    it 'delets a prefix list' do
+    it 'deletes a prefix list' do
       expect(subject.get('test7')).to be_truthy
       expect(subject.delete('test7')).to be_truthy
       expect(subject.get('test7')).to eq(nil)
@@ -195,4 +211,4 @@ describe Rbeapi::Api::Prefixlists do
       expect(subject.get('test8')[1]).to eq(nil)
     end
   end
-end
+end

data/spec/system/rbeapi/api/routemaps_spec.rb

@@ -124,8 +124,7 @@ describe Rbeapi::Api::Routemaps do
                       continue: 99, description: 'descript',
                       match: ['ip address prefix-list MYLOOPBACK',
                               'interface Loopback0'],
-                      set: ['community internet 5555:5555'])
-            ).to be_truthy
+                      set: ['community internet 5555:5555'])).to be_truthy
       expect(subject.get('test')).to eq(test_entry)
     end
 
@@ -135,7 +134,8 @@ describe Rbeapi::Api::Routemaps do
       expect(subject.get('test1')).to be_truthy
       expect(subject.get('test1').assoc('permit')[0]).to eq('permit')
       expect(
-        subject.get('test1').assoc('permit')[1].assoc(10)[0]).to eq(10)
+        subject.get('test1').assoc('permit')[1].assoc(10)[0]
+      ).to eq(10)
       expect(
         subject.get('test1').assoc('permit')[1].assoc(10)[1][:continue]
       ).to eq(nil)
@@ -213,11 +213,13 @@ describe Rbeapi::Api::Routemaps do
       expect(
         subject.set_match_statements('test', 'permit', 10,
                                      ['ip address prefix-list MYLOOPBACK',
-                                      'interface Loopback0'])).to be_truthy
+                                      'interface Loopback0'])
+      ).to be_truthy
       expect(subject.get('test'))
         .to eq('permit' => { 10 => {
                  match: ['ip address prefix-list MYLOOPBACK',
-                         'interface Loopback0'] } })
+                         'interface Loopback0']
+               } })
     end
 
     it 'adds more match statements' do
@@ -230,12 +232,13 @@ describe Rbeapi::Api::Routemaps do
       expect(subject
         .set_match_statements('test', 'permit', 10,
                               ['interface Vlan100',
-                               'ip address prefix-list MYLOOPBACK'])
-            ).to be_truthy
+                               'ip address prefix-list MYLOOPBACK']))
+        .to be_truthy
       expect(subject.get('test'))
         .to eq('permit' => { 10 => {
                  match: ['ip address prefix-list MYLOOPBACK',
-                         'interface Vlan100'] } })
+                         'interface Vlan100']
+               } })
       expect(subject
         .set_match_statements('test', 'permit', 10,
                               ['interface Vlan100'])).to be_truthy
@@ -261,7 +264,8 @@ describe Rbeapi::Api::Routemaps do
       expect(subject.get('test1'))
         .to eq('permit' => { 10 => {
                  match: ['ip address prefix-list MYLOOPBACK',
-                         'interface Loopback0'] } })
+                         'interface Loopback0']
+               } })
     end
   end
 
@@ -290,7 +294,8 @@ describe Rbeapi::Api::Routemaps do
                              'community internet 4444:4444'])).to be_truthy
       expect(subject.get('test1'))
         .to eq('permit' => { 10 => {
-                 set: ['community internet 4444:4444 5555:5555'] } })
+                 set: ['community internet 4444:4444 5555:5555']
+               } })
     end
   end
 

data/spec/system/rbeapi/api/users_spec.rb

@@ -68,8 +68,7 @@ describe Rbeapi::Api::Users do
       nopassword: false,
       encryption: 'md5',
       secret: md5_secret,
-      sshkey: sshkey
-    }
+      sshkey: sshkey }
   end
 
   describe '#getall' do
@@ -82,8 +81,7 @@ describe Rbeapi::Api::Users do
         'rbeapi' => { name: 'rbeapi', privilege: 1, role: nil,
                       nopassword: false, encryption: 'md5',
                       secret: md5_secret,
-                      sshkey: sshkey }
-      }
+                      sshkey: sshkey } }
     end
 
     before do
@@ -91,7 +89,8 @@ describe Rbeapi::Api::Users do
                    'no username user1',
                    'username admin privilege 1 role network-admin nopassword',
                    "username rbeapi privilege 1 secret 5 #{md5_secret}",
-                   "username rbeapi sshkey #{sshkey}"])
+                   "username rbeapi sshkey #{sshkey}",
+                   'management defaults', 'default secret hash'])
     end
 
     it 'returns the username collection' do

data/spec/system/rbeapi/api/vrrp_spec.rb

@@ -57,15 +57,12 @@ describe Rbeapi::Api::Vrrp do
                 timers_advertise: 1,
                 track: [
                   { name: 'Ethernet1', action: 'decrement', amount: 5 }
-                ]
-        },
+                ] },
         40 => { primary_ip: '40.10.5.32', delay_reload: 0, description: nil,
                 enable: true, ip_version: 2, mac_addr_adv_interval: 30,
                 preempt: true, preempt_delay_min: 0, preempt_delay_reload: 0,
                 priority: 200, secondary_ip: [], timers_advertise: 1,
-                track: @tracks
-        }
-      }
+                track: @tracks } }
     end
 
     it 'returns the virtual router resource' do

data/spec/system/rbeapi/client_spec.rb

@@ -171,8 +171,7 @@ describe Rbeapi::Client do
                                            username: 'test2',
                                            password: 'test',
                                            transport: 'http',
-                                           host: 'test2'
-                                          )).to eq(nil)
+                                           host: 'test2')).to eq(nil)
       expect(subject.config.get_connection('test2'))
         .to eq(username: 'test2',
                password: 'test',

data/spec/unit/rbeapi/api/acl/default_spec.rb

@@ -63,8 +63,7 @@ describe Rbeapi::Api::Acl do
         '50' => { seqno: '50', action: 'permit', srcaddr: '16.0.0.0',
                   srcprefixlen: '8', log: nil },
         '60' => { seqno: '60', action: 'permit', srcaddr: '9.10.11.0',
-                  srcprefixlen: '255.255.255.0', log: 'log' }
-      }
+                  srcprefixlen: '255.255.255.0', log: 'log' } }
     end
 
     it 'returns the ACL resource' do

data/spec/unit/rbeapi/api/alias/default_spec.rb

@@ -0,0 +1,119 @@
+#
+# Copyright (c) 2015, Arista Networks, Inc.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#   Redistributions of source code must retain the above copyright notice,
+#   this list of conditions and the following disclaimer.
+#
+#   Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in the
+#   documentation and/or other materials provided with the distribution.
+#
+#   Neither the name of Arista Networks nor the names of its
+#   contributors may be used to endorse or promote products derived from
+#   this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ARISTA NETWORKS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
+# BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
+# OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
+# IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+require 'spec_helper'
+
+require 'rbeapi/api/alias'
+
+include FixtureHelpers
+
+describe Rbeapi::Api::Alias do
+  subject { described_class.new(node) }
+
+  let(:node) { double('node') }
+
+  let(:test) do
+    { name: 'Alias1',
+      command: 'my command' }
+  end
+  let(:name) { test[:name] }
+
+  def aliases
+    aliases = Fixtures[:alias]
+    return aliases if aliases
+    fixture('alias', format: :text, dir: File.dirname(__FILE__))
+  end
+
+  before :each do
+    allow(subject.node).to receive(:running_config).and_return(aliases)
+  end
+
+  describe '#getall' do
+    let(:test1_entries) do
+      { 'Alias1' => { name: 'Alias1', command: 'my command' },
+        'Alias2' => { name: 'Alias2', command: 'my command 2' },
+        'Alias3' => { name: 'Alias3',
+                      command: '1 conf\n2 int %1\n3 description %2\n'\
+                               '4 end\nend' } }
+    end
+
+    it 'returns the alias collection' do
+      expect(subject.getall).to include(test1_entries)
+    end
+
+    it 'returns a hash collection' do
+      expect(subject.getall).to be_a_kind_of(Hash)
+    end
+
+    it 'has three entries' do
+      expect(subject.getall.size).to eq(3)
+    end
+  end
+
+  describe '#get' do
+    it 'returns the alias resource for given name' do
+      expect(subject.get(name)).to eq(test)
+    end
+
+    it 'returns a hash' do
+      expect(subject.get(name)).to be_a_kind_of(Hash)
+    end
+
+    it 'has two entries' do
+      expect(subject.get(name).size).to eq(2)
+    end
+  end
+
+  describe '#create' do
+    it 'create a new alias entry' do
+      expect(node).to receive(:config).with(['alias Alias1 my command'])
+      expect(subject.create('Alias1', command: 'my command')).to be_truthy
+    end
+    it 'raises ArgumentError for create without required args ' do
+      expect { subject.create('Alias') }.to \
+        raise_error ArgumentError
+    end
+  end
+
+  describe '#set_command' do
+    it 'set the command' do
+      expect(node).to receive(:config).with(['alias Alias4 my command'])
+      expect(subject.create('Alias4', command: 'my command')).to be_truthy
+    end
+  end
+
+  describe '#delete' do
+    it 'delete a alias resource' do
+      expect(node).to receive(:config).with('no alias Alias1')
+      expect(subject.delete('Alias1')).to be_truthy
+    end
+  end
+end