rails_best_practices 1.20.0 → 1.22.1

data/spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe AlwaysAddDbIndexReview do
-      let(:runner) { Core::Runner.new(reviews: AlwaysAddDbIndexReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should always add db index' do
+      it 'alwayses add db index' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
@@ -28,7 +28,7 @@ module RailsBestPractices
         expect(runner.errors[1].to_s).to eq('db/schema.rb:2 - always add db index (comments => [user_id])')
       end
 
-      it 'should always add db index with polymorphic foreign key' do
+      it 'alwayses add db index with polymorphic foreign key' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "versions", force: true do |t|
@@ -41,10 +41,12 @@ module RailsBestPractices
         runner.review('db/schema.rb', content)
         runner.after_review
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])')
+        expect(runner.errors[0].to_s).to eq(
+          'db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])'
+        )
       end
 
-      it 'should always add db index with polymorphic foreign key and _type is defined before _id' do
+      it 'alwayses add db index with polymorphic foreign key and _type is defined before _id' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "versions", force: true do |t|
@@ -57,10 +59,12 @@ module RailsBestPractices
         runner.review('db/schema.rb', content)
         runner.after_review
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])')
+        expect(runner.errors[0].to_s).to eq(
+          'db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])'
+        )
       end
 
-      it 'should always add db index with single index, but without polymorphic foreign key' do
+      it 'alwayses add db index with single index, but without polymorphic foreign key' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "taggings", force: true do |t|
@@ -77,10 +81,12 @@ module RailsBestPractices
         runner.review('db/schema.rb', content)
         runner.after_review
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])')
+        expect(runner.errors[0].to_s).to eq(
+          'db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])'
+        )
       end
 
-      it 'should always add db index with polymorphic foreign key, but without single index' do
+      it 'alwayses add db index with polymorphic foreign key, but without single index' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "taggings", force: true do |t|
@@ -100,7 +106,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('db/schema.rb:2 - always add db index (taggings => [tag_id])')
       end
 
-      it 'should always add db index only _id without non related _type column' do
+      it 'alwayses add db index only _id without non related _type column' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "websites", force: true do |t|
@@ -119,7 +125,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('db/schema.rb:2 - always add db index (websites => [user_id])')
       end
 
-      it 'should not always add db index with column has no id' do
+      it 'does not always add db index with column has no id' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
@@ -133,7 +139,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index with add_index' do
+      it 'does not always add db index with add_index' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
@@ -155,7 +161,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index with t.index' do
+      it 'does not always add db index with t.index' do
         # e.g. schema_plus creates indices like this https://github.com/lomba/schema_plus
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
@@ -173,7 +179,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index with only _type column' do
+      it 'does not always add db index with only _type column' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "versions", force: true do |t|
@@ -186,7 +192,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index with multi-column index' do
+      it 'does not always add db index with multi-column index' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "versions", force: true do |t|
@@ -203,7 +209,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index if there is an index contains more columns' do
+      it 'does not always add db index if there is an index contains more columns' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "taggings", force: true do |t|
@@ -220,7 +226,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index if two indexes for polymorphic association' do
+      it 'does not always add db index if two indexes for polymorphic association' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "taggings", force: true do |t|
@@ -238,7 +244,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not always add db index if table does not exist' do
+      it 'does not always add db index if table does not exist' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
@@ -251,7 +257,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should always add db index if association_name is different to foreign_key' do
+      it 'alwayses add db index if association_name is different to foreign_key' do
         content = <<-EOF
         class Comment < ActiveRecord::Base
           belongs_to :commentor, class_name: "User"
@@ -278,8 +284,8 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('db/schema.rb:2 - always add db index (comments => [commentor_id])')
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: AlwaysAddDbIndexReview.new(ignored_files: /db\/schema/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{db/schema}))
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
@@ -298,7 +304,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should detect index option in column creation' do
+      it 'detects index option in column creation' do
         content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|

data/spec/rails_best_practices/reviews/check_destroy_return_value_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe CheckDestroyReturnValueReview do
-      let(:runner) { Core::Runner.new(reviews: CheckDestroyReturnValueReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       describe 'check_destroy_return_value' do
-        it 'should warn you if you fail to check the destroy return value' do
+        it 'warns you if you fail to check the destroy return value' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -19,10 +19,12 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:5 - check 'destroy' return value or use 'destroy!'")
+          expect(runner.errors[0].to_s).to eq(
+            "app/helpers/posts_helper.rb:5 - check 'destroy' return value or use 'destroy!'"
+          )
         end
 
-        it 'should allow destroy return value if assigned to a var' do
+        it 'allows destroy return value if assigned to a var' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -35,7 +37,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy return value used in if' do
+        it 'allows destroy return value used in if' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -52,7 +54,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy return value used in elsif' do
+        it 'allows destroy return value used in elsif' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -71,7 +73,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy return value used in unless' do
+        it 'allows destroy return value used in unless' do
           content = <<-EOF
           def my_method
             unless @post.destroy
@@ -83,7 +85,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy return value used in if_mod' do
+        it 'allows destroy return value used in if_mod' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -96,7 +98,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy return value used in unless_mod' do
+        it 'allows destroy return value used in unless_mod' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -109,7 +111,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy return value used in unless with &&' do
+        it 'allows destroy return value used in unless with &&' do
           content = <<-EOF
           def my_method
             unless some_method(1) && other_method(2) && @post.destroy
@@ -121,7 +123,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow destroy!' do
+        it 'allows destroy!' do
           content = <<-EOF
           def my_method
             post = Posts.create do |p|
@@ -135,8 +137,8 @@ module RailsBestPractices
         end
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: CheckDestroyReturnValueReview.new(ignored_files: /helpers/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /helpers/))
         content = <<-EOF
           def my_method
             post = Posts.create do |p|

data/spec/rails_best_practices/reviews/check_save_return_value_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe CheckSaveReturnValueReview do
-      let(:runner) { Core::Runner.new(reviews: CheckSaveReturnValueReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       describe 'check_save_return_value' do
-        it 'should warn you if you fail to check save return value' do
+        it 'warns you if you fail to check save return value' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -19,10 +19,12 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:5 - check 'save' return value or use 'save!'")
+          expect(runner.errors[0].to_s).to eq(
+            "app/helpers/posts_helper.rb:5 - check 'save' return value or use 'save!'"
+          )
         end
 
-        it 'should allow save return value assigned to var' do
+        it 'allows save return value assigned to var' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -35,7 +37,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save return value used in if' do
+        it 'allows save return value used in if' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -52,7 +54,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save return value used in elsif' do
+        it 'allows save return value used in elsif' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -71,7 +73,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save return value used in unless' do
+        it 'allows save return value used in unless' do
           content = <<-EOF
           def my_method
             unless @post.save
@@ -83,7 +85,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save return value used in if_mod' do
+        it 'allows save return value used in if_mod' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -96,7 +98,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save return value used in unless_mod' do
+        it 'allows save return value used in unless_mod' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -109,7 +111,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save return value used in unless with &&' do
+        it 'allows save return value used in unless with &&' do
           content = <<-EOF
           def my_method
             unless some_method(1) && other_method(2) && @post.save
@@ -121,7 +123,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow save!' do
+        it 'allows save!' do
           content = <<-EOF
           def my_method
             post = Posts.new do |p|
@@ -134,7 +136,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should warn you if you fail to check update_attributes return value' do
+        it 'warns you if you fail to check update_attributes return value' do
           content = <<-EOF
           def my_method
             @post.update_attributes params
@@ -142,10 +144,12 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:2 - check 'update_attributes' return value or use 'update_attributes!'")
+          expect(runner.errors[0].to_s).to eq(
+            "app/helpers/posts_helper.rb:2 - check 'update_attributes' return value or use 'update_attributes!'"
+          )
         end
 
-        it 'should allow update_attributes if return value is checked' do
+        it 'allows update_attributes if return value is checked' do
           content = <<-EOF
           def my_method
             @post.update_attributes(params) or raise "failed to save"
@@ -176,10 +180,12 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:12 - check 'update_attributes' return value or use 'update_attributes!'")
+          expect(runner.errors[0].to_s).to eq(
+            "app/controllers/posts_controller.rb:12 - check 'update_attributes' return value or use 'update_attributes!'"
+          )
         end
 
-        it 'should warn you if you use create which is always unsafe' do
+        it 'warns you if you use create which is always unsafe' do
           content = <<-EOF
           class Post < ActiveRecord::Base
           end
@@ -195,10 +201,12 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:2 - use 'create!' instead of 'create' as the latter may not always save")
+          expect(runner.errors[0].to_s).to eq(
+            "app/helpers/posts_helper.rb:2 - use 'create!' instead of 'create' as the latter may not always save"
+          )
         end
 
-        it 'should warn you if you use create with a block which is always unsafe' do
+        it 'warns you if you use create with a block which is always unsafe' do
           content = <<-EOF
           module Blog
             class Post < ActiveRecord::Base
@@ -223,7 +231,9 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/blog/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/blog/posts_helper.rb:4 - use 'create!' instead of 'create' as the latter may not always save")
+          expect(runner.errors[0].to_s).to eq(
+            "app/helpers/blog/posts_helper.rb:4 - use 'create!' instead of 'create' as the latter may not always save"
+          )
         end
 
         it 'allows create called on non-model classes' do
@@ -241,8 +251,8 @@ module RailsBestPractices
         end
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: CheckSaveReturnValueReview.new(ignored_files: /helpers/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /helpers/))
         content = <<-EOF
           def my_method
             post = Posts.new do |p|

data/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe DefaultScopeIsEvilReview do
-      let(:runner) { Core::Runner.new(reviews: DefaultScopeIsEvilReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should detect default_scope with -> syntax' do
+      it 'detects default_scope with -> syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope -> { order('created_at desc') }
@@ -18,7 +18,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - default_scope is evil')
       end
 
-      it 'should detect default_scope with old syntax' do
+      it 'detects default_scope with old syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope order('created_at desc')
@@ -29,7 +29,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - default_scope is evil')
       end
 
-      it 'should not detect default_scope' do
+      it 'does not detect default_scope' do
         content = <<-EOF
         class User < ActiveRecord::Base
           scope :default, -> { order('created_at desc') }
@@ -39,8 +39,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: DefaultScopeIsEvilReview.new(ignored_files: /user/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /user/))
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope -> { order('created_at desc') }

data/spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe DryBundlerInCapistranoReview do
-      let(:runner) { Core::Runner.new(reviews: DryBundlerInCapistranoReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should dry bundler in capistrno' do
+      it 'dries bundler in capistrno' do
         content = <<-EOF
         namespace :bundler do
           task :create_symlink, roles: :app do
@@ -29,7 +29,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/deploy.rb:1 - dry bundler in capistrano')
       end
 
-      it 'should not dry bundler in capistrano' do
+      it 'does not dry bundler in capistrano' do
         content = <<-EOF
           require 'bundler/capistrano'
         EOF
@@ -37,8 +37,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: DryBundlerInCapistranoReview.new(ignored_files: /deploy\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /deploy\.rb/))
         content = <<-EOF
         namespace :bundler do
           task :create_symlink, roles: :app do

data/spec/rails_best_practices/reviews/hash_syntax_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe HashSyntaxReview do
-      let(:runner) { Core::Runner.new(reviews: HashSyntaxReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should find 1.8 Hash with symbol' do
+      it 'finds 1.8 Hash with symbol' do
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }
@@ -18,7 +18,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - change Hash Syntax to 1.9')
       end
 
-      it 'should not find 1.8 Hash with string' do
+      it 'does not find 1.8 Hash with string' do
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { "foo" => "bar" }
@@ -28,7 +28,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not alert on 1.9 Syntax' do
+      it 'does not alert on 1.9 Syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { foo: :bar }
@@ -38,7 +38,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should ignore haml_out' do
+      it 'ignores haml_out' do
         content = <<~EOF
           %div{ class: "foo1" }
           .div{ class: "foo2" }
@@ -48,7 +48,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not consider hash with array key' do
+      it 'does not consider hash with array key' do
         content = <<-EOF
         transition [:unverified, :verified] => :deleted
         EOF
@@ -56,7 +56,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not consider hash with charaters not valid for symbol' do
+      it 'does not consider hash with charaters not valid for symbol' do
         content = <<-EOF
         receiver.stub(:` => 'Error')
         EOF
@@ -64,8 +64,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: HashSyntaxReview.new(ignored_files: /user/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /user/))
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }

data/spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe IsolateSeedDataReview do
-      let(:runner) { Core::Runner.new(reviews: IsolateSeedDataReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       context 'create' do
-        it 'should isolate seed data' do
+        it 'isolates seed data' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -33,7 +33,7 @@ module RailsBestPractices
       end
 
       context 'new and save' do
-        it 'should isolate seed data for local variable' do
+        it 'isolates seed data for local variable' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -57,7 +57,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('db/migrate/20090818130258_create_roles.rb:9 - isolate seed data')
         end
 
-        it 'should isolate seed data for instance variable' do
+        it 'isolates seed data for instance variable' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -82,7 +82,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should not isolate seed data without data insert' do
+      it 'does not isolate seed data without data insert' do
         content = <<-EOF
         class CreateRoles < ActiveRecord::Migration
           def self.up
@@ -100,8 +100,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: IsolateSeedDataReview.new(ignored_files: /create_roles/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /create_roles/))
         content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up