rails_best_practices 1.20.0 → 1.22.1

data/spec/rails_best_practices/prepares/model_prepare_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe ModelPrepare do
-      let(:runner) { Core::Runner.new(prepares: ModelPrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'models' do
         it 'class_name with modules ::' do
@@ -32,7 +32,7 @@ module RailsBestPractices
       end
 
       context 'associations' do
-        it 'should parse model associations' do
+        it 'parses model associations' do
           content = <<-EOF
           class Project < ActiveRecord::Base
             belongs_to              :portfolio
@@ -43,14 +43,22 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/project.rb', content)
           model_associations = Prepares.model_associations
-          expect(model_associations.get_association('Project', 'portfolio')).to eq('meta' => 'belongs_to', 'class_name' => 'Portfolio')
-          expect(model_associations.get_association('Project', 'project_manager')).to eq('meta' => 'has_one', 'class_name' => 'ProjectManager')
-          expect(model_associations.get_association('Project', 'milestones')).to eq('meta' => 'has_many', 'class_name' => 'Milestone')
-          expect(model_associations.get_association('Project', 'categories')).to eq('meta' => 'has_and_belongs_to_many', 'class_name' => 'Category')
+          expect(model_associations.get_association('Project', 'portfolio')).to eq(
+            'meta' => 'belongs_to', 'class_name' => 'Portfolio'
+          )
+          expect(model_associations.get_association('Project', 'project_manager')).to eq(
+            'meta' => 'has_one', 'class_name' => 'ProjectManager'
+          )
+          expect(model_associations.get_association('Project', 'milestones')).to eq(
+            'meta' => 'has_many', 'class_name' => 'Milestone'
+          )
+          expect(model_associations.get_association('Project', 'categories')).to eq(
+            'meta' => 'has_and_belongs_to_many', 'class_name' => 'Category'
+          )
         end
 
         context 'with class_name option' do
-          it 'should parse belongs_to' do
+          it 'parses belongs_to' do
             content = <<-EOF
             class Post < ActiveRecord::Base
               belongs_to :author, "class_name" => "Person"
@@ -58,10 +66,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/post.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Post', 'author')).to eq('meta' => 'belongs_to', 'class_name' => 'Person')
+            expect(model_associations.get_association('Post', 'author')).to eq(
+              'meta' => 'belongs_to', 'class_name' => 'Person'
+            )
           end
 
-          it 'should parse has_one' do
+          it 'parses has_one' do
             content = <<-EOF
             class Project < ActiveRecord::Base
               has_one :project_manager, "class_name" => "Person"
@@ -69,10 +79,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/post.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Project', 'project_manager')).to eq('meta' => 'has_one', 'class_name' => 'Person')
+            expect(model_associations.get_association('Project', 'project_manager')).to eq(
+              'meta' => 'has_one', 'class_name' => 'Person'
+            )
           end
 
-          it 'should parse has_many' do
+          it 'parses has_many' do
             content = <<-EOF
             class Project < ActiveRecord::Base
               has_many :people, "class_name" => "Person"
@@ -80,10 +92,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/project.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Project', 'people')).to eq('meta' => 'has_many', 'class_name' => 'Person')
+            expect(model_associations.get_association('Project', 'people')).to eq(
+              'meta' => 'has_many', 'class_name' => 'Person'
+            )
           end
 
-          it 'should parse has_and_belongs_to_many' do
+          it 'parses has_and_belongs_to_many' do
             content = <<-EOF
             class Citizen < ActiveRecord::Base
               has_and_belongs_to_many :nations, "class_name" => "Country"
@@ -91,11 +105,13 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/citizen.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Citizen', 'nations')).to eq('meta' => 'has_and_belongs_to_many', 'class_name' => 'Country')
+            expect(model_associations.get_association('Citizen', 'nations')).to eq(
+              'meta' => 'has_and_belongs_to_many', 'class_name' => 'Country'
+            )
           end
 
           context 'namespace' do
-            it 'should parse with namespace' do
+            it 'parses with namespace' do
               content = <<-EOF
               class Community < ActiveRecord::Base
                 has_many :members
@@ -110,11 +126,15 @@ module RailsBestPractices
               runner.prepare('app/models/community/member.rb', content)
               runner.after_prepare
               model_associations = Prepares.model_associations
-              expect(model_associations.get_association('Community', 'members')).to eq('meta' => 'has_many', 'class_name' => 'Community::Member')
-              expect(model_associations.get_association('Community::Member', 'community')).to eq('meta' => 'belongs_to', 'class_name' => 'Community')
+              expect(model_associations.get_association('Community', 'members')).to eq(
+                'meta' => 'has_many', 'class_name' => 'Community::Member'
+              )
+              expect(model_associations.get_association('Community::Member', 'community')).to eq(
+                'meta' => 'belongs_to', 'class_name' => 'Community'
+              )
             end
 
-            it 'should parse without namespace' do
+            it 'parses without namespace' do
               content = <<-EOF
               class Community::Member::Rating < ActiveRecord::Base
                 belongs_to :member
@@ -129,14 +149,18 @@ module RailsBestPractices
               runner.prepare('app/models/community/member.rb', content)
               runner.after_prepare
               model_associations = Prepares.model_associations
-              expect(model_associations.get_association('Community::Member::Rating', 'member')).to eq('meta' => 'belongs_to', 'class_name' => 'Community::Member')
-              expect(model_associations.get_association('Community::Member', 'ratings')).to eq('meta' => 'has_many', 'class_name' => 'Community::Member::Rating')
+              expect(model_associations.get_association('Community::Member::Rating', 'member')).to eq(
+                'meta' => 'belongs_to', 'class_name' => 'Community::Member'
+              )
+              expect(model_associations.get_association('Community::Member', 'ratings')).to eq(
+                'meta' => 'has_many', 'class_name' => 'Community::Member::Rating'
+              )
             end
           end
         end
 
         context 'mongoid embeds' do
-          it 'should parse embeds_many' do
+          it 'parses embeds_many' do
             content = <<-EOF
             class Person
               include Mongoid::Document
@@ -145,10 +169,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/person.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Person', 'addresses')).to eq('meta' => 'embeds_many', 'class_name' => 'Address')
+            expect(model_associations.get_association('Person', 'addresses')).to eq(
+              'meta' => 'embeds_many', 'class_name' => 'Address'
+            )
           end
 
-          it 'should parse embeds_one' do
+          it 'parses embeds_one' do
             content = <<-EOF
             class Lush
               include Mongoid::Document
@@ -157,10 +183,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/lush.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Lush', 'whiskey')).to eq('meta' => 'embeds_one', 'class_name' => 'Drink')
+            expect(model_associations.get_association('Lush', 'whiskey')).to eq(
+              'meta' => 'embeds_one', 'class_name' => 'Drink'
+            )
           end
 
-          it 'should parse embedded_in' do
+          it 'parses embedded_in' do
             content = <<-EOF
             class Drink
               include Mongoid::Document
@@ -169,12 +197,14 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/drink.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Drink', 'alcoholic')).to eq('meta' => 'embedded_in', 'class_name' => 'Lush')
+            expect(model_associations.get_association('Drink', 'alcoholic')).to eq(
+              'meta' => 'embedded_in', 'class_name' => 'Lush'
+            )
           end
         end
 
         context 'mongomapper many/one' do
-          it 'should parse one' do
+          it 'parses one' do
             content = <<-EOF
             class Employee
               include MongoMapper::Document
@@ -183,10 +213,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/employee.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Employee', 'desk')).to eq('meta' => 'one', 'class_name' => 'Desk')
+            expect(model_associations.get_association('Employee', 'desk')).to eq(
+              'meta' => 'one', 'class_name' => 'Desk'
+            )
           end
 
-          it 'should parse many' do
+          it 'parses many' do
             content = <<-EOF
             class Tree
               include MongoMapper::Document
@@ -201,7 +233,7 @@ module RailsBestPractices
       end
 
       context 'methods' do
-        it 'should parse model methods' do
+        it 'parses model methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def save; end
@@ -213,7 +245,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(%w[save find])
         end
 
-        it 'should parse model methods with access control' do
+        it 'parses model methods with access control' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def save; end
@@ -232,7 +264,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post', 'private').map(&:method_name)).to eq(['find_by_sql'])
         end
 
-        it 'should parse model methods with module ::' do
+        it 'parses model methods with module ::' do
           content = <<-EOF
           class Admin::Blog::Post < ActiveRecord::Base
             def save; end
@@ -244,7 +276,7 @@ module RailsBestPractices
           expect(methods.get_methods('Admin::Blog::Post').map(&:method_name)).to eq(%w[save find])
         end
 
-        it 'should parse model methods with module' do
+        it 'parses model methods with module' do
           content = <<-EOF
           module Admin
             module Blog
@@ -260,7 +292,7 @@ module RailsBestPractices
           expect(methods.get_methods('Admin::Blog::Post').map(&:method_name)).to eq(%w[save find])
         end
 
-        it 'should not add methods from module' do
+        it 'does not add methods from module' do
           content = <<-EOF
             class Model < ActiveRecord::Base
             end
@@ -279,7 +311,7 @@ module RailsBestPractices
       end
 
       context 'scope' do
-        it 'should treat named_scope as method' do
+        it 'treats named_scope as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
@@ -290,7 +322,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(['active'])
         end
 
-        it 'should treat scope as method' do
+        it 'treats scope as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
@@ -303,7 +335,7 @@ module RailsBestPractices
       end
 
       context 'alias' do
-        it 'should treat alias as method' do
+        it 'treats alias as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             alias :new :old
@@ -314,7 +346,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(['new'])
         end
 
-        it 'should treat alias_method as method' do
+        it 'treats alias_method as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             alias_method :new, :old
@@ -325,7 +357,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(['new'])
         end
 
-        it 'should treat alias_method_chain as method' do
+        it 'treats alias_method_chain as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             alias_method_chain :method, :feature
@@ -338,7 +370,7 @@ module RailsBestPractices
       end
 
       context 'attributes' do
-        it 'should parse mongoid field' do
+        it 'parses mongoid field' do
           content = <<-EOF
           class Post
             include Mongoid::Document
@@ -358,7 +390,7 @@ module RailsBestPractices
           expect(model_attributes.get_attribute_type('Post', 'active')).to eq('Boolean')
         end
 
-        it 'should parse mongomapper field' do
+        it 'parses mongomapper field' do
           content = <<-EOF
           class Post
             include MongoMapper::Document
@@ -382,13 +414,17 @@ module RailsBestPractices
       end
 
       context 'no error' do
-        it 'should raised for finder_sql option' do
+        it 'raiseds for finder_sql option' do
           content = <<-EOF
           class EventSubscription < ActiveRecord::Base
             has_many :event_notification_template, finder_sql: ?
           end
           EOF
-          content = content.sub('?', '\'SELECT event_notification_templates.* from event_notification_templates where event_type_id=#{event_type_id} and delivery_method_id=#{delivery_method_id}\'')
+          content =
+            content.sub(
+              '?',
+              '\'SELECT event_notification_templates.* from event_notification_templates where event_type_id=#{event_type_id} and delivery_method_id=#{delivery_method_id}\''
+            )
           expect { runner.prepare('app/models/event_subscription.rb', content) }.not_to raise_error
         end
       end