rails_best_practices 1.20.0 → 1.22.1

data/spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe KeepFindersOnTheirOwnModelReview do
-      let(:runner) { Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should keep finders on thier own model' do
+      it 'keeps finders on thier own model' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -23,7 +23,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/post.rb:5 - keep finders on their own model')
       end
 
-      it 'should keep finders on thier own model with all method' do
+      it 'keeps finders on thier own model with all method' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -39,7 +39,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/post.rb:5 - keep finders on their own model')
       end
 
-      it 'should not keep finders on thier own model with self finder' do
+      it 'does not keep finders on thier own model with self finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -54,7 +54,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not keep finders on thier own model with own finder' do
+      it 'does not keep finders on thier own model with own finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -69,7 +69,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not keep finders on their own model without finder' do
+      it 'does not keep finders on their own model without finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -83,7 +83,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not keep finders on their own model with ruby Array#find' do
+      it 'does not keep finders on their own model with ruby Array#find' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -97,8 +97,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new(ignored_files: /app\/models\/post\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/models/post\.rb}))
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -5,10 +5,14 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe LawOfDemeterReview do
-      let(:runner) { Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: LawOfDemeterReview.new) }
+      let(:runner) do
+        Core::Runner.new(
+          prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: described_class.new
+        )
+      end
 
       describe 'belongs_to' do
-        before(:each) do
+        before do
           content = <<-EOF
           class Invoice < ActiveRecord::Base
             belongs_to :user
@@ -28,7 +32,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it 'should law of demeter with erb' do
+        it 'laws of demeter with erb' do
           content = <<-EOF
           <%= @invoice.user.name %>
           <%= @invoice.user.address %>
@@ -39,7 +43,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.erb:1 - law of demeter')
         end
 
-        it 'should law of demeter with haml' do
+        it 'laws of demeter with haml' do
           content = <<~EOF
             = @invoice.user.name
             = @invoice.user.address
@@ -50,7 +54,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.haml:1 - law of demeter')
         end
 
-        it 'should law of demeter with slim' do
+        it 'laws of demeter with slim' do
           content = <<~EOF
             = @invoice.user.name
             = @invoice.user.address
@@ -61,7 +65,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.slim:1 - law of demeter')
         end
 
-        it 'should no law of demeter' do
+        it 'noes law of demeter' do
           content = <<-EOF
           <%= @invoice.user_name %>
           <%= @invoice.user_address %>
@@ -73,7 +77,7 @@ module RailsBestPractices
       end
 
       describe 'has_one' do
-        before(:each) do
+        before do
           content = <<-EOF
           class Invoice < ActiveRecord::Base
             has_one :price
@@ -92,7 +96,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it 'should law of demeter' do
+        it 'laws of demeter' do
           content = <<-EOF
           <%= @invoice.price.currency %>
           <%= @invoice.price.number %>
@@ -104,7 +108,7 @@ module RailsBestPractices
       end
 
       context 'polymorphic association' do
-        before :each do
+        before do
           content = <<-EOF
           class Comment < ActiveRecord::Base
             belongs_to :commentable, polymorphic: true
@@ -129,7 +133,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it 'should law of demeter' do
+        it 'laws of demeter' do
           content = <<-EOF
           <%= @comment.commentable.title %>
           EOF
@@ -139,7 +143,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should no law of demeter with method call' do
+      it 'noes law of demeter with method call' do
         content = <<-EOF
         class Question < ActiveRecord::Base
           has_many :answers, dependent: :destroy
@@ -163,9 +167,12 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
-                                  reviews: LawOfDemeterReview.new(ignored_files: /app\/views\/invoices/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
+            reviews: described_class.new(ignored_files: %r{app/views/invoices})
+          )
         content = <<-EOF
           <%= @invoice.user.name %>
           <%= @invoice.user.address %>

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoControllerReview do
-      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoControllerReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move code into controller for method call' do
+      it 'moves code into controller for method call' do
         content = <<-EOF
         <% Post.find(:all).each do |post| %>
           <%=h post.title %>
@@ -19,7 +19,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
       end
 
-      it 'should move code into controller for assign' do
+      it 'moves code into controller for assign' do
         content = <<-EOF
         <% @posts = Post.all %>
         <% @posts.each do |post| %>
@@ -32,7 +32,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
       end
 
-      it 'should not move code into controller' do
+      it 'does not move code into controller' do
         content = <<-EOF
         <% @posts.each do |post| %>
           <%=h post.title %>
@@ -43,8 +43,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new(ignored_files: /app\/views\/post/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/views/post}))
         content = <<-EOF
         <% Post.find(:all).each do |post| %>
           <%=h post.title %>

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoHelperReview do
-      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoHelperReview.new('array_count' => 2)) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new('array_count' => 2)) }
 
-      it 'should move code into helper' do
+      it 'moves code into helper' do
         content = <<-EOF
         <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
                                                     [t(:published), "published"]],
@@ -15,10 +15,12 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)'
+        )
       end
 
-      it 'should not move code into helper with simple arguments' do
+      it 'does not move code into helper with simple arguments' do
         content = <<-EOF
         <%= select_tag :state, options_for_select( Post.STATES ) %>
         EOF
@@ -26,8 +28,11 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => /app\/views\/post/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => %r{app/views/post})
+          )
         content = <<-EOF
         <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
                                                     [t(:published), "published"]],

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoModelReview do
-      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move code into model' do
+      it 'moves code into model' do
         content = <<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
@@ -15,48 +15,58 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model with haml' do
+      it 'moves code into model with haml' do
         content = <<~EOF
           - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
             = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.haml', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model with slim' do
+      it 'moves code into model with slim' do
         content = <<~EOF
           - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
             = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.slim', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model with if in one line' do
+      it 'moves code into model with if in one line' do
         content = <<-EOF
         <%= link_to 'Edit this post', edit_post_url(@post) if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it "should move code into model with '? :'" do
+      it "moves code into model with '? :'" do
         content = <<-EOF
         <%= current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) ? link_to('Edit this post', edit_post_url(@post)) : '' %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model only review for current if conditional statement' do
+      it 'moves code into model only review for current if conditional statement' do
         content = <<-EOF
         <% if @post.title %>
           <% if @post.user %>
@@ -69,7 +79,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move code into model' do
+      it 'does not move code into model' do
         content = <<-EOF
         <% if @post.editable_by?(current_user) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
@@ -79,7 +89,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move code into model for multiple calls on same variable node' do
+      it 'does not move code into model for multiple calls on same variable node' do
         content = <<-EOF
         <% if !job.company.blank? && job.company.title? %>
         <% end %>
@@ -88,8 +98,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveCodeIntoModelReview.new(ignored_files: /app\/views\/post/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/views/post}))
         content = <<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>

data/spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveFinderToNamedScopeReview do
-      let(:runner) { Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move finder to named_scope' do
+      it 'moves finder to named_scope' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -27,7 +27,7 @@ module RailsBestPractices
         expect(runner.errors[1].to_s).to eq('app/controllers/posts_controller.rb:7 - move finder to named_scope')
       end
 
-      it 'should not move simple finder' do
+      it 'does not move simple finder' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -44,7 +44,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move namd_scope' do
+      it 'does not move namd_scope' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -57,7 +57,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not review model file' do
+      it 'does not review model file' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           def published
@@ -75,8 +75,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new(ignored_files: /app\/controllers\/posts/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/controllers/posts}))
         content = <<-EOF
         class PostsController < ActionController::Base
           def index

data/spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveModelLogicIntoModelReview do
-      let(:runner) { Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move model logic into model' do
+      it 'moves model logic into model' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -26,10 +26,12 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)'
+        )
       end
 
-      it 'should not move model logic into model with simple model calling' do
+      it 'does not move model logic into model with simple model calling' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -45,7 +47,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move model logic into model with self calling' do
+      it 'does not move model logic into model with self calling' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -61,8 +63,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new(ignored_files: /app\/controllers\/posts/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/controllers/posts}))
         content = <<-EOF
         class PostsController < ApplicationController
           def publish

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NeedlessDeepNestingReview do
-      let(:runner) { Core::Runner.new(reviews: NeedlessDeepNestingReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should needless deep nesting' do
+      it 'needlesses deep nesting' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -20,7 +20,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it 'should not needless deep nesting for shallow' do
+      it 'does not needless deep nesting for shallow' do
         content = <<-EOF
         resources :posts, shallow: true do
           resources :comments do
@@ -32,7 +32,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not needless deep nesting for shallow 4 levels' do
+      it 'does not needless deep nesting for shallow 4 levels' do
         content = <<-EOF
         resources :applications, shallow: true, only: [:index, :show, :create] do
           resources :events, only: [:index, :show, :create, :subscribe, :push] do
@@ -46,7 +46,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should needless deep nesting with resource' do
+      it 'needlesses deep nesting with resource' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -59,7 +59,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it 'should needless deep nesting with block node' do
+      it 'needlesses deep nesting with block node' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -73,7 +73,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it 'should no needless deep nesting' do
+      it 'noes needless deep nesting' do
         content = <<-EOF
         resources :posts do
           resources :comments
@@ -88,8 +88,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: NeedlessDeepNestingReview.new(ignored_files: /config\/routes/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{config/routes}))
         content = <<-EOF
           map.resources :posts do |post|
             post.resources :comments do |comment|

data/spec/rails_best_practices/reviews/not_rescue_exception_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotRescueExceptionReview do
-      let(:runner) { Core::Runner.new(reviews: NotRescueExceptionReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       describe 'not_rescue_exception' do
-        it 'should not rescue exception in method rescue with named var' do
+        it 'does not rescue exception in method rescue with named var' do
           content = <<-EOF
           def my_method
             do_something
@@ -21,7 +21,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
-        it 'should not rescue exception in method rescue without named var' do
+        it 'does not rescue exception in method rescue without named var' do
           content = <<-EOF
           def my_method
             do_something
@@ -34,7 +34,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
-        it 'should not rescue exception in block rescue with named var' do
+        it 'does not rescue exception in block rescue with named var' do
           content = <<-EOF
           def my_method
             begin
@@ -49,7 +49,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
-        it 'should not rescue exception in block rescue without named var' do
+        it 'does not rescue exception in block rescue without named var' do
           content = <<-EOF
           def my_method
             begin
@@ -64,7 +64,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
-        it 'should allow rescue implicit StandardError in block rescue without named var' do
+        it 'allows rescue implicit StandardError in block rescue without named var' do
           content = <<-EOF
           def my_method
             begin
@@ -78,7 +78,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow rescue explicit StandardError in block rescue without named var' do
+        it 'allows rescue explicit StandardError in block rescue without named var' do
           content = <<-EOF
           def my_method
             begin
@@ -92,8 +92,8 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not check ignored files' do
-          runner = Core::Runner.new(reviews: NotRescueExceptionReview.new(ignored_files: /posts_helper/))
+        it 'does not check ignored files' do
+          runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_helper/))
           content = <<-EOF
           def my_method
             do_something

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotUseDefaultRouteReview do
-      let(:runner) { Core::Runner.new(reviews: NotUseDefaultRouteReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should not use default route' do
+      it 'does not use default route' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts
@@ -20,7 +20,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:4 - not use default route')
       end
 
-      it 'should no not use default route' do
+      it 'noes not use default route' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts
@@ -30,8 +30,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{config/routes\.rb}))
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts