rails_best_practices 0.6.6 → 0.6.7

data/spec/rails_best_practices/{checks/use_say_with_time_in_migrations_check_spec.rb → reviews/use_say_with_time_in_migrations_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck do
-  before :each do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck.new)
-  end
+describe RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview.new) }
 
   it "should use say with time in migrations" do
     content =<<-EOF
@@ -14,11 +12,9 @@ describe RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck do
       end
     end
     EOF
-    @runner.review('db/migrate/20101010080658_update_users.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors.size.should == 1
-    errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations"
+    runner.review('db/migrate/20101010080658_update_users.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations"
   end
 
   it "should use say with time in migrations with create_table" do
@@ -35,11 +31,9 @@ describe RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck do
       end
     end
     EOF
-    @runner.review('db/migrate/20101010080658_update_users.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors.size.should == 1
-    errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations"
+    runner.review('db/migrate/20101010080658_update_users.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations"
   end
 
   it "should not use say with time in migrations" do
@@ -54,9 +48,8 @@ describe RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck do
       end
     end
     EOF
-    @runner.review('db/migrate/20101010080658_update_users.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/migrate/20101010080658_update_users.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not use say with time when default migration message" do
@@ -69,9 +62,8 @@ describe RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck do
       end
     end
     EOF
-    @runner.review('db/migrate/20101010080658_create_users.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/migrate/20101010080658_create_users.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not raise an error" do
@@ -106,8 +98,7 @@ describe RailsBestPractices::Checks::UseSayWithTimeInMigrationsCheck do
       end
     end
     EOF
-    @runner.review('db/migrate/20101010080658_create_users.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/migrate/20101010080658_create_users.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/use_scope_access_check_spec.rb → reviews/use_scope_access_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::UseScopeAccessCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseScopeAccessCheck.new)
-  end
+describe RailsBestPractices::Reviews::UseScopeAccessReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseScopeAccessReview.new) }
 
   context "if" do
     it "shoud use scope access" do
@@ -20,10 +18,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
     end
 
     it "shoud use scope access by comparing with id" do
@@ -40,10 +37,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
     end
 
     it "shoud use scope access with current_user ==" do
@@ -60,10 +56,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
     end
 
     it "shoud use scope access by current_user.id ==" do
@@ -80,10 +75,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
     end
   end
 
@@ -102,10 +96,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "shoud use scope access by comparing with id" do
@@ -122,10 +115,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "shoud use scope access with current_user ==" do
@@ -142,10 +134,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "shoud use scope access by current_user.id ==" do
@@ -162,10 +153,9 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "should no error in use_scope_access_review" do
@@ -187,7 +177,8 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
         end
       end
       EOF
-      @runner.review('app/controllers/comments_controller.rb', content)
+      runner.review('app/controllers/comments_controller.rb', content)
+      runner.should have(0).errors
     end
   end
 end

data/spec/rails_best_practices_spec.rb

@@ -8,7 +8,7 @@ describe RailsBestPractices do
       dir = File.dirname(__FILE__)
       RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices_spec.rb')
       RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/core/visitable_sexp_spec.rb')
-      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/checks/check_spec.rb')
+      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/reviews/review_spec.rb')
     end
   end
 
@@ -27,9 +27,9 @@ describe RailsBestPractices do
   end
 
   describe "output_terminal_errors" do
-    check1 = RailsBestPractices::Checks::LawOfDemeterCheck.new
-    check2 = RailsBestPractices::Checks::UseQueryAttributeCheck.new
-    runner = RailsBestPractices::Core::Runner.new(check1, check2)
+    check1 = RailsBestPractices::Reviews::LawOfDemeterReview.new
+    check2 = RailsBestPractices::Reviews::UseQueryAttributeReview.new
+    runner = RailsBestPractices::Core::Runner.new(:reviews => [check1, check2])
     check1.add_error "law of demeter", "app/models/user.rb", 10
     check2.add_error "use query attribute", "app/models/post.rb", 100
     RailsBestPractices.runner = runner

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
+require 'rspec/expectations'
 require 'rails_best_practices'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  hash: 11
-  prerelease: false
+  hash: 9
+  prerelease: 
   segments: 
   - 0
   - 6
-  - 6
-  version: 0.6.6
+  - 7
+  version: 0.6.7
 platform: ruby
 authors: 
 - Richard Huang
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-24 00:00:00 +08:00
+date: 2011-02-14 00:00:00 +08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -30,10 +30,10 @@ dependencies:
         - 0
         - 4
         version: 2.0.4
-  name: ruby_parser
   prerelease: false
-  type: :runtime
   version_requirements: *id001
+  type: :runtime
+  name: ruby_parser
 - !ruby/object:Gem::Dependency 
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
@@ -46,10 +46,10 @@ dependencies:
         - 0
         - 9
         version: 0.0.9
-  name: ruby-progressbar
   prerelease: false
-  type: :runtime
   version_requirements: *id002
+  type: :runtime
+  name: ruby-progressbar
 - !ruby/object:Gem::Dependency 
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
@@ -61,10 +61,10 @@ dependencies:
         - 1
         - 2
         version: "1.2"
-  name: colored
   prerelease: false
-  type: :runtime
   version_requirements: *id003
+  type: :runtime
+  name: colored
 - !ruby/object:Gem::Dependency 
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
@@ -77,10 +77,10 @@ dependencies:
         - 6
         - 6
         version: 2.6.6
-  name: erubis
   prerelease: false
-  type: :runtime
   version_requirements: *id004
+  type: :runtime
+  name: erubis
 - !ruby/object:Gem::Dependency 
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
@@ -93,10 +93,10 @@ dependencies:
         - 0
         - 18
         version: 3.0.18
-  name: haml
   prerelease: false
-  type: :runtime
   version_requirements: *id005
+  type: :runtime
+  name: haml
 - !ruby/object:Gem::Dependency 
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
@@ -107,10 +107,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: i18n
   prerelease: false
-  type: :runtime
   version_requirements: *id006
+  type: :runtime
+  name: i18n
 - !ruby/object:Gem::Dependency 
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
@@ -121,28 +121,42 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: activesupport
   prerelease: false
-  type: :runtime
   version_requirements: *id007
+  type: :runtime
+  name: activesupport
 - !ruby/object:Gem::Dependency 
   requirement: &id008 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  prerelease: false
+  version_requirements: *id008
+  type: :development
+  name: rake
+- !ruby/object:Gem::Dependency 
+  requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 13
+        hash: 31
         segments: 
         - 2
+        - 4
         - 0
-        - 1
-        version: 2.0.1
-  name: rspec
+        version: 2.4.0
   prerelease: false
+  version_requirements: *id009
   type: :development
-  version_requirements: *id008
+  name: rspec
 - !ruby/object:Gem::Dependency 
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -152,12 +166,12 @@ dependencies:
         - 0
         - 6
         version: "0.6"
-  name: watchr
   prerelease: false
+  version_requirements: *id010
   type: :development
-  version_requirements: *id009
+  name: watchr
 - !ruby/object:Gem::Dependency 
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  requirement: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -168,10 +182,10 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  name: bundler
   prerelease: false
+  version_requirements: *id011
   type: :development
-  version_requirements: *id010
+  name: bundler
 description: a code metric tool for rails codes, written in Ruby.
 email: 
 - flyerhzm@gmail.com
@@ -196,69 +210,77 @@ files:
 - bin/rails_best_practices
 - install_supported_rubies.sh
 - lib/rails_best_practices.rb
-- lib/rails_best_practices/checks.rb
-- lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb
-- lib/rails_best_practices/checks/always_add_db_index_check.rb
-- lib/rails_best_practices/checks/check.rb
-- lib/rails_best_practices/checks/dry_bundler_in_capistrano_check.rb
-- lib/rails_best_practices/checks/isolate_seed_data_check.rb
-- lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
-- lib/rails_best_practices/checks/law_of_demeter_check.rb
-- lib/rails_best_practices/checks/move_code_into_controller_check.rb
-- lib/rails_best_practices/checks/move_code_into_helper_check.rb
-- lib/rails_best_practices/checks/move_code_into_model_check.rb
-- lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb
-- lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
-- lib/rails_best_practices/checks/needless_deep_nesting_check.rb
-- lib/rails_best_practices/checks/not_use_default_route_check.rb
-- lib/rails_best_practices/checks/overuse_route_customizations_check.rb
-- lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb
-- lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb
-- lib/rails_best_practices/checks/use_before_filter_check.rb
-- lib/rails_best_practices/checks/use_model_association_check.rb
-- lib/rails_best_practices/checks/use_observer_check.rb
-- lib/rails_best_practices/checks/use_query_attribute_check.rb
-- lib/rails_best_practices/checks/use_say_with_time_in_migrations_check.rb
-- lib/rails_best_practices/checks/use_scope_access_check.rb
 - lib/rails_best_practices/command.rb
 - lib/rails_best_practices/core.rb
+- lib/rails_best_practices/core/check.rb
 - lib/rails_best_practices/core/checking_visitor.rb
 - lib/rails_best_practices/core/error.rb
 - lib/rails_best_practices/core/runner.rb
 - lib/rails_best_practices/core/visitable_sexp.rb
 - lib/rails_best_practices/core_ext/enumerable.rb
 - lib/rails_best_practices/core_ext/nil_class.rb
+- lib/rails_best_practices/prepares.rb
+- lib/rails_best_practices/prepares/mailer_prepare.rb
+- lib/rails_best_practices/prepares/model_prepare.rb
+- lib/rails_best_practices/reviews.rb
+- lib/rails_best_practices/reviews/add_model_virtual_attribute_review.rb
+- lib/rails_best_practices/reviews/always_add_db_index_review.rb
+- lib/rails_best_practices/reviews/dry_bundler_in_capistrano_review.rb
+- lib/rails_best_practices/reviews/isolate_seed_data_review.rb
+- lib/rails_best_practices/reviews/keep_finders_on_their_own_model_review.rb
+- lib/rails_best_practices/reviews/law_of_demeter_review.rb
+- lib/rails_best_practices/reviews/move_code_into_controller_review.rb
+- lib/rails_best_practices/reviews/move_code_into_helper_review.rb
+- lib/rails_best_practices/reviews/move_code_into_model_review.rb
+- lib/rails_best_practices/reviews/move_finder_to_named_scope_review.rb
+- lib/rails_best_practices/reviews/move_model_logic_into_model_review.rb
+- lib/rails_best_practices/reviews/needless_deep_nesting_review.rb
+- lib/rails_best_practices/reviews/not_use_default_route_review.rb
+- lib/rails_best_practices/reviews/overuse_route_customizations_review.rb
+- lib/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review.rb
+- lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
+- lib/rails_best_practices/reviews/review.rb
+- lib/rails_best_practices/reviews/use_before_filter_review.rb
+- lib/rails_best_practices/reviews/use_model_association_review.rb
+- lib/rails_best_practices/reviews/use_observer_review.rb
+- lib/rails_best_practices/reviews/use_query_attribute_review.rb
+- lib/rails_best_practices/reviews/use_say_with_time_in_migrations_review.rb
+- lib/rails_best_practices/reviews/use_scope_access_review.rb
 - lib/rails_best_practices/version.rb
 - rails_best_practices.gemspec
 - rails_best_practices.yml
 - rake_rubies.sh
-- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
-- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
-- spec/rails_best_practices/checks/check_spec.rb
-- spec/rails_best_practices/checks/dry_bundler_in_capistrano_check_spec.rb
-- spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
-- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
-- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
-- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
-- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
-- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
-- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
-- spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
-- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
-- spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
-- spec/rails_best_practices/checks/use_model_association_check_spec.rb
-- spec/rails_best_practices/checks/use_observer_check_spec.rb
-- spec/rails_best_practices/checks/use_query_attribute_check_spec.rb
-- spec/rails_best_practices/checks/use_say_with_time_in_migrations_check_spec.rb
-- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
+- spec/rails_best_practices/core/check_spec.rb
+- spec/rails_best_practices/core/checking_visitor_spec.rb
 - spec/rails_best_practices/core/error_spec.rb
 - spec/rails_best_practices/core/visitable_sexp_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
 - spec/rails_best_practices/core_ext/nil_class_spec.rb
+- spec/rails_best_practices/prepares/mailer_prepare_spec.rb
+- spec/rails_best_practices/prepares/model_prepare_spec.rb
+- spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
+- spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
+- spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
+- spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb
+- spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb
+- spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb
+- spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb
+- spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
+- spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb
+- spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb
+- spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb
+- spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb
+- spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb
+- spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb
+- spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb
+- spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb
+- spec/rails_best_practices/reviews/review_spec.rb
+- spec/rails_best_practices/reviews/use_before_filter_review_spec.rb
+- spec/rails_best_practices/reviews/use_model_association_review_spec.rb
+- spec/rails_best_practices/reviews/use_observer_review_spec.rb
+- spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb
+- spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb
+- spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
 - spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
@@ -270,7 +292,7 @@ post_install_message: |
   
     rails_best_practices is a code metric tool to check the quality of rails codes.
   
-    I highly recommend you go through the Rails Best Practices website first.
+    I highly recommend you browse the Rails Best Practices website first.
   
         http://rails-bestpractices.com
   
@@ -307,37 +329,41 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.4.2
 signing_key: 
 specification_version: 3
 summary: a code metric tool for rails codes.
 test_files: 
-- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
-- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
-- spec/rails_best_practices/checks/check_spec.rb
-- spec/rails_best_practices/checks/dry_bundler_in_capistrano_check_spec.rb
-- spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
-- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
-- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
-- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
-- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
-- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
-- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
-- spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
-- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
-- spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
-- spec/rails_best_practices/checks/use_model_association_check_spec.rb
-- spec/rails_best_practices/checks/use_observer_check_spec.rb
-- spec/rails_best_practices/checks/use_query_attribute_check_spec.rb
-- spec/rails_best_practices/checks/use_say_with_time_in_migrations_check_spec.rb
-- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
+- spec/rails_best_practices/core/check_spec.rb
+- spec/rails_best_practices/core/checking_visitor_spec.rb
 - spec/rails_best_practices/core/error_spec.rb
 - spec/rails_best_practices/core/visitable_sexp_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
 - spec/rails_best_practices/core_ext/nil_class_spec.rb
+- spec/rails_best_practices/prepares/mailer_prepare_spec.rb
+- spec/rails_best_practices/prepares/model_prepare_spec.rb
+- spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
+- spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
+- spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
+- spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb
+- spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb
+- spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb
+- spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb
+- spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
+- spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb
+- spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb
+- spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb
+- spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb
+- spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb
+- spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb
+- spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb
+- spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb
+- spec/rails_best_practices/reviews/review_spec.rb
+- spec/rails_best_practices/reviews/use_before_filter_review_spec.rb
+- spec/rails_best_practices/reviews/use_model_association_review_spec.rb
+- spec/rails_best_practices/reviews/use_observer_review_spec.rb
+- spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb
+- spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb
+- spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
 - spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb