rails_best_practices 0.6.6 → 0.6.7

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Reviews::MoveCodeIntoHelperReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveCodeIntoHelperReview.new('array_count' => 2)) }
+
+  it "should move code into helper" do
+    content = <<-EOF
+    <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
+                                                [t(:published), "published"]],
+                                               params[:default_state] ) %>
+    EOF
+    runner.review('app/views/posts/show.html.erb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/views/posts/show.html.erb:3 - move code into helper (array_count >= 2)"
+  end
+
+  it "should not move code into helper with simple arguments" do
+    content = <<-EOF
+    <%= select_tag :state, options_for_select( Post.STATES ) %>
+    EOF
+    runner.review('app/views/posts/show.html.erb', content)
+    runner.should have(0).errors
+  end
+end

data/spec/rails_best_practices/{checks/move_code_into_model_check_spec.rb → reviews/move_code_into_model_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::MoveCodeIntoModelCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveCodeIntoModelCheck.new)
-  end
+describe RailsBestPractices::Reviews::MoveCodeIntoModelReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveCodeIntoModelReview.new) }
 
   it "should move code into model" do
     content =<<-EOF
@@ -11,10 +9,9 @@ describe RailsBestPractices::Checks::MoveCodeIntoModelCheck do
       <%= link_to 'Edit this post', edit_post_url(@post) %>
     <% end %>
     EOF
-    @runner.review('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)"
+    runner.review('app/views/posts/show.html.erb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)"
   end
 
   it "should move code into model with haml" do
@@ -22,10 +19,9 @@ describe RailsBestPractices::Checks::MoveCodeIntoModelCheck do
 - if current_user && (current_user == @post.user || @post.editors.include?(current_user))
   = link_to 'Edit this post', edit_post_url(@post)
     EOF
-    @runner.review('app/views/posts/show.html.haml', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)"
+    runner.review('app/views/posts/show.html.haml', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)"
   end
 
   it "should move code into model only review for current if conditional statement" do
@@ -37,9 +33,8 @@ describe RailsBestPractices::Checks::MoveCodeIntoModelCheck do
       <% end %>
     <% end %>
     EOF
-    @runner.review('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/views/posts/show.html.erb', content)
+    runner.should have(0).errors
   end
 
   it "should not move code into model" do
@@ -48,8 +43,7 @@ describe RailsBestPractices::Checks::MoveCodeIntoModelCheck do
       <%= link_to 'Edit this post', edit_post_url(@post) %>
     <% end %>
     EOF
-    @runner.review('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/views/posts/show.html.erb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/move_finder_to_named_scope_check_spec.rb → reviews/move_finder_to_named_scope_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::MoveFinderToNamedScopeCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveFinderToNamedScopeCheck.new)
-  end
+describe RailsBestPractices::Reviews::MoveFinderToNamedScopeReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveFinderToNamedScopeReview.new) }
 
   it "should move finder to named_scope" do
     content = <<-EOF
@@ -20,11 +18,10 @@ describe RailsBestPractices::Checks::MoveFinderToNamedScopeCheck do
       end
     end
     EOF
-    @runner.review('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.size.should == 2
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:4 - move finder to named_scope"
-    errors[1].to_s.should == "app/controllers/posts_controller.rb:8 - move finder to named_scope"
+    runner.review('app/controllers/posts_controller.rb', content)
+    runner.should have(2).errors
+    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:4 - move finder to named_scope"
+    runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:8 - move finder to named_scope"
   end
 
   it "should not move simple finder" do
@@ -41,8 +38,8 @@ describe RailsBestPractices::Checks::MoveFinderToNamedScopeCheck do
       end
     end
     EOF
-    @runner.review('app/controllers/posts_controller.rb', content)
-    @runner.errors.should be_empty
+    runner.review('app/controllers/posts_controller.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not move namd_scope" do
@@ -55,8 +52,8 @@ describe RailsBestPractices::Checks::MoveFinderToNamedScopeCheck do
       end
     end
     EOF
-    @runner.review('app/controllers/posts_controller.rb', content)
-    @runner.errors.should be_empty
+    runner.review('app/controllers/posts_controller.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not review model file" do
@@ -75,8 +72,7 @@ describe RailsBestPractices::Checks::MoveFinderToNamedScopeCheck do
 
     end
     EOF
-    @runner.review('app/model/post.rb', content)
-    @runner.errors.should be_empty
-
+    runner.review('app/model/post.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/move_model_logic_into_model_check_spec.rb → reviews/move_model_logic_into_model_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::MoveModelLogicIntoModelCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveModelLogicIntoModelCheck.new)
-  end
+describe RailsBestPractices::Reviews::MoveModelLogicIntoModelReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveModelLogicIntoModelReview.new) }
 
   it "should move model logic into model" do
     content = <<-EOF
@@ -23,10 +21,9 @@ describe RailsBestPractices::Checks::MoveModelLogicIntoModelCheck do
       redirect_to post_url(@post)
     end
     EOF
-    @runner.review('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - move model logic into model (@post use_count > 4)"
+    runner.review('app/controllers/posts_controller.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - move model logic into model (@post use_count > 4)"
   end
 
   it "should not move model logic into model with simple model calling" do
@@ -42,8 +39,7 @@ describe RailsBestPractices::Checks::MoveModelLogicIntoModelCheck do
       redirect_to post_url(@post)
     end
     EOF
-    @runner.review('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/controllers/posts_controller.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/needless_deep_nesting_check_spec.rb → reviews/needless_deep_nesting_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::NeedlessDeepNestingCheck.new)
-  end
+describe RailsBestPractices::Reviews::NeedlessDeepNestingReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::NeedlessDeepNestingReview.new) }
 
   describe "rails2" do
     it "should needless deep nesting" do
@@ -14,10 +12,9 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
     end
 
     it "should needless deep nesting with resource" do
@@ -28,10 +25,9 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
     end
 
     it "should needless deep nesting with block node" do
@@ -43,10 +39,9 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         post.resources :votes
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
     end
 
     it "should no needless deep nesting" do
@@ -59,9 +54,8 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         comment.resources :favorites
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
 
     it "should no needless deep nesting with block node" do
@@ -71,9 +65,8 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         comment.resources :votes
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
   end
 
@@ -86,10 +79,9 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
     end
 
     it "should needless deep nesting with resource" do
@@ -100,10 +92,9 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
     end
 
     it "should needless deep nesting with block node" do
@@ -115,10 +106,9 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         resources :votes
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
     end
 
     it "should no needless deep nesting" do
@@ -132,9 +122,8 @@ describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
         resources :favorites
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
   end
 end

data/spec/rails_best_practices/{checks/not_use_default_route_check_spec.rb → reviews/not_use_default_route_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::NotUseDefaultRouteCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::NotUseDefaultRouteCheck.new)
-  end
+describe RailsBestPractices::Reviews::NotUseDefaultRouteReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::NotUseDefaultRouteReview.new) }
 
   describe "rails2" do
     it "should not use default route" do
@@ -15,11 +13,10 @@ describe RailsBestPractices::Checks::NotUseDefaultRouteCheck do
         map.connect ':controller/:action/:id.:format'
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:4 - not use default route"
-      errors[1].to_s.should == "config/routes.rb:5 - not use default route"
+      runner.review('config/routes.rb', content)
+      runner.should have(2).errors
+      runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
+      runner.errors[1].to_s.should == "config/routes.rb:5 - not use default route"
     end
 
     it "should no not use default route" do
@@ -28,9 +25,8 @@ describe RailsBestPractices::Checks::NotUseDefaultRouteCheck do
         map.resources :posts, :member => { :push => :post }
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
   end
 
@@ -43,10 +39,9 @@ describe RailsBestPractices::Checks::NotUseDefaultRouteCheck do
         match ':controller(/:action(/:id(.:format)))'
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:5 - not use default route"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:5 - not use default route"
     end
 
     it "should no not use default route" do
@@ -55,9 +50,8 @@ describe RailsBestPractices::Checks::NotUseDefaultRouteCheck do
         resources :posts
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
   end
 end

data/spec/rails_best_practices/{checks/overuse_route_customizations_check_spec.rb → reviews/overuse_route_customizations_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::OveruseRouteCustomizationsCheck.new)
-  end
+describe RailsBestPractices::Reviews::OveruseRouteCustomizationsReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::OveruseRouteCustomizationsReview.new) }
 
   describe "rails2" do
     it "should overuse route customizations" do
@@ -15,10 +13,9 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
                                            :delete_comment => :delete }
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
     end
 
     it "should overuse route customizations with collection" do
@@ -30,10 +27,9 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
                               :collection => { :comments => :get }
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
     end
 
     it "should overuse route customizations with collection 2" do
@@ -47,10 +43,9 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
     end
 
     it "should not overuse route customizations without customization" do
@@ -59,9 +54,8 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         map.resources :posts
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
 
     it "should not overuse route customizations when customize route is only one" do
@@ -70,9 +64,8 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         map.resources :posts, :member => { :vote => :post }
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
 
     it "should not raise error for constants in routes" do
@@ -84,9 +77,8 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
   end
 
@@ -107,10 +99,9 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
     end
 
     it "should overuse route customizations another way" do
@@ -124,10 +115,9 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
     end
 
     it "should not overuse route customizations without customization" do
@@ -136,9 +126,8 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         resources :posts
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
 
     it "should not overuse route customizations when customize route is only one" do
@@ -151,9 +140,8 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
         end
       end
       EOF
-      @runner.review('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('config/routes.rb', content)
+      runner.should have(0).errors
     end
   end
 end