rails_best_practices 0.6.6 → 0.6.7

data/spec/rails_best_practices/{checks/always_add_db_index_check_spec.rb → reviews/always_add_db_index_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::AlwaysAddDbIndexCheck.new)
-  end
+describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::AlwaysAddDbIndexReview.new) }
 
   it "should always add db index" do
     content = <<-EOF
@@ -15,11 +13,10 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       end
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [post_id])"
-    errors[1].to_s.should == "db/schema.rb:2 - always add db index (comments => [user_id])"
+    runner.review('db/schema.rb', content)
+    runner.should have(2).errors
+    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [post_id])"
+    runner.errors[1].to_s.should == "db/schema.rb:2 - always add db index (comments => [user_id])"
   end
 
   it "should always add db index with polymorphic foreign key" do
@@ -32,10 +29,9 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       end
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
+    runner.review('db/schema.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
   end
 
   it "should always add db index with polymorphic foreign key and _type is defined before _id" do
@@ -48,11 +44,9 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       end
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors.size.should == 1
-    errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
+    runner.review('db/schema.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
   end
 
   it "should always add db index with single index, but without polymorphic foreign key" do
@@ -67,10 +61,9 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       add_index "taggings", ["tag_id"], :name => "index_taggings_on_tag_id"
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])"
+    runner.review('db/schema.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])"
   end
 
   it "should always add db index with polymorphic foreign key, but without single index" do
@@ -85,10 +78,9 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       add_index "taggings", ["taggable_id", "taggable_type"], :name => "index_taggings_on_taggable_id_and_taggable_type"
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [tag_id])"
+    runner.review('db/schema.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [tag_id])"
   end
 
   it "should not always add db index with column has no id" do
@@ -100,9 +92,8 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       end
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/schema.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not always add db index with add_index" do
@@ -118,9 +109,8 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       add_index "comments", ["user_id"], :name => "index_comments_on_user_id"
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/schema.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not always add db index with only _type column" do
@@ -131,9 +121,8 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       end
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/schema.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not always add db index with multi-column index" do
@@ -148,9 +137,8 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       add_index "versions", ["versioned_id", "versioned_type"], :name => "index_versions_on_versioned_id_and_versioned_type"
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/schema.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not always add db index if there is an index contains more columns" do
@@ -165,8 +153,7 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
       add_index "taggings", ["taggable_id", "taggable_type", "context"], :name => "index_taggings_on_taggable_id_and_taggable_type_and_context"
     end
     EOF
-    @runner.review('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/schema.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/dry_bundler_in_capistrano_check_spec.rb → reviews/dry_bundler_in_capistrano_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::DryBundlerInCapistranoCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::DryBundlerInCapistranoCheck.new)
-  end
+describe RailsBestPractices::Reviews::DryBundlerInCapistranoReview do
+  let(:runner) { runner = RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::DryBundlerInCapistranoReview.new) }
 
   it "should dry bundler in capistrno" do
     content = <<-EOF
@@ -22,18 +20,16 @@ describe RailsBestPractices::Checks::DryBundlerInCapistranoCheck do
 
     after 'deploy:update_code', 'bundler:bundle_new_release'
     EOF
-    @runner.review('config/deploy.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "config/deploy.rb:1 - dry bundler in capistrano"
+    runner.review('config/deploy.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "config/deploy.rb:1 - dry bundler in capistrano"
   end
 
   it "should not dry bundler in capistrano" do
     content = <<-EOF
       require 'bundler/capistrano'
     EOF
-    @runner.review('config/deploy.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('config/deploy.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/isolate_seed_data_check_spec.rb → reviews/isolate_seed_data_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::IsolateSeedDataCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::IsolateSeedDataCheck.new)
-  end
+describe RailsBestPractices::Reviews::IsolateSeedDataReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::IsolateSeedDataReview.new) }
 
   context "create" do
     it "should isolate seed data" do
@@ -24,11 +22,9 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
         end
       end
       EOF
-      @runner.review('db/migrate/20090818130258_create_roles.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:8 - isolate seed data"
-      errors.size.should == 1
+      runner.review('db/migrate/20090818130258_create_roles.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:8 - isolate seed data"
     end
   end
 
@@ -52,10 +48,9 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
         end
       end
       EOF
-      @runner.review('db/migrate/20090818130258_create_roles.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
+      runner.review('db/migrate/20090818130258_create_roles.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
     end
 
     it "should isolate seed data for instance variable" do
@@ -77,10 +72,9 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
         end
       end
       EOF
-      @runner.review('db/migrate/20090818130258_create_roles.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
+      runner.review('db/migrate/20090818130258_create_roles.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
     end
   end
 
@@ -98,8 +92,7 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
       end
     end
     EOF
-    @runner.review('db/migrate/20090818130258_create_roles.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('db/migrate/20090818130258_create_roles.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/keep_finders_on_their_own_model_check_spec.rb → reviews/keep_finders_on_their_own_model_review_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck.new)
-  end
+describe RailsBestPractices::Reviews::KeepFindersOnTheirOwnModelReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::KeepFindersOnTheirOwnModelReview.new) }
 
   it "should keep finders on thier own model" do
     content = <<-EOF
@@ -16,10 +14,9 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
       end
     end
     EOF
-    @runner.review('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/models/post.rb:5 - keep finders on their own model"
+    runner.review('app/models/post.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/models/post.rb:5 - keep finders on their own model"
   end
 
   it "should keep finders on thier own model with all method" do
@@ -33,10 +30,9 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
       end
     end
     EOF
-    @runner.review('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/models/post.rb:5 - keep finders on their own model"
+    runner.review('app/models/post.rb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/models/post.rb:5 - keep finders on their own model"
   end
 
   it "should not keep finders on thier own model with self finder" do
@@ -50,9 +46,8 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
       end
     end
     EOF
-    @runner.review('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/models/post.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not keep finders on thier own model with own finder" do
@@ -66,9 +61,8 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
       end
     end
     EOF
-    @runner.review('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/models/post.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not keep finders on their own model without finder" do
@@ -81,9 +75,8 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
       end
     end
     EOF
-    @runner.review('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/models/post.rb', content)
+    runner.should have(0).errors
   end
 
   it "should not keep finders on their own model with ruby Array#find" do
@@ -96,8 +89,7 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
       end
     end
     EOF
-    @runner.review('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/models/post.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/{checks/law_of_demeter_check_spec.rb → reviews/law_of_demeter_review_spec.rb}

@@ -1,10 +1,13 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Checks::LawOfDemeterCheck do
+describe RailsBestPractices::Reviews::LawOfDemeterReview do
 
-  before :each do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::LawOfDemeterCheck.new)
-  end
+  let(:runner) {
+    RailsBestPractices::Core::Runner.new(
+      :prepares => RailsBestPractices::Prepares::ModelPrepare.new,
+      :reviews => RailsBestPractices::Reviews::LawOfDemeterReview.new
+    )
+  }
 
   describe "belongs_to" do
     before(:each) do
@@ -13,7 +16,7 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
         belongs_to :user
       end
       EOF
-      @runner.prepare('app/models/invoice.rb', content)
+      runner.prepare('app/models/invoice.rb', content)
     end
 
     it "should law of demeter" do
@@ -22,10 +25,9 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
       <%= @invoice.user.address %>
       <%= @invoice.user.cellphone %>
       EOF
-      @runner.review('app/views/invoices/show.html.erb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
+      runner.review('app/views/invoices/show.html.erb', content)
+      runner.should have(3).errors
+      runner.errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
     end
 
     it "should law of demeter" do
@@ -34,10 +36,9 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
 = @invoice.user.address
 = @invoice.user.cellphone
       EOF
-      @runner.review('app/views/invoices/show.html.haml', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/views/invoices/show.html.haml:1 - law of demeter"
+      runner.review('app/views/invoices/show.html.haml', content)
+      runner.should have(3).errors
+      runner.errors[0].to_s.should == "app/views/invoices/show.html.haml:1 - law of demeter"
     end
 
     it "should no law of demeter" do
@@ -46,9 +47,8 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
       <%= @invoice.user_address %>
       <%= @invoice.user_cellphone %>
       EOF
-      @runner.review('app/views/invoices/show.html.erb', content)
-      errors = @runner.errors
-      errors.should be_empty
+      runner.review('app/views/invoices/show.html.erb', content)
+      runner.should have(0).errors
     end
   end
 
@@ -59,7 +59,7 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
         has_one :price
       end
       EOF
-      @runner.prepare('app/models/invoice.rb', content)
+      runner.prepare('app/models/invoice.rb', content)
     end
 
     it "should law of demeter" do
@@ -67,10 +67,9 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
       <%= @invoice.price.currency %>
       <%= @invoice.price.number %>
       EOF
-      @runner.review('app/views/invoices/show.html.erb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
+      runner.review('app/views/invoices/show.html.erb', content)
+      runner.should have(2).errors
+      runner.errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
     end
   end
 
@@ -80,13 +79,13 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
       has_many :answers, :dependent => :destroy
     end
     EOF
-    @runner.prepare('app/models/question.rb', content)
+    runner.prepare('app/models/question.rb', content)
     content = <<-EOF
     class Answer < ActiveRecord::Base
       belongs_to :question, :counter_cache => true, :touch => true
     end
     EOF
-    @runner.prepare('app/models/answer.rb', content)
+    runner.prepare('app/models/answer.rb', content)
     content = <<-EOF
     class CommentsController < ApplicationController
       def comment_url
@@ -94,8 +93,7 @@ describe RailsBestPractices::Checks::LawOfDemeterCheck do
       end
     end
     EOF
-    @runner.review('app/controllers/comments_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
+    runner.review('app/controllers/comments_controller.rb', content)
+    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Reviews::MoveCodeIntoControllerReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveCodeIntoControllerReview.new) }
+
+  it "should move code into controller" do
+    content = <<-EOF
+    <% @posts = Post.find(:all) %>
+    <% @posts.each do |post| %>
+      <%=h post.title %>
+      <%=h post.content %>
+    <% end %>
+    EOF
+    runner.review('app/views/posts/index.html.erb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
+  end
+
+  it "should not move code into controller" do
+    content = <<-EOF
+    <% @posts.each do |post| %>
+      <%=h post.title %>
+      <%=h post.content %>
+    <% end %>
+    EOF
+    runner.review('app/views/posts/index.html.erb', content)
+    runner.should have(0).errors
+  end
+end