rails_best_practices 0.4.0 → 0.4.1

data/spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb

@@ -1,76 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::ReplaceComplexCreationWithFactoryMethodCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::ReplaceComplexCreationWithFactoryMethodCheck.new)
-  end
-  
-  it "should replace complex creation with factory method" do
-    content = <<-EOF
-    class InvoiceController < ApplicationController
-      
-      def create
-        @invoice = Invoice.new(params[:invoice])
-        @invoice.address = current_user.address
-        @invoice.phone = current_user.phone
-        @invoice.vip = (@invoice.amount > 1000)
-        
-        if Time.now.day > 15
-          @invoice.deliver_time = Time.now + 2.month
-        else
-          @invoice.deliver_time = Time.now + 1.month
-        end
-        
-        @invoice.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/invoices_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/invoices_controller.rb:3 - replace complex creation with factory method (@invoice attribute_assignment_count > 2)"
-  end
-
-  it "should not replace complex creation with factory method with simple creation" do
-    content = <<-EOF
-    class InvoiceController < ApplicationController
-
-      def create
-        @invoice = Invoice.new(params[:invoice])
-        @invoice.address = current_user.address
-        @invoice.phone = current_user.phone
-        @invoice.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/invoices_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not replace complex creation with factory method when attrasgn_count is 5" do
-    content = <<-EOF
-    class InvoiceController < ApplicationController
-
-      def create
-        @invoice = Invoice.new(params[:invoice])
-        @invoice.address = current_user.address
-        @invoice.phone = current_user.phone
-        @invoice.vip = (@invoice.amount > 1000)
-
-        if Time.now.day > 15
-          @invoice.deliver_time = Time.now + 2.month
-        else
-          @invoice.deliver_time = Time.now + 1.month
-        end
-
-        @invoice.save
-      end
-    end
-    EOF
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::ReplaceComplexCreationWithFactoryMethodCheck.new('attribute_assignment_count' => 5))
-    @runner.check('app/controllers/invoices_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb

@@ -1,36 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::ReplaceInstanceVariableWithLocalVariableCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::ReplaceInstanceVariableWithLocalVariableCheck.new)
-  end
-
-  it "should replace instance variable with local varialbe" do
-    content = <<-EOF
-    <%= @post.title %>
-    EOF
-    @runner.check('app/views/posts/_post.html.erb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/_post.html.erb:1 - replace instance variable with local variable"
-  end
-
-  it "should replace instance variable with local varialbe in haml file" do
-    content = <<-EOF
-= @post.title
-    EOF
-    @runner.check('app/views/posts/_post.html.haml', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/_post.html.haml:1 - replace instance variable with local variable"
-  end
-
-  it "should not replace instance variable with local varialbe" do
-    content = <<-EOF
-    <%= post.title %>
-    EOF
-    @runner.check('app/views/posts/_post.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/use_before_filter_check_spec.rb

@@ -1,85 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::UseBeforeFilterCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseBeforeFilterCheck.new)
-  end
-  
-  it "should use before_filter" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def show
-        @post = current_user.posts.find(params[:id])
-      end
-
-      def edit
-        @post = current_user.posts.find(params[:id])
-      end
-
-      def update
-        @post = current_user.posts.find(params[:id])
-        @post.update_attributes(params[:post])
-      end
-
-      def destroy
-        @post = current_user.posts.find(params[:id])
-        @post.destroy
-      end
-
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:3,7,11,16 - use before_filter for show,edit,update,destroy"
-  end
-  
-  it "should not use before_filter" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-      before_filter :find_post, :only => [:show, :edit, :update, :destroy]
-
-      def update
-        @post.update_attributes(params[:post])
-      end
-
-      def destroy
-        @post.destroy
-      end
-
-      protected
-
-      def find_post
-        @post = current_user.posts.find(params[:id])
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not use before_filter by nil" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def show
-      end
-
-      def edit
-      end
-
-      def update
-      end
-
-      def destroy
-      end
-
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/use_model_association_check_spec.rb

@@ -1,71 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::UseModelAssociationCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseModelAssociationCheck.new)
-  end
-  
-  it "should use model association for instance variable" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-      
-      def create
-        @post = Post.new(params[:post])
-        @post.user_id = current_user.id
-        @post.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - use model association (for @post)"
-  end
-
-  it "should not use model association without association assign" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def create
-        @post = Post.new(params[:post])
-        @post.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should use model association for local variable" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def create
-        post = Post.new(params[:post])
-        post.user_id = current_user.id
-        post.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - use model association (for post)"
-  end
-
-  it "should not use model association" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def create
-        post = current_user.posts.buid(params[:post])
-        post.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/use_observer_check_spec.rb

@@ -1,67 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::UseObserverCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseObserverCheck.new)
-  end
-
-  it "should use observer" do
-    content =<<-EOF
-    class Project < ActiveRecord::Base
-      after_create :send_create_notification
-
-      private
-
-      def send_create_notification
-        self.members.each do |member|
-          ProjectMailer.deliver_notification(self, member)
-        end
-      end
-    end
-    EOF
-    @runner.check('app/models/project.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/models/project.rb:6 - use observer"
-  end
-
-  it "should not use observer without callback" do
-    content =<<-EOF
-    class Project < ActiveRecord::Base
-      private
-
-      def send_create_notification
-        self.members.each do |member|
-          ProjectMailer.deliver_notification(self, member)
-        end
-      end
-    end
-    EOF
-    @runner.check('app/models/project.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should use observer with two after_create" do
-    content =<<-EOF
-    class Project < ActiveRecord::Base
-      after_create :send_create_notification, :update_author
-
-      private
-
-      def send_create_notification
-        self.members.each do |member|
-          ProjectMailer.deliver_notification(self, member)
-        end
-      end
-
-      def update_author
-      end
-    end
-    EOF
-    @runner.check('app/models/project.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/models/project.rb:6 - use observer"
-  end
-end

data/spec/rails_best_practices/checks/use_scope_access_check_spec.rb

@@ -1,193 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::UseScopeAccessCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseScopeAccessCheck.new)
-  end
-  
-  context "if" do
-    it "shoud use scope access" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-      
-        def edit
-          @post = Post.find(params[:id])
-        
-          if @post.user != current_user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
-    end
-
-    it "shoud use scope access by comparing with id" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if @post.user_id != current_user.id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
-    end
-
-    it "shoud use scope access with current_user ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if current_user != @post.user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
-    end
-
-    it "shoud use scope access by current_user.id ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if current_user.id != @post.user_id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
-    end
-  end
-
-  context "unless" do
-    it "shoud use scope access" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          unless @post.user == current_user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-
-    it "shoud use scope access by comparing with id" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          unless @post.user_id == current_user.id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-
-    it "shoud use scope access with current_user ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          unless current_user == @post.user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-
-    it "shoud use scope access by current_user.id ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          unless current_user.id == @post.user_id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/posts_controller.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-    
-    it "should no error in use_scope_access_check" do
-      content = <<-EOF
-      class CommentsController < ApplicationController
-      
-        def add_comment
-          @current_user = User.find_by_id(session[:user_id])
-          @id = params[:post_id]
-          @error = ""
-          if (@text = params[:text]) == ""
-            @error = "Please enter a comment!"
-          else
-            @comment = Comment.create_object(@text,  @id, @current_user.id)
-          end
-          unless @comment
-            @error = "Comment could not be saved."
-          end
-        end
-      end
-      EOF
-      @runner.check('app/controllers/comments_controller.rb', content)
-    end
-  end
-end