rails_best_practices 0.4.0 → 0.4.1

data/spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb

@@ -1,113 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::AddModelVirtualAttributeCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::AddModelVirtualAttributeCheck.new)
-  end
-  
-  it "should add model virtual attribute" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-      
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:full_name].split(' ', 2).first
-        @user.last_name = params[:full_name].split(' ', 2).last
-        @user.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/users_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for @user)"
-  end
-  
-  it "should add model virtual attribute with local assignment" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-      
-      def create
-        user = User.new(params[:user])
-        user.first_name = params[:full_name].split(' ', 2).first
-        user.last_name = params[:full_name].split(' ', 2).last
-        user.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/users_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for user)"
-  end
-
-  it "should not add model virtual attribute with differen param" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:first_name]
-        @user.last_name = params[:last_name]
-        @user.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/users_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-  
-  it "should not add model virtual attribute with read" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-      
-      def show
-        if params[:id]
-          @user = User.find(params[:id])
-        else
-          @user = current_user
-        end
-      end
-    end
-    EOF
-    @runner.check('app/controllers/users_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should add model virtual attribute with two dimension params" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:user][:full_name].split(' ', 2).first
-        @user.last_name = params[:user][:full_name].split(' ', 2).last
-        @user.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/users_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for @user)"
-  end
-
-  it "should no add model virtual attribute with two dimension params" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:user][:first_name]
-        @user.last_name = params[:user][:last_name]
-        @user.save
-      end
-    end
-    EOF
-    @runner.check('app/controllers/users_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb

@@ -1,73 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::AlwaysAddDbIndexCheck.new)
-  end
-
-  it "should always add db index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.string "content"
-        t.integer "post_id"
-        t.integer "user_id"
-      end
-    end
-    EOF
-    @runner.check('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/schema.rb:4 - always add db index (comments => post_id)"
-    errors[1].to_s.should == "db/schema.rb:5 - always add db index (comments => user_id)"
-  end
-  
-  it "should always add db index with column has no id" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.string "content"
-        t.integer "position"
-      end
-    end
-    EOF
-    @runner.check('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-  
-  it "should not always add db index with add_index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.string "content"
-        t.integer "post_id"
-        t.integer "user_id"
-      end
-
-      add_index "comments", ["post_id"], :name => "index_comments_on_post_id"
-      add_index "comments", ["user_id"], :name => "index_comments_on_user_id"
-    end
-    EOF
-    @runner.check('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not always add db index with multi-column index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "versions", :force => true do |t|
-        t.integer  "versioned_id"
-        t.string   "versioned_type"
-        t.string   "tag"
-      end
-
-      add_index "versions", ["versioned_id", "versioned_type"], :name => "index_versions_on_versioned_id_and_versioned_type"
-    end
-    EOF
-    @runner.check('db/schema.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb

@@ -1,76 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::IsolateSeedDataCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::IsolateSeedDataCheck.new)
-  end
-
-  it "should isolate seed data" do
-    content = <<-EOF
-    class CreateRoles < ActiveRecord::Migration
-      def self.up
-        create_table "roles", :force => true do |t|
-          t.string :name
-        end
-
-        ["admin", "author", "editor", "account"].each do |name|
-          Role.create!(:name => name)
-        end
-      end
-
-      def self.down
-        drop_table "roles"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:8 - isolate seed data"
-    errors.size.should == 1
-  end
-  
-  it "should isolate seed data with new and save" do
-    content = <<-EOF
-    class CreateRoles < ActiveRecord::Migration
-      def self.up
-        create_table "roles", :force => true do |t|
-          t.string :name
-        end
-  
-        ["admin", "author", "editor", "account"].each do |name|
-          role = Role.new(:name => name)
-          role.save!
-        end
-      end
-  
-      def self.down
-        drop_table "roles"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
-  end
-  
-  it "should not isolate seed data without data insert" do
-    content = <<-EOF
-    class CreateRoles < ActiveRecord::Migration
-      def self.up
-        create_table "roles", :force => true do |t|
-          t.string :name
-        end
-      end
-  
-      def self.down
-        drop_table "roles"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb

@@ -1,103 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck.new)
-  end
-
-  it "should keep finders on thier own model" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      has_many :comments
-
-      def find_valid_comments
-        self.comment.find(:all, :conditions => { :is_spam => false }, 
-                                :limit => 10)
-      end
-    end
-    EOF
-    @runner.check('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/models/post.rb:5 - keep finders on their own model"
-  end
-
-  it "should keep finders on thier own model with all method" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      has_many :comments
-
-      def find_valid_comments
-        self.comment.all(:conditions => { :is_spam => false },
-                         :limit => 10)
-      end
-    end
-    EOF
-    @runner.check('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/models/post.rb:5 - keep finders on their own model"
-  end
-
-  it "should not keep finders on thier own model with self finder" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      has_many :comments
-
-      def find_valid_comments
-        self.find(:all, :conditions => { :is_spam => false }, 
-                                :limit => 10)
-      end
-    end
-    EOF
-    @runner.check('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not keep finders on thier own model with own finder" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      has_many :comments
-
-      def find_valid_comments
-        Post.find(:all, :conditions => { :is_spam => false }, 
-                                :limit => 10)
-      end
-    end
-    EOF
-    @runner.check('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not keep finders on their own model without finder" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      has_many :comments
-
-      def find_valid_comments
-        self.comments.destroy_all
-      end
-    end
-    EOF
-    @runner.check('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not keep finders on their own model with ruby Array#find" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      has_many :comments
-
-      def active_comments
-        self.comments.find {|comment| comment.status == 'active'}
-      end
-    end
-    EOF
-    @runner.check('app/models/post.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/law_of_demeter_check_spec.rb

@@ -1,76 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::LawOfDemeterCheck do
-  
-  describe "belongs_to" do
-    before(:each) do
-      @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::LawOfDemeterCheck.new)
-
-      content = <<-EOF
-      class Invoice < ActiveRecord::Base
-        belongs_to :user
-      end
-      EOF
-      @runner.check('app/models/invoice.rb', content)
-    end
-
-    it "should law of demeter" do
-      content = <<-EOF
-      <%= @invoice.user.name %>
-      <%= @invoice.user.address %>
-      <%= @invoice.user.cellphone %>
-      EOF
-      @runner.check('app/views/invoices/show.html.erb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
-    end
-
-    it "should law of demeter" do
-      content = <<-EOF
-= @invoice.user.name
-= @invoice.user.address
-= @invoice.user.cellphone
-      EOF
-      @runner.check('app/views/invoices/show.html.haml', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/views/invoices/show.html.haml:1 - law of demeter"
-    end
-
-    it "should no law of demeter" do
-      content = <<-EOF
-      <%= @invoice.user_name %>
-      <%= @invoice.user_address %>
-      <%= @invoice.user_cellphone %>
-      EOF
-      @runner.check('app/views/invoices/show.html.erb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-
-  describe "has_one" do
-    before(:each) do
-      @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::LawOfDemeterCheck.new)
-
-      content = <<-EOF
-      class Invoice < ActiveRecord::Base
-        has_one :price
-      end
-      EOF
-      @runner.check('app/models/invoice.rb', content)
-    end
-
-    it "should law of demeter" do
-      content = <<-EOF
-      <%= @invoice.price.currency %>
-      <%= @invoice.price.number %>
-      EOF
-      @runner.check('app/views/invoices/show.html.erb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
-    end
-  end
-end

data/spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb

@@ -1,33 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::MoveCodeIntoControllerCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveCodeIntoControllerCheck.new)
-  end
-  
-  it "should move code into controller" do
-    content = <<-EOF
-    <% @posts = Post.find(:all) %>
-    <% @posts.each do |post| %>
-      <%=h post.title %>
-      <%=h post.content %>
-    <% end %>
-    EOF
-    @runner.check('app/views/posts/index.html.erb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
-  end
-
-  it "should not move code into controller" do
-    content = <<-EOF
-    <% @posts.each do |post| %>
-      <%=h post.title %>
-      <%=h post.content %>
-    <% end %>
-    EOF
-    @runner.check('app/views/posts/index.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end