rails_best_practices 0.4.0 → 0.4.1

data/spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb

@@ -1,29 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::MoveCodeIntoHelperCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveCodeIntoHelperCheck.new('array_count' => 2))
-  end
-
-  it "should move code into helper" do
-    content = <<-EOF
-    <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
-                                                [t(:published), "published"]],
-                                               params[:default_state] ) %>
-    
-    EOF
-    @runner.check('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/show.html.erb:3 - move code into helper (array_count >= 2)"
-  end
-
-  it "should not move code into helper with simple arguments" do
-    content = <<-EOF
-    <%= select_tag :state, options_for_select( Post.STATES ) %>
-    EOF
-    @runner.check('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/move_code_into_model_check_spec.rb

@@ -1,55 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::MoveCodeIntoModelCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveCodeIntoModelCheck.new)
-  end
-
-  it "should move code into model" do
-    content =<<-EOF
-    <% if current_user && (current_user == @post.user || @post.editors.include?(current_user)) %>
-      <%= link_to 'Edit this post', edit_post_url(@post) %>
-    <% end %>
-    EOF
-    @runner.check('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into model (@post)"
-  end
-
-  it "should move code into model with haml" do
-    content =<<-EOF
-- if current_user && (current_user == @post.user || @post.editors.include?(current_user))
-  = link_to 'Edit this post', edit_post_url(@post)
-    EOF
-    @runner.check('app/views/posts/show.html.haml', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/posts/show.html.haml:1 - move code into model (@post)"
-  end
-  
-  it "should move code into model only check for current if conditional statement" do
-    content =<<-EOF
-    <% if @post.title %>
-      <% if @post.user %>
-        <% if @post.description %>
-        <% end %>
-      <% end %>
-    <% end %>
-    EOF
-    @runner.check('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not move code into model" do
-    content =<<-EOF
-    <% if @post.editable_by?(current_user) %>
-      <%= link_to 'Edit this post', edit_post_url(@post) %>
-    <% end %>
-    EOF
-    @runner.check('app/views/posts/show.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb

@@ -1,82 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::MoveFinderToNamedScopeCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveFinderToNamedScopeCheck.new)
-  end
-  
-  it "should move finder to named_scope" do
-    content = <<-EOF
-    class PostsController < ActionController::Base
-
-      def index
-        @public_posts = Post.find(:all, :conditions => { :state => 'public' },
-                                        :limit => 10,
-                                        :order => 'created_at desc')
-
-        @draft_posts  = Post.find(:all, :conditions => { :state => 'draft' },
-                                        :limit => 10,
-                                        :order => 'created_at desc')
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.size.should == 2
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:4 - move finder to named_scope"
-    errors[1].to_s.should == "app/controllers/posts_controller.rb:8 - move finder to named_scope"
-  end
-  
-  it "should not move simple finder" do
-    content = <<-EOF
-    class PostsController < ActionController::Base
-
-      def index
-        @all_posts = Post.find(:all)
-        @another_all_posts = Post.all
-        @first_post = Post.find(:first)
-        @another_first_post = Post.first
-        @last_post = Post.find(:last)
-        @another_last_post = Post.last
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    @runner.errors.should be_empty
-  end
-  
-  it "should not move namd_scope" do
-    content = <<-EOF
-    class PostsController < ActionController::Base
-
-      def index
-        @public_posts = Post.published
-        @draft_posts  = Post.draft
-      end
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    @runner.errors.should be_empty
-  end
-  
-  it "should not check model file" do
-    content = <<-EOF
-    class Post < ActiveRecord::Base
-      
-      def published
-        Post.find(:all, :conditions => { :state => 'public' },
-                        :limit => 10, :order => 'created_at desc')
-      end
-
-      def published
-        Post.find(:all, :conditions => { :state => 'draft' },
-                        :limit => 10, :order => 'created_at desc')
-      end
-                          
-    end
-    EOF
-    @runner.check('app/model/post.rb', content)
-    @runner.errors.should be_empty
-    
-  end
-end

data/spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb

@@ -1,49 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::MoveModelLogicIntoModelCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveModelLogicIntoModelCheck.new)
-  end
-  
-  it "should move model logic into model" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-      
-      def publish
-        @post = Post.find(params[:id])
-        @post.update_attributes(:is_published, true)
-        @post.approved_by = current_user
-        if @post.created_at > Time.now - 7.days
-          @post.popular = 100
-        else
-          @post.popular = 0
-        end
-      end
-      
-      redirect_to post_url(@post)
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - move model logic into model (@post called_count > 4)"
-  end
-
-  it "should not move model logic into model with simple model calling" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def publish
-        @post = Post.find(params[:id])
-        @post.update_attributes(:is_published, true)
-        @post.approved_by = current_user
-      end
-
-      redirect_to post_url(@post)
-    end
-    EOF
-    @runner.check('app/controllers/posts_controller.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-end

data/spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb

@@ -1,70 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::NeedlessDeepNestingCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::NeedlessDeepNestingCheck.new)
-  end
-  
-  describe "rails2" do
-    it "should needless deep nesting" do
-      content = <<-EOF
-      map.resources :posts do |post|
-        post.resources :comments do |comment|
-          comment.resources :favorites
-        end
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
-
-    it "should no needless deep nesting" do
-      content = <<-EOF
-      map.resources :posts do |post|
-        post.resources :comments
-      end
-      
-      map.resources :comments do |comment|
-        comment.resources :favorites
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-
-  describe "rails3" do
-    it "should needless deep nesting" do
-      content = <<-EOF
-      resources :posts do
-        resources :comments do
-          resources :favorites
-        end
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
-    end
-
-    it "should no needless deep nesting" do
-      content = <<-EOF
-      resources :posts do
-        resources :comments
-        resources :votes
-      end
-      
-      resources :comments do
-        resources :favorites
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-end

data/spec/rails_best_practices/checks/not_use_default_route_check_spec.rb

@@ -1,63 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::NotUseDefaultRouteCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::NotUseDefaultRouteCheck.new)
-  end
-  
-  describe "rails2" do
-    it "should not use default route" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :push => :post }
-        
-        map.connect ':controller/:action/:id'
-        map.connect ':controller/:action/:id.:format'
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:4 - not use default route"
-      errors[1].to_s.should == "config/routes.rb:5 - not use default route"
-    end
-
-    it "should no not use default route" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :push => :post }
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-
-  describe "rails3" do
-    it "should not use default route" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts
-        
-        match ':controller(/:action(/:id(.:format)))'
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:5 - not use default route"
-    end
-
-    it "should no not use default route" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-end

data/spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb

@@ -1,145 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::OveruseRouteCustomizationsCheck.new)
-  end
-
-  describe "rails2" do
-    it "should overuse route customizations" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :comments => :get,
-                                           :create_comment => :post,
-                                           :update_comment => :post,
-                                           :delete_comment => :post }
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
-    
-    it "should overuse route customizations with collection" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :create_comment => :post,
-                                           :update_comment => :post,
-                                           :delete_comment => :post },
-                              :collection => { :comments => :get }
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
-
-    it "should overuse route customizations with collection 2" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :categories do |category|
-          category.resources :posts, :member => { :create_comment => :post,
-                                                  :update_comment => :post,
-                                                  :delete_comment => :post },
-                                     :collection => { :comments => :get }
-        end
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
-    end
-    
-    it "should not overuse route customizations without customization" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-
-    it "should not overuse route customizations when customize route is only one" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :vote => :post }
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-
-  describe "rails3" do
-    it "should overuse route customizations" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts do
-          member do
-            post :create_comment
-            post :update_comment
-            post :delete_comment
-          end
-
-          collection do
-            get :comments
-          end
-        end
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
-
-    it "should overuse route customizations another way" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts do
-          post :create_comment, :on => :member
-          post :update_comment, :on => :member
-          post :delete_comment, :on => :member
-          get :comments, :on => :collection
-        end
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should_not be_empty
-      errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
-    
-    it "should not overuse route customizations without customization" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-
-    it "should not overuse route customizations when customize route is only one" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts do
-          member do
-            post :vote
-          end
-        end
-      end
-      EOF
-      @runner.check('config/routes.rb', content)
-      errors = @runner.errors
-      errors.should be_empty
-    end
-  end
-end