puppet 7.28.0 → 7.29.1

data/spec/unit/type/file/content_spec.rb

@@ -1,440 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:file).attrclass(:content), :uses_checksums => true do
-  include PuppetSpec::Files
-  include_context 'with supported checksum types'
-
-  let(:filename) { tmpfile('testfile') }
-  let(:environment) { Puppet::Node::Environment.create(:testing, []) }
-  let(:catalog) { Puppet::Resource::Catalog.new(:test, environment) }
-  let(:resource) { Puppet::Type.type(:file).new :path => filename, :catalog => catalog, :backup => 'puppet' }
-
-  before do
-    File.open(filename, 'w') {|f| f.write "initial file content"}
-  end
-
-  around do |example|
-    Puppet.override(:environments => Puppet::Environments::Static.new(environment)) do
-      example.run
-    end
-  end
-
-  describe "when determining the actual content to write" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    it "should use the set content if available" do
-      content.should = "ehness"
-      expect(content.actual_content).to eq("ehness")
-    end
-
-    it "should not use the content from the source if the source is set" do
-      expect(resource).not_to receive(:parameter).with(:source)
-
-      expect(content.actual_content).to be_nil
-    end
-  end
-
-  describe "when setting the desired content" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    before do
-      allow_any_instance_of(Puppet::Type.type(:file)).to receive(:file).and_return('my/file.pp')
-      allow_any_instance_of(Puppet::Type.type(:file)).to receive(:line).and_return(5)
-    end
-
-    it "should make the actual content available via an attribute" do
-      content.should = "this is some content"
-
-      expect(content.actual_content).to eq("this is some content")
-    end
-
-    with_digest_algorithms do
-      it "should store the checksum as the desired content" do
-        d = digest("this is some content")
-
-        content.should = "this is some content"
-
-        expect(content.should).to eq("{#{digest_algorithm}}#{d}")
-      end
-
-      it "should not checksum 'absent'" do
-        content.should = :absent
-
-        expect(content.should).to eq(:absent)
-      end
-
-      it "should accept a checksum as the desired content" do
-        d = digest("this is some content")
-
-        string = "{#{digest_algorithm}}#{d}"
-        content.should = string
-
-        expect(content.should).to eq(string)
-      end
-    end
-
-    it "should convert the value to ASCII-8BIT" do
-      content.should= "Let's make a \u{2603}"
-
-      expect(content.actual_content).to eq("Let's make a \xE2\x98\x83".force_encoding(Encoding::ASCII_8BIT))
-    end
-  end
-
-  describe "when retrieving the current content" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    it "should return :absent if the file does not exist" do
-      expect(resource).to receive(:stat).and_return(nil)
-
-      expect(content.retrieve).to eq(:absent)
-    end
-
-    it "should not manage content on directories" do
-      stat = double('stat', :ftype => "directory")
-      expect(resource).to receive(:stat).and_return(stat)
-
-      expect(content.retrieve).to be_nil
-    end
-
-    it "should not manage content on links" do
-      stat = double('stat', :ftype => "link")
-      expect(resource).to receive(:stat).and_return(stat)
-
-      expect(content.retrieve).to be_nil
-    end
-
-    it "should always return the checksum as a string" do
-      resource[:checksum] = :mtime
-
-      stat = double('stat', :ftype => "file")
-      expect(resource).to receive(:stat).and_return(stat)
-
-      time = Time.now
-      expect(resource.parameter(:checksum)).to receive(:mtime_file).with(resource[:path]).and_return(time)
-
-      expect(content.retrieve).to eq("{mtime}#{time}")
-    end
-
-    with_digest_algorithms do
-      it "should return the checksum of the file if it exists and is a normal file" do
-        stat = double('stat', :ftype => "file")
-        expect(resource).to receive(:stat).and_return(stat)
-        expect(resource.parameter(:checksum)).to receive("#{digest_algorithm}_file".intern).with(resource[:path]).and_return("mysum")
-
-        expect(content.retrieve).to eq("{#{digest_algorithm}}mysum")
-      end
-    end
-  end
-
-  describe "when testing whether the content is in sync" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    before do
-      resource[:ensure] = :file
-    end
-
-    with_digest_algorithms do
-      before(:each) do
-        resource[:checksum] = digest_algorithm
-      end
-
-      it "should return true if the resource shouldn't be a regular file" do
-        expect(resource).to receive(:should_be_file?).and_return(false)
-        content.should = "foo"
-        expect(content).to be_safe_insync("whatever")
-      end
-
-      it "should warn that no content will be synced to links when ensure is :present" do
-        resource[:ensure] = :present
-        resource[:content] = 'foo'
-        allow(resource).to receive(:should_be_file?).and_return(false)
-        allow(resource).to receive(:stat).and_return(double("stat", :ftype => "link"))
-
-        expect(resource).to receive(:warning).with(/Ensure set to :present but file type is/)
-
-        content.insync? :present
-      end
-
-      it "should return false if the current content is :absent" do
-        content.should = "foo"
-        expect(content).not_to be_safe_insync(:absent)
-      end
-
-      it "should return false if the file should be a file but is not present" do
-        expect(resource).to receive(:should_be_file?).and_return(true)
-        content.should = "foo"
-
-        expect(content).not_to be_safe_insync(:absent)
-      end
-
-      describe "and the file exists" do
-        before do
-          allow(resource).to receive(:stat).and_return(double("stat"))
-          content.should = "some content"
-        end
-
-        it "should return false if the current contents are different from the desired content" do
-          expect(content).not_to be_safe_insync("other content")
-        end
-
-        it "should return true if the sum for the current contents is the same as the sum for the desired content" do
-          expect(content).to be_safe_insync("{#{digest_algorithm}}" + digest("some content"))
-        end
-
-        it "should include the diff module" do
-          expect(content.respond_to?("diff")).to eq(false)
-        end
-
-        describe "showing the diff" do
-          it "doesn't show the diff when #show_diff? is false" do
-            expect(content).to receive(:show_diff?).and_return(false)
-            expect(content).not_to receive(:diff)
-            expect(content).not_to be_safe_insync("other content")
-          end
-
-          describe "and #show_diff? is true" do
-            before do
-              expect(content).to receive(:show_diff?).and_return(true)
-              resource[:loglevel] = "debug"
-            end
-
-            it "prints the diff" do
-              expect(content).to receive(:diff).and_return("my diff")
-              expect(content).to receive(:debug).with("\nmy diff")
-              expect(content).not_to be_safe_insync("other content")
-            end
-
-            it "prints binary file notice if diff is not valid encoding" do
-              expect(content).to receive(:diff).and_return("\xc7\xd1\xfc\x84")
-              expect(content).to receive(:debug).with(/\nBinary files #{filename} and .* differ/)
-              expect(content).not_to be_safe_insync("other content")
-            end
-
-            it "redacts the diff when the property is sensitive" do
-              content.sensitive = true
-              expect(content).not_to receive(:diff)
-              expect(content).to receive(:debug).with("[diff redacted]")
-              expect(content).not_to be_safe_insync("other content")
-            end
-          end
-        end
-      end
-    end
-
-    let(:saved_time) { Time.now }
-    [:ctime, :mtime].each do |time_stat|
-      [["older", -1, false], ["same", 0, true], ["newer", 1, true]].each do
-        |compare, target_time, success|
-        describe "with #{compare} target #{time_stat} compared to source" do
-          before do
-            resource[:checksum] = time_stat
-            resource[:source] = make_absolute('/temp/foo')
-            content.should = "{#{time_stat}}#{saved_time}"
-          end
-
-          it "should return #{success}" do
-            if success
-              expect(content).to be_safe_insync("{#{time_stat}}#{saved_time+target_time}")
-            else
-              expect(content).not_to be_safe_insync("{#{time_stat}}#{saved_time+target_time}")
-            end
-          end
-        end
-      end
-
-      describe "with #{time_stat}" do
-        before do
-          resource[:checksum] = time_stat
-          resource[:source] = make_absolute('/temp/foo')
-        end
-
-        it "should not be insync if trying to create it" do
-          content.should = "{#{time_stat}}#{saved_time}"
-          expect(content).not_to be_safe_insync(:absent)
-        end
-
-        it "should raise an error if content is not a checksum" do
-          content.should = "some content"
-          expect {
-            content.safe_insync?("{#{time_stat}}#{saved_time}")
-          }.to raise_error(/Resource with checksum_type #{time_stat} didn't contain a date in/)
-        end
-
-        it "should not be insync even if content is the absent symbol" do
-          content.should = :absent
-          expect(content).not_to be_safe_insync(:absent)
-        end
-
-        it "should warn that no content will be synced to links when ensure is :present" do
-          resource[:ensure] = :present
-          resource[:content] = 'foo'
-          allow(resource).to receive(:should_be_file?).and_return(false)
-          allow(resource).to receive(:stat).and_return(double("stat", :ftype => "link"))
-
-          expect(resource).to receive(:warning).with(/Ensure set to :present but file type is/)
-
-          content.insync? :present
-        end
-      end
-    end
-
-    describe "and :replace is false" do
-      before do
-        allow(resource).to receive(:replace?).and_return(false)
-      end
-
-      it "should be insync if the file exists and the content is different" do
-        allow(resource).to receive(:stat).and_return(double('stat'))
-
-        expect(content).to be_safe_insync("whatever")
-      end
-
-      it "should be insync if the file exists and the content is right" do
-        allow(resource).to receive(:stat).and_return(double('stat'))
-
-        expect(content).to be_safe_insync("something")
-      end
-
-      it "should not be insync if the file does not exist" do
-        content.should = "foo"
-        expect(content).not_to be_safe_insync(:absent)
-      end
-    end
-  end
-
-  describe "when testing whether the content is initialized in the resource and in sync" do
-    CHECKSUM_TYPES_TO_TRY.each do |checksum_type, checksum|
-      describe "sync with checksum type #{checksum_type} and the file exists" do
-        before do
-          @new_resource = Puppet::Type.type(:file).new :ensure => :file, :path => filename, :catalog => catalog,
-            :content => CHECKSUM_PLAINTEXT, :checksum => checksum_type
-          allow(@new_resource).to receive(:stat).and_return(double('stat'))
-        end
-
-        it "should return false if the sum for the current contents are different from the desired content" do
-          expect(@new_resource.parameters[:content]).not_to be_safe_insync("other content")
-        end
-
-        it "should return true if the sum for the current contents is the same as the sum for the desired content" do
-          expect(@new_resource.parameters[:content]).to be_safe_insync("{#{checksum_type}}#{checksum}")
-        end
-      end
-    end
-  end
-
-  describe "determining if a diff should be shown" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    before do
-      Puppet[:show_diff] = true
-      resource[:show_diff] = true
-    end
-
-    it "is true if there are changes and the global and per-resource show_diff settings are true" do
-      expect(content.show_diff?(true)).to be_truthy
-    end
-
-    it "is false if there are no changes" do
-      expect(content.show_diff?(false)).to be_falsey
-    end
-
-    it "is false if show_diff is globally disabled" do
-      Puppet[:show_diff] = false
-      expect(content.show_diff?(false)).to be_falsey
-    end
-
-    it "is false if show_diff is disabled on the resource" do
-      resource[:show_diff] = false
-      expect(content.show_diff?(false)).to be_falsey
-    end
-  end
-
-  describe "when changing the content" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    before do
-      allow(resource).to receive(:[]).with(:path).and_return("/boo")
-      allow(resource).to receive(:stat).and_return("eh")
-    end
-
-    it "should use the file's :write method to write the content" do
-      expect(resource).to receive(:write).with(content)
-
-      content.sync
-    end
-
-    it "should return :file_changed if the file already existed" do
-      expect(resource).to receive(:stat).and_return("something")
-      allow(resource).to receive(:write)
-      expect(content.sync).to eq(:file_changed)
-    end
-
-    it "should return :file_created if the file did not exist" do
-      expect(resource).to receive(:stat).and_return(nil)
-      allow(resource).to receive(:write)
-      expect(content.sync).to eq(:file_created)
-    end
-  end
-
-  describe "when writing" do
-    let(:content) { described_class.new(:resource => resource) }
-
-    let(:fh) { File.open(filename, 'wb') }
-
-    before do
-      allow_any_instance_of(Puppet::Type.type(:file)).to receive(:file).and_return('my/file.pp')
-      allow_any_instance_of(Puppet::Type.type(:file)).to receive(:line).and_return(5)
-    end
-
-    it "should attempt to read from the filebucket if no actual content nor source exists" do
-      content.should = "{md5}foo"
-      allow_any_instance_of(content.resource.bucket.class).to receive(:getfile).and_return("foo")
-      content.write(fh)
-      fh.close
-    end
-
-    describe "from actual content" do
-      before(:each) do
-        allow(content).to receive(:actual_content).and_return("this is content")
-      end
-
-      it "should write to the given file handle" do
-        fh = double('filehandle')
-        expect(fh).to receive(:print).with("this is content")
-        content.write(fh)
-      end
-
-      it "should return the current checksum value" do
-        expect(resource.parameter(:checksum)).to receive(:sum_stream).and_return("checksum")
-        expect(content.write(fh)).to eq("checksum")
-      end
-    end
-
-    describe "from a file bucket" do
-      it "should fail if a file bucket cannot be retrieved" do
-        content.should = "{md5}foo"
-        expect(content.resource).to receive(:bucket).and_return(nil)
-        expect { content.write(fh) }.to raise_error(Puppet::Error)
-      end
-
-      it "should fail if the file bucket cannot find any content" do
-        content.should = "{md5}foo"
-        bucket = double('bucket')
-        expect(content.resource).to receive(:bucket).and_return(bucket)
-        expect(bucket).to receive(:getfile).with("foo").and_raise("foobar")
-        expect { content.write(fh) }.to raise_error(Puppet::Error)
-      end
-
-      it "should write the returned content to the file" do
-        content.should = "{md5}foo"
-        bucket = double('bucket')
-        expect(content.resource).to receive(:bucket).and_return(bucket)
-        expect(bucket).to receive(:getfile).with("foo").and_return("mycontent")
-
-        fh = double('filehandle')
-        expect(fh).to receive(:print).with("mycontent")
-        content.write(fh)
-      end
-    end
-  end
-end

data/spec/unit/type/file/ctime_spec.rb

@@ -1,33 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:file).attrclass(:ctime) do
-  require 'puppet_spec/files'
-  include PuppetSpec::Files
-
-  before do
-    @filename = tmpfile('ctime')
-    @resource = Puppet::Type.type(:file).new({:name => @filename})
-  end
-
-  it "should be able to audit the file's ctime" do
-    File.open(@filename, "w"){ }
-
-    @resource[:audit] = [:ctime]
-
-    # this .to_resource audit behavior is magical :-(
-    expect(@resource.to_resource[:ctime]).to eq(Puppet::FileSystem.stat(@filename).ctime.to_s)
-  end
-
-  it "should return absent if auditing an absent file" do
-    @resource[:audit] = [:ctime]
-
-    expect(@resource.to_resource[:ctime]).to eq(:absent)
-  end
-
-  it "should prevent the user from trying to set the ctime" do
-    expect {
-      @resource[:ctime] = Time.now.to_s
-    }.to raise_error(Puppet::Error, /ctime is read-only/)
-  end
-
-end

data/spec/unit/type/file/ensure_spec.rb

@@ -1,121 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:file).attrclass(:ensure) do
-  include PuppetSpec::Files
-
-  let(:path) { tmpfile('file_ensure') }
-  let(:resource) { Puppet::Type.type(:file).new(:ensure => 'file', :path => path, :replace => true) }
-  let(:property) { resource.property(:ensure) }
-
-  it "should be a subclass of Ensure" do
-    expect(described_class.superclass).to eq(Puppet::Property::Ensure)
-  end
-
-  describe "when retrieving the current state" do
-    it "should return :absent if the file does not exist" do
-      expect(resource).to receive(:stat).and_return(nil)
-
-      expect(property.retrieve).to eq(:absent)
-    end
-
-    it "should return the current file type if the file exists" do
-      stat = double('stat', :ftype => "directory")
-      expect(resource).to receive(:stat).and_return(stat)
-
-      expect(property.retrieve).to eq(:directory)
-    end
-  end
-
-  describe "when testing whether :ensure is in sync" do
-    it "should always be in sync if replace is 'false' unless the file is missing" do
-      property.should = :file
-      expect(resource).to receive(:replace?).and_return(false)
-      expect(property.safe_insync?(:link)).to be_truthy
-    end
-
-    it "should be in sync if :ensure is set to :absent and the file does not exist" do
-      property.should = :absent
-
-      expect(property).to be_safe_insync(:absent)
-    end
-
-    it "should not be in sync if :ensure is set to :absent and the file exists" do
-      property.should = :absent
-
-      expect(property).not_to be_safe_insync(:file)
-    end
-
-    it "should be in sync if a normal file exists and :ensure is set to :present" do
-      property.should = :present
-
-      expect(property).to be_safe_insync(:file)
-    end
-
-    it "should be in sync if a directory exists and :ensure is set to :present" do
-      property.should = :present
-
-      expect(property).to be_safe_insync(:directory)
-    end
-
-    it "should be in sync if a symlink exists and :ensure is set to :present" do
-      property.should = :present
-
-      expect(property).to be_safe_insync(:link)
-    end
-
-    it "should not be in sync if :ensure is set to :file and a directory exists" do
-      property.should = :file
-
-      expect(property).not_to be_safe_insync(:directory)
-    end
-  end
-
-  describe "#sync" do
-    context "directory" do
-      before :each do
-        resource[:ensure] = :directory
-      end
-
-      it "should raise if the parent directory doesn't exist" do
-        newpath = File.join(path, 'nonexistentparent', 'newdir')
-        resource[:path] = newpath
-
-        expect {
-          property.sync
-        }.to raise_error(Puppet::Error, /Cannot create #{newpath}; parent directory #{File.dirname(newpath)} does not exist/)
-      end
-
-      it "should accept octal mode as integer" do
-        resource[:mode] = '0700'
-        expect(resource).to receive(:property_fix)
-        expect(Dir).to receive(:mkdir).with(path, 0700)
-
-        property.sync
-      end
-
-      it "should accept octal mode as string" do
-        resource[:mode] = "700"
-        expect(resource).to receive(:property_fix)
-        expect(Dir).to receive(:mkdir).with(path, 0700)
-
-        property.sync
-      end
-
-      it "should accept octal mode as string with leading zero" do
-        resource[:mode] = "0700"
-        expect(resource).to receive(:property_fix)
-        expect(Dir).to receive(:mkdir).with(path, 0700)
-
-        property.sync
-      end
-
-      it "should accept symbolic mode" do
-        resource[:mode] = "u=rwx,go=x"
-        expect(resource).to receive(:property_fix)
-        expect(Dir).to receive(:mkdir).with(path, 0711)
-
-        property.sync
-      end
-    end
-  end
-end

data/spec/unit/type/file/group_spec.rb

@@ -1,65 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:file).attrclass(:group) do
-  include PuppetSpec::Files
-
-  let(:path) { tmpfile('mode_spec') }
-  let(:resource) { Puppet::Type.type(:file).new :path => path, :group => 'users' }
-  let(:group) { resource.property(:group) }
-
-  before :each do
-    # If the provider was already loaded without root, it won't have the
-    # feature, so we have to add it here to test.
-    Puppet::Type.type(:file).defaultprovider.has_feature :manages_ownership
-  end
-
-  describe "#insync?" do
-    before :each do
-      resource[:group] = ['foos', 'bars']
-
-      allow(resource.provider).to receive(:name2gid).with('foos').and_return(1001)
-      allow(resource.provider).to receive(:name2gid).with('bars').and_return(1002)
-    end
-
-    it "should fail if a group's id can't be found by name" do
-      allow(resource.provider).to receive(:name2gid).and_return(nil)
-
-      expect { group.insync?(5) }.to raise_error(/Could not find group foos/)
-    end
-
-    it "should return false if a group's id can't be found by name in noop" do
-      Puppet[:noop] = true
-      allow(resource.provider).to receive(:name2gid).and_return(nil)
-
-      expect(group.insync?('notcreatedyet')).to eq(false)
-    end
-
-    it "should use the id for comparisons, not the name" do
-      expect(group.insync?('foos')).to be_falsey
-    end
-
-    it "should return true if the current group is one of the desired group" do
-      expect(group.insync?(1001)).to be_truthy
-    end
-
-    it "should return false if the current group is not one of the desired group" do
-      expect(group.insync?(1003)).to be_falsey
-    end
-  end
-
-  %w[is_to_s should_to_s].each do |prop_to_s|
-    describe "##{prop_to_s}" do
-      it "should use the name of the user if it can find it" do
-        allow(resource.provider).to receive(:gid2name).with(1001).and_return('foos')
-
-        expect(group.send(prop_to_s, 1001)).to eq("'foos'")
-      end
-
-      it "should use the id of the user if it can't" do
-        allow(resource.provider).to receive(:gid2name).with(1001).and_return(nil)
-
-        expect(group.send(prop_to_s, 1001)).to eq('1001')
-      end
-    end
-  end
-end