puppet 7.28.0 → 7.29.1

data/spec/integration/application/doc_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-require 'puppet/application/doc'
-
-describe Puppet::Application::Doc do
-  include PuppetSpec::Files
-
-  let(:app) { Puppet::Application[:doc] }
-
-  it 'lists references' do
-    app.command_line.args = ['-l']
-    expect {
-      app.run
-    }.to exit_with(0)
-     .and output(/configuration - A reference for all settings/).to_stdout
-  end
-
-  it 'generates markdown' do
-    app.command_line.args = ['-r', 'report']
-    expect {
-      app.run
-    }.to exit_with(0)
-     .and output(/# Report Reference/).to_stdout
-  end
-end

data/spec/integration/application/filebucket_spec.rb

@@ -1,255 +0,0 @@
-require 'spec_helper'
-require 'puppet/face'
-require 'puppet_spec/puppetserver'
-require 'puppet_spec/files'
-
-describe "puppet filebucket", unless: Puppet::Util::Platform.jruby? do
-  include PuppetSpec::Files
-  include_context "https client"
-
-  let(:server) { PuppetSpec::Puppetserver.new }
-  let(:filebucket) { Puppet::Application[:filebucket] }
-  let(:backup_file) { tmpfile('backup_file') }
-  let(:text) { 'some random text' }
-  let(:sha256) { Digest::SHA256.file(backup_file).to_s }
-
-  before :each do
-    Puppet[:log_level] = 'debug'
-    File.binwrite(backup_file, text)
-  end
-
-  after :each do
-    # mute debug messages generated during `after :each` blocks
-    Puppet::Util::Log.close_all
-  end
-
-  it "backs up to and restores from the local filebucket" do
-    filebucket.command_line.args = ['backup', backup_file, '--local']
-    expect {
-      filebucket.run
-    }.to output(/: #{sha256}/).to_stdout
-
-    dest = tmpfile('file_bucket_restore')
-    filebucket.command_line.args = ['restore', dest, sha256, '--local']
-    expect {
-      filebucket.run
-    }.to output(/FileBucket read #{sha256}/).to_stdout
-
-    expect(FileUtils.compare_file(backup_file, dest)).to eq(true)
-  end
-
-  it "backs up text files to the filebucket server" do
-    server.start_server do |port|
-      Puppet[:serverport] = port
-      expect {
-        filebucket.command_line.args = ['backup', backup_file]
-        filebucket.run
-      }.to output(a_string_matching(
-        %r{Debug: HTTP HEAD https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file\/sha256\/#{sha256}\/#{File.realpath(backup_file)}\?environment\=production returned 404 Not Found}
-      ).and matching(
-        %r{Debug: HTTP PUT https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file\/sha256\/#{sha256}\/#{File.realpath(backup_file)}\?environment\=production returned 200 OK}
-      ).and matching(
-        %r{#{backup_file}: #{sha256}}
-      )).to_stdout
-
-      expect(File.binread(File.join(server.upload_directory, 'filebucket'))).to eq(text)
-    end
-  end
-
-  it "backs up binary files to the filebucket server" do
-    binary = "\xD1\xF2\r\n\x81NuSc\x00".force_encoding(Encoding::ASCII_8BIT)
-    File.binwrite(backup_file, binary)
-
-    server.start_server do |port|
-      Puppet[:serverport] = port
-      expect {
-        filebucket.command_line.args = ['backup', backup_file]
-        filebucket.run
-      }.to output(a_string_matching(
-        %r{Debug: HTTP HEAD https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file/sha256/f3aee54d781e413862eb068d89661f930385cc81bbafffc68477ff82eb9bea43/}
-      ).and matching(
-        %r{Debug: HTTP PUT https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file/sha256/f3aee54d781e413862eb068d89661f930385cc81bbafffc68477ff82eb9bea43/}
-      )).to_stdout
-
-      expect(File.binread(File.join(server.upload_directory, 'filebucket'))).to eq(binary)
-    end
-  end
-
-  it "backs up utf-8 encoded files to the filebucket server" do
-    utf8 = "\u2603".force_encoding(Encoding::UTF_8)
-    File.binwrite(backup_file, utf8)
-
-    server.start_server do |port|
-      Puppet[:serverport] = port
-      expect {
-        filebucket.command_line.args = ['backup', backup_file]
-        filebucket.run
-      }.to output(a_string_matching(
-        %r{Debug: HTTP HEAD https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file/sha256/51643361c79ecaef25a8de802de24f570ba25d9c2df1d22d94fade11b4f466cc/}
-      ).and matching(
-        %r{Debug: HTTP PUT https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file/sha256/51643361c79ecaef25a8de802de24f570ba25d9c2df1d22d94fade11b4f466cc/}
-      )).to_stdout
-
-      expect(File.read(File.join(server.upload_directory, 'filebucket'), encoding: 'utf-8')).to eq(utf8)
-    end
-  end
-
-  it "doesn't attempt to back up file that already exists on the filebucket server" do
-    file_exists_handler = -> (req, res) {
-      res.status = 200
-    }
-
-    server.start_server(mounts: {filebucket: file_exists_handler}) do |port|
-      Puppet[:serverport] = port
-      expect {
-        filebucket.command_line.args = ['backup', backup_file]
-        filebucket.run
-      }.to output(a_string_matching(
-        %r{Debug: HTTP HEAD https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file\/sha256\/#{sha256}\/#{File.realpath(backup_file)}\?environment\=production returned 200 OK}
-      ).and matching(
-        %r{#{backup_file}: #{sha256}}
-      )).to_stdout
-    end
-  end
-
-  it "downloads files from the filebucket server" do
-    get_handler = -> (req, res) {
-      res['Content-Type'] = 'application/octet-stream'
-      res.body = 'something to store'
-    }
-
-    server.start_server(mounts: {filebucket: get_handler}) do |port|
-      Puppet[:serverport] = port
-      expect {
-        filebucket.command_line.args = ['get', 'fac251367c9e083c6b1f0f3181']
-        filebucket.run
-      }.to output(a_string_matching(
-        %r{Debug: HTTP GET https:\/\/127.0.0.1:#{port}\/puppet\/v3\/file_bucket_file\/sha256\/fac251367c9e083c6b1f0f3181\?environment\=production returned 200 OK}
-      ).and matching(
-        %r{something to store}
-       )).to_stdout
-    end
-  end
-
-  it "lists the local filebucket even if the environment doesn't exist locally" do
-    Puppet[:environment] = 'doesnotexist'
-    Puppet::FileSystem.mkpath(Puppet[:clientbucketdir])
-
-    filebucket.command_line.args = ['backup', '--local', backup_file]
-    expect {
-      result = filebucket.run
-      expect(result).to eq([backup_file])
-    }.to output(/Computing checksum on file/).to_stdout
-  end
-
-  context 'diff', unless: Puppet::Util::Platform.windows? || Puppet::Util::Platform.jruby? do
-    context 'using a remote bucket' do
-      it 'outputs a diff between a local and remote file' do
-        File.binwrite(backup_file, "bar\nbaz")
-
-        get_handler = -> (req, res) {
-          res['Content-Type'] = 'application/octet-stream'
-          res.body = 'foo'
-        }
-
-        server.start_server(mounts: {filebucket: get_handler}) do |port|
-          Puppet[:serverport] = port
-          expect {
-            filebucket.command_line.args = ['diff', 'fac251367c9e083c6b1f0f3181', backup_file, '--remote']
-            filebucket.run
-          }.to output(a_string_matching(
-            /[-<] ?foo/
-          ).and matching(
-            /[+>] ?bar/
-          ).and matching(
-            /[+>] ?baz/
-          )).to_stdout
-        end
-      end
-
-      it 'outputs a diff between two remote files' do
-        get_handler = -> (req, res) {
-          res['Content-Type'] = 'application/octet-stream'
-          res.body = <<~END
-          --- /opt/puppetlabs/server/data/puppetserver/bucket/d/3/b/0/7/3/8/4/d3b07384d113edec49eaa6238ad5ff00/contents\t2020-04-06 21:25:24.892367570 +0000
-          +++ /opt/puppetlabs/server/data/puppetserver/bucket/9/9/b/9/9/9/2/0/99b999207e287afffc86c053e5693247/contents\t2020-04-06 21:26:13.603398063 +0000
-          @@ -1 +1,2 @@
-          -foo
-          +bar
-          +baz
-          END
-        }
-
-        server.start_server(mounts: {filebucket: get_handler}) do |port|
-          Puppet[:serverport] = port
-          expect {
-            filebucket.command_line.args = ['diff', 'd3b07384d113edec49eaa6238ad5ff00', "99b999207e287afffc86c053e5693247", '--remote']
-            filebucket.run
-          }.to output(a_string_matching(
-            /[-<] ?foo/
-          ).and matching(
-            /[+>] ?bar/
-          ).and matching(
-            /[+>] ?baz/
-          )).to_stdout
-        end
-      end
-    end
-
-    context 'using a local bucket' do
-      let(:filea) {
-        f = tmpfile('filea')
-        File.binwrite(f, 'foo')
-        f
-      }
-      let(:fileb) {
-        f = tmpfile('fileb')
-        File.binwrite(f, "bar\nbaz")
-        f
-      }
-      let(:checksuma) { Digest::SHA256.file(filea).to_s }
-      let(:checksumb) { Digest::SHA256.file(fileb).to_s }
-
-      it 'compares to files stored in a local bucket' do
-        expect {
-          filebucket.command_line.args = ['backup', filea, '--local']
-          filebucket.run
-        }.to output(/#{filea}: #{checksuma}/).to_stdout
-
-        expect{
-          filebucket.command_line.args = ['backup', fileb, '--local']
-          filebucket.run
-        }.to output(/#{fileb}: #{checksumb}\n/).to_stdout
-
-        expect {
-          filebucket.command_line.args = ['diff', checksuma, checksumb, '--local']
-          filebucket.run
-        }.to output(a_string_matching(
-          /[-<] ?foo/
-        ).and matching(
-          /[+>] ?bar/
-        ).and matching(
-          /[+>] ?baz/
-        )).to_stdout
-      end
-
-      it 'compares a file on the filesystem and a file stored in a local bucket' do
-        expect {
-          filebucket.command_line.args = ['backup', filea, '--local']
-          filebucket.run
-        }.to output(/#{filea}: #{checksuma}/).to_stdout
-
-        expect {
-          filebucket.command_line.args = ['diff', checksuma, fileb, '--local']
-          filebucket.run
-        }.to output(a_string_matching(
-          /[-<] ?foo/
-        ).and matching(
-          /[+>] ?bar/
-        ).and matching(
-          /[+>] ?baz/
-        )).to_stdout
-      end
-    end
-  end
-end

data/spec/integration/application/help_spec.rb

@@ -1,44 +0,0 @@
-require 'spec_helper'
-require 'puppet/application/help'
-
-describe "puppet help" do
-  let(:app) { Puppet::Application[:help] }
-
-  it "generates global help" do
-    expect {
-      app.run
-    }.to exit_with(0)
-     .and output(Regexp.new(Regexp.escape(<<~END), Regexp::MULTILINE)).to_stdout
-
-       Usage: puppet <subcommand> [options] <action> [options]
-
-       Available subcommands:
-     END
-  end
-
-  Puppet::Face.faces.sort.each do |face_name|
-    next if face_name == :key
-
-    context "for #{face_name}" do
-      it "generates help" do
-        app.command_line.args = ['help', face_name]
-
-        expect {
-          app.run
-        }.to exit_with(0)
-         .and output(/USAGE: puppet #{face_name} <action>/).to_stdout
-      end
-
-      Puppet::Face[face_name, :current].actions.sort.each do |action_name|
-        it "for action #{action_name}" do
-          app.command_line.args = ['help', face_name, action_name]
-
-          expect {
-            app.run
-          }.to exit_with(0)
-           .and output(/USAGE: puppet #{face_name}/).to_stdout
-        end
-      end
-    end
-  end
-end

data/spec/integration/application/lookup_spec.rb

@@ -1,275 +0,0 @@
-require 'spec_helper'
-require 'puppet_spec/files'
-require 'puppet_spec/compiler'
-require 'deep_merge/core'
-
-describe 'lookup' do
-  include PuppetSpec::Files
-
-  context 'with an environment' do
-    let(:fqdn) { Puppet[:certname] }
-    let(:env_name) { 'spec' }
-    let(:env_dir) { tmpdir('environments') }
-    let(:environment_files) do
-      {
-        env_name => {
-          'modules' => {},
-          'hiera.yaml' => <<-YAML.unindent,
-            ---
-            version: 5
-            hierarchy:
-              - name: "Common"
-                data_hash: yaml_data
-                path: "common.yaml"
-            YAML
-          'data' => {
-            'common.yaml' => <<-YAML.unindent
-              ---
-              a: value a
-              mod_a::a: value mod_a::a (from environment)
-              mod_a::hash_a:
-                a: value mod_a::hash_a.a (from environment)
-              mod_a::hash_b:
-                a: value mod_a::hash_b.a (from environment)
-              lookup_options:
-                mod_a::hash_b:
-                  merge: hash
-              YAML
-          }
-        },
-        'someother' => {
-        }
-      }
-    end
-
-    let(:app) { Puppet::Application[:lookup] }
-    let(:facts) { Puppet::Node::Facts.new("facts", {'my_fact' => 'my_fact_value'}) }
-    let(:cert) { pem_content('oid.pem') }
-
-    let(:node) { Puppet::Node.new('testnode', :facts => facts) }
-    let(:populated_env_dir) do
-      dir_contained_in(env_dir, environment_files)
-      env_dir
-    end
-
-    before do
-      stub_request(:get, "https://puppet:8140/puppet-ca/v1/certificate/#{fqdn}").to_return(body: cert)
-      allow(Puppet::Node::Facts.indirection).to receive(:find).and_return(facts)
-
-      Puppet[:environment] = env_name
-      Puppet[:environmentpath] = populated_env_dir
-
-      http = Puppet::HTTP::Client.new(ssl_context: Puppet::SSL::SSLProvider.new.create_insecure_context)
-      Puppet.runtime[:http] = http
-    end
-
-    def expect_lookup_with_output(exitcode, out)
-      expect { app.run }.to exit_with(exitcode).and output(out).to_stdout
-    end
-
-    it 'finds data in the environment' do
-      app.command_line.args << 'a'
-      expect_lookup_with_output(0, /value a/)
-    end
-
-    it "resolves hiera data using a top-level node parameter" do
-      File.write(File.join(env_dir, env_name, 'hiera.yaml'), <<~YAML)
-        ---
-        version: 5
-        hierarchy:
-          - name: "Per Node"
-            data_hash: yaml_data
-            path: "%{my_fact}.yaml"
-      YAML
-
-      File.write(File.join(env_dir, env_name, 'data', "my_fact_value.yaml"), <<~YAML)
-        ---
-        a: value from per node data
-      YAML
-
-      app.command_line.args << 'a'
-      expect_lookup_with_output(0, /--- value from per node data/)
-    end
-
-    it "resolves hiera data using a top-level node parameter from enc" do
-      Puppet.settings[:node_terminus] = 'exec'
-      enc = tmpfile('enc.sh')
-      Puppet.settings[:external_nodes] = enc
-      File.write(File.join(env_dir, env_name, 'hiera.yaml'), <<~YAML)
-      ---
-      version: 5
-      hierarchy:
-        - name: "Node parameters"
-          data_hash: yaml_data
-          path: "%{site}.yaml"
-      YAML
-
-      File.write(File.join(env_dir, env_name, 'data', "pdx.yaml"), <<~YAML)
-      ---
-      key: value
-      YAML
-      allow(Puppet::Util::Execution).to receive(:execute).with([enc, fqdn], anything).and_return(<<~YAML)
-      parameters:
-        site: pdx
-      YAML
-      app.command_line.args << 'key' << '--compile'
-      Puppet.initialize_settings(['-E', env_name])
-      expect_lookup_with_output(0, /--- value/)
-    end
-
-    it "prefers the environment specified on the commandline over the enc environment" do
-      Puppet.settings[:node_terminus] = 'exec'
-      enc = tmpfile('enc.sh')
-      Puppet.settings[:external_nodes] = enc
-      File.write(File.join(env_dir, env_name, 'hiera.yaml'), <<~YAML)
-      ---
-      version: 5
-      hierarchy:
-        - name: "Node parameters"
-          data_hash: yaml_data
-          path: "%{site}.yaml"
-      YAML
-
-      File.write(File.join(env_dir, env_name, 'data', "pdx.yaml"), <<~YAML)
-      ---
-      key: value
-      YAML
-      allow(Puppet::Util::Execution).to receive(:execute).with([enc, fqdn], anything).and_return(<<~YAML)
-      ---
-      # return 'someother' environment because it doesn't have any hiera data
-      environment: someother
-      parameters:
-        site: pdx
-      YAML
-      app.command_line.args << 'key' << '--compile'
-      Puppet.initialize_settings(['-E', env_name])
-      expect_lookup_with_output(0, /--- value/)
-    end
-
-    it 'loads trusted information from the node certificate' do
-      Puppet.settings[:node_terminus] = 'exec'
-      expect_any_instance_of(Puppet::Node::Exec).to receive(:find) do |args|
-        info = Puppet.lookup(:trusted_information)
-        expect(info.certname).to eq(fqdn)
-        expect(info.extensions).to eq({ "1.3.6.1.4.1.34380.1.2.1.1" => "somevalue" })
-      end.and_return(node)
-
-      app.command_line.args << 'a' << '--compile'
-      expect_lookup_with_output(0, /--- value a/)
-    end
-
-    it 'loads external facts when running without --node' do
-      expect(Puppet::Util).not_to receive(:skip_external_facts)
-      expect(Facter).not_to receive(:load_external)
-
-      app.command_line.args << 'a'
-      expect_lookup_with_output(0, /--- value a/)
-    end
-
-    describe 'when using --node' do
-      let(:fqdn) { 'random_node' }
-
-      it 'skips loading of external facts' do
-        app.command_line.args << 'a' << '--node' << fqdn
-
-        expect(Puppet::Node::Facts.indirection).to receive(:find).and_return(facts)
-        expect(Facter).to receive(:load_external).twice.with(false)
-        expect(Facter).to receive(:load_external).twice.with(true)
-        expect_lookup_with_output(0, /--- value a/)
-      end
-    end
-
-    context 'uses node_terminus' do
-      require 'puppet/indirector/node/exec'
-      require 'puppet/indirector/node/plain'
-
-      let(:node) { Puppet::Node.new('testnode', :facts => facts) }
-
-      it ':plain without --compile' do
-        Puppet.settings[:node_terminus] = 'exec'
-        expect_any_instance_of(Puppet::Node::Plain).to receive(:find).and_return(node)
-        expect_any_instance_of(Puppet::Node::Exec).not_to receive(:find)
-
-        app.command_line.args << 'a'
-        expect_lookup_with_output(0, /--- value a/)
-      end
-
-      it 'configured in Puppet settings with --compile' do
-        Puppet.settings[:node_terminus] = 'exec'
-        expect_any_instance_of(Puppet::Node::Plain).not_to receive(:find)
-        expect_any_instance_of(Puppet::Node::Exec).to receive(:find).and_return(node)
-
-        app.command_line.args << 'a' << '--compile'
-        expect_lookup_with_output(0, /--- value a/)
-      end
-    end
-
-    context 'configured with the wrong environment' do
-      it 'does not find data in non-existing environment' do
-        Puppet[:environment] = 'doesntexist'
-        app.command_line.args << 'a'
-        expect { app.run }.to raise_error(Puppet::Environments::EnvironmentNotFound, /Could not find a directory environment named 'doesntexist'/)
-      end
-    end
-
-    context 'and a module' do
-      let(:mod_a_files) do
-        {
-          'mod_a' => {
-            'data' => {
-              'common.yaml' => <<-YAML.unindent
-                ---
-                mod_a::a: value mod_a::a (from mod_a)
-                mod_a::b: value mod_a::b (from mod_a)
-                mod_a::hash_a:
-                  a: value mod_a::hash_a.a (from mod_a)
-                  b: value mod_a::hash_a.b (from mod_a)
-                mod_a::hash_b:
-                  a: value mod_a::hash_b.a (from mod_a)
-                  b: value mod_a::hash_b.b (from mod_a)
-                mod_a::interpolated: "-- %{lookup('mod_a::a')} --"
-                mod_a::a_a: "-- %{lookup('mod_a::hash_a.a')} --"
-                mod_a::a_b: "-- %{lookup('mod_a::hash_a.b')} --"
-                mod_a::b_a: "-- %{lookup('mod_a::hash_b.a')} --"
-                mod_a::b_b: "-- %{lookup('mod_a::hash_b.b')} --"
-                'mod_a::a.quoted.key': 'value mod_a::a.quoted.key (from mod_a)'
-                YAML
-            },
-            'hiera.yaml' => <<-YAML.unindent,
-              ---
-              version: 5
-              hierarchy:
-                - name: "Common"
-                  data_hash: yaml_data
-                  path: "common.yaml"
-              YAML
-          }
-        }
-      end
-
-      let(:populated_env_dir) do
-        dir_contained_in(env_dir, DeepMerge.deep_merge!(environment_files, env_name => { 'modules' => mod_a_files }))
-        env_dir
-      end
-
-      it 'finds data in the module' do
-        app.command_line.args << 'mod_a::b'
-        expect_lookup_with_output(0, /value mod_a::b \(from mod_a\)/)
-      end
-
-      it 'finds quoted keys in the module' do
-        app.command_line.args << "'mod_a::a.quoted.key'"
-        expect_lookup_with_output(0, /value mod_a::a.quoted.key \(from mod_a\)/)
-      end
-
-      it 'merges hashes from environment and module when merge strategy hash is used' do
-        app.command_line.args << 'mod_a::hash_a' << '--merge' << 'hash'
-        expect_lookup_with_output(0, <<~END)
-          ---
-          a: value mod_a::hash_a.a (from environment)
-          b: value mod_a::hash_a.b (from mod_a)
-        END
-      end
-    end
-  end
-end