puppet 7.28.0 → 7.29.1

data/spec/unit/pops/types/type_mismatch_describer_spec.rb

@@ -1,424 +0,0 @@
-require 'spec_helper'
-require 'puppet/pops'
-require 'puppet_spec/compiler'
-require 'puppet_spec/files'
-require 'puppet/loaders'
-
-module Puppet::Pops
-module Types
-
-describe 'the type mismatch describer' do
-  include PuppetSpec::Compiler, PuppetSpec::Files
-
-  context 'with deferred functions' do
-    let(:env_name) { 'spec' }
-    let(:code_dir) { Puppet[:environmentpath] }
-    let(:env_dir) { File.join(code_dir, env_name) }
-    let(:env) { Puppet::Node::Environment.create(env_name.to_sym, [File.join(populated_code_dir, env_name, 'modules')]) }
-    let(:node) { Puppet::Node.new('fooname', environment: env) }
-    let(:populated_code_dir) do
-      dir_contained_in(code_dir, env_name => env_content)
-      PuppetSpec::Files.record_tmp(env_dir)
-      code_dir
-    end
-
-    let(:env_content) {
-      {
-        'lib' => {
-          'puppet' => {
-            'functions' => {
-              'string_return.rb' => <<-RUBY.unindent,
-              Puppet::Functions.create_function(:string_return) do
-                dispatch :string_return do
-                  param 'String', :arg1
-                  return_type 'String'
-                end
-                def string_return(arg1)
-                  arg1
-                end
-              end
-              RUBY
-              'variant_return.rb' => <<-RUBY.unindent,
-              Puppet::Functions.create_function(:variant_return) do
-                dispatch :variant_return do
-                  param 'String', :arg1
-                  return_type 'Variant[Integer,Float]'
-                end
-                def variant_return(arg1)
-                  arg1
-                end
-              end
-              RUBY
-              'no_return.rb' => <<-RUBY.unindent,
-              Puppet::Functions.create_function(:no_return) do
-                dispatch :no_return do
-                  param 'String', :arg1
-                end
-                def variant_return(arg1)
-                  arg1
-                end
-              end
-              RUBY
-            }
-          }
-        }
-      }
-    }
-
-    before(:each) do
-      Puppet.push_context(:loaders => Puppet::Pops::Loaders.new(env))
-    end
-
-    after(:each) do
-      Puppet.pop_context
-    end
-
-    it 'will compile when the parameter type matches the function return_type' do
-      code = <<-CODE
-        $d = Deferred("string_return", ['/a/non/existing/path'])
-        class testclass(String $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code, node) }.to_not raise_error
-    end
-
-    it "will compile when a Variant parameter's types matches the return type" do
-      code = <<-CODE
-        $d = Deferred("string_return", ['/a/non/existing/path'])
-        class testclass(Variant[String, Float] $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code, node) }.to_not raise_error
-    end
-
-    it "will compile with a union of a Variant parameters' types and Variant return types" do
-      code = <<-CODE
-        $d = Deferred("variant_return", ['/a/non/existing/path'])
-        class testclass(Variant[Any,Float] $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code, node) }.to_not raise_error
-    end
-
-    it 'will warn when there is no defined return_type for the function definition' do
-      code = <<-CODE
-        $d = Deferred("no_return", ['/a/non/existing/path'])
-        class testclass(Variant[String,Boolean] $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect(Puppet).to receive(:warn_once).with(anything, anything, /.+function no_return has no return_type/).at_least(:once)
-      expect { eval_and_collect_notices(code, node) }.to_not raise_error
-    end
-
-    it 'will report a mismatch between a deferred function return type and class parameter value' do
-      code = <<-CODE
-        $d = Deferred("string_return", ['/a/non/existing/path'])
-        class testclass(Integer $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code, node) }.to raise_error(Puppet::Error, /.+'classparam' expects an Integer value, got String/)
-    end
-
-    it 'will report an argument error when no matching arity is found' do
-      code = <<-CODE
-        $d = Deferred("string_return", ['/a/non/existing/path', 'second-invalid-arg'])
-        class testclass(Integer $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code,node) }.to raise_error(Puppet::Error, /.+ No matching arity found for string_return/)
-    end
-
-    it 'will error with no matching Variant class parameters and return_type' do
-      code = <<-CODE
-        $d = Deferred("string_return", ['/a/non/existing/path'])
-        class testclass(Variant[Integer,Float] $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code,node) }.to raise_error(Puppet::Error, /.+'classparam' expects a value of type Integer or Float, got String/)
-    end
-
-    # This test exposes a shortcoming in the #message function for Puppet::Pops::Type::TypeMismatch
-    # where the `actual` is not introspected for the list of Variant types, so the error message
-    # shows that the list of expected types does not match Variant, instead of a list of actual types.
-    it 'will error with no matching Variant class parameters and Variant return_type' do
-      code = <<-CODE
-        $d = Deferred("variant_return", ['/a/non/existing/path'])
-        class testclass(Variant[String,Boolean] $classparam) {
-        }
-        class { 'testclass':
-          classparam => $d
-        }
-      CODE
-      expect { eval_and_collect_notices(code, node) }.to raise_error(Puppet::Error, /.+'classparam' expects a value of type String or Boolean, got Variant/)
-    end
-  end
-
-  it 'will report a mismatch between a hash and a struct with details' do
-    code = <<-CODE
-      function f(Hash[String,String] $h) {
-         $h['a']
-      }
-      f({'a' => 'a', 'b' => 23})
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /'f' parameter 'h' entry 'b' expects a String value, got Integer/)
-  end
-
-  it 'will report a mismatch between a array and tuple with details' do
-    code = <<-CODE
-      function f(Array[String] $h) {
-         $h[0]
-      }
-      f(['a', 23])
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /'f' parameter 'h' index 1 expects a String value, got Integer/)
-  end
-
-  it 'will not report details for a mismatch between an array and a struct' do
-    code = <<-CODE
-      function f(Array[String] $h) {
-         $h[0]
-      }
-      f({'a' => 'a string', 'b' => 23})
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /expects an Array value, got Struct/)
-  end
-
-  it 'will not report details for a mismatch between a hash and a tuple' do
-    code = <<-CODE
-      function f(Hash[String,String] $h) {
-         $h['a']
-      }
-      f(['a', 23])
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /expects a Hash value, got Tuple/)
-  end
-
-  it 'will report an array size mismatch' do
-    code = <<-CODE
-      function f(Array[String,1,default] $h) {
-        $h[0]
-      }
-      f([])
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /expects size to be at least 1, got 0/)
-  end
-
-  it 'will report a hash size mismatch' do
-    code = <<-CODE
-      function f(Hash[String,String,1,default] $h) {
-         $h['a']
-      }
-      f({})
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /expects size to be at least 1, got 0/)
-  end
-
-  it 'will include the aliased type when reporting a mismatch that involves an alias' do
-    code = <<-CODE
-      type UnprivilegedPort = Integer[1024,65537]
-
-      function check_port(UnprivilegedPort $port) {}
-      check_port(34)
-    CODE
-    expect { eval_and_collect_notices(code) }.to raise_error(Puppet::Error, /parameter 'port' expects an UnprivilegedPort = Integer\[1024, 65537\] value, got Integer\[34, 34\]/)
-  end
-
-  it 'will include the aliased type when reporting a mismatch that involves an alias nested in another type' do
-    code = <<-CODE
-      type UnprivilegedPort = Integer[1024,65537]
-      type PortMap = Hash[UnprivilegedPort,String]
-
-      function check_port(PortMap $ports) {}
-      check_port({ 34 => 'some service'})
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'ports' expects a PortMap = Hash\[UnprivilegedPort = Integer\[1024, 65537\], String\] value, got Hash\[Integer\[34, 34\], String\]/))
-  end
-
-  it 'will not include the aliased type more than once when reporting a mismatch that involves an alias that is self recursive' do
-    code = <<-CODE
-      type Tree = Hash[String,Tree]
-
-      function check_tree(Tree $tree) {}
-      check_tree({ 'x' => {'y' => {32 => 'n'}}})
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'tree' entry 'x' entry 'y' expects a Tree = Hash\[String, Tree\] value, got Hash\[Integer\[32, 32\], String\]/))
-  end
-
-  it 'will use type normalization' do
-    code = <<-CODE
-      type EVariants = Variant[Enum[a,b],Enum[b,c],Enum[c,d]]
-
-      function check_enums(EVariants $evars) {}
-      check_enums('n')
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-       /parameter 'evars' expects a match for EVariants = Enum\['a', 'b', 'c', 'd'\], got 'n'/))
-  end
-
-  it "will not generalize a string that doesn't match an enum in a function call" do
-    code = <<-CODE
-      function check_enums(Enum[a,b] $arg) {}
-      check_enums('c')
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'arg' expects a match for Enum\['a', 'b'\], got 'c'/))
-  end
-
-  it "will not disclose a Sensitive that doesn't match an enum in a function call" do
-    code = <<-CODE
-      function check_enums(Enum[a,b] $arg) {}
-      check_enums(Sensitive('c'))
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'arg' expects a match for Enum\['a', 'b'\], got Sensitive/))
-  end
-
-  it "reports errors on the first failing parameter when that parameter is not the first in order" do
-    code = <<-CODE
-      type Abc = Enum['a', 'b', 'c']
-      type Cde = Enum['c', 'd', 'e']
-      function two_params(Abc $a, Cde $b) {}
-      two_params('a', 'x')
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'b' expects a match for Cde = Enum\['c', 'd', 'e'\], got 'x'/))
-  end
-
-  it "will not generalize a string that doesn't match an enum in a define call" do
-    code = <<-CODE
-      define check_enums(Enum[a,b] $arg) {}
-      check_enums { x: arg => 'c' }
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'arg' expects a match for Enum\['a', 'b'\], got 'c'/))
-  end
-
-  it "will include Undef when describing a mismatch against a Variant where one of the types is Undef" do
-    code = <<-CODE
-      define check(Variant[Undef,String,Integer,Hash,Array] $arg) {}
-      check{ x: arg => 2.4 }
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'arg' expects a value of type Undef, String, Integer, Hash, or Array/))
-  end
-
-  it "will not disclose a Sensitive that doesn't match an enum in a define call" do
-    code = <<-CODE
-      define check_enums(Enum[a,b] $arg) {}
-      check_enums { x: arg => Sensitive('c') }
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /parameter 'arg' expects a match for Enum\['a', 'b'\], got Sensitive/))
-  end
-
-  it "will report the parameter of Type[<type alias>] using the alias name" do
-    code = <<-CODE
-      type Custom = String[1]
-      Custom.each |$x| { notice($x) }
-    CODE
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /expects an Iterable value, got Type\[Custom\]/))
-  end
-
-  context 'when reporting a mismatch between' do
-    let(:parser) { TypeParser.singleton }
-    let(:subject) { TypeMismatchDescriber.singleton }
-
-    context 'hash and struct' do
-      it 'reports a size mismatch when hash has unlimited size' do
-        expected = parser.parse('Struct[{a=>Integer,b=>Integer}]')
-        actual = parser.parse('Hash[String,Integer]')
-        expect(subject.describe_mismatch('', expected, actual)).to eq('expects size to be 2, got unlimited')
-      end
-
-      it 'reports a size mismatch when hash has specified but incorrect size' do
-        expected = parser.parse('Struct[{a=>Integer,b=>Integer}]')
-        actual = parser.parse('Hash[String,Integer,1,1]')
-        expect(subject.describe_mismatch('', expected, actual)).to eq('expects size to be 2, got 1')
-      end
-
-      it 'reports a full type mismatch when size is correct but hash value type is incorrect' do
-        expected = parser.parse('Struct[{a=>Integer,b=>String}]')
-        actual = parser.parse('Hash[String,Integer,2,2]')
-        expect(subject.describe_mismatch('', expected, actual)).to eq("expects a Struct[{'a' => Integer, 'b' => String}] value, got Hash[String, Integer]")
-      end
-    end
-
-    it 'reports a missing parameter as "has no parameter"' do
-      t = parser.parse('Struct[{a=>String}]')
-      expect { subject.validate_parameters('v', t, {'a'=>'a','b'=>'b'}, false) }.to raise_error(Puppet::Error, "v: has no parameter named 'b'")
-    end
-
-    it 'reports a missing value as "expects a value"' do
-      t = parser.parse('Struct[{a=>String,b=>String}]')
-      expect { subject.validate_parameters('v', t, {'a'=>'a'}, false) }.to raise_error(Puppet::Error, "v: expects a value for parameter 'b'")
-    end
-
-    it 'reports a missing block as "expects a block"' do
-      callable = parser.parse('Callable[String,String,Callable]')
-      args_tuple = parser.parse('Tuple[String,String]')
-      dispatch = Functions::Dispatch.new(callable, 'foo', ['a','b'], false, 'block')
-      expect(subject.describe_signatures('function', [dispatch], args_tuple)).to eq("'function' expects a block")
-    end
-
-    it 'reports an unexpected block as "does not expect a block"' do
-      callable = parser.parse('Callable[String,String]')
-      args_tuple = parser.parse('Tuple[String,String,Callable]')
-      dispatch = Functions::Dispatch.new(callable, 'foo', ['a','b'])
-      expect(subject.describe_signatures('function', [dispatch], args_tuple)).to eq("'function' does not expect a block")
-    end
-
-    it 'reports a block return type mismatch' do
-      callable = parser.parse('Callable[[0,0,Callable[ [0,0],String]],Undef]')
-      args_tuple = parser.parse('Tuple[Callable[[0,0],Integer]]')
-      dispatch = Functions::Dispatch.new(callable, 'foo', [], false, 'block')
-      expect(subject.describe_signatures('function', [dispatch], args_tuple)).to eq("'function' block return expects a String value, got Integer")
-    end
-  end
-
-  it "reports struct mismatch correctly when hash doesn't contain required keys" do
-    code = <<-PUPPET
-      type Test::Options = Struct[{
-        var => String
-      }]
-      class test(String $var, Test::Options $opts) {}
-      class { 'test': var => 'hello', opts => {} }
-    PUPPET
-    expect { eval_and_collect_notices(code) }.to(raise_error(Puppet::Error,
-      /Class\[Test\]: parameter 'opts' expects size to be 1, got 0/))
-  end
-
-  it "treats Optional as Optional[Any]" do
-    code = <<-PUPPET
-      class test(Optional $var=undef) {}
-      class { 'test': var => 'hello' }
-    PUPPET
-    expect { eval_and_collect_notices(code) }.not_to raise_error
-  end
-
-end
-end
-end