puppet 6.0.7-x86-mingw32 → 6.0.8-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  # encoding: UTF-8
3
2
  require 'spec_helper'
4
3
 
@@ -13,7 +12,7 @@ describe Puppet::Type.type(:user) do
13
12
  def flush; end
14
13
  def self.instances; []; end
15
14
  end
16
- described_class.stubs(:defaultprovider).returns @provider_class
15
+ allow(described_class).to receive(:defaultprovider).and_return(@provider_class)
17
16
  end
18
17
 
19
18
  it "should be able to create an instance" do
@@ -65,12 +64,12 @@ describe Puppet::Type.type(:user) do
65
64
  end
66
65
 
67
66
  it "cannot be set to true for a provider that does not manage homedirs" do
68
- provider.class.stubs(:manages_homedir?).returns false
67
+ allow(provider.class).to receive(:manages_homedir?).and_return(false)
69
68
  expect { instance[:managehome] = 'yes' }.to raise_error(Puppet::Error, /can not manage home directories/)
70
69
  end
71
70
 
72
71
  it "can be set to true for a provider that does manage homedirs" do
73
- provider.class.stubs(:manages_homedir?).returns true
72
+ allow(provider.class).to receive(:manages_homedir?).and_return(true)
74
73
  instance[:managehome] = 'yes'
75
74
  end
76
75
  end
@@ -127,8 +126,8 @@ describe Puppet::Type.type(:user) do
127
126
  end
128
127
 
129
128
  it "should set all values to :absent if the user is absent" do
130
- @user.property(:ensure).expects(:retrieve).returns :absent
131
- @user.property(:uid).expects(:retrieve).never
129
+ expect(@user.property(:ensure)).to receive(:retrieve).and_return(:absent)
130
+ expect(@user.property(:uid)).not_to receive(:retrieve)
132
131
  expect(@user.retrieve[@user.property(:uid)]).to eq(:absent)
133
132
  end
134
133
 
@@ -148,13 +147,13 @@ describe Puppet::Type.type(:user) do
148
147
 
149
148
  it "should call :create on the provider when asked to sync to the :present state" do
150
149
  @provider = @provider_class.new(:name => 'foo', :ensure => :absent)
151
- @provider.expects(:create)
150
+ expect(@provider).to receive(:create)
152
151
  described_class.new(:name => 'foo', :ensure => :present, :provider => @provider).parameter(:ensure).sync
153
152
  end
154
153
 
155
154
  it "should call :delete on the provider when asked to sync to the :absent state" do
156
155
  @provider = @provider_class.new(:name => 'foo', :ensure => :present)
157
- @provider.expects(:delete)
156
+ expect(@provider).to receive(:delete)
158
157
  described_class.new(:name => 'foo', :ensure => :absent, :provider => @provider).parameter(:ensure).sync
159
158
  end
160
159
 
@@ -212,27 +211,27 @@ describe Puppet::Type.type(:user) do
212
211
  end
213
212
 
214
213
  it "should return true if any of the specified groups are equal to the current integer" do
215
- Puppet::Util.expects(:gid).with("foo").returns 300
216
- Puppet::Util.expects(:gid).with("bar").returns 500
214
+ expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
215
+ expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
217
216
  expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to be_safe_insync(500)
218
217
  end
219
218
 
220
219
  it "should return false if none of the specified groups are equal to the current integer" do
221
- Puppet::Util.expects(:gid).with("foo").returns 300
222
- Puppet::Util.expects(:gid).with("bar").returns 500
220
+ expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
221
+ expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
223
222
  expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to_not be_safe_insync(700)
224
223
  end
225
224
  end
226
225
 
227
226
  describe "when syncing" do
228
227
  it "should use the first found, specified group as the desired value and send it to the provider" do
229
- Puppet::Util.expects(:gid).with("foo").returns nil
230
- Puppet::Util.expects(:gid).with("bar").returns 500
228
+ expect(Puppet::Util).to receive(:gid).with("foo").and_return(nil)
229
+ expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
231
230
 
232
231
  @provider = @provider_class.new(:name => 'foo')
233
232
  resource = described_class.new(:name => 'foo', :provider => @provider, :gid => [ 'foo', 'bar' ])
234
233
 
235
- @provider.expects(:gid=).with 500
234
+ expect(@provider).to receive(:gid=).with(500)
236
235
  resource.parameter(:gid).sync
237
236
  end
238
237
  end
@@ -257,7 +256,6 @@ describe Puppet::Type.type(:user) do
257
256
  end
258
257
 
259
258
  describe "when testing is in sync" do
260
-
261
259
  before :each do
262
260
  # the useradd provider uses a single string to represent groups and so does Puppet::Property::List when converting to should values
263
261
  @provider = @provider_class.new(:name => 'foo', :groups => 'a,b,e,f')
@@ -366,7 +364,7 @@ describe Puppet::Type.type(:user) do
366
364
  # useradd subclasses nameservice and thus inherits #comments_insync?
367
365
  user = described_class.new(:name => 'foo', :comment => @value, :provider => :useradd)
368
366
  comment_property = user.properties.find {|p| p.name == :comment}
369
- user.provider.expects(:comments_insync?)
367
+ expect(user.provider).to receive(:comments_insync?)
370
368
  comment_property.insync?('bar')
371
369
  end
372
370
 
@@ -374,6 +372,7 @@ describe Puppet::Type.type(:user) do
374
372
  let(:is) { "\u2603" }
375
373
  let(:should) { "\u06FF" }
376
374
  let(:comment_property) { @user.properties.find { |p| p.name == :comment } }
375
+
377
376
  context "given is and should strings with incompatible encoding" do
378
377
  it "should return a formatted string" do
379
378
  is.force_encoding(Encoding::ASCII_8BIT)
@@ -409,7 +408,7 @@ describe Puppet::Type.type(:user) do
409
408
  Puppet::Resource::Catalog.new :testing do |conf|
410
409
  [testuser, testrole].each { |resource| conf.add_resource resource }
411
410
  end
412
- Puppet::Type::User::ProviderDirectoryservice.stubs(:get_macosx_version_major).returns "10.5"
411
+ allow(Puppet::Type::User::ProviderDirectoryservice).to receive(:get_macosx_version_major).and_return("10.5")
413
412
 
414
413
  rel = testuser.autorequire[0]
415
414
  expect(rel.source.ref).to eq(testrole.ref)
@@ -431,15 +430,15 @@ describe Puppet::Type.type(:user) do
431
430
  def check_valid_shell; end
432
431
  end
433
432
 
434
- described_class.stubs(:defaultprovider).returns @shell_provider_class
433
+ allow(described_class).to receive(:defaultprovider).and_return(@shell_provider_class)
435
434
  end
436
435
 
437
436
  it "should call :check_valid_shell on the provider when changing shell value" do
438
437
  @provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :present)
439
- @provider.expects(:check_valid_shell)
438
+ expect(@provider).to receive(:check_valid_shell)
440
439
  resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
441
- Puppet::Util::Storage.stubs(:load)
442
- Puppet::Util::Storage.stubs(:store)
440
+ allow(Puppet::Util::Storage).to receive(:load)
441
+ allow(Puppet::Util::Storage).to receive(:store)
443
442
  catalog = Puppet::Resource::Catalog.new
444
443
  catalog.add_resource resource
445
444
  catalog.apply
@@ -447,10 +446,10 @@ describe Puppet::Type.type(:user) do
447
446
 
448
447
  it "should call :check_valid_shell on the provider when changing ensure from present to absent" do
449
448
  @provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :absent)
450
- @provider.expects(:check_valid_shell)
449
+ expect(@provider).to receive(:check_valid_shell)
451
450
  resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
452
- Puppet::Util::Storage.stubs(:load)
453
- Puppet::Util::Storage.stubs(:store)
451
+ allow(Puppet::Util::Storage).to receive(:load)
452
+ allow(Puppet::Util::Storage).to receive(:store)
454
453
  catalog = Puppet::Resource::Catalog.new
455
454
  catalog.add_resource resource
456
455
  catalog.apply
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  whit = Puppet::Type.type(:whit)
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet_spec/compiler'
4
3
  require 'puppet/property/boolean'
@@ -138,18 +137,18 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
138
137
 
139
138
  it "should delegate to the tagging module when tags are added" do
140
139
  resource = klass.new(:name => "foo")
141
- resource.stubs(:tag).with(resource_type)
140
+ allow(resource).to receive(:tag).with(resource_type)
142
141
 
143
- resource.expects(:tag).with(:tag1, :tag2)
142
+ expect(resource).to receive(:tag).with(:tag1, :tag2)
144
143
 
145
144
  resource.tags = [:tag1,:tag2]
146
145
  end
147
146
 
148
147
  it "should add the current type as tag" do
149
148
  resource = klass.new(:name => "foo")
150
- resource.stubs(:tag)
149
+ allow(resource).to receive(:tag)
151
150
 
152
- resource.expects(:tag).with(resource_type)
151
+ expect(resource).to receive(:tag).with(resource_type)
153
152
 
154
153
  resource.tags = [:tag1,:tag2]
155
154
  end
@@ -255,7 +254,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
255
254
 
256
255
  {:file => "/my/file", :line => 50}.each do |attr, value|
257
256
  it "should set the #{attr}" do
258
- @resource.stubs(attr).returns value
257
+ allow(@resource).to receive(attr).and_return(value)
259
258
  expect(@resource.event.send(attr)).to eq(value)
260
259
  end
261
260
  end
@@ -394,8 +393,8 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
394
393
  basic = type.provide(:basic) {}
395
394
  greater = type.provide(:greater) {}
396
395
 
397
- basic.stubs(:specificity).returns 1
398
- greater.stubs(:specificity).returns 2
396
+ allow(basic).to receive(:specificity).and_return(1)
397
+ allow(greater).to receive(:specificity).and_return(2)
399
398
 
400
399
  expect(type.defaultprovider).to equal(greater)
401
400
  end
@@ -603,7 +602,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
603
602
  resource = Puppet::Resource.new(resource_type, "/foo",
604
603
  :parameters => {:atboot => :yes, :fstype => "boo", :remounts => true},
605
604
  :sensitive_parameters => [:remounts])
606
- klass.any_instance.expects(:warning).with(regexp_matches(/Unable to mark 'remounts' as sensitive: remounts is a parameter and not a property/))
605
+ expect_any_instance_of(klass).to receive(:warning).with(/Unable to mark 'remounts' as sensitive: remounts is a parameter and not a property/)
607
606
  klass.new(resource)
608
607
  end
609
608
 
@@ -611,7 +610,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
611
610
  resource = Puppet::Resource.new(resource_type, "/foo",
612
611
  :parameters => {:atboot => :yes, :fstype => "boo"},
613
612
  :sensitive_parameters => [:device])
614
- klass.any_instance.expects(:warning).with("Unable to mark 'device' as sensitive: the property itself was not assigned a value.")
613
+ expect_any_instance_of(klass).to receive(:warning).with("Unable to mark 'device' as sensitive: the property itself was not assigned a value.")
615
614
  klass.new(resource)
616
615
  end
617
616
 
@@ -619,7 +618,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
619
618
  resource = Puppet::Resource.new(resource_type, "/foo",
620
619
  :parameters => {:atboot => :yes, :fstype => "boo"},
621
620
  :sensitive_parameters => [:content])
622
- klass.any_instance.expects(:err).with("Unable to mark 'content' as sensitive: the property itself is not defined on #{resource_type}.")
621
+ expect_any_instance_of(klass).to receive(:err).with("Unable to mark 'content' as sensitive: the property itself is not defined on #{resource_type}.")
623
622
  klass.new(resource)
624
623
  end
625
624
  end
@@ -673,8 +672,8 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
673
672
  end
674
673
 
675
674
  it "should include the file/line in the error" do
676
- Puppet::Type.type(:file).any_instance.stubs(:file).returns("example.pp")
677
- Puppet::Type.type(:file).any_instance.stubs(:line).returns(42)
675
+ allow_any_instance_of(Puppet::Type.type(:file)).to receive(:file).and_return("example.pp")
676
+ allow_any_instance_of(Puppet::Type.type(:file)).to receive(:line).and_return(42)
678
677
  expect { Puppet::Type.type(:file).new(:title => "/foo", :source => "unknown:///") }.to raise_error(Puppet::ResourceError, /\(file: example\.pp, line: 42\)/)
679
678
  end
680
679
  end
@@ -690,15 +689,15 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
690
689
  end
691
690
 
692
691
  it "should set the attributes in the order returned by the class's :allattrs method" do
693
- klass.stubs(:allattrs).returns([:name, :atboot, :noop])
692
+ allow(klass).to receive(:allattrs).and_return([:name, :atboot, :noop])
694
693
  resource = Puppet::Resource.new(resource_type, "/foo", :parameters => {:name => "myname", :atboot => :yes, :noop => "whatever"})
695
694
 
696
695
  set = []
697
696
 
698
- klass.any_instance.stubs(:newattr).with do |param, hash|
697
+ allow_any_instance_of(klass).to receive(:newattr) do |_, param, hash|
699
698
  set << param
700
- true
701
- end.returns(stub_everything("a property"))
699
+ double("a property", :value= => nil, :default => nil, :name => nil)
700
+ end
702
701
 
703
702
  klass.new(resource)
704
703
 
@@ -707,15 +706,15 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
707
706
  end
708
707
 
709
708
  it "should always set the name and then default provider before anything else" do
710
- klass.stubs(:allattrs).returns([:provider, :name, :atboot])
709
+ allow(klass).to receive(:allattrs).and_return([:provider, :name, :atboot])
711
710
  resource = Puppet::Resource.new(resource_type, "/foo", :parameters => {:name => "myname", :atboot => :yes})
712
711
 
713
712
  set = []
714
713
 
715
- klass.any_instance.stubs(:newattr).with do |param, hash|
714
+ allow_any_instance_of(klass).to receive(:newattr) do |_, param, hash|
716
715
  set << param
717
- true
718
- end.returns(stub_everything("a property"))
716
+ double("a property", :value= => nil, :default => nil, :name => nil)
717
+ end
719
718
 
720
719
  klass.new(resource)
721
720
  expect(set[0]).to eq(:name)
@@ -728,10 +727,10 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
728
727
  # on jruby. Thus, we stub it out here since we don't care to do any assertions on it.
729
728
  # This is only an issue if you're running these unit tests on a platform where upstart
730
729
  # is a default provider, like Ubuntu trusty.
731
- Puppet::Util::Execution.stubs(:execute)
730
+ allow(Puppet::Util::Execution).to receive(:execute)
732
731
 
733
732
  defaults = []
734
- Puppet::Type.type(:service).any_instance.stubs(:set_default).with { |value| defaults << value; true }
733
+ allow_any_instance_of(Puppet::Type.type(:service)).to receive(:set_default) { |_, value| defaults << value }
735
734
 
736
735
  Puppet::Type.type(:service).new :name => "whatever"
737
736
 
@@ -748,7 +747,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
748
747
 
749
748
  context "when validating the resource" do
750
749
  it "should call the type's validate method if present" do
751
- Puppet::Type.type(:file).any_instance.expects(:validate)
750
+ expect_any_instance_of(Puppet::Type.type(:file)).to receive(:validate)
752
751
  Puppet::Type.type(:file).new(:name => make_absolute('/foo'))
753
752
  end
754
753
 
@@ -763,8 +762,8 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
763
762
  end
764
763
 
765
764
  it "should raise Puppet::ResourceError with manifest file and line on failure" do
766
- Puppet::Type.type(:file).any_instance.stubs(:file).returns("example.pp")
767
- Puppet::Type.type(:file).any_instance.stubs(:line).returns(42)
765
+ allow_any_instance_of(Puppet::Type.type(:file)).to receive(:file).and_return("example.pp")
766
+ allow_any_instance_of(Puppet::Type.type(:file)).to receive(:line).and_return(42)
768
767
  expect do
769
768
  Puppet::Type.type(:file).new(
770
769
  :name => make_absolute('/foo'),
@@ -856,7 +855,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
856
855
  end
857
856
 
858
857
  it "should use the Resource Type's namevar to determine how to find the name in the hash" do
859
- @type.stubs(:key_attributes).returns([ :myname ])
858
+ allow(@type).to receive(:key_attributes).and_return([ :myname ])
860
859
 
861
860
  expect(@type.hash2resource(:myname => "foo").title).to eq("foo")
862
861
  end
@@ -890,26 +889,26 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
890
889
  describe "when retrieving current property values" do
891
890
  before do
892
891
  @resource = klass.new(:name => "foo", :fstype => "bar", :pass => 1, :ensure => :present)
893
- @resource.property(:ensure).stubs(:retrieve).returns :absent
892
+ allow(@resource.property(:ensure)).to receive(:retrieve).and_return(:absent)
894
893
  end
895
894
 
896
895
  it "should always retrieve the ensure value by default" do
897
896
  @ensurable_resource = Puppet::Type.type(:file).new(:name => "/not/existent", :mode => "0644")
898
- Puppet::Type::File::Ensure.stubs(:ensure).returns :absent
899
- Puppet::Type::File::Ensure.any_instance.expects(:retrieve).once
897
+ allow(Puppet::Type::File::Ensure).to receive(:ensure).and_return(:absent)
898
+ expect_any_instance_of(Puppet::Type::File::Ensure).to receive(:retrieve).once
900
899
  @ensurable_resource.retrieve_resource
901
900
  end
902
901
 
903
902
  it "should not retrieve the ensure value if specified" do
904
903
  @ensurable_resource = Puppet::Type.type(:service).new(:name => "DummyService", :enable => true)
905
- @ensurable_resource.properties.each { |prop| prop.stubs(:retrieve) }
906
- Puppet::Type::Service::Ensure.any_instance.expects(:retrieve).never
904
+ @ensurable_resource.properties.each { |prop| allow(prop).to receive(:retrieve) }
905
+ expect_any_instance_of(Puppet::Type::Service::Ensure).not_to receive(:retrieve)
907
906
  @ensurable_resource.retrieve_resource
908
907
  end
909
908
 
910
909
  it "should fail if its provider is unsuitable" do
911
910
  @resource = klass.new(:name => "foo", :fstype => "bar", :pass => 1, :ensure => :present)
912
- @resource.provider.class.expects(:suitable?).returns false
911
+ expect(@resource.provider.class).to receive(:suitable?).and_return(false)
913
912
  expect { @resource.retrieve_resource }.to raise_error(Puppet::Error)
914
913
  end
915
914
 
@@ -936,14 +935,14 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
936
935
  end
937
936
 
938
937
  it "should not call retrieve on non-ensure properties if the resource is absent and should consider the property absent" do
939
- @resource.property(:ensure).expects(:retrieve).returns :absent
940
- @resource.property(:fstype).expects(:retrieve).never
938
+ expect(@resource.property(:ensure)).to receive(:retrieve).and_return(:absent)
939
+ expect(@resource.property(:fstype)).not_to receive(:retrieve)
941
940
  expect(@resource.retrieve_resource[:fstype]).to eq(:absent)
942
941
  end
943
942
 
944
943
  it "should include the result of retrieving each property's current value if the resource is present" do
945
- @resource.property(:ensure).expects(:retrieve).returns :present
946
- @resource.property(:fstype).expects(:retrieve).returns 15
944
+ expect(@resource.property(:ensure)).to receive(:retrieve).and_return(:present)
945
+ expect(@resource.property(:fstype)).to receive(:retrieve).and_return(15)
947
946
  @resource.retrieve_resource[:fstype] == 15
948
947
  end
949
948
  end
@@ -962,8 +961,8 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
962
961
  expect(type_resource.parameters[:remounts]).not_to be_a(Puppet::Property)
963
962
  expect(type_resource.parameters[:fstype].is_a?(Puppet::Property)).to be_truthy
964
963
 
965
- type_resource.property(:ensure).expects(:retrieve).returns :present
966
- type_resource.property(:fstype).expects(:retrieve).returns 15
964
+ expect(type_resource.property(:ensure)).to receive(:retrieve).and_return(:present)
965
+ expect(type_resource.property(:fstype)).to receive(:retrieve).and_return(15)
967
966
 
968
967
  resource = type_resource.to_resource
969
968
 
@@ -978,7 +977,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
978
977
  describe "when there's one namevar" do
979
978
  before do
980
979
  @type_class = Puppet::Type.type(:notify)
981
- @type_class.stubs(:key_attributes).returns([:one])
980
+ allow(@type_class).to receive(:key_attributes).and_return([:one])
982
981
  end
983
982
 
984
983
  it "should have a default pattern for when there's one namevar" do
@@ -1033,7 +1032,7 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
1033
1032
  let(:provider) { resource.provider }
1034
1033
 
1035
1034
  it "should be suitable if its type doesn't use providers" do
1036
- type.stubs(:paramclass).with(:provider).returns nil
1035
+ allow(type).to receive(:paramclass).with(:provider).and_return(nil)
1037
1036
  expect(resource).to be_suitable
1038
1037
  end
1039
1038
 
@@ -1042,18 +1041,18 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
1042
1041
  end
1043
1042
 
1044
1043
  it "should not be suitable if it has a provider which is not suitable" do
1045
- provider.class.stubs(:suitable?).returns false
1044
+ allow(provider.class).to receive(:suitable?).and_return(false)
1046
1045
  expect(resource).not_to be_suitable
1047
1046
  end
1048
1047
 
1049
1048
  it "should be suitable if it does not have a provider and there is a default provider" do
1050
- resource.stubs(:provider).returns nil
1049
+ allow(resource).to receive(:provider).and_return(nil)
1051
1050
  expect(resource).to be_suitable
1052
1051
  end
1053
1052
 
1054
1053
  it "should not be suitable if it doesn't have a provider and there is not default provider" do
1055
- resource.stubs(:provider).returns nil
1056
- type.stubs(:defaultprovider).returns nil
1054
+ allow(resource).to receive(:provider).and_return(nil)
1055
+ allow(type).to receive(:defaultprovider).and_return(nil)
1057
1056
 
1058
1057
  expect(resource).not_to be_suitable
1059
1058
  end
@@ -1185,27 +1184,29 @@ describe Puppet::Type::RelationshipMetaparam do
1185
1184
  end
1186
1185
 
1187
1186
  it "should be able to validate relationships" do
1188
- expect(Puppet::Type.metaparamclass(:require).new(:resource => mock("resource"))).to respond_to(:validate_relationship)
1187
+ expect(Puppet::Type.metaparamclass(:require).new(:resource => double("resource"))).to respond_to(:validate_relationship)
1189
1188
  end
1190
1189
 
1191
1190
  describe 'if any specified resource is not in the catalog' do
1192
- let(:catalog) { mock 'catalog' }
1191
+ let(:catalog) { double('catalog') }
1193
1192
 
1194
1193
  let(:resource) do
1195
- stub 'resource',
1194
+ double(
1195
+ 'resource',
1196
1196
  :catalog => catalog,
1197
1197
  :ref => 'resource',
1198
1198
  :line= => nil,
1199
1199
  :line => nil,
1200
1200
  :file= => nil,
1201
1201
  :file => nil
1202
+ )
1202
1203
  end
1203
1204
 
1204
1205
  let(:param) { Puppet::Type.metaparamclass(:require).new(:resource => resource, :value => %w{Foo[bar] Class[test]}) }
1205
1206
 
1206
1207
  before do
1207
- catalog.expects(:resource).with("Foo[bar]").returns "something"
1208
- catalog.expects(:resource).with("Class[Test]").returns nil
1208
+ expect(catalog).to receive(:resource).with("Foo[bar]").and_return("something")
1209
+ expect(catalog).to receive(:resource).with("Class[Test]").and_return(nil)
1209
1210
  end
1210
1211
 
1211
1212
  describe "and the resource doesn't have a file or line number" do
@@ -1219,8 +1220,8 @@ describe Puppet::Type::RelationshipMetaparam do
1219
1220
 
1220
1221
  describe "and the resource has a file or line number" do
1221
1222
  before do
1222
- resource.stubs(:line).returns '42'
1223
- resource.stubs(:file).returns '/hitchhikers/guide/to/the/galaxy'
1223
+ allow(resource).to receive(:line).and_return('42')
1224
+ allow(resource).to receive(:file).and_return('/hitchhikers/guide/to/the/galaxy')
1224
1225
  end
1225
1226
 
1226
1227
  it "raises an error with context" do
@@ -1280,8 +1281,8 @@ describe Puppet::Type.metaparamclass(:audit) do
1280
1281
 
1281
1282
  describe "when generating the uniqueness key" do
1282
1283
  it "should include all of the key_attributes in alphabetical order by attribute name" do
1283
- Puppet::Type.type(:file).stubs(:key_attributes).returns [:path, :mode, :owner]
1284
- Puppet::Type.type(:file).stubs(:title_patterns).returns(
1284
+ allow(Puppet::Type.type(:file)).to receive(:key_attributes).and_return([:path, :mode, :owner])
1285
+ allow(Puppet::Type.type(:file)).to receive(:title_patterns).and_return(
1285
1286
  [ [ /(.*)/, [ [:path, lambda{|x| x} ] ] ] ]
1286
1287
  )
1287
1288
  myfile = make_absolute('/my/file')