puppet 6.0.7-x86-mingw32 → 6.0.8-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  component = Puppet::Type.type(:component)
@@ -1,11 +1,10 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
- describe Puppet::Type.type(:exec) do
3
+ RSpec.describe Puppet::Type.type(:exec) do
5
4
  include PuppetSpec::Files
6
5
 
7
6
  def exec_tester(command, exitstatus = 0, rest = {})
8
- Puppet.features.stubs(:root?).returns(true)
7
+ allow(Puppet.features).to receive(:root?).and_return(true)
9
8
 
10
9
  output = rest.delete(:output) || ''
11
10
 
@@ -21,12 +20,13 @@ describe Puppet::Type.type(:exec) do
21
20
  }.merge(rest)
22
21
 
23
22
  exec = Puppet::Type.type(:exec).new(type_args)
23
+ expect(Puppet::Util::Execution).to receive(:execute) do |cmd, options|
24
+ expect(cmd).to eq(command)
25
+ expect(options[:override_locale]).to eq(false)
26
+ expect(options).to have_key(:custom_environment)
24
27
 
25
- Puppet::Util::Execution.expects(:execute).times(tries).with() do |*args|
26
- args[0] == command &&
27
- args[1][:override_locale] == false &&
28
- args[1].has_key?(:custom_environment)
29
- end.returns(output)
28
+ output
29
+ end.exactly(tries).times
30
30
 
31
31
  return exec
32
32
  end
@@ -44,12 +44,12 @@ describe Puppet::Type.type(:exec) do
44
44
  # We have to set 'unless' in resource init or it can not be marked sensitive correctly.
45
45
  # So: we create a dummy ahead of time and use 'any_instance' to stub out provider methods.
46
46
  dummy = Puppet::Type.type(:exec).new(:name => @command)
47
- dummy.provider.class.any_instance.stubs(:validatecmd)
48
- dummy.provider.class.any_instance.stubs(:checkexe).returns(true)
49
- pass_status = stub('status', :exitstatus => 0, :split => ["pass output"])
50
- fail_status = stub('status', :exitstatus => 1, :split => ["fail output"])
51
- Puppet::Util::Execution.stubs(:execute).with(:true, anything).returns(pass_status)
52
- Puppet::Util::Execution.stubs(:execute).with(:false, anything).returns(fail_status)
47
+ allow_any_instance_of(dummy.provider.class).to receive(:validatecmd)
48
+ allow_any_instance_of(dummy.provider.class).to receive(:checkexe).and_return(true)
49
+ pass_status = double('status', :exitstatus => 0, :split => ["pass output"])
50
+ fail_status = double('status', :exitstatus => 1, :split => ["fail output"])
51
+ allow(Puppet::Util::Execution).to receive(:execute).with(:true, anything).and_return(pass_status)
52
+ allow(Puppet::Util::Execution).to receive(:execute).with(:false, anything).and_return(fail_status)
53
53
 
54
54
  test = Puppet::Type.type(:exec).new(type_args)
55
55
 
@@ -280,15 +280,15 @@ describe Puppet::Type.type(:exec) do
280
280
  describe "when setting user" do
281
281
  describe "on POSIX systems", :if => Puppet.features.posix? do
282
282
  it "should fail if we are not root" do
283
- Puppet.features.stubs(:root?).returns(false)
283
+ allow(Puppet.features).to receive(:root?).and_return(false)
284
284
  expect {
285
285
  Puppet::Type.type(:exec).new(:name => '/bin/true whatever', :user => 'input')
286
286
  }.to raise_error Puppet::Error, /Parameter user failed/
287
287
  end
288
288
 
289
289
  it "accepts the current user" do
290
- Puppet.features.stubs(:root?).returns(false)
291
- Etc.stubs(:getpwuid).returns(Struct::Passwd.new('input'))
290
+ allow(Puppet.features).to receive(:root?).and_return(false)
291
+ allow(Etc).to receive(:getpwuid).and_return(Struct::Passwd.new('input'))
292
292
 
293
293
  type = Puppet::Type.type(:exec).new(:name => '/bin/true whatever', :user => 'input')
294
294
 
@@ -297,7 +297,7 @@ describe Puppet::Type.type(:exec) do
297
297
 
298
298
  ['one', 2, 'root', 4294967295, 4294967296].each do |value|
299
299
  it "should accept '#{value}' as user if we are root" do
300
- Puppet.features.stubs(:root?).returns(true)
300
+ allow(Puppet.features).to receive(:root?).and_return(true)
301
301
  type = Puppet::Type.type(:exec).new(:name => '/bin/true whatever', :user => value)
302
302
  expect(type[:user]).to eq(value)
303
303
  end
@@ -306,7 +306,7 @@ describe Puppet::Type.type(:exec) do
306
306
 
307
307
  describe "on Windows systems", :if => Puppet::Util::Platform.windows? do
308
308
  before :each do
309
- Puppet.features.stubs(:root?).returns(true)
309
+ allow(Puppet.features).to receive(:root?).and_return(true)
310
310
  end
311
311
 
312
312
  it "should reject user parameter" do
@@ -328,12 +328,16 @@ describe Puppet::Type.type(:exec) do
328
328
  end
329
329
 
330
330
  describe "when running as root" do
331
- before :each do Puppet.features.stubs(:root?).returns(true) end
331
+ before(:each) do
332
+ allow(Puppet.features).to receive(:root?).and_return(true)
333
+ end
332
334
  it_behaves_like "exec[:group]"
333
335
  end
334
336
 
335
337
  describe "when not running as root" do
336
- before :each do Puppet.features.stubs(:root?).returns(false) end
338
+ before(:each) do
339
+ allow(Puppet.features).to receive(:root?).and_return(false)
340
+ end
337
341
  it_behaves_like "exec[:group]"
338
342
  end
339
343
  end
@@ -361,9 +365,9 @@ describe Puppet::Type.type(:exec) do
361
365
  instance = Puppet::Type.type(:exec).new(:name => @executable)
362
366
  end
363
367
  if valid then
364
- instance.provider.expects(:validatecmd).returns(true)
368
+ expect(instance.provider).to receive(:validatecmd).and_return(true)
365
369
  else
366
- instance.provider.expects(:validatecmd).raises(Puppet::Error, "from a stub")
370
+ expect(instance.provider).to receive(:validatecmd).and_raise(Puppet::Error, "from a stub")
367
371
  end
368
372
  instance[@param] = command
369
373
  end
@@ -388,16 +392,16 @@ describe Puppet::Type.type(:exec) do
388
392
 
389
393
  it "should accept the array when all commands return valid" do
390
394
  input = %w{one two three}
391
- @test.provider.expects(:validatecmd).times(input.length).returns(true)
395
+ expect(@test.provider).to receive(:validatecmd).exactly(input.length).times.and_return(true)
392
396
  @test[param] = input
393
397
  expect(@test[param]).to eq(input)
394
398
  end
395
399
 
396
400
  it "should reject the array when any commands return invalid" do
397
401
  input = %w{one two three}
398
- @test.provider.expects(:validatecmd).with(input.first).returns(false)
402
+ expect(@test.provider).to receive(:validatecmd).with(input.first).and_return(false)
399
403
  input[1..-1].each do |cmd|
400
- @test.provider.expects(:validatecmd).with(cmd).returns(true)
404
+ expect(@test.provider).to receive(:validatecmd).with(cmd).and_return(true)
401
405
  end
402
406
  @test[param] = input
403
407
  expect(@test[param]).to eq(input)
@@ -405,7 +409,7 @@ describe Puppet::Type.type(:exec) do
405
409
 
406
410
  it "should reject the array when all commands return invalid" do
407
411
  input = %w{one two three}
408
- @test.provider.expects(:validatecmd).times(input.length).returns(false)
412
+ expect(@test.provider).to receive(:validatecmd).exactly(input.length).times.and_return(false)
409
413
  @test[param] = input
410
414
  expect(@test[param]).to eq(input)
411
415
  end
@@ -486,7 +490,7 @@ describe Puppet::Type.type(:exec) do
486
490
 
487
491
  context 'on POSIX', :unless => Puppet::Util::Platform.windows? || RUBY_PLATFORM == 'java' do
488
492
  it 'sends a SIGTERM and raises a Puppet::Error' do
489
- Process.expects(:kill).at_least_once
493
+ expect(Process).to receive(:kill).at_least(:once)
490
494
  expect { subject.refresh }.to raise_error Puppet::Error, "Command exceeded timeout"
491
495
  end
492
496
  end
@@ -692,15 +696,15 @@ describe Puppet::Type.type(:exec) do
692
696
  @pass = make_absolute("/magic/pass")
693
697
  @fail = make_absolute("/magic/fail")
694
698
 
695
- @pass_status = stub('status', :exitstatus => sense[:pass] ? 0 : 1)
696
- @fail_status = stub('status', :exitstatus => sense[:fail] ? 0 : 1)
699
+ @pass_status = double('status', :exitstatus => sense[:pass] ? 0 : 1)
700
+ @fail_status = double('status', :exitstatus => sense[:fail] ? 0 : 1)
697
701
 
698
- @test.provider.stubs(:checkexe).returns(true)
702
+ allow(@test.provider).to receive(:checkexe).and_return(true)
699
703
  [true, false].each do |check|
700
- @test.provider.stubs(:run).with(@pass, check).
701
- returns(['test output', @pass_status])
702
- @test.provider.stubs(:run).with(@fail, check).
703
- returns(['test output', @fail_status])
704
+ allow(@test.provider).to receive(:run).with(@pass, check).
705
+ and_return(['test output', @pass_status])
706
+ allow(@test.provider).to receive(:run).with(@fail, check).
707
+ and_return(['test output', @fail_status])
704
708
  end
705
709
  end
706
710
 
@@ -761,17 +765,17 @@ describe Puppet::Type.type(:exec) do
761
765
  end
762
766
 
763
767
  it "should return :notrun when check_all_attributes returns true" do
764
- @exec_resource.stubs(:check_all_attributes).returns true
768
+ allow(@exec_resource).to receive(:check_all_attributes).and_return(true)
765
769
  expect(@exec_resource.retrieve[:returns]).to eq(:notrun)
766
770
  end
767
771
 
768
772
  it "should return default exit code 0 when check_all_attributes returns false" do
769
- @exec_resource.stubs(:check_all_attributes).returns false
773
+ allow(@exec_resource).to receive(:check_all_attributes).and_return(false)
770
774
  expect(@exec_resource.retrieve[:returns]).to eq(['0'])
771
775
  end
772
776
 
773
777
  it "should return the specified exit code when check_all_attributes returns false" do
774
- @exec_resource.stubs(:check_all_attributes).returns false
778
+ allow(@exec_resource).to receive(:check_all_attributes).and_return(false)
775
779
  @exec_resource[:returns] = 42
776
780
  expect(@exec_resource.retrieve[:returns]).to eq(["42"])
777
781
  end
@@ -783,11 +787,11 @@ describe Puppet::Type.type(:exec) do
783
787
  end
784
788
 
785
789
  it "should return the provider's run output" do
786
- provider = stub 'provider'
787
- status = stubs "process_status"
788
- status.stubs(:exitstatus).returns("0")
789
- provider.expects(:run).returns(["silly output", status])
790
- @exec_resource.stubs(:provider).returns(provider)
790
+ provider = double('provider')
791
+ status = double('process_status')
792
+ allow(status).to receive(:exitstatus).and_return("0")
793
+ expect(provider).to receive(:run).and_return(["silly output", status])
794
+ allow(@exec_resource).to receive(:provider).and_return(provider)
791
795
 
792
796
  @exec_resource.refresh
793
797
  expect(@exec_resource.output).to eq('silly output')
@@ -801,29 +805,29 @@ describe Puppet::Type.type(:exec) do
801
805
 
802
806
  it "should call provider run with the refresh parameter if it is set" do
803
807
  myother_bogus_cmd = make_absolute('/myother/bogus/cmd')
804
- provider = stub 'provider'
805
- @exec_resource.stubs(:provider).returns(provider)
806
- @exec_resource.stubs(:[]).with(:refresh).returns(myother_bogus_cmd)
807
- provider.expects(:run).with(myother_bogus_cmd)
808
+ provider = double('provider')
809
+ allow(@exec_resource).to receive(:provider).and_return(provider)
810
+ allow(@exec_resource).to receive(:[]).with(:refresh).and_return(myother_bogus_cmd)
811
+ expect(provider).to receive(:run).with(myother_bogus_cmd)
808
812
 
809
813
  @exec_resource.refresh
810
814
  end
811
815
 
812
816
  it "should call provider run with the specified command if the refresh parameter is not set" do
813
- provider = stub 'provider'
814
- status = stubs "process_status"
815
- status.stubs(:exitstatus).returns("0")
816
- provider.expects(:run).with(@bogus_cmd).returns(["silly output", status])
817
- @exec_resource.stubs(:provider).returns(provider)
817
+ provider = double('provider')
818
+ status = double('process_status')
819
+ allow(status).to receive(:exitstatus).and_return("0")
820
+ expect(provider).to receive(:run).with(@bogus_cmd).and_return(["silly output", status])
821
+ allow(@exec_resource).to receive(:provider).and_return(provider)
818
822
 
819
823
  @exec_resource.refresh
820
824
  end
821
825
 
822
826
  it "should not run the provider if check_all_attributes is false" do
823
- @exec_resource.stubs(:check_all_attributes).returns false
824
- provider = stub 'provider'
825
- provider.expects(:run).never
826
- @exec_resource.stubs(:provider).returns(provider)
827
+ allow(@exec_resource).to receive(:check_all_attributes).and_return(false)
828
+ provider = double('provider')
829
+ expect(provider).not_to receive(:run)
830
+ allow(@exec_resource).to receive(:provider).and_return(provider)
827
831
 
828
832
  @exec_resource.refresh
829
833
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  checksum = Puppet::Type.type(:file).attrclass(:checksum)
@@ -15,12 +14,12 @@ describe checksum do
15
14
 
16
15
  it "should use its current value when asked to sum content" do
17
16
  @checksum.value = :md5lite
18
- @checksum.expects(:md5lite).with("foobar").returns "yay"
17
+ expect(@checksum).to receive(:md5lite).with("foobar").and_return("yay")
19
18
  @checksum.sum("foobar")
20
19
  end
21
20
 
22
21
  it "should use :md5 to sum when no value is set" do
23
- @checksum.expects(:md5).with("foobar").returns "yay"
22
+ expect(@checksum).to receive(:md5).with("foobar").and_return("yay")
24
23
  @checksum.sum("foobar")
25
24
  end
26
25
 
@@ -54,36 +53,36 @@ describe checksum do
54
53
 
55
54
  it "should use its current value when asked to sum a file's content" do
56
55
  @checksum.value = :md5lite
57
- @checksum.expects(:md5lite_file).with(@path).returns "yay"
56
+ expect(@checksum).to receive(:md5lite_file).with(@path).and_return("yay")
58
57
  @checksum.sum_file(@path)
59
58
  end
60
59
 
61
60
  it "should use :md5 to sum a file when no value is set" do
62
- @checksum.expects(:md5_file).with(@path).returns "yay"
61
+ expect(@checksum).to receive(:md5_file).with(@path).and_return("yay")
63
62
  @checksum.sum_file(@path)
64
63
  end
65
64
 
66
65
  it "should convert all sums to strings when summing files" do
67
66
  @checksum.value = :mtime
68
- @checksum.expects(:mtime_file).with(@path).returns Time.now
67
+ expect(@checksum).to receive(:mtime_file).with(@path).and_return(Time.now)
69
68
  expect { @checksum.sum_file(@path) }.not_to raise_error
70
69
  end
71
70
 
72
71
  it "should return the summed contents of a file with a checksum label" do
73
72
  @resource[:checksum] = :md5
74
- @checksum.expects(:md5_file).returns "mysum"
73
+ expect(@checksum).to receive(:md5_file).and_return("mysum")
75
74
  expect(@checksum.sum_file(@path)).to eq("{md5}mysum")
76
75
  end
77
76
 
78
77
  it "should return the summed contents of a stream with a checksum label" do
79
78
  @resource[:checksum] = :md5
80
- @checksum.expects(:md5_stream).returns "mysum"
79
+ expect(@checksum).to receive(:md5_stream).and_return("mysum")
81
80
  expect(@checksum.sum_stream).to eq("{md5}mysum")
82
81
  end
83
82
 
84
83
  it "should yield the sum_stream block to the underlying checksum" do
85
84
  @resource[:checksum] = :md5
86
- @checksum.expects(:md5_stream).yields("something").returns("mysum")
85
+ expect(@checksum).to receive(:md5_stream).and_yield("something").and_return("mysum")
87
86
  @checksum.sum_stream do |sum|
88
87
  expect(sum).to eq("something")
89
88
  end
@@ -96,7 +95,7 @@ describe checksum do
96
95
  end
97
96
 
98
97
  it 'rejects md5 checksums in FIPS mode' do
99
- Puppet::Util::Platform.stubs(:fips_enabled?).returns true
98
+ allow(Puppet::Util::Platform).to receive(:fips_enabled?).and_return(true)
100
99
  expect {
101
100
  @resource[:checksum] = :md5
102
101
  }.to raise_error(Puppet::ResourceError,
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums => true do
@@ -19,7 +18,7 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
19
18
  let(:checksum_value) { described_class.new(:resource => resource) }
20
19
 
21
20
  it "should not compute a checksum if source is absent" do
22
- resource.expects(:stat).never
21
+ expect(resource).not_to receive(:stat)
23
22
  expect(checksum_value.retrieve).to be_nil
24
23
  end
25
24
 
@@ -29,21 +28,21 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
29
28
  end
30
29
 
31
30
  it "should return :absent if the target does not exist" do
32
- resource.expects(:stat).returns nil
31
+ expect(resource).to receive(:stat).and_return(nil)
33
32
 
34
33
  expect(checksum_value.retrieve).to eq(:absent)
35
34
  end
36
35
 
37
36
  it "should not manage content on directories" do
38
- stat = mock 'stat', :ftype => "directory"
39
- resource.expects(:stat).returns stat
37
+ stat = double('stat', :ftype => "directory")
38
+ expect(resource).to receive(:stat).and_return(stat)
40
39
 
41
40
  expect(checksum_value.retrieve).to be_nil
42
41
  end
43
42
 
44
43
  it "should not manage content on links" do
45
- stat = mock 'stat', :ftype => "link"
46
- resource.expects(:stat).returns stat
44
+ stat = double('stat', :ftype => "link")
45
+ expect(resource).to receive(:stat).and_return(stat)
47
46
 
48
47
  expect(checksum_value.retrieve).to be_nil
49
48
  end
@@ -51,11 +50,11 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
51
50
  it "should always return the checksum as a string" do
52
51
  resource[:checksum] = :mtime
53
52
 
54
- stat = mock 'stat', :ftype => "file"
55
- resource.expects(:stat).returns stat
53
+ stat = double('stat', :ftype => "file")
54
+ expect(resource).to receive(:stat).and_return(stat)
56
55
 
57
56
  time = Time.now
58
- resource.parameter(:checksum).expects(:mtime_file).with(resource[:path]).returns time
57
+ expect(resource.parameter(:checksum)).to receive(:mtime_file).with(resource[:path]).and_return(time)
59
58
 
60
59
  expect(checksum_value.retrieve).to eq(time.to_s)
61
60
  end
@@ -63,9 +62,9 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
63
62
 
64
63
  with_digest_algorithms do
65
64
  it "should return the checksum of the target if it exists and is a normal file" do
66
- stat = mock 'stat', :ftype => "file"
67
- resource.expects(:stat).returns stat
68
- resource.parameter(:checksum).expects("#{digest_algorithm}_file".intern).with(resource[:path]).returns "mysum"
65
+ stat = double('stat', :ftype => "file")
66
+ expect(resource).to receive(:stat).and_return(stat)
67
+ expect(resource.parameter(:checksum)).to receive("#{digest_algorithm}_file".intern).with(resource[:path]).and_return("mysum")
69
68
  resource[:source] = source_file
70
69
 
71
70
  expect(checksum_value.retrieve).to eq("mysum")
@@ -96,7 +95,7 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
96
95
  end
97
96
 
98
97
  it "should return true if the resource shouldn't be a regular file" do
99
- resource.expects(:should_be_file?).returns false
98
+ expect(resource).to receive(:should_be_file?).and_return(false)
100
99
  checksum_value.should = "foo"
101
100
  expect(checksum_value).to be_safe_insync("whatever")
102
101
  end
@@ -107,7 +106,7 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
107
106
  end
108
107
 
109
108
  it "should return false if the file should be a file but is not present" do
110
- resource.expects(:should_be_file?).returns true
109
+ expect(resource).to receive(:should_be_file?).and_return(true)
111
110
  checksum_value.should = "foo"
112
111
 
113
112
  expect(checksum_value).not_to be_safe_insync(:absent)
@@ -115,7 +114,7 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
115
114
 
116
115
  describe "and the file exists" do
117
116
  before do
118
- resource.stubs(:stat).returns mock("stat")
117
+ allow(resource).to receive(:stat).and_return(double("stat"))
119
118
  checksum_value.should = "somechecksum"
120
119
  end
121
120
 
@@ -135,19 +134,19 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
135
134
  describe "and Puppet[:show_diff] is #{cfg} and show_diff => #{param}" do
136
135
  before do
137
136
  Puppet[:show_diff] = cfg
138
- resource.stubs(:show_diff?).returns param
137
+ allow(resource).to receive(:show_diff?).and_return(param)
139
138
  resource[:loglevel] = "debug"
140
139
  end
141
140
 
142
141
  if cfg and param
143
142
  it "should display a diff" do
144
- checksum_value.expects(:diff).returns("my diff").once
145
- checksum_value.expects(:debug).with("\nmy diff").once
143
+ expect(checksum_value).to receive(:diff).and_return("my diff").once
144
+ expect(checksum_value).to receive(:debug).with("\nmy diff").once
146
145
  expect(checksum_value).not_to be_safe_insync("otherchecksum")
147
146
  end
148
147
  else
149
148
  it "should not display a diff" do
150
- checksum_value.expects(:diff).never
149
+ expect(checksum_value).not_to receive(:diff)
151
150
  expect(checksum_value).not_to be_safe_insync("otherchecksum")
152
151
  end
153
152
  end
@@ -202,17 +201,17 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
202
201
 
203
202
  describe "and :replace is false" do
204
203
  before do
205
- resource.stubs(:replace?).returns false
204
+ allow(resource).to receive(:replace?).and_return(false)
206
205
  end
207
206
 
208
207
  it "should be insync if the file exists and the checksum_value is different" do
209
- resource.stubs(:stat).returns mock('stat')
208
+ allow(resource).to receive(:stat).and_return(double('stat'))
210
209
 
211
210
  expect(checksum_value).to be_safe_insync("whatever")
212
211
  end
213
212
 
214
213
  it "should be insync if the file exists and the checksum_value is right" do
215
- resource.stubs(:stat).returns mock('stat')
214
+ allow(resource).to receive(:stat).and_return(double('stat'))
216
215
 
217
216
  expect(checksum_value).to be_safe_insync("something")
218
217
  end
@@ -231,7 +230,7 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
231
230
  before do
232
231
  @new_resource = Puppet::Type.type(:file).new :ensure => :file, :path => path, :catalog => catalog,
233
232
  :checksum_value => checksum, :checksum => checksum_type, :source => source_file
234
- @new_resource.stubs(:stat).returns mock('stat')
233
+ allow(@new_resource).to receive(:stat).and_return(double('stat'))
235
234
  end
236
235
 
237
236
  it "should return false if the current checksum_value is different from the desired checksum_value" do
@@ -249,12 +248,12 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
249
248
  let(:checksum_value) { described_class.new(:resource => resource) }
250
249
 
251
250
  before do
252
- resource.stubs(:[]).with(:path).returns "/boo"
253
- resource.stubs(:stat).returns "eh"
251
+ allow(resource).to receive(:[]).with(:path).and_return("/boo")
252
+ allow(resource).to receive(:stat).and_return("eh")
254
253
  end
255
254
 
256
255
  it "should raise if source is absent" do
257
- resource.expects(:write).never
256
+ expect(resource).not_to receive(:write)
258
257
 
259
258
  expect { checksum_value.sync }.to raise_error "checksum_value#sync should not be called without a source parameter"
260
259
  end
@@ -265,20 +264,20 @@ describe Puppet::Type.type(:file).attrclass(:checksum_value), :uses_checksums =>
265
264
  end
266
265
 
267
266
  it "should use the file's :write method to write the checksum_value" do
268
- resource.expects(:write).with(resource.parameter(:source))
267
+ expect(resource).to receive(:write).with(resource.parameter(:source))
269
268
 
270
269
  checksum_value.sync
271
270
  end
272
271
 
273
272
  it "should return :file_changed if the file already existed" do
274
- resource.expects(:stat).returns "something"
275
- resource.stubs(:write)
273
+ expect(resource).to receive(:stat).and_return("something")
274
+ allow(resource).to receive(:write)
276
275
  expect(checksum_value.sync).to eq(:file_changed)
277
276
  end
278
277
 
279
278
  it "should return :file_created if the file did not exist" do
280
- resource.expects(:stat).returns nil
281
- resource.stubs(:write)
279
+ expect(resource).to receive(:stat).and_return(nil)
280
+ allow(resource).to receive(:write)
282
281
  expect(checksum_value.sync).to eq(:file_created)
283
282
  end
284
283
  end