puppet 6.0.7-x86-mingw32 → 6.0.8-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:filebucket) do
@@ -77,26 +76,26 @@ describe Puppet::Type.type(:filebucket) do
77
76
 
78
77
  describe "when creating the filebucket" do
79
78
  before do
80
- @bucket = stub 'bucket', :name= => nil
79
+ @bucket = double('bucket', :name= => nil)
81
80
  end
82
81
 
83
82
  it "should use any provided path" do
84
83
  path = make_absolute("/foo/bar")
85
84
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :path => path
86
- Puppet::FileBucket::Dipper.expects(:new).with(:Path => path).returns @bucket
85
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Path => path).and_return(@bucket)
87
86
  bucket.bucket
88
87
  end
89
88
 
90
89
  it "should use any provided server and port" do
91
90
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :server => "myserv", :port => "myport", :path => false
92
- Puppet::FileBucket::Dipper.expects(:new).with(:Server => "myserv", :Port => "myport").returns @bucket
91
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Server => "myserv", :Port => "myport").and_return(@bucket)
93
92
  bucket.bucket
94
93
  end
95
94
 
96
95
  it "should not try to guess server or port if the path is unset and no server is provided" do
97
96
  Puppet.settings[:server] = "myserv"
98
97
  Puppet.settings[:server_list] = ['server_list_0', 'server_list_1']
99
- Puppet::FileBucket::Dipper.expects(:new).with(:Server => nil, :Port => nil).returns @bucket
98
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Server => nil, :Port => nil).and_return(@bucket)
100
99
 
101
100
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :path => false
102
101
  bucket.bucket
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:group) do
@@ -50,20 +49,20 @@ describe Puppet::Type.type(:group) do
50
49
 
51
50
  it "should call 'create' to create the group" do
52
51
  group = @class.new(:name => "foo", :ensure => :present)
53
- group.provider.expects(:create)
52
+ expect(group.provider).to receive(:create)
54
53
  group.parameter(:ensure).sync
55
54
  end
56
55
 
57
56
  it "should call 'delete' to remove the group" do
58
57
  group = @class.new(:name => "foo", :ensure => :absent)
59
- group.provider.expects(:delete)
58
+ expect(group.provider).to receive(:delete)
60
59
  group.parameter(:ensure).sync
61
60
  end
62
61
 
63
62
  it "delegates the existence check to its provider" do
64
63
  provider = @class.provide(:testing) {}
65
64
  provider_instance = provider.new
66
- provider_instance.expects(:exists?).returns true
65
+ expect(provider_instance).to receive(:exists?).and_return(true)
67
66
 
68
67
  type = @class.new(:name => "group", :provider => provider_instance)
69
68
 
@@ -71,7 +70,6 @@ describe Puppet::Type.type(:group) do
71
70
  end
72
71
 
73
72
  describe "should delegate :members implementation to the provider:" do
74
-
75
73
  let (:provider) do
76
74
  @class.provide(:testing) do
77
75
  has_features :manages_members
@@ -85,13 +83,13 @@ describe Puppet::Type.type(:group) do
85
83
  let (:type) { @class.new(:name => "group", :provider => provider_instance, :members => ['user1']) }
86
84
 
87
85
  it "insync? calls members_insync?" do
88
- provider_instance.expects(:members_insync?).with(['user1'], ['user1']).returns true
86
+ expect(provider_instance).to receive(:members_insync?).with(['user1'], ['user1']).and_return(true)
89
87
  expect(type.property(:members).insync?(['user1'])).to be_truthy
90
88
  end
91
89
 
92
90
  it "is_to_s and should_to_s call members_to_s" do
93
- provider_instance.expects(:members_to_s).with(['user1', 'user2']).returns "user1 (), user2 ()"
94
- provider_instance.expects(:members_to_s).with(['user1']).returns "user1 ()"
91
+ expect(provider_instance).to receive(:members_to_s).with(['user1', 'user2']).and_return("user1 (), user2 ()")
92
+ expect(provider_instance).to receive(:members_to_s).with(['user1']).and_return("user1 ()")
95
93
 
96
94
  expect(type.property(:members).is_to_s('user1')).to eq('user1 ()')
97
95
  expect(type.property(:members).should_to_s('user1,user2')).to eq('user1 (), user2 ()')
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/type'
@@ -7,7 +6,7 @@ describe Puppet::Type.type(:file).attrclass(:noop) do
7
6
  include PuppetSpec::Files
8
7
 
9
8
  before do
10
- Puppet.settings.stubs(:use)
9
+ allow(Puppet.settings).to receive(:use)
11
10
  @file = Puppet::Type.newfile :path => make_absolute("/what/ever")
12
11
  end
13
12
 
@@ -1,10 +1,8 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:package) do
5
-
6
4
  before do
7
- Puppet::Util::Storage.stubs(:store)
5
+ allow(Puppet::Util::Storage).to receive(:store)
8
6
  end
9
7
 
10
8
  it "should have a :package_settings feature that requires :package_settings_insync?, :package_settings and :package_settings=" do
@@ -19,66 +17,81 @@ describe Puppet::Type.type(:package) do
19
17
 
20
18
  context "when validating attribute values" do
21
19
  let(:provider) do
22
- stub( 'provider',
23
- :class => described_class.defaultprovider,
24
- :clear => nil,
25
- :validate_source => false )
20
+ double('provider',
21
+ :class => described_class.defaultprovider,
22
+ :clear => nil,
23
+ :validate_source => false)
26
24
  end
25
+
27
26
  before do
28
- provider.class.stubs(:supports_parameter?).returns(true)
29
- described_class.defaultprovider.stubs(:new).returns(provider)
27
+ allow(provider.class).to receive(:supports_parameter?).and_return(true)
28
+ allow(described_class.defaultprovider).to receive(:new).and_return(provider)
30
29
  end
30
+
31
31
  describe 'package_settings' do
32
32
  context "with a minimalistic provider supporting package_settings" do
33
33
  context "and {:package_settings => :settings}" do
34
34
  let(:resource) do
35
35
  described_class.new :name => 'foo', :package_settings => :settings
36
36
  end
37
+
37
38
  it { expect { resource }.to_not raise_error }
39
+
38
40
  it "should set package_settings to :settings" do
39
41
  expect(resource.value(:package_settings)).to be :settings
40
42
  end
41
43
  end
42
44
  end
45
+
43
46
  context "with a provider that supports validation of the package_settings" do
44
47
  context "and {:package_settings => :valid_value}" do
45
48
  before do
46
- provider.expects(:package_settings_validate).once.with(:valid_value).returns(true)
49
+ expect(provider).to receive(:package_settings_validate).once.with(:valid_value).and_return(true)
47
50
  end
51
+
48
52
  let(:resource) do
49
53
  described_class.new :name => 'foo', :package_settings => :valid_value
50
54
  end
55
+
51
56
  it { expect { resource }.to_not raise_error }
57
+
52
58
  it "should set package_settings to :valid_value" do
53
59
  expect(resource.value(:package_settings)).to eq(:valid_value)
54
60
  end
55
61
  end
62
+
56
63
  context "and {:package_settings => :invalid_value}" do
57
64
  before do
58
65
  msg = "package_settings must be a Hash, not Symbol"
59
- provider.expects(:package_settings_validate).once.
60
- with(:invalid_value).raises(ArgumentError, msg)
66
+ expect(provider).to receive(:package_settings_validate).once.
67
+ with(:invalid_value).and_raise(ArgumentError, msg)
61
68
  end
69
+
62
70
  let(:resource) do
63
71
  described_class.new :name => 'foo', :package_settings => :invalid_value
64
72
  end
73
+
65
74
  it do
66
75
  expect { resource }.to raise_error Puppet::Error,
67
76
  /package_settings must be a Hash, not Symbol/
68
77
  end
69
78
  end
70
79
  end
80
+
71
81
  context "with a provider that supports munging of the package_settings" do
72
82
  context "and {:package_settings => 'A'}" do
73
83
  before do
74
- provider.expects(:package_settings_munge).once.with('A').returns(:a)
84
+ expect(provider).to receive(:package_settings_munge).once.with('A').and_return(:a)
75
85
  end
86
+
76
87
  let(:resource) do
77
88
  described_class.new :name => 'foo', :package_settings => 'A'
78
89
  end
90
+
79
91
  it do
80
92
  expect { resource }.to_not raise_error
81
93
  end
94
+
82
95
  it "should set package_settings to :a" do
83
96
  expect(resource.value(:package_settings)).to be :a
84
97
  end
@@ -86,47 +99,55 @@ describe Puppet::Type.type(:package) do
86
99
  end
87
100
  end
88
101
  end
102
+
89
103
  describe "package_settings property" do
90
104
  let(:provider) do
91
- stub( 'provider',
92
- :class => described_class.defaultprovider,
93
- :clear => nil,
94
- :validate_source => false )
105
+ double('provider',
106
+ :class => described_class.defaultprovider,
107
+ :clear => nil,
108
+ :validate_source => false)
95
109
  end
110
+
96
111
  before do
97
- provider.class.stubs(:supports_parameter?).returns(true)
98
- described_class.defaultprovider.stubs(:new).returns(provider)
112
+ allow(provider.class).to receive(:supports_parameter?).and_return(true)
113
+ allow(described_class.defaultprovider).to receive(:new).and_return(provider)
99
114
  end
115
+
100
116
  context "with {package_settings => :should}" do
101
117
  let(:resource) do
102
118
  described_class.new :name => 'foo', :package_settings => :should
103
119
  end
120
+
104
121
  describe "#insync?(:is)" do
105
122
  it "returns the result of provider.package_settings_insync?(:should,:is)" do
106
- resource.provider.expects(:package_settings_insync?).once.with(:should,:is).returns :ok1
123
+ expect(resource.provider).to receive(:package_settings_insync?).once.with(:should,:is).and_return(:ok1)
107
124
  expect(resource.property(:package_settings).insync?(:is)).to be :ok1
108
125
  end
109
126
  end
127
+
110
128
  describe "#should_to_s(:newvalue)" do
111
129
  it "returns the result of provider.package_settings_should_to_s(:should,:newvalue)" do
112
- resource.provider.expects(:package_settings_should_to_s).once.with(:should,:newvalue).returns :ok2
130
+ expect(resource.provider).to receive(:package_settings_should_to_s).once.with(:should,:newvalue).and_return(:ok2)
113
131
  expect(resource.property(:package_settings).should_to_s(:newvalue)).to be :ok2
114
132
  end
115
133
  end
134
+
116
135
  describe "#is_to_s(:currentvalue)" do
117
136
  it "returns the result of provider.package_settings_is_to_s(:should,:currentvalue)" do
118
- resource.provider.expects(:package_settings_is_to_s).once.with(:should,:currentvalue).returns :ok3
137
+ expect(resource.provider).to receive(:package_settings_is_to_s).once.with(:should,:currentvalue).and_return(:ok3)
119
138
  expect(resource.property(:package_settings).is_to_s(:currentvalue)).to be :ok3
120
139
  end
121
140
  end
122
141
  end
142
+
123
143
  context "with any non-nil package_settings" do
124
144
  describe "#change_to_s(:currentvalue,:newvalue)" do
125
145
  let(:resource) do
126
146
  described_class.new :name => 'foo', :package_settings => {}
127
147
  end
148
+
128
149
  it "returns the result of provider.package_settings_change_to_s(:currentvalue,:newvalue)" do
129
- resource.provider.expects(:package_settings_change_to_s).once.with(:currentvalue,:newvalue).returns :ok4
150
+ expect(resource.provider).to receive(:package_settings_change_to_s).once.with(:currentvalue,:newvalue).and_return(:ok4)
130
151
  expect(resource.property(:package_settings).change_to_s(:currentvalue,:newvalue)).to be :ok4
131
152
  end
132
153
  end
@@ -1,10 +1,9 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:package) do
5
4
  before do
6
- Process.stubs(:euid).returns 0
7
- Puppet::Util::Storage.stubs(:store)
5
+ allow(Process).to receive(:euid).and_return(0)
6
+ allow(Puppet::Util::Storage).to receive(:store)
8
7
  end
9
8
 
10
9
  it "should have a :reinstallable feature that requires the :reinstall method" do
@@ -58,13 +57,13 @@ describe Puppet::Type.type(:package) do
58
57
 
59
58
  describe "when validating attribute values" do
60
59
  before :each do
61
- @provider = stub(
60
+ @provider = double(
62
61
  'provider',
63
62
  :class => Puppet::Type.type(:package).defaultprovider,
64
63
  :clear => nil,
65
64
  :validate_source => nil
66
65
  )
67
- Puppet::Type.type(:package).defaultprovider.stubs(:new).returns(@provider)
66
+ allow(Puppet::Type.type(:package).defaultprovider).to receive(:new).and_return(@provider)
68
67
  end
69
68
 
70
69
  after :each do
@@ -85,32 +84,32 @@ describe Puppet::Type.type(:package) do
85
84
  end
86
85
 
87
86
  it "should support :purged as a value to :ensure if the provider has the :purgeable feature" do
88
- @provider.expects(:satisfies?).with([:purgeable]).returns(true)
87
+ expect(@provider).to receive(:satisfies?).with([:purgeable]).and_return(true)
89
88
  Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged)
90
89
  end
91
90
 
92
91
  it "should not support :purged as a value to :ensure if the provider does not have the :purgeable feature" do
93
- @provider.expects(:satisfies?).with([:purgeable]).returns(false)
92
+ expect(@provider).to receive(:satisfies?).with([:purgeable]).and_return(false)
94
93
  expect { Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged) }.to raise_error(Puppet::Error)
95
94
  end
96
95
 
97
96
  it "should support :latest as a value to :ensure if the provider has the :upgradeable feature" do
98
- @provider.expects(:satisfies?).with([:upgradeable]).returns(true)
97
+ expect(@provider).to receive(:satisfies?).with([:upgradeable]).and_return(true)
99
98
  Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest)
100
99
  end
101
100
 
102
101
  it "should not support :latest as a value to :ensure if the provider does not have the :upgradeable feature" do
103
- @provider.expects(:satisfies?).with([:upgradeable]).returns(false)
102
+ expect(@provider).to receive(:satisfies?).with([:upgradeable]).and_return(false)
104
103
  expect { Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest) }.to raise_error(Puppet::Error)
105
104
  end
106
105
 
107
106
  it "should support version numbers as a value to :ensure if the provider has the :versionable feature" do
108
- @provider.expects(:satisfies?).with([:versionable]).returns(true)
107
+ expect(@provider).to receive(:satisfies?).with([:versionable]).and_return(true)
109
108
  Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0")
110
109
  end
111
110
 
112
111
  it "should not support version numbers as a value to :ensure if the provider does not have the :versionable feature" do
113
- @provider.expects(:satisfies?).with([:versionable]).returns(false)
112
+ expect(@provider).to receive(:satisfies?).with([:versionable]).and_return(false)
114
113
  expect { Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0") }.to raise_error(Puppet::Error)
115
114
  end
116
115
 
@@ -127,13 +126,13 @@ describe Puppet::Type.type(:package) do
127
126
 
128
127
  module PackageEvaluationTesting
129
128
  def setprops(properties)
130
- @provider.stubs(:properties).returns(properties)
129
+ allow(@provider).to receive(:properties).and_return(properties)
131
130
  end
132
131
  end
133
132
 
134
133
  describe Puppet::Type.type(:package) do
135
134
  before :each do
136
- @provider = stub(
135
+ @provider = double(
137
136
  'provider',
138
137
  :class => Puppet::Type.type(:package).defaultprovider,
139
138
  :clear => nil,
@@ -141,8 +140,8 @@ describe Puppet::Type.type(:package) do
141
140
  :name => :mock,
142
141
  :validate_source => nil
143
142
  )
144
- Puppet::Type.type(:package).defaultprovider.stubs(:new).returns(@provider)
145
- Puppet::Type.type(:package).defaultprovider.stubs(:instances).returns([])
143
+ allow(Puppet::Type.type(:package).defaultprovider).to receive(:new).and_return(@provider)
144
+ allow(Puppet::Type.type(:package).defaultprovider).to receive(:instances).and_return([])
146
145
  @package = Puppet::Type.type(:package).new(:name => "yay")
147
146
 
148
147
  @catalog = Puppet::Resource::Catalog.new
@@ -155,14 +154,14 @@ describe Puppet::Type.type(:package) do
155
154
  before { @package[:ensure] = :purged }
156
155
 
157
156
  it "should do nothing if it is :purged" do
158
- @provider.expects(:properties).returns(:ensure => :purged).at_least_once
157
+ expect(@provider).to receive(:properties).and_return(:ensure => :purged).at_least(:once)
159
158
  @catalog.apply
160
159
  end
161
160
 
162
161
  [:absent, :installed, :present, :latest].each do |state|
163
162
  it "should purge if it is #{state.to_s}" do
164
- @provider.stubs(:properties).returns(:ensure => state)
165
- @provider.expects(:purge)
163
+ allow(@provider).to receive(:properties).and_return(:ensure => state)
164
+ expect(@provider).to receive(:purge)
166
165
  @catalog.apply
167
166
  end
168
167
  end
@@ -175,15 +174,15 @@ describe Puppet::Type.type(:package) do
175
174
 
176
175
  [:purged, :absent].each do |state|
177
176
  it "should do nothing if it is #{state.to_s}" do
178
- @provider.expects(:properties).returns(:ensure => state).at_least_once
177
+ expect(@provider).to receive(:properties).and_return(:ensure => state).at_least(:once)
179
178
  @catalog.apply
180
179
  end
181
180
  end
182
181
 
183
182
  [:installed, :present, :latest].each do |state|
184
183
  it "should uninstall if it is #{state.to_s}" do
185
- @provider.stubs(:properties).returns(:ensure => state)
186
- @provider.expects(:uninstall)
184
+ allow(@provider).to receive(:properties).and_return(:ensure => state)
185
+ expect(@provider).to receive(:uninstall)
187
186
  @catalog.apply
188
187
  end
189
188
  end
@@ -196,15 +195,15 @@ describe Puppet::Type.type(:package) do
196
195
 
197
196
  [:present, :latest, "1.0"].each do |state|
198
197
  it "should do nothing if it is #{state.to_s}" do
199
- @provider.expects(:properties).returns(:ensure => state).at_least_once
198
+ expect(@provider).to receive(:properties).and_return(:ensure => state).at_least(:once)
200
199
  @catalog.apply
201
200
  end
202
201
  end
203
202
 
204
203
  [:purged, :absent].each do |state|
205
204
  it "should install if it is #{state.to_s}" do
206
- @provider.stubs(:properties).returns(:ensure => state)
207
- @provider.expects(:install)
205
+ allow(@provider).to receive(:properties).and_return(:ensure => state)
206
+ expect(@provider).to receive(:install)
208
207
  @catalog.apply
209
208
  end
210
209
  end
@@ -217,30 +216,30 @@ describe Puppet::Type.type(:package) do
217
216
 
218
217
  [:purged, :absent].each do |state|
219
218
  it "should upgrade if it is #{state.to_s}" do
220
- @provider.stubs(:properties).returns(:ensure => state)
221
- @provider.expects(:update)
219
+ allow(@provider).to receive(:properties).and_return(:ensure => state)
220
+ expect(@provider).to receive(:update)
222
221
  @catalog.apply
223
222
  end
224
223
  end
225
224
 
226
225
  it "should upgrade if the current version is not equal to the latest version" do
227
- @provider.stubs(:properties).returns(:ensure => "1.0")
228
- @provider.stubs(:latest).returns("2.0")
229
- @provider.expects(:update)
226
+ allow(@provider).to receive(:properties).and_return(:ensure => "1.0")
227
+ allow(@provider).to receive(:latest).and_return("2.0")
228
+ expect(@provider).to receive(:update)
230
229
  @catalog.apply
231
230
  end
232
231
 
233
232
  it "should do nothing if it is equal to the latest version" do
234
- @provider.stubs(:properties).returns(:ensure => "1.0")
235
- @provider.stubs(:latest).returns("1.0")
236
- @provider.expects(:update).never
233
+ allow(@provider).to receive(:properties).and_return(:ensure => "1.0")
234
+ allow(@provider).to receive(:latest).and_return("1.0")
235
+ expect(@provider).not_to receive(:update)
237
236
  @catalog.apply
238
237
  end
239
238
 
240
239
  it "should do nothing if the provider returns :present as the latest version" do
241
- @provider.stubs(:properties).returns(:ensure => :present)
242
- @provider.stubs(:latest).returns("1.0")
243
- @provider.expects(:update).never
240
+ allow(@provider).to receive(:properties).and_return(:ensure => :present)
241
+ allow(@provider).to receive(:latest).and_return("1.0")
242
+ expect(@provider).not_to receive(:update)
244
243
  @catalog.apply
245
244
  end
246
245
  end
@@ -252,24 +251,24 @@ describe Puppet::Type.type(:package) do
252
251
 
253
252
  [:purged, :absent].each do |state|
254
253
  it "should install if it is #{state.to_s}" do
255
- @provider.stubs(:properties).returns(:ensure => state)
254
+ allow(@provider).to receive(:properties).and_return(:ensure => state)
256
255
  expect(@package.property(:ensure).insync?(state)).to be_falsey
257
- @provider.expects(:install)
256
+ expect(@provider).to receive(:install)
258
257
  @catalog.apply
259
258
  end
260
259
  end
261
260
 
262
261
  it "should do nothing if the current version is equal to the desired version" do
263
- @provider.stubs(:properties).returns(:ensure => "1.0")
262
+ allow(@provider).to receive(:properties).and_return(:ensure => "1.0")
264
263
  expect(@package.property(:ensure).insync?('1.0')).to be_truthy
265
- @provider.expects(:install).never
264
+ expect(@provider).not_to receive(:install)
266
265
  @catalog.apply
267
266
  end
268
267
 
269
268
  it "should install if the current version is not equal to the specified version" do
270
- @provider.stubs(:properties).returns(:ensure => "2.0")
269
+ allow(@provider).to receive(:properties).and_return(:ensure => "2.0")
271
270
  expect(@package.property(:ensure).insync?('2.0')).to be_falsey
272
- @provider.expects(:install)
271
+ expect(@provider).to receive(:install)
273
272
  @catalog.apply
274
273
  end
275
274
 
@@ -277,29 +276,29 @@ describe Puppet::Type.type(:package) do
277
276
  let(:installed_versions) { ["1.0", "2.0", "3.0"] }
278
277
 
279
278
  before (:each) do
280
- @provider.stubs(:properties).returns(:ensure => installed_versions)
279
+ allow(@provider).to receive(:properties).and_return(:ensure => installed_versions)
281
280
  end
282
281
 
283
282
  it "should install if value not in the array" do
284
283
  @package[:ensure] = "1.5"
285
284
  expect(@package.property(:ensure).insync?(installed_versions)).to be_falsey
286
- @provider.expects(:install)
285
+ expect(@provider).to receive(:install)
287
286
  @catalog.apply
288
287
  end
289
288
 
290
289
  it "should not install if value is in the array" do
291
290
  @package[:ensure] = "2.0"
292
291
  expect(@package.property(:ensure).insync?(installed_versions)).to be_truthy
293
- @provider.expects(:install).never
292
+ expect(@provider).not_to receive(:install)
294
293
  @catalog.apply
295
294
  end
296
295
 
297
296
  describe "when ensure is set to 'latest'" do
298
297
  it "should not install if the value is in the array" do
299
- @provider.expects(:latest).returns("3.0")
298
+ expect(@provider).to receive(:latest).and_return("3.0")
300
299
  @package[:ensure] = "latest"
301
300
  expect(@package.property(:ensure).insync?(installed_versions)).to be_truthy
302
- @provider.expects(:install).never
301
+ expect(@provider).not_to receive(:install)
303
302
  @catalog.apply
304
303
  end
305
304
  end
@@ -328,16 +327,16 @@ describe Puppet::Type.type(:package) do
328
327
  it "should reinstall if it should be #{state.to_s} and reinstall_on_refresh is true" do
329
328
  @package[:ensure] = state
330
329
  @package[:reinstall_on_refresh] = :true
331
- @provider.stubs(:reinstallable?).returns(true)
332
- @provider.expects(:reinstall).once
330
+ allow(@provider).to receive(:reinstallable?).and_return(true)
331
+ expect(@provider).to receive(:reinstall).once
333
332
  @package.refresh
334
333
  end
335
334
 
336
335
  it "should reinstall if it should be #{state.to_s} and reinstall_on_refresh is false" do
337
336
  @package[:ensure] = state
338
337
  @package[:reinstall_on_refresh] = :false
339
- @provider.stubs(:reinstallable?).returns(true)
340
- @provider.expects(:reinstall).never
338
+ allow(@provider).to receive(:reinstallable?).and_return(true)
339
+ expect(@provider).not_to receive(:reinstall)
341
340
  @package.refresh
342
341
  end
343
342
  end
@@ -345,15 +344,15 @@ describe Puppet::Type.type(:package) do
345
344
  [:purged, :absent, :held].each do |state|
346
345
  it "should not reinstall if it should be #{state.to_s} and reinstall_on_refresh is true" do
347
346
  @package[:ensure] = state
348
- @provider.stubs(:reinstallable?).returns(true)
349
- @provider.expects(:reinstall).never
347
+ allow(@provider).to receive(:reinstallable?).and_return(true)
348
+ expect(@provider).not_to receive(:reinstall)
350
349
  @package.refresh
351
350
  end
352
351
 
353
352
  it "should not reinstall if it should be #{state.to_s} and reinstall_on_refresh is false" do
354
353
  @package[:ensure] = state
355
- @provider.stubs(:reinstallable?).returns(true)
356
- @provider.expects(:reinstall).never
354
+ allow(@provider).to receive(:reinstallable?).and_return(true)
355
+ expect(@provider).not_to receive(:reinstall)
357
356
  @package.refresh
358
357
  end
359
358
  end
@@ -363,9 +362,9 @@ describe Puppet::Type.type(:package) do
363
362
  it "should select dnf over yum for dnf supported fedora versions" do
364
363
  dnf = Puppet::Type.type(:package).provider(:dnf)
365
364
  yum = Puppet::Type.type(:package).provider(:yum)
366
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
367
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
368
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("22")
365
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
366
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
367
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("22")
369
368
 
370
369
  expect(dnf.specificity).to be > yum.specificity
371
370
  end