puppet 5.0.0 → 6.0.0

data/spec/unit/provider/service/gentoo_spec.rb

@@ -2,16 +2,17 @@
 
 require 'spec_helper'
 
-describe Puppet::Type.type(:service).provider(:gentoo) do
+describe 'Puppet::Type::Service::Provider::Gentoo', unless: Puppet::Util::Platform.jruby? do
+  let(:provider_class) { Puppet::Type.type(:service).provider(:gentoo) }
 
-  if Puppet.features.microsoft_windows?
+  if Puppet::Util::Platform.windows?
     # Get a pid for $CHILD_STATUS to latch on to
     command = "cmd.exe /c \"exit 0\""
     Puppet::Util::Execution.execute(command, {:failonfail => false})
   end
 
   before :each do
-    Puppet::Type.type(:service).stubs(:defaultprovider).returns described_class
+    Puppet::Type.type(:service).stubs(:defaultprovider).returns provider_class
     FileTest.stubs(:file?).with('/sbin/rc-update').returns true
     FileTest.stubs(:executable?).with('/sbin/rc-update').returns true
     Facter.stubs(:value).with(:operatingsystem).returns 'Gentoo'
@@ -52,7 +53,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
   describe ".instances" do
 
     it "should have an instances method" do
-      expect(described_class).to respond_to(:instances)
+      expect(provider_class).to respond_to(:instances)
     end
 
     it "should get a list of services from /etc/init.d but exclude helper scripts" do
@@ -66,7 +67,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
       end
 
       Puppet::FileSystem.stubs(:symlink?).returns false # stub('file', :symlink? => false)
-      expect(described_class.instances.map(&:name)).to eq([
+      expect(provider_class.instances.map(&:name)).to eq([
         'alsasound',
         'bootmisc',
         'hwclock',
@@ -81,12 +82,12 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
   describe "#start" do
     it "should use the supplied start command if specified" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :start => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :start => '/bin/foo'))
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.start
     end
     it "should start the service with <initscript> start otherwise" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:execute).with(['/etc/init.d/sshd',:start], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.expects(:search).with('sshd').returns('/etc/init.d/sshd')
       provider.start
@@ -95,12 +96,12 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
   describe "#stop" do
     it "should use the supplied stop command if specified" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :stop => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :stop => '/bin/foo'))
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.stop
     end
     it "should stop the service with <initscript> stop otherwise" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:execute).with(['/etc/init.d/sshd',:stop], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.expects(:search).with('sshd').returns('/etc/init.d/sshd')
       provider.stop
@@ -110,32 +111,32 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
   describe "#enabled?" do
 
     before :each do
-      described_class.any_instance.stubs(:update).with(:show).returns File.read(my_fixture('rc_update_show'))
+      provider_class.any_instance.stubs(:update).with(:show).returns File.read(my_fixture('rc_update_show'))
     end
 
     it "should run rc-update show to get a list of enabled services" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:update).with(:show).returns "\n"
       provider.enabled?
     end
 
     ['hostname', 'net.lo', 'procfs'].each do |service|
       it "should consider service #{service} in runlevel boot as enabled" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => service))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => service))
         expect(provider.enabled?).to eq(:true)
       end
     end
 
     ['alsasound', 'xdm', 'netmount'].each do |service|
       it "should consider service #{service} in runlevel default as enabled" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => service))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => service))
         expect(provider.enabled?).to eq(:true)
       end
     end
 
     ['rsyncd', 'lighttpd', 'mysql'].each do |service|
       it "should consider unused service #{service} as disabled" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => service))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => service))
         expect(provider.enabled?).to eq(:false)
       end
     end
@@ -144,7 +145,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
   describe "#enable" do
     it "should run rc-update add to enable a service" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:update).with(:add, 'sshd', :default)
       provider.enable
     end
@@ -152,7 +153,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
   describe "#disable" do
     it "should run rc-update del to disable a service" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:update).with(:del, 'sshd', :default)
       provider.disable
     end
@@ -162,7 +163,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
     describe "when a special status command is specified" do
       it "should use the status command from the resource" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true).never
         provider.expects(:execute).with(['/bin/foo'], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
         $CHILD_STATUS.stubs(:exitstatus).returns 0
@@ -170,7 +171,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
       end
 
       it "should return :stopped when the status command returns with a non-zero exitcode" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true).never
         provider.expects(:execute).with(['/bin/foo'], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
         $CHILD_STATUS.stubs(:exitstatus).returns 3
@@ -178,7 +179,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
       end
 
       it "should return :running when the status command returns with a zero exitcode" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true).never
         provider.expects(:execute).with(['/bin/foo'], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
         $CHILD_STATUS.stubs(:exitstatus).returns 0
@@ -188,14 +189,14 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
     describe "when hasstatus is false" do
       it "should return running if a pid can be found" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => false))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => false))
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true).never
         provider.expects(:getpid).returns 1000
         expect(provider.status).to eq(:running)
       end
 
       it "should return stopped if no pid can be found" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => false))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => false))
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true).never
         provider.expects(:getpid).returns nil
         expect(provider.status).to eq(:stopped)
@@ -204,7 +205,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
     describe "when hasstatus is true" do
       it "should return running if <initscript> status exits with a zero exitcode" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => true))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => true))
         provider.expects(:search).with('sshd').returns('/etc/init.d/sshd')
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
         $CHILD_STATUS.stubs(:exitstatus).returns 0
@@ -212,7 +213,7 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
       end
 
       it "should return stopped if <initscript> status exits with a non-zero exitcode" do
-        provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => true))
+        provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasstatus => true))
         provider.expects(:search).with('sshd').returns('/etc/init.d/sshd')
         provider.expects(:execute).with(['/etc/init.d/sshd',:status], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
         $CHILD_STATUS.stubs(:exitstatus).returns 3
@@ -223,21 +224,21 @@ describe Puppet::Type.type(:service).provider(:gentoo) do
 
   describe "#restart" do
     it "should use the supplied restart command if specified" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :restart => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :restart => '/bin/foo'))
       provider.expects(:execute).with(['/etc/init.d/sshd',:restart], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.restart
     end
 
     it "should restart the service with <initscript> restart if hasrestart is true" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => true))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => true))
       provider.expects(:search).with('sshd').returns('/etc/init.d/sshd')
       provider.expects(:execute).with(['/etc/init.d/sshd',:restart], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.restart
     end
 
     it "should restart the service with <initscript> stop/start if hasrestart is false" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => false))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => false))
       provider.expects(:search).with('sshd').returns('/etc/init.d/sshd')
       provider.expects(:execute).with(['/etc/init.d/sshd',:restart], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/etc/init.d/sshd',:stop], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)

data/spec/unit/provider/service/init_spec.rb

@@ -5,16 +5,17 @@
 
 require 'spec_helper'
 
-describe Puppet::Type.type(:service).provider(:init) do
+describe 'Puppet::Type::Service::Provider::Init', unless: Puppet::Util::Platform.jruby? do
+  let(:provider_class) { Puppet::Type.type(:service).provider(:init) }
 
-  if Puppet.features.microsoft_windows?
+  if Puppet::Util::Platform.windows?
     # Get a pid for $CHILD_STATUS to latch on to
-    command = "cmd.exe /c \"exit 0\""
-    Puppet::Util::Execution.execute(command, {:failonfail => false})
+    cmd = "cmd.exe /c \"exit 0\""
+    Puppet::Util::Execution.execute(cmd, {:failonfail => false})
   end
 
   before do
-    Puppet::Type.type(:service).defaultprovider = described_class
+    Puppet::Type.type(:service).defaultprovider = provider_class
   end
 
   after do
@@ -44,7 +45,7 @@ describe Puppet::Type.type(:service).provider(:init) do
 
   describe "when getting all service instances" do
     before :each do
-      described_class.stubs(:defpath).returns('tmp')
+      provider_class.stubs(:defpath).returns('tmp')
 
       @services = ['one', 'two', 'three', 'four', 'umountfs']
       Dir.stubs(:entries).with('tmp').returns @services
@@ -53,35 +54,35 @@ describe Puppet::Type.type(:service).provider(:init) do
     end
 
     it "should return instances for all services" do
-      expect(described_class.instances.map(&:name)).to eq(@services)
+      expect(provider_class.instances.map(&:name)).to eq(@services)
     end
 
     it "should omit an array of services from exclude list" do
       exclude = ['two', 'four']
-      expect(described_class.get_services(described_class.defpath, exclude).map(&:name)).to eq(@services - exclude)
+      expect(provider_class.get_services(provider_class.defpath, exclude).map(&:name)).to eq(@services - exclude)
     end
 
     it "should omit a single service from the exclude list" do
       exclude = 'two'
-      expect(described_class.get_services(described_class.defpath, exclude).map(&:name)).to eq(@services - [exclude])
+      expect(provider_class.get_services(provider_class.defpath, exclude).map(&:name)).to eq(@services - [exclude])
     end
 
     it "should omit Yocto services on cisco-wrlinux" do
       Facter.stubs(:value).with(:osfamily).returns 'cisco-wrlinux'
       exclude = 'umountfs'
-      expect(described_class.get_services(described_class.defpath).map(&:name)).to eq(@services - [exclude])
+      expect(provider_class.get_services(provider_class.defpath).map(&:name)).to eq(@services - [exclude])
     end
 
     it "should not omit Yocto services on non cisco-wrlinux platforms" do
-      expect(described_class.get_services(described_class.defpath).map(&:name)).to eq(@services)
+      expect(provider_class.get_services(provider_class.defpath).map(&:name)).to eq(@services)
     end
 
     it "should use defpath" do
-      expect(described_class.instances).to be_all { |provider| provider.get(:path) == described_class.defpath }
+      expect(provider_class.instances).to be_all { |provider| provider.get(:path) == provider_class.defpath }
     end
 
     it "should set hasstatus to true for providers" do
-      expect(described_class.instances).to be_all { |provider| provider.get(:hasstatus) == true }
+      expect(provider_class.instances).to be_all { |provider| provider.get(:hasstatus) == true }
     end
 
     it "should discard upstart jobs", :if => Puppet.features.manages_symlinks? do
@@ -90,14 +91,14 @@ describe Puppet::Type.type(:service).provider(:init) do
       Puppet::FileSystem.expects(:symlink?).at_least_once.returns false
       Puppet::FileSystem.expects(:symlink?).with(Puppet::FileSystem.pathname(path)).returns(true)
       Puppet::FileSystem.expects(:readlink).with(Puppet::FileSystem.pathname(path)).returns("/lib/init/upstart-job")
-      expect(described_class.instances.map(&:name)).to eq(valid_services)
+      expect(provider_class.instances.map(&:name)).to eq(valid_services)
     end
 
     it "should discard non-initscript scripts" do
       valid_services = @services
       all_services = valid_services + excludes
       Dir.expects(:entries).with('tmp').returns all_services
-      expect(described_class.instances.map(&:name)).to match_array(valid_services)
+      expect(provider_class.instances.map(&:name)).to match_array(valid_services)
     end
   end
 
@@ -240,7 +241,7 @@ describe Puppet::Type.type(:service).provider(:init) do
     describe "when starting a service on Solaris" do
       it "should use ctrun" do
         Facter.stubs(:value).with(:osfamily).returns 'Solaris'
-        provider.expects(:execute).with('/usr/bin/ctrun -l none /service/path/myservice start', {:failonfail => true, :override_locale => false, :squelch => false, :combine => true}).returns("")
+        provider.expects(:execute).with('/usr/bin/ctrun -l child /service/path/myservice start', {:failonfail => true, :override_locale => false, :squelch => false, :combine => true}).returns("")
         $CHILD_STATUS.stubs(:exitstatus).returns(0)
         provider.start
       end

data/spec/unit/provider/service/launchd_spec.rb

@@ -3,7 +3,9 @@
 
 require 'spec_helper'
 
-describe Puppet::Type.type(:service).provider(:launchd) do
+describe 'Puppet::Type::Service::Provider::Launchd', unless: Puppet::Util::Platform.jruby? do
+  let(:provider_class) { Puppet::Type.type(:service).provider(:launchd) }
+
   let (:plistlib) { Puppet::Util::Plist }
   let (:joblabel) { "com.foo.food" }
   let (:provider) { subject.class }
@@ -12,7 +14,7 @@ describe Puppet::Type.type(:service).provider(:launchd) do
   let (:launchd_overrides_10_) { '/var/db/com.apple.xpc.launchd/disabled.plist' }
   subject { resource.provider }
 
-  if Puppet.features.microsoft_windows?
+  if Puppet::Util::Platform.windows?
     # Get a pid for $CHILD_STATUS to latch on to
     command = "cmd.exe /c \"exit 0\""
     Puppet::Util::Execution.execute(command, {:failonfail => false})
@@ -292,7 +294,8 @@ describe Puppet::Type.type(:service).provider(:launchd) do
         provider.expects(:launchd_paths).returns(['/Library/LaunchAgents'])
         provider.expects(:return_globbed_list_of_file_paths).with('/Library/LaunchAgents').returns([busted_plist_path])
         plistlib.expects(:read_plist_file).with(busted_plist_path).returns(plist_without_label)
-        Puppet.expects(:warning).with("The #{busted_plist_path} plist does not contain a 'label' key; Puppet is skipping it")
+        Puppet.expects(:debug).with("Reading launchd plist #{busted_plist_path}")
+        Puppet.expects(:debug).with("The #{busted_plist_path} plist does not contain a 'label' key; Puppet is skipping it")
         provider.make_label_to_path_map
       end
     end

data/spec/unit/provider/service/openbsd_spec.rb

@@ -4,11 +4,12 @@
 
 require 'spec_helper'
 
-provider_class = Puppet::Type.type(:service).provider(:openbsd)
+describe 'Puppet::Type::Service::Provider::Openbsd',
+    unless: Puppet::Util::Platform.windows? || Puppet::Util::Platform.jruby? do
+  let(:provider_class) { Puppet::Type.type(:service).provider(:openbsd) }
 
-describe provider_class, :unless => Puppet.features.microsoft_windows? do
   before :each do
-    Puppet::Type.type(:service).stubs(:defaultprovider).returns described_class
+    Puppet::Type.type(:service).stubs(:defaultprovider).returns provider_class
     Facter.stubs(:value).with(:operatingsystem).returns :openbsd
     Facter.stubs(:value).with(:osfamily).returns 'OpenBSD'
     FileTest.stubs(:file?).with('/usr/sbin/rcctl').returns true
@@ -17,12 +18,12 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#instances" do
     it "should have an instances method" do
-      expect(described_class).to respond_to :instances
+      expect(provider_class).to respond_to :instances
     end
 
     it "should list all available services" do
-      described_class.stubs(:execpipe).with(['/usr/sbin/rcctl', :getall]).yields File.read(my_fixture('rcctl_getall'))
-      expect(described_class.instances.map(&:name)).to eq([
+      provider_class.stubs(:execpipe).with(['/usr/sbin/rcctl', :getall]).yields File.read(my_fixture('rcctl_getall'))
+      expect(provider_class.instances.map(&:name)).to eq([
         'accounting', 'pf', 'postgresql', 'tftpd', 'wsmoused', 'xdm',
       ])
     end
@@ -30,13 +31,13 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#start" do
     it "should use the supplied start command if specified" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :start => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :start => '/bin/foo'))
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.start
     end
 
     it "should start the service otherwise" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:texecute).with(:start, ['/usr/sbin/rcctl', '-f', :start, 'sshd'], true)
       provider.start
     end
@@ -44,13 +45,13 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#stop" do
     it "should use the supplied stop command if specified" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :stop => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :stop => '/bin/foo'))
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.stop
     end
 
     it "should stop the service otherwise" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
       provider.expects(:texecute).with(:stop, ['/usr/sbin/rcctl', :stop, 'sshd'], true)
       provider.stop
     end
@@ -58,14 +59,14 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#status" do
     it "should use the status command from the resource" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
       provider.expects(:execute).with(['/usr/sbin/rcctl', :get, 'sshd', :status], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/bin/foo'], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
       provider.status
     end
 
     it "should return :stopped when status command returns with a non-zero exitcode" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
       provider.expects(:execute).with(['/usr/sbin/rcctl', :get, 'sshd', :status], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/bin/foo'], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
       $CHILD_STATUS.stubs(:exitstatus).returns 3
@@ -73,7 +74,7 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
     end
 
     it "should return :running when status command returns with a zero exitcode" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :status => '/bin/foo'))
       provider.expects(:execute).with(['/usr/sbin/rcctl', :get, 'sshd', :status], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/bin/foo'], :failonfail => false, :override_locale => false, :squelch => false, :combine => true)
       $CHILD_STATUS.stubs(:exitstatus).returns 0
@@ -83,20 +84,20 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#restart" do
     it "should use the supplied restart command if specified" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :restart => '/bin/foo'))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :restart => '/bin/foo'))
       provider.expects(:execute).with(['/usr/sbin/rcctl', '-f', :restart, 'sshd'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.restart
     end
 
     it "should restart the service with rcctl restart if hasrestart is true" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => true))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => true))
       provider.expects(:texecute).with(:restart, ['/usr/sbin/rcctl', '-f', :restart, 'sshd'], true)
       provider.restart
     end
 
     it "should restart the service with rcctl stop/start if hasrestart is false" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => false))
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :hasrestart => false))
       provider.expects(:texecute).with(:restart, ['/usr/sbin/rcctl', '-f', :restart, 'sshd'], true).never
       provider.expects(:texecute).with(:stop, ['/usr/sbin/rcctl', :stop, 'sshd'], true)
       provider.expects(:texecute).with(:start, ['/usr/sbin/rcctl', '-f', :start, 'sshd'], true)
@@ -106,15 +107,15 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#enabled?" do
     it "should return :true if the service is enabled" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:get, 'sshd', :status)
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:get, 'sshd', :status)
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'get', 'sshd', 'status'], :failonfail => false, :combine => false, :squelch => false).returns(stub(:exitstatus => 0))
       expect(provider.enabled?).to eq(:true)
     end
 
     it "should return :false if the service is disabled" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:get, 'sshd', :status).returns('NO')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:get, 'sshd', :status).returns('NO')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'get', 'sshd', 'status'], :failonfail => false, :combine => false, :squelch => false).returns(stub(:exitstatus => 1))
       expect(provider.enabled?).to eq(:false)
     end
@@ -122,16 +123,16 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#enable" do
     it "should run rcctl enable to enable the service" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:enable, 'sshd').returns('')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:enable, 'sshd').returns('')
       provider.expects(:rcctl).with(:enable, 'sshd')
       provider.enable
     end
 
     it "should run rcctl enable with flags if provided" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :flags => '-6'))
-      described_class.stubs(:rcctl).with(:enable, 'sshd').returns('')
-      described_class.stubs(:rcctl).with(:set, 'sshd', :flags, '-6').returns('')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :flags => '-6'))
+      provider_class.stubs(:rcctl).with(:enable, 'sshd').returns('')
+      provider_class.stubs(:rcctl).with(:set, 'sshd', :flags, '-6').returns('')
       provider.expects(:rcctl).with(:enable, 'sshd')
       provider.expects(:rcctl).with(:set, 'sshd', :flags, '-6')
       provider.enable
@@ -140,8 +141,8 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#disable" do
     it "should run rcctl disable to disable the service" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:disable, 'sshd').returns('')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:disable, 'sshd').returns('')
       provider.expects(:rcctl).with(:disable, 'sshd')
       provider.disable
     end
@@ -149,22 +150,22 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#running?" do
     it "should run rcctl check to check the service" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:check, 'sshd').returns('sshd(ok)')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:check, 'sshd').returns('sshd(ok)')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'check', 'sshd'], :failonfail => false, :combine => false, :squelch => false).returns('sshd(ok)')
       expect(provider.running?).to be_truthy
     end
 
     it "should return true if the service is running" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:check, 'sshd').returns('sshd(ok)')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:check, 'sshd').returns('sshd(ok)')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'check', 'sshd'], :failonfail => false, :combine => false, :squelch => false).returns('sshd(ok)')
       expect(provider.running?).to be_truthy
     end
 
     it "should return nil if the service is not running" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:check, 'sshd').returns('sshd(failed)')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:check, 'sshd').returns('sshd(failed)')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'check', 'sshd'], :failonfail => false, :combine => false, :squelch => false).returns('sshd(failed)')
       expect(provider.running?).to be_nil
     end
@@ -172,31 +173,31 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
 
   describe "#flags" do
     it "should return flags when set" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :flags => '-6'))
-      described_class.stubs(:rcctl).with('get', 'sshd', 'flags').returns('-6')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :flags => '-6'))
+      provider_class.stubs(:rcctl).with('get', 'sshd', 'flags').returns('-6')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'get', 'sshd', 'flags'], :failonfail => false, :combine => false, :squelch => false).returns('-6')
       provider.flags
     end
 
     it "should return empty flags" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with('get', 'sshd', 'flags').returns('')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with('get', 'sshd', 'flags').returns('')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'get', 'sshd', 'flags'], :failonfail => false, :combine => false, :squelch => false).returns('')
       provider.flags
     end
 
     it "should return flags for special services" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'pf'))
-      described_class.stubs(:rcctl).with('get', 'pf', 'flags').returns('YES')
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'pf'))
+      provider_class.stubs(:rcctl).with('get', 'pf', 'flags').returns('YES')
       provider.expects(:execute).with(['/usr/sbin/rcctl', 'get', 'pf', 'flags'], :failonfail => false, :combine => false, :squelch => false).returns('YES')
       provider.flags
     end
   end
 
   describe "#flags=" do
-    it "should run rcctl to set flags" do
-      provider = described_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
-      described_class.stubs(:rcctl).with(:set, 'sshd', :flags, '-4').returns('')
+    it "should run rcctl to set flags", :unless => Puppet::Util::Platform.windows? || RUBY_PLATFORM == 'java' do
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd'))
+      provider_class.stubs(:rcctl).with(:set, 'sshd', :flags, '-4').returns('')
       provider.expects(:rcctl).with(:set, 'sshd', :flags, '-4')
       provider.flags = '-4'
     end