puppet 2.6.18 → 2.7.1

data/spec/unit/type/interface_spec.rb

@@ -0,0 +1,98 @@
+#!/usr/bin/env rspec
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe Puppet::Type.type(:interface) do
+
+  it "should have a 'name' parameter'" do
+    Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1")[:name].should == "FastEthernet 0/1"
+  end
+
+  it "should have a 'device_url' parameter'" do
+    Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :device_url => :device)[:device_url].should == :device
+  end
+
+  it "should have an ensure property" do
+    Puppet::Type.type(:interface).attrtype(:ensure).should == :property
+  end
+
+  it "should be applied on device" do
+    Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1").should be_appliable_to_device
+  end
+
+  [:description, :speed, :duplex, :native_vlan, :encapsulation, :mode, :allowed_trunk_vlans, :etherchannel, :ipaddress].each do |p|
+    it "should have a #{p} property" do
+      Puppet::Type.type(:interface).attrtype(p).should == :property
+    end
+  end
+
+  describe "when validating attribute values" do
+    before do
+      @provider = stub 'provider', :class => Puppet::Type.type(:interface).defaultprovider, :clear => nil
+      Puppet::Type.type(:interface).defaultprovider.stubs(:new).returns(@provider)
+    end
+
+    it "should support :present as a value to :ensure" do
+      Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ensure => :present)
+    end
+
+    it "should support :shutdown as a value to :ensure" do
+      Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ensure => :shutdown)
+    end
+
+    it "should support :no_shutdown as a value to :ensure" do
+      Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ensure => :no_shutdown)
+    end
+
+    describe "especially speed" do
+      it "should allow a number" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :speed => "100")
+      end
+
+      it "should allow :auto" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :speed => :auto)
+      end
+    end
+
+    describe "especially duplex" do
+      it "should allow :half" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :duplex => :half)
+      end
+
+      it "should allow :full" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :duplex => :full)
+      end
+
+      it "should allow :auto" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :duplex => :auto)
+      end
+    end
+
+    describe "especially ipaddress" do
+      it "should allow ipv4 addresses" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => "192.168.0.1/24")
+      end
+
+      it "should allow arrays of ipv4 addresses" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => ["192.168.0.1/24", "192.168.1.0/24"])
+      end
+
+      it "should allow ipv6 addresses" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => "f0e9::/64")
+      end
+
+      it "should allow ipv6 options" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => "f0e9::/64 link-local")
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => "f0e9::/64 eui-64")
+      end
+
+      it "should allow a mix of ipv4 and ipv6" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => ["192.168.0.1/24", "f0e9::/64 link-local"])
+      end
+
+      it "should munge ip addresses to a computer format" do
+        Puppet::Type.type(:interface).new(:name => "FastEthernet 0/1", :ipaddress => "192.168.0.1/24")[:ipaddress].should == [[24, IPAddr.new('192.168.0.1'), nil]]
+      end
+    end
+  end
+end

data/spec/unit/type/macauthorization_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 macauth_type = Puppet::Type.type(:macauthorization)
 

data/spec/unit/type/maillist_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 maillist = Puppet::Type.type(:maillist)
 

data/spec/unit/type/mcx_spec.rb

@@ -1,26 +1,5 @@
-#!/usr/bin/env ruby
-#--
-# Copyright (C) 2008 Jeffrey J McCune.
-
-# This program and entire repository is free software; you can
-# redistribute it and/or modify it under the terms of the GNU
-# General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-
-# Author: Jeff McCune <mccune.jeff@gmail.com>
-
-# Most of this code copied from /spec/type/service.rb
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 require 'puppet/type/mcx'
 

data/spec/unit/type/mount_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 describe Puppet::Type.type(:mount) do
   it "should have a :refreshable feature that requires the :remount method" do
@@ -231,27 +230,51 @@ describe Puppet::Type.type(:mount)::Ensure do
 
  end
 
-  describe Puppet::Type.type(:mount), "when responding to events" do
+  describe Puppet::Type.type(:mount), "when responding to refresh" do
+    pending "2.6.x specifies slightly different behavior and the desired behavior needs to be clarified and revisited.  See ticket #4904" do
 
-    it "should remount if it is currently mounted" do
-      @provider.expects(:mounted?).returns(true)
-      @provider.expects(:remount)
+      it "should remount if it is supposed to be mounted" do
+        @mount[:ensure] = "mounted"
+        @provider.expects(:remount)
 
-      @mount.refresh
-    end
+        @mount.refresh
+      end
 
-    it "should not remount if it is not currently mounted" do
-      @provider.expects(:mounted?).returns(false)
-      @provider.expects(:remount).never
+      it "should not remount if it is supposed to be present" do
+        @mount[:ensure] = "present"
+        @provider.expects(:remount).never
 
-      @mount.refresh
-    end
+        @mount.refresh
+      end
+
+      it "should not remount if it is supposed to be absent" do
+        @mount[:ensure] = "absent"
+        @provider.expects(:remount).never
+
+        @mount.refresh
+      end
 
-    it "should not remount swap filesystems" do
-      @mount[:fstype] = "swap"
-      @provider.expects(:remount).never
+      it "should not remount if it is supposed to be defined" do
+        @mount[:ensure] = "defined"
+        @provider.expects(:remount).never
 
-      @mount.refresh
+        @mount.refresh
+      end
+
+      it "should not remount if it is supposed to be unmounted" do
+        @mount[:ensure] = "unmounted"
+        @provider.expects(:remount).never
+
+        @mount.refresh
+      end
+
+      it "should not remount swap filesystems" do
+        @mount[:ensure] = "mounted"
+        @mount[:fstype] = "swap"
+        @provider.expects(:remount).never
+
+        @mount.refresh
+      end
     end
   end
 end

data/spec/unit/type/nagios_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 require 'puppet/external/nagios'
 

data/spec/unit/type/noop_metaparam_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 require 'puppet/type'
 

data/spec/unit/type/package_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 describe Puppet::Type.type(:package) do
   before do

data/spec/unit/type/resources_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 resources = Puppet::Type.type(:resources)
 
@@ -52,7 +51,7 @@ describe resources do
           @resources.generate.collect { |r| r.ref }.should_not include(@host1.ref)
         end
 
-        it "should not include the skipped users" do
+        it "should not include the skipped users", :'fails_on_ruby_1.9.2' => true do
           res = Puppet::Type.type(:resources).new :name => :user, :purge => true
           res.catalog = Puppet::Resource::Catalog.new
 

data/spec/unit/type/schedule_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 module ScheduleTesting
 
@@ -37,6 +36,14 @@ describe Puppet::Type.type(:schedule) do
   describe Puppet::Type.type(:schedule) do
     include ScheduleTesting
 
+    it "should apply to device" do
+      @schedule.should be_appliable_to_device
+    end
+
+    it "should apply to host" do
+      @schedule.should be_appliable_to_host
+    end
+
     it "should default to :distance for period-matching" do
       @schedule[:periodmatch].should == :distance
     end
@@ -89,7 +96,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching hourly by distance" do
+  describe Puppet::Type.type(:schedule), "when matching hourly by distance", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -110,7 +117,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching daily by distance" do
+  describe Puppet::Type.type(:schedule), "when matching daily by distance", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -131,7 +138,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching weekly by distance" do
+  describe Puppet::Type.type(:schedule), "when matching weekly by distance", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -152,7 +159,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching monthly by distance" do
+  describe Puppet::Type.type(:schedule), "when matching monthly by distance", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -173,7 +180,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching hourly by number" do
+  describe Puppet::Type.type(:schedule), "when matching hourly by number", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -198,7 +205,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching daily by number" do
+  describe Puppet::Type.type(:schedule), "when matching daily by number", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -229,7 +236,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching weekly by number" do
+  describe Puppet::Type.type(:schedule), "when matching weekly by number", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -254,7 +261,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching monthly by number" do
+  describe Puppet::Type.type(:schedule), "when matching monthly by number", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do
@@ -279,7 +286,7 @@ describe Puppet::Type.type(:schedule) do
     end
   end
 
-  describe Puppet::Type.type(:schedule), "when matching with a repeat greater than one" do
+  describe Puppet::Type.type(:schedule), "when matching with a repeat greater than one", :'fails_on_ruby_1.9.2' => true do
     include ScheduleTesting
 
     before do

data/spec/unit/type/selboolean_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 describe Puppet::Type.type(:selboolean), "when validating attributes" do
   [:name, :persistent].each do |param|

data/spec/unit/type/selmodule_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 describe Puppet::Type.type(:selmodule), "when validating attributes" do
   [:name, :selmoduledir, :selmodulepath].each do |param|

data/spec/unit/type/service_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 describe Puppet::Type.type(:service) do
   it "should have an :enableable feature that requires the :enable, :disable, and :enabled? methods" do
@@ -66,6 +65,10 @@ describe Puppet::Type.type(:service), "when validating attribute values" do
     Puppet::Type.type(:service).new(:name => "yay", :hasstatus => :false)
   end
 
+  it "should specify :true as the default value of hasstatus" do
+    Puppet::Type.type(:service).new(:name => "yay")[:hasstatus].should == :true
+  end
+
   it "should support :true as a value to :hasrestart" do
     Puppet::Type.type(:service).new(:name => "yay", :hasrestart => :true)
   end

data/spec/unit/type/ssh_authorized_key_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 ssh_authorized_key = Puppet::Type.type(:ssh_authorized_key)
 

data/spec/unit/type/sshkey_spec.rb

@@ -0,0 +1,70 @@
+#!/usr/bin/env rspec
+require 'spec_helper'
+
+sshkey = Puppet::Type.type(:sshkey)
+
+describe sshkey do
+  before do
+    @class = sshkey
+  end
+
+  it "should have :name its namevar" do
+    @class.key_attributes.should == [:name]
+  end
+
+  describe "when validating attributes" do
+    [:name, :provider].each do |param|
+      it "should have a #{param} parameter" do
+        @class.attrtype(param).should == :param
+      end
+    end
+
+    [:host_aliases, :ensure, :key, :type].each do |property|
+      it "should have a #{property} property" do
+        @class.attrtype(property).should == :property
+      end
+    end
+  end
+
+  describe "when validating values" do
+
+    it "should support ssh-dss as a type value" do
+      proc { @class.new(:name => "foo", :type => "ssh-dss") }.should_not raise_error
+    end
+
+    it "should support ssh-rsa as a type value" do
+      proc { @class.new(:name => "whev", :type => "ssh-rsa") }.should_not raise_error
+    end
+
+    it "should alias :dsa to ssh-dss as a value for type" do
+      key = @class.new(:name => "whev", :type => :dsa)
+      key.should(:type).should == :'ssh-dss'
+    end
+
+    it "should alias :rsa to ssh-rsa as a value for type" do
+      key = @class.new(:name => "whev", :type => :rsa)
+      key.should(:type).should == :'ssh-rsa'
+    end
+
+    it "should not support values other than ssh-dss, ssh-rsa, dsa, rsa for type" do
+      proc { @class.new(:name => "whev", :type => :'ssh-dsa') }.should raise_error(Puppet::Error)
+    end
+
+    it "should accept one host_alias" do
+      proc { @class.new(:name => "foo", :host_aliases => 'foo.bar.tld') }.should_not raise_error
+    end
+
+    it "should accept multiple host_aliases as an array" do
+      proc { @class.new(:name => "foo", :host_aliases => ['foo.bar.tld','10.0.9.9']) }.should_not raise_error
+    end
+
+    it "should not accept spaces in any host_alias" do
+      proc { @class.new(:name => "foo", :host_aliases => ['foo.bar.tld','foo bar']) }.should raise_error(Puppet::Error)
+    end
+
+    it "should not accept aliases in the resourcename" do
+      proc { @class.new(:name => 'host,host.domain,ip') }.should raise_error(Puppet::Error)
+    end
+
+  end
+end