puppet 2.6.18 → 2.7.1

data/spec/unit/util/network_device/cisco/facts_spec.rb

@@ -0,0 +1,63 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../../spec_helper'
+
+require 'puppet/util/network_device'
+require 'puppet/util/network_device/cisco/facts'
+
+describe Puppet::Util::NetworkDevice::Cisco::Facts do
+  before(:each) do
+    @transport = stub_everything 'transport'
+    @facts = Puppet::Util::NetworkDevice::Cisco::Facts.new(@transport)
+  end
+
+  {
+    "cisco WS-C2924C-XL (PowerPC403GA) processor (revision 0x11) with 8192K/1024K bytes of memory." => {:hardwaremodel => "WS-C2924C-XL", :memorysize => "8192K", :processor => "PowerPC403GA", :hardwarerevision => "0x11" },
+    "Cisco 1841 (revision 5.0) with 355328K/37888K bytes of memory." => {:hardwaremodel=>"1841", :memorysize => "355328K", :hardwarerevision => "5.0" },
+    "Cisco 877 (MPC8272) processor (revision 0x200) with 118784K/12288K bytes of memory." => {:hardwaremodel=>"877", :memorysize => "118784K", :processor => "MPC8272", :hardwarerevision => "0x200" },
+    "cisco WS-C2960G-48TC-L (PowerPC405) processor (revision C0) with 61440K/4088K bytes of memory." => {:hardwaremodel=>"WS-C2960G-48TC-L", :memorysize => "61440K", :processor => "PowerPC405", :hardwarerevision => "C0" },
+    "cisco WS-C2950T-24 (RC32300) processor (revision R0) with 19959K bytes of memory." => {:hardwaremodel=>"WS-C2950T-24", :memorysize => "19959K", :processor => "RC32300", :hardwarerevision => "R0" }
+  }.each do |ver, expected|
+    it "should parse show ver output for hardware device facts" do
+      @transport.stubs(:command).with("sh ver").returns(<<eos)
+Switch>sh ver
+#{ver}
+Switch>
+eos
+      @facts.parse_show_ver.should == expected
+    end
+  end
+
+  {
+"Switch uptime is 1 year, 12 weeks, 6 days, 22 hours, 32 minutes" => { :hostname => "Switch", :uptime => "1 year, 12 weeks, 6 days, 22 hours, 32 minutes", :uptime_seconds => 39393120, :uptime_days => 455 },
+"c2950 uptime is 3 weeks, 1 day, 23 hours, 36 minutes" => { :hostname => "c2950", :uptime => "3 weeks, 1 day, 23 hours, 36 minutes", :uptime_days => 22, :uptime_seconds =>  1985760},
+"router uptime is 5 weeks, 1 day, 3 hours, 30 minutes" => { :hostname => "router", :uptime => "5 weeks, 1 day, 3 hours, 30 minutes", :uptime_days => 36, :uptime_seconds => 3123000 },
+"c2950 uptime is 1 minute" => { :hostname => "c2950", :uptime => "1 minute", :uptime_days => 0, :uptime_seconds => 60 }
+  }.each do |ver, expected|
+    it "should parse show ver output for device uptime facts" do
+      @transport.stubs(:command).with("sh ver").returns(<<eos)
+Switch>sh ver
+#{ver}
+Switch>
+eos
+      @facts.parse_show_ver.should == expected
+    end
+  end
+
+  {
+"IOS (tm) C2900XL Software (C2900XL-C3H2S-M), Version 12.0(5)WC10, RELEASE SOFTWARE (fc1)"=> { :operatingsystem => "IOS", :operatingsystemrelease => "12.0(5)WC10", :operatingsystemmajrelease => "12.0WC", :operatingsystemfeature => "C3H2S"},
+"IOS (tm) C2950 Software (C2950-I6K2L2Q4-M), Version 12.1(22)EA8a, RELEASE SOFTWARE (fc1)"=> { :operatingsystem => "IOS", :operatingsystemrelease => "12.1(22)EA8a", :operatingsystemmajrelease => "12.1EA", :operatingsystemfeature => "I6K2L2Q4"},
+"Cisco IOS Software, C2960 Software (C2960-LANBASEK9-M), Version 12.2(44)SE, RELEASE SOFTWARE (fc1)"=>{ :operatingsystem => "IOS", :operatingsystemrelease => "12.2(44)SE", :operatingsystemmajrelease => "12.2SE", :operatingsystemfeature => "LANBASEK9"},
+"Cisco IOS Software, C870 Software (C870-ADVIPSERVICESK9-M), Version 12.4(11)XJ4, RELEASE SOFTWARE (fc2)"=>{ :operatingsystem => "IOS", :operatingsystemrelease => "12.4(11)XJ4", :operatingsystemmajrelease => "12.4XJ", :operatingsystemfeature => "ADVIPSERVICESK9"},
+"Cisco IOS Software, 1841 Software (C1841-ADVSECURITYK9-M), Version 12.4(24)T4, RELEASE SOFTWARE (fc2)" =>{ :operatingsystem => "IOS", :operatingsystemrelease => "12.4(24)T4", :operatingsystemmajrelease => "12.4T", :operatingsystemfeature => "ADVSECURITYK9"},
+  }.each do |ver, expected|
+    it "should parse show ver output for device software version facts" do
+      @transport.stubs(:command).with("sh ver").returns(<<eos)
+Switch>sh ver
+#{ver}
+Switch>
+eos
+      @facts.parse_show_ver.should == expected
+    end
+  end
+end

data/spec/unit/util/network_device/cisco/interface_spec.rb

@@ -0,0 +1,89 @@
+#!/usr/bin/env rspec
+
+require File.dirname(__FILE__) + '/../../../../spec_helper'
+
+require 'puppet/util/network_device'
+require 'puppet/util/network_device/cisco/interface'
+
+describe Puppet::Util::NetworkDevice::Cisco::Interface do
+  before(:each) do
+    @transport = stub_everything 'transport'
+    @interface = Puppet::Util::NetworkDevice::Cisco::Interface.new("FastEthernet0/1",@transport)
+  end
+
+  it "should include IPCalc" do
+    @interface.class.include?(Puppet::Util::NetworkDevice::IPCalc)
+  end
+
+  describe "when updating the physical device" do
+    it "should enter global configuration mode" do
+      @transport.expects(:command).with("conf t")
+      @interface.update
+    end
+
+    it "should enter interface configuration mode" do
+      @transport.expects(:command).with("interface FastEthernet0/1")
+      @interface.update
+    end
+
+    it "should 'execute' all differing properties" do
+      @interface.expects(:execute).with(:description, "b")
+      @interface.expects(:execute).with(:mode, :access).never
+      @interface.update({ :description => "a", :mode => :access }, { :description => "b", :mode => :access })
+    end
+
+    it "should execute in cisco ios defined order" do
+      speed = states('speed').starts_as('notset')
+      @interface.expects(:execute).with(:speed, :auto).then(speed.is('set'))
+      @interface.expects(:execute).with(:duplex, :auto).when(speed.is('set'))
+      @interface.update({ :duplex => :half, :speed => "10" }, { :duplex => :auto, :speed => :auto  })
+    end
+
+    it "should execute absent properties with a no prefix" do
+      @interface.expects(:execute).with(:description, "a", "no ")
+      @interface.update({ :description => "a"}, { })
+    end
+
+    it "should exit twice" do
+      @transport.expects(:command).with("exit").twice
+      @interface.update
+    end
+  end
+
+  describe "when executing commands" do
+    it "should execute string commands directly" do
+      @transport.expects(:command).with("speed auto")
+      @interface.execute(:speed, :auto)
+    end
+
+    it "should execute string commands with the given prefix" do
+      @transport.expects(:command).with("no speed auto")
+      @interface.execute(:speed, :auto, "no ")
+    end
+
+    it "should stop at executing the first command that works for array" do
+      @transport.expects(:command).with("channel-group 1").yields("% Invalid command")
+      @transport.expects(:command).with("port group 1")
+      @interface.execute(:etherchannel, "1")
+    end
+
+    it "should execute the block for block commands" do
+      @transport.expects(:command).with("ip address 192.168.0.1 255.255.255.0")
+      @interface.execute(:ipaddress, [[24, IPAddr.new('192.168.0.1'), nil]])
+    end
+
+    it "should execute the block for block commands" do
+      @transport.expects(:command).with("ipv6 address fe08::/76 link-local")
+      @interface.execute(:ipaddress, [[76, IPAddr.new('fe08::'), 'link-local']])
+    end
+
+  end
+
+  describe "when sending commands to the device" do
+    it "should detect errors" do
+      Puppet.expects(:err)
+      @transport.stubs(:command).yields("% Invalid Command")
+      @interface.command("sh ver")
+    end
+  end
+end

data/spec/unit/util/network_device/config_spec.rb

@@ -0,0 +1,102 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+require 'puppet/util/network_device/config'
+
+describe Puppet::Util::NetworkDevice::Config do
+  before(:each) do
+    Puppet[:deviceconfig] = "/dummy"
+    FileTest.stubs(:exists?).with("/dummy").returns(true)
+  end
+
+  describe "when initializing" do
+    before :each do
+      Puppet::Util::NetworkDevice::Config.any_instance.stubs(:read)
+    end
+
+    it "should use the deviceconfig setting as pathname" do
+      Puppet.expects(:[]).with(:deviceconfig).returns("/dummy")
+
+      Puppet::Util::NetworkDevice::Config.new
+    end
+
+    it "should raise an error if no file is defined finally" do
+      Puppet.expects(:[]).with(:deviceconfig).returns(nil)
+
+      lambda { Puppet::Util::NetworkDevice::Config.new }.should raise_error(Puppet::DevError)
+    end
+
+    it "should read and parse the file" do
+      Puppet::Util::NetworkDevice::Config.any_instance.expects(:read)
+
+      Puppet::Util::NetworkDevice::Config.new
+    end
+  end
+
+  describe "when parsing device" do
+    before :each do
+      @config = Puppet::Util::NetworkDevice::Config.new
+      @config.stubs(:changed?).returns(true)
+      @fd = stub 'fd'
+      File.stubs(:open).yields(@fd)
+    end
+
+    it "should skip comments" do
+      @fd.stubs(:each).yields('  # comment')
+
+      OpenStruct.expects(:new).never
+
+      @config.read
+    end
+
+    it "should increment line number even on commented lines" do
+      @fd.stubs(:each).multiple_yields('  # comment','[router.puppetlabs.com]')
+
+      @config.read
+      @config.devices.should be_include('router.puppetlabs.com')
+    end
+
+    it "should skip blank lines" do
+      @fd.stubs(:each).yields('  ')
+
+      @config.read
+      @config.devices.should be_empty
+    end
+
+    it "should produce the correct line number" do
+      @fd.stubs(:each).multiple_yields('  ', '[router.puppetlabs.com]')
+
+      @config.read
+      @config.devices['router.puppetlabs.com'].line.should == 2
+    end
+
+    it "should throw an error if the current device already exists" do
+      @fd.stubs(:each).multiple_yields('[router.puppetlabs.com]', '[router.puppetlabs.com]')
+
+      lambda { @config.read }.should raise_error
+    end
+
+    it "should create a new device for each found device line" do
+      @fd.stubs(:each).multiple_yields('[router.puppetlabs.com]', '[swith.puppetlabs.com]')
+
+      @config.read
+      @config.devices.size.should == 2
+    end
+
+    it "should parse the device type" do
+      @fd.stubs(:each).multiple_yields('[router.puppetlabs.com]', 'type cisco')
+
+      @config.read
+      @config.devices['router.puppetlabs.com'].provider.should == 'cisco'
+    end
+
+    it "should parse the device url" do
+      @fd.stubs(:each).multiple_yields('[router.puppetlabs.com]', 'type cisco', 'url ssh://test/')
+
+      @config.read
+      @config.devices['router.puppetlabs.com'].url.should == 'ssh://test/'
+    end
+  end
+
+end

data/spec/unit/util/network_device/ipcalc_spec.rb

@@ -0,0 +1,63 @@
+#!/usr/bin/env rspec
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+require 'puppet/util/network_device/ipcalc'
+
+describe Puppet::Util::NetworkDevice::IPCalc do
+  class TestIPCalc
+    include Puppet::Util::NetworkDevice::IPCalc
+  end
+
+  before(:each) do
+    @ipcalc = TestIPCalc.new
+  end
+
+  describe "when parsing ip/prefix" do
+    it "should parse ipv4 without prefixes" do
+      @ipcalc.parse('127.0.0.1').should == [32,IPAddr.new('127.0.0.1')]
+    end
+
+    it "should parse ipv4 with prefixes" do
+      @ipcalc.parse('127.0.1.2/8').should == [8,IPAddr.new('127.0.1.2')]
+    end
+
+    it "should parse ipv6 without prefixes" do
+      @ipcalc.parse('FE80::21A:2FFF:FE30:ECF0').should == [128,IPAddr.new('FE80::21A:2FFF:FE30:ECF0')]
+    end
+
+    it "should parse ipv6 with prefixes" do
+      @ipcalc.parse('FE80::21A:2FFF:FE30:ECF0/56').should == [56,IPAddr.new('FE80::21A:2FFF:FE30:ECF0')]
+    end
+  end
+
+  describe "when building netmask" do
+    it "should produce the correct ipv4 netmask from prefix length" do
+      @ipcalc.netmask(Socket::AF_INET, 27).should == IPAddr.new('255.255.255.224')
+    end
+
+    it "should produce the correct ipv6 netmask from prefix length" do
+      @ipcalc.netmask(Socket::AF_INET6, 56).should == IPAddr.new('ffff:ffff:ffff:ff00::0')
+    end
+  end
+
+  describe "when building wildmask" do
+    it "should produce the correct ipv4 wildmask from prefix length" do
+      @ipcalc.wildmask(Socket::AF_INET, 27).should == IPAddr.new('0.0.0.31')
+    end
+
+    it "should produce the correct ipv6 wildmask from prefix length" do
+      @ipcalc.wildmask(Socket::AF_INET6, 126).should == IPAddr.new('::3')
+    end
+  end
+
+  describe "when computing prefix length from netmask" do
+    it "should produce the correct ipv4 prefix length" do
+      @ipcalc.prefix_length(IPAddr.new('255.255.255.224')).should == 27
+    end
+
+    it "should produce the correct ipv6 prefix length" do
+      @ipcalc.prefix_length(IPAddr.new('fffe::0')).should == 15
+    end
+  end
+end

data/spec/unit/util/network_device/transport/base_spec.rb

@@ -0,0 +1,42 @@
+#!/usr/bin/env rspec
+
+require File.dirname(__FILE__) + '/../../../../spec_helper'
+
+require 'puppet/util/network_device/transport/base'
+
+describe Puppet::Util::NetworkDevice::Transport::Base do
+  class TestTransport < Puppet::Util::NetworkDevice::Transport::Base
+  end
+
+  before(:each) do
+    @transport = TestTransport.new
+  end
+
+  describe "when sending commands" do
+    it "should send the command to the telnet session" do
+      @transport.expects(:send).with("line")
+      @transport.command("line")
+    end
+
+    it "should expect an output matching the given prompt" do
+      @transport.expects(:expect).with(/prompt/)
+      @transport.command("line", :prompt => /prompt/)
+    end
+
+    it "should expect an output matching the default prompt" do
+      @transport.default_prompt = /defprompt/
+      @transport.expects(:expect).with(/defprompt/)
+      @transport.command("line")
+    end
+
+    it "should yield telnet output to the given block" do
+      @transport.expects(:expect).yields("output")
+      @transport.command("line") { |out| out.should == "output" }
+    end
+
+    it "should return telnet output to the caller" do
+      @transport.expects(:expect).returns("output")
+      @transport.command("line").should == "output"
+    end
+  end
+end

data/spec/unit/util/network_device/transport/ssh_spec.rb

@@ -0,0 +1,219 @@
+#!/usr/bin/env rspec
+
+require File.dirname(__FILE__) + '/../../../../spec_helper'
+
+require 'puppet/util/network_device/transport/ssh'
+
+describe Puppet::Util::NetworkDevice::Transport::Ssh, :if => Puppet.features.ssh?, :'fails_on_ruby_1.9.2' => true do
+
+  before(:each) do
+    @transport = Puppet::Util::NetworkDevice::Transport::Ssh.new()
+  end
+
+  it "should handle login through the transport" do
+    @transport.should be_handles_login
+  end
+
+  it "should connect to the given host and port" do
+    Net::SSH.expects(:start).with { |host, user, args| host == "localhost" && args[:port] == 22 }.returns stub_everything
+    @transport.host = "localhost"
+    @transport.port = 22
+
+    @transport.connect
+  end
+
+  it "should connect using the given username and password" do
+    Net::SSH.expects(:start).with { |host, user, args| user == "user" && args[:password] == "pass" }.returns stub_everything
+    @transport.user = "user"
+    @transport.password = "pass"
+
+    @transport.connect
+  end
+
+  it "should raise a Puppet::Error when encountering an authentication failure" do
+    Net::SSH.expects(:start).raises Net::SSH::AuthenticationFailed
+    @transport.host = "localhost"
+    @transport.user = "user"
+
+    lambda { @transport.connect }.should raise_error Puppet::Error
+  end
+
+  describe "when connected" do
+    before(:each) do
+      @ssh = stub_everything 'ssh'
+      @channel = stub_everything 'channel'
+      Net::SSH.stubs(:start).returns @ssh
+      @ssh.stubs(:open_channel).yields(@channel)
+      @transport.stubs(:expect)
+    end
+
+    it "should open a channel" do
+      @ssh.expects(:open_channel)
+
+      @transport.connect
+    end
+
+    it "should request a pty" do
+      @channel.expects(:request_pty)
+
+      @transport.connect
+    end
+
+    it "should create a shell channel" do
+      @channel.expects(:send_channel_request).with("shell")
+      @transport.connect
+    end
+
+    it "should raise an error if shell channel creation fails" do
+      @channel.expects(:send_channel_request).with("shell").yields(@channel, false)
+      lambda { @transport.connect }.should raise_error
+    end
+
+    it "should register an on_data and on_extended_data callback" do
+      @channel.expects(:send_channel_request).with("shell").yields(@channel, true)
+      @channel.expects(:on_data)
+      @channel.expects(:on_extended_data)
+      @transport.connect
+    end
+
+    it "should accumulate data to the buffer on data" do
+      @channel.expects(:send_channel_request).with("shell").yields(@channel, true)
+      @channel.expects(:on_data).yields(@channel, "data")
+
+      @transport.connect
+      @transport.buf.should == "data"
+    end
+
+    it "should accumulate data to the buffer on extended data" do
+      @channel.expects(:send_channel_request).with("shell").yields(@channel, true)
+      @channel.expects(:on_extended_data).yields(@channel, 1, "data")
+
+      @transport.connect
+      @transport.buf.should == "data"
+    end
+
+    it "should mark eof on close" do
+      @channel.expects(:send_channel_request).with("shell").yields(@channel, true)
+      @channel.expects(:on_close).yields(@channel)
+
+      @transport.connect
+      @transport.should be_eof
+    end
+
+    it "should expect output to conform to the default prompt" do
+      @channel.expects(:send_channel_request).with("shell").yields(@channel, true)
+      @transport.expects(:default_prompt).returns("prompt")
+      @transport.expects(:expect).with("prompt")
+      @transport.connect
+    end
+
+    it "should start the ssh loop" do
+      @ssh.expects(:loop)
+      @transport.connect
+    end
+  end
+
+  describe "when closing" do
+    before(:each) do
+      @ssh = stub_everything 'ssh'
+      @channel = stub_everything 'channel'
+      Net::SSH.stubs(:start).returns @ssh
+      @ssh.stubs(:open_channel).yields(@channel)
+      @channel.stubs(:send_channel_request).with("shell").yields(@channel, true)
+      @transport.stubs(:expect)
+      @transport.connect
+    end
+
+    it "should close the channel" do
+      @channel.expects(:close)
+      @transport.close
+    end
+
+    it "should close the ssh session" do
+      @ssh.expects(:close)
+      @transport.close
+    end
+  end
+
+  describe "when sending commands" do
+    before(:each) do
+      @ssh = stub_everything 'ssh'
+      @channel = stub_everything 'channel'
+      Net::SSH.stubs(:start).returns @ssh
+      @ssh.stubs(:open_channel).yields(@channel)
+      @channel.stubs(:send_channel_request).with("shell").yields(@channel, true)
+      @transport.stubs(:expect)
+      @transport.connect
+    end
+
+    it "should send data to the ssh channel" do
+      @channel.expects(:send_data).with("data\n")
+      @transport.command("data")
+    end
+
+    it "should expect the default prompt afterward" do
+      @transport.expects(:default_prompt).returns("prompt")
+      @transport.expects(:expect).with("prompt")
+      @transport.command("data")
+    end
+
+    it "should expect the given prompt" do
+      @transport.expects(:expect).with("myprompt")
+      @transport.command("data", :prompt => "myprompt")
+    end
+
+    it "should yield the buffer output to given block" do
+      @transport.expects(:expect).yields("output")
+      @transport.command("data") do |out|
+        out.should == "output"
+      end
+    end
+
+    it "should return buffer output" do
+      @transport.expects(:expect).returns("output")
+      @transport.command("data").should == "output"
+    end
+  end
+
+  describe "when expecting output" do
+    before(:each) do
+      @connection = stub_everything 'connection'
+      @socket = stub_everything 'socket'
+      transport = stub 'transport', :socket => @socket
+      @ssh = stub_everything 'ssh', :transport => transport
+      @channel = stub_everything 'channel', :connection => @connection
+      @transport.ssh = @ssh
+      @transport.channel = @channel
+    end
+
+    it "should process the ssh event loop" do
+      IO.stubs(:select)
+      @transport.buf = "output"
+      @transport.expects(:process_ssh)
+      @transport.expect(/output/)
+    end
+
+    it "should return the output" do
+      IO.stubs(:select)
+      @transport.buf = "output"
+      @transport.stubs(:process_ssh)
+      @transport.expect(/output/).should == "output"
+    end
+
+    it "should return the output" do
+      IO.stubs(:select)
+      @transport.buf = "output"
+      @transport.stubs(:process_ssh)
+      @transport.expect(/output/).should == "output"
+    end
+
+    describe "when processing the ssh loop" do
+      it "should advance one tick in the ssh event loop and exit on eof" do
+        @transport.buf = ''
+        @connection.expects(:process).then.raises(EOFError)
+        @transport.process_ssh
+      end
+    end
+  end
+
+end