puppet 2.6.18 → 2.7.1

data/spec/unit/provider/package/pkg_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 provider = Puppet::Type.type(:package).provider(:pkg)
 

data/spec/unit/provider/package/pkgdmg_spec.rb

@@ -1,90 +1,83 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
+require 'spec_helper'
 
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+provider = Puppet::Type.type(:package).provider(:pkgdmg)
 
-describe Puppet::Type.type(:package).provider(:pkgdmg) do
-  let(:resource) { Puppet::Type.type(:package).new(:name => 'foo', :provider => :pkgdmg) }
-  let(:provider) { described_class.new(resource) }
+describe provider do
+  before do
+    @resource = stub 'resource', :[] => "dummypkgdmg"
+    @provider = provider.new(@resource)
 
-  it { should_not be_versionable }
-  it { should_not be_uninstallable }
+    @fakemountpoint   = "/tmp/dmg.foo"
+    @fakepkgfile      = "/tmp/test.pkg"
+    @fakehdiutilinfo  = {"system-entities" => [{"mount-point" => @fakemountpoint}] }
+    @fakehdiutilplist = Plist::Emit.dump(@fakehdiutilinfo)
+
+    @hdiutilmountargs = ["mount", "-plist", "-nobrowse", "-readonly",
+      "-noidme", "-mountrandom", "/tmp"]
+  end
+
+  it "should not be versionable" do
+    provider.versionable?.should be_false
+  end
+
+  it "should not be uninstallable" do
+    provider.uninstallable?.should be_false
+  end
 
   describe "when installing it should fail when" do
-    before :each do
-      Puppet::Util.expects(:execute).never
+    it "no source is specified" do
+      @resource.stubs(:[]).with(:source).returns nil
+      lambda { @provider.install }.should raise_error(Puppet::Error)
     end
 
-    it "no source is specified" do
-      expect { provider.install }.should raise_error(Puppet::Error, /must specify a package source/)
+    it "no name is specified" do
+      @resource.stubs(:[]).with(:name).returns nil
+      lambda { @provider.install }.should raise_error(Puppet::Error)
     end
 
     it "the source does not end in .dmg or .pkg" do
-      resource[:source] = "bar"
-      expect { provider.install }.should raise_error(Puppet::Error, /must specify a source string ending in .*dmg.*pkg/)
+      @resource.stubs(:[]).with(:source).returns "notendingindotdmgorpkg"
+      lambda { @provider.install }.should raise_error(Puppet::Error)
+    end
+
+    it "a disk image with no system entities is mounted" do
+      @provider.stubs(:[]).with(:hdiutil).returns ""
+      lambda { @provider.install }.should raise_error(Puppet::Error)
     end
   end
 
   # These tests shouldn't be this messy. The pkgdmg provider needs work...
   describe "when installing a pkgdmg" do
-    let(:fake_mountpoint) { "/tmp/dmg.foo" }
-    let(:empty_hdiutil_plist) { Plist::Emit.dump({}) }
-    let(:fake_hdiutil_plist) { Plist::Emit.dump({"system-entities" => [{"mount-point" => fake_mountpoint}]}) }
-
     before do
       fh = mock 'filehandle'
       fh.stubs(:path).yields "/tmp/foo"
-      resource[:source] = "foo.dmg"
+      @resource.stubs(:[]).with(:source).returns "foo.dmg"
       File.stubs(:open).yields fh
-      Dir.stubs(:mktmpdir).returns "/tmp/testtmp123"
-      FileUtils.stubs(:remove_entry_secure)
-    end
-
-    it "should fail when a disk image with no system entities is mounted" do
-      described_class.stubs(:hdiutil).returns(empty_hdiutil_plist)
-      expect { provider.install }.should raise_error(Puppet::Error, /No disk entities/)
     end
 
     it "should call hdiutil to mount and eject the disk image" do
       Dir.stubs(:entries).returns []
-      provider.class.expects(:hdiutil).with("eject", fake_mountpoint).returns 0
-      provider.class.expects(:hdiutil).with("mount", "-plist", "-nobrowse", "-readonly", "-noidme", "-mountrandom", "/tmp", nil).returns fake_hdiutil_plist
-      provider.install
+      @provider.class.expects(:hdiutil).with("eject", @fakemountpoint).returns 0
+      @provider.class.expects(:hdiutil).with("mount", "-plist", "-nobrowse", "-readonly", "-noidme", "-mountrandom", "/tmp", nil).returns @fakehdiutilplist
+      @provider.install
     end
 
     it "should call installpkg if a pkg/mpkg is found on the dmg" do
       Dir.stubs(:entries).returns ["foo.pkg"]
-      provider.class.stubs(:hdiutil).returns fake_hdiutil_plist
-      provider.class.expects(:installpkg).with("#{fake_mountpoint}/foo.pkg", resource[:name], "foo.dmg").returns ""
-      provider.install
-    end
-
-    describe "from a remote source" do
-      let(:tmpdir) { "/tmp/good123" }
-
-      before :each do
-        resource[:source] = "http://fake.puppetlabs.com/foo.dmg"
-      end
-
-      it "should call tmpdir and use the returned directory" do
-        Dir.expects(:mktmpdir).returns tmpdir
-        Dir.stubs(:entries).returns ["foo.pkg"]
-        described_class.expects(:curl).with do |*args|
-          args[0] == "-o" and args[1].include? tmpdir
-        end
-        described_class.stubs(:hdiutil).returns fake_hdiutil_plist
-        described_class.expects(:installpkg)
-
-        provider.install
-      end
+      @provider.class.stubs(:hdiutil).returns @fakehdiutilplist
+      @provider.class.expects(:installpkg).with("#{@fakemountpoint}/foo.pkg", @resource[:name], "foo.dmg").returns ""
+      @provider.install
     end
   end
 
   describe "when installing flat pkg file" do
     it "should call installpkg if a flat pkg file is found instead of a .dmg image" do
-      resource[:source] = "/tmp/test.pkg"
-      resource[:name] = "testpkg"
-      provider.class.expects(:installpkgdmg).with("/tmp/test.pkg", "testpkg").returns ""
-      provider.install
-    end
+      @resource.stubs(:[]).with(:source).returns "/tmp/test.pkg"
+      @resource.stubs(:[]).with(:name).returns "testpkg"
+        @provider.class.expects(:installpkgdmg).with("#{@fakepkgfile}", "testpkg").returns ""
+        @provider.install
+        end
   end
+
 end

data/spec/unit/provider/package/pkgutil_spec.rb

@@ -0,0 +1,182 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+provider = Puppet::Type.type(:package).provider(:pkgutil)
+
+describe provider do
+  before(:each) do
+    @resource = Puppet::Type.type(:package).new(
+      :name     => "TESTpkg",
+      :ensure   => :present,
+      :provider => :pkgutil
+    )
+    @provider = provider.new(@resource)
+
+    # Stub all file and config tests
+    provider.stubs(:healthcheck)
+  end
+
+  it "should have an install method" do
+    @provider.should respond_to(:install)
+  end
+
+  it "should have a latest method" do
+    @provider.should respond_to(:uninstall)
+  end
+
+  it "should have an update method" do
+    @provider.should respond_to(:update)
+  end
+
+  it "should have a latest method" do
+    @provider.should respond_to(:latest)
+  end
+
+  describe "when installing" do
+    it "should use a command without versioned package" do
+      @resource[:ensure] = :latest
+      @provider.expects(:pkguti).with('-y', '-i', 'TESTpkg')
+      @provider.install
+    end
+  end
+
+  describe "when updating" do
+    it "should use a command without versioned package" do
+      @provider.expects(:pkguti).with('-y', '-u', 'TESTpkg')
+      @provider.update
+    end
+  end
+
+  describe "when uninstalling" do
+    it "should call the remove operation" do
+      @provider.expects(:pkguti).with('-y', '-r', 'TESTpkg')
+      @provider.uninstall
+    end
+  end
+
+  describe "when getting latest version" do
+    it "should return TESTpkg's version string" do
+      fake_data = "
+noisy output here
+TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.latest.should == "1.4.5,REV=2007.11.20"
+    end
+
+    it "should handle TESTpkg's 'SAME' version string" do
+      fake_data = "
+noisy output here
+TESTpkg                   1.4.5,REV=2007.11.18      SAME"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.latest.should == "1.4.5,REV=2007.11.18"
+    end
+
+    it "should handle a non-existent package" do
+      fake_data = "noisy output here
+Not in catalog"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.latest.should == nil
+    end
+
+    it "should warn on unknown pkgutil noise" do
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns("testingnoise")
+      @provider.latest.should == nil
+    end
+
+    it "should ignore pkgutil noise/headers to find TESTpkg" do
+      fake_data = "# stuff
+=> Fetching new catalog and descriptions (http://mirror.opencsw.org/opencsw/unstable/i386/5.11) if available ...
+2011-02-19 23:05:46 URL:http://mirror.opencsw.org/opencsw/unstable/i386/5.11/catalog [534635/534635] -> \"/var/opt/csw/pkgutil/catalog.mirror.opencsw.org_opencsw_unstable_i386_5.11.tmp\" [1]
+Checking integrity of /var/opt/csw/pkgutil/catalog.mirror.opencsw.org_opencsw_unstable_i386_5.11 with gpg.
+gpg: Signature made February 17, 2011 05:27:53 PM GMT using DSA key ID E12E9D2F
+gpg: Good signature from \"Distribution Manager <dm@blastwave.org>\"
+==> 2770 packages loaded from /var/opt/csw/pkgutil/catalog.mirror.opencsw.org_opencsw_unstable_i386_5.11
+package                   installed                 catalog
+TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.latest.should == "1.4.5,REV=2007.11.20"
+    end
+
+    it "should find REALpkg via an alias (TESTpkg)" do
+      fake_data = "
+noisy output here
+REALpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.query[:name].should == "TESTpkg"
+    end
+  end
+
+  describe "when querying current version" do
+    it "should return TESTpkg's version string" do
+      fake_data = "TESTpkg  1.4.5,REV=2007.11.18  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.query[:ensure].should == "1.4.5,REV=2007.11.18"
+    end
+
+    it "should handle a package that isn't installed" do
+      fake_data = "TESTpkg  notinst  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.query[:ensure].should == :absent
+    end
+
+    it "should handle a non-existent package" do
+      fake_data = "noisy output here
+Not in catalog"
+      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      @provider.query[:ensure].should == :absent
+    end
+  end
+
+  describe "when querying current instances" do
+    it "should warn on unknown pkgutil noise" do
+      provider.expects(:pkguti).with(['-a']).returns("testingnoise")
+      provider.expects(:pkguti).with(['-c']).returns("testingnoise")
+      Puppet.expects(:warning).times(2)
+      provider.expects(:new).never
+      provider.instances.should == []
+    end
+
+    it "should return TESTpkg's version string" do
+      fake_data = "TESTpkg  TESTpkg  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-a']).returns fake_data
+
+      fake_data = "TESTpkg  1.4.5,REV=2007.11.18  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c']).returns fake_data
+
+      testpkg = mock 'pkg1'
+      provider.expects(:new).with(:ensure => "1.4.5,REV=2007.11.18", :name => "TESTpkg", :provider => :pkgutil).returns testpkg
+      provider.instances.should == [testpkg]
+    end
+
+    it "should also return both TESTpkg and mypkg alias instances" do
+      fake_data = "mypkg  TESTpkg  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-a']).returns fake_data
+
+      fake_data = "TESTpkg  1.4.5,REV=2007.11.18  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c']).returns fake_data
+
+      testpkg = mock 'pkg1'
+      provider.expects(:new).with(:ensure => "1.4.5,REV=2007.11.18", :name => "TESTpkg", :provider => :pkgutil).returns testpkg
+
+      aliaspkg = mock 'pkg2'
+      provider.expects(:new).with(:ensure => "1.4.5,REV=2007.11.18", :name => "mypkg", :provider => :pkgutil).returns aliaspkg
+
+      provider.instances.should == [testpkg,aliaspkg]
+    end
+
+    it "shouldn't mind noise in the -a output" do
+      fake_data = "noisy output here"
+      provider.expects(:pkguti).with(['-a']).returns fake_data
+
+      fake_data = "TESTpkg  1.4.5,REV=2007.11.18  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with(['-c']).returns fake_data
+
+      testpkg = mock 'pkg1'
+      provider.expects(:new).with(:ensure => "1.4.5,REV=2007.11.18", :name => "TESTpkg", :provider => :pkgutil).returns testpkg
+
+      provider.instances.should == [testpkg]
+    end
+  end
+
+end

data/spec/unit/provider/package/yum_spec.rb

@@ -0,0 +1,66 @@
+#!/usr/bin/env rspec
+require 'spec_helper'
+
+provider = Puppet::Type.type(:package).provider(:yum)
+
+describe provider do
+  before do
+    # Create a mock resource
+     @resource = stub 'resource'
+     @resource.stubs(:[]).with(:name).returns 'mypackage'
+     @provider = provider.new(@resource)
+     @provider.stubs(:resource).returns @resource
+     @provider.stubs(:yum).returns 'yum'
+     @provider.stubs(:rpm).returns 'rpm'
+     @provider.stubs(:get).with(:name).returns 'mypackage'
+     @provider.stubs(:get).with(:version).returns '1'
+     @provider.stubs(:get).with(:release).returns '1'
+     @provider.stubs(:get).with(:arch).returns 'i386'
+  end
+  # provider should repond to the following methods
+   [:install, :latest, :update, :purge].each do |method|
+     it "should have a(n) #{method}" do
+       @provider.should respond_to(method)
+    end
+  end
+
+  describe 'when installing' do
+    it 'should call yum install for :installed' do
+      @resource.stubs(:should).with(:ensure).returns :installed
+      @provider.expects(:yum).with('-d', '0', '-e', '0', '-y', :install, 'mypackage')
+      @provider.install
+    end
+    it 'should use :install to update' do
+      @provider.expects(:install)
+      @provider.update
+    end
+    it 'should be able to set version' do
+      @resource.stubs(:should).with(:ensure).returns '1.2'
+      @provider.expects(:yum).with('-d', '0', '-e', '0', '-y', :install, 'mypackage-1.2')
+      @provider.stubs(:query).returns :ensure => '1.2'
+      @provider.install
+    end
+    it 'should be able to downgrade' do
+      @resource.stubs(:should).with(:ensure).returns '1.0'
+      @provider.expects(:yum).with('-d', '0', '-e', '0', '-y', :downgrade, 'mypackage-1.0')
+      @provider.stubs(:query).returns(:ensure => '1.2').then.returns(:ensure => '1.0')
+      @provider.install
+    end
+  end
+
+  describe 'when uninstalling' do
+    it 'should use erase to purge' do
+      @provider.expects(:yum).with('-y', :erase, 'mypackage')
+      @provider.purge
+    end
+    it 'should use rpm to uninstall' do
+      @provider.expects(:rpm).with('-e', 'mypackage-1-1.i386')
+      @provider.uninstall
+    end
+  end
+
+  it 'should be versionable' do
+    provider.should be_versionable
+  end
+end
+

data/spec/unit/provider/package/zypper_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 provider_class = Puppet::Type.type(:package).provider(:zypper)
 

data/spec/unit/provider/parsedfile_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-require File.dirname(__FILE__) + '/../../spec_helper'
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 require 'puppet/provider/parsedfile'
 

data/spec/unit/provider/selboolean_spec.rb

@@ -1,6 +1,5 @@
-#!/usr/bin/env ruby
-
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+#!/usr/bin/env rspec
+require 'spec_helper'
 
 provider_class = Puppet::Type.type(:selboolean).provider(:getsetsebool)
 

data/spec/unit/provider/selmodule_spec.rb

@@ -1,11 +1,11 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
 # Note: This unit test depends on having a sample SELinux policy file
 # in the same directory as this test called selmodule-example.pp
 # with version 1.5.0.  The provided selmodule-example.pp is the first
 # 256 bytes taken from /usr/share/selinux/targeted/nagios.pp on Fedora 9
 
-Dir.chdir(File.dirname(__FILE__)) { (s = lambda { |f| File.exist?(f) ? require(f) : Dir.chdir("..") { s.call(f) } }).call("spec/spec_helper.rb") }
+require 'spec_helper'
 
 provider_class = Puppet::Type.type(:selmodule).provider(:semodule)
 

data/spec/unit/provider/service/daemontools_spec.rb

@@ -1,10 +1,10 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 #
 # Unit testing for the Daemontools service Provider
 #
 # author Brice Figureau
 #
-require File.dirname(__FILE__) + '/../../../spec_helper'
+require 'spec_helper'
 
 provider_class = Puppet::Type.type(:service).provider(:daemontools)