puppet-lint 2.5.0 → 3.0.0

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_resources/duplicate_params_spec.rb

@@ -15,11 +15,11 @@ describe 'duplicate_params' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(5).in_column(11)
     end
   end
@@ -36,7 +36,7 @@ describe 'duplicate_params' do
       END
     end
 
-    it 'should not detect any errors' do
+    it 'does not detect any errors' do
       expect(problems).to have(0).problems
     end
   end
@@ -53,11 +53,11 @@ describe 'duplicate_params' do
       END
     end
 
-    it 'should only detect a single error' do
+    it 'only detects a single error' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(4).in_column(15)
     end
   end
@@ -76,11 +76,11 @@ describe 'duplicate_params' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(7).in_column(11)
     end
   end
@@ -95,7 +95,7 @@ describe 'duplicate_params' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -103,7 +103,7 @@ describe 'duplicate_params' do
   context 'colon as last token in file' do
     let(:code) { '}:' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_resources/ensure_first_param_spec.rb

@@ -7,7 +7,7 @@ describe 'ensure_first_param' do
     context 'ensure as only attr in a single line resource' do
       let(:code) { "file { 'foo': ensure => present }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -21,7 +21,7 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -36,11 +36,11 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(3).in_column(13)
       end
     end
@@ -55,7 +55,7 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -76,7 +76,7 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -92,25 +92,25 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
     context 'ensure as only attr in a single line resource' do
       let(:code) { "file { 'foo': ensure => present }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -124,7 +124,7 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -148,15 +148,15 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_fixed(msg).on_line(3).in_column(13)
       end
 
-      it 'should make ensure the first attr' do
+      it 'makes ensure the first attr' do
         expect(manifest).to eq(fixed)
       end
     end
@@ -171,7 +171,7 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -192,7 +192,7 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -228,15 +228,15 @@ describe 'ensure_first_param' do
         END
       end
 
-      it 'should detect a problem' do
+      it 'detects a problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the problem' do
+      it 'fixes the problem' do
         expect(problems).to contain_fixed(msg).on_line(3).in_column(13)
       end
 
-      it 'should move the whole ensure parameter to the top' do
+      it 'moves the whole ensure parameter to the top' do
         expect(manifest).to eq(fixed)
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_resources/ensure_not_symlink_target_spec.rb

@@ -14,7 +14,7 @@ describe 'ensure_not_symlink_target' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -28,22 +28,22 @@ describe 'ensure_not_symlink_target' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(2).in_column(23)
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
@@ -57,11 +57,11 @@ describe 'ensure_not_symlink_target' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
 
-      it 'should not modify the manifest' do
+      it 'does not modify the manifest' do
         expect(manifest).to eq(code)
       end
     end
@@ -84,15 +84,15 @@ describe 'ensure_not_symlink_target' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the problem' do
+      it 'fixes the problem' do
         expect(problems).to contain_fixed(msg).on_line(2).in_column(23)
       end
 
-      it 'should create a new target param' do
+      it 'creates a new target param' do
         expect(manifest).to eq(fixed)
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_resources/file_mode_spec.rb

@@ -7,11 +7,11 @@ describe 'file_mode' do
     context '3 digit file mode' do
       let(:code) { "file { 'foo': mode => '777' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(23)
       end
     end
@@ -19,7 +19,7 @@ describe 'file_mode' do
     context '4 digit file mode' do
       let(:code) { "file { 'foo': mode => '0777' }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -27,7 +27,7 @@ describe 'file_mode' do
     context 'file mode as a variable' do
       let(:code) { "file { 'foo': mode => $file_mode }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -35,7 +35,7 @@ describe 'file_mode' do
     context 'symbolic file mode' do
       let(:code) { "file { 'foo': mode => 'u=rw,og=r' }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -43,7 +43,7 @@ describe 'file_mode' do
     context 'file mode undef unquoted' do
       let(:code) { "file { 'foo': mode => undef }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -51,11 +51,11 @@ describe 'file_mode' do
     context 'file mode undef quoted' do
       let(:code) { "file { 'foo': mode => 'undef' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(23)
       end
     end
@@ -63,7 +63,7 @@ describe 'file_mode' do
     context 'mode as audit value' do
       let(:code) { "file { '/etc/passwd': audit => [ owner, mode ], }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -71,11 +71,11 @@ describe 'file_mode' do
     context '3 digit concat mode' do
       let(:code) { "concat { 'foo': mode => '777' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(25)
       end
     end
@@ -83,7 +83,7 @@ describe 'file_mode' do
     context '4 digit concat mode' do
       let(:code) { "concat { 'foo': mode => '0777' }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -91,7 +91,7 @@ describe 'file_mode' do
     context 'concat mode as a variable' do
       let(:code) { "concat { 'foo': mode => $concat_mode }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -99,7 +99,7 @@ describe 'file_mode' do
     context 'symbolic concat mode' do
       let(:code) { "concat { 'foo': mode => 'u=rw,og=r' }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -107,7 +107,7 @@ describe 'file_mode' do
     context 'concat mode undef unquoted' do
       let(:code) { "concat { 'foo': mode => undef }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -115,11 +115,11 @@ describe 'file_mode' do
     context 'concat mode undef quoted' do
       let(:code) { "concat { 'foo': mode => 'undef' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(25)
       end
     end
@@ -127,7 +127,7 @@ describe 'file_mode' do
     context 'mode as audit value' do
       let(:code) { "concat { '/etc/passwd': audit => [ owner, mode ], }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -135,7 +135,7 @@ describe 'file_mode' do
     context 'mode as a function return value' do
       let(:code) { "file { 'foo': mode => lookup('bar'), }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -155,11 +155,11 @@ describe 'file_mode' do
         END
       end
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problems
       end
 
-      it 'should create three warnings' do
+      it 'creates three warnings' do
         expect(problems).to contain_warning(sprintf(msg)).on_line(4).in_column(23)
         expect(problems).to contain_warning(sprintf(msg)).on_line(6).in_column(23)
         expect(problems).to contain_warning(sprintf(msg)).on_line(8).in_column(23)
@@ -168,26 +168,26 @@ describe 'file_mode' do
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
     context '3 digit file mode' do
       let(:code) { "file { 'foo': mode => '777' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(23)
       end
 
-      it 'should zero pad the file mode' do
+      it 'zeroe pads the file mode' do
         expect(manifest).to eq("file { 'foo': mode => '0777' }")
       end
     end
@@ -195,15 +195,15 @@ describe 'file_mode' do
     context 'file mode undef quoted' do
       let(:code) { "file { 'foo': mode => 'undef' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(23)
       end
 
-      it 'should not modify the original manifest' do
+      it 'does not modify the original manifest' do
         expect(manifest).to eq(code)
       end
     end
@@ -211,15 +211,15 @@ describe 'file_mode' do
     context '3 digit concat mode' do
       let(:code) { "concat { 'foo': mode => '777' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(25)
       end
 
-      it 'should zero pad the concat mode' do
+      it 'zero pads the concat mode' do
         expect(manifest).to eq("concat { 'foo': mode => '0777' }")
       end
     end
@@ -227,15 +227,15 @@ describe 'file_mode' do
     context 'concat mode undef quoted' do
       let(:code) { "concat { 'foo': mode => 'undef' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(25)
       end
 
-      it 'should not modify the original manifest' do
+      it 'does not modify the original manifest' do
         expect(manifest).to eq(code)
       end
     end
@@ -243,11 +243,11 @@ describe 'file_mode' do
     context 'mode as a function return value' do
       let(:code) { "file { 'foo': mode => lookup('bar'), }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
 
-      it 'should not change the manifest' do
+      it 'does not change the manifest' do
         expect(manifest).to eq(code)
       end
     end
@@ -281,17 +281,17 @@ describe 'file_mode' do
         END
       end
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problems
       end
 
-      it 'should fix 3 problems' do
+      it 'fixes 3 problems' do
         expect(problems).to contain_fixed(msg).on_line(4).in_column(23)
         expect(problems).to contain_fixed(msg).on_line(6).in_column(23)
         expect(problems).to contain_fixed(msg).on_line(8).in_column(23)
       end
 
-      it 'should zero pad the file modes and change them to strings' do
+      it 'zero pads the file modes and change them to strings' do
         expect(manifest).to eq(fixed)
       end
     end