puppet-lint 2.5.0 → 3.0.0

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/arrow_on_right_operand_line_spec.rb

@@ -12,7 +12,7 @@ describe 'arrow_on_right_operand_line' do
           END
         end
 
-        it 'should not detect any problems' do
+        it 'does not detect any problems' do
           expect(problems).to have(0).problems
         end
       end
@@ -25,20 +25,20 @@ describe 'arrow_on_right_operand_line' do
           END
         end
 
-        it 'should detect a problem' do
+        it 'detects a problem' do
           expect(problems).to have(1).problem
         end
 
-        it 'should create a warning' do
+        it 'creates a warning' do
           expect(problems).to contain_warning(msg).on_line(1).in_column(31)
         end
 
         context 'with fix enabled' do
-          before do
+          before(:each) do
             PuppetLint.configuration.fix = true
           end
 
-          after do
+          after(:each) do
             PuppetLint.configuration.fix = false
           end
 
@@ -49,11 +49,11 @@ describe 'arrow_on_right_operand_line' do
             END
           end
 
-          it 'should fix the problem' do
+          it 'fixes the problem' do
             expect(problems).to contain_fixed(msg).on_line(1).in_column(31)
           end
 
-          it 'should move the arrow to before the right operand' do
+          it 'moves the arrow to before the right operand' do
             expect(manifest).to eq(fixed)
           end
         end
@@ -67,7 +67,7 @@ describe 'arrow_on_right_operand_line' do
           END
         end
 
-        it 'should not detect any problems' do
+        it 'does not detect any problems' do
           expect(problems).to have(0).problems
         end
       end
@@ -83,11 +83,11 @@ describe 'arrow_on_right_operand_line' do
           END
         end
 
-        it 'should detect a problem' do
+        it 'detects a problem' do
           expect(problems).to have(1).problem
         end
 
-        it 'should create a warning' do
+        it 'creates a warning' do
           expect(problems).to contain_warning(msg).on_line(1).in_column(30)
         end
 
@@ -110,11 +110,11 @@ describe 'arrow_on_right_operand_line' do
             END
           end
 
-          it 'should fix the problem' do
+          it 'fixes the problem' do
             expect(problems).to contain_fixed(msg).on_line(1).in_column(30)
           end
 
-          it 'should move the arrow to before the right operand' do
+          it 'moves the arrow to before the right operand' do
             expect(manifest).to eq(fixed)
           end
         end
@@ -128,11 +128,11 @@ describe 'arrow_on_right_operand_line' do
           END
         end
 
-        it 'should detect a problem' do
+        it 'detects a problem' do
           expect(problems).to have(1).problem
         end
 
-        it 'should create a warning' do
+        it 'creates a warning' do
           expect(problems).to contain_warning(msg).on_line(1).in_column(30)
         end
 
@@ -152,11 +152,11 @@ describe 'arrow_on_right_operand_line' do
             END
           end
 
-          it 'should fix the problem' do
+          it 'fixes the problem' do
             expect(problems).to contain_fixed(msg).on_line(1).in_column(30)
           end
 
-          it 'should move the arrow to before the right operand' do
+          it 'moves the arrow to before the right operand' do
             expect(manifest).to eq(fixed)
           end
         end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/autoloader_layout_spec.rb

@@ -5,7 +5,7 @@ describe 'autoloader_layout' do
     let(:code) { 'class foo::bar { }' }
     let(:path) { 'foo/manifests/bar.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -14,7 +14,7 @@ describe 'autoloader_layout' do
     let(:code) { 'define foo::bar::baz() { }' }
     let(:path) { 'foo/manifests/bar/baz.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -23,7 +23,7 @@ describe 'autoloader_layout' do
     let(:code) { 'class foo { }' }
     let(:path) { 'foo/manifests/init.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -33,11 +33,11 @@ describe 'autoloader_layout' do
     let(:path) { 'foo/manifests/init.pp' }
     let(:msg) { 'foo::bar not in autoload module layout' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1).in_column(7)
     end
   end
@@ -55,7 +55,7 @@ describe 'autoloader_layout' do
 
     let(:path) { 'bar/manifests/init.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -64,41 +64,41 @@ describe 'autoloader_layout' do
     let(:code) { 'class foo { }' }
     let(:path) { 'puppet-foo/manifests/init.pp' }
 
-    it 'should detect a single problem' do
+    it 'detects a single problem' do
       expect(problems).to have(1).problems
     end
   end
 
   context 'foo in puppet-foo/manifests/bar.pp with relative option' do
-    before do
+    before(:each) do
       PuppetLint.configuration.relative = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.relative = false
     end
 
     let(:code) { 'class foo { }' }
     let(:path) { 'puppet-foo/manifests/bar.pp' }
 
-    it 'should detect a single problem' do
+    it 'detects a single problem' do
       expect(problems).to have(1).problems
     end
   end
 
   context 'foo in puppet-foo/manifests/init.pp with relative option' do
-    before do
+    before(:each) do
       PuppetLint.configuration.relative = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.relative = false
     end
 
     let(:code) { 'class foo { }' }
     let(:path) { 'puppet-foo/manifests/init.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/class_inherits_from_params_class_spec.rb

@@ -11,11 +11,11 @@ describe 'class_inherits_from_params_class' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(2).in_column(42)
     end
   end
@@ -32,7 +32,7 @@ describe 'class_inherits_from_params_class' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/code_on_top_scope_spec.rb

@@ -10,7 +10,7 @@ describe 'code_on_top_scope' do
       END
     end
 
-    its(:problems) { should be_empty }
+    its(:problems) { is_expected.to be_empty }
   end
 
   describe 'new lines outside of class-define block' do
@@ -23,7 +23,7 @@ describe 'code_on_top_scope' do
       END
     end
 
-    its(:problems) { should be_empty }
+    its(:problems) { is_expected.to be_empty }
   end
 
   describe 'code outside class block' do
@@ -41,8 +41,8 @@ describe 'code_on_top_scope' do
     end
 
     its(:problems) do
-      should contain_warning('code outside of class or define block - include')
-      should have(4).problems
+      is_expected.to contain_warning('code outside of class or define block - include')
+      is_expected.to have(4).problems
     end
   end
 end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/inherits_across_namespaces_spec.rb

@@ -6,7 +6,7 @@ describe 'inherits_across_namespaces' do
   context 'class inheriting from parent in same module namespace' do
     let(:code) { 'class foo::bar inherits foo { }' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -14,7 +14,7 @@ describe 'inherits_across_namespaces' do
   context 'class inheriting from sister in same module namespace' do
     let(:code) { 'class foo::bar inherits foo::baz { }' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -22,11 +22,11 @@ describe 'inherits_across_namespaces' do
   context 'class inheriting from another module namespace' do
     let(:code) { 'class foo::bar inherits baz { }' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(25)
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/name_contains_uppercase_spec.rb

@@ -6,11 +6,11 @@ describe 'names_containing_uppercase' do
     let(:path) { 'foobar/manifests/init.pp' }
     let(:class_msg) { "defined type 'FooBar' contains illegal uppercase" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(8)
     end
   end
@@ -20,11 +20,11 @@ describe 'names_containing_uppercase' do
     let(:path) { 'foobar/manifests/init.pp' }
     let(:class_msg) { "class 'FooBar' contains illegal uppercase" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(7)
     end
   end
@@ -34,30 +34,30 @@ describe 'names_containing_uppercase' do
     let(:path) { 'foo/manifests/barfoo.pp' }
     let(:class_msg) { "class 'Foo::BarFoo' contains illegal uppercase" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(7)
     end
 
     context 'check fix -' do
-      before do
+      before(:each) do
         PuppetLint.configuration.fix = true
       end
 
-      after do
+      after(:each) do
         PuppetLint.configuration.fix = false
       end
 
       let(:fixed) { code.downcase }
 
-      it 'should create an error' do
+      it 'creates an error' do
         expect(problems).to contain_fixed(class_msg).on_line(1).in_column(7)
       end
 
-      it 'should downcase the class name' do
+      it 'downcases the class name' do
         expect(manifest).to eq(fixed)
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/names_containing_dash_spec.rb

@@ -8,11 +8,11 @@ describe 'names_containing_dash' do
     let(:code) { 'class foo-bar { }' }
     let(:path) { 'foo-bar/manifests/init.pp' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(7)
     end
   end
@@ -21,11 +21,11 @@ describe 'names_containing_dash' do
     let(:code) { 'define foo::foo-bar { }' }
     let(:path) { 'foo/manifests/foo-bar.pp' }
 
-    it 'should only detect a single problem' do
+    it 'only detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(define_msg).on_line(1).in_column(8)
     end
   end
@@ -34,11 +34,11 @@ describe 'names_containing_dash' do
     let(:code) { 'class foo::bar-foo { }' }
     let(:path) { 'foo/manifests/bar-foo.pp' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(7)
     end
   end
@@ -51,7 +51,7 @@ describe 'names_containing_dash' do
       END
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(2).in_column(15)
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/nested_classes_or_defines_spec.rb

@@ -7,7 +7,7 @@ describe 'nested_classes_or_defines' do
   context 'class on its own' do
     let(:code) { 'class foo { }' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -22,11 +22,11 @@ describe 'nested_classes_or_defines' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(class_msg).on_line(2).in_column(11)
     end
   end
@@ -42,7 +42,7 @@ describe 'nested_classes_or_defines' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -58,7 +58,7 @@ describe 'nested_classes_or_defines' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -73,11 +73,11 @@ describe 'nested_classes_or_defines' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problems
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(define_msg).on_line(2).in_column(11)
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/parameter_order_spec.rb

@@ -3,11 +3,11 @@ require 'spec_helper'
 describe 'parameter_order' do
   let(:msg) { 'optional parameter listed before required parameter' }
 
-  %w[define class].each do |type|
+  ['define', 'class'].each do |type|
     context "#{type} with attrs in order" do
       let(:code) { "#{type} foo($bar, $baz='gronk') { }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -15,7 +15,7 @@ describe 'parameter_order' do
     context "#{type} with parameter that calls a function" do
       let(:code) { "#{type} foo($bar=extlookup($name)) {}" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -23,12 +23,12 @@ describe 'parameter_order' do
     context "#{type} with attrs out of order" do
       let(:code) { "#{type} foo($bar='baz', $gronk) { }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
       col = (type == 'class' ? 23 : 24)
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(col)
       end
     end
@@ -41,7 +41,7 @@ describe 'parameter_order' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -54,12 +54,12 @@ describe 'parameter_order' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
       col = (type == 'class' ? 35 : 36)
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(col)
       end
     end
@@ -75,7 +75,7 @@ describe 'parameter_order' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/right_to_left_relationship_spec.rb

@@ -6,7 +6,7 @@ describe 'right_to_left_relationship' do
   context 'chain 2 resources left to right' do
     let(:code) { 'Class[foo] -> Class[bar]' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -14,11 +14,11 @@ describe 'right_to_left_relationship' do
   context 'chain 2 resources right to left' do
     let(:code) { 'Class[foo] <- Class[bar]' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(12)
     end
   end