puppet-lint 2.5.0 → 3.0.0

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_classes/variable_scope_spec.rb

@@ -12,11 +12,11 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(2).in_column(18)
     end
   end
@@ -30,7 +30,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -45,7 +45,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -64,7 +64,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -79,7 +79,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -93,7 +93,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -107,11 +107,11 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(2).in_column(18)
     end
   end
@@ -125,7 +125,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -142,7 +142,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -158,7 +158,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -180,11 +180,11 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should only detect two problems' do
+    it 'only detects two problems' do
       expect(problems).to have(2).problem
     end
 
-    it 'should create two warnings' do
+    it 'creates two warnings' do
       expect(problems).to contain_warning(msg).on_line(7).in_column(11)
       expect(problems).to contain_warning(msg).on_line(5).in_column(13)
     end
@@ -212,18 +212,18 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should only detect three problems' do
+    it 'only detects three problems' do
       expect(problems).to have(3).problem
     end
 
-    it 'should create three warnings' do
+    it 'creates three warnings' do
       expect(problems).to contain_warning(msg).on_line(7).in_column(13)
       expect(problems).to contain_warning(msg).on_line(12).in_column(15)
       expect(problems).to contain_warning(msg).on_line(14).in_column(13)
     end
   end
 
-  %w[alias audit before loglevel noop notify require schedule stage subscribe tag].each do |metaparam|
+  ['alias', 'audit', 'before', 'loglevel', 'noop', 'notify', 'require', 'schedule', 'stage', 'subscribe', 'tag'].each do |metaparam|
     context "referencing #{metaparam} metaparam value as a variable" do
       let(:code) do
         <<-END
@@ -233,7 +233,7 @@ describe 'variable_scope' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -250,7 +250,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -264,7 +264,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -278,7 +278,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -293,7 +293,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -308,11 +308,11 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should only detect one problem' do
+    it 'only detects one problem' do
       expect(problems).to have(1).problems
     end
 
-    it 'should create one warning' do
+    it 'creates one warning' do
       expect(problems).to contain_warning(msg).on_line(2).in_column(14)
     end
   end
@@ -326,7 +326,7 @@ describe 'variable_scope' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_comments/slash_comments_spec.rb

@@ -7,37 +7,37 @@ describe 'slash_comments' do
     context 'slash comments' do
       let(:code) { '// foo' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(1)
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
     context 'slash comments' do
       let(:code) { '// foo' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(1)
       end
 
-      it 'should replace the double slash with a hash' do
+      it 'replaces the double slash with a hash' do
         expect(manifest).to eq('# foo')
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_comments/star_comments_spec.rb

@@ -12,22 +12,22 @@ describe 'star_comments' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(11)
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
@@ -48,15 +48,15 @@ describe 'star_comments' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(1)
       end
 
-      it 'should convert the multiline comment' do
+      it 'converts the multiline comment' do
         expect(manifest).to eq(fixed)
       end
     end
@@ -75,15 +75,15 @@ describe 'star_comments' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(11)
       end
 
-      it 'should convert the multiline comment' do
+      it 'converts the multiline comment' do
         expect(manifest).to eq(fixed)
       end
     end
@@ -108,15 +108,15 @@ describe 'star_comments' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(11)
       end
 
-      it 'should convert the multiline comment' do
+      it 'converts the multiline comment' do
         expect(manifest).to eq(fixed)
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_conditionals/case_without_default_spec.rb

@@ -13,7 +13,7 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -28,11 +28,11 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(9)
     end
   end
@@ -49,11 +49,11 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg)
     end
   end
@@ -73,11 +73,11 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should detect two problems' do
+    it 'detects two problems' do
       expect(problems).to have(2).problems
     end
 
-    it 'should create two warnings' do
+    it 'creates two warnings' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(9)
       expect(problems).to contain_warning(msg).on_line(4).in_column(13)
     end
@@ -101,7 +101,7 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -120,7 +120,7 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should create one warning' do
+    it 'creates one warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(9)
     end
   end
@@ -140,7 +140,7 @@ describe 'case_without_default' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_conditionals/selector_inside_resource_spec.rb

@@ -15,11 +15,11 @@ describe 'selector_inside_resource' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(2).in_column(18)
     end
   end
@@ -33,7 +33,7 @@ describe 'selector_inside_resource' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_documentation/documentation_spec.rb

@@ -7,11 +7,11 @@ describe 'documentation' do
   describe 'undocumented class' do
     let(:code) { 'class test {}' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(class_msg).on_line(1).in_column(1)
     end
   end
@@ -24,7 +24,7 @@ describe 'documentation' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -38,11 +38,11 @@ describe 'documentation' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(class_msg).on_line(3).in_column(9)
     end
   end
@@ -50,11 +50,11 @@ describe 'documentation' do
   describe 'undocumented defined type' do
     let(:code) { 'define test {}' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(define_msg).on_line(1).in_column(1)
     end
   end
@@ -67,7 +67,7 @@ describe 'documentation' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_nodes/unquoted_node_name_spec.rb

@@ -7,11 +7,11 @@ describe 'unquoted_node_name' do
     context 'unquoted node name' do
       let(:code) { 'node foo { }' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(6)
       end
     end
@@ -19,7 +19,7 @@ describe 'unquoted_node_name' do
     context 'default node' do
       let(:code) { 'node default { }' }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -27,7 +27,7 @@ describe 'unquoted_node_name' do
     context 'single quoted node name' do
       let(:code) { "node 'foo' { }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -35,7 +35,7 @@ describe 'unquoted_node_name' do
     context 'regex node name' do
       let(:code) { 'node /foo/ { }' }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -43,11 +43,11 @@ describe 'unquoted_node_name' do
     context 'multiple bare node names' do
       let(:code) { 'node foo, bar, baz { }' }
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problems
       end
 
-      it 'should create 3 warnings' do
+      it 'creates 3 warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(6)
         expect(problems).to contain_warning(msg).on_line(1).in_column(11)
         expect(problems).to contain_warning(msg).on_line(1).in_column(16)
@@ -57,11 +57,11 @@ describe 'unquoted_node_name' do
     context 'mixed node name types' do
       let(:code) { "node foo, 'bar', baz { }" }
 
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problems
       end
 
-      it 'should create 2 warnings' do
+      it 'creates 2 warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(6)
         expect(problems).to contain_warning(msg).on_line(1).in_column(18)
       end
@@ -70,11 +70,11 @@ describe 'unquoted_node_name' do
     context 'multiple node blocks' do
       let(:code) { 'node foo { } node bar { }' }
 
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problems
       end
 
-      it 'should create 2 warnings' do
+      it 'creates 2 warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(6)
         expect(problems).to contain_warning(msg).on_line(1).in_column(19)
       end
@@ -83,37 +83,37 @@ describe 'unquoted_node_name' do
     context 'incomplete node block' do
       let(:code) { 'node foo' }
 
-      it 'should detect a problem' do
+      it 'detects a problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create 1 error' do
+      it 'creates 1 error' do
         expect(problems).to contain_error('Syntax error (try running `puppet parser validate <file>`)').on_line(1).in_column(1)
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
     context 'unquoted node name' do
       let(:code) { 'node foo { }' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(6)
       end
 
-      it 'should quote the node name' do
+      it 'quotes the node name' do
         expect(manifest).to eq("node 'foo' { }")
       end
     end
@@ -122,17 +122,17 @@ describe 'unquoted_node_name' do
       let(:code) { 'node foo, bar, baz { }' }
       let(:fixed) { "node 'foo', 'bar', 'baz' { }" }
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problems
       end
 
-      it 'should fix the 3 problems' do
+      it 'fixes the 3 problems' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(6)
         expect(problems).to contain_fixed(msg).on_line(1).in_column(11)
         expect(problems).to contain_fixed(msg).on_line(1).in_column(16)
       end
 
-      it 'should quote all three node names' do
+      it 'quotes all three node names' do
         expect(manifest).to eq(fixed)
       end
     end
@@ -141,16 +141,16 @@ describe 'unquoted_node_name' do
       let(:code) { "node foo, 'bar', baz { }" }
       let(:fixed) { "node 'foo', 'bar', 'baz' { }" }
 
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problems
       end
 
-      it 'should fix the 2 problems' do
+      it 'fixes the 2 problems' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(6)
         expect(problems).to contain_fixed(msg).on_line(1).in_column(18)
       end
 
-      it 'should quote the 2 unquoted node names' do
+      it 'quotes the 2 unquoted node names' do
         expect(manifest).to eq(fixed)
       end
     end