puppet-lint-manifest_whitespace-check 0.2.8 → 0.3.0

data/spec/puppet-lint/plugins/manifest_whitespace_opening_brace_spec.rb

@@ -5,76 +5,102 @@ require 'spec_helper'
 describe 'manifest_whitespace_opening_brace_before' do
   let(:opening_brace_msg) { 'there should be a single space before an opening brace' }
 
+  context 'parameters without space' do
+    let(:code) do
+      <<~CODE
+        $foo = lookup('foo::bar',Hash,'first',{})
+      CODE
+    end
+
+    it 'detects a problem' do
+      expect(problems).not_to be_empty
+    end
+  end
+
   context 'with comment only' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         $value7 = {
           # nothing
         }
-      EOF
+      CODE
+    end
+
+    it 'detects no problems' do
+      expect(problems).to be_empty
+    end
+  end
+
+  context 'with an iterator' do
+    let(:code) do
+      <<~CODE
+        $slave_ifnames = $bonds.reduce({}) |$l, $i| {
+          $l + split($i['attached_devices'], /,/).reduce({}) |$sl, $d| { $sl + { $d => $i['identifier'] } }
+        }
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'inside, inline with function' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         $sssd_config = {
-        ▏ 'sssd' => merge($config, {
-        ▏ ▏ ▏ 'domains'  => $domains,
-        ▏ ▏ ▏ 'services' => 'nss,pam',
-        ▏ }),
+          'sssd' => merge($config, {
+             'domains'  => $domains,
+             'services' => 'nss,pam',
+          }),
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'inside interpolation' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         my_define { "foo-${myvar}": }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'inline with a function before' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         Hash( { $key => $return_value })
-      EOF
+      CODE
     end
 
-    it 'should detect 1 problem' do
+    it 'detects 1 problem' do
       expect(problems).to have(1).problem
     end
   end
 
   context 'inline with a function' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         Hash({ $key => $return_value })
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'inside a function' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         $my_var = lookup(
           {
             'name'          => 'my_module::my_var',
@@ -83,44 +109,44 @@ describe 'manifest_whitespace_opening_brace_before' do
             'default_value' => [],
           }
         )
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with cases' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         case $facts['kernel'] {
           'OpenBSD': { $has_wordexp = false }
           default:   { $has_wordexp = true }
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with class no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         class example{
           # some generic comment
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a problem' do
+      it 'detects a problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(1).in_column(14)
       end
     end
@@ -134,13 +160,13 @@ describe 'manifest_whitespace_opening_brace_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should add a space' do
+      it 'adds a space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             class example {
               # some generic comment
             }
-          EOF
+          CODE
         )
       end
     end
@@ -148,7 +174,7 @@ describe 'manifest_whitespace_opening_brace_before' do
 
   context 'with no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -181,15 +207,15 @@ describe 'manifest_whitespace_opening_brace_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect three problems' do
+      it 'detects three problems' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(8).in_column(2)
       end
     end
@@ -203,17 +229,17 @@ describe 'manifest_whitespace_opening_brace_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect three problems' do
+      it 'detects three problems' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_brace_msg)
       end
 
-      it 'should add spaces' do
+      it 'adds spaces' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -246,7 +272,7 @@ describe 'manifest_whitespace_opening_brace_before' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -254,7 +280,7 @@ describe 'manifest_whitespace_opening_brace_before' do
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -281,15 +307,15 @@ describe 'manifest_whitespace_opening_brace_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(8).in_column(4)
       end
     end
@@ -303,17 +329,17 @@ describe 'manifest_whitespace_opening_brace_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_brace_msg)
       end
 
-      it 'should remove a space' do
+      it 'removes a space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -340,7 +366,7 @@ describe 'manifest_whitespace_opening_brace_before' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -348,7 +374,7 @@ describe 'manifest_whitespace_opening_brace_before' do
 
   context 'with newline' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -378,15 +404,15 @@ describe 'manifest_whitespace_opening_brace_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(9).in_column(1)
       end
     end
@@ -400,17 +426,17 @@ describe 'manifest_whitespace_opening_brace_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_brace_msg)
       end
 
-      it 'should fix the newline' do
+      it 'fixes the newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -437,7 +463,7 @@ describe 'manifest_whitespace_opening_brace_before' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -445,7 +471,7 @@ describe 'manifest_whitespace_opening_brace_before' do
 
   context 'with comment' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -474,11 +500,11 @@ describe 'manifest_whitespace_opening_brace_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to be_empty
       end
     end
@@ -486,7 +512,7 @@ describe 'manifest_whitespace_opening_brace_before' do
 
   context 'with good inherits' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -513,11 +539,11 @@ describe 'manifest_whitespace_opening_brace_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect no problem' do
+      it 'detects no problem' do
         expect(problems).to be_empty
       end
     end
@@ -525,7 +551,7 @@ describe 'manifest_whitespace_opening_brace_before' do
 
   context 'with bad inherits' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -552,15 +578,15 @@ describe 'manifest_whitespace_opening_brace_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(8).in_column(22)
       end
     end
@@ -574,13 +600,13 @@ describe 'manifest_whitespace_opening_brace_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a missing space' do
+      it 'detects a missing space' do
         expect(problems).to have(1).problem
       end
 
-      it 'should add the space' do
+      it 'adds the space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -607,7 +633,7 @@ describe 'manifest_whitespace_opening_brace_before' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -619,7 +645,7 @@ describe 'manifest_whitespace_opening_brace_after' do
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -652,15 +678,15 @@ describe 'manifest_whitespace_opening_brace_after' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(9).in_column(14)
       end
     end
@@ -674,17 +700,17 @@ describe 'manifest_whitespace_opening_brace_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_brace_msg)
       end
 
-      it 'should add spaces' do
+      it 'adds spaces' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -717,7 +743,7 @@ describe 'manifest_whitespace_opening_brace_after' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -725,7 +751,7 @@ describe 'manifest_whitespace_opening_brace_after' do
 
   context 'with no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -752,15 +778,15 @@ describe 'manifest_whitespace_opening_brace_after' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(9).in_column(14)
       end
     end
@@ -774,17 +800,17 @@ describe 'manifest_whitespace_opening_brace_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect 2 problems' do
+      it 'detects 2 problems' do
         expect(problems).to have(2).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_brace_msg)
       end
 
-      it 'should add spaces' do
+      it 'adds spaces' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -811,7 +837,7 @@ describe 'manifest_whitespace_opening_brace_after' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -819,7 +845,7 @@ describe 'manifest_whitespace_opening_brace_after' do
 
   context 'with two newlines' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -851,15 +877,15 @@ describe 'manifest_whitespace_opening_brace_after' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 4 problems' do
+      it 'detects 4 problems' do
         expect(problems).to have(4).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_brace_msg).on_line(9).in_column(1)
       end
     end
@@ -873,17 +899,17 @@ describe 'manifest_whitespace_opening_brace_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect 4 problems' do
+      it 'detects 4 problems' do
         expect(problems).to have(4).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_brace_msg)
       end
 
-      it 'should add spaces' do
+      it 'adds spaces' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -911,7 +937,7 @@ describe 'manifest_whitespace_opening_brace_after' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end