puppet-lint-manifest_whitespace-check 0.2.8 → 0.3.0

data/spec/puppet-lint/plugins/manifest_whitespace_class_header_spec.rb

@@ -3,13 +3,13 @@
 require 'spec_helper'
 
 describe 'manifest_whitespace_class_name_single_space_before' do
-  let(:single_space_msg) {
+  let(:single_space_msg) do
     'there should be a single space between the class or defined resource statement and the name'
-  }
+  end
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -20,15 +20,15 @@ describe 'manifest_whitespace_class_name_single_space_before' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(6)
       end
     end
@@ -42,17 +42,17 @@ describe 'manifest_whitespace_class_name_single_space_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the space' do
+      it 'fixes the space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -63,7 +63,7 @@ describe 'manifest_whitespace_class_name_single_space_before' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -74,7 +74,7 @@ describe 'manifest_whitespace_class_name_single_space_before' do
       'class example inherits otherexample {'
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
@@ -85,21 +85,21 @@ describe 'manifest_whitespace_class_name_single_space_after' do
 
   context 'with inherits' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         class example inherits otherexample {
           assert_private()
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with parameters and no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -112,15 +112,15 @@ describe 'manifest_whitespace_class_name_single_space_after' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(7)
       end
     end
@@ -134,17 +134,17 @@ describe 'manifest_whitespace_class_name_single_space_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the newline' do
+      it 'fixes the newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -157,7 +157,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -165,7 +165,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
 
   context 'with scope and no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -176,15 +176,15 @@ describe 'manifest_whitespace_class_name_single_space_after' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(7)
       end
     end
@@ -198,17 +198,17 @@ describe 'manifest_whitespace_class_name_single_space_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the newline' do
+      it 'fixes the newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -219,7 +219,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -227,7 +227,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
 
   context 'with no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -238,15 +238,15 @@ describe 'manifest_whitespace_class_name_single_space_after' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(7)
       end
     end
@@ -260,17 +260,17 @@ describe 'manifest_whitespace_class_name_single_space_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the newline' do
+      it 'fixes the newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -281,7 +281,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -289,7 +289,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -300,15 +300,15 @@ describe 'manifest_whitespace_class_name_single_space_after' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(7)
       end
     end
@@ -322,17 +322,17 @@ describe 'manifest_whitespace_class_name_single_space_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the space' do
+      it 'fixes the space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -343,7 +343,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -351,7 +351,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
 
   context 'with newline' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -365,15 +365,15 @@ describe 'manifest_whitespace_class_name_single_space_after' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(7)
       end
     end
@@ -387,17 +387,17 @@ describe 'manifest_whitespace_class_name_single_space_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the newline' do
+      it 'fixes the newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -408,7 +408,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -416,7 +416,7 @@ describe 'manifest_whitespace_class_name_single_space_after' do
 
   context 'with comment' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -428,10 +428,10 @@ describe 'manifest_whitespace_class_name_single_space_after' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to be_empty
     end
   end

data/spec/puppet-lint/plugins/manifest_whitespace_class_inherits_spec.rb

@@ -7,7 +7,7 @@ describe 'manifest_whitespace_inherits_name_single_space_before' do
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -18,15 +18,15 @@ describe 'manifest_whitespace_inherits_name_single_space_before' do
             param1 => 'value1',
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(6).in_column(23)
       end
     end
@@ -40,17 +40,17 @@ describe 'manifest_whitespace_inherits_name_single_space_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the space' do
+      it 'fixes the space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -61,7 +61,7 @@ describe 'manifest_whitespace_inherits_name_single_space_before' do
                 param1 => 'value1',
               }
             }
-          EOF
+          CODE
         )
       end
     end