puppet-lint-manifest_whitespace-check 0.2.8 → 0.3.0

data/spec/puppet-lint/plugins/manifest_whitespace_double_newline_end_of_file_spec.rb

@@ -3,9 +3,11 @@
 require 'spec_helper'
 
 describe 'manifest_whitespace_double_newline_end_of_file' do
+  let(:single_newline_end_of_file_msg) { 'there should be a single newline at the end of a manifest' }
+
   context 'with good example' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         class example (
 
 
@@ -14,51 +16,49 @@ describe 'manifest_whitespace_double_newline_end_of_file' do
 
 
         }
-      EOF
+      CODE
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to be_empty
     end
   end
 
-  let(:single_newline_end_of_file_msg) { 'there should be a single newline at the end of a manifest' }
-
   context 'with fix disabled' do
     context 'with 1 empty line at the end of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
           class example {
           }
 
-        EOF
+        CODE
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_newline_end_of_file_msg).on_line(3).in_column(1)
       end
     end
 
     context 'with 3 empty lines at the end of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
           class example {
           }
 
 
 
-        EOF
+        CODE
       end
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_newline_end_of_file_msg).on_line(3).in_column(1)
         expect(problems).to contain_error(single_newline_end_of_file_msg).on_line(4).in_column(1)
         expect(problems).to contain_error(single_newline_end_of_file_msg).on_line(5).in_column(1)
@@ -77,58 +77,58 @@ describe 'manifest_whitespace_double_newline_end_of_file' do
 
     context 'with 1 empty line at the end of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
           class example {
           }
 
-        EOF
+        CODE
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_newline_end_of_file_msg).on_line(3).in_column(1)
       end
 
-      it 'should add the final newline' do
+      it 'adds the final newline' do
         expect(manifest).to eq(
-          <<~EOF
+          <<~CODE,
             class example {
             }
-          EOF
+          CODE
         )
       end
     end
 
     context 'with 3 empty lines at the end of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
           class example {
           }
 
 
 
-        EOF
+        CODE
       end
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_newline_end_of_file_msg).on_line(3).in_column(1)
         expect(problems).to contain_fixed(single_newline_end_of_file_msg).on_line(4).in_column(1)
         expect(problems).to contain_fixed(single_newline_end_of_file_msg).on_line(5).in_column(1)
       end
 
-      it 'should add the final newline' do
+      it 'adds the final newline' do
         expect(manifest).to eq(
-          <<~EOF
+          <<~CODE,
             class example {
             }
-          EOF
+          CODE
         )
       end
     end

data/spec/puppet-lint/plugins/manifest_whitespace_double_newline_spec.rb

@@ -7,22 +7,22 @@ describe 'manifest_whitespace_two_empty_lines' do
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         class { 'example2':
           param1 => 'value1',
 
 
           param2 => 'value2',
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_space_msg).on_line(4).in_column(1)
       end
     end
@@ -36,23 +36,23 @@ describe 'manifest_whitespace_two_empty_lines' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_space_msg)
       end
 
-      it 'should fix the space' do
+      it 'fixes the space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             class { 'example2':
               param1 => 'value1',
 
               param2 => 'value2',
             }
-          EOF
+          CODE
         )
       end
     end

data/spec/puppet-lint/plugins/manifest_whitespace_missing_newline_end_of_file_spec.rb

@@ -11,11 +11,11 @@ describe 'manifest_whitespace_missing_newline_end_of_file' do
         'class example { }'
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_newline_end_of_file_msg).on_line(1).in_column(17)
       end
     end
@@ -35,17 +35,32 @@ describe 'manifest_whitespace_missing_newline_end_of_file' do
         'class example { }'
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_newline_end_of_file_msg).on_line(1).in_column(17)
       end
 
-      it 'should add the final newline' do
+      it 'adds the final newline' do
         expect(manifest).to eq("class example { }\n")
       end
     end
+
+    context 'inside heredoc' do
+      let(:code) do
+        <<~CODE
+          $value = @("END_OF_HD")
+            SomeData
+          | - END_OF_HD
+          $other_value = 5
+        CODE
+      end
+
+      it 'detects no problems' do
+        expect(problems).to be_empty
+      end
+    end
   end
 end

data/spec/puppet-lint/plugins/manifest_whitespace_newline_begin_of_file_spec.rb

@@ -7,7 +7,7 @@ describe 'manifest_whitespace_newline_beginning_of_file' do
 
   context 'with good example' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         class example (
 
 
@@ -16,10 +16,10 @@ describe 'manifest_whitespace_newline_beginning_of_file' do
 
 
         }
-      EOF
+      CODE
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to be_empty
     end
   end
@@ -27,38 +27,38 @@ describe 'manifest_whitespace_newline_beginning_of_file' do
   context 'with fix disabled' do
     context 'with 1 empty line at the beginning of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
 
           class example {
           }
-        EOF
+        CODE
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_beginning_of_file_msg).on_line(1).in_column(1)
       end
     end
 
     context 'with 3 empty lines at the beginning of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
 
 
 
           class example {
           }
-        EOF
+        CODE
       end
 
-      it 'should detect 3 problems' do
+      it 'detects 3 problems' do
         expect(problems).to have(3).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(single_beginning_of_file_msg).on_line(1).in_column(1)
         expect(problems).to contain_error(single_beginning_of_file_msg).on_line(2).in_column(1)
         expect(problems).to contain_error(single_beginning_of_file_msg).on_line(3).in_column(1)
@@ -77,58 +77,58 @@ describe 'manifest_whitespace_newline_beginning_of_file' do
 
     context 'with 1 empty line at the beginning of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
 
           class example {
           }
-        EOF
+        CODE
       end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_beginning_of_file_msg).on_line(1).in_column(1)
       end
 
-      it 'should add the final newline' do
+      it 'adds the final newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             class example {
             }
-          EOF
+          CODE
         )
       end
     end
 
     context 'with 3 empty lines at the beginning of a manifest' do
       let(:code) do
-        <<~EOF
+        <<~CODE
 
 
 
           class example {
           }
-        EOF
+        CODE
       end
 
-      it 'should detect 3 problem' do
+      it 'detects 3 problem' do
         expect(problems).to have(3).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(single_beginning_of_file_msg).on_line(1).in_column(1)
         expect(problems).to contain_fixed(single_beginning_of_file_msg).on_line(2).in_column(1)
         expect(problems).to contain_fixed(single_beginning_of_file_msg).on_line(3).in_column(1)
       end
 
-      it 'should add the final newline' do
+      it 'adds the final newline' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             class example {
             }
-          EOF
+          CODE
         )
       end
     end