patient_http-sidekiq 1.2.0 → 1.4.0

data/lib/patient_http/sidekiq/web_ui/views/patient_http.html.erb

@@ -31,60 +31,115 @@
             <span><%= avg_duration %></span>
           </div>
         </div>
+        <div class="stat-card">
+          <div class="stat-label"><%= t('patient_http_max_capacity') %></div>
+          <div class="stat-value"><%= number_with_delimiter(max_capacity) %></div>
+        </div>
+        <div class="stat-card">
+          <div class="stat-label"><%= t('patient_http_currently_inflight') %></div>
+          <div class="stat-value"><%= number_with_delimiter(current_inflight) %></div>
+        </div>
+        <div class="stat-card">
+          <div class="stat-label"><%= t('patient_http_capacity_utilization') %></div>
+          <div class="stat-value"><%= utilization %>%</div>
+        </div>
       </div>
 
-      <!-- Capacity Information -->
-      <div class="capacity-section">
-        <h3><%= t('patient_http_connection_capacity') %></h3>
-        <div class="capacity-cards">
-          <div class="capacity-card">
-            <div class="capacity-label"><%= t('patient_http_max_capacity') %></div>
-            <div class="capacity-value"><%= number_with_delimiter(max_capacity) %></div>
-            <div class="capacity-unit"><%= t('patient_http_connections') %></div>
-          </div>
-          <div class="capacity-card">
-            <div class="capacity-label"><%= t('patient_http_currently_inflight') %></div>
-            <div class="capacity-value"><%= number_with_delimiter(current_inflight) %></div>
-            <div class="capacity-unit"><%= t('patient_http_requests') %></div>
-          </div>
-          <div class="capacity-card">
-            <div class="capacity-label"><%= t('patient_http_capacity_utilization') %></div>
-            <div class="capacity-value"><%= utilization %>%</div>
-            <div class="capacity-unit"><%= t('patient_http_used') %></div>
+      <!-- Processor Breakdown -->
+      <% unless processors.empty? %>
+        <div class="breakdown-section">
+          <h3><%= t('patient_http_processors') %></h3>
+          <div class="table-scroll">
+            <table class="table">
+              <thead>
+                <tr>
+                  <th><%= t('patient_http_processor') %></th>
+                  <th><%= t('patient_http_inflight') %></th>
+                  <th><%= t('patient_http_peak_inflight') %></th>
+                  <th><%= t('patient_http_max_capacity') %></th>
+                  <th><%= t('patient_http_utilization') %></th>
+                  <th><%= t('patient_http_total_requests') %></th>
+                  <th><%= t('patient_http_errors') %></th>
+                  <th><%= t('patient_http_max_capacity_exceeded') %></th>
+                  <th><%= t('patient_http_avg_duration') %></th>
+                </tr>
+              </thead>
+              <tbody>
+                <% processors.each do |processor| %>
+                  <tr>
+                    <td><%= h(processor[:name]) %></td>
+                    <td><%= number_with_delimiter(processor[:inflight]) %></td>
+                    <td><%= number_with_delimiter(processor[:peak_inflight]) %></td>
+                    <td><%= number_with_delimiter(processor[:max_capacity]) %></td>
+                    <td><%= processor[:utilization] %>%</td>
+                    <td><%= number_with_delimiter(processor[:requests]) %></td>
+                    <td><%= number_with_delimiter(processor[:errors]) %></td>
+                    <td><%= number_with_delimiter(processor[:max_capacity_exceeded]) %></td>
+                    <td><%= processor[:avg_duration] %></td>
+                  </tr>
+                <% end %>
+              </tbody>
+            </table>
           </div>
         </div>
+      <% end %>
 
-        <!-- Process Breakdown -->
-        <div class="process-breakdown">
-          <h4><%= t('patient_http_per_process_details') %></h4>
-          <table class="table">
-            <thead>
-              <tr>
-                <th><%= t('patient_http_process') %></th>
-                <th><%= t('patient_http_inflight') %></th>
-                <th><%= t('patient_http_max_capacity') %></th>
-                <th><%= t('patient_http_utilization') %></th>
-              </tr>
-            </thead>
-            <tbody>
-              <% if processes.empty? %>
-                <tr class="empty-state">
-                  <td colspan="4"><%= t('patient_http_no_active_processes') %></td>
+      <!-- In-Flight Requests -->
+      <% unless inflight.empty? %>
+        <div class="breakdown-section">
+          <h3><%= t('patient_http_inflight_requests') %></h3>
+          <div class="table-scroll">
+            <table class="table">
+              <thead>
+                <tr>
+                  <th><%= t('patient_http_age') %></th>
+                  <th><%= t('patient_http_method') %></th>
+                  <th><%= t('patient_http_url') %></th>
+                  <th><%= t('patient_http_processor') %></th>
+                  <th><%= t('patient_http_process') %></th>
                 </tr>
-              <% else %>
-                <% processes.each do |process_id, info| %>
-                  <% utilization = info[:max_capacity] > 0 ? (info[:inflight].to_f / info[:max_capacity] * 100).round(1) : 0 %>
+              </thead>
+              <tbody>
+                <% inflight.each do |request| %>
                   <tr>
-                    <td><%= h(process_id) %></td>
-                    <td><%= number_with_delimiter(info[:inflight]) %></td>
-                    <td><%= number_with_delimiter(info[:max_capacity]) %></td>
-                    <td><%= utilization %>%</td>
+                    <td><%= request[:age] %></td>
+                    <td><%= h(request[:http_method].to_s.upcase) %></td>
+                    <td class="url"><%= h(request[:url]) %></td>
+                    <td><%= h(request[:processor]) %></td>
+                    <td><%= h(request[:process_id]) %></td>
                   </tr>
                 <% end %>
-              <% end %>
-            </tbody>
-          </table>
+              </tbody>
+            </table>
+          </div>
         </div>
+      <% end %>
+
+      <!-- Sidekiq Process Breakdown -->
+      <div class="breakdown-section">
+        <h3><%= t('patient_http_sidekiq_processes') %></h3>
+        <table class="table">
+          <thead>
+            <tr>
+              <th><%= t('patient_http_process') %></th>
+              <th><%= t('patient_http_inflight') %></th>
+            </tr>
+          </thead>
+          <tbody>
+            <% if processes.empty? %>
+              <tr class="empty-state">
+                <td colspan="2"><%= t('patient_http_no_active_processes') %></td>
+              </tr>
+            <% else %>
+              <% processes.each do |process_id, info| %>
+                <tr>
+                  <td><%= h(process_id) %></td>
+                  <td><%= number_with_delimiter(info[:inflight]) %></td>
+                </tr>
+              <% end %>
+            <% end %>
+          </tbody>
+        </table>
       </div>
 
       <!-- HTTP Status Codes Breakdown -->

data/lib/patient_http/sidekiq/web_ui.rb

@@ -20,6 +20,10 @@ module PatientHttp
       ROOT = File.join(__dir__, "web_ui")
       VIEWS = File.join(ROOT, "views")
 
+      # Number of in-flight requests listed on the dashboard. The oldest are
+      # listed, because those are the ones worth looking at.
+      INFLIGHT_LIMIT = 50
+
       class << self
         # Sidekiq resolves symbol view names to different file names depending
         # on the version (*.erb before 8.1, *.html.erb from 8.1 on), so the
@@ -28,6 +32,42 @@ module PatientHttp
           @template ||= File.read(File.join(VIEWS, "patient_http.html.erb"))
         end
 
+        # Build the per-processor rows for the dashboard by combining the
+        # cumulative counters with the live capacity each processor reports.
+        #
+        # Statistics are not recorded per processor when only one is
+        # configured, because they would duplicate the overall totals, so the
+        # breakdown is empty in that case.
+        #
+        # @param stats_by_processor [Hash, nil] cumulative counters by processor name
+        # @param capacity_by_processor [Hash] inflight and capacity by processor name
+        # @return [Array<Hash>] one row per processor, sorted by name
+        def processor_rows(stats_by_processor, capacity_by_processor)
+          stats_by_processor ||= {}
+          return [] if stats_by_processor.empty? && capacity_by_processor.size < 2
+
+          names = (stats_by_processor.keys | capacity_by_processor.keys).sort
+          names.map do |name|
+            counts = stats_by_processor[name] || {}
+            capacity = capacity_by_processor[name] || {}
+            requests = counts["requests"].to_i
+            max_capacity = capacity[:max_capacity].to_i
+            inflight = capacity[:inflight].to_i
+
+            {
+              name: name,
+              inflight: inflight,
+              peak_inflight: counts["max_inflight"].to_i,
+              max_capacity: max_capacity,
+              utilization: (max_capacity > 0) ? (inflight.to_f / max_capacity * 100).round(1) : 0,
+              requests: requests,
+              errors: counts["errors"].to_i,
+              max_capacity_exceeded: counts["max_capacity_exceeded"].to_i,
+              avg_duration: (requests > 0) ? (counts["duration"].to_f / requests).round(3) : 0.0
+            }
+          end
+        end
+
         # This method is called by Sidekiq::Web when registering the extension
         def registered(app)
           # GET route for the main PatientHttp dashboard page
@@ -47,6 +87,16 @@ module PatientHttp
             current_inflight = processes.values.sum { |data| data[:inflight] }
             utilization = (max_capacity > 0) ? (current_inflight.to_f / max_capacity * 100).round(1) : 0
 
+            # Per-processor breakdown, combining the cumulative counters with
+            # the capacity each processor reports.
+            processors = PatientHttp::Sidekiq::WebUI.processor_rows(
+              totals["processors"],
+              PatientHttp::Sidekiq::TaskMonitor.inflight_counts_by_processor(processes)
+            )
+
+            # The requests that have been in flight the longest.
+            inflight = PatientHttp::Sidekiq::TaskMonitor.inflight_details(limit: INFLIGHT_LIMIT)
+
             erb(PatientHttp::Sidekiq::WebUI.template, locals: {
               totals: totals,
               total_requests: total_requests,
@@ -54,7 +104,9 @@ module PatientHttp
               max_capacity: max_capacity,
               current_inflight: current_inflight,
               utilization: utilization,
-              processes: processes
+              processes: processes,
+              processors: processors,
+              inflight: inflight
             })
           end