openstudio-standards 0.8.5 → 0.8.7

data/lib/openstudio-standards/standards/necb/NECB2011/qaqc/necb_qaqc.rb

@@ -300,7 +300,7 @@ class NECB2011
         1 => province,
         2 => neb_fuel
       }
-      row = look_up_csv_data(neb_prices_csv_file_name, search_info)
+      row = BTAP::Data.look_up_csv_data(neb_prices_csv_file_name, search_info)
       neb_fuel_cost = row['2020']
       fuel_consumption_gj = 0.0
       if neb_fuel == 'Electricity' || neb_fuel == 'Natural Gas'
@@ -325,7 +325,7 @@ class NECB2011
     # Fuel cost based local utility rates
     costing_rownames = model.sqlFile.get.execAndReturnVectorOfString("SELECT RowName FROM TabularDataWithStrings WHERE ReportName='LEEDsummary' AND ReportForString='Entire Facility' AND TableName='EAp2-7. Energy Cost Summary' AND ColumnName='Total Energy Cost'")
     #==> ["Electricity", "Natural Gas", "Additional", "Total"]
-    costing_rownames = validate_optional(costing_rownames, model, 'N/A')
+    costing_rownames = BTAP::Data.validate_optional(costing_rownames, model, 'N/A')
     if costing_rownames != 'N/A'
       costing_rownames.each do |rowname|
         case rowname
@@ -418,22 +418,22 @@ class NECB2011
     qaqc[:service_water_heating] = {}
     qaqc[:service_water_heating][:total_nominal_occupancy] = -1
     # qaqc[:service_water_heating][:total_nominal_occupancy]=model.sqlFile().get().execAndReturnVectorOfDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='OutdoorAirSummary' AND ReportForString='Entire Facility' AND TableName='Average Outdoor Air During Occupied Hours' AND ColumnName='Nominal Number of Occupants'").get.inject(0, :+)
-    qaqc[:service_water_heating][:total_nominal_occupancy] = get_total_nominal_capacity(model)
+    qaqc[:service_water_heating][:total_nominal_occupancy] = BTAP::Data.get_total_nominal_capacity(model)
 
     qaqc[:service_water_heating][:electricity_per_year] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='AnnualBuildingUtilityPerformanceSummary' AND ReportForString='Entire Facility' AND TableName='End Uses' AND ColumnName='Electricity' AND RowName='Water Systems'")
-    qaqc[:service_water_heating][:electricity_per_year] = validate_optional(qaqc[:service_water_heating][:electricity_per_year], model, -1)
+    qaqc[:service_water_heating][:electricity_per_year] = BTAP::Data.validate_optional(qaqc[:service_water_heating][:electricity_per_year], model, -1)
 
     qaqc[:service_water_heating][:electricity_per_day] = qaqc[:service_water_heating][:electricity_per_year] / 365.5
     qaqc[:service_water_heating][:electricity_per_day_per_occupant] = qaqc[:service_water_heating][:electricity_per_day] / qaqc[:service_water_heating][:total_nominal_occupancy]
 
     qaqc[:service_water_heating][:natural_gas_per_year] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='AnnualBuildingUtilityPerformanceSummary' AND ReportForString='Entire Facility' AND TableName='End Uses' AND ColumnName='Natural Gas' AND RowName='Water Systems'")
-    qaqc[:service_water_heating][:natural_gas_per_year] = validate_optional(qaqc[:service_water_heating][:natural_gas_per_year], model, -1)
+    qaqc[:service_water_heating][:natural_gas_per_year] = BTAP::Data.validate_optional(qaqc[:service_water_heating][:natural_gas_per_year], model, -1)
 
     qaqc[:service_water_heating][:additional_fuel_per_year] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='AnnualBuildingUtilityPerformanceSummary' AND ReportForString='Entire Facility' AND TableName='End Uses' AND ColumnName='Additional Fuel' AND RowName='Water Systems'")
-    qaqc[:service_water_heating][:additional_fuel_per_year] = validate_optional(qaqc[:service_water_heating][:additional_fuel_per_year], model, -1)
+    qaqc[:service_water_heating][:additional_fuel_per_year] = BTAP::Data.validate_optional(qaqc[:service_water_heating][:additional_fuel_per_year], model, -1)
 
     qaqc[:service_water_heating][:water_m3_per_year] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='AnnualBuildingUtilityPerformanceSummary' AND ReportForString='Entire Facility' AND TableName='End Uses' AND ColumnName='Water' AND RowName='Water Systems'")
-    qaqc[:service_water_heating][:water_m3_per_year] = validate_optional(qaqc[:service_water_heating][:water_m3_per_year], model, -1)
+    qaqc[:service_water_heating][:water_m3_per_year] = BTAP::Data.validate_optional(qaqc[:service_water_heating][:water_m3_per_year], model, -1)
 
     qaqc[:service_water_heating][:water_m3_per_day] = qaqc[:service_water_heating][:water_m3_per_year] / 365.5
     qaqc[:service_water_heating][:water_m3_per_day_per_occupant] = qaqc[:service_water_heating][:water_m3_per_day] / qaqc[:service_water_heating][:total_nominal_occupancy]
@@ -636,7 +636,7 @@ class NECB2011
           error_warning << "space.spaceType.get.lights[0] is nil for Space:[#{space.name.get}] Space Type:[#{spaceinfo[:space_type_name]}]"
         else
           spaceinfo[:lighting_w_per_m2] = space.spaceType.get.lights[0].lightsDefinition.wattsperSpaceFloorArea # .get.round(3) unless space.spaceType.get.lights[0].nil?
-          spaceinfo[:lighting_w_per_m2] = validate_optional(spaceinfo[:lighting_w_per_m2], model, -1.0)
+          spaceinfo[:lighting_w_per_m2] = BTAP::Data.validate_optional(spaceinfo[:lighting_w_per_m2], model, -1.0)
           unless spaceinfo[:lighting_w_per_m2].nil?
             spaceinfo[:lighting_w_per_m2] = spaceinfo[:lighting_w_per_m2].round(3)
           end
@@ -655,7 +655,7 @@ class NECB2011
           spaceinfo[:waterUseEquipment] << waterUseEquipment_info
           waterUseEquipment_info[:peak_flow_rate] = space.waterUseEquipment[0].waterUseEquipmentDefinition.peakFlowRate
           waterUseEquipment_info[:peak_flow_rate_per_area] = waterUseEquipment_info[:peak_flow_rate] / space.floorArea
-          area_per_occ = space.spaceType.get.people[0].nil? ? 0.0 : validate_optional(space.spaceType.get.people[0].spaceFloorAreaPerPerson, model, -1.0)
+          area_per_occ = space.spaceType.get.people[0].nil? ? 0.0 : BTAP::Data.validate_optional(space.spaceType.get.people[0].spaceFloorAreaPerPerson, model, -1.0)
           #                             Watt per person =             m3/s/m3                * 1000W/kW * (specific heat * dT) * m2/person
           waterUseEquipment_info[:shw_watts_per_person] = waterUseEquipment_info[:peak_flow_rate_per_area] * 1000 * (4.19 * 44.4) * 1000 * area_per_occ
           # puts waterUseEquipment_info[:shw_watts_per_ponce the erson]
@@ -727,12 +727,12 @@ class NECB2011
       air_loop.thermalZones.sort.each do |zone|
         air_loop_info[:thermal_zones] << zone.name.get
         vbz = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='Standard62.1Summary' AND ReportForString='Entire Facility' AND TableName='Zone Ventilation Parameters' AND ColumnName='Breathing Zone Outdoor Airflow - Vbz' AND Units='m3/s' AND RowName='#{zone.name.get.to_s.upcase}' ")
-        vbz = validate_optional(vbz, model, 0)
+        vbz = BTAP::Data.validate_optional(vbz, model, 0)
         air_loop_info[:total_breathing_zone_outdoor_airflow_vbz] += vbz
         air_loop_info[:total_floor_area_served] += zone.floorArea * zone.multiplier.to_f
       end
       air_loop_info[:area_outdoor_air_rate_m3_per_s_m2] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='Standard62.1Summary' AND ReportForString='Entire Facility' AND TableName='System Ventilation Parameters' AND ColumnName='Area Outdoor Air Rate - Ra' AND Units='m3/s-m2' AND RowName='#{air_loop_info[:name].to_s.upcase}' ")
-      air_loop_info[:area_outdoor_air_rate_m3_per_s_m2] = validate_optional(air_loop_info[:area_outdoor_air_rate_m3_per_s_m2], model, -1.0)
+      air_loop_info[:area_outdoor_air_rate_m3_per_s_m2] = BTAP::Data.validate_optional(air_loop_info[:area_outdoor_air_rate_m3_per_s_m2], model, -1.0)
 
       air_loop_info[:outdoor_air_L_per_s] = -1.0
       unless air_loop_info[:area_outdoor_air_rate_m3_per_s_m2] == -1.0
@@ -757,7 +757,7 @@ class NECB2011
         air_loop_info[:supply_fan][:max_air_flow_rate_m3_per_s] = -1.0
 
         max_air_flow_info = model.sqlFile.get.execAndReturnVectorOfString("SELECT RowName FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Fans' AND ColumnName='Max Air Flow Rate' AND Units='m3/s' ")
-        max_air_flow_info = validate_optional(max_air_flow_info, model, 'N/A')
+        max_air_flow_info = BTAP::Data.validate_optional(max_air_flow_info, model, 'N/A')
         if max_air_flow_info == 'N/A'
           error_warning << "max_air_flow_info is nil because the following sql statement returned nil: RowName FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Fans' AND ColumnName='Max Air Flow Rate' AND Units='m3/s' "
         else
@@ -804,7 +804,7 @@ class NECB2011
           coil[:efficency] = gas.gasBurnerEfficiency
           # coil[:nominal_capacity]= gas.nominalCapacity()
           coil[:nominal_capacity] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Heating Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].to_s.upcase}'")
-          coil[:nominal_capacity] = validate_optional(coil[:nominal_capacity], model, -1.0)
+          coil[:nominal_capacity] = BTAP::Data.validate_optional(coil[:nominal_capacity], model, -1.0)
         end
         if supply_comp.to_CoilHeatingElectric.is_initialized
           coil = {}
@@ -813,7 +813,7 @@ class NECB2011
           coil[:name] = electric.name.get
           coil[:type] = 'Electric'
           coil[:nominal_capacity] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Heating Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].to_s.upcase}'")
-          coil[:nominal_capacity] = validate_optional(coil[:nominal_capacity], model, -1.0)
+          coil[:nominal_capacity] = BTAP::Data.validate_optional(coil[:nominal_capacity], model, -1.0)
         end
         if supply_comp.to_CoilHeatingWater.is_initialized
           coil = {}
@@ -822,7 +822,7 @@ class NECB2011
           coil[:name] = water.name.get
           coil[:type] = 'Water'
           coil[:nominal_capacity] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Heating Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].to_s.upcase}'")
-          coil[:nominal_capacity] = validate_optional(coil[:nominal_capacity], model, -1.0)
+          coil[:nominal_capacity] = BTAP::Data.validate_optional(coil[:nominal_capacity], model, -1.0)
         end
         if supply_comp.to_HeatExchangerAirToAirSensibleAndLatent.is_initialized
           heatExchanger = supply_comp.to_HeatExchangerAirToAirSensibleAndLatent.get
@@ -841,7 +841,7 @@ class NECB2011
           coil[:name] = single_speed.name.get
           coil[:cop] = single_speed.ratedCOP.to_f
           coil[:nominal_total_capacity_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Cooling Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].upcase}' ")
-          coil[:nominal_total_capacity_w] = validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
+          coil[:nominal_total_capacity_w] = BTAP::Data.validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
         end
         if supply_comp.to_CoilCoolingDXTwoSpeed.is_initialized
           coil = {}
@@ -851,7 +851,7 @@ class NECB2011
           coil[:cop_low] = two_speed.ratedLowSpeedCOP.to_f
           coil[:cop_high] = two_speed.ratedHighSpeedCOP.to_f
           coil[:nominal_total_capacity_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Cooling Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].upcase}' ")
-          coil[:nominal_total_capacity_w] = validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
+          coil[:nominal_total_capacity_w] = BTAP::Data.validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
         end
         if supply_comp.to_CoilCoolingWater.is_initialized
           coil = {}
@@ -859,9 +859,9 @@ class NECB2011
           coil_cooling_water = supply_comp.to_CoilCoolingWater.get
           coil[:name] = coil_cooling_water.name.get
           coil[:nominal_total_capacity_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Cooling Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].upcase}' ")
-          coil[:nominal_total_capacity_w] = validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
+          coil[:nominal_total_capacity_w] = BTAP::Data.validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
           coil[:nominal_sensible_heat_ratio] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Cooling Coils' AND ColumnName='Nominal Sensible Heat Ratio' AND RowName='#{coil[:name].upcase}' ")
-          coil[:nominal_sensible_heat_ratio] = validate_optional(coil[:nominal_sensible_heat_ratio], model, -1.0)
+          coil[:nominal_sensible_heat_ratio] = BTAP::Data.validate_optional(coil[:nominal_sensible_heat_ratio], model, -1.0)
         end
       end
       qaqc[:air_loops] << air_loop_info
@@ -892,11 +892,11 @@ class NECB2011
           pump_info[:name] = pump.name.get
           pump_info[:type] = 'Pump:ConstantSpeed'
           pump_info[:head_pa] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Pumps' AND ColumnName='Head' AND RowName='#{pump_info[:name].upcase}' ")
-          pump_info[:head_pa] = validate_optional(pump_info[:head_pa], model, -1.0)
+          pump_info[:head_pa] = BTAP::Data.validate_optional(pump_info[:head_pa], model, -1.0)
           pump_info[:water_flow_m3_per_s] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Pumps' AND ColumnName='Water Flow' AND RowName='#{pump_info[:name].upcase}' ")
-          pump_info[:water_flow_m3_per_s] = validate_optional(pump_info[:water_flow_m3_per_s], model, -1.0)
+          pump_info[:water_flow_m3_per_s] = BTAP::Data.validate_optional(pump_info[:water_flow_m3_per_s], model, -1.0)
           pump_info[:electric_power_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Pumps' AND ColumnName='Electric Power' AND RowName='#{pump_info[:name].upcase}' ")
-          pump_info[:electric_power_w] = validate_optional(pump_info[:electric_power_w], model, -1.0)
+          pump_info[:electric_power_w] = BTAP::Data.validate_optional(pump_info[:electric_power_w], model, -1.0)
           pump_info[:motor_efficency] = pump.motorEfficiency
         end
 
@@ -908,11 +908,11 @@ class NECB2011
           pump_info[:name] = pump.name.get
           pump_info[:type] = 'Pump:VariableSpeed'
           pump_info[:head_pa] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Pumps' AND ColumnName='Head' AND RowName='#{pump_info[:name].upcase}' ")
-          pump_info[:head_pa] = validate_optional(pump_info[:head_pa], model, -1.0)
+          pump_info[:head_pa] = BTAP::Data.validate_optional(pump_info[:head_pa], model, -1.0)
           pump_info[:water_flow_m3_per_s] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Pumps' AND ColumnName='Water Flow' AND RowName='#{pump_info[:name].upcase}' ")
-          pump_info[:water_flow_m3_per_s] = validate_optional(pump_info[:water_flow_m3_per_s], model, -1.0)
+          pump_info[:water_flow_m3_per_s] = BTAP::Data.validate_optional(pump_info[:water_flow_m3_per_s], model, -1.0)
           pump_info[:electric_power_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Pumps' AND ColumnName='Electric Power' AND RowName='#{pump_info[:name].upcase}' ")
-          pump_info[:electric_power_w] = validate_optional(pump_info[:electric_power_w], model, -1.0)
+          pump_info[:electric_power_w] = BTAP::Data.validate_optional(pump_info[:electric_power_w], model, -1.0)
           pump_info[:motor_efficency] = pump.motorEfficiency
         end
 
@@ -925,7 +925,7 @@ class NECB2011
           boiler_info[:type] = 'Boiler:HotWater'
           boiler_info[:fueltype] = boiler.fuelType
           boiler_info[:nominal_capacity] = boiler.nominalCapacity
-          boiler_info[:nominal_capacity] = validate_optional(boiler_info[:nominal_capacity], model, -1.0)
+          boiler_info[:nominal_capacity] = BTAP::Data.validate_optional(boiler_info[:nominal_capacity], model, -1.0)
         end
 
         # Collect ChillerElectricEIR
@@ -935,7 +935,7 @@ class NECB2011
           plant_loop_info[:chiller_electric_eir] << chiller_info
           chiller_info[:name] = chiller.name.get
           chiller_info[:type] = 'Chiller:Electric:EIR'
-          chiller_info[:reference_capacity] = validate_optional(chiller.referenceCapacity, model, -1.0)
+          chiller_info[:reference_capacity] = BTAP::Data.validate_optional(chiller.referenceCapacity, model, -1.0)
           chiller_info[:reference_leaving_chilled_water_temperature] = chiller.referenceLeavingChilledWaterTemperature
         end
 
@@ -946,7 +946,7 @@ class NECB2011
           plant_loop_info[:cooling_tower_single_speed] << coolingTower_info
           coolingTower_info[:name] = coolingTower.name.get
           coolingTower_info[:type] = 'CoolingTower:SingleSpeed'
-          coolingTower_info[:fan_power_at_design_air_flow_rate] = validate_optional(coolingTower.fanPoweratDesignAirFlowRate, model, -1.0)
+          coolingTower_info[:fan_power_at_design_air_flow_rate] = BTAP::Data.validate_optional(coolingTower.fanPoweratDesignAirFlowRate, model, -1.0)
 
         end
 
@@ -964,7 +964,7 @@ class NECB2011
 
       qaqc[:eplusout_err] = {}
       warnings = model.sqlFile.get.execAndReturnVectorOfString("SELECT ErrorMessage FROM Errors WHERE ErrorType='0' ")
-      warnings = validate_optional(warnings, model, 'N/A')
+      warnings = BTAP::Data.validate_optional(warnings, model, 'N/A')
       unless warnings == 'N/A'
         qaqc[:eplusout_err][:warnings] = model.sqlFile.get.execAndReturnVectorOfString("SELECT ErrorMessage FROM Errors WHERE ErrorType='0' ").get
         qaqc[:eplusout_err][:fatal] = model.sqlFile.get.execAndReturnVectorOfString("SELECT ErrorMessage FROM Errors WHERE ErrorType='2' ").get
@@ -1667,7 +1667,7 @@ class NECB2011
           spaces = zone.spaces()
           spaces.each do |z_space|
             spacetype = z_space.spaceType
-            spacetype = validate_optional(spacetype, model, nil)
+            spacetype = BTAP::Data.validate_optional(spacetype, model, nil)
             if spacetype.nil?
               qaqc[:warnings] << "[necb_murb_hrv_compliance] Space [#{z_space.name}] does not have a SpaceType"
             else
@@ -1911,37 +1911,4 @@ class NECB2011
 
     raise ArgumentError, "invalid value for #{varname}: #{value}"
   end
-
-  def look_up_csv_data(csv_fname, search_criteria)
-    options = { headers: :first_row,
-                converters: [:numeric] }
-    unless File.exist?(csv_fname)
-      raise "File: [#{csv_fname}] Does not exist"
-    end
-
-    # we'll save the matches here
-    matches = nil
-    # save a copy of the headers
-    headers = nil
-    CSV.open(csv_fname, 'r', **options) do |csv|
-      # Since CSV includes Enumerable we can use 'find_all'
-      # which will return all the elements of the Enumerble for
-      # which the block returns true
-
-      matches = csv.find_all do |row|
-        match = true
-        search_criteria.keys.each do |key|
-          match &&= (row[key].strip == search_criteria[key].strip)
-        end
-        match
-      end
-      headers = csv.headers
-    end
-    # puts matches
-    raise('More than one match') if matches.size > 1
-
-    puts "Zero matches found for [#{search_criteria}]" if matches.empty?
-    # return matches[0]
-    return matches[0]
-  end
 end

data/lib/openstudio-standards/standards/necb/NECB2011/service_water_heating.rb

@@ -250,10 +250,11 @@ class NECB2011
       space_peak_flow = 0
       data = nil
       space_type_name = space.spaceType.get.standardsSpaceType.get.to_s
+      space_type_building = space.spaceType.get.standardsBuildingType.get.to_s
       tank_temperature = 60
       # find the specific space_type properties from standard.json
       space_types_table.each do |space_type|
-        if (space_type['building_type'] + ' ' + space_type_name) == (space_type['building_type'] + ' ' + space_type['space_type'])
+        if (space_type_building + ' ' + space_type_name) == (space_type['building_type'] + ' ' + space_type['space_type'])
           break if space_type['necb_hvac_system_selection_type'] == '- undefined -'
           # If there is no service hot water load.. Don't bother adding anything.
           break if (space_type['service_water_heating_peak_flow_per_area'].to_f == 0.0 && space_type['service_water_heating_peak_flow_rate'].to_f == 0.0) || space_type['service_water_heating_schedule'].nil?
@@ -360,7 +361,11 @@ class NECB2011
     # the hourly shw demand is for the following hour.  It is meant to determine, of the peak hourly shw times, which has
     # the highest shw demand the following hour.  This is used to determine shw capacity and volume.
     weekly_peak_flow.sort.each do |day_peak_sched|
-      day_peak_sched[1].sort.each_with_index do |hour_flow, hour_index|
+      # NOTE: this previously iterated `day_peak_sched[1].sort` — the SORTED
+      # hourly array — while using the (sorted) index against the UNSORTED
+      # arrays below, so the "hour after the peak" was effectively an arbitrary
+      # hour. The hourly array is now iterated in hour order.
+      day_peak_sched[1].each_with_index do |hour_flow, hour_index|
         if hour_flow == peak_flow_sched
           if hour_index == 23
             next_hour_test = 0

data/lib/openstudio-standards/standards/necb/NECB2015/data/surface_thermal_transmittance.json

@@ -0,0 +1,90 @@
+{
+  "tables": {
+    "surface_thermal_transmittance": {
+      "data_type": "table",
+      "notes": "Requires hdd to be defined to be evaluated in code. Never have ground windows or doors.",
+      "refs": [
+
+      ],
+      "units": "W_per_m2_K",
+      "table": {
+        "outdoors": {
+          "wall": {
+            "3000": 0.315,
+            "4000": 0.278,
+            "5000": 0.247,
+            "6000": 0.21,
+            "7000": 0.21,
+            "9999": 0.183
+          },
+          "roofceiling": {
+            "3000": 0.227,
+            "4000": 0.183,
+            "5000": 0.183,
+            "6000": 0.162,
+            "7000": 0.162,
+            "9999": 0.142
+          },
+          "floor": {
+            "3000": 0.227,
+            "4000": 0.183,
+            "5000": 0.183,
+            "6000": 0.162,
+            "7000": 0.162,
+            "9999": 0.142
+          },
+          "window": {
+            "3000": 2.4,
+            "4000": 2.2,
+            "5000": 2.2,
+            "6000": 2.2,
+            "7000": 2.2,
+            "9999": 1.6
+          },
+          "skylight": {
+            "3000": 2.4,
+            "4000": 2.2,
+            "5000": 2.2,
+            "6000": 2.2,
+            "7000": 2.2,
+            "9999": 1.6
+          },
+          "door": {
+            "3000": 2.4,
+            "4000": 2.2,
+            "5000": 2.2,
+            "6000": 2.2,
+            "7000": 2.2,
+            "9999": 1.6
+          }
+        },
+        "ground": {
+          "wall": {
+            "3000": 0.568,
+            "4000": 0.379,
+            "5000": 0.284,
+            "6000": 0.284,
+            "7000": 0.284,
+            "9999": 0.21
+          },
+          "roofceiling": {
+            "3000": 0.568,
+            "4000": 0.379,
+            "5000": 0.284,
+            "6000": 0.284,
+            "7000": 0.284,
+            "9999": 0.21
+          },
+          "floor": {
+            "3000": 0.757,
+            "4000": 0.757,
+            "5000": 0.757,
+            "6000": 0.757,
+            "7000": 0.757,
+            "9999": 0.379
+          }
+        }
+      }
+    }
+  }
+}

data/lib/openstudio-standards/standards/necb/NECB2015/necb_2015.rb

@@ -51,17 +51,18 @@ class NECB2015 < NECB2011
 
   def apply_loop_pump_power(model:, sizing_run_dir:)
     # NECB2015 Custom code
-    # Do another sizing run to take into account adjustments to equipment efficiency etc. on capacities. This was done primarily
-    # because the cooling tower loop capacity is affected by the chiller COP.  If the chiller COP is not properly set then
-    # the cooling tower loop capacity can be significantly off which will affect the NECB 2015 maximum loop pump capacity.  Found
-    # all sizing was off somewhat if the additional sizing run was not done.
+    # Do another sizing run to take into account adjustments to equipment
+    # efficiency etc. on capacities. This was done primarily because the cooling
+    # tower loop capacity is affected by the chiller COP. If the chiller COP is
+    # not properly set then the cooling tower loop capacity can be significantly
+    # off which will affect the NECB 2015 maximum loop pump capacity. Found all
+    # sizing was off somewhat if the additional sizing run was not done.
     if model_run_sizing_run(model, "#{sizing_run_dir}/SR2") == false
       raise('sizing run 2 failed!')
     end
 
     # Apply maxmimum loop pump power normalized by peak demand by served spaces as per NECB2015 5.2.6.3.(1)
     apply_maximum_loop_pump_power(model)
-    # model = BTAP::FileIO::remove_duplicate_materials_and_constructions(model)
     return model
   end
 
@@ -73,7 +74,8 @@ class NECB2015 < NECB2011
     if standards_space_type.include? 'Atrium' # @todo Note that since none of the archetypes has Atrium, this was tested for 'Dining'. #Atrium
       puts "#{standards_space_type} - has atrium" # space_type.name.to_s
       # puts space_height
-      if get_max_space_height_for_space_type(space_type: space_type) < 12.0
+      space_height = get_max_space_height_for_space_type(space_type: space_type)
+      if space_height < 12.0
         # @todo Regarding the below equations, identify which version of ASHRAE 90.1 was used in NECB2015.
         atrium_lpd_eq_smaller_12_intercept = 0
         atrium_lpd_eq_smaller_12_slope = 1.06

data/lib/openstudio-standards/standards/necb/NECB2017/data/surface_thermal_transmittance.json

@@ -10,48 +10,84 @@
         "NECB2017_S_3.2.3.1"
       ],
       "units": "W_per_m2_K",
-      "table": [
-        {
-          "boundary_condition": "Outdoors",
-          "surface": "Wall",
-          "formula": "( hdd < 3000) ? 0.315 : ( hdd < 4000) ? 0.278 : ( hdd < 5000 ) ? 0.247 : ( hdd < 6000) ? 0.210 :( hdd < 7000) ? 0.210 : 0.183"
+      "table": {
+        "outdoors": {
+          "wall": {
+            "3000": 0.315,
+            "4000": 0.278,
+            "5000": 0.247,
+            "6000": 0.21,
+            "7000": 0.21,
+            "9999": 0.183
+          },
+          "roofceiling": {
+            "3000": 0.193,
+            "4000": 0.156,
+            "5000": 0.156,
+            "6000": 0.138,
+            "7000": 0.138,
+            "9999": 0.121
+          },
+          "floor": {
+            "3000": 0.227,
+            "4000": 0.183,
+            "5000": 0.183,
+            "6000": 0.162,
+            "7000": 0.162,
+            "9999": 0.142
+          },
+          "window": {
+            "3000": 2.1,
+            "4000": 1.9,
+            "5000": 1.9,
+            "6000": 1.9,
+            "7000": 1.9,
+            "9999": 1.4
+          },
+          "skylight": {
+            "3000": 2.1,
+            "4000": 1.9,
+            "5000": 1.9,
+            "6000": 1.9,
+            "7000": 1.9,
+            "9999": 1.4
+          },
+          "door": {
+            "3000": 2.1,
+            "4000": 1.9,
+            "5000": 1.9,
+            "6000": 1.9,
+            "7000": 1.9,
+            "9999": 1.4
+          }
         },
-        {
-          "boundary_condition": "Outdoors",
-          "surface": "RoofCeiling",
-          "formula": "( hdd < 3000) ? 0.193 : ( hdd < 4000) ? 0.156 : ( hdd < 5000 ) ? 0.156 : ( hdd < 6000) ? 0.138 :( hdd < 7000) ? 0.138 : 0.121"
-        },
-        {
-          "boundary_condition": "Outdoors",
-          "surface": "Floor",
-          "formula": "( hdd < 3000) ? 0.227 : ( hdd < 4000) ? 0.183 : ( hdd < 5000 ) ? 0.183 : ( hdd < 6000) ? 0.162 :( hdd < 7000) ? 0.162 : 0.142"
-        },
-        {
-          "boundary_condition": "Outdoors",
-          "surface": "Window",
-          "formula": "( hdd < 3000) ? 2.100 : ( hdd < 7000) ? 1.900 : 1.400"
-        },
-        {
-          "boundary_condition": "Outdoors",
-          "surface": "Door",
-          "formula": "( hdd < 3000) ? 2.100 : ( hdd < 7000) ? 1.900 : 1.400"
-        },
-        {
-          "boundary_condition": "Ground",
-          "surface": "Wall",
-          "formula": "( hdd < 3000) ? 0.568 : ( hdd < 4000) ? 0.379 : ( hdd < 7000) ? 0.284 : 0.210"
-        },
-        {
-          "boundary_condition": "Ground",
-          "surface": "RoofCeiling",
-          "formula": "( hdd < 3000) ? 0.568 : ( hdd < 4000) ? 0.379 : ( hdd < 7000) ? 0.284 : 0.210"
-        },
-        {
-          "boundary_condition": "Ground",
-          "surface": "Floor",
-          "formula": "( hdd < 7000) ? 0.757 : 0.379"
+        "ground": {
+          "wall": {
+            "3000": 0.568,
+            "4000": 0.379,
+            "5000": 0.284,
+            "6000": 0.284,
+            "7000": 0.284,
+            "9999": 0.21
+          },
+          "roofceiling": {
+            "3000": 0.568,
+            "4000": 0.379,
+            "5000": 0.284,
+            "6000": 0.284,
+            "7000": 0.284,
+            "9999": 0.21
+          },
+          "floor": {
+            "3000": 0.757,
+            "4000": 0.757,
+            "5000": 0.757,
+            "6000": 0.757,
+            "7000": 0.757,
+            "9999": 0.379
+          }
         }
-      ]
+      }
     }
   }
 }

data/lib/openstudio-standards/standards/necb/NECB2017/necb_2017.rb

@@ -52,7 +52,8 @@ class NECB2017 < NECB2015
     if standards_space_type.include? 'Atrium' # @todo Note that since none of the archetypes has Atrium, this was tested for 'Dining'. #Atrium
       puts "#{standards_space_type} - has atrium" # space_type.name.to_s
       # puts space_height
-      if get_max_space_height_for_space_type(space_type: space_type) < 12.0
+      space_height = get_max_space_height_for_space_type(space_type: space_type)
+      if space_height < 12.0
         # @todo Regarding the below equations, identify which version of ASHRAE 90.1 was used in NECB2017.
         atrium_lpd_eq_smaller_12_intercept = 0
         atrium_lpd_eq_smaller_12_slope = 1.06